Commit Graph

106 Commits

Author SHA1 Message Date
thomas sarkanen
b0a0c4f126 Improve infinite loop handling in animation blueprints
Change early-out for exception handling to skip exceptions for all object types in preview worlds, not just actors. Also handle excpetions in this case when the debugger is attached to the object already (allows for break on exceptions to work).
Hook the BP exception delegate to disable ticking on the skeletal mesh component so we dont keep ticking runaway scripts
Tweaked thumbnail request to not submit the same asset multiple times - this happens multiple times on compilation and can cause longer hitches when the thumbnail is requested and ticked with an infinite loop in place.

#jira UE-188277
#rb dan.oconnor

[CL 26841618 by thomas sarkanen in ue5-main branch]
2023-08-04 04:35:00 -04:00
zach bethel
a9a5fa39db Deprecated non-command list variant of InitResource and UpdateResource. Patched the engine to pass command lists through. Follow-up CL's will refactor individual locations to thread command lists through the various callstacks, but that was done very judiciously in this CL to reduce risk.
#rb mihnea.balta, christopher.waters

[CL 25953623 by zach bethel in ue5-main branch]
2023-06-13 11:46:40 -04:00
zach bethel
6d657e92f1 Resubmitted InitDynamicRHI refactor with fixes for startup initialization.
[CL 25897584 by zach bethel in ue5-main branch]
2023-06-09 12:58:33 -04:00
zach bethel
f0efa3cf35 Undo refactor of InitDynamicRHI as there is a memory leak.
[CL 25872730 by zach bethel in ue5-main branch]
2023-06-08 11:34:52 -04:00
zach bethel
f84151acfa Deprecated {Init, Release}DynamicRHI in favor of just {Init, Release}RHI.
#rb luke.thatcher, christopher.waters, mihnea.balta

[CL 25859166 by zach bethel in ue5-main branch]
2023-06-07 17:33:37 -04:00
dave belanger
c5e1585469 Move around some asset thumbnail functionality (no change in logic)
Fixed EThumbnailTextureFlushMode::AlwaysFlush mode not fully working all the time (might be slower, but it's not used anywhere)
#rb Rex.Hill
#preflight 645c5391b71b8186aa2612d7

[CL 25429387 by dave belanger in ue5-main branch]
2023-05-11 12:18:57 -04:00
dave belanger
969891ce0c Fix bad merge in AssetThumbnail.cpp
[CL 25291667 by dave belanger in ue5-main branch]
2023-05-01 17:06:24 -04:00
dave belanger
d2106b5072 Prioritize thumbnail found from the on-disk package if it's cooked because the asset cannot change and rendering it without editor-only data might not give the same result as when it was rendered uncooked.
#rb julien.stjean,rex.hill
#preflight 644ff82a0e33f2d51d7cd064

[CL 25291627 by dave belanger in ue5-main branch]
2023-05-01 17:05:40 -04:00
aditya ravichandran
392da52168 Asset Thumbnails: Wait for rendering commands to finish before drawing the actual thumbnail
#rb JeanMichel.Dignard
#preflight 63ebcd247d2ec3d2fded1382

[CL 24224875 by aditya ravichandran in ue5-main branch]
2023-02-14 20:22:51 -05:00
aditya ravichandran
db59eb4a2c Content Browser: Improve UX around unsupported assets
#preflight 63e15a201020773a3f0f987e
#rb Lauren.Barnes, Julien.StJean

[CL 24040935 by aditya ravichandran in ue5-main branch]
2023-02-06 18:22:57 -05:00
dave belanger
d18637af45 Fix for pending kill asset reaching FAssetThumbnailPool::LoadThumbnail
#rb Jonathan.Bard
#preflight skip

[CL 23831904 by dave belanger in ue5-main branch]
2023-01-24 11:24:32 -05:00
dave belanger
ffc8ce987a Fix bad merge of AssetThumbnail.cpp in RES
#rb none
#jira none

[CL 23763302 by dave belanger in ue5-main branch]
2023-01-18 15:49:51 -05:00
dave belanger
5d9736ac63 Fixed regression fetching asset thumbnails from the package
#rb none
#preflight skip

[CL 23763261 by dave belanger in ue5-main branch]
2023-01-18 15:49:17 -05:00
Patrick Boutot
960459b5f2 Fix bad memory access in AssetThumbnail. ThumbnailMap was destroyed because it goes out of scope.
#rb lauren.barnes
#preflight none

[CL 23738130 by Patrick Boutot in ue5-main branch]
2023-01-17 10:17:43 -05:00
dave belanger
e6c979e7cc Fix custom thumbnails disappearing after GC
#rb Jason.Stasik
#preflight 63c2198a0225f00e14682a04

[CL 23710787 by dave belanger in ue5-main branch]
2023-01-14 10:27:52 -05:00
daren cheng
5d8250f0ec Add support for multiple thumbnail render frequencies.
Preparation changing default thumbnail render frequency.

#jira UE-169079
#preflight 63c08bc902024f93d8c1a650
#rb lauren.barnes, patrick.boutot, brooke.hubert

[CL 23673011 by daren cheng in ue5-main branch]
2023-01-12 20:50:24 -05:00
jeanmichel dignard
a13ec3a50c Fixed ThumbnailManager static exit
- There's a circular dependency between UThumbnailManager and FThumbnailPool where UThumbnailManager owns a FThumbnailPool and FThumbnailPool is registered to a delegate from UThumbnailManager.

#jira UE-169075
#rb danny.couture
#preflight 63655c285c51adc95ff49551

[CL 22998361 by jeanmichel dignard in ue5-main branch]
2022-11-04 19:37:36 -04:00
jeanmichel dignard
0f92c82ddf Asset Thumbnails
- Moved the thumbnail dirtying from FThumbnailPool to UThumbnailManager as it only needs to happen once per thumbnail, not once per pool.
- Prevent trying to dirty thumbnails in the asset package for generic thumbnails that don't get rendered.
- Prevent the reference viewer CDO from creating a thumbnail pool as it happens too early and isn't needed.

Saves around 20 seconds when entering PIE.

#rb danny.couture
#preflight 635febca6e6dca1fb4a0c589

[CL 22875433 by jeanmichel dignard in ue5-main branch]
2022-10-31 20:01:43 -04:00
bob tellez
e8d492cf06 [Backout] - CL22835964
[FYI] JeanMichel.Dignard
Original CL Desc
-----------------------------------------------------------------
Asset Thumbnails
- Moved the thumbnail dirtying from FThumbnailPool to UThumbnailManager as it only needs to happen once per thumbnail, not once per pool.
- Prevent trying to dirty thumbnails in the asset package for generic thumbnails that don't get rendered.

#rb danny.couture
#rnx

[CL 22850499 by bob tellez in ue5-main branch]
2022-10-29 01:53:12 -04:00
jeanmichel dignard
f7cb67e8f6 Asset Thumbnails
- Moved the thumbnail dirtying from FThumbnailPool to UThumbnailManager as it only needs to happen once per thumbnail, not once per pool.
- Prevent trying to dirty thumbnails in the asset package for generic thumbnails that don't get rendered.

#rb danny.couture
#rnx

[CL 22850390 by jeanmichel dignard in ue5-main branch]
2022-10-29 01:41:19 -04:00
rob gay
18e887e937 [MetaSounds] Fix/add missing new MetaSound type icons/thumbnails as well as play/stop overlays. Support for showing/filtering presets in ContentBrowser
#rb helen.yang julien.stjean
[REVIEW] helen.yang
#jira UE-168050
#preflight 635314707261e565c497645f

[CL 22786984 by rob gay in ue5-main branch]
2022-10-26 15:28:04 -04:00
dave jones2
70034eb577 UE-160860 - Fix UnrealEd Module truncation warnings
Part 2 of N

#jira UE-160860
#preflight 634451b56732684595b74177
#rb andrew.davidson

[CL 22601794 by dave jones2 in ue5-main branch]
2022-10-18 11:54:15 -04:00
Robert Millar
550595e2fc Fix missing thumbnails.
#rb none
#jira none
#preflight 631b7441967ffc68fb254f93

[CL 21924086 by Robert Millar in ue5-main branch]
2022-09-09 13:30:23 -04:00
Robert Millar
cc414a65b3 FNames containing asset paths are deprecated. FSoftObjectPath or FTopLevelAssetPath should be used instead.
Fixups for misc editor files.

#jira UE-161932
#rb matt.hoffman
#preflight 631a8b47967ffc68fbf81fbd

[CL 21909504 by Robert Millar in ue5-main branch]
2022-09-08 20:52:53 -04:00
Mateo Egey
f5746803ec Fixed unnecessary performance drain when doing interactive property changes.
Previously, the thumbnail of an object would be constantly dirtied while dragging, leading to poor editor performance

#jira none
#rb vincent.gauthier
#preflight skip

[CL 21200406 by Mateo Egey in ue5-main branch]
2022-07-21 10:03:25 -04:00