Commit Graph

220 Commits

Author SHA1 Message Date
jurre debaare
90f41f7031 CIS fixes following up on CL 26886518
[CL 26891783 by jurre debaare in ue5-main branch]
2023-08-07 14:03:42 -04:00
jurre debaare
bdeab34227 Added the 'concept' of common frame-rate to Animation Montages/Composites
- On load/change it tries to work out the highest compatible frame-rate across all the contained animation assets, and uses it as the sampling rate for the montage/composite itself
- If one or more assets are not compatible the sampling rate reverts back to 100000hz, and the user is informed about it
- Project wide option to enforce this, to be extended to other systems later, which will prevent the user from adding incompatible assets to a montage/composite
- CVar to mute warning on-load, useful for upgrading content without breaking validation
#jira UE-190813
#rb Thomas.sarkanen, Euan.Carmichael

[CL 26887867 by jurre debaare in ue5-main branch]
2023-08-07 12:41:26 -04:00
jaime cifuentes
2a50227a47 Fix for editor crash when closing one viewport while two viewports are open in persona
#jira UE-190703
#rb thomas.sarkanen

[CL 26771089 by jaime cifuentes in ue5-main branch]
2023-08-02 10:16:04 -04:00
jaime cifuentes
4b6bd3a72d Added 0.75 and custom speed to Animation Viewport ToolBar, for Animation Speed and TurnTable speed
#rb Thomas.Sarkanen
#jira UE-168709
#preflight 6443d21c0206a6e20fc7ad36

[CL 25161711 by jaime cifuentes in ue5-main branch]
2023-04-24 06:19:04 -04:00
kirill zorin
a469aafd78 Update callsites to prepare for upcoming TArray/TArrayView<TObjectPtr<...>> restrictions
#rb zousar.shaker
#rb devin.doucette
#rb steve.robb
#rb robert.manuszewski
#rb saam.barati
#preflight 643f4c09a35280ed4f53ccb3

[CL 25100071 by kirill zorin in ue5-main branch]
2023-04-18 22:39:29 -04:00
florin pascu
a7d89de504 Revert 24046871 so current ScreenSize is calculated per frame in EditorViewport and not static to the per platform value
#rb Jack.Porter
#jira UE-175594
#preflight 642187e67703a8de3d902dc1

[CL 24815602 by florin pascu in ue5-main branch]
2023-03-28 04:20:11 -04:00
benoit gadreau
b3ef14a942 Focus bone selection (missing file, follow-up of 24483126)
#jira UE-178950
#rb kiaran.ritchie
#preflight 640f003c482188d7102a58b6

[CL 24691878 by benoit gadreau in ue5-main branch]
2023-03-17 13:20:41 -04:00
jurre debaare
adf000b658 CIS Editor Error: SkeletonSelectionEditMode.h(45): error C4430: missing type specifier - int assumed
#rb none
#preflight 640f2cb9c41a0a2a77adc283

[CL 24613658 by jurre debaare in ue5-main branch]
2023-03-13 11:44:12 -04:00
joseph sozio
69c0a8222f [Backout] - CL24610412
[FYI] Jurre.deBaare
Original CL Desc
-----------------------------------------------------------------
Improved Skeleton reference pose drawing behaviour
- Allow for drawing sub-set of bones (through selection)
- Bone/socket details now pull correct data from reference skeleton
#preflight 6409dd42a450329d6c2d59b1
#rb Thomas.Sarkanen, Kiaran.Ritchie

[CL 24612076 by joseph sozio in ue5-main branch]
2023-03-13 09:59:51 -04:00
jurre debaare
cb45e0202d Improved Skeleton reference pose drawing behaviour
- Allow for drawing sub-set of bones (through selection)
- Bone/socket details now pull correct data from reference skeleton
#preflight 6409dd42a450329d6c2d59b1
#rb Thomas.Sarkanen, Kiaran.Ritchie

[CL 24610735 by jurre debaare in ue5-main branch]
2023-03-13 07:31:42 -04:00
jurre debaare
3a47e695c5 Rejig viewport bone drawsing code to satisfy static analysis and simplify flow
#rb none
#preflight 63f74af77064074bd8fa4d54

[CL 24386121 by jurre debaare in ue5-main branch]
2023-02-23 14:25:14 -05:00
jurre debaare
a8288a24a6 Persona - No option to view Just the Skeleton Reference Pose
#feature when previewing an animation asset with no preview Skeletal Mesh set + having Show All hierarchy enabled we now show the skeleton reference pose instead of an empty viewport
#rb Kiaran.Ritchie, Halfdan.Ingvarsson
#preflight 63f5e54a7064074bd87f7a0f

[CL 24359163 by jurre debaare in ue5-main branch]
2023-02-22 07:37:44 -05:00
jurre debaare
9c7934ae35 Improve Pose Asset GUID caching behaviour. Whenever the user performs an action that invalidates the data, and therefore the comparison - the GUID will be cleared and exempted from future comparisons. Actions include:
- Removing a pose
    - Adding an additional pose
    - Update an existing pose with current view-port pose
#misc dynamic button label, depending on whether or not user will be updating the poses (GUID out-of-date), or restoring the poses (GUID invalidated)
#preflight 63e6287f8917c5deac673480
#rb Thomas.Sarkanen

[CL 24173354 by jurre debaare in ue5-main branch]
2023-02-13 08:39:19 -05:00
florin pascu
5c211850a0 Avoid copying TMap every frame
#rb Jack.Porter
#preflight 63e10dc2244dc45a20da758c

[CL 24040235 by florin pascu in ue5-main branch]
2023-02-06 18:00:39 -05:00
florin pascu
73966b18e5 Make ScreenSize update in MobilePreview for the selected LOD
#jira UE-175594
#preflight 63e0f063fe33a0659431e252

[CL 24036708 by florin pascu in ue5-main branch]
2023-02-06 15:00:10 -05:00
jaime cifuentes
5a4ee5a500 Editor Fix : Persona PreviewMesh crash when a preview skeletal mesh executes a raw delegate on an already destroyed object
#rb thomas.sarkanen
#preflight 638793dc4004f73f6240ce87

[CL 23338142 by jaime cifuentes in ue5-main branch]
2022-11-30 14:29:37 -05:00
Jurre deBaare
38e431f722 //UE5/Release-5.1 - Build ContentExamples Win64 - Warning: PoseAsset is out-of-date with its source animation
- Use SmartName display name rather than UID when generating data model GUID
   - Defer PoseAsset out-of-date warning until next resave
#jira UE-163780
#rb Thomas.Sarkanen
#preflight 6377575533774509005eacd6

[CL 23191972 by Jurre deBaare in ue5-main branch]
2022-11-18 05:35:10 -05:00
timothy daoust
8ab610676d Fixed an issue where LOD bones did not display correctly in the Animation Editor Viewport
#rb alexis.matte
#preflight 635fd1c1df01edd14996ad29

[CL 22994738 by timothy daoust in ue5-main branch]
2022-11-04 16:41:06 -04:00
henrik karlsson
b5b86c796c This change is a strategical submit for a coming change that removes lots of includes in headers that are included by many files. This change contains adding of includes in files that previously got those includes transitively from other inclkudes
#preflight 6355d4940313c24974b2107b
#rb none

[CL 22783162 by henrik karlsson in ue5-main branch]
2022-10-26 12:57:32 -04:00
Jurre deBaare
67babaec16 ANIM-RT truncation fixes - Persona
#jira UE-166635
#rb Jaime.Cifuentes, Thomas.Sarkanen
#preflight 63513298047f3570addbcffe

[CL 22653074 by Jurre deBaare in ue5-main branch]
2022-10-20 07:59:06 -04:00
alexis matte
fe35eb697a Interchange:
- Skeletal mesh is now import using the skeletalmesh compile system to make sure all properties are locked and will stall another thread trying to access them.
---- This fix multiple crash if a viewer display the skeletal mesh and use some properties.
- Remove animation pipeline ensure(no skeleton) if we import with force static mesh and there is some translated animation node
- Fix crash when importing static mesh and the get mesh payload return an empty mesh description
- Reimport of skeletalmesh is not calling anymore postedit change if we reimport with interchange, interchange will call it in a post edit step.
---- This fix multiple crash if a viewer display the bones of the re-import skeletal mesh.
General:
- Reimport handler now have a reimport async version so the caller can control if a reimport is done asynchronously or synchronously

#jira UE-166986
#rb danny.couture , jeanluc.corenthin
#rnx
#lockdown jeanmichel.dignard
#preflight 634f61fdec03b54e9cdfe0bf

[CL 22634973 by alexis matte in ue5-main branch]
2022-10-19 15:15:54 -04:00
alexis matte
2b6472582d Fix crash when deleting a material slot on a mesh containing morph targets.
#rb benoit.deschenes
#rnx
#preflight 633d9e994a2cd8f4b2a0dcca

[CL 22388927 by alexis matte in ue5-main branch]
2022-10-06 20:13:31 -04:00
jaime cifuentes
7e873e5c17 FAnimationViewportClient: Fix for crash closing the editor, due to memory use after delete at AssetEditorModeManager.cpp (preview was already deleted when trying to get preview world)
#rb [at]thomas.sarkanen
#jira UE-165693
#preflight 633c33c590619e836219de30
#lockdown Laurent.Delayen

[CL 22331178 by jaime cifuentes in ue5-main branch]
2022-10-04 11:17:27 -04:00
lucas dower
3a97a65c2d Crash fix when drawing pose watches on skeletal mesh components
* No longer dereference pose watch UObject while in render thread, render data is instead mirrored before drawing on the render thread to prevent being modified in a worker thread.
* Cleanup of pose watch WITH_ENGINE ifdefs.

#jira UE-162374
[FYI] danny.chapman
#rb thomas.sarkanen
#preflight 632437858131e92d65ce2f55

[CL 22050342 by lucas dower in ue5-main branch]
2022-09-16 11:34:43 -04:00
kiaran ritchie
11c4a3cd65 Fixing issue, bone drawing modes don't immediately update if you click inside the radio button.
#rb trivial
#JIRA https://jira.it.epicgames.com/browse/UE-162190
#preflight
#preflight 6321214b9677b738f4b8ce2a

[CL 21996884 by kiaran ritchie in ue5-main branch]
2022-09-13 20:48:52 -04:00