Commit Graph

899 Commits

Author SHA1 Message Date
chris tchou
d1145fa8e6 Fix spelling error in landscape tool tip
#rb trivial

[CL 27832910 by chris tchou in ue5-main branch]
2023-09-13 11:22:53 -04:00
luc eygasier
3c52b7ef37 Fixes new landscape location/rotation/scale reset to default button not showing up when using the gizmos.
Adds LandscapeEditor DetailsView RightColumnMinWidth to allow ResetToDefault button to be properly hit testable.

#rb Jonathan.Bard
#jira UE-194977

[CL 27828563 by luc eygasier in ue5-main branch]
2023-09-13 09:40:34 -04:00
luc eygasier
bfab9cf037 Updates Landscape editor icons (BP Brush affects Heightmap/Weightmap/VisibilityLayer).
Changes buttons to toggle buttons for landscape editor BP brushes affecting layers features.
Updates landscape editor target list colors, padding, text color to reflect UE5 style.

#rb Jonathan.Bard

[CL 27346857 by luc eygasier in ue5-main branch]
2023-08-24 12:49:20 -04:00
don boogert
8ae36d3057 Landscape: Fix duplicate localization key
#rb trivial

[CL 26906483 by don boogert in ue5-main branch]
2023-08-07 20:01:44 -04:00
don boogert
97d6069c92 Landscape : Better handling of 8 bit images for heights and 16 bit images for weights.
Allows for reading 8bit images for heights and 16bit images for weights.

#rb jonathan.bard

[CL 26898588 by don boogert in ue5-main branch]
2023-08-07 16:50:13 -04:00
Giorgi Apriashvili
9fe59c3c9f Fix for Warning in FortniteEditor Static Analysis Win64 (MSVC): WaterInLandscapeEditLayerTests
#jira FORT-637488
#rb jerome.delattre

[CL 26838841 by Giorgi Apriashvili in ue5-main branch]
2023-08-04 01:24:17 -04:00
chris tchou
5e7a9d1dd4 In FLandscapeBrushCircle, moved cleanup of stale weak object ptrs entries for both BrushMaterialInstanceMap and BrushMaterialComponents from AddReferencedObjects to Tick.
The issue was caused by the cleanup of BrushMaterialInstanceMap which could remove entries from the map if the value (i.e. the material instance) got stale, while keeping the corresponding entry in the BrushMaterialComponents (since the landscape component itself was still perfectly fine), which led to an assert/crash in Tick, when we were trying to remove entries from the map, assuming there was one for each component in BrushMaterialComponents.

Now we first cleanup BrushMaterialInstanceMap from stale keys (i.e. null landscape component weak object ptrs) and then also cleanup stale entries in BrushMaterialFreeInstances. BrushMaterialComponents doesn't need to be cleaned up because of the way the code already works, at the end of the Tick it only contains valid components.


#rb Roey.Borsteinas

[CL 26817714 by chris tchou in ue5-main branch]
2023-08-03 13:40:25 -04:00
roey borsteinas
484df4620f Landscape: fixed loctext with same key having different strings.
#jira UE-191968
#rb trivial

[CL 26813435 by roey borsteinas in ue5-main branch]
2023-08-03 11:58:54 -04:00
don boogert
e2407cc4b6 Landscape : Fix crash on large landscape creation
#rb chris.tchou
#jira UE-182978

[CL 26790753 by don boogert in ue5-main branch]
2023-08-02 18:25:31 -04:00
don boogert
a0f97dc405 Landscape : Fixed Landscape Import of .raw files
#rb chris.tchou
#jira UE-181255

[CL 26789171 by don boogert in ue5-main branch]
2023-08-02 17:37:59 -04:00
Giorgi Apriashvili
b55dc98aa1 Verify that creating a Water Body Actor creates a new Landscape Edit Layer called Water
#jira UEENGQA-98975
#rb jerome.delattre

[CL 26737576 by Giorgi Apriashvili in ue5-main branch]
2023-08-01 09:54:40 -04:00
chris tchou
511cc2f3c2 Add an option for landscape splines to always auto-rotate "forward" (i.e. don't reverse directions). This only applies when there are exactly two spline segments connected to a control point; otherwise it falls back on the old behavior.
Original review in UE5/main branch: https://p4-swarm.epicgames.net/reviews/26543334

#rb don.boogert

[CL 26615455 by chris tchou in ue5-main branch]
2023-07-26 14:17:29 -04:00
don boogert
8100e1b04d Landscape: Fix crash when creating multiple landscapes with regions
#rb trivial

[CL 26527045 by don boogert in ue5-main branch]
2023-07-21 17:34:24 -04:00
chris tchou
b147d8ac6e Make all landscape usage of TSet and TMaps with Weak Object Ptr Keys use the proper Funcs
#rb jonathan.bard
#jira FORT-627060

[CL 26514512 by chris tchou in ue5-main branch]
2023-07-21 11:57:55 -04:00
chris tchou
4cead8998c Potential fix for rare crash in landscape circle brush
#rb don.boogert
#jira FORT-627060

[CL 26487685 by chris tchou in ue5-main branch]
2023-07-20 11:51:56 -04:00
chris tchou
b64f82888a Fix for crash exiting landscape editor import/export panel:
Though I only see crashes reported for ImportExport.cpp, I fixed a few similar issues in other detail panels.  The majority of the other detail panels already follow this convention of dynamically checking for null.

#rb jonathan.bard
#jira UE-187985, UE-156454

[CL 26351532 by chris tchou in ue5-main branch]
2023-06-30 14:59:55 -04:00
don boogert
7ea61e861a Landscape : Don't create a Transaction when creating a landscape with regions
#rb chris.tchou jonathan.bard
#jira UE-187241

[CL 26267557 by don boogert in ue5-main branch]
2023-06-27 15:23:56 -04:00
chris tchou
f4e353b8b0 Resize operation was not preserving all relevant landscape settings
Now uses CopySharedProperties to copy the bulk of the settings over.
Advantage is that this should automatically pick up any new settings properties we add in the future.

I added additional copies to handle the remaining settings.  In the future we might want to consider converting these to be shared properties as well.  Or if not shared, at least flag them as settings properties, so we can include them in the automatic copy here.

#rb jonathan.bard, luc.eygasier
#jira UE-173099

[CL 26188313 by chris tchou in ue5-main branch]
2023-06-22 14:16:08 -04:00
joe kirchoff
fc49b3b34f Fix C4855: implicit capture of 'this' via '[=]' is deprecated in '/std:c++20'
#rnx

[CL 26110412 by joe kirchoff in ue5-main branch]
2023-06-19 19:55:34 -04:00
sebastien lussier
d237f76eea Added getter/setter for APartitionedActor::GridSize
* Setter will log an error if GridSize is 0
* Deprecated GridSize, will ultimately be made private
#rb jeanfrancois.dube, richard.malo

[CL 26081899 by sebastien lussier in ue5-main branch]
2023-06-17 16:08:13 -04:00
don boogert
44eeec4416 Landscape : Correct automation test locations in hierarchy
#rb trivial
#pf none

[CL 25999474 by don boogert in ue5-main branch]
2023-06-14 19:06:02 -04:00
don boogert
7233e57493 Landscape : Testing - Added a simple import test.
#rb jerome.delattre
#rb jonathan.bard

[CL 25945881 by don boogert in ue5-main branch]
2023-06-13 00:08:20 -04:00
don boogert
520fb24249 Landscape : Fix LansscapeProxies being preventend from being unloaded when in LandscapeMode sculpt or paint mode
#jira UE-185724
#rb jonathan.bard

[CL 25943178 by don boogert in ue5-main branch]
2023-06-12 19:03:04 -04:00
don boogert
2b96e3b9ba Landscape : fix import of non u16 greyscale images to landscape height
#rb jonathan.bard

[CL 25860109 by don boogert in ue5-main branch]
2023-06-07 17:56:00 -04:00
chris tchou
4c181f3489 Fix potential overflow security issue importing landscape PNG files
#rb don.boogert, jonathan.bard
#jira UE-172842, UE-172835

[CL 25833042 by chris tchou in ue5-main branch]
2023-06-06 19:46:33 -04:00