Commit Graph

369 Commits

Author SHA1 Message Date
patrick enfedaque
04688ff566 Foliage Erase: Fix erasing when using grid foliage (World Partition)
- DesiredInstanceCount is global to brush sphere so we need to calculate a Potential instances to remove global to the sphere and not local to each intersecting IFA

#rb richard.malo
#rnx

[CL 27877112 by patrick enfedaque in ue5-main branch]
2023-09-14 09:47:54 -04:00
steve robb
51f3ea53ae Removed ChooseClass.h includes.
#rb trivial

[CL 27823723 by steve robb in ue5-main branch]
2023-09-13 05:43:01 -04:00
patrick enfedaque
0f5d4f243a MoveSelectedFoliageToActorEditorContext: Add missing transaction scope
#rb none
#rnx

[CL 27316026 by patrick enfedaque in ue5-main branch]
2023-08-23 15:16:48 -04:00
patrick enfedaque
c13ecc4fec Foliage Fixes:
- Use FScopedActorEditorContextFromActor for operations which need to use the same context as the Source actor
- Update Move Tool to allow Move to current Actor Editor Context. (Allows changing DataLayers / ContentBundle for selected instances)

#rb richard.malo
#rnx

[CL 27315792 by patrick enfedaque in ue5-main branch]
2023-08-23 15:11:58 -04:00
patrick enfedaque
dd7ec9fd93 [Backout] - CL27276715
[FYI] Patrick.Enfedaque
Original CL Desc
-----------------------------------------------------------------
Foliage: Fix use cases where moving existing foliage with an active DataLayer context would make that moved foliage part of the DataLayer

- Add Optional FDataLayerEditorContext param to FActorPartitionGetParams
- Add a FForEachRelevantActorParams so that UActorPartitionSubSystem::ForEachRelevantActor can also be filtered by Guid/DataLayer Editor Context
- This will allow upcoming change of the Move tool so that it can move Foliage from one DL context to another.

#rb richard.malo
#rnx

[CL 27283947 by patrick enfedaque in ue5-main branch]
2023-08-22 16:08:29 -04:00
patrick enfedaque
bc22137c64 Foliage: Fix use cases where moving existing foliage with an active DataLayer context would make that moved foliage part of the DataLayer
- Add Optional FDataLayerEditorContext param to FActorPartitionGetParams
- Add a FForEachRelevantActorParams so that UActorPartitionSubSystem::ForEachRelevantActor can also be filtered by Guid/DataLayer Editor Context
- This will allow upcoming change of the Move tool so that it can move Foliage from one DL context to another.

#rb richard.malo
#rnx

[CL 27277708 by patrick enfedaque in ue5-main branch]
2023-08-22 13:15:44 -04:00
patrick enfedaque
80eb11dc50 Foliage Mode: SupportF ExternalContentDragDropOp
- Also use ContentBrowserModule SaveAssetDialog instead of the limited SDlgPickAssetPath dialog

#rb sebastien.lussier
#rnx

[CL 27199631 by patrick enfedaque in ue5-main branch]
2023-08-18 08:13:46 -04:00
patrick enfedaque
13f3df4a3b Foliage Mode: Filter out Cooked Foliage types until we have a better way of identifying public/private assets
#rb richard.malo
[FYI] dave.belanger
#rnx

[CL 26572494 by patrick enfedaque in ue5-main branch]
2023-07-25 10:14:45 -04:00
joe kirchoff
fc49b3b34f Fix C4855: implicit capture of 'this' via '[=]' is deprecated in '/std:c++20'
#rnx

[CL 26110412 by joe kirchoff in ue5-main branch]
2023-06-19 19:55:34 -04:00
chris tchou
f3423484c2 We are seeing rare crashes in this check that there are no transactions active when exiting foliage edit mode.
No known repro steps, and unclear what circumstances trigger it.

I'm converting it to an ensure, so at least it doesn't crash, and adding more information so we know what transaction is active.

#rb jonathan.bard
#jira UE-188001

[CL 25900512 by chris tchou in ue5-main branch]
2023-06-09 14:47:02 -04:00
kirill zorin
de8db5ff76 Converting ARO-facing raw pointers to TObjectPtr ahead of raw pointer ARO API deprecation.
#rb zousar.shaker
#rb markus.breyer
#rb robert.manuszewski

#preflight 646391406b1406b54ab15460

[CL 25489627 by kirill zorin in ue5-main branch]
2023-05-16 10:52:49 -04:00
patrick enfedaque
3702d7a055 Foliage: Fix Foliage not following base component in WP map
- Move management into editor subsystem to split the moving and partitioning in two phases which fixes the issue

#jira UE-184366
#rb richard.malo
#preflight 645153a9de576521224056ad
#rnx

[CL 25321932 by patrick enfedaque in ue5-main branch]
2023-05-03 14:47:21 -04:00
patrick enfedaque
7c660fe9d2 FoliageEdMode: Fix rare crash occurence with zero delta where a Move + Selection was done in the same tracking (UDN report)
FEditorViewportClient still misses some clicks with very subtle mouse movements

#rb richard.malo
#preflight skip

[CL 24872981 by patrick enfedaque in ue5-main branch]
2023-03-31 12:05:02 -04:00
chris tchou
4492bf9779 Fix for Instanced Foliage paint brush taking a very long time when the Radius option is used.
With settings:
brush size: 4000
brush paint density: 1
density: 400
radius: 100000

Original Time:  20 minutes 37 seconds
New Time: 112 ms

#rb jonathan.bard
#jira UE-172097
#preflight 63f010d652460c3a1f6590e9

[CL 24316939 by chris tchou in ue5-main branch]
2023-02-20 12:08:19 -05:00
richard malo
e280eb523d Foliage Actor type was not available in the Foliage palette even for non-partitioned worlds.
#rb patrick.enfedaque, jeanfrancois.dube

[CL 23662402 by richard malo in ue5-main branch]
2023-01-12 09:37:52 -05:00
luc eygasier
b521e678d3 Removes TLazyObjectPtr usage in ALandscapeStreamingProxy, ULandscapeInfo, ULandscapeComponent, ULandscapeHeightfieldCollisionComponent.
Adds package deprecation and fixup mechanism to allow users to update fixedup packages.
Fixes Guid Remapping inTLazyObjectPtr asserting when multiple PIE sessions

#rb Jonathan.Bard
#preflight 63b49c2c35203bc7aacb1d15
#jira UE-156921

[CL 23631796 by luc eygasier in ue5-main branch]
2023-01-10 15:22:05 -05:00
michael balzer
035933e7b5 USplineMeshComponent: Rename GetAxisValue to GetAxisValueRef
#jira UE-172739
#9909
#preflight 639a76b38c64c74ac832d17c

[CL 23538907 by michael balzer in ue5-main branch]
2022-12-16 12:11:09 -05:00
Charles deRousiers
5c44593f0d Abstract blendmode lookup to ease blend mode compatibility with Strata.
#rb sebastien.hillaire
#jira none
#preflight 6398964335203bc7aa695e10

[CL 23492252 by Charles deRousiers in ue5-main branch]
2022-12-13 10:44:43 -05:00
Patrick Enfedaque
39e24d7aad Foliage & FoliageEdit modules: UnsafeTypeCastWarningLevel
#jira none
#rb richard.malo, jeanfrancois.dube
#fyi andrew.davidson, vincent.beauchemin
#preflight 63750e328f4cb2e4dc4ca0d3
#rnx

[CL 23155695 by Patrick Enfedaque in ue5-main branch]
2022-11-16 11:51:27 -05:00
henrik karlsson
b5b86c796c This change is a strategical submit for a coming change that removes lots of includes in headers that are included by many files. This change contains adding of includes in files that previously got those includes transitively from other inclkudes
#preflight 6355d4940313c24974b2107b
#rb none

[CL 22783162 by henrik karlsson in ue5-main branch]
2022-10-26 12:57:32 -04:00
yohann dossantos
0cdcf34e7c Fixing a regression in the Foliage editor, due to a bad combination of splitter vs scrollbox.
When a foliage asset was selected the splitter was requested a lot more space, which was granted starting with CL20995097 (addition of a scrollbox).
The issue was that the handle of the splitter is using a ratio of the splitter total size to position itself, so increasing the size a lot was also moving the handle a lot, assigning far too much space to the foliage asset list view, while the details view was far below.
The fix removes the splitter, and instead piggy back on the vertical box that was already there, and use an autosize/max height slot for the tileview, thus removing the need for a user manual move of splitter's handle.

#jira UE-166026
#rb patrick.enfedaque
#preflight 6352bb553a547c3da3783269
#lockdown jeanmichel.dignard

[CL 22710500 by yohann dossantos in ue5-main branch]
2022-10-22 07:14:17 -04:00
patrick enfedaque
f74f229adb Foliage: Fix instances not being moved to different cell when moved through base component
#jira UE-157379
#rb richard.malo
#preflight 632858911c7511917a88377d

[CL 22084756 by patrick enfedaque in ue5-main branch]
2022-09-19 19:53:18 -04:00
Philippe DeSeve
f6ac4963d7 Remove unused data layer label
#rb richard.malo
#jira UE-163472
#preflight none

[CL 21965427 by Philippe DeSeve in ue5-main branch]
2022-09-12 10:44:16 -04:00
bryan sefcik
b93a6cf7ed Pass 1 on editor include fixes:
Removed redundant private include paths from build.cs files.
Fixed include paths to be relative to the private or public folders.
Hid or removed includes that reached into other private module folders.
Updated PublicInclude paths when necessary.

#jira
#preflight 631e283bec5b0c765fc0ffdb

[CL 21960084 by bryan sefcik in ue5-main branch]
2022-09-11 18:33:06 -04:00
bryan sefcik
0837230669 Ran IWYU again on half of the Engine/Source/Editor/... source files.
#jira

[CL 21716414 by bryan sefcik in ue5-main branch]
2022-08-30 23:03:03 -04:00