Commit Graph

89 Commits

Author SHA1 Message Date
helge mathee
308d55d9b9 RigVM / ControlRig: Fix direct manipulation during PIE
#rb jaime.cifuentes
#jira UE-192171

[CL 27371219 by helge mathee in ue5-main branch]
2023-08-25 05:02:24 -04:00
robert manuszewski
d3991fec9b Fixing potential compile errors ahead of enabling TObjectPtr GC barrier
#rb trivial

[CL 26868625 by robert manuszewski in ue5-main branch]
2023-08-05 06:09:54 -04:00
thomas sarkanen
b0a0c4f126 Improve infinite loop handling in animation blueprints
Change early-out for exception handling to skip exceptions for all object types in preview worlds, not just actors. Also handle excpetions in this case when the debugger is attached to the object already (allows for break on exceptions to work).
Hook the BP exception delegate to disable ticking on the skeletal mesh component so we dont keep ticking runaway scripts
Tweaked thumbnail request to not submit the same asset multiple times - this happens multiple times on compilation and can cause longer hitches when the thumbnail is requested and ticked with an infinite loop in place.

#jira UE-188277
#rb dan.oconnor

[CL 26841618 by thomas sarkanen in ue5-main branch]
2023-08-04 04:35:00 -04:00
jaime cifuentes
2a50227a47 Fix for editor crash when closing one viewport while two viewports are open in persona
#jira UE-190703
#rb thomas.sarkanen

[CL 26771089 by jaime cifuentes in ue5-main branch]
2023-08-02 10:16:04 -04:00
thomas sarkanen
6cfb3173aa Fix preview instance not being re-selecteable after selecting an external anim instance to debug
#jira UE-190521
#rb jose.villarroel

[CL 26506645 by thomas sarkanen in ue5-main branch]
2023-07-21 04:59:49 -04:00
Thomas Sarkanen
cade535b0a Fixed crash opening a template animation blueprint with curves tab open
#jira none
#rb Jurre.deBaare
#preflight 6421aae47703a8de3d9a0890

[CL 24803198 by Thomas Sarkanen in ue5-main branch]
2023-03-27 11:11:05 -04:00
Thomas Sarkanen
502797ca50 Animation Curve Runtime & Editor Improvements
Runtime notes:
- Removes 'smart name' usage across the animation systems.
- Changed curve blending from a uniform array (sized per skeleton) to a sparse array of sorted named values. Blends and other combiners are performed using a dual iteration 'tape merge'.
- Skeleton curves are no longer guaranteed to cover all curve names that can be found at runtime.

Editor notes:
- Curve metadata (flags, bone links etc.) is still present on the skeleton, but can also now exist on a skeletal mesh
- Curve metadata (for morph targets) is still populated on import
- Curves can now be used arbitrarily at runtime

New features:
- New Find/Replace dialog that allows for batch-replacing curves and notifies across all of a project's assets
- New curve debugger tab in various Persona editors that allows for viewing curve values live. This also now allows viewing curves for specific pose watches.
- Pose watches now output curve tracks to the Rewind Debugger

#rb Jurre.deBaare,Nicholas.Frechette,Sara.Schvartzman,Helge.Mathee,Kiaran.Ritchie,Jaime.Cifuentes,Martin.Wilson,Keith.Yerex,Andrean.Franc (and more!)
#jira UE-167776
#jira UE-173716
#jira UE-110407
#preflight 63fc98c81206d91a2bc3ab90
#preflight 63f3ad4f81646f1f24c240c2

[CL 24421496 by Thomas Sarkanen in ue5-main branch]
2023-02-27 07:20:58 -05:00
Nicholas Frechette
230e9f42b3 Add missing anim BP template features now that skeleton compatibility has been relaxed
#jira UE-168846
#rb Thomas.Sarkanen
#preflight 63752a6c1c114bec050b9127

[CL 23157954 by Nicholas Frechette in ue5-main branch]
2022-11-16 13:30:40 -05:00
Thomas Sarkanen
d9c2b172f7 Skeleton compatibility improvements
Skeleton compatibility is now bi-directional. Specifying a compatible skeleton A -> B now implies B -> A.
Skeleton compatibility is now an editor-only concern. The runtime will attempt to do the 'best it can' via name -> name mappings. Only the editor will prevent assigning incompatible skeletons in (e.g.) asset pickers etc.
Skeleton compatibility checks in editor can now be disabled in the editor preferences (and each asset picker now has a checkbox option in its view settings that allows for quick access to this).

Moves FSkeletonRemapping to its own file (which is now private).
Skeleton remappings are now generated on demand on worker threads just before animation decompression and stored in a registry, guarded by FRWScopeLock for thread-safety.

Fixed some anim BP compiler edge cases where asset references on pins were not getting preloaded correctly, causing skeletons to be erroneously reported as missing.

Exposed the current asset registry filter in SAssetView so that menu extensions can access it (and use it to provide context)

#jira UE-166054
#jira UE-167355
#rb Jurre.deBaare,John.vanderBerg
#preflight 635902602e6690262afa86f9

[CL 22878911 by Thomas Sarkanen in ue5-main branch]
2022-11-01 06:25:59 -04:00
lucas dower
6bce8973c5 Fixed crash when attempting to draw pose-watched anim nodes which use custom edit modes such as 'Two Bone IK' and 'Transform (Modify) Bones'.
* Only nodes which have been setup to have drawable elements should be drawn when pose watched, such as 'RigidBody'.
* Anim nodes with custom edit modes should only draw their widgets when explicitly selected or override IAnimNodeEditMode::SupportsPoseWatch

#jira 165766
#rb thomas.sarkanen
#preflight 63514130047f3570adddd035

[CL 22655755 by lucas dower in ue5-main branch]
2022-10-20 10:42:00 -04:00
bryan sefcik
483f93dc1a Fixed misc include paths
#jira
#preflight 634f491669246074dbb2719d

[CL 22633214 by bryan sefcik in ue5-main branch]
2022-10-19 14:38:31 -04:00
eric knapik
ebeb6781c1 Animation BP toolbar trimming & permissions
* Tab filters are now applied before tab widgets before are created for animation blueprint editor instead of only when a user tries opening a new tab. This prevents disallowed tabs in default layouts being created.
* Event graph documents are not opened if event graph permissions are disabled when loading blueprint editor.
* Added new blueprint permission to optionally disable function overrides.

#rb thomas.sarkanen
#preflight 6346928ef04e6f8505f7b879

[CL 22547860 by eric knapik in ue5-main branch]
2022-10-15 02:13:23 -04:00
lucas dower
a5b975ca24 Fix for Persona mesh details text overlay blocking hit tests
* Fix for Persona mesh sections showing as selectable when not.
* Fix for editor viewport cursor style not updating if using orbit camera mode.

#jira UE-157811
#rb thomas.sarkanen
#preflight 63246538ea1c94f4c5b3dfc7

[CL 22052213 by lucas dower in ue5-main branch]
2022-09-16 12:44:00 -04:00
thomas sarkanen
772a44e8b6 Fixed crash deleting a blendspace node
Guarded against a null graph selection in IsEditable()

#jira UE-159116
#rb Jurre.deBaare
#preflight 632323873523d263aa159a86

[CL 22035592 by thomas sarkanen in ue5-main branch]
2022-09-15 15:09:24 -04:00
kiaran ritchie
9ece7682e8 Adding "Preview Scene Settings" tabs to IK Rig & Retarget editors.
This change also added a delegate to FPersonaToolkitArgs with reference to a IDetailBuilderLayout so assets can customize the Preview Scene Settings.

#JIRA https://jira.it.epicgames.com/browse/UE-148894
#rb halfdan.ingvarsson
#preflight
#preflight 631b7a00967ffc68fb262e06

[CL 21924418 by kiaran ritchie in ue5-main branch]
2022-09-09 13:58:03 -04:00
frederick lupien
63fd57b194 Add a context menu option to unexpose all unused pins in LinkedAnimGraph and LinkedAnimLayer nodes in animation blueprints
This is to be able to quickly hide all pins on linked graph nodes based on animation instance that expose a lot of properties

[REVIEW] [at]Thomas.Sarkanen
#tests PIE
#jira UE-156233
[FYI] [at]Paul.McLaurin

[CL 21908860 by frederick lupien in ue5-main branch]
2022-09-08 20:30:49 -04:00
bryan sefcik
0837230669 Ran IWYU again on half of the Engine/Source/Editor/... source files.
#jira

[CL 21716414 by bryan sefcik in ue5-main branch]
2022-08-30 23:03:03 -04:00
nick brett
c675819ca1 [UE][FEATURE] Extend Pose Watches to support control of other aspects of animation node debug draw.
- Pose watches can now contain elements which represent different asspects of an anim nodes debug draw (i.e. bodies and constraints in RBAN)
- Elements can be used to enable anim node debug draw even when a node is not selected, acting in the same way as the previous pose watches
- The previous Pose watch behavior is now provided by an element within a pose watch
- RBAN nodes now make use of Pose Watch Elements
- Moved skeleton draw parameter UPROPERTIES from PoseWatch to specialised PoseWatchPoseElement class

#rb [at]Thomas.Sarkanen, [at]Lucas.Dower
#preflight 62d6a3e43c3df323901fca27

#ROBOMERGE-AUTHOR: nick.brett
#ROBOMERGE-SOURCE: CL 21174786 via CL 21175779 via CL 21181135
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21192394 by nick brett in ue5-main branch]
2022-07-20 18:29:30 -04:00
fernando coello
a47fbea5c2 Filtering SMyBlueprint tabs in anim BPs
Various categories of actions are hidden/prohibited:
- Macros (creation/viewing)
- Event dispatchers/delegates
- Event graphs (as of Lyra we favor the thread safe update function)

#jira UE-157221
#rb Phillip.Kavan
#preflight 62b575a5d82986248b4149b7

#ROBOMERGE-OWNER: fernando.coello
#ROBOMERGE-AUTHOR: thomas.sarkanen
#ROBOMERGE-SOURCE: CL 20807528 via CL 20863116 via CL 20865600 via CL 20866003
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20876815 by fernando coello in ue5-main branch]
2022-06-29 12:24:47 -04:00
lucas dower
3701077ae7 Fixed create comment action not working in all animbp graph schemas
#jira UE-145034
#rb jurre.debaare
#preflight 628b7acc693c5e1de275b207

[CL 20324680 by lucas dower in ue5-main branch]
2022-05-23 08:31:28 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
Matt Peters
7ad238a806 AssetRegistry includes (Engine/Source): change #include "AssetData.h" -> #include "AssetRegistry/AssetData.h", and similar for the other moved AssetRegistry headers.
#rb Zousar.Shaker
#rnx
#preflight 6270509a220f89f0ad573030

[CL 20016982 by Matt Peters in ue5-main branch]
2022-05-02 18:06:48 -04:00
lucas dower
9a50e490bd Support for disabling pose watching on specific anim nodes
#jira UE-139373
#rb thomas.sarkanen
#preflight 61f2add8c0033b39f8bb1997

[CL 18753518 by lucas dower in ue5-main branch]
2022-01-27 10:11:25 -05:00
nick brett
d4e53c951f [UE][FEATURE] AnimDynamics node TRS Widget and Chain Body Editing:
+ Support for editing most geometric parameters (Joint Offsets, Box Extents, Collision Planes etc) with a TRS Widget.
+ Allow parameters to be edited for each individual physics body in a chain.
+ DEPRECATED some physics body properties, these are now held in an array, one instance per physics body.
+ Changed definition of LocalJointOffset - was joint position relative to physics body, now physics body position relative to joint
+ Fix for apparent bug in position constraints between chain bodies.
+ Added a new AnimDynamics Edit Mode to support new widget features.
+ Changes to details panel layout.

#rb [at]Benn.Gallagher, [at]Thomas.Sarkanen
[FYI] [at]charles.anderson
#preflight 61eec96daa3f15faa57b841f

#ROBOMERGE-OWNER: nick.brett
#ROBOMERGE-AUTHOR: nick.brett
#ROBOMERGE-SOURCE: CL 18721085 via CL 18721089 via CL 18721093 via CL 18724643 via CL 18724991
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18725005 by nick brett in ue5-main branch]
2022-01-25 12:55:32 -05:00
lucas dower
7ba1366473 Misc pose watch manager changes.
- Pose watch manager now in default anim bp layout
- Fix for being unable to make pose watches created from 'Automatically create pose watch on selection' setting a permanent pose watch and vice versa
- Cleaned up drag-and-drop validation
- Updated context menus
- Improved resolving name clashes

#jira UE-136746
#jira UE-136745
#rb Thomas.Sarkanen
#preflight 61b33ae1ee0de9822e3a62cc

#ROBOMERGE-AUTHOR: lucas.dower
#ROBOMERGE-SOURCE: CL 18430031 in //UE5/Release-5.0/... via CL 18435283
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v897-18405271)

[CL 18435504 by lucas dower in ue5-release-engine-test branch]
2021-12-10 17:45:09 -05:00