Commit Graph

181 Commits

Author SHA1 Message Date
helge mathee
308d55d9b9 RigVM / ControlRig: Fix direct manipulation during PIE
#rb jaime.cifuentes
#jira UE-192171

[CL 27371219 by helge mathee in ue5-main branch]
2023-08-25 05:02:24 -04:00
jose villarroel
710ad21f92 [Backout] - CL27251115
[FYI] jose.villarroel
Original CL Desc
-----------------------------------------------------------------
Added Anim Blueprint Editor preference to disable showing assets in the context menu of anim graph. This results in a significantly faster context menu in large projects.
[REVIEW] [at]Aaron.Cox, [at]Thomas.Sarkanen

[CL 27252044 by jose villarroel in ue5-main branch]
2023-08-21 16:14:50 -04:00
jose villarroel
a633cc5d56 Added Anim Blueprint Editor preference to disable showing assets in the context menu of anim graph. This results in a significantly faster context menu in large projects.
[REVIEW] [at]Aaron.Cox, [at]Thomas.Sarkanen

[CL 27251149 by jose villarroel in ue5-main branch]
2023-08-21 15:51:13 -04:00
robert manuszewski
d3991fec9b Fixing potential compile errors ahead of enabling TObjectPtr GC barrier
#rb trivial

[CL 26868625 by robert manuszewski in ue5-main branch]
2023-08-05 06:09:54 -04:00
thomas sarkanen
b0a0c4f126 Improve infinite loop handling in animation blueprints
Change early-out for exception handling to skip exceptions for all object types in preview worlds, not just actors. Also handle excpetions in this case when the debugger is attached to the object already (allows for break on exceptions to work).
Hook the BP exception delegate to disable ticking on the skeletal mesh component so we dont keep ticking runaway scripts
Tweaked thumbnail request to not submit the same asset multiple times - this happens multiple times on compilation and can cause longer hitches when the thumbnail is requested and ticked with an infinite loop in place.

#jira UE-188277
#rb dan.oconnor

[CL 26841618 by thomas sarkanen in ue5-main branch]
2023-08-04 04:35:00 -04:00
jaime cifuentes
2a50227a47 Fix for editor crash when closing one viewport while two viewports are open in persona
#jira UE-190703
#rb thomas.sarkanen

[CL 26771089 by jaime cifuentes in ue5-main branch]
2023-08-02 10:16:04 -04:00
jaime cifuentes
679292da88 Static analysis fix at SGraphNodeAnimTransition.cpp and AnimTransitionNodeDetails.cpp
#rb trivial

[CL 26677030 by jaime cifuentes in ue5-main branch]
2023-07-28 12:38:33 -04:00
jaime cifuentes
e71560bdff Added compiler note and visual warnings to state machine transitions if the transition rule has logic but the flag for automatic rule based condition is set
#jira UE-170338
#rb jose.villarroel

[CL 26665714 by jaime cifuentes in ue5-main branch]
2023-07-28 03:19:20 -04:00
thomas sarkanen
6cfb3173aa Fix preview instance not being re-selecteable after selecting an external anim instance to debug
#jira UE-190521
#rb jose.villarroel

[CL 26506645 by thomas sarkanen in ue5-main branch]
2023-07-21 04:59:49 -04:00
roland munguia
7dc3bb57a2 State machine entry, exit, fully blended in, and fully blended out anim node functions.
Additional changes:
- Added warnings for users using anim state events since we want to push towards using the state node functions.
- Added support for anim nodes to show any bound functions and not have them hardcoded.
- Added base context type for FAnimExecutionContext.
- Now users can specify the string for the default binding name of a function member reference in a BP by using the "DefaultBindingName" metadata tag. This will give the functionality to avoid having the default binding name be "NewFunction" and instead use the input string from the metadata tag.

#jira UE-184572
#rb Thomas.Sarkanen, jose.villarroel, aaron.cox
#preflight 646e6a836c2a2532b1f91efd

[CL 25631664 by roland munguia in ue5-main branch]
2023-05-25 18:06:26 -04:00
kirill zorin
de8db5ff76 Converting ARO-facing raw pointers to TObjectPtr ahead of raw pointer ARO API deprecation.
#rb zousar.shaker
#rb markus.breyer
#rb robert.manuszewski

#preflight 646391406b1406b54ab15460

[CL 25489627 by kirill zorin in ue5-main branch]
2023-05-16 10:52:49 -04:00
bryan sefcik
d205101cc8 Removed unnecessary private include modules.
#preflight 645da640cf788a25581110bb

[CL 25451545 by bryan sefcik in ue5-main branch]
2023-05-12 12:13:52 -04:00
bryan sefcik
91c57d395e Removed redundant module includes.
#preflight 645d4bf3aa3c584c0b5b3a67

[CL 25435653 by bryan sefcik in ue5-main branch]
2023-05-11 16:48:21 -04:00
aaron cox
58ce496633 Fix for static analysis warning: "Parameter 'InactiveStateColor' is always rewritten in function body before being used"
[REVIEW] [at]Roland.Munguia
#preflight 6446fd897368de8c981a7d46

[CL 25175863 by aaron cox in ue5-main branch]
2023-04-24 23:45:13 -04:00
aaron cox
3ff8e0003f New colors to distinguish state aliases and conduits.
[REVIEW] [at]Roland.Munguia

[CL 25158043 by aaron cox in ue5-main branch]
2023-04-22 11:49:00 -04:00
Thomas Sarkanen
cade535b0a Fixed crash opening a template animation blueprint with curves tab open
#jira none
#rb Jurre.deBaare
#preflight 6421aae47703a8de3d9a0890

[CL 24803198 by Thomas Sarkanen in ue5-main branch]
2023-03-27 11:11:05 -04:00
Thomas Sarkanen
502797ca50 Animation Curve Runtime & Editor Improvements
Runtime notes:
- Removes 'smart name' usage across the animation systems.
- Changed curve blending from a uniform array (sized per skeleton) to a sparse array of sorted named values. Blends and other combiners are performed using a dual iteration 'tape merge'.
- Skeleton curves are no longer guaranteed to cover all curve names that can be found at runtime.

Editor notes:
- Curve metadata (flags, bone links etc.) is still present on the skeleton, but can also now exist on a skeletal mesh
- Curve metadata (for morph targets) is still populated on import
- Curves can now be used arbitrarily at runtime

New features:
- New Find/Replace dialog that allows for batch-replacing curves and notifies across all of a project's assets
- New curve debugger tab in various Persona editors that allows for viewing curve values live. This also now allows viewing curves for specific pose watches.
- Pose watches now output curve tracks to the Rewind Debugger

#rb Jurre.deBaare,Nicholas.Frechette,Sara.Schvartzman,Helge.Mathee,Kiaran.Ritchie,Jaime.Cifuentes,Martin.Wilson,Keith.Yerex,Andrean.Franc (and more!)
#jira UE-167776
#jira UE-173716
#jira UE-110407
#preflight 63fc98c81206d91a2bc3ab90
#preflight 63f3ad4f81646f1f24c240c2

[CL 24421496 by Thomas Sarkanen in ue5-main branch]
2023-02-27 07:20:58 -05:00
Nicholas Frechette
230e9f42b3 Add missing anim BP template features now that skeleton compatibility has been relaxed
#jira UE-168846
#rb Thomas.Sarkanen
#preflight 63752a6c1c114bec050b9127

[CL 23157954 by Nicholas Frechette in ue5-main branch]
2022-11-16 13:30:40 -05:00
benjamin jillich
cc4a3af312 [UE-169779] Transition rule relinking can be difficult to drag based on cursor placement
#preflight 636e2f42c675563b761b279d

[CL 23095121 by benjamin jillich in ue5-main branch]
2022-11-11 06:21:37 -05:00
benjamin jillich
a6ef0d5b7f [UE-136096] Relinking transitions in anim graph state machines
[UE-168360] User can create a transition from a state into the entry state

* Relinking multiple transitions (transition nodes at once) when none of the transition nodes is selected.
* Selective relinking in case a subset of the transition nodes on a transitions are selected.
* Special case handling for transitions from entry state (they don't have a transition node connected).
* Drawing circle indicator around the arrow head in case the mouse cursor is approaching the transition.
* Hovering the arrow head of a transition highlights it by filling the circle with solid orange color and turning the arrow black.
* Ending the relink operation in empty space or the entry node will cancel the relink operation.
* Fixed bug that prevents creating new transitions ending in an entry state.

#jira https://jira.it.epicgames.com/browse/UE-136096
#jira https://jira.it.epicgames.com/browse/UE-168360
#preflight 636a169963037c10262bc421

[CL 23025287 by benjamin jillich in ue5-main branch]
2022-11-08 04:09:22 -05:00
Thomas Sarkanen
d9c2b172f7 Skeleton compatibility improvements
Skeleton compatibility is now bi-directional. Specifying a compatible skeleton A -> B now implies B -> A.
Skeleton compatibility is now an editor-only concern. The runtime will attempt to do the 'best it can' via name -> name mappings. Only the editor will prevent assigning incompatible skeletons in (e.g.) asset pickers etc.
Skeleton compatibility checks in editor can now be disabled in the editor preferences (and each asset picker now has a checkbox option in its view settings that allows for quick access to this).

Moves FSkeletonRemapping to its own file (which is now private).
Skeleton remappings are now generated on demand on worker threads just before animation decompression and stored in a registry, guarded by FRWScopeLock for thread-safety.

Fixed some anim BP compiler edge cases where asset references on pins were not getting preloaded correctly, causing skeletons to be erroneously reported as missing.

Exposed the current asset registry filter in SAssetView so that menu extensions can access it (and use it to provide context)

#jira UE-166054
#jira UE-167355
#rb Jurre.deBaare,John.vanderBerg
#preflight 635902602e6690262afa86f9

[CL 22878911 by Thomas Sarkanen in ue5-main branch]
2022-11-01 06:25:59 -04:00
lucas dower
6bce8973c5 Fixed crash when attempting to draw pose-watched anim nodes which use custom edit modes such as 'Two Bone IK' and 'Transform (Modify) Bones'.
* Only nodes which have been setup to have drawable elements should be drawn when pose watched, such as 'RigidBody'.
* Anim nodes with custom edit modes should only draw their widgets when explicitly selected or override IAnimNodeEditMode::SupportsPoseWatch

#jira 165766
#rb thomas.sarkanen
#preflight 63514130047f3570adddd035

[CL 22655755 by lucas dower in ue5-main branch]
2022-10-20 10:42:00 -04:00
bryan sefcik
483f93dc1a Fixed misc include paths
#jira
#preflight 634f491669246074dbb2719d

[CL 22633214 by bryan sefcik in ue5-main branch]
2022-10-19 14:38:31 -04:00
eric knapik
456b36cf50 #preflight skip
[CL 22547993 by eric knapik in ue5-main branch]
2022-10-15 02:17:29 -04:00
eric knapik
ebeb6781c1 Animation BP toolbar trimming & permissions
* Tab filters are now applied before tab widgets before are created for animation blueprint editor instead of only when a user tries opening a new tab. This prevents disallowed tabs in default layouts being created.
* Event graph documents are not opened if event graph permissions are disabled when loading blueprint editor.
* Added new blueprint permission to optionally disable function overrides.

#rb thomas.sarkanen
#preflight 6346928ef04e6f8505f7b879

[CL 22547860 by eric knapik in ue5-main branch]
2022-10-15 02:13:23 -04:00