Commit Graph

152 Commits

Author SHA1 Message Date
alfaroh corneyiii
6b74ef4c51 Change Chorus Wet/Dry Modulation Parameter to volume (for parity with submix modulators)
#jira UE-167151
#rb rob.gay

[CL 26442865 by alfaroh corneyiii in ue5-main branch]
2023-07-18 15:15:02 -04:00
kirill zorin
b6ee3a6c64 Fix UE_LOG callsites that have format string-related UB
#rb trivial
#preflight 647107780a6634dbb236a0a6

[CL 25651638 by kirill zorin in ue5-main branch]
2023-05-26 15:52:39 -04:00
helen yang
7c1c93403e Start audio bus before adding patch to key source in Submix Effect Dynamics Processor, remove misleading warning
#jira UE-137483
#jira UE-125147

#rb rob.gay
#preflight 63edede87e76998e9a94faf5

[CL 24271781 by helen yang in ue5-main branch]
2023-02-16 18:17:43 -05:00
henrik karlsson
9a1d5b1ad4 [Engine/Plugins]
* Ran IWYU on ~170 plugins to remove includes not needed. Public api still keep old includes inside #if UE_ENABLE_INCLUDE_ORDER_DEPRECATED_IN_5_2

#preflight 63d09351574ab9cae4670216
#rb none

[CL 23844750 by henrik karlsson in ue5-main branch]
2023-01-25 02:42:36 -05:00
miles flanagan
12e63d3d92 Prevent crash in multiband compressor when it tries to run with 0 bands.
#jira UE-174825
#preflight 63cf2e383a03cb0bbf254752
#rb none
#rnx

[CL 23834302 by miles flanagan in ue5-main branch]
2023-01-24 13:24:05 -05:00
henrik karlsson
9183978e29 [Engine/Plugins]
* Removed includes (using IWYU) in private files

#preflight 63c79978ac35a0e9dabbe408
#rb none

[CL 23770038 by henrik karlsson in ue5-main branch]
2023-01-19 00:48:07 -05:00
Andrew Rodham
4ff7bab147 Slate: Initial phase of FVector2D deprecation
- Expanded FDeprecateSlateVector2D to provide structs for parameters, return types and member variables that use FVector2f, while still allowing conversion to/from FVector2d with optional per-module deprecation mechanisms.
  - Many of the high-traffic SlateCore types like FSlateBrush, FGeometry and FSlateLayoutTransform have been converted to use these deprecation mechanisms.
  - Some legacy FGeometry::ToPaintGeometry and MakeChild overloads have been explicitly deprecated since they cause ambiguous overloads with FSlateLayoutTransform if it were to support implicit construction.
  - Deprecated ULocalPlayer::GetPixelBoundingBox and GetPixelPoint to prefer FVector2f for OptionalAllotedSize parameter since this parameter is expected to come from FGeometry
  - Exposed FVector2f members to blueprints

#jira none
#rb Andy.Davidson, Dave.Jones, Vincent.Gauthier, Patrick.Boutot
#preflight 63bc6fd068068a8bd6027c9f

[CL 23631073 by Andrew Rodham in ue5-main branch]
2023-01-10 14:46:43 -05:00
JeanMichel Dignard
5fc36285ba Fixed typos reported by localization
#jira UE-170395
#rb none
#preflight 63939b065c5308d18c4adbab

[CL 23468692 by JeanMichel Dignard in ue5-main branch]
2022-12-09 15:54:23 -05:00
helen yang
b9eb6cda6c Audio bus subsystem refactor checkpoint
- Move audio bus functionality from Mixer Device to new Audio Bus Subsystem
- Add new audio bus key struct so that FMixerAudioBuses do not have to be created with UObject ids

#jira UE-169610
#rb phil.popp, ryan.mangin, rob.gay
#preflight 63906195255f07df8e452b8c

[CL 23429172 by helen yang in ue5-main branch]
2022-12-07 11:04:50 -05:00
nicholas howe
115d386688 Audio bus reader node output patch buffer size fix
This fixes a bug where audio bus reader nodes might never start popping audio because AudioCallbackBufferFrameSize is set to a value other than the default 1024, such as 256.

Replace AddPatchForAudioBus with AddPatchOutputForAudioBus, which is parameterized by the desired number of frames and channels in the patch output.
Update AddPatchInputForAudioBus to match.
Both functions use a new MakePatch function to create a patch based on the parameters and scaled to fit the number of blocks specified by the new "au.PatchBufferBlocks" cvar.
Add support for quad, 5.1, and 7.1 bus reader and writer nodes.

[REVIEW] [at]phil.popp
#preflight 6386191a4004f73f62c48875

[CL 23312512 by nicholas howe in ue5-main branch]
2022-11-29 12:35:48 -05:00
alfaroh corneyiii
352c77962d Fix EditCondition warning in Impulse Response Asset
#jira UE-151680
#rb rob.gay
#preflight
#preflight 6373d33e1c114bec05b81cb8

[CL 23138919 by alfaroh corneyiii in ue5-main branch]
2022-11-15 13:12:43 -05:00
joe pribele
0926a226cf removed PRAGMA_DISABLE_OPTIMZATIONS that appear to be left in by accident
#rb zousar.shaker
#preflight 636c1c6f7c2b50519028f593

[CL 23063526 by joe pribele in ue5-main branch]
2022-11-09 16:47:19 -05:00
aaron mcleran
f9e7f2f015 Stereo-to-quad submix effect
#rb Maxwell.Hayes, alfaroh.corneyiii
#preflight none

[CL 22999973 by aaron mcleran in ue5-main branch]
2022-11-04 22:37:48 -04:00
henrik karlsson
8f895fef35 Added includes needed after removing includes in headers
#preflight 6360b63e41625be270a6e464
#rb none

[CL 22888775 by henrik karlsson in ue5-main branch]
2022-11-01 15:14:15 -04:00
henrik karlsson
862ef70ca4 [UHT]
* Fixed so delegate wrapper function is implemented in cpp file to be able to forward declare types used by delegate

#preflight 6360593fc6242f88a4c1fe5a
#rb none

[CL 22888516 by henrik karlsson in ue5-main branch]
2022-11-01 15:06:21 -04:00
rob gay
18e887e937 [MetaSounds] Fix/add missing new MetaSound type icons/thumbnails as well as play/stop overlays. Support for showing/filtering presets in ContentBrowser
#rb helen.yang julien.stjean
[REVIEW] helen.yang
#jira UE-168050
#preflight 635314707261e565c497645f

[CL 22786984 by rob gay in ue5-main branch]
2022-10-26 15:28:04 -04:00
maxwell hayes
a2cf0be8a5 Follow up fix for guard around Granular Synth being provided a USoundWave w/ non-forceinline loading behavior.
# jira UE-120998
#rb jimmy.smith
#preflight 635337bbcb31f106ce0a58d9
#rnx

[CL 22712208 by maxwell hayes in ue5-main branch]
2022-10-22 15:37:26 -04:00
maxwell hayes
ceb11a840f [Granular synth] protect against loading USoundWaves w/ incompatible loading behavior.
#jira UE-120998
#rb jimmy.smith
#rnx
#preflight 6351ea9b9e14ee3c79646934

[CL 22707985 by maxwell hayes in ue5-main branch]
2022-10-21 22:29:52 -04:00
maxwell hayes
3b2e604d60 Fix for convolution reverb not working on higher channel-count AudioDevices / SubmixGraphs
#jira UE-146734
#rb phil.popp
#preflight 634739be8a0a7b2adc9d8244

[CL 22582611 by maxwell hayes in ue5-main branch]
2022-10-17 18:20:27 -04:00
nick darnell
954d29b9f5 Editor - Beginning the process to no longer make loading all assets you right click in the content browser. The first step, is setting up the code to have a deprecation flag DEPRECATE_ASSET_TYPE_ACTIONS_NEEDING_LOADED_OBJECTS, this will make it illegal to implement GetActions on all AssetTypeAction implementations. Checked in disabled, enable it locally to begin trying to implement the recommended method detailed in the IAssetTypeActions header. WIP. One of the things this change does is outlaw (regardless of deprecation) the HasActions() function, this function is no longer used at all, and so we may as well remove its implementation, it also works well as a canary in finding other samples and things that need to be upgraded.
#jira UE-165574
[REVIEW] [at]Rex.Hill, [at]Lauren.Barnes
#preflight 63483c43ad0f7e2f20e44910

[CL 22534452 by nick darnell in ue5-main branch]
2022-10-14 16:59:41 -04:00
rob gay
56088a4180 DSP LFO/Modulation LFO fixes
- Add missing exponential factor to Modulation generator
- Fix bounds restriction calculation for expontential factor
- Add LFO ResetPhase implementation to override initial location in oscilator on rising edge where necessary (for modulation LFO, user range limited to unipolar but hardly ever wants to start at midpoint).
- Add bipolar option to avoid oneshot/bipolar conflation for certain types of LFOs
- Add back implementation for 5.1 deprecated function to avoid breaking licensees
#rb phil.popp
[REVIEW] phil.popp
#jira UE-127886
#preflight 6346eed9b757820b7ae99b76

[CL 22483928 by rob gay in ue5-main branch]
2022-10-12 15:31:28 -04:00
alfaroh corneyiii
ad525b20a0 Fix Audio Modulation Parameter Mismatch UI Bug
#jira UE-126644
#preflight 6340aee2437603cb0e4f14d8
#rb rob.gay
#lockdown aurel.cordonnier

[CL 22414481 by alfaroh corneyiii in ue5-main branch]
2022-10-07 21:33:37 -04:00
rob gay
4856cf0b72 Db/DB to dB display name fixes
#rb trivial
#jira UE-165456
#rnx
#preflight 6335ea5f7c11614c21772bc6

[CL 22264044 by rob gay in ue5-main branch]
2022-09-30 01:36:23 -04:00
bryan sefcik
50d4fac9e0 Updated ../Engine/Plugins/... to inline gen.cpp files
Before:
3548 unity files
Total CPU Time: 47343.578125 s
Total time in Parallel executor: 494.60 seconds

After:
3445 unity files
Total CPU Time: 46044.671875 s
Total time in Parallel executor: 468.51 seconds

#jira
#preflight 63336159b20e73a098b7f24f

[CL 22218213 by bryan sefcik in ue5-main branch]
2022-09-28 01:06:15 -04:00
rob gay
3f94473cc9 ModulationDestinations Upgrade
- Support sets of input modulators
- Support union of modulation heirarchy
#rb alfaroh.corney
#jira UE-163157
#preflight 63191cc3ec45fbf3d708437c

[CL 21892756 by rob gay in ue5-main branch]
2022-09-08 09:18:28 -04:00