Commit Graph

293 Commits

Author SHA1 Message Date
thomas tedemalm
dc26026706 [PCG] Fixed static analysis issue in pcg editor graph, Dereferencing NULL pointer 'OutboundNode'
#rb julien.lheureux, huw.bowles, wyatt.marvil
#jira UE-195411
#rnx

[CL 27885146 by thomas tedemalm in ue5-main branch]
2023-09-14 13:15:54 -04:00
huw bowles
a26217c655 [PCG] Fixes and improvements handling corrupt graphs.
Log errors in more cases and remove edges to non-existent nodes which was hit on one of the projects.

#rb julien.lheureux, adrien.logut, thomas.tedemalm, ryan.buehler, wyatt.marvil
#rnx

[CL 27784788 by huw bowles in ue5-main branch]
2023-09-12 04:07:27 -04:00
huw bowles
6faa026656 [PCG] Soft object path and soft class path added as new metadata types.
Previously this was emulated somewhat by storing the paths as FStrings but this did not result in proper references that are visible to the cook.

Notes:
* Producers/consumers of asset references moved to the new types.
* Broadcast to string enabled to allow string operations on paths.
* Broadcast from string always allowed when getting values, so that legacy usages which grabbed path as string will continue to work.
* Deprecation added to migrate old path handling (string mode).
* Serialize method added to traits because FSoftObjectPath can't be directly serialized to archive.
* Fixed some project-specific static casting to FString that coudl fail when applied to SOP/SCP attributes.

#rb adrien.logut, julien.lheureux, ryan.buehler
#rnx
#jira UE-192394

[CL 27749069 by huw bowles in ue5-main branch]
2023-09-11 06:38:20 -04:00
adrien logut
1b37477012 [PCG] Tentative fix for Editor test, testing PCG volume factory
* Can't repro locally and seems to be random. Add more checks to be sure to not use null pointers.
* Ran the preflight until the faulty job, failed but not on this test.

#rnx
#rb trivial
#jira UE-194566

[CL 27693956 by adrien logut in ue5-main branch]
2023-09-07 18:51:09 -04:00
thomas tedemalm
9534048b79 [PCG] Moved attribute list view sorting and filtering to separate thread in order to not freeze the editor on large data sets
#rb huw.bowles, julien.lheureux, adrien.logut, ryan.buehler
#jira UE-193774

[CL 27669898 by thomas tedemalm in ue5-main branch]
2023-09-07 08:29:14 -04:00
thomas tedemalm
168122b65e [PCG] Added support for multiple pcg components within the same actor when setting debug object from selection
#rb julien.lheureux, adrien.logut
#rnx

[CL 27635872 by thomas tedemalm in ue5-main branch]
2023-09-06 11:06:47 -04:00
adrien logut
cea3b1ae73 [PCG] Enforce bAllowMultipleConnections to false if AllowMultipleData is false on pins.
* Also rename AllowMultipleConnections function to AllowsMultipleConnections.
* Also rename AllowMultipleData function to AllowsMultipleData, for consistency.

#rnx
#jira UE-194366
#rb julien.lheureux, ryan.buehler, wyatt.marvil

[CL 27615432 by adrien logut in ue5-main branch]
2023-09-05 18:00:12 -04:00
huw bowles
c42983dfc1 [PCG] Profiling view polish pass
* Expanded columns so contents are (less) clipped by default
* Add header tooltips
* Normalized capitalisation and time units
* Numerical columns sort Descending by default (biggest costs at top)
* Removed partial implementation of PostExecute column which elements don't really use right now
* Add ellipsis overflow

#rb adrien.logut, thomas.tedemalm, wyatt.marvil
#rnx

[CL 27550787 by huw bowles in ue5-main branch]
2023-09-01 05:10:06 -04:00
ocea ellis
c37996ff3f [PCG] Adds a node that sorts points based on attribute
--New helper function SortByAttribute included
--Unit test added
--Added ability to randomize density in PCGTestCommon

#rb adrien.logut, huw.bowles, julien.lheureux
#jira UE-192929

[CL 27537336 by ocea ellis in ue5-main branch]
2023-08-31 16:50:48 -04:00
thomas tedemalm
df3afdaac2 [PCG] Moved scale initialization to PreActorSpawn in order to have the volume size set before dropping the PCG asset, for easier placement.
#rb julien.lheureux

[CL 27459304 by thomas tedemalm in ue5-main branch]
2023-08-29 15:01:49 -04:00
adrien logut
a8d0738358 [PCG] Add a Add/RemoveNodes function for bulk nodes adding/removing
* Use it when deleting nodes and pasting nodes in the editor.
* Use it when deleting nodes when collapsing in a subgraph.
* It will improve reactiveness in big graphs in already generated maps.

#rnx
#rb julien.lheureux, thomas.tedemalm, wyatt.marvil
[FYI] chris.cook

[CL 27408738 by adrien logut in ue5-main branch]
2023-08-28 07:55:57 -04:00
thomas tedemalm
54e50cb13c [PCG] Added column tooltips to the attribute list view that shows the type
#rb julien.lheureux, ryan.buehler, huw.bowles, adrien.logut

[CL 27279583 by thomas tedemalm in ue5-main branch]
2023-08-22 14:15:31 -04:00
huw bowles
18bd14fc59 [PCG] Fix ensure if one quits the editor while inspecting a graph.
#rb julien.lheureux, ryan.buehler, thomas.tedemalm
#rnx
#jira UE-193289

[CL 27201358 by huw bowles in ue5-main branch]
2023-08-18 10:04:11 -04:00
thomas tedemalm
acfd1305b2 [PCG] Made the PCG graph object selectable by clicking the node editor background.
#rb Huw.Bowles, Julien.Lheureux, Ryan.Beuhler

[CL 27179919 by thomas tedemalm in ue5-main branch]
2023-08-17 14:24:38 -04:00
adrien logut
f107dcd20a [PCG] Fix outstanding bug in the attribute list view
* Any None attribute that has extractor (like Vector) were not displaying properly

#rnx
#jira UE-193217
#rb julien.lheureux, ryan.buehler
#lockdown julien.marchand

[CL 27160101 by adrien logut in ue5-main branch]
2023-08-16 19:09:50 -04:00
thomas tedemalm
725378f64e Early review for undo/redo issue fix. Editor team is looking into adding support to only update the subobject tree, if we cant get something in place for 5.3 we should disable the refresh entirely with this change.
[PCG] Added console variable to toggle component changed calls to the leveleditor and made it disabled by default. This was causing issues with undo/redo transaction blocks while scrubbing values since it would regenerate the graph and refresh the details during interaction. Disabling this will cause the subobject tree to not refresh and show generated ISMC's until object has been reselected.

#jira UE-189516
#rb julien.lheureux
#lockdown julien.marchand

[CL 27141111 by thomas tedemalm in ue5-main branch]
2023-08-16 11:25:33 -04:00
wyatt marvil
c73747e91a [PCG] Fixed PCGGraphs not generating on drop
Also fix broken node colours that was impacting graph readability

#rb julien.lheureux, thomas.tedemalm
#jira UE-192388
#rnx
#lockdown julien.marchand

[CL 27141079 by wyatt marvil in ue5-main branch]
2023-08-16 11:24:30 -04:00
adrien logut
d2844f5017 [PCG] Refactor collapse to subgraph
* Move all collapse code into a helper on the plugin side
* Fix the collapse to include correctly graph parameters
* Add some unit tests
* Introduced a "ReconstructGraph" if there are changes on the model, but not on the view.

#jira UE-188421
#rnx
#rb julien.lheureux, ryan.buehler

[CL 27089881 by adrien logut in ue5-main branch]
2023-08-14 18:06:10 -04:00
ryan buehler
2ec5d697a5 [PCG] Fixed a crash when inspecting a transient debug graph object created from the Determinism Tests
* Also fixed an issue where SettingsWithOverride was incorrectly setting itself as Transient

#rnx
#jira UE-192632
#rb

[CL 27087115 by ryan buehler in ue5-main branch]
2023-08-14 17:01:44 -04:00
huw bowles
45941184a1 [PCG] Fix bug where Debug flag stops functioning for a graph
#rb julien.lheureux, thomas.tedemalm, adrien.logut, wyatt.marvil
#rnx
#jira UE-192353

[CL 26993505 by huw bowles in ue5-main branch]
2023-08-10 11:23:44 -04:00
wyatt marvil
6f10c00201 [PCG] Add post-paste operation to UPCGSettings to support copy/paste of nodes using graph parameter overrides
#rb
#jira UE-192417
#rnx

[CL 26979303 by wyatt marvil in ue5-main branch]
2023-08-09 19:37:12 -04:00
ryan buehler
67f1ca4e6f [PCG] Fixed a bug causing the PCG Attribute List View to crash when sorting a FString-based attribute...
#rnx
#jira UE-192265
#rb julien.lheureux, huw.bowles, thomas.tedemalm

[CL 26963870 by ryan buehler in ue5-main branch]
2023-08-09 13:47:46 -04:00
wyatt marvil
084de844e3 [PCG] Add inspection support for dynamically executed graphs
#rb julien.lheureux
#jira UE-189905, UE-188530

[CL 26908113 by wyatt marvil in ue5-main branch]
2023-08-07 21:00:15 -04:00
huw bowles
6ee33d4148 [PCG] Update inspection/debug on significant events like changing map and deleting actors with PCG components.
These were the primary ways I could repro the jira below - and it generally feels much neater to tidy up the state rather than continue inspecting components/data that no longer exist.

#rb julien.lheureux, adrien.logut, thomas.tedemalm
#jira UE-174287
#rnx

[CL 26891952 by huw bowles in ue5-main branch]
2023-08-07 14:05:20 -04:00
robert manuszewski
d3991fec9b Fixing potential compile errors ahead of enabling TObjectPtr GC barrier
#rb trivial

[CL 26868625 by robert manuszewski in ue5-main branch]
2023-08-05 06:09:54 -04:00