Commit Graph

739 Commits

Author SHA1 Message Date
jordi rovira
5ffe7a821a [mutable] Protect images that are being loaded from being garbage collected during compilation.
Additional profiling for object compilation.
Minor changes to ease backports.
[REVIEW] [at]max.garcia
#rnx

[CL 27881436 by jordi rovira in ue5-main branch]
2023-09-14 12:02:21 -04:00
alexei lebedev
316da2d59b #rnx
[CL 27879181 by alexei lebedev in ue5-main branch]
2023-09-14 10:58:02 -04:00
gerard martin
76d4c8d17c [Mutable] Fix COI Editor Texture Parameter Selector when adding a Default Value for the first time.
[REVIEW] [at]alexei.lebedev
#rnx

[CL 27876264 by gerard martin in ue5-main branch]
2023-09-14 09:21:17 -04:00
gerard martin
b4af1f087c [Mutable] Switch to the New TaskGraph API.
[REVIEW] [at]jordi.rovira, [at]alexei.lebedev
#rnx

[CL 27873356 by gerard martin in ue5-main branch]
2023-09-14 06:06:24 -04:00
alexei lebedev
4b47b0c39c #rnx
[CL 27873308 by alexei lebedev in ue5-main branch]
2023-09-14 06:03:16 -04:00
alexei lebedev
28829f7b9c [FYI] [at]pere.rifa
#rnx

[CL 27873230 by alexei lebedev in ue5-main branch]
2023-09-14 05:58:21 -04:00
gerard martin
c98af61fcc [Mutable] Simplify UpdateSkeletalMesh flow.
- Removed unecessary flags.
- Removed Generated Instance flag from DoUpdateSkeletalMesh. Was incorrect. This flag still requires some improvements.
- Renamed InitUpdateSkeletalMesh to EnqueuepdateSkeletalMesh.
- DoUpdateSkeletalMesh is no longer mandatory to start an update. An update can start by simply adding the FMutableOperation to the MutableCurrentOperation.
- Removed no longer necessary bIsCloseDistTick. DoUpdateSkeletalMesh is no longer called from the tick. Now DoUpdateSkeletalMesh is only necessary to enqueue a task, which tick never does (executes a task directly).
- Removed unused BeginUpdate delegates.
- Replaced LODsStreamingEnabled with expression that was activating the flag (LODSettings).
- Replaced ForceGenerateAllLODs with the expression that was activating the flag (being on an EditorViewport).
- State is no longer obtained from the Instance, it is captured when generating mu::Parameters.
- Removed unecessary State copy when creating lambads.

[REVIEW] [at]alexei.lebedev, [at]pere.rifa
#tests PIE, Village, Editor
#rnx

[CL 27873026 by gerard martin in ue5-main branch]
2023-09-14 05:31:42 -04:00
pere rifa
c39d895115 [Mutable] Re-apply fix crash when generating the imported model of skeletal meshes with MinLOD > 0.
#rnx

[CL 27838692 by pere rifa in ue5-main branch]
2023-09-13 13:27:47 -04:00
pere rifa
99571ca75d [Mutable] Allow reuse of MaterialInstances between updates.
Added CVar 'Mutable.ReuseMaterialInstances' to Enable/Disable the reuse of materials. Enabled by default.

#rnx
#rb alexei.lebedev

#localization none
#tests PIE Frontend and BR

[CL 27834830 by pere rifa in ue5-main branch]
2023-09-13 12:06:10 -04:00
jordi rovira
241cc7b515 [mutable] Fix and re-apply again CL27666321
[mutable] Add option to use Unreal's texture compressor at compile and debug time. Enable it by default for cook. Add option to override the internal pixel format function.
Change the method to find out the platform texture format, so that we have less ad-hoc code and more support for Unreal's project settings affecting it.
Cleanup image conversion code related to instance baking, removing duplicated hacky code.
Prevent CO image compilation for server platforms.
[REVIEW] [at]gerard.martin, [at]pere.rifa
#rnx

[CL 27825438 by jordi rovira in ue5-main branch]
2023-09-13 06:59:56 -04:00
max garcia
c187f9c06e [mutable] Fixed bug where refreshing a material node reset some texture options of the pin viewer.
#rnx
#rb gerard.martin

[CL 27823620 by max garcia in ue5-main branch]
2023-09-13 05:38:17 -04:00
pere rifa
c26f4e1003 [Mutable] Fix crash in UpdateSkeletalMesh_PostBeginUpdate0 when generating a mesh with invalid LODs.
#rnx
#rb alexei.lebedev

[CL 27822804 by pere rifa in ue5-main branch]
2023-09-13 04:57:22 -04:00
pere rifa
054b1511f8 [Mutable] Fix crash when generating the imported model of skeletal meshes with MinLOD > 0.
#rnx
#rb alexei.lebedev

[CL 27790262 by pere rifa in ue5-main branch]
2023-09-12 09:57:53 -04:00
ricard rovira
8faea8b7be [mutable] Fix unloaded passthrough textures getting treated as mutable generated
[REVIEW] [at]alexei.lebedev
#rnx

[CL 27784928 by ricard rovira in ue5-main branch]
2023-09-12 04:17:53 -04:00
robert millar
0374a2d30f [Backout] - CL27708842
[FYI] jordi.rovira
Original CL Desc
-----------------------------------------------------------------
[mutable] Fix and re-apply CL27666321
[mutable] Add option to use Unreal's texture compressor at compile and debug time. Enable it by default for cook. Add option to override the internal pixel format function.
Change the method to find out the platform texture format, so that we have less ad-hoc code and more support for Unreal's project settings affecting it.
Cleanup image conversion code related to instance baking, removing duplicated hacky code.
Prevent CO image compilation for server platforms.
[REVIEW] [at]gerard.martin, [at]pere.rifa
#rnx

[CL 27728180 by robert millar in ue5-main branch]
2023-09-08 16:59:37 -04:00
jordi rovira
4eef7bcce3 [mutable] Fix and re-apply CL27666321
[mutable] Add option to use Unreal's texture compressor at compile and debug time. Enable it by default for cook. Add option to override the internal pixel format function.
Change the method to find out the platform texture format, so that we have less ad-hoc code and more support for Unreal's project settings affecting it.
Cleanup image conversion code related to instance baking, removing duplicated hacky code.
Prevent CO image compilation for server platforms.
[REVIEW] [at]gerard.martin, [at]pere.rifa
#rnx

[CL 27708867 by jordi rovira in ue5-main branch]
2023-09-08 08:53:10 -04:00
bob tellez
7de365cd36 [Backout] - CL27666321, except for the native version bump. A bump was not needed to convert the data back
[FYI] jordi.rovira
Original CL Desc
-----------------------------------------------------------------
[mutable] Add option to use Unreal's texture compressor at compile and debug time. Enable it by default for cook. Add option to override the internal pixel format function.
Change the method to find out the platform texture format, so that we have less ad-hoc code and more support for Unreal's project settings affecting it.
Cleanup image conversion code related to instance baking, removing duplicated hacky code.
[REVIEW] [at]gerard.martin, [at]pere.rifa
#rnx

[CL 27685547 by bob tellez in ue5-main branch]
2023-09-07 16:01:14 -04:00
alexei lebedev
e3c52857d9 #rnx
[CL 27675653 by alexei lebedev in ue5-main branch]
2023-09-07 12:42:16 -04:00
jordi rovira
a45dd0df73 [mutable] Fix possible crash on CO compilation because of mismatched instruction types.
[FYI] [at]genis.sole
#rnx

[CL 27675314 by jordi rovira in ue5-main branch]
2023-09-07 12:37:59 -04:00
genis sole
bd4d347935 [Mutable] Fix FImageGenerationOptions::RectSize not being zero initialized by default.
- This could cause large image memory allocations in some operations randomly, for instance IM_PLAINCOLOUR.

[REVIEW] [at]jordi.rovira
#rnx

[CL 27671065 by genis sole in ue5-main branch]
2023-09-07 09:33:14 -04:00
gerard martin
e3a5749e02 [Mutable] Add default values to Texture Parameters.
- Texture Parameter Node now has a Default Value and Reference Value (prerviously known as Default Value).
- Created a new Editor Image Provider. Returns all textures available in the project.
- In editor, default Textures are correctly applied when creating a default Instance.
- Removed deprecated Instance/Descriptor Texture Parameter functions.

[REVIEW] [at]alexei.lebedev, [at]jordi.rovira
[FYI] [at]daniel.moreno, [at]genis.sole
#rnx

[CL 27668512 by gerard martin in ue5-main branch]
2023-09-07 06:34:12 -04:00
jordi rovira
e01762e74d [mutable] Several fixes to operations on block-compressed images, when the block size is not a divisor of the texture size, which may happen with the new astc formats.
[REVIEW] [at]genis.sole
#rnx

[CL 27667943 by jordi rovira in ue5-main branch]
2023-09-07 05:44:55 -04:00
gerard martin
3f21cc5adc [Mutable] Fix crash when skipping an update at Task_Game_StartUpdate.
#rnx

[CL 27667923 by gerard martin in ue5-main branch]
2023-09-07 05:43:19 -04:00
gerard martin
e30ca04a02 [Mutable] Minor CustomizableObjectSystem code improvements.
- Added consts.
- Changed function copies to references.
- Moved checks at the beggining of functions.
- Removed parameters passed outside the FMutableOperationData.
- Default initialization of members.
- Removed unused code.
- Moved implementations to source file.
- Fixed typos.

[REVIEW] [at]alexei.lebedev, [at]pere.rifa
#rnx

[CL 27666874 by gerard martin in ue5-main branch]
2023-09-07 04:23:11 -04:00
jordi rovira
dcd487a510 [mutable] Add option to use Unreal's texture compressor at compile and debug time. Enable it by default for cook. Add option to override the internal pixel format function.
Change the method to find out the platform texture format, so that we have less ad-hoc code and more support for Unreal's project settings affecting it.
Cleanup image conversion code related to instance baking, removing duplicated hacky code.
[REVIEW] [at]gerard.martin, [at]pere.rifa
#rnx

[CL 27666341 by jordi rovira in ue5-main branch]
2023-09-07 03:45:44 -04:00