Commit Graph

141 Commits

Author SHA1 Message Date
jeanfrancois dube
faa2537c02 World Partition Streaming Generation
RuntimeHash
- Added the possibility for runtime hash implementations to perform a validation on HLOD layers and report errors if the setup is invalid (always valid for the current runtime hash implementation).

RuntimeHashSet
- Wrapped input and output generation parameters into separate structs FGenerateStreamingParams and FGenerateStreamingResult to minimize interface changes in the future.
- Added support for multiple HLOD layers for runtime hashset implementation.

#jira UE-132357
#rb sebastien.lussier

[CL 27269995 by jeanfrancois dube in ue5-main branch]
2023-08-22 10:16:45 -04:00
julien stjean
7d9b5aeb59 Fixed an issue where the data validation was not able to execute some editor utility validator because some module where not loaded by default that those editor utility might depends on.
Extracted an function on the default EditorEngine to load the module that are loaded by default when it is initialized. This can now be used to load those module in some commandlet without the need to initiliaze the EditorEngine.

The DataValidationCommandlet now load those editor modules if it found an validator that is made via an EditorUtility.

#jira UE-191040
#rb JeanLuc.Corenthin

[CL 27002021 by julien stjean in ue5-main branch]
2023-08-10 14:38:04 -04:00
JeanFrancois Dube
6e125e0b93 Changelist Validation: Fix for not calling changelist consistency data validation
`UDataValidationChangelist::IsDataValid` was overriding the deprecated no const version of the function.

Unfortunately, the MSVC compiler does not recognise properly deprecated methods if we have a const and non-const version of a method and the compiler did not report it.

#jira none
#rb JeanFrancois.Dube
#p4v-cherrypick 26852734

[CL 26855362 by JeanFrancois Dube in ue5-main branch]
2023-08-04 14:50:56 -04:00
jamie dale
4dbe76a0d7 Extra nullptr check
#jira
[FYI] Bob.Tellez, Chris.Sharp
#rnx

[CL 26451385 by jamie dale in ue5-main branch]
2023-07-18 19:01:46 -04:00
jamie dale
b28aab0493 Only allow the actor validation menu to be used for OFPA packages
[FYI] Jason.Stasik
#rnx

[CL 26260266 by jamie dale in ue5-main branch]
2023-06-27 12:08:42 -04:00
jamie dale
a87b96b82e Added a context menu entry to perform asset validation on specific actors
#rb Jason.Stasik

[CL 26191245 by jamie dale in ue5-main branch]
2023-06-22 15:36:23 -04:00
jeanfrancois dube
aa45366676 World Partition Streaming Generation:
- Do actor filter validation in streaming generation phase, not during context creation.
- Don't create the streaming generation context when validating, since no error detection should be done in it.

#jira UE-186882
#rb patrick.enfedaque

[CL 26146334 by jeanfrancois dube in ue5-main branch]
2023-06-21 09:28:26 -04:00
bryan sefcik
d205101cc8 Removed unnecessary private include modules.
#preflight 645da640cf788a25581110bb

[CL 25451545 by bryan sefcik in ue5-main branch]
2023-05-12 12:13:52 -04:00
jodon karlik
472b38353a Properly deprecate old IsDataValid for a new, const version with FDataValidationContext.
This allows your assets to warn on top of erroring out.

#jira UE-183475
#preflight 644ae7701c2846595cbe0e21

[CL 25224515 by jodon karlik in ue5-main branch]
2023-04-27 17:53:18 -04:00
richard malo
5922caa026 Fixed WorldPartition changelist validator containing a data layer asset so that only the referencing partitioned worlds will be validated.
#rb jeanfrancois.dube
#preflight 641dfa50a86ae7cbcc782655

[CL 24811658 by richard malo in ue5-main branch]
2023-03-27 18:51:08 -04:00
bob tellez
259f9723f3 #UE Adjust validator test for redirectors in localization if both the source and localized assets are redirectors, and they both point to a corresponding new location, with matching relative paths
[CL 24737146 by bob tellez in ue5-main branch]
2023-03-21 15:05:34 -04:00
jeanfrancois dube
19503de0b6 Actor Class Descriptors
- Actors derived Blueprints will now store a class descriptor from the CDO object.
- Actor descriptors will now do delta serialization from their class descriptor.

#rb richard.malo, sebastien.lussier
#preflight 63fb765c9009dd70d7478b6a, 640b542cd778f88975362531

[CL 24601462 by jeanfrancois dube in ue5-main branch]
2023-03-10 20:04:29 -05:00
patrick enfedaque
c042995662 Level Instance: WorldPartitionActorFilter support (experimental)
- Experimental Flag hides Filter UI
- DataLayerAsset can enable filtering (will show up in Filter Outliner)
- DataLayerInstance can provide default filter value (default value when actor doesn't override)
- Level Instance Actor can have its own recursive filter
- Filtering Editor/Cook/PIE works
- Undo/Redo/Copy/Paste/ResetToDefault
- PackedLevelActors not yet supported

#rb jeanfrancois.dube, richard.malo
#preflight 64087dc36c1b9295b99222e8
#rnx

[CL 24561727 by patrick enfedaque in ue5-main branch]
2023-03-08 12:02:09 -05:00
jeanfrancois dube
5b493c5c0b World Partition: detect level instance circular references and avoid crashing.
#rb philippe.deseve
#preflight 640648c4c13b7130d2fbe943

[CL 24531528 by jeanfrancois dube in ue5-main branch]
2023-03-06 17:00:43 -05:00
patrick enfedaque
414bc9f21b Changelist Validation: DirtyFilesChangelistValidator now outputs the assets that need to be saved
#preflight 63e65f7f8c157e4873d8ad6f
#rb richard.malo, jeanfrancois.dube

[CL 24135402 by patrick enfedaque in ue5-main branch]
2023-02-11 11:39:41 -05:00
justin marcus
fd36ca191e Add optional per asset details for UEditorValidatorSubsystem::ValidateAssetsWithSettings
[CL 24092961 by justin marcus in ue5-main branch]
2023-02-09 00:36:18 -05:00
jeanfrancois dube
dbc320d8ef World Partition: don't report errors for invalid runtime grid references when streaming is disabled.
#rb patrick.enfedaque
[FYI] jeansebastien.guay
#preflight none

[CL 24040434 by jeanfrancois dube in ue5-main branch]
2023-02-06 18:07:02 -05:00
philippe deseve
c239b7b960 Avoid reporting a WorldPartitionValidation error when a previous validator failed.
#rb jeanfrancois.dube, richard.malo

[CL 23964715 by philippe deseve in ue5-main branch]
2023-02-02 01:25:10 -05:00
bryan sefcik
fb4aba8c69 Fixed compile issue after merge.
[CL 23942828 by bryan sefcik in ue5-main branch]
2023-01-31 20:21:48 -05:00
bryan sefcik
fbb134632a Added more missing generated.h includes.
#jira
#preflight 639cad22680483bcb12e021f

[CL 23942821 by bryan sefcik in ue5-main branch]
2023-01-31 20:21:25 -05:00
philippe deseve
85aca0649a Add a way to check if a path point to content bundle content but is not an ExternalActor
#rb richard.malo

[CL 23922861 by philippe deseve in ue5-main branch]
2023-01-31 01:04:03 -05:00
jason weiler
f6a2d36ca9 [Backout] - CL23883670
[FYI] jason.weiler
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL23878204
[FYI] jason.weiler
Original CL Desc
-----------------------------------------------------------------
Editor's "Check Content" validation fails when referencing a Verse class.
References to verse type packages should be simply skipped in the verifier.


#rb markus.breyer
#preflight 63d1728d6a14d8406d6edf53
#preflight 63d18925574ab9cae4d0b959
#preflight 63d2fdcef6267152013a8f89

[CL 23890515 by jason weiler in ue5-main branch]
2023-01-27 15:20:22 -05:00
jason weiler
80d97e448b [Backout] - CL23878204
[FYI] jason.weiler
Original CL Desc
-----------------------------------------------------------------
Editor's "Check Content" validation fails when referencing a Verse class.
References to verse type packages should be simply skipped in the verifier.


#rb markus.breyer
#preflight 63d1728d6a14d8406d6edf53
#preflight 63d18925574ab9cae4d0b959
#preflight 63d2fdcef6267152013a8f89

[CL 23889593 by jason weiler in ue5-main branch]
2023-01-27 14:54:17 -05:00
jason weiler
f2bee70500 Editor's "Check Content" validation fails when referencing a Verse class.
References to verse type packages should be simply skipped in the verifier.


#rb markus.breyer
#preflight 63d1728d6a14d8406d6edf53
#preflight 63d18925574ab9cae4d0b959
#preflight 63d2fdcef6267152013a8f89

[CL 23889279 by jason weiler in ue5-main branch]
2023-01-27 14:43:43 -05:00
henrik karlsson
9a1d5b1ad4 [Engine/Plugins]
* Ran IWYU on ~170 plugins to remove includes not needed. Public api still keep old includes inside #if UE_ENABLE_INCLUDE_ORDER_DEPRECATED_IN_5_2

#preflight 63d09351574ab9cae4670216
#rb none

[CL 23844750 by henrik karlsson in ue5-main branch]
2023-01-25 02:42:36 -05:00