Commit Graph

115 Commits

Author SHA1 Message Date
ben zeigler
708a868ca8 Change content browser asset registry callbacks to ignore directory paths like __ExternalActors__ that can never be searched for. This significantly improves the initial asset registry scan performance
#jira UE-183275
#rb julien.stjean, rex.hill

[CL 27351358 by ben zeigler in ue5-main branch]
2023-08-24 14:36:59 -04:00
julien stjean
c19fe82eb4 Fixed an issue where the contextual menu interpreted the relative file path of a source file an the display label instead of using the actual display label store with the source file.
#rb Alexis.Matte

[CL 26739466 by julien stjean in ue5-main branch]
2023-08-01 11:01:43 -04:00
julien stjean
a32f5bee98 Fixed an issue where the contextual menu for the asset reimport would consider multiple assets to be only one asset when all the asset are of the same type.
#rb trivial
#jira UE-180553

[CL 26716899 by julien stjean in ue5-main branch]
2023-07-31 15:08:48 -04:00
julien stjean
d6a10a9267 Adding an missing count to the number of assets we were able to retrive some information about their source file in the FAssetFileContextMenu::GetSelectedAssetSourceFilePaths function.
#rb none
[FYI] Alexis.Matte

[CL 26694575 by julien stjean in ue5-main branch]
2023-07-28 22:19:49 -04:00
julien stjean
3a24e47037 Fixed an issue with the api of the asset definitions. The GetSourceFiles function didn't allow to resolve the source file paths in a way that is independant of the asset implementation details.
Added the capacitity to the AssetImportData to resolve a source file name without a loaded package.

This also fixes the issues where the editor is not able to find the source file during a reimport or simply navigating to that file via the content browser.

#jira UE-180553
#rb Kerim.Borchaev

[CL 26609365 by julien stjean in ue5-main branch]
2023-07-26 11:46:14 -04:00
aditya ravichandran
d822cb508a Add an option to the Outliner to bulk edit components in the Property Matrix
#rb jeanmichel.dignard
#preflight 646fc7ef560bb18621ab144b

[CL 25647201 by aditya ravichandran in ue5-main branch]
2023-05-26 12:51:22 -04:00
aditya ravichandran
07f12688e4 Property Matrix Reskin
#rb JeanMichel.Dignard
#preflight 646413f5fa4cf41651def1a5

[CL 25507370 by aditya ravichandran in ue5-main branch]
2023-05-17 10:49:51 -04:00
kirill zorin
de8db5ff76 Converting ARO-facing raw pointers to TObjectPtr ahead of raw pointer ARO API deprecation.
#rb zousar.shaker
#rb markus.breyer
#rb robert.manuszewski

#preflight 646391406b1406b54ab15460

[CL 25489627 by kirill zorin in ue5-main branch]
2023-05-16 10:52:49 -04:00
julien stjean
8787c97df0 Additional improvement for the filter compilations of the asset views.
Added a system to cache some data that can be used when recompiling the filters for the incremental data updates.
For now this only used by for the asset data source internal path compilation of the asset views.

In my test on a bad scenario this yielded a reduction 98% of the time it take to call UContentBrowserAssetDataSource::CreateAssetFilter when the cache is used.

Before the optimization the reference call took  26.3 ms
After the optimization the reference call took 0.3725 ms

Also this change fix an issue with my last change interacting badly with the alias data source by not using its customization of the package paths hierarchy.

#preflight 645a92f42d27fa25b3069003
#jira UE-183276
#rb Rex.Hill

[CL 25396753 by julien stjean in ue5-main branch]
2023-05-09 18:06:59 -04:00
julien stjean
71cc3dbeb5 Perf improvement to the function UContentBrowserAssetDataSource::CreateAssetFilter.
For a large project with a lot paths with a recursive search on all the folder the change reduced time it took to create the filter by ~86%.

Before the change a function call took 191.3 ms
After the change the same function call took 25.8 ms

#jira UE-183275
#preflight 64499a7709453df548d462f5
#rb Rex.Hill, Robert.Millar

[CL 25283516 by julien stjean in ue5-main branch]
2023-05-01 10:09:15 -04:00
julien stjean
703a8ebc8f Adding some cpu traces for the content browser data source filter compilation.
#jira UE-183269
#rb none
#rnx
#preflight 64493e39b208f61af8999741

[CL 25202960 by julien stjean in ue5-main branch]
2023-04-26 13:56:32 -04:00
scott nelson
15371dad4c Fix entity delete and right click save on level assets not generating UEFN Playsets
#rb Dave.Belanger
#preflight 6441bc6f641e2c3cb462a5bf

[CL 25175438 by scott nelson in ue5-main branch]
2023-04-24 23:20:03 -04:00
paul chipchase
85393b704b Speed up the creation of the new asset content menu
#rb JeanMichel.Dignard
#jira none
#rnx
#preflight 643e375f702378c5730c8548

- Profiling showed 60ms->10ms, improving the responsiveness.
- Calling IAssetTools::GetNewAssetFactories is relatively expensive, so I added an overload of FindFactoriesInCategory that can have a TArray of factories passed to it and then calling IAssetTools::GetNewAssetFactories only once, rather than one time per category as was being done

[CL 25100992 by paul chipchase in ue5-main branch]
2023-04-19 02:27:36 -04:00
jamie dale
b95e92ef3d Content Browser UX improvements for cooked content
* Plugins that only contain cooked content (and have no C++ modules) no longer show their "Content" suffix.
* Folders that only contain private cooked content are no longer visible in the asset or path views.

#preflight 642f2e3cb306e98c632f0195
#rb Jason.Stasik, Aditya.RaviChandran

[CL 24994922 by jamie dale in ue5-main branch]
2023-04-11 14:22:33 -04:00
rex hill
4a9460be92 Add export class permission list
#preflight 643446394c3ccbbdf17e8269
#rnx
#rb dave.belanger

[CL 24994901 by rex hill in ue5-main branch]
2023-04-11 14:22:04 -04:00
scott nelson
c5c4059f2c Update wording of trying to edit cooked assets to be less scary for new users
#rb Derek.Truong
#preflight skipped

[CL 24851397 by scott nelson in ue5-main branch]
2023-03-30 02:50:12 -04:00
rex hill
ed58dd9174 Content Browser - Fix cooked assets no longer showing up
#rb lauren.barnes
#preflight 6410b27b3c2db40029ed92dc

[CL 24643996 by rex hill in ue5-main branch]
2023-03-14 16:50:12 -04:00
julien stjean
dbb4e180b0 Asset data event generated by the asset redirectors are considered as UAssset and they need don't a special handling from the ContentBrowser core functionnality.
This also fix an issue with the redirectors not being displayed by ContentBrowser.

#jira UE-178973
#rb Lauren.Barnes
#rnx
#preflight 6408e25e6e1dadfcda206563

[CL 24567275 by julien stjean in ue5-main branch]
2023-03-08 16:38:43 -05:00
paul chipchase
6e57dd4c26 The content browser can now respond to packages changing on disk.
#rb Julien.StJean, Matt.Peters
#jira UE-177133
#preflight 64072b19ba12ba64167e20e6

- In the last year we have started to make changes to the package format to allow data to be stored in the same file, but not actually inside of the package itself (See FPackageTrailer) and we might consider moving some other data blobs there in the future. This change has meant that there are code paths that can change things with the package file, that don't actually call save package, such as the process that virtualizes assets and can leave incorrect, stale data in the content browser tool tip.
-- This means when a user virtualizes an asset, the tooltip might indicate that it has not been virtualized and the size of the file on disk has not been changed until they browser to a different folder and browse back to refresh. This has caused people to believe that the virtualization operation has failed.
- This change hooks up UContentBrowserAssetDataSource to trigger a EContentBrowserItemUpdateType::Modified event when ever the package file changes on disk.
- During package save this could trigger multiple EContentBrowserItemUpdateType::Modified events for the same package (one from saving and one from the file being modified) but it looks like duplicate events already occur (if the packages are checked out as part of the save, this will introduce another EContentBrowserItemUpdateType::Modified event). There is a TODO in the code that suggests we might want to spend time removing duplicates events before broadcasting the delegate but when profiling I found that the overhead is quite low. In one test, saving 20 packages cost 4ms for the events triggered by the save and an additional 4ms for the events triggered by the file changing on disk. With the margins being so low it still doesn't look like a problem that is worth spending time on, however I did add a TRACE_CPUPROFILER_EVENT_SCOPE to the broadcasting of the delegate (UContentBrowserDataSubsystem::ItemDataUpdatedDelegate) so if it does become a problem in the future it will be easier to track down.

[CL 24556355 by paul chipchase in ue5-main branch]
2023-03-08 04:32:05 -05:00
lauren barnes
4a80733104 Checking for external assets in IsPrimaryAsset to avoid content browser updates on external assets
#rb Julien.StJean
#preflight 6400b66e3206d45d20a067a6

[CL 24486819 by lauren barnes in ue5-main branch]
2023-03-02 14:05:25 -05:00
randy jones
c802f4a1ff Add more scope traces to investigate UContentBrowserDataSubsystem::Tick() hitches during PIE
#rb danny.couture
#swarm 24363495
#preflight 63f5b41dac06ce789ff1eab6

[CL 24370912 by randy jones in ue5-main branch]
2023-02-22 17:27:16 -05:00
alexis matte
a20c1131ce Change asset tools import extension support to FNamePermissionList instead of FString. This allow to control the permissions like all the other permission.
#rb jeanluc.corenthin
#preflight 63e24fad07207b2570b72285

[CL 24049361 by alexis matte in ue5-main branch]
2023-02-07 10:49:14 -05:00
aditya ravichandran
db59eb4a2c Content Browser: Improve UX around unsupported assets
#preflight 63e15a201020773a3f0f987e
#rb Lauren.Barnes, Julien.StJean

[CL 24040935 by aditya ravichandran in ue5-main branch]
2023-02-06 18:22:57 -05:00
julien stjean
55a1b3af29 Introducing the unsupported asset item for the content browser.
These are currently used to display the asset that are hidden by a backend class permission system.
They can also be restricted to some path only if desired.
Note: We will do a UX pass for the unsupported items after this is submitted and later we will also add some support for the unsupported asset to the alias data source.

#preflight 63dc23a7175a9839ac4cf474
#rb Jason.Stasik

[CL 24007061 by julien stjean in ue5-main branch]
2023-02-03 22:39:50 -05:00
scott nelson
41cf7777e9 Fixup read only folder wording
#rb Derek.Truong
#preflight 63d19829be435f17b4082cd6

[CL 23864776 by scott nelson in ue5-main branch]
2023-01-26 02:25:07 -05:00