Commit Graph

1759 Commits

Author SHA1 Message Date
helge mathee
6c4319ca15 RigHierarchy: Improve performance of UpdateCachedChildren
#rb sara.schvartzman

[CL 27877307 by helge mathee in ue5-main branch]
2023-09-14 09:53:37 -04:00
jaime cifuentes
f52c8f0817 Fixed CIS error due to uninitialized var
#rb trivial

[CL 27803557 by jaime cifuentes in ue5-main branch]
2023-09-12 15:19:18 -04:00
sara schvartzman
3a0b3d47dd Control Rig: FIx compilation error
#rb trivial
#rnx

[CL 27795027 by sara schvartzman in ue5-main branch]
2023-09-12 12:09:25 -04:00
sara schvartzman
4cd9ba3c6e Control Rig: Fix bool controls not working properly in additive control rigs
#jira UE-193392
#rb helge.mathee
#rnx

[CL 27794688 by sara schvartzman in ue5-main branch]
2023-09-12 12:01:27 -04:00
sara schvartzman
cdaee32019 Control Rig: FIx static analysis error
#rb trivial
#rnx

[CL 27794507 by sara schvartzman in ue5-main branch]
2023-09-12 11:56:57 -04:00
halfdan ingvarsson
eeb5b51fc8 [Backout] - CL27758540
[FYI] halfdan.ingvarsson
Original CL Desc
-----------------------------------------------------------------
Control Rig: Move loading of the control enum for rig element settings to postload.

#rb helge.mathee
#rnx

[CL 27792780 by halfdan ingvarsson in ue5-main branch]
2023-09-12 11:15:42 -04:00
sara schvartzman
1bd2bff83f Control Rig: Adds ScaleFloat as a control type
#jira UE-193392
#rb helge.mathee

[CL 27789089 by sara schvartzman in ue5-main branch]
2023-09-12 09:14:49 -04:00
helge mathee
d5f2b453c2 ControlRig: Only draw nulls / axes in the preview world / asset editor
#rb na
#jira UE-194163

[CL 27788473 by helge mathee in ue5-main branch]
2023-09-12 08:39:59 -04:00
sara schvartzman
69dae541fe Control Rig: Added missing comment for additive control rigs
#rb trivial
#rnx

[CL 27788264 by sara schvartzman in ue5-main branch]
2023-09-12 08:29:10 -04:00
helge mathee
f40f06101d Control Rig: Avoid double registration of onControlModified
#rb na
#jira UE-194168

[CL 27787954 by helge mathee in ue5-main branch]
2023-09-12 08:10:29 -04:00
sara schvartzman
118996dd01 Control Rig: Ui refactor for sequencer
#jira UE-193117
#rb helge.mathee
#rnx

[CL 27787016 by sara schvartzman in ue5-main branch]
2023-09-12 06:57:12 -04:00
helge mathee
55a7981394 ControlRig: Avoid redundant control visibility related warning
#rb na
#jira UE-194581

[CL 27786869 by helge mathee in ue5-main branch]
2023-09-12 06:48:14 -04:00
jaime cifuentes
b10c4065f2 RigVM now uses a struct based storage, built on top of PropertyBag.
#rb [at]helge.mathee, [at]sara.schvartzman
#jira UE-180115

[CL 27785576 by jaime cifuentes in ue5-main branch]
2023-09-12 05:04:58 -04:00
halfdan ingvarsson
66f58ca1fc Control Rig: Add CurveExists utility node and fix validation of GetCurveValue.
#jira UE-195092, UE-195091
#rb none

[CL 27784388 by halfdan ingvarsson in ue5-main branch]
2023-09-12 03:20:50 -04:00
david bromberg
ba6a2c427c Sequencer- Improve performance of searching for items in large sequences by keeping the Spawnables, Possessables, and ObjectBindings arrays sorted by FGuid and using BinarySearch where searching is necessary. Testing was performed on adds and searches in these arrays to ensure improvement (to searches). Adds are a bit more expensive, but should be alright in the vast majority of use cases. Iimprovement could be made if necessary to bulk additions by adding bulk operation functionality.
[REVIEW] [at]ue-sequencer
#jira UE-111561

[CL 27759752 by david bromberg in ue5-main branch]
2023-09-11 13:19:25 -04:00
halfdan ingvarsson
61ca791dc6 Control Rig: Move loading of the control enum for rig element settings to postload.
#rb helge.mathee
#rnx

[CL 27758580 by halfdan ingvarsson in ue5-main branch]
2023-09-11 12:44:37 -04:00
benoit gadreau
7c004866a5 New TRS Gizmo updates
- arcball rotation: the rotation is computed using a spherical+hyperbolic projection (see code for more explanation)
    - indirect manipulation via MMB: hit parts are stored per mode then are used to drive the proper drag function
    - defered drag function: in order to avoid notifications storm, the drag functions can be applied on tick instead using a pending function
    - a single default TRS gizmo is now created when needed (instead of creating several thru selection changed or when the gizmo manager was ticking) and its visibility is set based on rules

TODO
    - UEditorInteractiveGizmoManager is now closer to UInteractiveGizmoManager so I don't think we need ActiveEditorGizmos, CachedGizmoMap, etc. that are not used anymore. This should be cleaned in another CL
    - UEditorTransformGizmo::OnGizmoTransformBegin should set the current axis (needed for some modes, including IKRig) but this is disabled for now has there are some side effects with dragging (this will be treated in another CL)


#jira UE-152973
#jira UE-161236
#rb brooke.hubert zach.rammell

[CL 27751789 by benoit gadreau in ue5-main branch]
2023-09-11 09:54:48 -04:00
sara schvartzman
4297a0ba43 Control Rig: Fix snapper not working with additive rigs
#jira UE-193606
#rb mike.zyracki
#rnx

[CL 27748220 by sara schvartzman in ue5-main branch]
2023-09-11 05:15:25 -04:00
benoit gadreau
2418883c42 Constraint & additive ControlRig:
In the context of additive rigs, the evaluation as to be forced after setting the control value to request keyframing thru the OnControlModified delegate.
    Not doing this results in the keys not being added (FControlRigParameterTrackEditor::HandleControlModified is not in game thread when evaluating the additive rig) so there's not new FMovieSceneRootEvaluationTemplateInstance created

NOTE
   Calling Evaluate_AnyThread here will force the update off every controls whereas we're just trying to add keys on a single one. Having a function taht could only compute the additive value on a set of keys could help reducing the cost but there might be some side effets as well.
   Leaving this as it is for now as additive rigs are still experimental atm.

#jira UE-193993
#rb sara.schvartzman

#rnx

[CL 27707896 by benoit gadreau in ue5-main branch]
2023-09-08 07:45:31 -04:00
sara schvartzman
89fe5d7d6c Control Rig: Hides additive control rigs behind CVar ControlRig.Sequencer.EnableAdditiveControlRigs
#rb trivial
#rnx

[CL 27676266 by sara schvartzman in ue5-main branch]
2023-09-07 13:04:36 -04:00
helge mathee
6b4c55d5c0 Control Rig: Maintain local pos / scl if parent scale is zero
#rb sara.schvartzman
#jira UE-194205

[CL 27671445 by helge mathee in ue5-main branch]
2023-09-07 09:47:08 -04:00
helge mathee
7e5b7c0d53 Control Rig: Avoid crash with SKM with out a skeleton
#rb na

[CL 27669759 by helge mathee in ue5-main branch]
2023-09-07 08:18:59 -04:00
sara schvartzman
8bf6a3cc47 Control Rig: Fix proxy controls not behaving correctly
#jira UE-193603
#rb helge.mathee
#rnx

[CL 27669227 by sara schvartzman in ue5-main branch]
2023-09-07 07:40:33 -04:00
sara schvartzman
9355cd800d Control Rig: Fix compilation issue
#rnx

[CL 27631783 by sara schvartzman in ue5-main branch]
2023-09-06 09:13:06 -04:00
sara schvartzman
383e00640e Control Rig: Fix compilation issue
#rnx

[CL 27631635 by sara schvartzman in ue5-main branch]
2023-09-06 08:59:32 -04:00