Commit Graph

68 Commits

Author SHA1 Message Date
robert millar
49bbf540a7 Add path name to assertions
#rb none

[CL 27861752 by robert millar in ue5-main branch]
2023-09-13 20:28:09 -04:00
jurre debaare
0309af427d Always force-set float/transform controls during AnimSequencerData evaluation
#rb Thomas.Sarkanen

[CL 27335950 by jurre debaare in ue5-main branch]
2023-08-24 05:02:39 -04:00
max chen
ae5943a9c3 Sequencer Scripting: Change to get/set view and working ranges to double
#jira UE-192832
#rb david.bromberg

[CL 27240177 by max chen in ue5-main branch]
2023-08-21 11:27:20 -04:00
jurre debaare
8dc2c722e9 Fixup incorrect by-value to by-const-ref
#rb Thomas.Sarkanen

[CL 27200995 by jurre debaare in ue5-main branch]
2023-08-18 09:45:36 -04:00
helge mathee
58cd171e37 Control Rig: Improve FName FString conversion
#rb sara.schvartzman

[CL 27197375 by helge mathee in ue5-main branch]
2023-08-18 04:03:07 -04:00
kiaran ritchie
615b185110 Fixes IK Retarget editor bug, undo queue broken after exporting animation
#rb trivial

[CL 26662082 by kiaran ritchie in ue5-main branch]
2023-07-27 20:00:12 -04:00
thomas sarkanen
bb0f638c25 Fix ensure when transforming bone indices during animation compression
Use the non-deprecated conversion function

#jira UE-190741
#rb Nicholas.Frechette

[CL 26544136 by thomas sarkanen in ue5-main branch]
2023-07-24 11:39:11 -04:00
thomas sarkanen
295f81df17 Fix crash from incorrect bone index type usage in UAnimationSequencerDataModel::GeneratePoseData
Also fixed bone index usage in FAnimPose::GetPose

#rb Nicholas.Frechette
[FYI] Jurre.deBaare

[CL 26482431 by thomas sarkanen in ue5-main branch]
2023-07-20 07:41:53 -04:00
thomas sarkanen
13f32cf5fa Fix use-after free when duplicating animation attributes
#rb Nicholas.Frechette
[FYI] Jurre.deBaare

[CL 26460033 by thomas sarkanen in ue5-main branch]
2023-07-19 10:15:36 -04:00
jurre debaare
b641fe84b6 Fix for incorrect frame number calculation when updating/adding anim curve key
#fix ensure that newly added movie scene curve always match their tick resolution to the MovieScene
#misc added additional validation to ensure requested action is performed correctly
#rb Thomas.Sarkanen

[CL 26254245 by jurre debaare in ue5-main branch]
2023-06-27 07:18:52 -04:00
Jurre deBaare
3cb883a68d Float Curve Keys added via AddFloatCurveKey are no longer frame aligned in 5.2
#jira UE-186353, UE-188631
#rb Euan.Carmichael

[CL 26207697 by Jurre deBaare in ue5-main branch]
2023-06-23 06:44:20 -04:00
Jurre deBaare
ea87923f4c ExportAnimSequence tries to re-initialize animation data model
#jira UE-189247
#rb Thomas.Sarkanen

[CL 26207668 by Jurre deBaare in ue5-main branch]
2023-06-23 06:42:29 -04:00
jurre debaare
1f125b13e3 Different approach for setting initial random color for newly added float curves
#rnx

[CL 26148387 by jurre debaare in ue5-main branch]
2023-06-21 10:16:09 -04:00
jurre debaare
b871ad62e3 Change ordering of undo/redo actions in UAnimSequencerController::AddCurve
#rb none

[CL 26125364 by jurre debaare in ue5-main branch]
2023-06-20 12:25:30 -04:00
Jurre deBaare
a8b90830e3 Curve Keys appears to be white no matter how many keys are added on all Curves
#jira UE-188493
#fix match old behaviour: generate a unique colour for newly added curve(s)
#rb Thomas.Sarkanen

[CL 26090144 by Jurre deBaare in ue5-main branch]
2023-06-19 10:28:19 -04:00
jurre debaare
877722dd68 UEFN Editor Ensure at UAnimationSequencerDataModel::GeneratePoseData
Content Worker Ensure at FBoneContainer::GetCompactPoseIndexFromSkeletonIndex

#rb Thomas.Sarkanen

[CL 25975176 by jurre debaare in ue5-main branch]
2023-06-14 08:54:44 -04:00
Jurre deBaare
bb2c517e06 AnimSequencerDataModel: handle certain curve/bone changes directly - forcing an update on the FKRig for the cached (control) data
#rb Euan.Carmichael

[CL 25974292 by Jurre deBaare in ue5-main branch]
2023-06-14 06:55:23 -04:00
euan carmichael
ddf4cc4cf4 Fix for crash when adding curves to anim sequences and immediately getting the bone pose
#jira UE-187647
#rb sara.schvartzman
#lockdown aurel.cordonnier

[CL 25856612 by euan carmichael in ue5-main branch]
2023-06-07 16:25:14 -04:00
thomas sarkanen
f1c828714a Speculative fix for crash during automated test
All other accesses to GetControlRigTrack() are guarded by a null check, this adds one to GetFKControlrigSection()

#jira UE-188025
#rb Jaime.Cifuentes

[CL 25853372 by thomas sarkanen in ue5-main branch]
2023-06-07 15:10:43 -04:00
thomas sarkanen
6ee22276df Fix crash when undoing/redoing animation sequence edits while an async task is in flight
Guards the PreEditUndo/PostEditUndo bracket so that any transaction modifications cannot occur at the same time as async compression/evaluation

#jira UE-187374
#rb Nicholas.Frechette

[CL 25843787 by thomas sarkanen in ue5-main branch]
2023-06-07 09:53:17 -04:00
mike zyracki
4ea8fe31e1 Animation Sequence: Do not recreate CR cache when added unless model is populated and never when curve is added when populated.
#rb thomas.sarkanen

[CL 25819570 by mike zyracki in ue5-main branch]
2023-06-06 12:40:25 -04:00
bryan sefcik
62d3f94e73 Removed public module dependencies because they aren't used by the module making them public and they create circular dependency issues.
#preflight 6478a35ec26e3b2449f1afcf
#jira

[CL 25745177 by bryan sefcik in ue5-main branch]
2023-06-01 17:53:45 -04:00
jurre debaare
fd2dce1934 [Backout] - 25598140
#fix removed debug/test check()

Original CL Desc
-----------------------------------------------------------------
[Backout] - CL25581118
UAnimSequence::IsCachedCookedPlatformDataLoaded Can Cause Cooks To Soft Lock
    - Add safety net in AnimSequence::PreSave to generate compressed data if necessary
    - Only try and update animation sequence with skeleton data (if it is actually out-of-date)
    - Deprecated ClearCompressedBoneData and ClearCompressedCurveData
    - Only early out of AnimSequence::BeginCacheDerivedData if hash matched running platform, if the data is _actually_ valid
    - AnimSequence::TryCancelAsyncTasks now only cancels the task, and leaves AnimationSequenceCompiler to clean up
    - AnimSequence::IsAsyncTaskComplete only returns true if _all_ tasks have finished (not just one)
    - AnimSequence::FinishAsyncTasks now handles cancelled tasks -> clear out compressed data, map entry and reset running platform hash (if applicable)
#rb Thomas.Sarkanen
#preflight 25504434

[CL 25599749 by jurre debaare in ue5-main branch]
2023-05-24 06:33:30 -04:00
bob tellez
1977ae1d70 [Backout] - CL25581118
[FYI] Jurre.deBaare
Original CL Desc
-----------------------------------------------------------------
UAnimSequence::IsCachedCookedPlatformDataLoaded Can Cause Cooks To Soft Lock
    - Add safety net in AnimSequence::PreSave to generate compressed data if necessary
    - Only try and update animation sequence with skeleton data (if it is actually out-of-date)
    - Deprecated ClearCompressedBoneData and ClearCompressedCurveData
    - Only early out of AnimSequence::BeginCacheDerivedData if hash matched running platform, if the data is _actually_ valid
    - AnimSequence::TryCancelAsyncTasks now only cancels the task, and leaves AnimationSequenceCompiler to clean up
    - AnimSequence::IsAsyncTaskComplete only returns true if _all_ tasks have finished (not just one)
    - AnimSequence::FinishAsyncTasks now handles cancelled tasks -> clear out compressed data, map entry and reset running platform hash (if applicable)
#rb Thomas.Sarkanen
#preflight 25504434

[CL 25598269 by bob tellez in ue5-main branch]
2023-05-24 02:07:24 -04:00
jurre debaare
3820225b59 Fix disappearing curves, scalar parameter entry is used for (re)populating FK rig hierarchy during PostLoad
#rb Thomas.Sarkanen
#preflight 646cb84664351d76f31ca4ae

[CL 25584063 by jurre debaare in ue5-main branch]
2023-05-23 11:41:18 -04:00