Commit Graph

24 Commits

Author SHA1 Message Date
jeremy moore
e3a94c217d Convert a checkSlow() to a check() with the hope that it might help track down FORT-496541
#ROBOMERGE-AUTHOR: jeremy.moore
#ROBOMERGE-SOURCE: CL 21437196 via CL 21437202 via CL 21437210 via CL 21437219
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v981-21435820)

[CL 21437851 by jeremy moore in ue5-main branch]
2022-08-17 22:56:33 -04:00
steve robb
fd2a0b1e20 Removal of TEXT literal concatenations, which doesn't work in UTF-8 mode.
#rb devin.doucette
#jira UE-132142
#preflight 62a8748fa76c84377748036b

#ROBOMERGE-OWNER: steve.robb
#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 20647443 via CL 20648283 via CL 20648315
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v955-20579017)

[CL 20651786 by steve robb in ue5-main branch]
2022-06-14 12:46:34 -04:00
Andriy Tylychko
3b82927aee removed unused NewTasks from TaskGraph's FGraphEvent::DispatchSubsequents() calls, as a preparation for deprecation
#preflight https://horde.devtools.epicgames.com/job/6244160fdc6183e3f5ef6650
#rb francis.hurteau, danny.couture

[CL 19554617 by Andriy Tylychko in ue5-main branch]
2022-03-30 04:53:52 -04:00
dan thompson
17ae342aa6 Fix for spurious FileCache/CompressionBlockSize warning:
-- When not using iostore containers
-- When not using compression
#rb trivial
[FYI] carlmagnus.nordin
[FYI] charles.bloom
#preflight 61f43351801201ab3890cd22

#ROBOMERGE-AUTHOR: dan.thompson
#ROBOMERGE-SOURCE: CL 18774859 in //UE5/Release-5.0/... via CL 18774927 via CL 18775395
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18775464 by dan thompson in ue5-main branch]
2022-01-28 13:51:28 -05:00
dan thompson
f903f566d5 Add a warning for when the FileCache block size doesn't match any iostore container compressed block sizes.
#rb CarlMagnus.Nordin
#preflight 61dc76678f44ab439b39e987

#ROBOMERGE-AUTHOR: dan.thompson
#ROBOMERGE-SOURCE: CL 18562735 in //UE5/Release-5.0/... via CL 18562758
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18562781 by dan thompson in ue5-release-engine-test branch]
2022-01-10 13:43:28 -05:00
andrew davidson
b98537f02b UNSAFE_TYPECAST_WARNING macros allow force enabling of warnings.
#[fyi] michael.noland
#preflight 61d86fa3c65e66487b36b5c0

#ushell-cherrypick of 18546856 by Andrew.Davidson

#ROBOMERGE-AUTHOR: andrew.davidson
#ROBOMERGE-SOURCE: CL 18552595 via CL 18552601 via CL 18552604 via CL 18553016 via CL 18553035
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18553054 by andrew davidson in ue5-release-engine-test branch]
2022-01-07 20:09:18 -05:00
andrew davidson
83f6ea2c8a Undo //Fortnite/Dev-EngineMerge-Test2/Engine/... changelist 18551315
#ROBOMERGE-AUTHOR: andrew.davidson
#ROBOMERGE-SOURCE: CL 18552107 via CL 18552130 via CL 18552133 via CL 18552520 via CL 18552534
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18552539 by andrew davidson in ue5-release-engine-test branch]
2022-01-07 19:03:23 -05:00
andrew davidson
9dc047e01d UNSAFE_TYPECAST_WARNING macros allow force enabling of warnings.
[FYI] michael.noland
#preflight 61d86fa3c65e66487b36b5c0

#ROBOMERGE-AUTHOR: andrew.davidson
#ROBOMERGE-SOURCE: CL 18546856 in //UE5/Release-5.0/... via CL 18546891
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18546909 by andrew davidson in ue5-release-engine-test branch]
2022-01-07 12:27:01 -05:00
aurel cordonnier
a6e741e007 Merge from Release-Engine-Staging @ 17915896 to Release-Engine-Test
This represents UE4/Main @17911760, Release-5.0 @17915875 and Dev-PerfTest @17914035

[CL 17918595 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-25 20:05:28 -04:00
jeremy moore
94f4444383 Make file cache block size configurable with (read only) CVar fc.BlockSize
#rb ben.ingram
#preflight 611d23203a81b0000133853f

#ROBOMERGE-SOURCE: CL 17216210 via CL 17216219
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v855-17104924)

[CL 17218065 by jeremy moore in ue5-release-engine-test branch]
2021-08-18 13:36:31 -04:00
eric mcdaniel
4d98aaa4fe Fix for potential deadlock in shader preloads
FPreloadShaderTask takes the ShaderPreloadLock in FShaderCodeArchive::OnShaderPreloadFinished() and then issues an async read.  Another task can be picked up by the thread while waiting on that read.  If that new task is also a FPreloadShaderTask it will try to aquire the ShaderPreloadLock again and deadlock.

Introduce an EnsureReadNonBlocking method to IMemoryReadStream which can be called outside the lock to ensure the data is ready.  We can then lock and copy out the data without incuring a wait and the potential for another FPreloadShaderTask being run while we hold the lock.

#rb Ben.Ingram, Michal.Valient

#ROBOMERGE-SOURCE: CL 16917416 via CL 16924675
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v836-16769935)

[CL 16925027 by eric mcdaniel in ue5-release-engine-test branch]
2021-07-22 11:57:21 -04:00
jeremy moore
6d29b32a60 Use a map to store the transient per line info in the FileCache.
Saves memory compared to allocating arrays for all lines.
#rb ben.ingram

#ROBOMERGE-SOURCE: CL 16680895 via CL 16680907
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v835-16672529)

[CL 16680918 by jeremy moore in ue5-release-engine-test branch]
2021-06-15 18:11:04 -04:00
pj kack
f678505362 FileCache: Restore the UE4 default value fc.NumFileCacheBlocks=256.
#jira UE-117562
#rb carlmagnus.nordin
#rnx

#ROBOMERGE-SOURCE: CL 16670408 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v834-16658389)

[CL 16670427 by pj kack in ue5-release-engine-test branch]
2021-06-15 04:08:45 -04:00
Marc Audy
cac1fe0019 Merge UE5/Release-Engine-Staging @ CL# 15299266 to UE5/Main
This represents UE4/Main @ CL# 15277572

[CL 15299962 by Marc Audy in ue5-main branch]
2021-02-03 14:57:28 -04:00
Tim Smith
3c24615072 Fixing PVS 7.7 Issues:
warning V1062: The 'XYZ' class defines a custom 'new' operator. The 'delete' operator must also be defined.

#rb steve.robb
#jira UE-91644

[CL 15019000 by Tim Smith in ue5-main branch]
2021-01-08 08:16:38 -04:00
Michal Valient
95d19f95b1 [REVERB] Merging //UE4/Private-Reverb-Development@13832732
#rb graham.wihlidal, rune.stubbe, brian.karis, andrew.lauritzen, jeff.farris

[CL 13834854 by Michal Valient in ue5-main branch]
2020-07-06 18:58:26 -04:00
Marc Audy
11f5b21210 Merging //UE5/Release-Engine-Staging @ 13752110 to Main (//UE5/Main)
#rnx

[CL 13753156 by Marc Audy in ue5-main branch]
2020-06-23 18:40:00 -04:00
Matt Kuhlenschmidt
603a4119c5 Fix HAL/PlatformFileManager.h non-portable casing CIS issues
#rb none

[CL 13214257 by Matt Kuhlenschmidt in ue5-main branch]
2020-05-06 17:58:18 -04:00
ben ingram
8cf693bdad Fix data race when IFileCache handle is used by multiple threads
#rb none

#ROBOMERGE-SOURCE: CL 13152458 via CL 13161669 via CL 13161725 via CL 13161836
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v688-13145358)

[CL 13161907 by ben ingram in Main branch]
2020-05-04 21:14:35 -04:00
jeff newquist
9fa4defb8c Fixed all size variants of IAsyncReadRequest so they correctly wait inside of WaitCompletionImpl for a callback to be completed before returning.
Normal read requests have this behavior, but size requests were not respecting this, which caused problems when the constructor launches a callback on another thread and then immediately calls WaitCompletion, such as in the callback lambda inside FFileCacheHandle::FFileCacheHandle / PushCompletedRequest.
#rb rune.stubbe
#jira none
#rnx

#ROBOMERGE-SOURCE: CL 12974187 in //UE4/Release-4.25/... via CL 12974195 via CL 12974203
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v682-12900288)

[CL 12974208 by jeff newquist in Main branch]
2020-04-22 09:27:31 -04:00
ben ingram
73961fa70d Updates to FileCache to work better with shader preloading
- FileCache can dynamically allocate/release memory as needed
- Preloaded lines are locked in the cache.  One the preloaded memory has been read, the line is unlocked.  This prevents preloaded lines from being evicted before they're needed.
- Cache line size changed from 64k to 16k, reduce fragmentation due to locked preloaded lines
#rb none

#ROBOMERGE-SOURCE: CL 12491121 via CL 12491126 via CL 12491130
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v673-12478461)

[CL 12491133 by ben ingram in Main branch]
2020-03-30 17:41:29 -04:00
Brandon Schaefer
c57bf5c0dc Fix mis-match malloc/delete, which was causing a check to fail
#jira UE-91200
#rb Ben.Ingram

[CL 12455956 by Brandon Schaefer in 4.25 branch]
2020-03-26 15:30:52 -04:00
Ben Ingram
bf98b39a7c #jira UE-89879
Add extra logging to try to get more information about crash
#rb none

[CL 11964426 by Ben Ingram in 4.25 branch]
2020-03-05 16:37:13 -05:00
Josh Adams
aa9705149b Copying Private-LoadTimes-4.24 stream to Main. Biggest changes are in Materials/Shader memory freezing.
#rb none

[CL 11282608 by Josh Adams in Main branch]
2020-02-06 13:13:41 -05:00