Commit Graph

385 Commits

Author SHA1 Message Date
Max Preussner
97d1b77e1e UHT: Fixed a large number of missing 'override' warnings on Linux
This will not fix warnings for UObject classes that implement legacy C++ interfaces for which we generate code (GENERATED_IINTERFACE_BODY), because, as far as I can tell, the code generator is currently not able to detect those cases. For example: class UFont : public UObject, public IFontProviderInterface --- IFontProviderInterface gets a _getUObject() injected, but we cannot detect this in the code generation for UFont. Some more work is needed here. It might be better to simply always generate _getUObject() for all classes, so that there are no weird special cases.

#CodeReview: steve.robb, dmitry.rekman

[CL 2492772 by Max Preussner in Main branch]
2015-03-26 18:31:15 -04:00
Steve Robb
175b44a665 .generated.inl headers removed.
#codereview robert.manuszewski

[CL 2481705 by Steve Robb in Main branch]
2015-03-17 12:02:56 -04:00
Jaroslaw Palczynski
6c305898e0 UE-8578: Slate Widget fails to compile once added to a new project
Slate Widget was failing, because of missing Slate dependencies. Testing introduced a couple of problems which all was fixed by this CL:
1. I introduced AdditionalDependencies in .uproject file and change "Add Code To Project..." procedure to fill this array if needed. UBT reads this field and builds the project with required modules. Needed for Slate classes.
2. Changed UHT to #include missing headers in generated.h files if it was missing an include for it's super class. It was causing problems if we were trying to add a subclass of BrushShape -- BrushShape.h didn't have #include "Brush.h" and UBrushShape was inheriting from UBrush.
3. Above problems also occured for Slate classes, but not all of them was UCLASSes, so I had to fixed that manually.
4. "Add Code To Project..." functionality was not invalidating UBT makefiles, which lead to omitting new source files during hot-reloading (even thought it was reporting a success). This change also should improve a bit performance, cause right now there is no "gathering" step -- there is only invalidate step which is a lot quicker.
5. Fixed "Selected Class Source" link to source class in Slate Widget and Slate Widget Style class.

#codereview Robert.Manuszewski

[CL 2481488 by Jaroslaw Palczynski in Main branch]
2015-03-17 09:34:18 -04:00
Jaroslaw Palczynski
fa31560e2d Enabled UHT to digest GENERATED_BODY instead of GENERATED_UCLASS_BODY, GENERATED_USTRUCT_BODY, GENERATED_UINTERFACE_BODY or GENERATED_IINTERFACE_BODY, changed every occurence to the new syntax and fixed every warning that have fallen out of this change.
#codereview Robert.Manuszewski

[CL 2481333 by Jaroslaw Palczynski in Main branch]
2015-03-17 05:19:11 -04:00
Maciej Mroz
56e1ade4b0 Inner DELEGATEs as children. [By JaroslawP]
UE-11693 Compiler error when using Bind Event to OnTextChanged in UMG
UE-11674 BindEvent node gives "Wrong Event Dispatcher" error for BlueprintAssignable MC delegate

#codereview Jaroslaw.Palczynski

[CL 2477120 by Maciej Mroz in Main branch]
2015-03-12 14:06:13 -04:00
Jaroslaw Palczynski
f12f8a83bc UHT was reporting circular dependency if UClassA inherited UClassB defined in the same header. Fixed.
[CL 2473892 by Jaroslaw Palczynski in Main branch]
2015-03-10 12:06:49 -04:00
Mikolaj Sieluzycki
d7a081e634 Disable deprecation warnings in code generated by UHT.
[CL 2473643 by Mikolaj Sieluzycki in Main branch]
2015-03-10 08:24:59 -04:00
Robert Manuszewski
7f252d9994 Fixing UnrealHeaderTool not respecting class flags on unparsed classes used as property types in other classes.
- Fixed some properties requiring 'instanced' keyword even though their type was marked as 'defaulttoinstanced"
- Removed 'Placeable' keyword from ALandscape (it has long been deprecated)

[CL 2473550 by Robert Manuszewski in Main branch]
2015-03-10 06:14:19 -04:00
Saul Abreu
79a26091bf Fixed behavior on FString::ParseIntoArray (muliple delimiters overload) functionality to support optionally culling empty strings. Greatly simplified implementation logic. Output parameter now properly named and taken by reference.
#codereview Steve.Robb, Robert.Manuszewski

[CL 2466824 by Saul Abreu in Main branch]
2015-03-02 15:51:37 -05:00
Jaroslaw Palczynski
3c450b9477 UE-10111: Hot Reload crash with Scene Component tied to Actor class
We've changed the way vtable ptr are obtained for UClasses. Right now we use special empty constructor to get it, so we don't have to use normal one which was causing troubles. This special vtable helper constructor is generated automatically for most cases, but sometimes it's not possible (e.g. no default constructor for members types). In such case there is a possibility to override that generated constructor and write a custom one. The signature is UCustomClass::UCustomClass(FVTableHelper& Helper) and it needs to call base class'es constructor with the same parameter. Please do not use these constructors for anything else. There is no guarantee the object will be in correct state after calling this.

You can still disable this functionality if something breaks, just set WITH_HOT_RELOAD_CTORS to 0.

[CL 2466152 by Jaroslaw Palczynski in Main branch]
2015-03-02 06:44:04 -05:00
Mikolaj Sieluzycki
5c01918778 Change _Implementation and _Validation functions UHT warning message.
[CL 2453014 by Mikolaj Sieluzycki in Main branch]
2015-02-20 06:11:35 -05:00
Robert Manuszewski
98b487ffdc Making sure UHT does not try to automatically declare constructor with OI if the base class does not declare one.
[CL 2446180 by Robert Manuszewski in Main branch]
2015-02-14 17:40:09 -05:00
Jaroslaw Palczynski
6f783c9b2b UECORE-59: I want to be able to specify server/validation function names in UHT and not rely on predefined ones.
[CL 2435374 by Jaroslaw Palczynski in Main branch]
2015-02-06 09:54:41 -05:00
Zak Middleton
c99e2d9b73 #ue4 - Deprecating UProperties does not cause deprecation warnings in generated code.
[CL 2433874 by Zak Middleton in Main branch]
2015-02-05 13:10:48 -05:00
Robert Manuszewski
e56a5b49ee Deprecating 'operator new' for UObjects.
[CL 2425600 by Robert Manuszewski in Main branch]
2015-01-30 08:30:03 -05:00
Jaroslaw Palczynski
d99adaedff UHT: Fixes fully qualified path into relative ones. Fully paths was breaking cross-compilation in some cases.
#codereview Robert.Manuszewski, Peter.Sauerbrei

[CL 2413981 by Jaroslaw Palczynski in Main branch]
2015-01-21 12:32:28 -05:00
Josh Adams
9cf8c67c77 - Generate AndroidManifest.xml from ProjectSettings
- Moved some Android settings to ProjectSettings, re-enabled SDK settings
- Removed SigningConfig.xml, and moved those settings into project settings
- Added concept of NotForLicensees and NoRedist engine and project config settings
- Removed BaseInternalGame.ini, replaced with NotForLicensees/BaseGame.ini
- Moved User*.ini to end of .ini hierarchy
- Added support for CLASS_GlobalUserConfig, so their settings will be saved to <AppData>/.../User*.ini (useful for SDK paths, etc)
- Enabled AndroidPlatformEditor module on Mac
- Changed Mac Build.sh to allow for Android on the commandline (just pass through if it's not an Xcode platform name)
- Iterative Android packaging now looks at just the important .ini sections, NOT entire .ini files

#codereview jamie.dale,james.moran,michael.trepka,robert.jones,chris.babcock

[CL 2413870 by Josh Adams in Main branch]
2015-01-21 11:17:55 -05:00
Jaroslaw Palczynski
da737428aa UHT: Multiple UCLASS in header. Minor tweaks and comments.
[CL 2412453 by Jaroslaw Palczynski in Main branch]
2015-01-20 13:06:35 -05:00
Jaroslaw Palczynski
adecd4aaad UHT: Allows defining multiple UCLASSes in one header file.
[CL 2412156 by Jaroslaw Palczynski in Main branch]
2015-01-20 09:33:54 -05:00
Jaroslaw Palczynski
494b01ca46 UHT: Splitting generated CPP files fix.
UECORE-73

[CL 2408543 by Jaroslaw Palczynski in Main branch]
2015-01-16 05:02:48 -05:00
Steve Robb
80c6561731 Fix for GUID calculation on split generated files.
#codereview robert.manuszewski,jaroslaw.palczynski

[CL 2404828 by Steve Robb in Main branch]
2015-01-13 12:24:06 -05:00
John Abercrombie
4e9ac6444a Merging using UE4-Fortnite-To-UE4 @ CL 2382284
[CL 2388856 by John Abercrombie in Main branch]
2014-12-15 15:29:48 -05:00
Mikolaj Sieluzycki
62bcb126ce XBoxOne CIS fix.
[CL 2386109 by Mikolaj Sieluzycki in Main branch]
2014-12-11 16:29:40 -05:00
Mikolaj Sieluzycki
4b1f513db4 Emit warning if GetLifetimeReplicatedProps and functions with _Implementation and _Validate suffixes aren't declared.
#codereview Robert.Manuszewski

[CL 2385673 by Mikolaj Sieluzycki in Main branch]
2014-12-11 11:49:41 -05:00
Robert Manuszewski
a00117eff3 Making sure CRCs generated for UHT-generated code do not change across platforms.
[CL 2385269 by Robert Manuszewski in Main branch]
2014-12-11 04:58:57 -05:00