Commit Graph

270 Commits

Author SHA1 Message Date
ben hoffman
3cd99fcd75 Revert 21442104 because it crashes a blueprint when you open it.
#fyi massimo.tristano
#preflight skip
#rnx
#jira UE-161349

[CL 21448370 by ben hoffman in ue5-main branch]
2022-08-18 15:31:18 -04:00
massimo tristano
1f8d25197d Fixed Scalar Parameter and Vector node to avoid triggering a component value change transaction if the user only clicks on the textbox (without effectively changing the value).
Currently when the user clicks on a Scalar or Vector parameter text box and then simply deselects the node, a data change is erroneously detected and a transaction is pushed onto the Undo stack. This change fixes the logic that determines whether the value is actually changed, removing these spurious and redundant transactions.

#rb sebastian.nordgren
#jira UE-159512
#preflight 62fe4890200ff87e07bddf46

[CL 21442104 by massimo tristano in ue5-main branch]
2022-08-18 10:39:09 -04:00
Rob Gay
2ae22b2f87 Make Graph Knot API public so it can be extended
#preflight 62f186fe086f90bbc47f1c70

[CL 21276599 by Rob Gay in ue5-main branch]
2022-08-08 18:06:03 -04:00
dave jones2
52ee51c6a8 Build fix - missing headers.
#jira UE-158700
#rb none
#preflight none

[CL 20971216 by dave jones2 in ue5-main branch]
2022-07-06 15:11:16 -04:00
dave jones2
3799e9c331 UE-157166 - Vector literal pins lack precision with high values
Similar to other numerical Slate widgets, we need to templatize SGraphPinVector so that it can choose between a float and double representation. Currently, only the BP editor will use the double variant, while other tools continue to use a float.

This also update SGraphPinVector2D and SGraphPinVector4 to use a template. While we do use SGraphPinVector2D in BPs, we currently don't use SGraphPinVector4. However, that may change in the future.

#jira UE-157166
#preflight 62bf6898c438da7f09e95af0
#rb andrew.davidson

[CL 20947777 by dave jones2 in ue5-main branch]
2022-07-05 15:33:08 -04:00
jordan hoffmann
f2957e798a [Bug Fix] Navigating the Event Graph in Blueprint Diff window causes visual snapping issues
#jira UE-156552
#rb Phillip.Kavan
#preflight 62b245a4e9509b62d927a108
#preflight 62b24d09604d9ccfc7422282

[CL 20767743 by jordan hoffmann in ue5-main branch]
2022-06-21 19:07:19 -04:00
Marc Audy
e2dd041c0f Fix static analysis warnings
#codereview Helge.Mathee
#rnx
#preflight

[CL 20618311 by Marc Audy in ue5-main branch]
2022-06-11 22:32:15 -04:00
jordan hoffmann
490bccda39 [Feature] blueprint diff node outlines colored by diff state
#jira UE-150555
#rb aditya.ravichandran
#preflight 62a38ead2558795127e232d0

[CL 20600224 by jordan hoffmann in ue5-main branch]
2022-06-10 14:52:59 -04:00
Helge Mathee
0dce2873af GraphEditor: NodeHandle / PinHandle to rely on pin index as well
#rb yoan.stamant
#jira na
#preflight https://horde.devtools.epicgames.com/job/62a355cafe519cd512604302

[CL 20595372 by Helge Mathee in ue5-main branch]
2022-06-10 10:39:23 -04:00
jordan hoffmann
ff6648b05f [BugFix] BP_Diff data flow changes
- because the graphs were being diffed in two different ways - once to generate the list and once to determine how to render the nodes, there were some differences in the diff behavior that caused certain nodes to not render as diffed even though they showed up in the list. this change uses the same diff list for both now so there shouldn't be any differences anymore

- This also solves an issue that caused highlighted pins from Blueprint Diff to persist to the blueprint itself. Now all visual modifications made by the diff viewer only appear in the diff panels rather than the main graph
#jira UE-93061
#preflight 62a256ef2469f462fdd9c693
#rb daren.cheng

This change sets up for future style changes allowing for us to render nodes in the diff graph based on their diff type. There are no style changes in this CL however.

[CL 20584624 by jordan hoffmann in ue5-main branch]
2022-06-09 16:44:27 -04:00
jordan hoffmann
c976ed5a3a [Bug Fix]: Clicking an Add or Removed entry in the blueprint diff tool only moves one of the views.
- The SNodePanel deferrs some of it's panning to future frames which was causing locked graphs in the diff tool to become out of sync. To solve this, I wait until the SNodePanel has finished finding it's target before setting locked graphs on the same trajectory

#jira UE-150557
#rb Marc.Audy, Brooke.Hubert, Lauren.Barnes, Vincent.Gauthier
#preflight 6286cc16cf5ac7317c47235d

[CL 20288942 by jordan hoffmann in ue5-main branch]
2022-05-19 19:12:34 -04:00
Josie Yang
af65e53764 Inline edit support to material expression inputs
- Inline edit support for UPROPERTY of type float, int32, uint32, uint8, enum, bool.
- Editable UPROPERTYs with "OverridingInputProperty" metadata are created as inline widgets next to their corresponding inputs.
- Rest of the editable UPROPERTYs may specify "ShowAsInputPin" metadata to become inline edit pins, with 2 choices: "Primary" - show in primary view, "Advanced" - show in in advanced view.
- Update a bunch of material expressions to reflect the changes, rest of the expressions still need to be worked through.

#jira UE-145276
#rb kevin.Ortegren
#preflight 627a3cc8937a047d62282ba7

[CL 20122451 by Josie Yang in ue5-main branch]
2022-05-10 09:53:13 -04:00
Lauren Barnes
6248f8d412 Replacing legacy EditorStyle calls with AppStyle
#preflight 6272a74d2f6d177be3c6fdda
#rb Matt.Kuhlenschmidt

#ROBOMERGE-OWNER: Lauren.Barnes
#ROBOMERGE-AUTHOR: lauren.barnes
#ROBOMERGE-SOURCE: CL 20057269 via CL 20070159 via CL 20072035 via CL 20072203
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)
#ROBOMERGE-CONFLICT from-shelf

[CL 20105363 by Lauren Barnes in ue5-main branch]
2022-05-09 13:12:28 -04:00
louise rasmussen
fd51dd72b6 ReferenceViewer Enhancements Part 1
- Updates the header style (UE5, emphasizes type)
- Shows nodes that may show up in more than one place (duplicates)
- Separates Depth control into Referencer Depth and Dependency Depth
- Comments with Package Path have been removed entirely (the tooltip remains)
- Rewritten algorithms to generate graph nodes that remove code duplication and will make adding new features easier
- Consolidates filters within the GetSortedLinks function
- adds temporary CVar that enables the ability to toggle between the old and new reference node layout algorithms.  The depricated algorithms and CVar will be removed once the rest of phase one is completed and the new layout has undergone more testing.

#JIRA  UE-148313, UE-148316, UE-148318
#rb Lauren.Barnes
#preflight 6272eb29dc3613022751c308

#ROBOMERGE-AUTHOR: louise.rasmussen
#ROBOMERGE-SOURCE: CL 20051603 via CL 20054172 via CL 20054231 via CL 20054249
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v943-19904690)

[CL 20060933 by louise rasmussen in ue5-main branch]
2022-05-05 14:04:26 -04:00
julien lheureux
c6e5b5d7a7 Improved behavior on links in graphs that support multiple links per pin.
Fixes issues with highlighting and alt-click delete on a link.

#rb lauren.barnes
#preflight 62631588bc24759dc755101a

[CL 19900843 by julien lheureux in ue5-main branch]
2022-04-25 08:49:05 -04:00
Mateo Egey
1c51045720 Fixed invalid guids being candidates for pin matching during OnDropped
#jira none
#rb trivial
#preflight skip

[CL 19543163 by Mateo Egey in ue5-main branch]
2022-03-29 11:41:21 -04:00
Mateo Egey
02207332a4 Fixed pin handles not matching pin via persistent guid first, which introduced issues with Niagara pin handling as Niagara has hidden pins of the same name "None" as part of a core paradigm
#jira UE-145725
#rb helge.mathee
#preflight 6242fb1bdf7d23dbfee91ad4

[CL 19540729 by Mateo Egey in ue5-main branch]
2022-03-29 08:53:00 -04:00
sara schvartzman
8ccbb335a5 Control Rig: Execute pins can't be connected in the proper order
#jira UE-145787
#rb benoit.gadreau
#preflight https://horde.devtools.epicgames.com/job/622f7b0380715dc6dad5e5c3

[CL 19375022 by sara schvartzman in ue5-main branch]
2022-03-14 13:40:28 -04:00
Helge Mathee
bedc891006 Control Rig: Fix for crash during pin wiring
#rb na
#jira na
#preflight na

[CL 19373777 by Helge Mathee in ue5-main branch]
2022-03-14 12:19:58 -04:00
Helge Mathee
fe5886fb9a EdGraph: Keep soft handles to pins and nodes during link
#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/6229c190d271eeb462e1d0ad

[CL 19334348 by Helge Mathee in ue5-main branch]
2022-03-10 06:25:01 -05:00
daren cheng
ed63759613 Remove pin tooltips on pin destruction, preventing stale tooltip crashes.
#jira UE-144506
#preflight 62210cd87b383ac2989e690b
#rb Vincent.Gauthier
#lockdown JeanMichel.Dignard

#ROBOMERGE-AUTHOR: daren.cheng
#ROBOMERGE-SOURCE: CL 19249172 in //UE5/Release-5.0/... via CL 19251784
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v924-19243027)

[CL 19263234 by daren cheng in ue5-main branch]
2022-03-04 03:25:54 -05:00
dave jones2
c8574d3b74 Merging //UE5/Dev-LargeWorldCoordinates [at] 18802167 to //UE5/Release-5.0
Blueprint real number support.

This change deprecates the use the of "float" and "double" types in Blueprints in favor of a new "real". By default, "real" is back by a double precision floating point number. However, it can be single precision if the number is a native float property or function parameter. This distinction won't be visible to the Blueprint user: in both instances, they'll be represented by "real" pin types. During deserialization, we'll automatically convert Blueprint pin types to use real/doubles, unless they're used to represent native code (including delegate signatures).

One consequence of this change is that we need to perform implicit casts between single and double precision real numbers. During Blueprint compilation, the compiler will detect points in the graph for when either a widening or narrowing conversion needs to occur. Subsequently, the script bytecode will contain a new cast instruction that performs the conversion. This also works on container types, but each entry in the container will have to be converted. This can introduce unwanted overhead for large containers that are frequently passed between Blueprint and native code.

The scope of this change affects Blueprints used by Gameplay, Animation, Control Rig, and UMG.

#rb marc.audy (serialization changes)
#jira UE-116484
#preflight 61f8bdd5a2514ba12ff7bdfc

#ROBOMERGE-AUTHOR: dave.jones2
#ROBOMERGE-SOURCE: CL 18809077 in //UE5/Release-5.0/... via CL 18809455 via CL 18822548
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18823569 by dave jones2 in ue5-main branch]
2022-02-02 05:50:50 -05:00
helge mathee
3abfb315a5 Control Rig: Cannot drag wires out from pins on collapsed nodes
This is due to the fact that we are changing the setting on the actual node - not the widget itself. Added a boolean to overdrive the behavior per widget

#rb sara.schvartzman
#jira UE-139791
#preflight https://horde.devtools.epicgames.com/job/61eaabbcc12be595d176b23b

#ROBOMERGE-AUTHOR: helge.mathee
#ROBOMERGE-SOURCE: CL 18688416 in //UE5/Release-5.0/... via CL 18688420 via CL 18688425
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18688430 by helge mathee in ue5-main branch]
2022-01-21 08:08:00 -05:00
ben hoffman
342cf191d1 Blueprints: Add new promotable operator icons to make it clearer that you can connect any type to it instead of just the one that is currently connected.
#jira UE-130755
#rb trivial
#rnx
#preflight 61df10146a076ddb53ecd68e
#preflight 61df40836a16a18acf8741e8

#ROBOMERGE-AUTHOR: ben.hoffman
#ROBOMERGE-SOURCE: CL 18589393 in //UE5/Release-5.0/... via CL 18589401 via CL 18589406
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v899-18417669)

[CL 18589423 by ben hoffman in ue5-main branch]
2022-01-12 16:08:58 -05:00
sebastian nordgren
9f571a3e15 Added "Break This Link" command to graph editor, which is displayed instead of the "Break Link..." submenu when there's only one link to display.
Fixed various Title Case errors in graph editor command names.

#review-18238003 @lauren.barnes
#preflight 619b8f30f934c1a291ceaa0b

[CL 18258594 by sebastian nordgren in ue5-main branch]
2021-11-22 10:13:04 -05:00