Commit Graph

14902 Commits

Author SHA1 Message Date
bob tellez
6aeccfaf4e [Backout] - CL33671805
[FYI] stu.mckenna
Original CL Desc
-----------------------------------------------------------------
- Fix for AddUsedInputMembers having inverted source / destination for arrays

#rb Laura.Hermanns

[CL 33681068 by bob tellez in ue5-main branch]
2024-05-16 03:24:36 -04:00
jeannoe morissette
a8ac71a367 VulkanRHI: Clean up shader structures. Remove unused FVulkanBindingTable and EVulkanBindingType. Adding ShaderStage::EStage::NumGraphicsStages to eventually replace ::NumStages where appropriate. Start simplifying VulkanShaderCompiler to remove some back and forth caused by legacy code paths. (WIP)
#rb florian.penzkofer, Laura.Hermanns
#rnx

[CL 33674263 by jeannoe morissette in ue5-main branch]
2024-05-15 18:38:27 -04:00
stu mckenna
da68d46d3d - Fix for AddUsedInputMembers having inverted source / destination for arrays
#rb Laura.Hermanns

[CL 33671939 by stu mckenna in ue5-main branch]
2024-05-15 17:38:28 -04:00
jeremie roy
b5de71b7fb Add delegate to control which settings get auto-discovered by the settings module
#jira UE-211011
#rb jason.walter

[CL 33657214 by jeremie roy in ue5-main branch]
2024-05-15 10:02:06 -04:00
catalin dragoiu
9f36fda32e Add Trace Control Window in Session Frontend
Initial implementation of the TraceTools module.
#rb ionut.matasaru
#jira UE-215072

[CL 33655703 by catalin dragoiu in ue5-main branch]
2024-05-15 08:55:14 -04:00
mark lintott
d571e68c92 Latest updates to Editor Performance tool
Added Virtual Assets Efficiency KPI
Added Stall Rate KPI
Added failure count for KPIs and added this to the UI
Insights Snapshots will generate multiple captures for each failure within the session upto a a maximum of 10 per session
Insights capture and Telemetry event generation movede from StatusBar to EditorPerformanceModule
Fixed issue where Editor Load Map tiem was incorrect when booting without a Map
Split Hitch and Stall rate KPIs bewteen Editor and PIE scopes
Added LocalGetMisses to DDC cache statistics
Turned off notifications by default, users should opt-in

[CL 33654736 by mark lintott in ue5-main branch]
2024-05-15 07:52:22 -04:00
rob perren
a99da34247 Add support for the cooked cooker to stage the .target file it is built with & for this file to be read by the editor
This allows dlls to be loaded based on the target file when not running in monolithic mode
#rb sebastian.schoner
#rnx

[CL 33653490 by rob perren in ue5-main branch]
2024-05-15 05:59:39 -04:00
dietmar hauser
244c0906af [Android] Fixing up GLSL shader compilation to once more allow usage of the OES External Texture extension
#jira UE-211495
#review 33604115

[CL 33653370 by dietmar hauser in ue5-main branch]
2024-05-15 05:46:03 -04:00
dominic couture
3518e1ace4 Iterate over migrated packags and do WorldCleanup() on found world. This is necessary to avoid various issues iwht Unitialization() in the BeginDestroys() of world subsystems.
#jira UE-214541
#rb JeanFrancois.Dube, Julien.StJean

[CL 33639981 by dominic couture in ue5-main branch]
2024-05-14 19:28:16 -04:00
dan thompson
a51d37e269 Compute RequiredMemory for "DDC2" texture build worker internally to avoid it affecting ddc keys.
Update GetOutputAlphaFromKnownAlpha to have the same call structure as GetOutputAlphaFromKnownAlphaOrFail

#ushell-cherrypick of 33523860 by Dan.Thompson
#rb charles.bloom
[FYI] devin.doucette
#rnx

[CL 33638267 by dan thompson in ue5-main branch]
2024-05-14 18:20:54 -04:00
Yuriy ODonnell
29ef258f59 Support GPU diagnostic buffer binding when using static root signature
#rb graham.wihlidal
#jira none

[CL 33634764 by Yuriy ODonnell in ue5-main branch]
2024-05-14 15:13:55 -04:00
sebastian arleryd
fa65fc6e04 Add the concept of section menus to ToolMenu sections
A section menu is currently only rendered for toolbar sections. The section menu can be opened via a new combo button that is added as the left-most entry of toolbar sections. When that combo button is clicked, a menu opens containing all entries of the section.

Section menus are disabled by default, but can be enabled on a section by calling the new FToolMenuSection::SetShowSectionMenu(bool) API.

#jira UE-212288
#rb aditya.ravichandran

[CL 33626872 by sebastian arleryd in ue5-main branch]
2024-05-14 08:06:09 -04:00
paul chipchase
ecea53ce65 Added new methods to IVirtualizationSystem for accessing statistics and deprecated the old methods.
#rb PJ.Kack
#jira UE-147384
#rnx

- The previous functor based system was difficult to update as changes to the data being passed to the functor could break existing code, so ::GetAccumualtedPayloadActivityInfo has been replaced with ::GetBackendStatistics, a version that returns a struct for each backend in the system which contains the relevant statistics for that backend. Adding new data to a struct is much easier.
-- The new data added per backend is the storage type so that the caller can tell if the backend was for cached storage or persistent storage.
- To fit into this naming scheme ::GetAccumualtedPayloadActivityInfo has been deprecated in favor of ::GetSystemStatistics which is simply a rename.
- The deprecated methods should continue to work as before.
- Existing engine code had been updated to use the new methods.
- Removed a typo from the copyright boilerplate at the begining of VirtualizationSystem.h

[CL 33626815 by paul chipchase in ue5-main branch]
2024-05-14 07:59:24 -04:00
kenzo terelst
3df923dab2 - Add FShaderBindingLayout as RenderCore wrapper for FRHIShaderBindingLayout which can also cache static uniform buffer declerations used during shader code gen
- Add option for ShaderType to declare which FShaderBindingLayout needs to be used for shader gen and runtime binding
- Add helper function to generate FShaderBindingLayoutContainer from array of uniform buffers and EShaderResourceTableFlags (only supports bindless mode right now)
- Serialize the FRHIShaderBindingLayout in FShaderCompilerEnvironment so it can be used by the shader compiler backends
- FShaderBindingLayout can add required symbols to the FShaderCompilerInput which shouldn't be dead code eliminated (required for Shader resource table building)
- Serialize the hash of RHIShaderResourceTable in the platform specific shader binary data so it can be used during runtime RTPSO validation (all shaders in the RTPSO need the same RHIShaderResourceTable)
- Renamed pRootSignaure member to RootSignature (style guide)

#jira UE-212347

[CL 33624453 by kenzo terelst in ue5-main branch]
2024-05-14 04:49:23 -04:00
pj kack
bff7ef0500 UnrealPak: Change memory throttling logic to prepare for async DDC get requests that can allocate compression buffers from worker threads.
Add IIoStoreWriteRequest::GetSourceBufferSizeEstimate() to get an upfront approximation of required memory for source reads and compression buffers.
Limit memory usage upfront in FIoStoreWriterContextImpl::ScheduleEntry() based on the estimate instead of during the actual allocations in the middle of the pipeline.
Remove wait from AllocCompressionBuffer and always let it return immediately with a valid compression buffer.
Rename FIoStoreWriteQueueEntry::NumChunkBlocksFromRefDb to NumChunkBlocks and use it for all entries.
Replace the unnecessary FIoStoreWriteQueueEntry::WriteFinishedEvent with a single WriterThread.Wait().
In FIoStoreWriterContextImpl::WriteEntry() reduce som memory growth by releasing the ChunkBlocks array and moving the filename when building the toc directory index.
Bump compression memory limit from 2 GB to 3 GB to reduce the need to (mostly) drain the queue to schedule large-ish entries.

#rb Per.Larsson
#rnx
#tests identical binary diff of /content/paks folder

[CL 33622054 by pj kack in ue5-main branch]
2024-05-14 01:45:53 -04:00
marc audy
28c077e1f9 Fix non-unity issues
#rnx

[CL 33614058 by marc audy in ue5-main branch]
2024-05-13 20:49:19 -04:00
steve robb
7f9dd540a6 Fixed IsDerivedFromSharedFromThis() when there are multiple TSharedFromThis bases.
Refactored the TSharedFromThis code to enforce a compile error when trying to create a TSharedPtr with multiple TSharedFromThis bases.
Fixed fallout.

#rb devin.doucette

[CL 33610597 by steve robb in ue5-main branch]
2024-05-13 18:24:48 -04:00
laura hermanns
ac06606d17 [Horde] Add second fallback to find Horde server URL in BaseEngine.ini.
This adds "[Horde]:ServerUrl" section to BaseEngine.ini configuration as second fallback when UE_HORDE_URL is not defined as environment variable nor present in the registry (Windows) or .horde.json file (POSIX).

#jira UE-210043
#rnx
#rb Ben.Marsh

[CL 33610566 by laura hermanns in ue5-main branch]
2024-05-13 18:23:19 -04:00
jerome delattre
13878a9635 Avoid comparison name reference mismatch between log and report
#rnx
#rb sebastian.lewicki

[CL 33604691 by jerome delattre in ue5-main branch]
2024-05-13 11:12:35 -04:00
paul chipchase
b41c057613 Small clean up of the virtualization stats logging
#rb PJ.Kack
#jira UE-147384
#rnx

- Note that these stats are only logged after selected commandlets have run (cooking, precaching etc)
- Replaces the data transfer rate statistic with an average request time to reflect recent changes to the statistics panel in the editor.
- Compacted the table to remove some unnecessary padding.

[CL 33602676 by paul chipchase in ue5-main branch]
2024-05-13 08:55:45 -04:00
pj kack
9d1aa521f4 UnrealPak: Add UsedPhysical and UsedVirtual memory stats to progress output logging and always log at least one status line.
#rb Per.Larsson
#rnx

[CL 33598566 by pj kack in ue5-main branch]
2024-05-13 04:12:59 -04:00
johan berg
4decca411b Add debug mode to serialized trace packets
By setting UE_TRACE_PACKET_VERIFICATION this mode embeds a serial numbers after each packet. Note that this makes analysis incompatible with traces recorded without this mode. Strictly useful for investigating potential package loss.

#rb ionut.matasaru

[CL 33598542 by johan berg in ue5-main branch]
2024-05-13 04:09:59 -04:00
Wei Liu
949639e8d8 Fix the GBufferA format for the mobile deferred with pixel local storage .
#jira none

#rb Dmitriy.Dyomin

[CL 33598326 by Wei Liu in ue5-main branch]
2024-05-13 03:32:25 -04:00
ben hoffman
2e6d7878bf Do not allow users to create a child blueprint based off of a BP function library. This never worked, and you would only recieve comipliation errors if you made one.
#jira UE-88170
#rb dan.oconnor

[CL 33582349 by ben hoffman in ue5-main branch]
2024-05-10 14:32:25 -04:00
jamie hayes
ec625768bf Partial backout of 33180448.
The displacement scaling material node doesn't work correctly with material instances that do not create static permutations, and we can't assume that displacement scaling of the material can be known as final during material translation. As a result, we stop trying to determine if a constant displacement could effectively disable tessellation and instead return to disabling displacement when the displacement pin has not been connected, which can still be used (via Material Attributes) to disable displacement based on static switches.

#rb massimo.tristano
#rnx

[CL 33576411 by jamie hayes in ue5-main branch]
2024-05-10 11:24:22 -04:00