Commit Graph

238 Commits

Author SHA1 Message Date
danny couture
684e00a15e Fix potential race condition on multicast delegate used from multiple threads
#rb Martin.Ridgers, Ionut.Matasaru
#preflight 6346a435fa31324bb133affb

[CL 22481908 by danny couture in ue5-main branch]
2022-10-12 13:39:40 -04:00
tyler staples
e469e98032 Add OnCSVProfileEndRequested delegate that fires right before we end a capture, allowing final information to be written.
#rb ben.woodhouse

[CL 22408903 by tyler staples in ue5-main branch]
2022-10-07 16:37:53 -04:00
ionut matasaru
f5ec088bd8 [Insights] Fixed incorrect usage of CORE_API for FDefaultMemScope (Horde issue #220129).
#rb Andriy.Tylychko
#preflight 633c6209116db430588dd367
#lockdown Mark.Lintott

[CL 22363950 by ionut matasaru in ue5-main branch]
2022-10-05 17:37:04 -04:00
Andriy Tylychko
ab5a1abe8d InheritedContext
grouped inherited LLM tag, mem tag and trace metadata into FInheritedContext to simplify their usage, avoid forgetting using all of them together, and to hide the ugly conditional compilation. Added FInheritedContext to higher level tasks instead of the low-level tasks to allow batch task launch to capture the inherited context once per batch

#rb ionut.matasaru
#preflight 633c47792f4bf32d31687192

[CL 22331272 by Andriy Tylychko in ue5-main branch]
2022-10-04 11:22:08 -04:00
marc audy
edd83dc1fb Trace:
* Replaced OnTraceFileStarted delegate with OnTraceStarted
* Added OnTraceStopped delegate
* Both events pass if the recording was for a network or file type.

#rb Brian.Bekich, Martin.Ridgers
#preflight

[CL 22088546 by marc audy in ue5-main branch]
2022-09-20 00:42:05 -04:00
louisphilippe seguin
e738e717e3 Trace
* Added trace file created callback:  Useful to gather all trace files created during execution
* Added config option to disable or resize tail buffers via [Trace.Config]:TailSizeBytes
* Added config option for worker thread sleep time via [Trace.Config]:SleepTimeInMS
* Fixed init code so it never creates a workerthread in builds that don't support multithreading

#rb Martin.Ridgets, Ionut.Matasaru

[CL 22013173 by louisphilippe seguin in ue5-main branch]
2022-09-14 15:04:08 -04:00
Martin Ridgers
378f8d57da Added F prefix to Options struct name
#rnx
#rb im
#preflight 632187ee9677b738f4d49188

[CL 22003200 by Martin Ridgers in ue5-main branch]
2022-09-14 04:06:08 -04:00
bryan sefcik
07894f4a07 Removed redundant private include paths from build.cs files.
Fixed include paths to be relative to the private or public folders.
Hid or removed includes that reached into other private module folders.
Updated PublicInclude paths when necessary.

#jira
#preflight 631a717cec45fbf3d74d4ba7

[CL 21916033 by bryan sefcik in ue5-main branch]
2022-09-09 00:53:22 -04:00
Martin Sevigny
211e0a6eec Prevent a possible division by zero in FHistogram::GetAverageOfAllMeasures
Reported on UDN case 416970

#review-21551973 trivial
#jira none
#preflight none

[CL 21551971 by Martin Sevigny in ue5-main branch]
2022-08-24 16:56:27 -04:00
ben woodhouse
7db1565880 If the CSV Profiler is running, output the CSV GT/RT frame in the GT and RT frame named events rather than the engine frame numbers, and prefix with Csv.
#rb serge.bernier

#ROBOMERGE-AUTHOR: ben.woodhouse
#ROBOMERGE-SOURCE: CL 21355012 via CL 21355934 via CL 21355993 via CL 21356002
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21358177 by ben woodhouse in ue5-main branch]
2022-08-12 13:23:10 -04:00
mickael gilabert
b2c395d8b8 Trim Low level allocator memory when OS might go into OOM
[REVIEW] [at]rob.millar
[FYI] dave.barrett
#rnx

#ROBOMERGE-OWNER: mickael.gilabert
#ROBOMERGE-AUTHOR: mickael.gilabert
#ROBOMERGE-SOURCE: CL 21204808 via CL 21205552 via CL 21205565 via CL 21205612
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21209877 by mickael gilabert in ue5-main branch]
2022-07-21 17:08:05 -04:00
Bryan sefcik
b4a6e947d8 Ran IWYU on Public headers under Engine/Source/Runtime/...
Headers are updated to contain any missing #includes needed to compile and #includes are sorted.  Nothing is removed.

#ushell-cherrypick of 21065896 by bryan.sefcik
#preflight 62d4b1a5a6141b6adfb0c892
#jira

#ROBOMERGE-OWNER: Bryan.sefcik
#ROBOMERGE-AUTHOR: bryan.sefcik
#ROBOMERGE-SOURCE: CL 21150156 via CL 21151754 via CL 21154719
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)
#ROBOMERGE-CONFLICT from-shelf

[CL 21181076 by Bryan sefcik in ue5-main branch]
2022-07-20 11:31:36 -04:00
bryan sefcik
a6f4cf20cc Possible fix for compile issue. I CNR the issue but this should fix it.
#ROBOMERGE-AUTHOR: bryan.sefcik
#ROBOMERGE-SOURCE: CL 21142224 via CL 21142225 via CL 21142229
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21153100 by bryan sefcik in ue5-main branch]
2022-07-18 17:34:34 -04:00
jeanfrancois dube
e4356c970b Macro UE_SCOPED_TIMER now includes total time when triggered several times.
#rb sebastien.lussier
#preflight 62cff452d45d5be7f1f167af
#rnx

#ROBOMERGE-AUTHOR: jeanfrancois.dube
#ROBOMERGE-SOURCE: CL 21100758 via CL 21100762 via CL 21100766
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21106381 by jeanfrancois dube in ue5-main branch]
2022-07-15 03:44:42 -04:00
jordan cristiano
7fb93f7d17 Reduced FScopeCycleCounter complexity by undoing the description string addition. Replaced the one use case with a dynamic stat string.
#rb evgenii.babinets
[FYI] jason.hoerner

#ROBOMERGE-AUTHOR: jordan.cristiano
#ROBOMERGE-SOURCE: CL 21046539 via CL 21046557 via CL 21047685
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21075529 by jordan cristiano in ue5-main branch]
2022-07-13 13:58:40 -04:00
bryan sefcik
a9cc65bca4 Updated Core code to not use CoreMinimal.h when possible.
Core public headers still will contain CoreMinimal.h if any included it before my IWYU changes.
#preflight 62c73594756222ced4e48707

[CL 20991367 by bryan sefcik in ue5-main branch]
2022-07-07 16:02:19 -04:00
bryan sefcik
9905eb52bb Pass 2 on running IWYU on Core.
Things to note regarding this pass:
* No includes are currently being removed from public headers.
* Any private file that has a #if is currently not being updated.
#preflight 62c703bbd13fac04f11da948

[CL 20985655 by bryan sefcik in ue5-main branch]
2022-07-07 12:30:11 -04:00
bryan sefcik
62489fe2b3 Ran a pass of IWYU on Core.
Things to note regarding this pass:
* No includes are currently being removed from public headers.
* Any private file that has a #if is currently not being updated.

#rb Devin Doucette and Marc Audy
#preflight 62c62086756222ced497ff95
#preflight 62c626d12f2d04691814d331
#preflight 62c630107e606620fdd64e31
#preflight 62c635c6756222ced49a13cf

[CL 20979027 by bryan sefcik in ue5-main branch]
2022-07-06 21:44:18 -04:00
ben woodhouse
f17e6c6f0d CSV profiler - persistent custom stats. Thread-safe helper classes for custom stats that persist across frames.
#rb simon.orr

#ROBOMERGE-AUTHOR: ben.woodhouse
#ROBOMERGE-SOURCE: CL 20939788 via CL 20939799 via CL 20939801
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20940317 by ben woodhouse in ue5-main branch]
2022-07-05 07:28:30 -04:00
Catalin Dragoiu
74aec4d0bf Track asset class for packages in CookProfiler
#rb Matt.Peters Francis.Hurteau
#preflight 62bda231a3568e30663c1507
#robomerge EngineMerge

[CL 20894999 by Catalin Dragoiu in ue5-main branch]
2022-06-30 10:13:15 -04:00
steve robb
dbe6f4a18d Allow formatting strings to be binary-compatible char types, not only exact types.
#jira UE-132142
#rb devin.doucette
#preflight 62bd5018a3568e30662ad3b4

#ROBOMERGE-OWNER: steve.robb
#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 20890364 via CL 20890433 via CL 20890478
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20892157 by steve robb in ue5-main branch]
2022-06-30 07:58:27 -04:00
Joe Kirchoff
75b4660aeb Resolve typecast warning in ProfilingDebugging
#rb trivial
#rnx
#preflight 62b644ea466962cd9a3826b0

[CL 20819593 by Joe Kirchoff in ue5-main branch]
2022-06-24 19:37:59 -04:00
tyler staples
cc245a8e46 Fix for csv profiler pause event not firing at start of capture
+ Added a new delegate to the CSV profiler that fires once on frame 0 of the capture so we can send the pause event as soon as valid.
+ The PerformanceTrackingSubsystem now handles sending the pause/resume events as it made more sense.

#rb ben.woodhouse, andrew.ladenberger

#ROBOMERGE-AUTHOR: tyler.staples
#ROBOMERGE-SOURCE: CL 20765956 via CL 20766099 via CL 20766135 via CL 20766258 via CL 20766315
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v970-20704180)

[CL 20767975 by tyler staples in ue5-main branch]
2022-06-21 19:30:02 -04:00
Johan Berg
ca32e4c627 Metadata scopes
Adds runtime events and analysis for generic meta data scopes. Any scope emitted on the "Metadata" writer will be analyzed and accessible in the metadata provider. Currently one built-in metadata type is provided: "Asset", which mimics LLMs implementation of asset tracking.

#rb ionut.matasaru
#robomerge EngineMerge
#preflight 62b1b35d827ccccb2cd7da0d

[CL 20755918 by Johan Berg in ue5-main branch]
2022-06-21 08:20:57 -04:00
Johan Berg
8a92cd22e4 Fix on-connection strings having different type ids.
Since there were two different events for declaring strings and FNames, one regular and one no-sync version used in on-connection callback, references would not be correctly resolved. We remove the no sync version and use only one version. In order to solve the synchronizing we defer resolving the strings in analysis.
#preflight 62a9c8932a1103ff5fb784ae
#robomerge EngineMerge

[CL 20668219 by Johan Berg in ue5-main branch]
2022-06-15 08:03:24 -04:00