Commit Graph

11185 Commits

Author SHA1 Message Date
danny couture
684e00a15e Fix potential race condition on multicast delegate used from multiple threads
#rb Martin.Ridgers, Ionut.Matasaru
#preflight 6346a435fa31324bb133affb

[CL 22481908 by danny couture in ue5-main branch]
2022-10-12 13:39:40 -04:00
Zak Middleton
4ffc7c245e #ue5 - Add range checks to UE::LWC::FloatToIntCastChecked() and validation code to UnrealMathTests startup tests.
#jira UE-161347
#rb Andrew.Davidson
#preflight 0

[CL 22481692 by Zak Middleton in ue5-main branch]
2022-10-12 13:30:10 -04:00
jian ru
60d5606640 Do not use the old mesh simplifier weights for nanite fallback mesh LOD0. Changing the weights alters the error calculation and makes any non-zero TargetError invalid.
[FYI] brian.karis

[CL 22473882 by jian ru in ue5-main branch]
2022-10-12 00:58:18 -04:00
bryan sefcik
521a10d411 PCH cleanup:
* Sorted includes.
* Updated PCH headers to include other PCH headers to make updates easier. Since each CoreUObject is higher on the code stack than Core, it makes sense to just remove the duplicates and just include the Core PCH header instead.
* Note: No new includes were added.  Just removed the duplicates.
#preflight 6345b727663dafe416d96581

[CL 22462506 by bryan sefcik in ue5-main branch]
2022-10-11 14:44:39 -04:00
jian ru
b539ff9aa7 Feed the same set of weights to FMeshSimplifier when generating LODs for nanite fallback meshes to ensure that auto-computed LOD transition screen sizes are consistent
[FYI] brian.karis, chris.morrison, bryce.lumpkin

[CL 22459671 by jian ru in ue5-main branch]
2022-10-11 12:15:30 -04:00
Andriy Tylychko
3dbc65b2e3 fixed a race reported and analysed by Carl-Magnus Nordin:
T1: Tail.Store(Sentinel)
T2: Prev = Tail.Load()  (Prev = Sentinel)
T2: Prev.Next = [some node]  (Sentinel.Next = [some node])
T1: Sentinel.Next = null
which can lead to losing nodes
#preflight 63458fbf045315f96a1c53a2

[CL 22459506 by Andriy Tylychko in ue5-main branch]
2022-10-11 12:08:34 -04:00
robert seiver
b4db2e582f Temporary workaround for creating processes that use two unique pipes
#fyi Brandon.Schaefer, James.Singer, Ryan.Neyland
#preflight 633ef28fb7327403d9a2c42b

[CL 22459137 by robert seiver in ue5-main branch]
2022-10-11 11:51:54 -04:00
David Harvey
fdf4be2031 Added a registerable callback for when a named chunk is installed.
- AddNamedChunkInstallDelegate / RemoveNamedChunkInstallDelegate

#jira UE-163419
#preflight 634418f46732684595a2ec81
#rb Brian.White

[CL 22453417 by David Harvey in ue5-main branch]
2022-10-11 04:44:45 -04:00
nick darnell
32367ac805 Modules - Better stats around loading the actual DLLs with modules. It's just nice to know what's going on in those blank spots when doing module loading.
[REVIEW] [at]Bob.Tellez

[CL 22450256 by nick darnell in ue5-main branch]
2022-10-11 00:39:02 -04:00
robomerge
4f08629f27 Added support for specifying localization targets that should only be loaded in a cooked editor
#preflight 6340342ab20780acc1f813f2
#rb Rex.Hill, Dave.Belanger

[CL 22433398 by robomerge in ue5-main branch]
2022-10-10 13:18:43 -04:00
Dan Thompson
7255fc6084 Explicitly delete operator bool on object weak pointers to make it clear why one doesn't exist, and clarify that you shouldn't be calling IsValid all the time.
#rb steve.robb
#preflight 634442241d5e6dbf759bc1ea

[CL 22432048 by Dan Thompson in ue5-main branch]
2022-10-10 12:33:54 -04:00
ionut matasaru
b62246872e [Insights] Added "clear metadata scope" (UE_TRACE_METADATA_CLEAR_SCOPE) for the Trace system memory allocation events.
#rb Catalin.Dragoiu
#preflight 63407d09b20780acc109ff75

[CL 22427085 by ionut matasaru in ue5-main branch]
2022-10-10 06:09:31 -04:00
josh adams
e767d53dce - Fixed DeviceProfile inheriting LODGroups from parent DP when there are no LOD groups specified (in this case, it was getting all LODgroups from the class defaults, and then it would never copy parent settings down, and would have defaults instead of parent values)
- Fixed a bug in the SectionName remapping system
#jira UE-165868
#rb dan.thompson
#preflight 63407bed587d6afac86b4453

[CL 22411128 by josh adams in ue5-main branch]
2022-10-07 18:10:19 -04:00
charles bloom
13c1331e1f Texture: remove cached LOD Bias, was often out of date
calculate LOD Bias as needed on demand
fix calculations of cinematic mip bias
clarify effective mip count should not go below numnonstreaming or numintail
RequiresBlock4Alignment to identify pixel formats that need 4-alignment (eg. not ASTC/ETC)
use RequiresBlock4Alignment to make NumNonStreaming only when necessary
so mobile platform streaming is not constrained when not needed

#preflight 634048c5607039cbc1675f52
#rb fabian.giesen

[CL 22409186 by charles bloom in ue5-main branch]
2022-10-07 16:44:48 -04:00
tyler staples
e469e98032 Add OnCSVProfileEndRequested delegate that fires right before we end a capture, allowing final information to be written.
#rb ben.woodhouse

[CL 22408903 by tyler staples in ue5-main branch]
2022-10-07 16:37:53 -04:00
arciel rekman
1ad6c3648e Fix Lyra crash due to shader decompression failure (UE-165785).
- PCD3D_SM5 and PCD3D_SM6 had a unique situation of having identical (bytecode-wise and output hash-wise) shaders (raytracing is allowed in PCD3D_SM5). This resulted in those IoStore chunks being deduplicated, however, the actual contents were not identical due to optional data (which isn't included in the shader hash, see UE-166389).
- This fix makes sure we don't use just the shader hash alone to produce IoStore chunk hashes. Hash will now include the shader size and the shader format name.
- A few early guards added here and there to detect the problem early.

Also fixed a memory leak in UnrealPak pointed by CM.

#rb [at]Yuriy.ODonnell, [at]CarlMagnus.Nordin, [at]Christopher.Waters, [at]Jason.Nadro
#jira UE-165785
#preflight 633f3beed718720d2d58f37e

[CL 22402802 by arciel rekman in ue5-main branch]
2022-10-07 12:32:35 -04:00
Andriy Tylychko
d204690fb9 fixed double destruction in Tasks System that was causing repeating "task destroyed" traces in TasksInsight
#jira UE-164718
#rb francis.hurteau
#preflight 633ffebc090af7205cff672f
#lockdown marc.audy

[CL 22402645 by Andriy Tylychko in ue5-main branch]
2022-10-07 12:24:00 -04:00
Andriy Tylychko
961fe71486 removed a "check" because it relies on an insufficiently strict memory order ("release" on the previous line). reported by TSAN. the check is not important enough to pessimise the algo for it
#preflight 63400abec6753f31ce64995f

[CL 22398554 by Andriy Tylychko in ue5-main branch]
2022-10-07 07:35:20 -04:00
stu mckenna
3ec1bfb90c - Add shader parameter binding for velocity
#rb trivial
#rnx
#preflight 633e0f85643eefca3d9a6ad6

[CL 22388047 by stu mckenna in ue5-main branch]
2022-10-06 19:50:52 -04:00
matt peters
9e410a542c Fix corelimit parsing; it was being ignored without physicalcorelimit.
#jira UE-166112
#rb Andriy.Tylychko
#rnx
#preflight 633d79e9b8777e804c1a59ba
#lockdown mark.lintott

[CL 22364004 by matt peters in ue5-main branch]
2022-10-05 17:39:29 -04:00
ionut matasaru
f5ec088bd8 [Insights] Fixed incorrect usage of CORE_API for FDefaultMemScope (Horde issue #220129).
#rb Andriy.Tylychko
#preflight 633c6209116db430588dd367
#lockdown Mark.Lintott

[CL 22363950 by ionut matasaru in ue5-main branch]
2022-10-05 17:37:04 -04:00
Andriy Tylychko
24c39ec5ec moved a check for successful thread creation and added a message that is supposed to help diagnosing an underlying problem
#jira FORT-521107
#preflight 633d9573d74cbd5504532e9c

[CL 22355371 by Andriy Tylychko in ue5-main branch]
2022-10-05 10:58:19 -04:00
Andriy Tylychko
6670668124 fixed server compilation that happens to have UE_MEMORY_TAGS_TRACE_ENABLED enabled but not UE_TRACE_ENABLED
#jira UE-166023
#preflight 633d8146d74cbd55044b2365

[CL 22353844 by Andriy Tylychko in ue5-main branch]
2022-10-05 09:33:49 -04:00
Andriy Tylychko
ab5a1abe8d InheritedContext
grouped inherited LLM tag, mem tag and trace metadata into FInheritedContext to simplify their usage, avoid forgetting using all of them together, and to hide the ugly conditional compilation. Added FInheritedContext to higher level tasks instead of the low-level tasks to allow batch task launch to capture the inherited context once per batch

#rb ionut.matasaru
#preflight 633c47792f4bf32d31687192

[CL 22331272 by Andriy Tylychko in ue5-main branch]
2022-10-04 11:22:08 -04:00
David Harvey
4f19e8845f remove temporary 5.1 scaffolding class used for deprecating FCustomChunk and introducing Named Chunks.
#jira UE-163419
#rnx
#rb trivial
#preflight 633be36df513083ba3292012

[CL 22327758 by David Harvey in ue5-main branch]
2022-10-04 04:14:54 -04:00