Commit Graph

205 Commits

Author SHA1 Message Date
alexis matte
a7f48ea1ff Interchange: Make sure InterchangeWorker process are terminate right when we discard the translator.
#jira UE-200434
#rb JeanLuc.Corenthin
#rnx

[CL 29749470 by alexis matte in ue5-main branch]
2023-11-15 12:01:59 -05:00
alexis matte
bbe5ab4560 Interchange: Fix the cancel when importing multiple file with fbx in-process.
#rb jeanluc.corenthin
#rnx

[CL 29643358 by alexis matte in ue5-main branch]
2023-11-10 11:42:45 -05:00
alexis matte
1adba86cfb Create an option to run fbx translator async not in parallel without the InterchangeWorker.
#jira UE-196748
#rb jeanluc.corenthin
#rnx

[CL 29637952 by alexis matte in ue5-main branch]
2023-11-10 08:47:02 -05:00
alexis matte
9f7322911d Fix legacy fbx automation tests, which do not play well with interchange conversion.
#rb jeanluc.corenthin
#rnx

[CL 29594587 by alexis matte in ue5-main branch]
2023-11-09 09:17:18 -05:00
alexis matte
ee8e2aa5a1 Interchange: Remove experimental flag on some node class
#rb jeanluc.corenthin
#rnx

[CL 29561794 by alexis matte in ue5-main branch]
2023-11-08 10:37:16 -05:00
alexis matte
b74ff7f155 Fix the reimport to correctly find the reimport handler when the file extension has change. It can happen if you drag and drop a file in the content browser.
#rb jeanluc.corenthin
#rnx

[CL 29315142 by alexis matte in ue5-main branch]
2023-11-01 09:50:24 -04:00
alexis matte
6f863a1e3c Fix issue with Flush Rendering command call twice
#jira UE-196811
#rb jeanluc.corenthin , zach.bethel
#rnx

[CL 28930401 by alexis matte in ue5-main branch]
2023-10-19 15:38:10 -04:00
alexis matte
19a23512f3 Fix issue when material already exist and importing a mesh.
#rb jeanluc.corenthin
#rnx

[CL 28916974 by alexis matte in ue5-main branch]
2023-10-19 09:49:17 -04:00
alexis matte
86aa41366a Interchange: Fix memory leak with node and container when the async helper is clean up.
#rb jeanluc.corenthin
#rnx

[CL 28916729 by alexis matte in ue5-main branch]
2023-10-19 09:41:45 -04:00
dan smith
fe6e821dd4 Fixed [at]oaram typo (should be [at]param) in various files
#rnx

[CL 28698745 by dan smith in ue5-main branch]
2023-10-11 22:54:35 -04:00
ionut matasaru
2f4b6b566d Additional fixes for usage of TRACE_CPUPROFILER_EVENT_SCOPE macros in Interchange plugin.
* TRACE_CPUPROFILER_EVENT_SCOPE(ScopeName) --> to be used with a plain text as scope name (not a string!). If the parameter is a string ("abc" or TEXT("abc")), the quotes (and the TEXT prefix) will be included in the actual timer name.
* TRACE_CPUPROFILER_EVENT_SCOPE_STR("scope name") --> to be used with a static string (const ANSICHAR* or const TCHAR*); ex: when the scope name needs to include a space char
* TRACE_CPUPROFILER_EVENT_SCOPE_TEXT(*MyScopeName) --> to be used with a dynamic string (const ANSICHAR* or const TCHAR*)
See also the comments for these macros in ProfilingDebugging\CpuProfilerTrace.h.

#rb Alexis.Matte

[CL 28341000 by ionut matasaru in ue5-main branch]
2023-09-29 09:49:56 -04:00
ionut matasaru
6bc1744531 Fixed usage of TRACE_CPUPROFILER_EVENT_SCOPE macros in Interchange plugin.
* TRACE_CPUPROFILER_EVENT_SCOPE(ScopeName) --> to be used with a plain text as scope name (not a string!). If the parameter is a string ("abc" or TEXT("abc")), the quotes (and the TEXT prefix) will be included in the actual timer name.
* TRACE_CPUPROFILER_EVENT_SCOPE_STR("scope name") --> to be used with a static string (const ANSICHAR* or const TCHAR*); ex: when the scope name needs to include a space char
* TRACE_CPUPROFILER_EVENT_SCOPE_TEXT(*MyScopeName) --> to be used with a dynamic string (const ANSICHAR* or const TCHAR*)
See also the comments for these macros in ProfilingDebugging\CpuProfilerTrace.h.

#rb Alexis.Matte

[CL 28315968 by ionut matasaru in ue5-main branch]
2023-09-28 09:14:07 -04:00
alexis matte
3fe4bbfff5 Backout a material interface change to derive from IInterface_AsyncCompilation.
#rb none
#rnx

[CL 28304673 by alexis matte in ue5-main branch]
2023-09-27 20:53:54 -04:00
alexis matte
80bd8e62b9 Interchange: Add missing traces to be able to verify the performance.
#jira UE-152387
#rb jeanluc.corenthin
#rnx

[CL 28281857 by alexis matte in ue5-main branch]
2023-09-27 13:52:22 -04:00
alexis matte
44600f1a47 Interchange: Fix crash when async texture build is not finish and the pipeline post import callback try to access the render data.
#jira UE-172001
#rb jeanluc.corenthin
#rnx

[CL 28133814 by alexis matte in ue5-main branch]
2023-09-22 09:53:51 -04:00
alexis matte
38f3d3bb8a Interchange: Fix a validation issue with python pipeline
#jira UE-195790
#rb jeanluc.corenthin
#rnx

[CL 28032988 by alexis matte in ue5-main branch]
2023-09-20 09:08:38 -04:00
josh adams
aeb5cb1347 - Restoring a backout after fixing the issue that causes the backout
[Backout] - CL27745134
[FYI] stan.hormell
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL27731288 - CIS / Build Errors
[FYI] Josh.Adams
Original CL Desc
-----------------------------------------------------------------
- Deprecated GetSectionPrivate and FindOrAddSection, and accessors in FConfigFile that could return a non-const FConfigSection (this is so we can track modifications to config values)
- Added AddToSection, RemoveKeyFromSection, etc to replace directly accessing a FConfigSection
- Fixed up Epic code for the deprecations (at least the majority, some projects that aren't built by Horde presubmit may have some that we will address going forward)
#jira UE-194955
#rb david.harvey and various others

[CL 27923017 by josh adams in ue5-main branch]
2023-09-15 13:39:02 -04:00
stan hormell
37bad2d07b [Backout] - CL27731288 - CIS / Build Errors
[FYI] Josh.Adams
Original CL Desc
-----------------------------------------------------------------
- Deprecated GetSectionPrivate and FindOrAddSection, and accessors in FConfigFile that could return a non-const FConfigSection (this is so we can track modifications to config values)
- Added AddToSection, RemoveKeyFromSection, etc to replace directly accessing a FConfigSection
- Fixed up Epic code for the deprecations (at least the majority, some projects that aren't built by Horde presubmit may have some that we will address going forward)
#jira UE-194955
#rb david.harvey and various others

[CL 27745141 by stan hormell in ue5-main branch]
2023-09-10 22:58:21 -04:00
josh adams
a8a9a0b759 - Deprecated GetSectionPrivate and FindOrAddSection, and accessors in FConfigFile that could return a non-const FConfigSection (this is so we can track modifications to config values)
- Added AddToSection, RemoveKeyFromSection, etc to replace directly accessing a FConfigSection
- Fixed up Epic code for the deprecations (at least the majority, some projects that aren't built by Horde presubmit may have some that we will address going forward)
#jira UE-194955
#rb david.harvey and various others

[CL 27731364 by josh adams in ue5-main branch]
2023-09-08 17:58:55 -04:00
alexis matte
3e600e3153 Make sure "import all" option from the import dialog reused the same options in case we import different file format (using different translator).
#jira UE-193978
#rb jeanluc.corenthin
#rnx

[CL 27606492 by alexis matte in ue5-main branch]
2023-09-05 14:52:47 -04:00
alexis matte
a9a14c20ec Fix non unity build
#rb trivial
#rnx

[CL 27598228 by alexis matte in ue5-main branch]
2023-09-05 11:40:22 -04:00
alexis matte
fff4fb747f Interchange: Allow translation to happen before openning the import dialog.
Filter the pipelines options with the translated data.

#jira UE-190402
#rb jeanluc.corenthin
#rnx

[CL 27596878 by alexis matte in ue5-main branch]
2023-09-05 10:58:05 -04:00
alexis matte
7c978de0e6 Make sure all options from the import system are supported properly.
#jira UE-193922
#rb jeanluc.corenthin
#rnx

[CL 27524703 by alexis matte in ue5-main branch]
2023-08-31 11:39:42 -04:00
Danny Kabrane
b71b7dc98f Fix Interchange - �Import Done� log record as a failure on import
#jira UE-176283
#rb JeanLuc.Corenthin

[CL 27445227 by Danny Kabrane in ue5-main branch]
2023-08-29 09:58:36 -04:00
JeanLuc Corenthin
0e65bd72c2 Modified Interchange engine in order to add Interchange Import to Dataprep
#jira none
#rb alexis.matte

[CL 27375460 by JeanLuc Corenthin in ue5-main branch]
2023-08-25 09:45:20 -04:00