Commit Graph

43 Commits

Author SHA1 Message Date
matt peters
64658cf6ae GetAssetRegistryTags deprecation: Make the old GetAssetRegistryTags and related functions deprecated.
Upgrade the overrides and callsites in all of Epic's code.
Every class that can be subclassed by licensees that has its override change needs to keep the old version of the function as deprecated. Otherwise subclasses that call Super::GetAssetRegistryTags will have a compile error instead of a deprecation warning.
Several classes had their own extension method for GetAssetRegistryTags being passed on to user data classes. Updated all of those to take FAssetRegistryTagsContext just like GetAssetRegistryTags does.
#rnx
#rb Francis.Hurteau

[CL 30224166 by matt peters in ue5-main branch]
2023-12-08 21:45:21 -05:00
jurre debaare
815af0710f Applying only FootstepEffectTagModifier or FootFXAnimModifier and undoing the apply creates None notifies
#fix re-introduce marking AnimSequence as modified when applying animation-modifier(s), removed in CL 23191977
#jira UE-188597
#rb Thomas.Sarkanen

[CL 26771279 by jurre debaare in ue5-main branch]
2023-08-02 10:19:24 -04:00
graeme thornton
59c57ecd88 Remove redundant scope lock with a conflicting name, caused by robomerge
[FYI] keaton.stewart

[CL 25966406 by graeme thornton in ue5-main branch]
2023-06-13 18:27:52 -04:00
henrik karlsson
f4449d5f25 [Fortnite]
* Fixed linux compile errors

[CL 25965335 by henrik karlsson in ue5-main branch]
2023-06-13 17:56:18 -04:00
rob perren
136f490b47 Anim Modifiers - Can't add multiple modifiers to multiple animation sequences without the engine crashing
[REVIEW] [at]jurre.debaare
#fix prevent deadlocking when trying to cancel async animation compression task while holding onto evaluation/modification lock on current thread
#misc ensure that apply an animation modifier holds aforementioned lock
#misc add bracket to MotionExtractorModifier
#rb Thomas.Sarkanen

#ushell-cherrypick of 25447073 by Jurre.deBaare

#localization none
#tests tested cook on project that was timing out to confirm this fixed the issue

[CL 25964700 by rob perren in ue5-main branch]
2023-06-13 17:35:19 -04:00
jurre debaare
1c7700a71f Move Evaluation lock to higher level, as transacting the Skeleton will regenerate its ReferenceSkeleton
#jira UE-184438
#rb trivial
#preflight 64625b5a3a76d5a567fe900d

[CL 25494942 by jurre debaare in ue5-main branch]
2023-05-16 15:28:57 -04:00
jurre debaare
a3e8a1d2fc Anim Modifiers - Can't add multiple modifiers to multiple animation sequences without the engine crashing
#jira  UE-184438
#fix prevent deadlocking when trying to cancel async animation compression task while holding onto evaluation/modification lock on current thread
#misc ensure that apply an animation modifier holds aforementioned lock
#misc add bracket to MotionExtractorModifier
#preflight 645e19df5b775f11fba5e0fe
#rb Thomas.Sarkanen

[CL 25448534 by jurre debaare in ue5-main branch]
2023-05-12 10:19:37 -04:00
jamie dale
c6b3e9ee21 Use the FMessageDialog overloads that pass the optional title by-value
#jira
#rb none
#rnx

[CL 25062672 by jamie dale in ue5-main branch]
2023-04-15 20:49:52 -04:00
Jurre deBaare
458f97b453 Animation Modifier : Improved Error Handling
- Dll Export the FApplyModifiersScope object to allow batch apply modifiers by script (Python or Blueprint Scripted Actions)
- New API to suppress warning or error dialogs when applying modifiers from script
- Fix : 'YesToAll' 'NoToAll' not respected when both error and warning are throwed from same modifier class

Contributed by Yupeng.Zhang

#rb Jurre.deBaare
#preflight 63c539422e714f64add554e5
#jira UE-172660

[CL 23728150 by Jurre deBaare in ue5-main branch]
2023-01-16 07:04:54 -05:00
Jurre deBaare
31f1b097fd Animation Compression
- Added new compression and 'compiling' API/path
  * Relies on newer DDC API
  * Only fetches compressible data when data is not found in DDC
  * Fetching data happens off the GT now (including Additive animation)
- Deprecated and replace AnimSequence API around compression
** AnimStreamable still relies on old, synchronous, compression path **

IAnimationDataModel
- Removed bone track data being stored as FBoneAnimationTrack
- Bone animation can now only be referenced by Name (not track index anymore)
- Deprecated any API relying on FBoneAnimationTrack
- Added API to retrieve FTransform(s) for given frame(s) with provided bone name
- Added API to lock model against modifications during evaluation (required for non-racing off-GT evaluation)

Animation Sequence
- Frame-rate is now stored on a per-platform basis, allowing for future replacement of frame-stripping (editing property is disabled for now)
- Now allows for storing _transient_ per-platform compressed animation data (required for multi-platform cook)

PerPlatformProperties
- Added per-platform FFrameRate implementation

#preflight 63999f102540a78d2778adb7
#rb Thomas.Sarkanen, Nicholas.Frechette, Devin.Doucette
#fyi Zousar.Shaker

[CL 23510521 by Jurre deBaare in ue5-main branch]
2022-12-14 05:56:08 -05:00
Jurre deBaare
a5305f76a3 Contributed by Yupeng.Zhang from The Coalition:
Animation Modifier : Fix Modifier on Skeleton
Transfered the ownership of 'PreviouslyAppliedModifier' from an animation modifier instance to the animation sequence being applied.
This solved the following issue:
- Modifier on Skeleton cause USkeleton dirtied everytime the modifier is applied to an animation sequence.
- Modifier on Skeleton cannot be re-apply or reverted correctly.
- CanRevert & OutOfDate status for Modifier on Skeleton was not reflect the true status of all animation sequences referencing that skeleton.

- CurrentAnimSequence/CurrentSkeleton was not set on OnRevert()
- IAnimationDataController::FScopedBracket was not open on OnRevert() before re-apply modifier
- Stateful animation modifier can now be reverted correctly (Applied modifier instance is nolonger reverted after OnApply call)

#preflight 63775e0ff514e1ded99ef095

[CL 23191977 by Jurre deBaare in ue5-main branch]
2022-11-18 05:35:47 -05:00
Jurre deBaare
782976dbe4 Crash in UAnimSequence::GetBonePose after adding curve with UAnimationBlueprintLibrary::AddCurve with Anim Modifier
#jira UE-166435
#fix remove scope bracket around application of ANimationModifier, moving responsibility to the user

Curve keys added with Anim Modifiers have incorrect time
#jira UE-166436
#fix ensure that when adding a scalar curve, its tick rate is matched to the AnimModel's, and convert between tick-rate and model frame rate when setting keys

#rb Aaron.Cox
#preflight 6346de84663dafe4162d9485

[CL 22500269 by Jurre deBaare in ue5-main branch]
2022-10-13 05:54:31 -04:00
bryan sefcik
0837230669 Ran IWYU again on half of the Engine/Source/Editor/... source files.
#jira

[CL 21716414 by bryan sefcik in ue5-main branch]
2022-08-30 23:03:03 -04:00
Robb Surridge
0a5a02c5b2 Coding standard fixes: gender-inclusive language
#jira UE-156429
#preflight 62b32e826a25ba6ae52f94bd
#rb jason.walter

[CL 20795375 by Robb Surridge in ue5-main branch]
2022-06-23 11:14:07 -04:00
jurre debaare
fa330baae5 Warning in FortniteEditor Static Analysis Win64 (PVS-Studio): animationmodifier.cpp(103): warning V595: The 'CurrentAnimSequence' pointer was utilized before it was verified
#fix integrating 17963104 and 17948236 to address AnimModifier.cpp static-analysis warnings
#rb none
#preflight 61d6dda0c65e66487b273948

#ROBOMERGE-OWNER: jurre.debaare
#ROBOMERGE-AUTHOR: jurre.debaare
#ROBOMERGE-SOURCE: CL 18532919 via CL 18532974 via CL 18533065 via CL 18533541 via CL 18534001
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18534191 by jurre debaare in ue5-release-engine-test branch]
2022-01-06 14:19:52 -05:00
Marc Audy
0c3be2b6ad Merge Release-Engine-Staging to Test @ CL# 18240298
[CL 18241953 by Marc Audy in ue5-release-engine-test branch]
2021-11-18 14:37:34 -05:00
aurel cordonnier
fc542f6cfd Merge from Release-Engine-Staging @ 18081189 to Release-Engine-Test
This represents UE4/Main @18073326, Release-5.0 @18081140 and Dev-PerfTest @18045971

[CL 18081471 by aurel cordonnier in ue5-release-engine-test branch]
2021-11-07 23:43:01 -05:00
aurel cordonnier
a6e741e007 Merge from Release-Engine-Staging @ 17915896 to Release-Engine-Test
This represents UE4/Main @17911760, Release-5.0 @17915875 and Dev-PerfTest @17914035

[CL 17918595 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-25 20:05:28 -04:00
aurel cordonnier
7f517562d5 Merge from Release-Engine-Staging @ 17438845 to Release-Engine-Test
This represents UE4/Main @17430120 and Dev-PerfTest @17437669

[CL 17439044 by aurel cordonnier in ue5-release-engine-test branch]
2021-09-06 12:23:53 -04:00
julien stjean
e3fb173774 Fixed Static analysis issues in interchange (fbxmesh.h) by changing the function GetMeshUniqueID from FbxHelper to return a empty string when the mesh is empty.
[FYI] Richard.TalbotWatkings

Fixed Static analysis in AnimationModifier.cpp the CurrentAnimSequence ptr can't be null since it was deferenced at the line 75.

Fixed Static analysis in PackageStoreOptimizer for some reason the static analysis did like the way the check was presented.

Fixed Static analysis in SComponentClassCombo.cpp and SDisplayClusterConfiguratorComponentCombo.cpp changed the code so that the static analyser should understand it better.

#jira UE-120410
#rb Jean.MichelDignard

#ROBOMERGE-SOURCE: CL 17071360 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v853-17066230)

[CL 17071396 by julien stjean in ue5-release-engine-test branch]
2021-08-05 13:15:23 -04:00
jurre debaare
69a7c18269 Option to apply Animation Modifiers to only new or changed animations
#feature add ability to only apply out-of-date animation modifiers from asset context menu, and through details view on AnimationModifier classes
#fix ensure that we do not apply pending kill modifiers or instances that are used for reverting
#jira UE-84819
#rb Thomas.Sarkanen
#preflight 60cb38fd6092ba000140842e

#ROBOMERGE-SOURCE: CL 16704034 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v835-16672529)

[CL 16704042 by jurre debaare in ue5-release-engine-test branch]
2021-06-17 09:50:18 -04:00
jurre debaare
6cdfe38db8 Feature Request: Apply All for Animations modified by Anim Modifier
#feature added ApplyModifier scope struct which keeps track of which modifier has prompted the user for any warnings, and allow them to YesAll/NoAll rather than having to individually prompt for each modifier/animation sequence combination
#jira UE-82825
#rb Thomas.Sarkanen

#ROBOMERGE-SOURCE: CL 16671774 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v834-16658389)

[CL 16671775 by jurre debaare in ue5-release-engine-test branch]
2021-06-15 07:23:45 -04:00
Martin Ridgers
ff37feb911 Fix no-unity compile
#rb trivial
#rnx

[CL 15887119 by Martin Ridgers in ue5-main branch]
2021-04-01 05:20:16 -04:00
jurre debaare
349e585908 - Introduces UInterface for UAnimDataController and moves implementation to new AnimationDataController (editor only) module
- Export curve types entirely for use outside of Engine
- Miscellaneous small fixes from UE5 Main
#rb Thomas.Sarkanen
#preflight 6061973e25b98e00019ea154

#ROBOMERGE-OWNER: jurre.debaare
#ROBOMERGE-AUTHOR: jurre.debaare
#ROBOMERGE-SOURCE: CL 15849140 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v786-15839533)
#ROBOMERGE-CONFLICT from-shelf

[CL 15851594 by jurre debaare in ue5-main branch]
2021-03-29 11:34:31 -04:00
Jurre deBaare
8fa69ff878 //UE5/Main - Cook EngineTest Win64 - Assertion failed: !FUObjectThreadContext::Get().IsRoutingPostLoad
#fix update revision GUID for any AnimModifier class its instance during load, rather than forcefully loading them during the CDOs PostLoad
#jira UE-110692
#rb Thomas.Sarkanen

[CL 15710989 by Jurre deBaare in ue5-main branch]
2021-03-16 10:02:58 -04:00