That fix is relativley simple and contained to the content id resolvers themselves (ScyllaContentIdStore).
This bug exposed the confusing use of BlobIdentifier as both a identifier into the blob store (its original intent) and as a content id (which needs to be resolved before it can be used to locate a blob in the blob store).
So I added a new type for ContentId so we can keep track of this seperate, this required quite a lot more refactoring to handle properly (indicating how bad of a state this was in).
This also fixed a issue were ContentHash was not being serialized into compact binary representations in the api, which is now fixed.
This is a potentially dangerous change with lots of things impacted, added a unit test to cover exactly the case that prompted the bug in the first place.
#preflight 61f03244fd5285142b1cf1e5
[CL 18724565 by Joakim Lindqvist in ue5-main branch]
Added a test for multiple pattern schedules as well
#rnx
#jira none
#rb ben.marsh, ryan.durand
#preflight skip
[CL 18715378 by Ryan Hummer in ue5-main branch]
Batch getting these on the server-side leads to less back-and-forth when resolving timings for many jobs.
#fyi chad.garyet
#preflight 61eacb96c92021e535bfa8b0
[CL 18689450 by carl bystrom in ue5-main branch]
Will still only activate as a *hosted* service if configured in settings.
#preflight 61e9708fc92021e53596f8e4
[CL 18674021 by carl bystrom in ue5-main branch]
- Send any queued notifications at a hard-coded 12 hour interval
- Only JobScheduled notifications makes use of this they were too frequent before
#preflight 61e9641b276892ce1091f024
[CL 18673709 by carl bystrom in ue5-main branch]
The old health checks are now moved to a seperate set of endpoints, and I switched our kubernetes configuration over to use that, as noone else should be calling these endpoints now.
The expectation is that this fixes issues we see as Horde Storage scales up and pods starts getting shut down due to failed health checks even though the load doesnt look high enough for that to really happen.
#preflight none
[CL 18659351 by Joakim Lindqvist in ue5-main branch]
