Commit Graph

84 Commits

Author SHA1 Message Date
sebastian nordgren
b9803aee28 Speculative fix for crash when an invalid FPropertyNode is passed into FDetailPropertyRow, causing it to store a null IPropertyHandle pointer that is never checked for validity.
This fix always initializes it to a valid pointer, but invalid handle, which is a state that is handled correctly in FPropertyHandleBase.

#jira UE-130580
[REVIEW] [at]lauren.barnes
#preflight 61e56664a2616066f67fbfa6

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 18639655 in //UE5/Release-5.0/... via CL 18639702 via CL 18639711
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v900-18638592)

[CL 18639724 by sebastian nordgren in ue5-main branch]
2022-01-18 09:53:00 -05:00
thomas sarkanen
d884e2b6fc Fix ExtensionContent not working for FDetailWidgetRow created via IDetailPropertyRow::CustomWidget()
#jira none
#rb Sebastian.Nordgren
[FYI] Sebastian.Nordgren
#preflight 61e57650006b17a68656d278

#ROBOMERGE-AUTHOR: thomas.sarkanen
#ROBOMERGE-SOURCE: CL 18632672 in //UE5/Release-5.0/... via CL 18633038 via CL 18633049
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v899-18417669)

[CL 18637357 by thomas sarkanen in ue5-main branch]
2022-01-18 04:29:05 -05:00
jeremie roy
92747ca450 Fix crash caused by dereferencing nullptr when displaying a detail property row with an external root node using a property row generator
#jira UE-134126
#rb simon.therriault sebastian.nordgren

#ROBOMERGE-AUTHOR: jeremie.roy
#ROBOMERGE-SOURCE: CL 18223217 in //UE5/Release-5.0/... via CL 18223245
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)
#ROBOMERGE[STARSHIP]: UE5-Main

[CL 18223259 by jeremie roy in ue5-release-engine-test branch]
2021-11-17 09:51:59 -05:00
aurel cordonnier
fc542f6cfd Merge from Release-Engine-Staging @ 18081189 to Release-Engine-Test
This represents UE4/Main @18073326, Release-5.0 @18081140 and Dev-PerfTest @18045971

[CL 18081471 by aurel cordonnier in ue5-release-engine-test branch]
2021-11-07 23:43:01 -05:00
aurel cordonnier
a12d56ff31 Merge from Release-Engine-Staging @ 17791557 to Release-Engine-Test
This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485

[CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-12 21:21:22 -04:00
sebastian nordgren
1b97999265 NameContent() in details rows now correctly respects user-defined HAlign, allowing for labels to contain an HBox with both left and right aligned slots.
#rb paul.chipchase
#preflight 614af4fa6a142b0001b2fecf

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 17594051 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v871-17566257)

[CL 17594062 by sebastian nordgren in ue5-release-engine-test branch]
2021-09-22 07:02:49 -04:00
steven dao
2d527f66bd Drag-and-drop to reorder variables in FUserDefinedStructureEditor
- Allow drag-and-drop behavior to be customized for a details widget row
- Cleanup PropertyEditorHelpers::MakePropertyReorderHandle (it was setting the enabled attribute which always ended up getting overwritten)
- Add drag-and-drop handler+op for UserDefinedStructureEditor to enable drag-and-drop reordering. Removed buttons for moving up/down.

#jira UETOOL-2776
#rb sebastian.nordgren
#preflight 6130deb01a52e20001a6c93b

#ROBOMERGE-SOURCE: CL 17404287 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)

[CL 17404301 by steven dao in ue5-release-engine-test branch]
2021-09-02 12:06:51 -04:00
sebastian nordgren
427c03f8cb The IsEnabled() attribute of FDetailPropertyRows and FDetailWidgetRows is now correctly used.
#jira UE-118847
#rb lauren.barnes
#preflight 6130a707f09c6e00015db076

#ROBOMERGE-SOURCE: CL 17403168 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v865-17346139)

[CL 17403204 by sebastian nordgren in ue5-release-engine-test branch]
2021-09-02 10:42:32 -04:00
sebastian nordgren
71aa25c115 Removed check of IsEditConst for DetailPropertyRows, since this was causing elements in VisibleAnywhere containers to not be editable.
#fyi marc.audy, kriss.gossart

[CL 16472196 by sebastian nordgren in ue5-main branch]
2021-05-26 13:51:53 -04:00
Patrick Boutot
aeea5f0679 Slate: Convert SConcertScrollBox, SWrapBox, SBoxPanel, SWindow FSlot's to the FSlotArgument syntax.
#jira UE-114425
#preflight 60adb0b704188d000133d0b9

[CL 16466544 by Patrick Boutot in ue5-main branch]
2021-05-26 06:42:00 -04:00
sebastian nordgren
4568c16c4e Fixed warnings related to &= in DetailPropertyRow.cpp on old VS compiler versions.
#jira UE-116397

#ROBOMERGE-SOURCE: CL 16446098 in //UE5/Main/... via CL 16446102
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Release-Engine-Staging) (v814-16434418)

[CL 16446106 by sebastian nordgren in ue5-release-engine-staging branch]
2021-05-25 07:16:15 -04:00
sebastian nordgren
8d9ccdd48d Fixed warnings related to &= in DetailPropertyRow.cpp on old VS compiler versions.
#jira UE-116397

[CL 16446098 by sebastian nordgren in ue5-main branch]
2021-05-25 07:14:01 -04:00
sebastian nordgren
e4fc76dfd1 Property rows with custom widgets now default to the standard IsEnabled check if a custom one is not set.
#jira UE-115779
#rb lauren.barnes, danny.chapman

[CL 16434493 by sebastian nordgren in ue5-main branch]
2021-05-24 07:26:49 -04:00
aurel cordonnier
8eebe8841f Merge UE5/RET @ 16305968 to UE5/Main
This represents UE4/Main @ 16261013 and Dev-PerfTest @ 16259937

[CL 16306996 by aurel cordonnier in ue5-main branch]
2021-05-12 18:10:03 -04:00
sebastian nordgren
ca7a047932 Edit conditions for properties that don't support edit condition toggles no longer checkSlow when retrieving the check state, but rather only when setting it.
CustomEditConditionValueChanged handlers are now postfixed with a call to FPropertyNode::InvalidateCachedState(), which causes the IsEditConst state to refresh.

Removed unnecessary code to access the PropertyEditor->IsEditConditionMet(), which is stored in EditConditionValue now.

#review @lauren.barnes, @patric.boutot
#jira FROST-1702

[CL 16008018 by sebastian nordgren in ue5-main branch]
2021-04-14 13:15:46 -04:00
sebastian nordgren
13d3eced9f When creating a CustomWidget from an FDetailPropertyRow ie. Category.AddProperty(MyProperty).CustomWidget(), we now forward the property handle to the widget row as well.
#rb lauren.barnes

[CL 15872336 by sebastian nordgren in ue5-main branch]
2021-03-31 04:11:44 -04:00
sebastian nordgren
a496f31be5 Moved unnecessary padding from FDetailPropertyRow that was causing 4 pixels of padding to always appear on the right and throw off alignment in the details panel.
#rb trivial

#ROBOMERGE-SOURCE: CL 15406764 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15406767 by sebastian nordgren in ue5-main branch]
2021-02-15 10:57:06 -04:00
lauren barnes
70f0a2dc9b Changing a check to an ensure so we can find the indeterminate behavior but not crash.
#rb Brooke.Hubert
[FYI] Sebastian.Nordgren

#ROBOMERGE-SOURCE: CL 15392972 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15393063 by lauren barnes in ue5-main branch]
2021-02-11 18:15:30 -04:00
sebastian nordgren
270e57b642 Added FDetailPropertyRow::SetWidgetRowProperties to handle the setting of the FDetailWidgetRow's custom properties correctly in both cases that it's used.
#rb paul.chipchase

#ROBOMERGE-SOURCE: CL 15386872 in //UE5/Release-5.0-EarlyAccess/...
#ROBOMERGE-BOT: STARSHIP (Release-5.0-EarlyAccess -> Main) (v771-15082668)

[CL 15386875 by sebastian nordgren in ue5-main branch]
2021-02-11 07:59:12 -04:00
sebastian nordgren
00cdd61257 Details view labels are now, once again, left aligned.
#rb lauren.barnes

[CL 15279030 by sebastian nordgren in ue5-main branch]
2021-02-02 05:21:40 -04:00
sebastian nordgren
b480730be1 Property names in the details panel are now clipped consistently, rather than allowing a bit of slack that causes the text to zig-zag when the column is resized to be small.
#rb trivial

[CL 15130819 by sebastian nordgren in ue5-main branch]
2021-01-18 11:56:26 -04:00
sebastian nordgren
548ca6c766 IWYU. Removed unnecessary includes of SResetToDefaultPropertyEditor.
[CL 15009203 by sebastian nordgren in ue5-main branch]
2021-01-07 05:41:03 -04:00
sebastian nordgren
aedd43a9d1 Detail property rows that had a custom widget defined for them now correctly call the OverrideResetToDefault delegate given to the custom widget row.
FPropertyHandleImpl also no longer causes an infinite loop of deferred actions when a custom reset to default is set on a property row.

#rb lauren.barnes
#fyi kiaran.ritchie

[CL 14842839 by sebastian nordgren in ue5-main branch]
2020-12-03 06:13:13 -04:00
sebastian nordgren
09b15cf70d Exposed SResetToDefaultPropertyEditor publicly to allow it to be used for material slots.
#rb lauren.barnes

[CL 14444449 by sebastian nordgren in ue5-main branch]
2020-10-08 03:21:16 -04:00
sebastian nordgren
5050b88330 Details view reskin phase 1.
The details view now displays gridlines between rows, and now has 4 columns - edit condition, name, value, and reset/extensions.

Edit condition widgets are now created in SDetailSingleItemRow and are placed in their own fixed column on the left of the details view. FEditConditionParser is now in FPropertyNode rather FPropertyEditor, which allows access to it more broadly - notably in SDetailSingleItemRow.

The Reset to Default SWidget can no longer be replaced - the logic for it being visible and a handler for when it is pressed is still customizable. SPropertyEditorAsset no longer has a special slot for the reset to default widget.

All extension widgets are now placed in a resizable column on the right of the panel, including the Keyframe button.

FDetailColumnSizeData is now publicly exposed by IDetailsView, and is no longer passed around as much.

#rb matt.kuhlenschmidt

[CL 14375859 by sebastian nordgren in ue5-main branch]
2020-09-23 08:16:20 -04:00