Commit Graph

1110 Commits

Author SHA1 Message Date
sebastian nordgren
74959d7da3 FPropertyHandleObject::SetValue when called with an FAssetData no longer always marks an asset as dirty if the new value is identical to the previous value.
This makes an assumption the FObjectPropertyBase::GetExportPath() will continue to return the value in 'ClassName'ObjectPath format, but that seems very unlikely to change and is depended on elsewhere so this can be considered an acceptable risk.

Suggested by UDN: https://epicgames.lightning.force.com/lightning/r/Case/5004z00001ay3pbAAA/view

#rb paul.chipchase
#preflight 61efd42b8c16f8372245a8f2

[CL 18721203 by sebastian nordgren in ue5-main branch]
2022-01-25 06:05:21 -05:00
marc audy
6553e6cd0a Remove as much C++ deprecation as possible up to 4.17 (along with a few scattered removals from beyond)
#preflight 61eefc77ba69a4fdb220bf23

#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 18712765 in //UE5/Release-5.0/... via CL 18712784 via CL 18713147
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18713191 by marc audy in ue5-main branch]
2022-01-24 15:07:48 -05:00
simon therriault
106ad125a5 - Reverting show hidden properties bypassing customized struct
#rb none
#jira none
#preflight 61eed810ba69a4fdb216d923

#ROBOMERGE-AUTHOR: simon.therriault
#ROBOMERGE-SOURCE: CL 18710054 in //UE5/Release-5.0/... via CL 18710097 via CL 18710221
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18710247 by simon therriault in ue5-main branch]
2022-01-24 12:04:25 -05:00
michael noland
92354cbf98 Added a bit more information to what failed when an edit condition cannot be parsed, indicating whether it was an issue with the type or the value
#preflight none

#ROBOMERGE-AUTHOR: michael.noland
#ROBOMERGE-SOURCE: CL 18705386 in //UE5/Release-5.0/... via CL 18705389 via CL 18705411
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18705413 by michael noland in ue5-main branch]
2022-01-23 20:20:41 -05:00
patrick hardy
9939de5f19 Fixed removing an instanced element from a map or set not using the internal index for object lookup.
#jira UE-139981
#rb marc.audy
#preflight 61eb42cb731e3b4088a504ae

#ROBOMERGE-AUTHOR: patrick.hardy
#ROBOMERGE-SOURCE: CL 18699372 in //UE5/Release-5.0/... via CL 18699470 via CL 18699524
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18699561 by patrick hardy in ue5-main branch]
2022-01-21 18:49:57 -05:00
frank fella
2a62ba523e PropertyEditor - Expose an api on the property row generator to invalidate cached internal data so that visual state can be refreshed when the displayed object is modified from non property editor code.
#rb sebastian.nordgren
#preflight 61ead90d731e3b4088910db0

#ROBOMERGE-AUTHOR: frank.fella
#ROBOMERGE-SOURCE: CL 18691530 in //UE5/Release-5.0/... via CL 18691872 via CL 18692095
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18692290 by frank fella in ue5-main branch]
2022-01-21 13:31:29 -05:00
denys dubinin
907d9285ec BUG in RC and Material List. Slow details panel performance when lots of material slots are involved
#rb simon.therriault
#jira UE-138225
#preflight 61e841d0e543b825456e1952

#ROBOMERGE-AUTHOR: denys.dubinin
#ROBOMERGE-SOURCE: CL 18690369 in //UE5/Release-5.0/... via CL 18690385 via CL 18690405
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18690427 by denys dubinin in ue5-main branch]
2022-01-21 11:34:04 -05:00
jamie dale
d8a032c47c Avoid filtering sub-categories that may yet contain properties
#preflight 61e9a96a1739bb8724d865a9
#rb Jason.Stasik

#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 18679333 via CL 18679357 via CL 18679379 via CL 18679387 via CL 18681207 via CL 18681244 via CL 18681285
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v902-18672795)

[CL 18681568 by jamie dale in ue5-main branch]
2022-01-20 16:32:50 -05:00
simon therriault
54e2cac693 - Updating detail category node generation to consider ShouldShowHiddenProperties flag before discarding a customized node
#rb sebastian.nordgren
#jira UE-138909
#preflight 61e97d56f1602135349dedcc

#ROBOMERGE-AUTHOR: simon.therriault
#ROBOMERGE-SOURCE: CL 18675227 in //UE5/Release-5.0/... via CL 18675254 via CL 18675265
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v902-18672795)

[CL 18679734 by simon therriault in ue5-main branch]
2022-01-20 15:24:26 -05:00
sebastian nordgren
b9803aee28 Speculative fix for crash when an invalid FPropertyNode is passed into FDetailPropertyRow, causing it to store a null IPropertyHandle pointer that is never checked for validity.
This fix always initializes it to a valid pointer, but invalid handle, which is a state that is handled correctly in FPropertyHandleBase.

#jira UE-130580
[REVIEW] [at]lauren.barnes
#preflight 61e56664a2616066f67fbfa6

#ROBOMERGE-AUTHOR: sebastian.nordgren
#ROBOMERGE-SOURCE: CL 18639655 in //UE5/Release-5.0/... via CL 18639702 via CL 18639711
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v900-18638592)

[CL 18639724 by sebastian nordgren in ue5-main branch]
2022-01-18 09:53:00 -05:00
thomas sarkanen
fe89ad5266 Custom copy/paste actions now pulse the details row to indicate they were run
Previously the row only pulsed if it ran the built-in copy/paste routines

#jira none
#rb Sebastian.Nordgren
#preflight 61e59409a2616066f686b35b

#ROBOMERGE-AUTHOR: thomas.sarkanen
#ROBOMERGE-SOURCE: CL 18633622 in //UE5/Release-5.0/... via CL 18633637 via CL 18633649
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v899-18417669)

[CL 18637386 by thomas sarkanen in ue5-main branch]
2022-01-18 04:32:02 -05:00
thomas sarkanen
d884e2b6fc Fix ExtensionContent not working for FDetailWidgetRow created via IDetailPropertyRow::CustomWidget()
#jira none
#rb Sebastian.Nordgren
[FYI] Sebastian.Nordgren
#preflight 61e57650006b17a68656d278

#ROBOMERGE-AUTHOR: thomas.sarkanen
#ROBOMERGE-SOURCE: CL 18632672 in //UE5/Release-5.0/... via CL 18633038 via CL 18633049
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v899-18417669)

[CL 18637357 by thomas sarkanen in ue5-main branch]
2022-01-18 04:29:05 -05:00
stu mckenna
6fbad33170 - Fix crash when toggling a bool property
#rb frank.fella
#jira none
#rnx
#preflight 61df116dff67b6fe7abd8695

#ROBOMERGE-AUTHOR: stu.mckenna
#ROBOMERGE-SOURCE: CL 18586417 in //UE5/Release-5.0/... via CL 18586434 via CL 18586445
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v899-18417669)

[CL 18586456 by stu mckenna in ue5-main branch]
2022-01-12 12:48:03 -05:00
sebastian nordgren
928f4adad7 Property matrix now correctly displays EditCondition checkboxes only when applicable to the row. Property matrix rows also hide if the EditConditionHides metadata is set.
#jira UE-117103
#review-18517480 @lauren.barnes

[CL 18584618 by sebastian nordgren in ue5-main branch]
2022-01-12 10:43:58 -05:00
bob tellez
af1dd6ea3e #UE Move objects referred to by instanced array/set/map properties to the transient package when removed from the container type. This was already the case for ActorComponents, but now applies to all objects referred to by instanced properties.
#rb Marc.Audy

#ROBOMERGE-AUTHOR: bob.tellez
#ROBOMERGE-SOURCE: CL 18574430 via CL 18574434 via CL 18574435 via CL 18574440 via CL 18574664 via CL 18574676 via CL 18574681
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v899-18417669)

[CL 18574694 by bob tellez in ue5-main branch]
2022-01-11 13:37:28 -05:00
bob tellez
c1e0611ab5 #UE Move objects referred to by instanced array/set/map properties to the transient package when removed from the container type. This was already the case for ActorComponents, but now applies to all objects referred to by instanced properties.
#rb Marc.Audy

#ROBOMERGE-AUTHOR: bob.tellez
#ROBOMERGE-SOURCE: CL 18574430 via CL 18574434 via CL 18574435 via CL 18574440 via CL 18574664 via CL 18574676
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18574681 by bob tellez in ue5-release-engine-test branch]
2022-01-11 13:36:13 -05:00
Robert Manuszewski
13573e3787 Refactoring compiled-in FProperty constructors so that they have the same signature
#jira SOL-1981
#rb Steve.Robb
#preflight 61dc0bbcaf44b43628348c9b

[CL 18558135 by Robert Manuszewski in ue5-main branch]
2022-01-10 06:22:03 -05:00
semion piskarev
93ed014029 Added LinearDeltaSensitivity metadata tag to make it possible for detail panel sliders to not be exponential. Used it in a couple of modeling tools.
#rb Patrick.Boutot
#rnx
#jira UE-96690
#preflight 61d73f18db0309127d18cf20

#ROBOMERGE-AUTHOR: semion.piskarev
#ROBOMERGE-SOURCE: CL 18534516 in //UE5/Release-5.0/... via CL 18534588 via CL 18534642
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v899-18417669)

[CL 18534655 by semion piskarev in ue5-main branch]
2022-01-06 14:41:14 -05:00
semion piskarev
75a5775fc0 Added LinearDeltaSensitivity metadata tag to make it possible for detail panel sliders to not be exponential. Used it in a couple of modeling tools.
#rb Patrick.Boutot
#rnx
#jira UE-96690
#preflight 61d73f18db0309127d18cf20

#ROBOMERGE-AUTHOR: semion.piskarev
#ROBOMERGE-SOURCE: CL 18534516 in //UE5/Release-5.0/... via CL 18534588
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18534642 by semion piskarev in ue5-release-engine-test branch]
2022-01-06 14:39:38 -05:00
Marc Audy
c43360f47c Eliminate whitespace only differences between Release-Engine-Staging and Release-Engine-Test
#[fyi] Aurel.Cordonnier

#ushell-cherrypick of 18448630 by Marc.Audy
#preflight none

[CL 18483677 by Marc Audy in ue5-main branch]
2021-12-17 03:41:59 -05:00
daren cheng
4bb7d6c36f Check if asset is UWorld before opening to prevent loss of work in current level.
#jira UE-136742
#rb sebastian.nordgren
#preflight 61b90f70032c36821eadb466

#ROBOMERGE-AUTHOR: daren.cheng
#ROBOMERGE-SOURCE: CL 18461123 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v898-18417669)
#ROBOMERGE[STARSHIP]: UE5-Release-Engine-Staging Release-5.0

[CL 18461144 by daren cheng in ue5-release-engine-test branch]
2021-12-14 17:45:42 -05:00
daren cheng
e30041a3cb Check if asset is UWorld before opening to prevent loss of work in current level.
#jira UE-136742
#rb sebastian.nordgren
#robomerge 5.0
#preflight 61b90f70032c36821eadb466

[CL 18461123 by daren cheng in ue5-main branch]
2021-12-14 17:44:55 -05:00
daren cheng
4759c262ba Fix TMap key EditInlineNew if value is EditInlineNew.
#jira UE-137280
#rb sebastian.nordgren
#preflight 61b90f3f8f57c5c0c2289713

#ROBOMERGE-AUTHOR: daren.cheng
#ROBOMERGE-SOURCE: CL 18461100 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v898-18417669)
#ROBOMERGE[STARSHIP]: UE5-Release-Engine-Staging Release-5.0

[CL 18461108 by daren cheng in ue5-release-engine-test branch]
2021-12-14 17:44:26 -05:00
daren cheng
bb88259ae8 Fix TMap key EditInlineNew if value is EditInlineNew.
#jira UE-137280
#rb sebastian.nordgren
#robomerge 5.0
#preflight 61b90f3f8f57c5c0c2289713

[CL 18461100 by daren cheng in ue5-main branch]
2021-12-14 17:43:57 -05:00
jay nakai
06471344b3 Fix crash when pasting an empty string, or string with multiple empty entries using newlines separators, into bulk property editor. Crash was an index-out-of-bound because code assumed at least one entry would exist after calling ParseIntoArray
Explicitly handle pasting a single empty string by creating Row and Cell entries in that situation. Updated paste handler so when pasting a string with multiple empty strings with newline separators, each empty string is treated like an empty row string. This makes pasting a string with empty row strings more consistent, as rows will no longer get trimmed and potentially mutate the expected outcome

#rb Brooke.Hubert
#rb Sebastian.Nordgren

#ROBOMERGE-AUTHOR: jay.nakai
#ROBOMERGE-SOURCE: CL 18455838 via CL 18455858 via CL 18455892 via CL 18455909 via CL 18456550 via CL 18456582 via CL 18456598
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v898-18417669)

[CL 18456630 by jay nakai in ue5-main branch]
2021-12-14 13:35:58 -05:00