Commit Graph

161 Commits

Author SHA1 Message Date
robb surridge
04588085d2 Fix broken links to documentation in header and source files.
#jira none
#rb trivial
#preflight 61f0445dff453b751b38959f

#ROBOMERGE-AUTHOR: robb.surridge
#ROBOMERGE-SOURCE: CL 18726086 in //UE5/Release-5.0/... via CL 18726097 via CL 18726340
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18726365 by robb surridge in ue5-main branch]
2022-01-25 14:22:58 -05:00
helen yang
a421fe4d4d Fixes for MetaSound rename and delete editor commands
- Change delete command to only use delete key instead of backspace
- Allow rename action on interface menu items
- Fix crash caused by invalid rename request handle

#jira UE-135967
#rb rob.gay
#preflight 61efab0ca5126b4d3e833747

#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 18725047 in //UE5/Release-5.0/... via CL 18725247 via CL 18725393
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18725412 by helen yang in ue5-main branch]
2022-01-25 13:25:11 -05:00
rob gay
193ab59674 Fix bit from a CL not meant to go in with last fix-up
#rb trivial
#jira none
#rnx
#preflight buildfix

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18716589 in //UE5/Release-5.0/... via CL 18716614 via CL 18716760
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18717203 by rob gay in ue5-main branch]
2022-01-24 19:04:57 -05:00
rob gay
a7c5ad05ed Fix missed hard-coded data type names in a couple functions
#rb trivial
#rnx
#jira none
#preflight skip

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18716287 in //UE5/Release-5.0/... via CL 18716302 via CL 18716735
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18717188 by rob gay in ue5-main branch]
2022-01-24 19:04:21 -05:00
rob gay
c67bb7d0a4 Clean-up upgrade note logic (do not clear in validation step and clear style field when presaving via UMetasoundEditorGraph as doing so in validation marks graph as dirty post save when not desired)
#rb helen.yang
#rnx
[FYI] sondra.moyls
#jira none
#preflight 61ef2e98ca3de856bcdea81b

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18716201 in //UE5/Release-5.0/... via CL 18716213 via CL 18716355
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18717179 by rob gay in ue5-main branch]
2022-01-24 19:04:00 -05:00
rob gay
55d5407a44 Rebuild keys when searching for open MetaSounds to re-register (keys could be out-of-date and cause some MetaSounds to not get re-registered when expected. Can manifests as composed graphs being out-of-date in editor and not always updating).
#rb trivial
#jira none
#rnx
[FYI] sondra.moyls
#preflight 61eb158a731e3b40889d239b

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18695182 in //UE5/Release-5.0/... via CL 18695202 via CL 18695239
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18695276 by rob gay in ue5-main branch]
2022-01-21 15:40:14 -05:00
rob gay
fe1d4b93a4 Don't serialize cached dependency data on MetaSound graphs to avoid text desync or out-of-date data when autoupdate is disabled for a given asset.
TODO: Split out FMetasoundFrontendClass to class & dependency struct, where dependency is only the information required to find an item in the registry and potentially a couple non-localized breadcrumbs
#rb phil.popp
#jira none
#rnx
#preflight 61e8f894276892ce10892644
#preflight 61e9f7f91739bb8724e071ec

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18684546 in //UE5/Release-5.0/... via CL 18684559 via CL 18684566
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v902-18672795)

[CL 18684575 by rob gay in ue5-main branch]
2022-01-20 19:19:55 -05:00
helen yang
5a72e56aa5 Prevent creating reference loops when dragging and dropping MetaSounds
- Also show appropriate messaging and cancel transaction if invalid

#jira UE-137117
#jira UE-139205

#rb rob.gay
#preflight 61e75133f517d721f97f53d8

#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 18677056 in //UE5/Release-5.0/... via CL 18677063 via CL 18677069
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v902-18672795)

[CL 18680203 by helen yang in ue5-main branch]
2022-01-20 15:40:20 -05:00
rob gay
472ba41220 Fix bug with document dependency synchronization by refactoring Document FrontendClass Synchronization to be more clear by renaming as RemoveUnreferencedDependencies & adding option to FindOrAddClass to synchronize if class is found already with registry
#rb phil.popp
#rnx
#jira UE-137696
#preflight 61e8a561da16597a1f4967c3

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18669591 in //UE5/Release-5.0/... via CL 18669597 via CL 18669618
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v901-18665521)

[CL 18669641 by rob gay in ue5-main branch]
2022-01-19 19:32:01 -05:00
rob gay
214a8e1e5f Mark all open nodes referenced by an asset as needing to be refreshed when renaming an asset
#jira UE-137696
#rb helen.yang
#rnx
#preflight 61e73a177f0c4b5aad71dbb4

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18649056 in //UE5/Release-5.0/... via CL 18649470 via CL 18649776
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v900-18638592)

[CL 18650046 by rob gay in ue5-main branch]
2022-01-18 17:48:25 -05:00
helen yang
df6218aabf Fix various MetaSound Input Widget and Default Clamp issues
- added option for volume slider to output linear (0-1) value while displaying dB value
- edge case handling for volume and frequency ranges causing widgets to get stuck
- fix functionality and details panel for clamp and other input float properties
- don't show widgets or widget options on readonly graphs

#jira UE-135525
#jira UE-127715
#jira UE-135856
#jira UE-135866
#jira UE-137488

#rb rob.gay
#preflight 61e0acce250b9537f783ed35

#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 18620012 in //UE5/Release-5.0/... via CL 18620328 via CL 18620770
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v899-18417669)

[CL 18621051 by helen yang in ue5-main branch]
2022-01-14 14:01:09 -05:00
phil popp
cc3974e78c Cleanup metasound deprecation wording in code.
Add visual warning for deprecated metasound nodes.
#rb Rob.Gay
#jira UE-137119
#preflight 61e04af4797757aace801bf4

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 18597781 in //UE5/Release-5.0/... via CL 18597791 via CL 18597807
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v899-18417669)

[CL 18597823 by phil popp in ue5-main branch]
2022-01-13 11:36:48 -05:00
phil popp
07cf8fc40c Fix for ensure when adding variable set or get node when dragged from pin.
#jira UE-135952
#rb Rob.Gay, Helen.Yang
#preflight 61ddce0cce7fe7aeff6b621f

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 18574927 in //UE5/Release-5.0/... via CL 18574938
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18574950 by phil popp in ue5-release-engine-test branch]
2022-01-11 13:56:42 -05:00
rob gay
682aec537b Missing Forward Declarations
#rb trivial
#rnx
#jira UE-138352
#preflight skip

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18526252 in //UE5/Release-5.0/... via CL 18526257
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18526267 by rob gay in ue5-release-engine-test branch]
2022-01-05 18:17:17 -05:00
rob gay
f15e92afd2 Fix static analysis warning
#rb trivial
#jira none
#rnx
#preflight 61d51eb8c73b7e46b2631f0a

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18516239 in //UE5/Release-5.0/... via CL 18516248
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18516253 by rob gay in ue5-release-engine-test branch]
2022-01-04 23:44:51 -05:00
rob gay
14ae84810f - Add support for MetaSound Editor UObject array drag/drop
- Checkpoint: Clean-up MetaSound Editor Graph Literal Customization Factory Code
#rb phil.popp
#rnx
#jira UE-112876
#jira UE-137578
#preflight 61d397605d522c9b407a6e29

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18512006 in //UE5/Release-5.0/... via CL 18512018
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18512066 by rob gay in ue5-release-engine-test branch]
2022-01-04 15:17:54 -05:00
helen yang
e692a370b4 Enable F2 for renaming MetaSound member and comment nodes
- Also add rename to action menu when right clicking on node

#jira UE-116872
#rb rob.gay
#preflight 61ba5c8c08091d99edcc6cac


#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 18476783 in //UE5/Release-5.0/... via CL 18481369
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18481462 by helen yang in ue5-release-engine-test branch]
2021-12-16 19:29:43 -05:00
aaron mcleran
0ffa11ba73 Adding new interface for one-shots, upgrading old metasounds to use new interface if they hooked up the on-finished trigger.
Great test-case for interfaces and our upgrade code paths.

#rb Rob.Gay
#jira UE-137708
#preflight 61ba7d64753a9d8c87c2a038

#ROBOMERGE-AUTHOR: aaron.mcleran
#ROBOMERGE-SOURCE: CL 18472322 in //UE5/Release-5.0/... via CL 18473370
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18473402 by aaron mcleran in ue5-release-engine-test branch]
2021-12-15 23:11:10 -05:00
mark lintott
a8d06c0c1f Non-Unity Fix
[FYI] rob.gay
#rb trival
#preflight 61b8811bb026ce352ac11ecd

#ROBOMERGE-AUTHOR: mark.lintott
#ROBOMERGE-SOURCE: CL 18453422 in //UE5/Release-5.0/... via CL 18453424
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v898-18417669)

[CL 18453426 by mark lintott in ue5-release-engine-test branch]
2021-12-14 06:46:30 -05:00
rob gay
bf91eee1a9 Tooltip fix-up
#rb trivial
#jira none
#rnx

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18450236 in //UE5/Release-5.0/... via CL 18450247
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v897-18405271)

[CL 18450252 by rob gay in ue5-release-engine-test branch]
2021-12-13 18:37:29 -05:00
rob gay
3e9eab6da9 - Rename & redirect MetaSoundEditorGraph<Input>Literals to MetaSoundEditorGraph<DefaultMember>Literals
- First pass at consolidating editor code for API members/vertices where possible
- Make Variables & Output now use default literal for input value (so user doesn't have to hunt down literal box in graph)

Various bug fixes:
- Fixes crash in post undo after updating a variable default
- Fixes ':Array' flavor showing up in new SearchableComboBox when selecting `Is Array` for literal type
- Synchronize variable setter default literal with variable interface default literal
- Provide default literal field for outputs & variables for consistency
    - Added win is widget support for single input/output types (i.e. floats for now)
- Don't show trigger simulate option on non-transmissible inputs (ex. OnPlay)
- Set simulate button visibility to only show when parameter transmission is supported by input
- Make simulate buttons in graph only visible when sound plays
- Start sounds automatically when clicking simulate in inspector
- Fixed initial condition "holding" trigger state for trigger routing now that Transmission System is only used inter-MetaSound (not intra-MetaSound) and we are deprecating Send/Receives

#rb phil.popp
#rnx
#jira UE-135813
#jira UE-132900
#jira UE-135844
#jira UE-116867
#jira UE-135366
#jira UE-137310
#preflight 61b7afe4fc570891338fea08

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18450046 in //UE5/Release-5.0/... via CL 18450065
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v897-18405271)

[CL 18450072 by rob gay in ue5-release-engine-test branch]
2021-12-13 18:15:01 -05:00
rob gay
3bdc09e2a5 Backout out backed out changelist 18369256 (includes AudioComponent redirect fix)
-----------------------------------------------------------------
MetaSounds Interfaces Checkpoint 2:
- Version up source archetypes to become two interfaces: channel interfaces (mono/stereo) & base source namespace
- Clean-up Interface panel to support namespacing better
- Fix bugs with assuming interfaces are always and the only base namespace members
- Allow namespacing for any arbitrary interface member
- Add lock icon to clarify what interface members cannot be modified individually (i.e. cannot add, remove, or rename them as they are interface members)
- Organize members alphabetically
#jira UE-135000
#rnx
#rb phil.popp
#preflight 61a7d1079c77d610079303ec
#p4v-cherrypick 18344347

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18413245 via CL 18413381 via CL 18413401 via CL 18434953 via CL 18437303
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v897-18405271)

[CL 18437360 by rob gay in ue5-release-engine-test branch]
2021-12-10 20:37:31 -05:00
aurel cordonnier
3e68a3edef [Backout] - CL18345215
[FYI] rob.gay
Original CL Desc
-----------------------------------------------------------------
MetaSounds Interfaces Checkpoint 2:
- Version up source archetypes to become two interfaces: channel interfaces (mono/stereo) & base source namespace
- Clean-up Interface panel to support namespacing better
- Fix bugs with assuming interfaces are always and the only base namespace members
- Allow namespacing for any arbitrary interface member
- Add lock icon to clarify what interface members cannot be modified individually (i.e. cannot add, remove, or rename them as they are interface members)
- Organize members alphabetically
#jira UE-135000
#rnx
#rb phil.popp
#preflight 61a7d1079c77d610079303ec
#p4v-cherrypick 18344347

#ROBOMERGE-AUTHOR: aurel.cordonnier
#ROBOMERGE-SOURCE: CL 18369256 via CL 18369273 via CL 18369290 via CL 18434224 via CL 18435611
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v897-18405271)

[CL 18436532 by aurel cordonnier in ue5-release-engine-test branch]
2021-12-10 19:13:22 -05:00
helen yang
598e0756c1 MetaSound conversion node improvements
- enable autoconverter nodes between enums and int32 (and vice versa)
- add background image and description with typenames for autoconverter nodes to match BP
- update conversion nodes appearance to match autoconversion nodes

#jira UE-134658
#rb phil.popp, rob.gay
#preflight 61ae59618358693a22c32d61

#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 18386410 in //UE5/Release-5.0/... via CL 18386422
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v896-18170469)

[CL 18386437 by helen yang in ue5-release-engine-test branch]
2021-12-06 14:40:38 -05:00
rob gay
a62cf6bce9 Move EditorModule to be public header to load from other modules
#rb phil.popp
[FYI] dan.reynolds
#lockdown Jeff.Farris
#preflight 6167658f6fb125000107a926

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 17809827 via CL 17999012 via CL 18368462 via CL 18368551
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18368600 by rob gay in ue5-release-engine-test branch]
2021-12-03 10:23:37 -05:00