Commit Graph

103 Commits

Author SHA1 Message Date
danny chapman
0e5c4849f3 Build fix - make some functions inline so they can be used elsewhere
#rb trivial
#preflight 647a01e3e75a2263919b0dc5

[CL 25764895 by danny chapman in ue5-main branch]
2023-06-02 12:32:07 -04:00
kirill zorin
b6ee3a6c64 Fix UE_LOG callsites that have format string-related UB
#rb trivial
#preflight 647107780a6634dbb236a0a6

[CL 25651638 by kirill zorin in ue5-main branch]
2023-05-26 15:52:39 -04:00
dan oconnor
0a97a12d8b Mark FSimSpaceSettings as POD, it has a constructor but can be copied with memcpy, this will result in STRUCT_IsPlainOldData being set, which will speed up working with UserDefinedStructs that aggregate this structure. This structure has been embedded heavily in some UserDefinedStruct (ex. RBANParamsStruct). Drawback to this change is that if we add NON-Pod data to this structure we will memcpy it.
#rb chris.caulfield
#jira
#rnx

[CL 25644740 by dan oconnor in ue5-main branch]
2023-05-26 12:11:11 -04:00
chris caulfield
dd1b9b3b14 RBAN - temp workaround and logging for OOB access of BodyAnimData
#rb benn.gallagher

[CL 25592108 by chris caulfield in ue5-main branch]
2023-05-23 18:11:16 -04:00
sergio gardeazabal
d907da5d37 [Chaos VD] Implemented Recording using Trace
- Created a set of macros to trace data about Solver Frames, Solver Steps, and Solver Particles on Rigid Solvers and RBAN solvers
- Added a way to have the context between CVDTrace calls to know which solver started the call on a determined solver step or particle without having to copy that information to every object

#rb benn.gallagher
#jira UE-181330
#preflight 643d9d4c0a5a4b944e348487

[CL 25077633 by sergio gardeazabal in ue5-main branch]
2023-04-17 18:20:36 -04:00
nick brett
c339d7a6be [UE] Add ECVF_Scalability flag to p.RigidBodyNode and p.ClothPhysics CVars
- This will allow the ''Preview Rendering Level' setting in editor to set the CVars to the values defined in platform device profiles.

#rb [at]Benn.Gallagher, [at]Ben.Woodhouse

[CL 23741214 by nick brett in ue5-main branch]
2023-01-17 13:13:07 -05:00
jaime cifuentes
a20a6e0027 Added validation and visual error functionality to AnimNode_SkeletalControlBase, which can be used to check referenced bones and show errors on the AnimGraph nodes that use them (so it is clear if the setup does not work due to a bone missing)
#rb thomas.sarkanen
#jira UE-160111
#preflight 63b85453c927e34482895de4

[CL 23599353 by jaime cifuentes in ue5-main branch]
2023-01-06 12:16:12 -05:00
chris caulfield
cd0fbfbe92 Chaos - fix RBAN SimulationSpace force transfer when using Bone-Space mode and scaling to zero
[FYI] frederick.lupien
#rb none
#preflight 637d5681815e4b9b7578ee75

[CL 23244705 by chris caulfield in ue5-main branch]
2022-11-22 20:28:51 -05:00
Chris Caulfield
2f240b0614 Fix RBAN TeleportPhysics handling
This fixes a character movement related issue where walking into a moving kinematic object would stop the RBAN nodes from simulating altogether because the moving kinematic moves the movement component which triggers a TeleportPhysics.

#rb benn.gallagher, satchit.subramanian
#jira none
#preflight 6376a411fa348e8480775c8b

[CL 23184228 by Chris Caulfield in ue5-main branch]
2022-11-17 16:47:48 -05:00
henrik karlsson
fa90b399a4 Added includes for future change. This changelist only contains added #include and a couple of empty placeholder files
Tested compiling fortnite, unrealeditor, lyra, qagame with non-unity/pch

#preflight 63635997876630122adeab9f
#rb none

[CL 22958990 by henrik karlsson in ue5-main branch]
2022-11-03 14:18:47 -04:00
henrik karlsson
b5b86c796c This change is a strategical submit for a coming change that removes lots of includes in headers that are included by many files. This change contains adding of includes in files that previously got those includes transitively from other inclkudes
#preflight 6355d4940313c24974b2107b
#rb none

[CL 22783162 by henrik karlsson in ue5-main branch]
2022-10-26 12:57:32 -04:00
jaime cifuentes
39bb9b978b Truncation fixes for AnimationGraphRuntime module
#rb @thomas.sarkanen
#jira UE-166634
#preflight 63591a0a764df4711e65c76e

[CL 22776099 by jaime cifuentes in ue5-main branch]
2022-10-26 07:34:18 -04:00
Nicholas Frechette
a182dbd867 Wrap deprecated properties with WITH_EDITORONLY_DATA to avoid runtime waste
#jira UE-49197
#rb Thomas.Sarkanen, Helge.Mathee
#preflight 6358002a66733d70593afa3f

[CL 22751839 by Nicholas Frechette in ue5-main branch]
2022-10-25 11:42:04 -04:00
chris caulfield
93fa1517dd Chaos - move RBAN world object collection to game thread
#rb benn.gallagher
#jira UE-158098, UE-156294
#preflight 633b609f3629a1a4f938bc1d

[CL 22327050 by chris caulfield in ue5-main branch]
2022-10-04 01:24:03 -04:00
marc audy
311f7464bf Updated ../Engine/Source/Runtime/... to inline gen.cpp files
Before:
3648 unity files
Total CPU Time: 47886.140625 s
Total time in Parallel executor: 498.81 seconds

After:
3548 unity files
Total CPU Time: 46643.828125 s
Total time in Parallel executor: 486.06 seconds

#jira
#preflight

[CL 22173263 by marc audy in ue5-main branch]
2022-09-24 13:57:58 -04:00
Chris Caulfield
fa6ad88864 Chaos - Constraint Solver Refactor
- Constraint Solver now solves IslandGroups using sets of dependent tasks
- Gather and Scatter use all available workers regardless of number of Islands
- Significantly better multi-core performance in large-island tests
- Added IslandGroupManager
- Added ConstraintGroupSolver (replaced SolverDatas)
- Added ConstraintContainerSolver (replaced ConstraintRule)
- Removed a lot of dead code

#rb cedric.caillaud, vincent.robert, benn.gallagher, jaco.vandyk
#jira none
#okforgitbug public
#preflight 630450540061f895d002cf5d
#preflight 6307c7e71670d55ad5cfd33e

[CL 21570706 by Chris Caulfield in ue5-main branch]
2022-08-25 15:42:32 -04:00
kriss gossart
0422ca7705 Skeletal Mesh - Replace the newly created GetSkeletalMesh function by GetSkeletalMeshAsset so it matches the setter SetSkeletalMeshAsset function (which itself couldn't be named SetSkeletalMesh due to the function already existing and doing something else).
#rb Josie.Yang
#preflight 62fa2afeae3edb54c979492e
#jira none

[CL 21385959 by kriss gossart in ue5-main branch]
2022-08-15 09:26:50 -04:00
chris caulfield
0c36c1d8e1 RBAN - change warning to a log to prevent new CIS breaks
#rb trivial

#ROBOMERGE-AUTHOR: chris.caulfield
#ROBOMERGE-SOURCE: CL 21202017 via CL 21202104 via CL 21202177
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21204039 by chris caulfield in ue5-main branch]
2022-07-21 13:31:01 -04:00
chris caulfield
8a874eebd3 RBAN - add warning when using a bone-space simulation with an invalid base bone
#rb none
#preflight 62d869fac0180d8071e4f5b1

#ROBOMERGE-AUTHOR: chris.caulfield
#ROBOMERGE-SOURCE: CL 21197201 via CL 21197206 via CL 21197208
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21197505 by chris caulfield in ue5-main branch]
2022-07-20 23:51:33 -04:00
jaime cifuentes
7f89f01ffa AnimNode_Rigidbody MasterAlpha rename. Part of UE-158645
#jira UE-158645
#review @thomas.sarkanen @benn.gallagher
#preflight 62cc4bcabc36fc75cc5d6d72

[CL 21054114 by jaime cifuentes in ue5-main branch]
2022-07-12 05:30:52 -04:00
chris caulfield
3f19a5e6ee Chaos
- add PhysicsAsset option to select linear or non-linear joint solver for RBAN (old assets default to non-linear, new to linear)
- optimize joint SLerp drive (asin approximation and quaternion to axes)
- add unit tests for AsinEst

#jira UE-157785
#rb cedric.caillaud, michael.forot
#preflight 62bcadcfb447118888a10aaf

#ROBOMERGE-OWNER: chris.caulfield
#ROBOMERGE-AUTHOR: chris.caulfield
#ROBOMERGE-SOURCE: CL 20881652 via CL 20881788 via CL 20882418
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20885785 by chris caulfield in ue5-main branch]
2022-06-29 19:01:50 -04:00
ben woodhouse
c790d47e04 Fix RBAN memory stomp due to out of bounds array access
#ROBOMERGE-AUTHOR: ben.woodhouse
#ROBOMERGE-SOURCE: CL 20829351 via CL 20829358 via CL 20829359 via CL 20829368 via CL 20829372 via CL 20829373
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20830138 by ben woodhouse in ue5-main branch]
2022-06-27 09:50:43 -04:00
Josie Yang
6b15506e58 Replace direct access to SkeletalMesh object from USkinnedMeshComponent with GetSkeletalMesh function
#rb kriss.gossart
#preflight 62aafc9ada0af39a4783930a

[CL 20686007 by Josie Yang in ue5-main branch]
2022-06-16 09:14:04 -04:00
Benn Gallagher
8757cb3641 Physics interface cleanup.
* Removed deprecated or dead code paths
* Simplified build system setup for physics support
* Deprecated build system flags and unsupported macros

#jira none
#rb Chris.Caulfield, Kriss.Gossart
#preflight 62963ec0fe779f23c8ea0c5e

[CL 20450744 by Benn Gallagher in ue5-main branch]
2022-06-01 06:59:18 -04:00
thomas sarkanen
58c99c971c Fixed various issues with the revised re-instancing code path for anim BPs
Fixed RBAN not re-initialzing correctly on re-instancing - added a special case to reinit the simulation.
Made reinstancing handler virtual so users can add their own fallbacks in the future.
Fixed dynamic AnimGraphLayers not (un)linking correctly after live-recompile, as it was trying to link against the old (replaced) animation instance

#rb Jurre.deBaare
#preflight 628cf1dec97e4beea3a2f541

#ROBOMERGE-AUTHOR: thomas.sarkanen
#ROBOMERGE-SOURCE: CL 20349883 via CL 20349893 via CL 20349912
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20352477 by thomas sarkanen in ue5-main branch]
2022-05-24 14:26:39 -04:00