Added a system to cache some data that can be used when recompiling the filters for the incremental data updates.
For now this only used by for the asset data source internal path compilation of the asset views.
In my test on a bad scenario this yielded a reduction 98% of the time it take to call UContentBrowserAssetDataSource::CreateAssetFilter when the cache is used.
Before the optimization the reference call took 26.3 ms
After the optimization the reference call took 0.3725 ms
Also this change fix an issue with my last change interacting badly with the alias data source by not using its customization of the package paths hierarchy.
#preflight 645a92f42d27fa25b3069003
#jira UE-183276
#rb Rex.Hill
[CL 25396753 by julien stjean in ue5-main branch]
For a large project with a lot paths with a recursive search on all the folder the change reduced time it took to create the filter by ~86%.
Before the change a function call took 191.3 ms
After the change the same function call took 25.8 ms
#jira UE-183275
#preflight 64499a7709453df548d462f5
#rb Rex.Hill, Robert.Millar
[CL 25283516 by julien stjean in ue5-main branch]
* Plugins that only contain cooked content (and have no C++ modules) no longer show their "Content" suffix.
* Folders that only contain private cooked content are no longer visible in the asset or path views.
#preflight 642f2e3cb306e98c632f0195
#rb Jason.Stasik, Aditya.RaviChandran
[CL 24994922 by jamie dale in ue5-main branch]
#rb Julien.StJean, Matt.Peters
#jira UE-177133
#preflight 64072b19ba12ba64167e20e6
- In the last year we have started to make changes to the package format to allow data to be stored in the same file, but not actually inside of the package itself (See FPackageTrailer) and we might consider moving some other data blobs there in the future. This change has meant that there are code paths that can change things with the package file, that don't actually call save package, such as the process that virtualizes assets and can leave incorrect, stale data in the content browser tool tip.
-- This means when a user virtualizes an asset, the tooltip might indicate that it has not been virtualized and the size of the file on disk has not been changed until they browser to a different folder and browse back to refresh. This has caused people to believe that the virtualization operation has failed.
- This change hooks up UContentBrowserAssetDataSource to trigger a EContentBrowserItemUpdateType::Modified event when ever the package file changes on disk.
- During package save this could trigger multiple EContentBrowserItemUpdateType::Modified events for the same package (one from saving and one from the file being modified) but it looks like duplicate events already occur (if the packages are checked out as part of the save, this will introduce another EContentBrowserItemUpdateType::Modified event). There is a TODO in the code that suggests we might want to spend time removing duplicates events before broadcasting the delegate but when profiling I found that the overhead is quite low. In one test, saving 20 packages cost 4ms for the events triggered by the save and an additional 4ms for the events triggered by the file changing on disk. With the margins being so low it still doesn't look like a problem that is worth spending time on, however I did add a TRACE_CPUPROFILER_EVENT_SCOPE to the broadcasting of the delegate (UContentBrowserDataSubsystem::ItemDataUpdatedDelegate) so if it does become a problem in the future it will be easier to track down.
[CL 24556355 by paul chipchase in ue5-main branch]
These are currently used to display the asset that are hidden by a backend class permission system.
They can also be restricted to some path only if desired.
Note: We will do a UX pass for the unsupported items after this is submitted and later we will also add some support for the unsupported asset to the alias data source.
#preflight 63dc23a7175a9839ac4cf474
#rb Jason.Stasik
[CL 24007061 by julien stjean in ue5-main branch]
#rb Stanley.Hayes
#rb Jamie.Dale
#rb Jason.Stasik
#rb Yiliang.Siew
#preflight 635205e49e14ee3c7969c9bf
Iteration on Jason Stasiks CL 17314610. This is a minimal version of CL 17314610 which adds a 'view' method to AssetTypeActions which is now attempted whenever an activated item's 'edit' attempt fails.
The matching CL for the restricted FAssetTypeActions_VerseClass changes is 22472079.
[CL 22823595 by jared cotton in ue5-main branch]
[FYI] jared.cotton
Original CL Desc
-----------------------------------------------------------------
Addition of 'view' method to AssetTypeActions
#rb Stanley.Hayes
#rb Jamie.Dale
#rb Jason.Stasik
#rb Yiliang.Siew
#preflight 635205e49e14ee3c7969c9bf
Iteration on Jason Stasiks CL 17314610. This is a minimal version of CL 17314610 which adds a 'view' method to AssetTypeActions which is now attempted whenever an activated item's 'edit' attempt fails.
The matching CL for the restricted FAssetTypeActions_VerseClass changes is 22472079.
[CL 22803476 by bob tellez in ue5-main branch]
#rb Stanley.Hayes
#rb Jamie.Dale
#rb Jason.Stasik
#rb Yiliang.Siew
#preflight 635205e49e14ee3c7969c9bf
Iteration on Jason Stasiks CL 17314610. This is a minimal version of CL 17314610 which adds a 'view' method to AssetTypeActions which is now attempted whenever an activated item's 'edit' attempt fails.
The matching CL for the restricted FAssetTypeActions_VerseClass changes is 22472079.
[CL 22803451 by jared cotton in ue5-main branch]
Fixups for editor support classes for content browser code.
#jira UE-161932
#rb jason.stasik,jamie.dale
#preflight 631bd2a0d31788ea3ac03570
[CL 21935588 by robert millar in ue5-main branch]
Headers are updated to contain any missing #includes needed to compile and #includes are sorted. Nothing is removed.
#ushell-cherrypick of 21065253 by bryan.sefcik
#jira
#preflight 62d5b3e91062f2e63014598e
#ROBOMERGE-AUTHOR: bryan.sefcik
#ROBOMERGE-SOURCE: CL 21152630 via CL 21156388 via CL 21157044
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)
[CL 21181817 by bryan sefcik in ue5-main branch]
Allow browsing to aliases if source asset is not visible
Allow aliases in collections
#rb dave.belanger,jamie.dale
#preflight 62d0b1ad8e4b379590da3397
#ROBOMERGE-AUTHOR: jason.stasik
#ROBOMERGE-SOURCE: CL 21115320 via CL 21115363 via CL 21115394 via CL 21115412 via CL 21115431
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)
[CL 21142427 by jason stasik in ue5-main branch]
