Commit Graph

1906 Commits

Author SHA1 Message Date
robert manuszewski
4c9c6db9cb Garbage Collector History: GC can now store information about traversed references which can then later be searched through with FReferenceChainSearch (obj refs)
#preflight 61f966f580608c7029bb14e1
#rb Steve.Robb

#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 18810462 in //UE5/Release-5.0/... via CL 18810472 via CL 18822694
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18823613 by robert manuszewski in ue5-main branch]
2022-02-02 05:53:42 -05:00
robert manuszewski
4a814e3a44 Merging changes from another stream:
FReferenceChainSearch will no longer store raw pointers to UObjects when constructing reference chains and instead will only preserve basic information about UObjects separate from UObjects themselves

Making FUObjectArray::ObjectToObjectItem accept a pointer to a const object

Removing redundant code from FindStaleClusters and fixing indents

#jira SOL-1885
#rb Steve.Robb
#preflight 61f959458b4112f7cc9a88c0

#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 18809578 in //UE5/Release-5.0/... via CL 18809596 via CL 18822554
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18823575 by robert manuszewski in ue5-main branch]
2022-02-02 05:51:34 -05:00
dave jones2
c8574d3b74 Merging //UE5/Dev-LargeWorldCoordinates [at] 18802167 to //UE5/Release-5.0
Blueprint real number support.

This change deprecates the use the of "float" and "double" types in Blueprints in favor of a new "real". By default, "real" is back by a double precision floating point number. However, it can be single precision if the number is a native float property or function parameter. This distinction won't be visible to the Blueprint user: in both instances, they'll be represented by "real" pin types. During deserialization, we'll automatically convert Blueprint pin types to use real/doubles, unless they're used to represent native code (including delegate signatures).

One consequence of this change is that we need to perform implicit casts between single and double precision real numbers. During Blueprint compilation, the compiler will detect points in the graph for when either a widening or narrowing conversion needs to occur. Subsequently, the script bytecode will contain a new cast instruction that performs the conversion. This also works on container types, but each entry in the container will have to be converted. This can introduce unwanted overhead for large containers that are frequently passed between Blueprint and native code.

The scope of this change affects Blueprints used by Gameplay, Animation, Control Rig, and UMG.

#rb marc.audy (serialization changes)
#jira UE-116484
#preflight 61f8bdd5a2514ba12ff7bdfc

#ROBOMERGE-AUTHOR: dave.jones2
#ROBOMERGE-SOURCE: CL 18809077 in //UE5/Release-5.0/... via CL 18809455 via CL 18822548
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18823569 by dave jones2 in ue5-main branch]
2022-02-02 05:50:50 -05:00
paul chipchase
05d81ee7f3 EditorBulkData and the virtualization system now use FIoHash directly and FPayloadId is removed
#rb Per.Larsson, Devin.Doucette
#jira UE-133497
#rnx
#preflight 61f835491c5ac5523462810a

- A lot of files have been touched but most of this is changing FPayload::IsValid to !FIoHash::IsZero, the main changes are in EditorBulkData/EditorBulkDataTests
- The only difference between FPayloadId and FIoHash is that the former considered the hash of an invalid or empty buffer to be 'invalid' too where as FIoHash would return a valid hash
-- To keep behaviour the same, we only hash payloads in EditorBulkData using a utility method ::HashBuffer which will not hash empty or invalid payloads and return a default FIoHash instead.
-- Unit tests have been extended to prove that the behaviour has not changed.

#ROBOMERGE-AUTHOR: paul.chipchase
#ROBOMERGE-SOURCE: CL 18806362 in //UE5/Release-5.0/... via CL 18808527 via CL 18821790
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18822154 by paul chipchase in ue5-main branch]
2022-02-02 02:21:24 -05:00
robert manuszewski
97b5e82c0b Deprecating EInternalObjectFlags::PendingKill. Making sure iterators use the appropriate flags based on the current state of PendingKill being enabled or not.
#preflight 61f8f33d537702981c352c7a
#rb Steve.Robb

#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 18806353 in //UE5/Release-5.0/... via CL 18808526 via CL 18821789
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18822151 by robert manuszewski in ue5-main branch]
2022-02-02 02:21:12 -05:00
marc audy
3f37f75a75 Avoid unnecessary lookup of Archetype
General cleanup of component langugage where actually it is more generally for all subobjects
Fix comments and add default parameters
#rnx
#preflight 61f88a94f657e25a59067fb4

#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 18803287 in //UE5/Release-5.0/... via CL 18803296 via CL 18821587
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18821670 by marc audy in ue5-main branch]
2022-02-02 01:49:54 -05:00
Marc Audy
e68ad1cf27 Fix IsDefaultObject to not return true for CDOs
Cleaned up out of date comment about function implementation
#rb Ben.Zeigler
#preflight 61f88a9e68795b2f45916cae

[CL 18803336 by Marc Audy in ue5-main branch]
2022-01-31 20:35:09 -05:00
andrew davidson
a687bd02ed Merge //UE5/Dev-LWCRendering[at]18755967
LWC: Serialize LWC double types as double. Enable double bulk serialization for all bulk-serializable-as-float LWC types.
#lockdown marc.audy
#rb marc.audy
#preflight 61f83517114ec25fe0ad5f15

#ROBOMERGE-AUTHOR: andrew.davidson
#ROBOMERGE-SOURCE: CL 18795077 in //UE5/Release-5.0/... via CL 18795472 via CL 18797572
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18798048 by andrew davidson in ue5-main branch]
2022-01-31 16:44:37 -05:00
Andrew Davidson
4a3e582384 LWC: Remove UE_LARGE_WORLD_COORDINATES_DISABLED toggle
#rb stephen.holmes
[FYI] zak.middleton
#preflight 61f7d18b114ec25fe09648d6

#ROBOMERGE-OWNER: Andrew.Davidson
#ROBOMERGE-AUTHOR: andrew.davidson
#ROBOMERGE-SOURCE: CL 18788533 in //UE5/Release-5.0/... via CL 18788583 via CL 18788850
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)
#ROBOMERGE-CONFLICT from-shelf
#preflight 61f7eb7a114ec25fe0990f8c

[CL 18789644 by Andrew Davidson in ue5-main branch]
2022-01-31 10:10:51 -05:00
steve robb
2537bf8094 Hide UClass::Implements to prevent accidental misuse.
#jira UE-140075
#rb devin.doucette
#preflight 61f40096f628752a568a8493

#ROBOMERGE-AUTHOR: steve.robb
#ROBOMERGE-SOURCE: CL 18787643 via CL 18787651 via CL 18787653 via CL 18787882 via CL 18787955
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18787962 by steve robb in ue5-main branch]
2022-01-31 06:07:14 -05:00
marc audy
0fd821baa5 Make ClassGeneratedBy WITH_EDITORONLY_DATA as it will always be null in cooked builds
#rb Michael.Noland
#preflight 61f441427a7f0d39ddf153cf
#jira

#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 18778942 via CL 18778966 via CL 18778988 via CL 18779795 via CL 18780212
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18780217 by marc audy in ue5-main branch]
2022-01-28 18:19:09 -05:00
phillip kavan
340513789d Ensure that the FArchiveReplaceObjectAndStructPropertyRef ctor invokes the default serialization path with the right vtable.
#jira MH-3535, MH-4936
#rb Robert.Manuszewski
#preflight 61f43da2241aeec8655ac928

#ROBOMERGE-AUTHOR: phillip.kavan
#ROBOMERGE-SOURCE: CL 18777281 in //UE5/Release-5.0/... via CL 18778405 via CL 18778932
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18778969 by phillip kavan in ue5-main branch]
2022-01-28 16:45:51 -05:00
paul chipchase
0ccefd14bc Add a new bitfield of flags to the payload entries in FPackageTrailer.
#rb PJ.Kack
#rnx
#preflight 61f439e2801201ab389237ef

- This will allow us to store per payload info in the future such as disabling virtualization for specific payloads.
- Currently there are no flags.
- Older trailer formats will update automatically.

#ROBOMERGE-AUTHOR: paul.chipchase
#ROBOMERGE-SOURCE: CL 18776027 in //UE5/Release-5.0/... via CL 18777349 via CL 18777591
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18777602 by paul chipchase in ue5-main branch]
2022-01-28 15:26:33 -05:00
jose villarroel
9746cc9977 [Backout] - CL18751910
[FYI] Thomas.Sarkanen
Original CL Desc
-----------------------------------------------------------------
Fix asserts/warnings around child anim BPs

Ensures that cleaned-up sparse class data structs are moved out of the package they are in, thus not requiring a GC step to ensure that batch compilation works correctly.
Without this, it is possible for the NewObject call in FAnimBlueprintCompilerContext::RecreateSparseClassData to attempt to re-use (as it has a fixed name) the currently-existing (but not referenced) object rather than creating a new one.
This also reverts some other changes that were made to try to address related issues.

#jira FORT-444463
#rb Phillip.Kavan
#preflight 61f18be3f8088a3d298e6419
#p4v-cherrypick 18740288

#ROBOMERGE-AUTHOR: jose.villarroel
#ROBOMERGE-SOURCE: CL 18773105 in //UE5/Release-5.0/... via CL 18773189 via CL 18773693
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18773704 by jose villarroel in ue5-main branch]
2022-01-28 12:39:05 -05:00
carlmagnus nordin
73a67c95d9 Renamed EPackageLocationFilter enums from Cooked/Uncooked to IoDispatcher/FileSystem
Cleaned up duplicated logic between DoesPackageExist and DoesPackageExistEx
#rnx
#preflight 61f3b9f2801201ab387e6e50
#rb per.larsson

#ROBOMERGE-AUTHOR: carlmagnus.nordin
#ROBOMERGE-SOURCE: CL 18770321 in //UE5/Release-5.0/... via CL 18770330 via CL 18770438
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18770443 by carlmagnus nordin in ue5-main branch]
2022-01-28 08:48:13 -05:00
carlmagnus nordin
a201cd8e12 Fixed up uses of FIoDispatcher::IsInitialized() so that they work correctly also when there's a mix of cooked packages in iostore and uncooked packages on disk
FIoDispatcher::IsInitialized() will now return true if it exists (which is almost always)
Renamed FArchive::IsUsingEventDrivenLoader() to IsLoadingFromCookedPackage and based it on the PKG_Cooked flag
#rnx
#rb pj.kack
#preflight 61f3ab6f74510448a6740570

#ROBOMERGE-AUTHOR: carlmagnus.nordin
#ROBOMERGE-SOURCE: CL 18769198 in //UE5/Release-5.0/... via CL 18769204 via CL 18769272
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18769277 by carlmagnus nordin in ue5-main branch]
2022-01-28 04:29:58 -05:00
jamie dale
e8f33997f3 Deleted FStructVariant in favor of using FInstancedStruct
#jira
#preflight 61f1ca11fd5285142b4dbc64
#rb Rex.Hill

#ROBOMERGE-OWNER: jamie.dale
#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 18747759 via CL 18747878 via CL 18747892 via CL 18747928 via CL 18748218 via CL 18748276
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18748289 by jamie dale in ue5-main branch]
2022-01-26 19:50:32 -05:00
francis hurteau
cc6a90638b Fix CIS warning about unbalanced pragma disable deprecation
#rb trivial
#jira none
#preflight trivial

#ROBOMERGE-AUTHOR: francis.hurteau
#ROBOMERGE-SOURCE: CL 18747375 in //UE5/Release-5.0/... via CL 18747383 via CL 18747623
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18747628 by francis hurteau in ue5-main branch]
2022-01-26 18:44:51 -05:00
thomas sarkanen
8f861ede89 Fix asserts/warnings around child anim BPs
Ensures that cleaned-up sparse class data structs are moved out of the package they are in, thus not requiring a GC step to ensure that batch compilation works correctly.
Without this, it is possible for the NewObject call in FAnimBlueprintCompilerContext::RecreateSparseClassData to attempt to re-use (as it has a fixed name) the currently-existing (but not referenced) object rather than creating a new one.
This also reverts some other changes that were made to try to address related issues.

#rb Phillip.Kavan
#preflight 61f18be3f8088a3d298e6419

#ROBOMERGE-AUTHOR: thomas.sarkanen
#ROBOMERGE-SOURCE: CL 18740288 via CL 18740350 via CL 18740373 via CL 18742029 via CL 18742887
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18743237 by thomas sarkanen in ue5-main branch]
2022-01-26 15:37:52 -05:00
francis hurteau
5714cca54f Reduced runtime UPackage size from 176b to 144b or 120b when stripping deprecated properties
This should saves around ~1.5 Mb to ~3 Mb at runtime with ~50000 packages

Added a new core define UE_STRIP_DEPRECATED_PROPERTIES that could be used to wrap deprecated properties and strip them to regain memory when a projects becomes compliant. this can be set in the project target file
Deprecated most public properties from UPackage and created accessors for them

#rb PJ.Kack
#jira UE-138957
#preflight 61f17a6f7266f4e79bd62601

#ROBOMERGE-AUTHOR: francis.hurteau
#ROBOMERGE-SOURCE: CL 18738937 in //UE5/Release-5.0/... via CL 18739524 via CL 18741373
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18742135 by francis hurteau in ue5-main branch]
2022-01-26 15:00:04 -05:00
robb surridge
04588085d2 Fix broken links to documentation in header and source files.
#jira none
#rb trivial
#preflight 61f0445dff453b751b38959f

#ROBOMERGE-AUTHOR: robb.surridge
#ROBOMERGE-SOURCE: CL 18726086 in //UE5/Release-5.0/... via CL 18726097 via CL 18726340
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18726365 by robb surridge in ue5-main branch]
2022-01-25 14:22:58 -05:00
paul chipchase
4faa718790 Saving a package containing virtualized payloads will no longer force the package to 'rehydrate' and download the payloads to store locally.
#rb PJ.Kack
#jira UE-136131
#rnx
#preflight 61eacb3d445cebac10c3d046

- A cvar named "Serialization.RehydrateOnSave" now controls if we rehydrate a package on save, defaulting to false.
-- At the very least we will need to be able to turn this to true to run any "rehydrate the project" UAT command in the future.
- The package trailer no longer stores a valid compressed size for a payload. In the best case scenario we only know the compressed size of the payload when it was still stored on locally on disk. Each virtualization backend is free to take the payload and recompress it anyway it sees fit etc.
- When duplicate payloads entries are added to a FPackageTrailerBuilder we now keep the original payload entry and discard the duplicate rather than replacing the existing entry with the duplicate, which was the original intent.

#ROBOMERGE-AUTHOR: paul.chipchase
#ROBOMERGE-SOURCE: CL 18721599 in //UE5/Release-5.0/... via CL 18721602 via CL 18721661
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18721674 by paul chipchase in ue5-main branch]
2022-01-25 08:05:16 -05:00
marc audy
6553e6cd0a Remove as much C++ deprecation as possible up to 4.17 (along with a few scattered removals from beyond)
#preflight 61eefc77ba69a4fdb220bf23

#ROBOMERGE-AUTHOR: marc.audy
#ROBOMERGE-SOURCE: CL 18712765 in //UE5/Release-5.0/... via CL 18712784 via CL 18713147
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18713191 by marc audy in ue5-main branch]
2022-01-24 15:07:48 -05:00
paul chipchase
77c12cf814 Virtualized bulkdata is now know as EditorBulkData
#rb PJ.Kack
#rnx
#jira UE-139708
#preflight 61eaaedfc92021e535b6d1e0

- The goal is to show a clear separation between the bulkdata object and the virtualization system.
- NOTE that all of these classes were added during 5.0 development so we are just renaming and moving them, no deprecation paths.
- Renamed FVirtualizedUntypedBulkData to FEditorBulkData
-- Also removed the derived templated types, they were never actually used
- Renamed FVirtualizedBulkDataReader to FEditorBulkDataReader
- Renamed FVirtualizedBulkDataWriter to FEditorBulkDataWriter
- Moved the renamed classes to the UE::Serialization namespace from UE::Virtualization
- Renamed the files of the renamed classes where required.
- Replaced use of LogVirtualization with LogSerialization.
- Renamed defines prefixed with VBD_* to UE_ and make sure they are undefed by the end of the cpp
- Edited unit tests to show up under "System.CoreUObject.Serialization.EditorBulkData.*"

#ROBOMERGE-AUTHOR: paul.chipchase
#ROBOMERGE-SOURCE: CL 18688778 in //UE5/Release-5.0/... via CL 18688787 via CL 18688810
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18688823 by paul chipchase in ue5-main branch]
2022-01-21 09:18:53 -05:00
scott nelson
3ed3213fdd [VK] Add new PKG_ExternallyReferenceable flag to mark Public Assets
#preflight 61e894b663639eb6f60601c1
#rb Francis.Hurteau

#ROBOMERGE-AUTHOR: scott.nelson
#ROBOMERGE-SOURCE: CL 18669651 via CL 18673592 via CL 18673638 via CL 18673668 via CL 18674347 via CL 18674435 via CL 18674504
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v902-18672795)

[CL 18679711 by scott nelson in ue5-main branch]
2022-01-20 15:22:02 -05:00