Commit Graph

177 Commits

Author SHA1 Message Date
rob gay
6887608d07 - Version MetaSound asset graph name FText being generated from file name & copied to MetaSound asset.
- Add missing user-defined fields to MetaSound graph options (ex. IsDeprecated, Keywords, etc.) and force update on transient style changeID (TODO: Probably would make more sense for Metadata FText to live on style struct and share that transient ChangeID, so that non-runtime changes to FText metadata wouldn't bump the change ID)
[CODEREVIEW] helen.yang
#jira UE-137696
#rnx
#preflight 61f870c0a6632a34f35e5e3c

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18805501 in //UE5/Release-5.0/... via CL 18807964 via CL 18821755
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18822116 by rob gay in ue5-main branch]
2022-02-02 02:19:16 -05:00
rob gay
820b8558a0 Fix for ensure hit when calling CreateInternalWidgets prior to synchronizing graph for some MetaSounds assets (subsequent CL had deeper fix that avoided calling refresh on nodes prematurally, so the incorrect expectation that widgets had to be generated prior to synchronization no longer holds). This is a partial revert from previous CL.
#rb trivial
#jira none
#rnx
#preflight 61f84dab41414fb013d9fdcb

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18797129 in //UE5/Release-5.0/... via CL 18797912 via CL 18799114
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18799233 by rob gay in ue5-main branch]
2022-01-31 17:23:45 -05:00
rob gay
5452cd8168 MetaSound Composition Fixes
- Removed need for marking ed graph nodes for refresh in most places in favor of using frontend class metadata/interface guids to signify an ed node requiring a refresh
- Update CanAutoUpdate to always provide interface changes if the metadata/interface guids change and return true, even if the runtime properties do not report
 changes, so the editor can adequately update referenced classes that have only asthetic updates
#rb helen.yang
#jira UE-136242
#jira UE-137696
#rnx
#preflight 61f8343168795b2f45820e03

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18794812 in //UE5/Release-5.0/... via CL 18795366 via CL 18796340
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18796687 by rob gay in ue5-main branch]
2022-01-31 15:53:54 -05:00
helen yang
ecb71d0c8a Retain all connections when control + click dragging multiple connections to another MetaSound node
#jira UE-116874
#rb rob.gay
#preflight 61f332ca6b5aea38e59db068

#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 18794786 in //UE5/Release-5.0/... via CL 18795351 via CL 18796329
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18796678 by helen yang in ue5-main branch]
2022-01-31 15:53:33 -05:00
rob gay
f71016bbac Fix for deleting copied inputs causing them to sneak back into graph
#rb trivial
#jira UE-137490
[FYI] sondra.moyls
#rnx
#preflight skip

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18792566 in //UE5/Release-5.0/... via CL 18792616 via CL 18793509
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545)

[CL 18793833 by rob gay in ue5-main branch]
2022-01-31 13:57:52 -05:00
phil popp
3e2e304b2d Fix for invalid proxy generate classes showing up on metasound node drop downs.
#jira UE-135719
#rb trivial
#preflight skip

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 18774345 in //UE5/Release-5.0/... via CL 18774355 via CL 18775372
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18775443 by phil popp in ue5-main branch]
2022-01-28 13:50:28 -05:00
rob gay
010d642a75 Fix for sparse ensure when unregistering due to AssetClassKeys sometimes being out-of-date on the document. Minor rename to clarify a graph has been modified vs. its dirty state (which may be true regardless of function's execution)
#rb trivial
[FYI] phil.popp
#jira none
#rnx
#preflight 61f2d2b7801201ab38616410

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18755089 in //UE5/Release-5.0/... via CL 18755102 via CL 18757582
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18758549 by rob gay in ue5-main branch]
2022-01-27 14:36:57 -05:00
rob gay
1e6ee23838 - Fix interface vertex metadata still serializing text during presave.
- Fix node tooltips caching old strings & improperly displaying them if a node's tooltips are modified but the node is not versioned

Minor Clean-up:
- Move interface registry generation logic to static function to mirror metadata's analogous call
- Remove misleading, unused GetPinTooltip cruft from SMetasoundGraphPin

[CODEREVIEW] phil.popp
#jira none
#rnx
#preflight 61f23629e12e3fcf9b324887

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18750829 in //UE5/Release-5.0/... via CL 18750848 via CL 18750876
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18750878 by rob gay in ue5-main branch]
2022-01-27 01:31:46 -05:00
rob gay
bfa27ae8aa Add notification when MetaSound document has been versioned & mark dirty on editor open if so
#rb trivial
#jira none
#rnx
[FYI] sondra.moyls
#preflight 61f1f6d073238441cb748458

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18748869 in //UE5/Release-5.0/... via CL 18748880 via CL 18748960
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18748971 by rob gay in ue5-main branch]
2022-01-26 20:55:33 -05:00
rob gay
e00c7856fa Move any places where FText is copied to a MetaSound document to transient UProperties that are populated by external registries (i.e. the interface registry & the class registry)
#rb phil.popp
#rnx
#jira none
#preflight 61f1cc37c0033b39f89ee39c

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18746974 in //UE5/Release-5.0/... via CL 18746984 via CL 18747190
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18747199 by rob gay in ue5-main branch]
2022-01-26 18:11:52 -05:00
robb surridge
04588085d2 Fix broken links to documentation in header and source files.
#jira none
#rb trivial
#preflight 61f0445dff453b751b38959f

#ROBOMERGE-AUTHOR: robb.surridge
#ROBOMERGE-SOURCE: CL 18726086 in //UE5/Release-5.0/... via CL 18726097 via CL 18726340
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18726365 by robb surridge in ue5-main branch]
2022-01-25 14:22:58 -05:00
helen yang
a421fe4d4d Fixes for MetaSound rename and delete editor commands
- Change delete command to only use delete key instead of backspace
- Allow rename action on interface menu items
- Fix crash caused by invalid rename request handle

#jira UE-135967
#rb rob.gay
#preflight 61efab0ca5126b4d3e833747

#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 18725047 in //UE5/Release-5.0/... via CL 18725247 via CL 18725393
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18725412 by helen yang in ue5-main branch]
2022-01-25 13:25:11 -05:00
rob gay
193ab59674 Fix bit from a CL not meant to go in with last fix-up
#rb trivial
#jira none
#rnx
#preflight buildfix

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18716589 in //UE5/Release-5.0/... via CL 18716614 via CL 18716760
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18717203 by rob gay in ue5-main branch]
2022-01-24 19:04:57 -05:00
rob gay
a7c5ad05ed Fix missed hard-coded data type names in a couple functions
#rb trivial
#rnx
#jira none
#preflight skip

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18716287 in //UE5/Release-5.0/... via CL 18716302 via CL 18716735
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18717188 by rob gay in ue5-main branch]
2022-01-24 19:04:21 -05:00
rob gay
c67bb7d0a4 Clean-up upgrade note logic (do not clear in validation step and clear style field when presaving via UMetasoundEditorGraph as doing so in validation marks graph as dirty post save when not desired)
#rb helen.yang
#rnx
[FYI] sondra.moyls
#jira none
#preflight 61ef2e98ca3de856bcdea81b

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18716201 in //UE5/Release-5.0/... via CL 18716213 via CL 18716355
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18717179 by rob gay in ue5-main branch]
2022-01-24 19:04:00 -05:00
rob gay
55d5407a44 Rebuild keys when searching for open MetaSounds to re-register (keys could be out-of-date and cause some MetaSounds to not get re-registered when expected. Can manifests as composed graphs being out-of-date in editor and not always updating).
#rb trivial
#jira none
#rnx
[FYI] sondra.moyls
#preflight 61eb158a731e3b40889d239b

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18695182 in //UE5/Release-5.0/... via CL 18695202 via CL 18695239
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18695276 by rob gay in ue5-main branch]
2022-01-21 15:40:14 -05:00
rob gay
fe1d4b93a4 Don't serialize cached dependency data on MetaSound graphs to avoid text desync or out-of-date data when autoupdate is disabled for a given asset.
TODO: Split out FMetasoundFrontendClass to class & dependency struct, where dependency is only the information required to find an item in the registry and potentially a couple non-localized breadcrumbs
#rb phil.popp
#jira none
#rnx
#preflight 61e8f894276892ce10892644
#preflight 61e9f7f91739bb8724e071ec

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18684546 in //UE5/Release-5.0/... via CL 18684559 via CL 18684566
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v902-18672795)

[CL 18684575 by rob gay in ue5-main branch]
2022-01-20 19:19:55 -05:00
helen yang
5a72e56aa5 Prevent creating reference loops when dragging and dropping MetaSounds
- Also show appropriate messaging and cancel transaction if invalid

#jira UE-137117
#jira UE-139205

#rb rob.gay
#preflight 61e75133f517d721f97f53d8

#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 18677056 in //UE5/Release-5.0/... via CL 18677063 via CL 18677069
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v902-18672795)

[CL 18680203 by helen yang in ue5-main branch]
2022-01-20 15:40:20 -05:00
rob gay
472ba41220 Fix bug with document dependency synchronization by refactoring Document FrontendClass Synchronization to be more clear by renaming as RemoveUnreferencedDependencies & adding option to FindOrAddClass to synchronize if class is found already with registry
#rb phil.popp
#rnx
#jira UE-137696
#preflight 61e8a561da16597a1f4967c3

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18669591 in //UE5/Release-5.0/... via CL 18669597 via CL 18669618
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v901-18665521)

[CL 18669641 by rob gay in ue5-main branch]
2022-01-19 19:32:01 -05:00
rob gay
214a8e1e5f Mark all open nodes referenced by an asset as needing to be refreshed when renaming an asset
#jira UE-137696
#rb helen.yang
#rnx
#preflight 61e73a177f0c4b5aad71dbb4

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18649056 in //UE5/Release-5.0/... via CL 18649470 via CL 18649776
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v900-18638592)

[CL 18650046 by rob gay in ue5-main branch]
2022-01-18 17:48:25 -05:00
helen yang
df6218aabf Fix various MetaSound Input Widget and Default Clamp issues
- added option for volume slider to output linear (0-1) value while displaying dB value
- edge case handling for volume and frequency ranges causing widgets to get stuck
- fix functionality and details panel for clamp and other input float properties
- don't show widgets or widget options on readonly graphs

#jira UE-135525
#jira UE-127715
#jira UE-135856
#jira UE-135866
#jira UE-137488

#rb rob.gay
#preflight 61e0acce250b9537f783ed35

#ROBOMERGE-AUTHOR: helen.yang
#ROBOMERGE-SOURCE: CL 18620012 in //UE5/Release-5.0/... via CL 18620328 via CL 18620770
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v899-18417669)

[CL 18621051 by helen yang in ue5-main branch]
2022-01-14 14:01:09 -05:00
phil popp
cc3974e78c Cleanup metasound deprecation wording in code.
Add visual warning for deprecated metasound nodes.
#rb Rob.Gay
#jira UE-137119
#preflight 61e04af4797757aace801bf4

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 18597781 in //UE5/Release-5.0/... via CL 18597791 via CL 18597807
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v899-18417669)

[CL 18597823 by phil popp in ue5-main branch]
2022-01-13 11:36:48 -05:00
phil popp
07cf8fc40c Fix for ensure when adding variable set or get node when dragged from pin.
#jira UE-135952
#rb Rob.Gay, Helen.Yang
#preflight 61ddce0cce7fe7aeff6b621f

#ROBOMERGE-AUTHOR: phil.popp
#ROBOMERGE-SOURCE: CL 18574927 in //UE5/Release-5.0/... via CL 18574938
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18574950 by phil popp in ue5-release-engine-test branch]
2022-01-11 13:56:42 -05:00
rob gay
682aec537b Missing Forward Declarations
#rb trivial
#rnx
#jira UE-138352
#preflight skip

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18526252 in //UE5/Release-5.0/... via CL 18526257
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18526267 by rob gay in ue5-release-engine-test branch]
2022-01-05 18:17:17 -05:00
rob gay
f15e92afd2 Fix static analysis warning
#rb trivial
#jira none
#rnx
#preflight 61d51eb8c73b7e46b2631f0a

#ROBOMERGE-AUTHOR: rob.gay
#ROBOMERGE-SOURCE: CL 18516239 in //UE5/Release-5.0/... via CL 18516248
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18516253 by rob gay in ue5-release-engine-test branch]
2022-01-04 23:44:51 -05:00