Commit Graph

4082 Commits

Author SHA1 Message Date
robert manuszewski
43d504502b Adding automated startup tests to check if class / struct / enum / property metadata contains values with short type names which will help with ANY_PACKAGE removal
(disabled until all ANY_PACKAGE removal changes are in)

#jira UE-99463
#rb Steve.Robb
#preflight 62921cafdb0a62f25c07b693

#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20407210 via CL 20407235 via CL 20407352 via CL 20407427
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20409051 by robert manuszewski in ue5-main branch]
2022-05-28 12:18:53 -04:00
alexis matte
fb5c72dfba Fix crash and deadlock when reloading a package containing skeletalmesh.
- Crash: There was a missing FScopeLock when reading the skeletal mesh imported bulk data this was crashing if we access the bulkdata in two different thread in same time.
- Deadlock: The reload package function is doing a TThreadSfeObjectIterator which deadlock if the inner code create a UObject. The skeletalmesh build can be running in another thread and can create UObject when building the morphtargets. The fix is to move the work outside of the iterator, the iteration now just store the UObject into a TArray and the work is execute in a for loop after the iteration.

#jira UE-154208
#preflight 6290dd464f63120d8e2583db
#rb danny.couture
#rnx
#lockdown jeanmichel.dignard

#ROBOMERGE-AUTHOR: alexis.matte
#ROBOMERGE-SOURCE: CL 20393643 in //UE5/Release-5.0/... via CL 20397182
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20399670 by alexis matte in ue5-main branch]
2022-05-27 17:10:20 -04:00
Jon Nabozny
127848635c Fix cases of engine classes not returning normalized INI paths.
#JIRA None
#review-20392531 @Ben.Marsh @Josh.Adams
#preflight None
#rb Trivial

[CL 20394955 by Jon Nabozny in ue5-main branch]
2022-05-27 12:44:56 -04:00
George Rolfe
1733b33a3f Added TIsUEnumClass trait with UHT integration
#jira none
#rb tim.smith
#rb steve.robb
#preflight 6290bb1c1f0041249bec1f57

[CL 20391947 by George Rolfe in ue5-main branch]
2022-05-27 08:28:20 -04:00
Per Larsson
88f2de0b83 Removed disable optimization pragma and unused header
#rb none
#jira none
#preflight 629094a9f6668c14a3c758a1

[CL 20391200 by Per Larsson in ue5-main branch]
2022-05-27 05:24:20 -04:00
Per Larsson
c30e677d1b Merge BulkData 1&2
#rb Paul.Chipchase, PJ.Kack, CarlMagnus.Nordin
#jira none
#preflight 629085d14f63120d8e170977

###
This change attempts to merge the editor and the runtime version of bulk data, i.e. bulk data one and two.
The major difference between the two is the fact that the editor version supported element vice
serialization via inheritance. This has been complelety removed in the runtime version. In order
to mitigate this divergance a non-virtual base class has been extracted that forms the base
for the untyped and typed versions of bulk data.
The untyped version is only used in editor and will be deprecated. However this is a breaking change,
previously it was possible to inherit from FByteBulkData in editor builds.
Other differences between the two includes:
* IsBulkDataLoaded - returns true for bulk data 1 if an allocation has been made even if the size is zero
* StartStreaming - was removed in bulk data 2 and has been removed
* FlushAsyncLoading - bulk data 2 was busy waiting, now an event is used

All I/O related functionality has been extracted into BulkDataStreaming.cpp and is using
a  FBulkDataChunkId that is either a package path or a package ID.This could potentially
be extended to contain a cache key in development builds to support loading from DDC, i.e derived
data references.

[CL 20391050 by Per Larsson in ue5-main branch]
2022-05-27 04:31:58 -04:00
robert manuszewski
61dfaccf23 Reverting to old object export text format as the new format shouldn't have been introduced before the remaining ANY_PACKAGE removal changed are submitted
#rb trivial
#preflight none

#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20387061 via CL 20387072 via CL 20387075 via CL 20387083
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20388257 by robert manuszewski in ue5-main branch]
2022-05-26 20:17:30 -04:00
robert millar
ae6572db39 Refactor reference chain searching to handle multiple objects at once to reduce time spent scanning all objects and creating/deleting temporary structures.
Add ShortestToGarbage option to deduplicate reference chains by the root reference & the first garbage object encountered.
Do not use the 'Visited' counter for the FGCObject referencer so that we can find multiple chains that terminate there since it handles many disparate types of reference.
When removing duplicate chains, if the chain root is the GC object referencer, use the previous object in the chain as a key instead.
Sort chains by length before deduplicating in shortest/longest mode.
Truncate GCObjectReferencer strings in case they overflow FName's capacity.

#rb none

#ROBOMERGE-AUTHOR: robert.millar
#ROBOMERGE-SOURCE: CL 20384061 via CL 20384066 via CL 20384814 via CL 20384939
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20387039 by robert millar in ue5-main branch]
2022-05-26 18:34:44 -04:00
danny couture
373563955a Fix potential deadlock by moving the ForEachObject sections that locks the hash table outside of another lock
#rnx
#rb Francis.Hurteau
#preflight 628f6b0680139a518168c9e5

[CL 20378034 by danny couture in ue5-main branch]
2022-05-26 08:06:42 -04:00
danny couture
b79d21f351 Make ImplementsGetWorld check thread-safe
#rnx
#rb Francis.Hurteau
#preflight 628e6daa82597362d105efab

[CL 20377916 by danny couture in ue5-main branch]
2022-05-26 07:41:37 -04:00
Marc Audy
ab31b6dc6c Fix non-unity
#rnx
#preflight

[CL 20376568 by Marc Audy in ue5-main branch]
2022-05-26 02:27:07 -04:00
robert millar
412079529f Add IsGarbage function.
#rb none

#ROBOMERGE-AUTHOR: robert.millar
#ROBOMERGE-SOURCE: CL 20368750 via CL 20368758 via CL 20369216 via CL 20369301
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20370894 by robert millar in ue5-main branch]
2022-05-25 16:27:55 -04:00
Steve Robb
c20cb33cf6 Fix for copy+pasted description for UStruct::DestroyStruct.
#jira UE-114278
#rb trivial
#preflight none

[CL 20368857 by Steve Robb in ue5-main branch]
2022-05-25 14:22:21 -04:00
robert manuszewski
3aa73e1a69 Fixing static analysis warning which revealed a bug in StaticFindFirstObject
[FYI] Andrew.Scheidecker
#rb trivial

#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20363159 via CL 20363251 via CL 20363384 via CL 20363414
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20366242 by robert manuszewski in ue5-main branch]
2022-05-25 12:08:30 -04:00
danny couture
8f1e0b2f56 Add -EditorDomain and -NoEditorDomain command line parsing
#rnx
#rb Matt.Peters, Per.Larsson
#preflight 628e184b4a44e2e184c93007

[CL 20362823 by danny couture in ue5-main branch]
2022-05-25 08:20:58 -04:00
robert manuszewski
ab7e946c3b New utility functions for ANY_PACKAGE removal
- UClass::TryFindTypeSlow
- UClass::TryFindTypeSlowSafe
- UClass::TryConvertShortTypeNameToPathName
- UClass::TryFixShortClassNameExportPath
- Additional options for StaticFindFirstObject
- Added a new overload for FObjectPropertyBase::GetExportPath

#jira UE-99463
#rb Steve.Robb
#preflight 628d28a2c97e4beea3ab258f

#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20360134 via CL 20360138 via CL 20360316 via CL 20360356
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20360692 by robert manuszewski in ue5-main branch]
2022-05-25 02:13:39 -04:00
robert millar
ca098ff15c Modify FGCObjectInfo::TryResolveObject to use only FNames and no FStrings to search for objects.
Requires base casses to handle recursion for script packages and for finding UClass::StaticClass().
The class of class is class, and the outer of the class UPackage is a UPackage.

#rb none

#ROBOMERGE-AUTHOR: robert.millar
#ROBOMERGE-SOURCE: CL 20355908 via CL 20355936 via CL 20356012 via CL 20356034
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20357501 by robert millar in ue5-main branch]
2022-05-24 18:37:58 -04:00
devin doucette
b2a07ea03e DDC: Merge from UE5/Main
#preflight 6288ff678828ea88c8af7034
#preflight 628ab5d93246d5019db76ed2
#rb none
#rnx

#ROBOMERGE-OWNER: devin.doucette
#ROBOMERGE-AUTHOR: Devin.Doucette
#ROBOMERGE-SOURCE: CL 20353148 via CL 20353832 via CL 20353839
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20355348 by devin doucette in ue5-main branch]
2022-05-24 16:40:25 -04:00
Matt Peters
0baa95d653 EditorBulkDatas need to create new guids to avoid duplication when they are loading from an instanced load, since instanced loads duplicate data from a source package into a new package of a different name.
#jira UE-152829
#rb Paul.Chipchase
#rnx
#preflight 628cd21cf057b981ca5edf3f

[CL 20347479 by Matt Peters in ue5-main branch]
2022-05-24 09:36:42 -04:00
CarlMagnus Nordin
a694071dbe AsyncLoading2: Keep the full package path for loaded packages instead of just the package name
#rb pj.kack
#preflight 628c99cff057b981ca4cdbc3

[CL 20345705 by CarlMagnus Nordin in ue5-main branch]
2022-05-24 05:33:01 -04:00
robert manuszewski
77ac0ff10f Adding UStruct::GetStructPathName() (part of a bigger change required for a fix)
#rb trivial
#preflight 62863b012b53e2be4c972d30

#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20344772 via CL 20344773 via CL 20344775 via CL 20344777
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20345312 by robert manuszewski in ue5-main branch]
2022-05-24 04:18:40 -04:00
Catalin Dragoiu
0b478d5694 Cooking Profiler Prototype
#rb Ionut.Matasaru  Matt Peters
#preflight 628b8690693c5e1de2773a39

[CL 20327158 by Catalin Dragoiu in ue5-main branch]
2022-05-23 10:13:54 -04:00
HertzDonut
90f1d6a993 UStructs can now provide a CanEditChange override by setting the TStructOpsTypeTraitsBase2::WithCanEditChange trait.
PR #8877: Contributed by HertzDonut

#rb sebastian.nordgren
#preflight 628b6da1183c1e134617e4c3

[CL 20323458 by HertzDonut in ue5-main branch]
2022-05-23 07:33:11 -04:00
robert manuszewski
f8a812a32f Converting hardcoded short class/enum names to pathnames ahead of ANY_PACKAGE removal
#rb trivial
#jira UE-99463
#preflight 6288fd998828ea88c8aef3d0

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20314896 via CL 20314897 via CL 20314903 via CL 20314904
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20315214 by robert manuszewski in ue5-main branch]
2022-05-22 10:30:02 -04:00
matt breindel
6114886c10 Introduce new FVirtualStackAllocator which provides alloca() type functionality backed by virtual memory. Only supported on platforms with support for manual virtual memory management.
[REVIEW] [at]*tim.tillotson
#rb steve.robb tim.tillotson
#preflight 62859e01614041edb7c36eed (failed for seemingly unrelated reasons)

#ROBOMERGE-AUTHOR: matt.breindel
#ROBOMERGE-SOURCE: CL 20284331 via CL 20284341 via CL 20284483 via CL 20284591
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20304687 by matt breindel in ue5-main branch]
2022-05-20 18:45:18 -04:00