Commit Graph

10564 Commits

Author SHA1 Message Date
JeanFrancois Dube
57aef1aa48 World Partition: minor code changes to keep consistency between streaming generation log functions.
#rb none
#preflight none
#rnx

[CL 20433362 by JeanFrancois Dube in ue5-main branch]
2022-05-30 19:32:08 -04:00
JeanFrancois Dube
5feebe9624 World Partition:
- Added FHierarchicalLogArchive proxy that can be used to output a structured log archive.
- Converted world partition streaming generation logging to use FHierarchicalLogArchive.

#rb richard.malo
#preflight 6294e2363f154a84f7fb492d
#rnx

[CL 20431659 by JeanFrancois Dube in ue5-main branch]
2022-05-30 12:37:47 -04:00
Devin Doucette
605998206f CompactBinary: Replaced local ReadUnaligned function with FPlatformMemory::ReadUnaligned
#preflight 6294ced34c7bcac173d19fb1
#rb Zousar.Shaker
#rnx

[CL 20431253 by Devin Doucette in ue5-main branch]
2022-05-30 11:19:23 -04:00
Jerome Delattre
fd78d9fe7d Avoid map reallocation for AutomationTest filters
#preflight 6294d35d4c7bcac173d20670
#rb Chris.Constantinescu
#rnx
#jira none

[CL 20430933 by Jerome Delattre in ue5-main branch]
2022-05-30 10:34:32 -04:00
Andriy Tylychko
1ac9a76c0c releasing FIoBatchImpl::Callback right after it's called to avoid a long living allocation that keeps a larger memory block from being returned to the system
#rb CarlMagnus.Nordin
#preflight trivial

[CL 20429437 by Andriy Tylychko in ue5-main branch]
2022-05-30 05:43:13 -04:00
Richard Wallis
55c9e19f57 Remove macOS specific logic in FPaths::GeneratedConfigDir(). Using ~/library/preferences/UnrealEngine folder based on project name can lead to clashes with different projects using the same name. Use the same logic as other platforms and store generated config ini files in the project/saved/ folder. This also will fix the minor issue of leaving lots of per project config files around in ~/library/preferences/UnrealEngine when you delete a project.
Tested multiple blueprint and C++ projects with the same name in different directories; running the editor + PIE + cooking & packing.

#jira UE-130570
#review-20362376 @will.damon
#preflight https://horde.devtools.epicgames.com/job/628dfb1d415c65b96ae16322
#rb Will.Damon, Josh.Adams

[CL 20429412 by Richard Wallis in ue5-main branch]
2022-05-30 05:38:41 -04:00
Marc Audy
c77dc2604e Fix non-unity
#rnx
#preflight

[CL 20403276 by Marc Audy in ue5-main branch]
2022-05-28 01:16:10 -04:00
brian karis
0d8b010e12 Nanite displaced mesh. Added uniform tessellation and displacement.
#rb graham.wihlidal
#preflight 62901dcd74630984fd6763b1

#ROBOMERGE-AUTHOR: brian.karis
#ROBOMERGE-SOURCE: CL 20400905 via CL 20400917 via CL 20400925
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20402444 by brian karis in ue5-main branch]
2022-05-27 20:42:29 -04:00
jeremy moore
6ffda2e45e Add bEvaluateWorldPositionOffset property which will be used to determine whether to evaluate WPO.
Actual usage of the property will get merged in from UE5, but adding the placeholder property here to reduce pain from data merges.
This change also remaps the original bEvaluateWorldPositionOffset on SMC into bEvaluateWorldPositionOffsetInRayTracing, because this var was only ever driven by ray tracing specific methods.
We expect to need to special case robomerging the remap of bEvaluateWorldPositionOffsetInRayTracing since it needs to be done from different branches with different branch specific versions.
#rnx
#preflight 62912113fe5e30102ab83d32

#ROBOMERGE-OWNER: jeremy.moore
#ROBOMERGE-AUTHOR: jeremy.moore
#ROBOMERGE-SOURCE: CL 20398059 via CL 20398673 via CL 20398786
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20401242 by jeremy moore in ue5-main branch]
2022-05-27 19:30:55 -04:00
geoff evans
a01f28498a Trace: Enable Default Trace Channels automatically for Editor
### Features
Prior to this change there are no trace channels active for any Editor process, and default channels were accessed by passing -trace or -trace=default.

This change enables default channels automatically for Editor.

#rb ionut.matasaru
#jira UE-151707
#preflight 627d6b4ba82f3adab8b0de98

#ROBOMERGE-AUTHOR: geoff.evans
#ROBOMERGE-SOURCE: CL 20394530 via CL 20394607 via CL 20394639
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20398664 by geoff evans in ue5-main branch]
2022-05-27 16:49:15 -04:00
Johan Berg
a86afcb0fd Memory tracing refactorings
As the memory tracing implementation grew and callstack tracing was extracted it became clear that alot of the code which was implemented as platform specific should really be platform independent. This changelist moves all MemoryTrace_* methods except the MemoryTrace_Initialize to a platform independent layer. This also allows for internalizing the "do-not-allocate-while-tracing-an-allocation" flag. Also took the oportunity to rename MemoryTrace.cpp in Microsoft folder to better reflect platform specific file.

#rb ionut.matasaru
#preflight 6290df2d3c05bea8bfd3ed82
#preflight 6290eb90b83292836e074fff

[CL 20394897 by Johan Berg in ue5-main branch]
2022-05-27 12:39:27 -04:00
Julien StJean
2eba3b5a65 Improved the performance of the TypedElementSelectionSet Selection.
From 119 Seconds to 269 ms when measuring the time redo a large marquee selection (30 384 static mesh instances).

#jira UE-148888
#preflight 627146b75e6ce673f443ccea

[CL 20393379 by Julien StJean in ue5-main branch]
2022-05-27 10:44:22 -04:00
Steve Robb
4514fad516 GitHub 8898 : FIntVector: Add component-wise multiplication operator
#rb steve.robb
#jira UE-142730
#preflight 6290d8ac1f0041249bf005d5

[CL 20393041 by Steve Robb in ue5-main branch]
2022-05-27 10:16:47 -04:00
David Harvey
3be9106018 remove Hololens from ExceptionHandling.h
- only one function used in one place, so easier to extern it directly.

#jira UE-149794
#rnx
#preflight 6290b15bf6668c14a3cc75d0
#rb pending

[CL 20392928 by David Harvey in ue5-main branch]
2022-05-27 10:09:47 -04:00
jeff newquist
7d1a83e840 Remove hardcoded NDA platform define. This can be defined for a game by specifying bAllowConfidentialPlatformDefines as a target rule.
#jira none
#fyi david.harvey
#preflight 628f7ba43437fe04a8586fa9

[CL 20392517 by jeff newquist in ue5-main branch]
2022-05-27 09:40:32 -04:00
Rune Stubbe
1539f7895a Improved Nanite partitioning heuristics to produce fewer multi-material clusters
Locality links are now only added between elements with the same material
#rb brian.karis
#preflight 6290cee5dd2be751aeda4a71

[CL 20392408 by Rune Stubbe in ue5-main branch]
2022-05-27 09:30:52 -04:00
Devin Doucette
3b9e9b2d33 ParallelFor: Cancel unused tasks and time the wait for tasks to complete
When worker threads are heavily utilized by slow tasks, ParallelFor may execute most of the work on the calling thread before most (or any) of its tasks have executed. Allowing these tasks to execute later is wasteful because each task executed on a background worker pays about 0.3us to lower and then raise thread priority. Canceling the tasks can avoid that cost when paired with an upcoming change to the scheduler, which saves about 40us for each call to ParallelFor in a heavily-utilized pool of 126 worker threads.

#preflight 62587f45010ebc5d4e89d347
#rb Andriy.Tylychko, Arne.Schober

[CL 20392225 by Devin Doucette in ue5-main branch]
2022-05-27 09:18:08 -04:00
adam kinge
eb79f04e36 A temporary iOS only workaround for a memory allocator crash on UE5/Main until UE-154181 is resolved.
#review-20390217 @jack.porter
#fyi dmytro.vovk
#jira UE-154181
#preflight none for iOS

[CL 20392131 by adam kinge in ue5-main branch]
2022-05-27 09:06:15 -04:00
Per Larsson
c30e677d1b Merge BulkData 1&2
#rb Paul.Chipchase, PJ.Kack, CarlMagnus.Nordin
#jira none
#preflight 629085d14f63120d8e170977

###
This change attempts to merge the editor and the runtime version of bulk data, i.e. bulk data one and two.
The major difference between the two is the fact that the editor version supported element vice
serialization via inheritance. This has been complelety removed in the runtime version. In order
to mitigate this divergance a non-virtual base class has been extracted that forms the base
for the untyped and typed versions of bulk data.
The untyped version is only used in editor and will be deprecated. However this is a breaking change,
previously it was possible to inherit from FByteBulkData in editor builds.
Other differences between the two includes:
* IsBulkDataLoaded - returns true for bulk data 1 if an allocation has been made even if the size is zero
* StartStreaming - was removed in bulk data 2 and has been removed
* FlushAsyncLoading - bulk data 2 was busy waiting, now an event is used

All I/O related functionality has been extracted into BulkDataStreaming.cpp and is using
a  FBulkDataChunkId that is either a package path or a package ID.This could potentially
be extended to contain a cache key in development builds to support loading from DDC, i.e derived
data references.

[CL 20391050 by Per Larsson in ue5-main branch]
2022-05-27 04:31:58 -04:00
Geoffrey Douglas
7d3985da84 Centralize application of nodal offset to LensComponent, removing all references to nodal offset from the LiveLink camera controller
#jira UE-153107
#jira UE-146118
#rb simon.therriault
#preflight 628fe02174630984fd4eb26a

[CL 20385271 by Geoffrey Douglas in ue5-main branch]
2022-05-26 16:49:09 -04:00
Steve Robb
d62cc2f0b9 Comment about failed compilation of non-public constructors copied from TIntrusiveReferenceController to TArray::Emplace.
#rb trivial
#jira none
#preflight none

[CL 20381453 by Steve Robb in ue5-main branch]
2022-05-26 13:55:59 -04:00
Jimmy Andrews
532db0b972 fix a bug where FScopedSlowTask can get stuck auto-cancelling if the dialog-create-delay is longer than it takes to call ShouldCancel()
#rb rinat.abdrashitov
#preflight 628dbcbcaf7a2e956ba62ee3

[CL 20381176 by Jimmy Andrews in ue5-main branch]
2022-05-26 13:19:28 -04:00
Steve Robb
69503ce2d7 Improved comments around the use of MakeShared.
New ConstCastWeakPtr and StaticCastWeakPtr functions to match the SharedPtr/Ref equivalents.
Lots of sharedptr-related functions made [[nodiscard]].

#rb devin.doucette
#jira none
#preflight 628fad39e17a02240dd5bbe7

[CL 20381019 by Steve Robb in ue5-main branch]
2022-05-26 13:04:03 -04:00
Stu McKenna
6a5eb11e9b - Add back in packing to external cbuffer as some platforms don't adhere to the same rules
#rb shaun.kime, rob.krajcarski
#jira none
#rnx
#preflight 628facc974630984fd42ea93

[CL 20380888 by Stu McKenna in ue5-main branch]
2022-05-26 12:51:40 -04:00
ionut matasaru
df6018342f Added CacheAllocated statistics for trace system (all memory allocated in cache buffers).
Fixed "Important Events cache" stats displayed by Trace.Status console command.

#rb Johan.Berg
#preflight 628f37cdc511f67c9f0905f6

[CL 20376989 by ionut matasaru in ue5-main branch]
2022-05-26 04:47:52 -04:00