Commit Graph

13710 Commits

Author SHA1 Message Date
jimmy smith
a403a64c9c Fix for crash/OOM on importing truncated .wav files if using the PCM codec.
#rb max.hayes
#jira UE-192209

[CL 27219298 by jimmy smith in ue5-main branch]
2023-08-18 16:33:14 -04:00
jeannoe morissette
e97f023224 VulkanRHI: Add handling of multiple entrypoints for RayHitGroup shaders (VK RT WIP, does not change current output)
#rb carl.lloyd
[FYI] aleksander.netzel
#jira UE-171798
#rnx

[CL 27209304 by jeannoe morissette in ue5-main branch]
2023-08-18 13:12:21 -04:00
jeannoe morissette
b070af8d82 VulkanRHI: Add quotes around the entrypoint name in the command line for cases where multiple entrypoints are possible (like RT hit group)
#rb carl.lloyd
[FYI] aleksander.netzel
#rnx

[CL 27204165 by jeannoe morissette in ue5-main branch]
2023-08-18 11:39:37 -04:00
dominic couture
8bc739dd3e This changelist contains various changes to allow the creation of FPrimitiveSceneProxy & FPrimtiveSceneInfos for meshes not associated with an AActor/UPrimitiveComponent pair. In other words, it's now possible to add primitives to FScene that aren't associated with AActors & UPrimitiveComponents. These are additional entry points, all existing code should continue to build & execute as is.
*Added FPrimitiveSceneDesc, a structure you can initialize with a description of the primitive you're trying to Add/Remove/Update in the FScene
-Added entry points in FSceneInterface to do those operations, legacy entry points using UPrimitiveComponent are untouched.
-The code that executes those operations in FScene has been refactored to be shared between the two entry points as much as possible to lessen the additional maintenance burden.


*Added FPrimitiveSceneProxyDesc/FStaticMeshSceneProxyDesc/FInstancedStaticMeshSceneProxyDesc, structures that hold all the necessary information to create a FPrimitiveSceneProxy/FStaticMeshSceneProxy/FInstancedStaticMeshSceneProxy without depending on AActors or UPrimitiveComponent.
-Those structures can be initialized by constructing them with the corresponding UPrimitiveComponents, or by constructing their default versions and initializing the desired fields.
-Creation code for FPrimitiveSceneProxy/FStaticMeshSceneProxy/FInstancedStaticMeshSceneProxy now takes all its info from those desc structures. They are created on demand during scene proxy creation for UPrimitiveComponents. This means no additional memory, and all serialized assets & blueprints are unaffected.


*Added IPrimitiveComponent/IStaticMeshComponent interfaces
-These allow for some editor-only interactions occurring during proxy creation, and serve as a common interface for some code that expected to manipulate UPrimitiveComponent/UStaticMeshComponents. For example FObjectCacheEventSink / FObjectCacheContext now uses those interfaces to associate the resources between various users and interactions like proxy recreation on shader/mesh changes occur through those interfaces.


* Misc
-Moved scene primitive related member variables into a new structure (FPrimitiveSceneInfoData) to facilitate code sharing and implementations of various related functionality (like SetLastRenderTime).
-Changed ObjectCacheContext to store associations between resources and components using component interfaces so that other systems creating proxies have the proper behaviors when resource changes require proxy recreation.
-Added natvis support so that component interfaces to UPrimitiveComponent/UStaticMeshComponent display the component ptr for easier debugging.
-Changed FMotionVectorSimulation to use UObject* instead of UPrimitiveComponent*, it was already using this internally
-Templatized some nanite helpers like ShouldCreateNaniteProxy & AuditMaterials since we need to use them from both UPrimitiveComponent & FPrimitiveSceneProxyDesc and it'll help make sure we keep them in sync.

#jira UE-191990

#rb Zach.Bethel, Ola.Olsson, Jason.Nadro, Krzysztof.Narkowicz

[CL 27200716 by dominic couture in ue5-main branch]
2023-08-18 09:26:39 -04:00
tim smith
5252c1e1b3 1) Removed the bUseVerse UBT setting.
2) Removed usage of WITH_VERSE and UE_USE_VERSE_PATHS
3) Modified UBT to always set WITH_VERSE and UE_USE_VERSE_PATHS to one until the setting is completely removed.

#rb Andrew.Scheidecker

[CL 27199531 by tim smith in ue5-main branch]
2023-08-18 08:09:29 -04:00
patrick enfedaque
0967478909 Migrate dialog: Migration of a map is all or nothing. Hide __ExternalActors__ / __ExternalObjects__ from dialog when migrating OFPA maps.
#rb jeanfrancois.dube
#rnx

[CL 27199211 by patrick enfedaque in ue5-main branch]
2023-08-18 07:50:59 -04:00
jeannoe morissette
4e65bdc179 VulkanRHI: Start adding code in VulkanShaderCompiler to track bindless UB and handle RootParametersStructure. (VK RT WIP, disabled for now)
#rb none
#jira UE-171798
#rnx

[CL 27185944 by jeannoe morissette in ue5-main branch]
2023-08-17 17:14:45 -04:00
zousar shaker
ca374bd482 Add a setting that controls whether the modal acknowledgement dialog is shown before a browser is launched for OIDC authentication in editor. This setting is editor-wide (not per project), but:
1. A project can override the default value in that project's DefaultEditorSettings.ini
2. A user can indicate they don't want to see the dialog in the future, and thata setting is persisted to the user's editor settings file

If the setting indicates (either through defaults or user choice) that the acknowledgement dialog can be skipped, then unattended operations (eg: commandlets like cook etc..) are permitted to attempt interactive login by launching the browser.  If the browser login succeeds within a fixed timespan (30 seconds), then the unattended operation can proceed having successfully obtained an oidc token.  If the browser login hasn't succeeded in the fixed timespan, then the unanttended operation will proceed but will have failed to obtain an oidc token.  In neither case do we block indefinitely on completion of browser login to obtain an oidc token.

#rb joakim.lindqvist
[FYI] stefan.boberg
#jira UE-191803

[CL 27177449 by zousar shaker in ue5-main branch]
2023-08-17 13:13:20 -04:00
zousar shaker
c91ec057f6 Increase default timeout when waiting for zenserver shutdown from 5 seconds to 15 seconds as I've received a report of zenserver upgrade failing due to the shutdown timeout being insufficient.
#rb none,trivial
[FYI] joe.pribele
[FYI] dan.engelbrecht

[CL 27177406 by zousar shaker in ue5-main branch]
2023-08-17 13:12:29 -04:00
jimmy smith
59da8ffa49 Fix for PCM not playing under some circumstances
#jira UE-193167 UE-193169
#rb max.hayes phil.popp

[CL 27158787 by jimmy smith in ue5-main branch]
2023-08-16 18:33:02 -04:00
charles bloom
7f52be25d7 fix checkSlow in NaniteEncode
#rb none
#rnx

[CL 27155328 by charles bloom in ue5-main branch]
2023-08-16 17:14:22 -04:00
jeannoe morissette
150748bbaa VulkanRHI: (VK RT WIP) Move all serialized parameter of the shader compilation process into a struct together (Header, SRT, Spirv).
#rb none
#jira UE-171798
#rnx

[CL 27151506 by jeannoe morissette in ue5-main branch]
2023-08-16 15:44:45 -04:00
pj kack
3b92239e69 IoStore: Make sure the FZenPackageHeader array views starting with ImportedPublicExportHashes are 8-byte aligned
#jira UE-192747
#rb per.larsson

[CL 27135261 by pj kack in ue5-main branch]
2023-08-16 06:18:19 -04:00
laura hermanns
f5e5f41162 Fix removal of unused shader interpolators for DXC backends: Keep original semantic name including its index and separate it from its overridden binding slot.
#rb Dan.Elksnitis, Ben.Woodhouse
[FYI] Brian.White, Carl.Lloyd, Serge.Bernie
#jira UE-191963
#rnx

[CL 27133050 by laura hermanns in ue5-main branch]
2023-08-16 00:43:54 -04:00
jeannoe morissette
8102581292 VulkanRHI: Remove unnecessary code in VulkanShaderCompiler (clean up WIP). Remove some of the CombinedImageSampler code (and some ImmutableSamplers). Removed some parts of FOLDVulkanCodeHeader. Remove the use of FHlslccHeaderWriter and FHlslccHeader to generate a string and then parse it, work directly from SPIRV and reflection.
#rb Laura.Hermanns
#jira UE-176887,UE-176175
#rnx

[CL 27132998 by jeannoe morissette in ue5-main branch]
2023-08-16 00:42:57 -04:00
marc audy
a75b48030b More compressible Nanite disk format (typically ~10% smaller after compression)
-Delta code vertex attributes and cluster refs
-ZigZag code deltas
-Store them as whole bytes
-Split high/mid/low bytes into separate streams

Transcode
-Transcode is now split into an independent pass and a number of dependent passes
-Launch a group per cluster instead of launching a group per potential cluster in a page and have them early out

Got rid of unused vertex color mode: NANITE_VERTEX_COLOR_MODE_WHITE
#rb brian.karis
[FYI] graham.wihlidal, jamie.hayes
#jira

[CL 27132972 by marc audy in ue5-main branch]
2023-08-16 00:39:49 -04:00
josh adams
82ee4f70d5 - Removed the quotes around the signing identity for Xcode manual codesigning
- During staging, we now make the UBTGenerated/Info.Template.plist in the project folder instead of Engine folder, for BP projects
- Fixed an AppStoreConnect label in the Xcode project settings that would have confused anyone trying to set it up

#jira UE-193101, UE-193108, UE-193104
#rb Calvin.zheng

[CL 27130271 by josh adams in ue5-main branch]
2023-08-15 21:33:02 -04:00
Jerome Delattre
31881299d9 Add support for plain text to FAutomationTestBase::AddExpectedMessage
#jira UE-190032
#rb Chris.Constantinescu, Rob.Huyett

[CL 27118558 by Jerome Delattre in ue5-main branch]
2023-08-15 16:21:05 -04:00
dan elksnitis
9064172949 [shaders] migration of VectorVM shader format to independent preprocessing API (along with some cleanup)
#rb Rob.Krajcarski
#rb Laura.Hermanns

[CL 27106719 by dan elksnitis in ue5-main branch]
2023-08-15 12:28:03 -04:00
zousar shaker
6b75b9a36e Change HTTP cache store to allow GetChunks to execute asynchronous network operations.
#rb devin.doucette
#rnx

[CL 27104962 by zousar shaker in ue5-main branch]
2023-08-15 11:49:22 -04:00
Mikita Hauruk
59d812b6f2 [Insights] Automated T223693548, T223693546 and T223693547 from "Unreal Insights - Memory Insights - Allocations Query Table" suite
#jira UEENGQA-99691
#jira UEENGQA-99692
#jira UEENGQA-99693

#rb ionut.matasaru catalin.dragoiu

[CL 27097536 by Mikita Hauruk in ue5-main branch]
2023-08-15 01:39:00 -04:00
ryan schmidt
709253e10a CombineMeshInstances: Add support for specifying constraints on allowed Approximation types for specific Parts
#rb none
#rnx

[CL 27094778 by ryan schmidt in ue5-main branch]
2023-08-14 21:03:36 -04:00
maxwell hayes
055650379c Added protection against crash when importing corrupt audio file and setting codec to PCM.
#jira UE-192209
#rb Aaron.McLeran
#lockdown julien.marchand

[CL 27093547 by maxwell hayes in ue5-main branch]
2023-08-14 19:51:29 -04:00
joe kirchoff
8fc9771156 Don't use static functions in the DirectX module to get paths, it is not guaranteed that this module will exist
#rnx

[CL 27090677 by joe kirchoff in ue5-main branch]
2023-08-14 18:16:33 -04:00
dan thompson
5899f2b386 Fix for log spew when packaging DLC plugins.
#rb fabian.giesen

[CL 27089868 by dan thompson in ue5-main branch]
2023-08-14 18:05:57 -04:00