Commit Graph

762 Commits

Author SHA1 Message Date
devin doucette
1a688b31e2 DDC: Fixed Clang static analysis warnings
#jira none
#preflight 640f96f3482188d710688621
#rb Zousar.Shaker
#rnx
#lockdown zousar.shaker

[CL 24643936 by devin doucette in ue5-main branch]
2023-03-14 16:48:35 -04:00
devin doucette
672818b928 StringBuilder: Converted WriteToString from a type to a function
This was not possible on C++14 and is possible now due to guaranteed copy elision in C++17.
This will break backward compatibility when WriteToString was used as a type or in a context where it would be copied.

#preflight 640a0460af3fc3529234c216
#rb Matt.Peters

[CL 24583299 by devin doucette in ue5-main branch]
2023-03-09 17:06:55 -05:00
Dan Thompson
8f55b18fe5 Remove debug logging
#fyi devin.doucette
#rb none
#preflight 6408d546cf5fe1e28cea3c19

[CL 24563734 by Dan Thompson in ue5-main branch]
2023-03-08 13:46:10 -05:00
mark lintott
fe1ee99e15 Fix for DDC and Cook analytics event attributes not being transmitted as numbers to the backend. This allows us to correctly aggregate DDC/Cook values in Grafana.
[FYI] Devin.Doucette, Garry.Casey, Erik.Knapik
#rb trivial
#preflight 63fdf46fef1b24bf940111c1

[CL 24446536 by mark lintott in ue5-main branch]
2023-02-28 13:24:40 -05:00
devin doucette
d802756cf3 DDC: Added logging if legacy requests fail to copy the buffer
Includes a speculative workaround for check(Data.Num()) failing.

#rb Matt.Peters
#rnx

[CL 24412735 by devin doucette in ue5-main branch]
2023-02-24 19:01:05 -05:00
devin doucette
ee3c2bc2fd DDC: Initialized bGetResult in case the callback is somehow missed
#rb none

[CL 24408000 by devin doucette in ue5-main branch]
2023-02-24 15:48:03 -05:00
devin doucette
4b200b0c7f DDC: Added -DDC-VerifyFix to overwrite existing records and values that differ from newly generated records and values
#rb Zousar.Shaker

[CL 24287758 by devin doucette in ue5-main branch]
2023-02-17 14:18:34 -05:00
joakim lindqvist
40c47276bd Error -> Warning when we are unable to resolve a token for Cloud DDC. This will not cause the build to fail, but it will typically be slower for it so error is harsh (as that in itself causes the build to fail)
[FYI] zousar.shaker
#preflight 63ef6b8b90198dffbae12467

[CL 24281972 by joakim lindqvist in ue5-main branch]
2023-02-17 10:25:12 -05:00
charles bloom
5e488c3f89 LaunchTaskInThreadPool API change needs to be properly deprecated
add pass-through for old args

#rb devin.doucette
#preflight none

[CL 24263337 by charles bloom in ue5-main branch]
2023-02-16 13:36:05 -05:00
dan engelbrecht
e7c1e5fa6a Only report local stats for Zen DDC.
ZenCacheStore now only tracks what the client sees, regardless if the zenserver instance gets a hit from a configured upstream.
As we don't currently have any upstreams configured in the zen server instance this should give a more accurate number for hit/miss stats that matches the file cache.

#preflight 63eabb1bb96a6b2718326d15
#rb zousar.shaker devin.doucette

[CL 24206594 by dan engelbrecht in ue5-main branch]
2023-02-14 03:09:44 -05:00
charles bloom
048e8bc0fd AssetCompilingManager track down and log about resources that don't set RequiredMemory
mark places that need fixing with [at]todo RequiredMemory
add DebugName to Task and Work to track down sources of the work items

#preflight https://horde.devtools.epicgames.com/job/63eabe61b96a6b2718336f8f
#rb danny.couture

[CL 24201094 by charles bloom in ue5-main branch]
2023-02-13 22:01:48 -05:00
mark lintott
7126d3c2ed Split up the DDC cache analytics per back end so we can more easily reason about specific abck end perf
#rb zousar.shaker, devin.doucette
#preflight 63da8e557a39a18021722350

[CL 23984212 by mark lintott in ue5-main branch]
2023-02-02 18:47:48 -05:00
zousar shaker
7444b2940f Added comment to the DerivedDataCache build file explaining the need for developers to add a DesktopPlatform dependency if they need UE Cloud DDC interactive login to work for their custom targets.
#rb none
[FYI] paul.chipchase
[FYI] devin.doucette

[CL 23933609 by zousar shaker in ue5-main branch]
2023-01-31 14:13:17 -05:00
Zousar Shaker
d907347b26 Fix build breakage from CL23917590.
#rb none
#fyi devin.doucette
#preflight skip,BuildBreakFix

[CL 23918382 by Zousar Shaker in ue5-main branch]
2023-01-30 18:34:40 -05:00
Devin Doucette
82621298bf DDC: Added -ExportBuildOutput to include outputs in exported builds
#preflight 63d804445c69f453c111cfd0
#rb Zousar.Shaker

[CL 23917590 by Devin Doucette in ue5-main branch]
2023-01-30 17:44:07 -05:00
danny couture
74782129ec Fix race in FCounters used in FileSystemCacheStore and AsyncLoading
#rnx
#rb Devin.Doucette
#preflight 63d1d57e6a14d8406d8fc7d4

[CL 23863764 by danny couture in ue5-main branch]
2023-01-25 21:07:51 -05:00
Devin Doucette
023e2fd5e8 DDC: Fixed a race condition in the cache hierarchy
The hierarchy now uses a request barrier after the first synchronous request completion. Async requests could occasionally complete fast enough that DispatchRequests would be left to handle the completion. In that scenario, there would not be a barrier in place when beginning any subsequent requests, which would lead to a failed assertion in the request owner.

#preflight 63ceb5c63a03cb0bbff95362
#rb Zousar.Shaker

[CL 23848713 by Devin Doucette in ue5-main branch]
2023-01-25 11:05:29 -05:00
zousar shaker
d52719ba40 Add support for a Zen cache store Host to be None (implying that it is disabled) and to have both commandline and environment overrides (similar to the HTTP cache store).
#rb devin.doucette

[CL 23815887 by zousar shaker in ue5-main branch]
2023-01-23 12:48:38 -05:00
mark lintott
72bf7a2d8c Fixed the Cloud, Local and Shared Percentages that exceed 100% when more than one backend is used. These were flawed, Root Get/Hit count cannot be used for the percentages for each backend in this way.
#rb devin.doucette
 #preflight 63c93722ac35a0e9da754473

[CL 23773901 by mark lintott in ue5-main branch]
2023-01-19 10:45:32 -05:00
nicholas howe
a8ee4b6253 Fix RemoveTicker Hang in HttpCacheStore.
#jira UE-174489
#rb devin.doucette
#preflight 63c85026c246f14856661f40

[CL 23766649 by nicholas howe in ue5-main branch]
2023-01-18 17:59:46 -05:00
zousar shaker
d78e86696f Exclude Zen from HttpCacheStore test on non-windows platforms as it is not ready for use on non-windows platforms.
#rb trivial
[FYI] devin.doucette
[FYI] matt.peters

[CL 23658577 by zousar shaker in ue5-main branch]
2023-01-11 20:57:41 -05:00
zousar shaker
bfbf54d4ca ZenCacheStore - ignore "None" as an override value for a local DDC path when using sandboxes (in line with past behavior for non-default local caches like Warm/Cold).
#rb devin.doucette

[CL 23658565 by zousar shaker in ue5-main branch]
2023-01-11 20:57:13 -05:00
mark lintott
8bad2c0365 Removed the callback system from core Analytics system. Fixed up analytics gathering in DerivedDataCache, Virtualization and HttpCacheStore
#rb wes.hunt
#preflight 63be95bd68068a8bd6a4438e

[CL 23651011 by mark lintott in ue5-main branch]
2023-01-11 14:28:01 -05:00
Devin Doucette
d081f5a477 DDC: Fixed the file system cache EditorOverrideSetting not handling paths with \ in them
#jira none
#preflight 63b78d3ad862fdd347ea642b
#rb Zousar.Shaker

[CL 23595626 by Devin Doucette in ue5-main branch]
2023-01-05 22:10:29 -05:00
zousar shaker
d1afea0f1f Allow ReadOnly mode for a DDC FileSystemCacheStore to have maintenance performed if Clean=true or DeleteUnused=true. When ReadOnly, they are now both false by default, but usable if explicitly set to true. When not ReadOnly, DeleteUnused remains true by default.
#rb devin.doucette

[CL 23592522 by zousar shaker in ue5-main branch]
2023-01-05 16:11:30 -05:00