Commit Graph

115 Commits

Author SHA1 Message Date
arciel rekman
8510cb4400 Fix another crash on exit due ot leaked global library's resources.
#rb none
[FYI] Justin.Marcus, CarlMagnus.Nordin
#preflight none

[CL 23000351 by arciel rekman in ue5-main branch]
2022-11-05 00:23:45 -04:00
arciel rekman
8615e858af Change Fatal log to a warning due to Global library's behavior.
#rb CM.Nordin
[FYI] Justin.Marcus, CarlMagnus.Nordin
#preflight none

[CL 22988920 by arciel rekman in ue5-main branch]
2022-11-04 12:17:41 -04:00
justin marcus
c31e3bcd3a Add fatal log to ~FShaderLibraryInstance. It is impossible for it to safely release resources from it's destructor.
[REVIEW] [at]Arciel.Rekman [at]Carl-Magnus.Nordin
#preflight https://horde.devtools.epicgames.com/job/6363c9b5dc30a4ce96fec50f

[CL 22968304 by justin marcus in ue5-main branch]
2022-11-03 17:57:51 -04:00
carlmagnus nordin
2b1c25c510 If a plugin contains a shader code library make sure to close it when unmounting the plugin
#preflight 6350ed84b13bfb29eb372a3b
#rb arciel.rekman

[CL 22651680 by carlmagnus nordin in ue5-main branch]
2022-10-20 04:48:12 -04:00
Matt Peters
9356ad41c4 ShaderCodeLibrary for CookMultiprocess: Fix typo in AppendFromCompactBinary that caused all calls to fail.
#rb None, trivial
#rnx
#preflight 632c7ff1e23e50651b4387f6

[CL 22139676 by Matt Peters in ue5-main branch]
2022-09-22 13:39:33 -04:00
Matt Peters
a8028aafba MPCook: Replicate shaderlibrary from CookWorker to Director.
#rb Jason.Nadro, Robert.Srinivasiah, Arciel.Rekman
#rnx
#preflight 6328bcd20a4ad044de3cbcfc

[CL 22078910 by Matt Peters in ue5-main branch]
2022-09-19 15:44:57 -04:00
Florin Pascu
6b3c1469ba Preview Shader Platform using different ShaderMaps and the DDPI/Cvar values of the Previewable Actual Platform
NumPlatforms limit changed from 64 to 65536, limited by NumBits
#jira UE-120561
#rb Chris.Waters, Jack.Porter, Mihnea.Balta
#preflight 630f1604f92416fb92b373ab

[CL 21718179 by Florin Pascu in ue5-main branch]
2022-08-31 04:38:34 -04:00
Matt Peters
80caf7a021 ShaderCodeLibraryCooker: Separate concerns so that writing shaderlibraries to disk is separate from population during the cook. This supports upcoming multiprocess cooking changes.
Tweak some functions for reduction of duplication and readability.
#rb Jason.Nadro, Rob.Srinivasiah
#rnx
#preflight 630d0a4d501b64ba331b303f

[CL 21685434 by Matt Peters in ue5-main branch]
2022-08-29 15:08:45 -04:00
allan bentham
9a5afd7255 Multiple PSO cache processing.
Splitt PSO cache code to separate out bundled game caches and a single PSO recording user cache.
Any additional PSO caches are enqueued when the shader library state change adds shader library components.
removed unused PSO SaveMode::SortedBoundPSOs.
#rb dmytro.vovk, peter.sauerbrei
#preflight 62d568481062f2e63007eafd
#preflight 62d5a99b2e3e5993c3bd473f

#ROBOMERGE-AUTHOR: allan.bentham
#ROBOMERGE-SOURCE: CL 21152209 via CL 21154820 via CL 21156073
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21181749 by allan bentham in ue5-main branch]
2022-07-20 11:54:53 -04:00
Jason Nadro
9c36c843b8 Removed unacceptable words from RenderCore.
#rb trivial
#jira UE-158668
#preflight 62c840a57e606620fd5c2847

[CL 21007335 by Jason Nadro in ue5-main branch]
2022-07-08 10:54:10 -04:00
Florin Pascu
f64fc575d2 Re-submiting with Mac fixes
Changed ShaderArchive, GlobalShaderCache, ShaderDebugInfo and Autogen to use ShaderPlatformName and not ShaderFormat when naming their output files.
#rb Jack.Porter, Chris.Waters, Mihnea.Balta, Jason.Nadro
#jira UE-120561
#preflight 62c31f6fc9410537282296c6

[CL 20937870 by Florin Pascu in ue5-main branch]
2022-07-04 19:06:33 -04:00
Florin Pascu
09cb19fcfd Backout 20871665 to fix Mac cook
#rb none
#jira none
#preflight 62be0c68d94b57687c3ff309

[CL 20904999 by Florin Pascu in ue5-main branch]
2022-06-30 17:41:55 -04:00
Florin Pascu
1844e8e514 Changed ShaderArchive, GlobalShaderCache, ShaderDebugInfo and Autogen to use ShaderPlatformName and not ShaderFormat when naming their output files.
#rb Jack.Porter, Chris.Waters, Mihnea.Balta, Jason.Nadro
#jira UE-120561
#preflight 62bbf93ae353c20ac2361d94

[CL 20871665 by Florin Pascu in ue5-main branch]
2022-06-29 04:19:06 -04:00
Devin Doucette
748e39e3c0 Replaced uses of _SV with TEXTVIEW
#preflight 6266da740634d0904ce6de29
#rb Steve.Robb
#rnx

[CL 19905760 by Devin Doucette in ue5-main branch]
2022-04-25 13:56:30 -04:00
arciel rekman
e3d2d01f9b Fix deadlock when opening plugin shader libraries.
#rb Ben.Ingram, Josh.Adams
#preflight 625f7bb06b458c3f8597af43
[REVIEW] [at]Josh.Adams, [at]Jason.Nadro, [at]Ben.Ingram

#ROBOMERGE-AUTHOR: arciel.rekman
#ROBOMERGE-SOURCE: CL 19854958 via CL 19857024 via CL 19862962 via CL 19863061
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v940-19807014)

[CL 19871027 by arciel rekman in ue5-main branch]
2022-04-22 15:55:14 -04:00
arciel rekman
2c4fba02af Fix hitching while precompiling PSO cache.
- Add a new API to release preloaded shader to provide a way to manage preloaded data (which was previously statically allocated).

#rb James.Doverspike, Richard.Wallis
[REVIEW] [at]Allan.Bentham, [at]Richard.Wallis
#preflight 625e11c4db15ac92db7ee858

#ROBOMERGE-AUTHOR: arciel.rekman
#ROBOMERGE-SOURCE: CL 19832275 via CL 19833640 via CL 19837454 via CL 19854946 via CL 19855339
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v940-19807014)

[CL 19856713 by arciel rekman in ue5-main branch]
2022-04-21 17:47:12 -04:00
markus breyer
64e81f8041 Unblocking workaround for UEFN is hanging on its startup from EGS
#rb acriel.rekman
#rnx
#preflight 625f50f6d41243458717bce1

#ROBOMERGE-AUTHOR: markus.breyer
#ROBOMERGE-SOURCE: CL 19825176 via CL 19826072 via CL 19826094 via CL 19826110
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v940-19807014)

[CL 19834832 by markus breyer in ue5-main branch]
2022-04-20 14:29:48 -04:00
josh adams
95462e7d2a - FIxed loading shader caches from plugins' IOStore files
#rb arciel.rekman
#preflight 625d8938691f49969eab04af

#ROBOMERGE-AUTHOR: josh.adams
#ROBOMERGE-SOURCE: CL 19789816 via CL 19791853 via CL 19791859 via CL 19791865
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v939-19570697)

[CL 19809560 by josh adams in ue5-main branch]
2022-04-19 11:33:37 -04:00
arciel rekman
1c4d80a2ff Chunk PSO cache during the cook (FORT-443978).
- "Build" command of the PSO commandlet will split the cache, generating separate files for each chunk.
- Criterion is whether any shaders of the PSO can be used by the assets in that chunk (including after deduplication).
- Disabled by default because the runtime part to pick up those files isn't in yet.

#rb Allan.Bentham, Dmytro.Vovk
[REVIEW] [at]Allan.Bentham, [at]Pete.Sauerbrei, [at]Chris.Genova, [at]James.Doverspike, [at]Kenzo.TerElst, [at]Dmytro.Vovk
#preflight 62448dc2e434babd8ae73354

#ROBOMERGE-OWNER: arciel.rekman
#ROBOMERGE-AUTHOR: arciel.rekman
#ROBOMERGE-SOURCE: CL 19563493 via CL 19563649 via CL 19563674
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v937-19513599)

[CL 19565457 by arciel rekman in ue5-main branch]
2022-03-30 18:20:37 -04:00
sebastian thomeczek
7ef35c3511 Adjust LogPakFile logging verbosity
- added VeryVerbose message when access to any file from ExcludedNonPakExtensions is prevented
- Introduced new Display message to print mounted pak file name and mount point, moved the corresponding logs that were already printing that information from the shadercodelibrary to verbose
- Moved most FPakReadRequest messages to VeryVerbose
- Moved PrimaryIndexSize PathHashIndexSize and FullDirectoryIndeSize to Verbose
- Moved OnPakFileMounted2Time to Verbose

#rb Matt.Peters, PJ.Kack
#jira none
#preflight 61f00f308c16f837224ada89

#ROBOMERGE-AUTHOR: sebastian.thomeczek
#ROBOMERGE-SOURCE: CL 18722494 in //UE5/Release-5.0/... via CL 18722496 via CL 18722552
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18722570 by sebastian thomeczek in ue5-main branch]
2022-01-25 10:08:12 -05:00
arciel rekman
9a7c807094 Make IoStore-based shader library the default everywhere.
- IoStore-based code archive has significant advantages over the file-based one as it implements shader group compression.
- Also fixed a PC/desktop-specific issue of multiple opens of the library.

#rb CM.Nordin, [at]Ben.Ingram, James.Doverspike
[REVIEW] [at]CarlMagnus.Nordin, [at]Ben.Ingam

#ROBOMERGE-AUTHOR: arciel.rekman
#ROBOMERGE-SOURCE: CL 18691837 via CL 18691933 via CL 18692000 via CL 18692479 via CL 18692746 via CL 18692912
#ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v903-18687472)

[CL 18693178 by arciel rekman in ue5-main branch]
2022-01-21 14:14:42 -05:00
christopher waters
edc2ecf951 Fixing deadlocks on lower core count PCs running DX12.
#jira UE-138111
#rb arciel.rekman

#ROBOMERGE-AUTHOR: christopher.waters
#ROBOMERGE-SOURCE: CL 18591564 via CL 18591779 via CL 18591794 via CL 18592536 via CL 18592562 via CL 18592578
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Test -> Main) (v899-18417669)

[CL 18592583 by christopher waters in ue5-main branch]
2022-01-12 19:46:40 -05:00
arciel rekman
886eaf509b Allocate RHI shader cache on demand (UE-136845).
- Reduces shader memory usage by avoiding upfront allocations, most of which are unused.

#rb Ben.Ingram, Jason.Nadro, Dmitriy.Dyomin, Kevin.Ortegren
[REVIEW] [at]Ben.Ingram, [at]Jason.Nadro, [at]Dmitriy.Dyomin, [at]Kevin.Ortegren
#jira UE-136845

#ROBOMERGE-AUTHOR: arciel.rekman
#ROBOMERGE-SOURCE: CL 18460736 via CL 18462379 via CL 18462501 via CL 18463512 via CL 18463537
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18463549 by arciel rekman in ue5-release-engine-test branch]
2021-12-14 19:15:02 -05:00
arciel rekman
abd87464cd Fix a static code analysis warning in ShaderCodeLibrary.cpp
- Exempted, the warning is bogus.

#rb none

#ROBOMERGE-AUTHOR: arciel.rekman
#ROBOMERGE-SOURCE: CL 18285081 via CL 18285083 via CL 18285085 via CL 18286626 via CL 18286673
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18286712 by arciel rekman in ue5-release-engine-test branch]
2021-11-24 14:11:17 -05:00
aurel cordonnier
fc542f6cfd Merge from Release-Engine-Staging @ 18081189 to Release-Engine-Test
This represents UE4/Main @18073326, Release-5.0 @18081140 and Dev-PerfTest @18045971

[CL 18081471 by aurel cordonnier in ue5-release-engine-test branch]
2021-11-07 23:43:01 -05:00