Commit Graph

54 Commits

Author SHA1 Message Date
sara schvartzman
504aa57ea2 Control Rig: Fix crash when opening rig with corrupted aggregate node
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/640633c5de14c9e34b8ac7e8

[CL 24529317 by sara schvartzman in ue5-main branch]
2023-03-06 15:49:44 -05:00
helge mathee
158a5a86e5 Control Rig: More surgical approach to ControlRigGraphNode::ReconstructNode_Internal
#rb sara.schvartzman
[FYI] halfdan.ingvarsson
#preflight https://horde.devtools.epicgames.com/job/63ff3a58ac6c61e2b5acf1ff

[CL 24462142 by helge mathee in ue5-main branch]
2023-03-01 10:04:44 -05:00
Helge Mathee
e6d731611e Control Rig: Update UI node after creating sub pins
#rb sara.schvartzman
#jira UE-176809
#preflight https://horde.devtools.epicgames.com/job/63fe0bd7ae54ee4ce9a3cd16

[CL 24442606 by Helge Mathee in ue5-main branch]
2023-02-28 10:32:53 -05:00
helge mathee
cff412d97c ControlRig: Deal with assets containing nullptr UEdGraphPin subpins
#rb sara.schvartzman
#preflight https://horde.devtools.epicgames.com/job/63f4dbf9500c05a624a64907

[CL 24344108 by helge mathee in ue5-main branch]
2023-02-21 13:25:23 -05:00
sara schvartzman
672dbc16f8 Control Rig: Fix cannot connect reroute output to another pin (source pin is not an output)
#rb benoit.gadreau
#preflight https://horde.devtools.epicgames.com/job/63efb65890198dffbaf8f1be

[CL 24294093 by sara schvartzman in ue5-main branch]
2023-02-17 18:20:58 -05:00
sara schvartzman
fe0bb4d0b9 Control Rig: Fix binding variable to subpin removes valid pins and ensures
#jira UE-175190
#rb helge.mathee
#swarm https://p4-swarm.epicgames.net/reviews/23870506
#preflight https://horde.devtools.epicgames.com/job/63d2b9e0be1970f882a105da

[CL 23881533 by sara schvartzman in ue5-main branch]
2023-01-27 05:02:44 -05:00
Helge Mathee
7eb666ee61 RigVM: Array Dispatches
#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/639353040236bc17ce9f635f

[CL 23565632 by Helge Mathee in ue5-main branch]
2023-01-03 09:23:55 -05:00
Helge Mathee
131afa1302 RigVM: New control flow Dispatch
#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/638742e6d76995cb14951ee3

[CL 23330412 by Helge Mathee in ue5-main branch]
2022-11-30 10:26:42 -05:00
Helge Mathee
66107e89e7 RigVM: Fixed array pin support for select node
#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/6380ca9f33774509007678b7

[CL 23286221 by Helge Mathee in ue5-main branch]
2022-11-28 03:38:49 -05:00
Helge Mathee
ac962eb5d8 Control Rig: Fix crash during graph profiling
#rb na
#jira na
#preflight https://horde.devtools.epicgames.com/job/637dd730cc307d6fa5f8639a

[CL 23246535 by Helge Mathee in ue5-main branch]
2022-11-23 03:36:10 -05:00
sara schvartzman
f9a4ef98fd Control Rig: Reuse function compilation data
#jira FORT-519929
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/637407fc953c19d435b38d76

[CL 23151594 by sara schvartzman in ue5-main branch]
2022-11-16 03:33:17 -05:00
Helge Mathee
d45bd63bb7 Control Rig: Replace cast link with cast nodes
#rb sara.schvartzman
#jira na
#preflight https://horde.devtools.epicgames.com/job/636503dfde2c4dbb5d92f669

[CL 23008884 by Helge Mathee in ue5-main branch]
2022-11-07 04:27:49 -05:00
Helge Mathee
0c6059e8fe Control Rig: Guard against nullptrs in subpins
#rb na
#jira UE-168034
#preflight https://horde.devtools.epicgames.com/job/6357cb9710505f5393882e41

[CL 22748965 by Helge Mathee in ue5-main branch]
2022-10-25 07:47:30 -04:00
sara schvartzman
a4f0067488 Control Rig: Fix default values not showing up correctly
#jira UE-168188
#rb none
#preflight none

[CL 22748444 by sara schvartzman in ue5-main branch]
2022-10-25 06:09:50 -04:00
Helge Mathee
06171f6e93 Control Rig: Fix sequence node aggregate UI
#rb sara.schvartzman
#jira UE-168030
#preflight https://horde.devtools.epicgames.com/job/6356b4c9f92c325024ebd814

[CL 22748405 by Helge Mathee in ue5-main branch]
2022-10-25 06:00:44 -04:00
sara schvartzman
7ef7471729 Control Rig: Fix Reroute, If, Select, Array nodes not available when pulling from a pin
#jira UE-168032, UE-168033
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/6356b2773a547c3da323b609

[CL 22748352 by sara schvartzman in ue5-main branch]
2022-10-25 05:45:35 -04:00
sara schvartzman
8facd1f53e Control Rig: Inline function bytecode
#jira FORT-519929
#rb helge.mathee
#preflight https://horde.devtools.epicgames.com/job/634edc6d3042441e0f39ca99

[CL 22723244 by sara schvartzman in ue5-main branch]
2022-10-24 08:59:51 -04:00
Helge Mathee
fa274720f6 Control Rig: Fixes for fallout from UI optimizations
#rb sara.schvartzman
#jira UE-167285 UE-167244
#preflight https://horde.devtools.epicgames.com/job/634fd6adac48fa11ed310f59

[CL 22622242 by Helge Mathee in ue5-main branch]
2022-10-19 07:53:01 -04:00
Helge Mathee
630b370f55 Control Rig: UI Graph Performance Improvements
#jira UE-152944
#rb sara.schvartzman
#preflight https://horde.devtools.epicgames.com/job/6346d47cf04e6f85050ea4a2

[CL 22500206 by Helge Mathee in ue5-main branch]
2022-10-13 05:50:41 -04:00
jack cai
9d6ee2889b ControlRig: user defined struct used as function argument can trigger an assertion when one of the member variables change its type
#jira UE-165790
#rb Sara.schvartzman, Helge.mathee
#preflight https://horde.devtools.epicgames.com/job/633b1c006b10157eac5fc7ba

[CL 22336420 by jack cai in ue5-main branch]
2022-10-04 15:24:37 -04:00
bryan sefcik
50d4fac9e0 Updated ../Engine/Plugins/... to inline gen.cpp files
Before:
3548 unity files
Total CPU Time: 47343.578125 s
Total time in Parallel executor: 494.60 seconds

After:
3445 unity files
Total CPU Time: 46044.671875 s
Total time in Parallel executor: 468.51 seconds

#jira
#preflight 63336159b20e73a098b7f24f

[CL 22218213 by bryan sefcik in ue5-main branch]
2022-09-28 01:06:15 -04:00
sara schvartzman
eec59437e9 Control Rig: Collapse nodes with templates
#jira UE-146929
#rb helge.mathee
#preflight 62ced5dbd00f3c208e47c183

[CL 21089290 by sara schvartzman in ue5-main branch]
2022-07-14 06:53:37 -04:00
helge mathee
b3573a03b0 Control Rig: Remove strong dependencies from User interface on data model - use TWeakObejctPtr
#rb rob.millar
#preflight https://horde.devtools.epicgames.com/job/62c6e9bb2823f28cf21e5f45

#ROBOMERGE-AUTHOR: helge.mathee
#ROBOMERGE-SOURCE: CL 20988142 via CL 20988169 via CL 20988205
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 20992713 by helge mathee in ue5-main branch]
2022-07-07 17:00:35 -04:00
Helge Mathee
3d20407084 RigVM: Refactor template type system to rely on integers rather than string comparisons
* Switching the FRigVMTemplateArgumentType to be backed up by FName instead of FString for faster comparison
* Adding a "Types" storage under the RigVMRegistry of all of the known supported types
* Have the FRigVMTemplateArgument refer to type indices rather than full type structures
* Have the resolval comparison code rely on comparing type indices rather than type structures
* Store relationship between the bool and the TArray<bool> type as an array / element lookup within the registry - to avoid string operations when doing lookups from element to array to 2 dimensional array for a type.
* The preferred types list on the template node is now stored as pairs of argument name and type index <FName, int32> rather than FString.
* Also we no longer support all types for the untyped nodes (such as reroute, select, if etc) - but instead we support all user defined types (non-native structs and enums) as well as all types ever used as a template argument. The reasoning here is that supporting a type that's not used by any node is pointless. This reduced the type set from 9876 to 237.

#rb halfdan.ingvarsson
#jira na
#preflight https://horde.devtools.epicgames.com/job/62b9c666ba62f4498a345be2

[CL 20861728 by Helge Mathee in ue5-main branch]
2022-06-28 13:41:23 -04:00
benoit gadreau
c64c1bf314 Fix use of IsChildOf with possible nullptr (cf. CL 20439034)
todo: check for all use of IsChildOf within ControlRig to avoid future issues

#jira UE-155523 UE-155505
#rb halfdan.ingvarsson
#fyi brandon.schaefer
#preflight 6297bd5be809e387be23e44c

[CL 20457493 by benoit gadreau in ue5-main branch]
2022-06-01 15:51:46 -04:00