Commit Graph

26 Commits

Author SHA1 Message Date
Helge Mathee
fbb7b1e70c Control Rig: Perform reroute tracing as part of the inlining pass, clean up unit tests
#rb sara.schvartzman
#jira na

[CL 14771671 by Helge Mathee in ue5-main branch]
2020-11-18 07:48:31 -04:00
Helge Mathee
f4f3d546f9 RigVM: Allow editor only introspection on Register CPP Types and Objects.
#rb jack.cai
#jira na

[CL 14629525 by Helge Mathee in ue5-main branch]
2020-11-02 13:35:21 -04:00
Helge Mathee
9aa62f8a4d Control Rig: Clean up reroute nodes when making bindings from variable node
#rb na
#jira UE-101978

[CL 14597186 by Helge Mathee in ue5-main branch]
2020-10-28 03:33:52 -04:00
Helge Mathee
92ad9cb748 Control Rig: Fix making variable node out of variable binding with segmentpaths
#rb na
#jira na

[CL 14597146 by Helge Mathee in ue5-main branch]
2020-10-28 03:18:50 -04:00
Helge Mathee
21fc6402b0 Control Rig: Rename bUndo to bSetupUndoRedo
#rb na
#jira na
#fyi sara.schvartzman

[CL 14585117 by Helge Mathee in ue5-main branch]
2020-10-27 03:30:51 -04:00
Helge Mathee
f5b12d86b3 UE-93573 Cycle check can fail on rewire
Since a new wire can disconnect an old wire - we need to ignore certain wires when building the map for link validation and cycle checking. With this fix we pass a list of links to ignore (wires to ignore in the graph) to the AST that's going to get build, and then perform cycle checking only with that.

#rb sara.schvartzman
#jira UE-93573

[CL 14577857 by Helge Mathee in ue5-main branch]
2020-10-26 12:29:38 -04:00
Helge Mathee
9040c2513f Control Rig: Support for Variable pin binding
#jira UE-97661 UE-97660
#rb sara.schvartzman

[CL 14572443 by Helge Mathee in ue5-main branch]
2020-10-26 06:51:31 -04:00
Marc Audy
4c1bb11c29 Merge UE5/Release-Engine-Staging to UE5/Main @ 14548662
This represents UE4/Main @ 14525125 + cherrypicked fixes
#skipundocheck

[CL 14551026 by Marc Audy in ue5-main branch]
2020-10-22 19:19:16 -04:00
Helge Mathee
02d72a290f Control Rig: Feature to bind pins to external variables, model + controller work (view todo)
#rb sara.schvartzman
#jira UE-97661

[CL 14531756 by Helge Mathee in ue5-main branch]
2020-10-21 03:46:35 -04:00
Helge Mathee
5e8044db9c First steps for Variable accessors. Added virtual method for FRigVMStruct to react to a node being dropped. Added a context to allow to introspect existing variables, create new variables and bind variables to a pin.
Please review in order

Files under Runtime
Files under Developer
Files under EngineTest

#jira na
#rb sara.schvartzman

[CL 14513356 by Helge Mathee in ue5-main branch]
2020-10-19 08:06:50 -04:00
Jeff Farris
bccbf0ae66 Editgrated 14478375 from Release-4.26 (Control Rig / RigVM: Add alignment for non-intel platforms)
#fyi helge.mathee

[CL 14503002 by Jeff Farris in ue5-main branch]
2020-10-15 13:40:12 -04:00
Marc Audy
50a3d7d368 Merge Release-Engine-Staging to Main @ CL# 14467590
This represents UE4/Main @ 14432125 + some cherrypick fixes

[CL 14468207 by Marc Audy in ue5-main branch]
2020-10-09 22:42:26 -04:00
Marcus Wassmer
3b81cf8201 Merging using //UE5/Main_to_//UE5/Release-Engine-Staging @14384769
autoresolved files
#rb none

[CL 14384911 by Marcus Wassmer in ue5-main branch]
2020-09-24 00:43:27 -04:00
Marc Audy
7379fa99c5 Merging //UE5/Release-Engine-Staging to Main (//UE5/Main) @ 14229157
[CL 14233282 by Marc Audy in ue5-main branch]
2020-09-01 14:07:48 -04:00
brooke hubert
48113fc77e Adding EditorFramework to build.cs files
#rnx
#Jira UE-96448
#rb chris.gagnon

[CL 14114839 by brooke hubert in ue5-main branch]
2020-08-14 13:24:16 -04:00
Marc Audy
11f5b21210 Merging //UE5/Release-Engine-Staging @ 13752110 to Main (//UE5/Main)
#rnx

[CL 13753156 by Marc Audy in ue5-main branch]
2020-06-23 18:40:00 -04:00
helge mathee
86d659f978 Control Rig: Ensure to clean up injected nodes during undo / redo
The injected node action was just calling RemoveNode, which outside of undo / redo does not clean up links. We had some stale / transient nodes due to this in the repro case. By adding an additional argument to force recursion into BreakAllLinks etc this is fixed.

#rb lina.halper
#lockdown laurent.delayen
#jira UE-92035

#ROBOMERGE-SOURCE: CL 12923962 in //UE4/Release-4.25/... via CL 12923974 via CL 12923998
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v682-12900288)

[CL 12924002 by helge mathee in Main branch]
2020-04-20 11:20:47 -04:00
helge mathee
097750f1d2 Control Rig: Rapidly undoing "Add visual debug" causes ensure
#rb trivial
#jira UE-89763

#ROBOMERGE-SOURCE: CL 12672604 in //UE4/Release-4.25/... via CL 12672606 via CL 12672638
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v675-12543919)

[CL 12672663 by helge mathee in Main branch]
2020-04-08 10:20:10 -04:00
helge mathee
494f2a53f6 Control Rig: Re-enable deprecated units for RigVM
#rb na
#jira UE-91550

#ROBOMERGE-SOURCE: CL 12651458 via CL 12651470 via CL 12651471
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v675-12543919)

[CL 12651474 by helge mathee in Main branch]
2020-04-07 04:28:28 -04:00
helge mathee
c56506a1ef Control Rig: Ensure to define missing parameters AFTER initial traverse of AST
#rb na
#jira UE-91550

#ROBOMERGE-SOURCE: CL 12651454 via CL 12651456 via CL 12651459
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v675-12543919)

[CL 12651464 by helge mathee in Main branch]
2020-04-07 04:27:49 -04:00
helge mathee
60a1b432f7 RigVM AST: Moved the lookup from AST Node to Expression Index to a map, since now with nested nodes the Node index itself cannot be relied on.
#rb lina.halper
#jira UE-88252

Merging

//UE4/Dev-Anim/Engine/Source/Developer/RigVMDeveloper/...

to //UE4/Dev-Anim/Engine/Source/Developer/RigVMDeveloper/...

#ROBOMERGE-SOURCE: CL 11498311 in //UE4/Release-4.25/...
#ROBOMERGE-BOT: RELEASE (Release-4.25 -> Release-4.25Plus) (v654-11333218)

[CL 11498330 by helge mathee in 4.25-Plus branch]
2020-02-18 09:32:18 -05:00
helge mathee
b7c3bfa7cc Instead of accessing sub array elements on a default struct we create a new structonscope for the inner property and use that instead. The array property might be empty - so relying on that isn't stable and can cause crashes as hit in UE-88394
#rb lina.halper
#jira UE-88394

Merging

//UE4/Dev-Anim/Engine/Source/Developer/RigVMDeveloper/Private/RigVMModel/RigVMController.cpp

to //UE4/Release-4.25/Engine/Source/Developer/RigVMDeveloper/Private/RigVMModel/RigVMController.cpp

#ROBOMERGE-SOURCE: CL 11498307 in //UE4/Release-4.25/...
#ROBOMERGE-BOT: RELEASE (Release-4.25 -> Release-4.25Plus) (v654-11333218)

[CL 11498326 by helge mathee in 4.25-Plus branch]
2020-02-18 09:32:14 -05:00
helge mathee
223157a801 Control Rig: Fix error log for UE-88390
#jira UE-88390
#rb na

Merging

//UE4/Dev-Anim/Engine/Source/Developer/RigVMDeveloper/Private/RigVMModel/RigVMController.cpp

to //UE4/Dev-Anim/Engine/Source/Developer/RigVMDeveloper/Private/RigVMModel/RigVMController.cpp

#ROBOMERGE-SOURCE: CL 11498280 in //UE4/Release-4.25/...
#ROBOMERGE-BOT: RELEASE (Release-4.25 -> Release-4.25Plus) (v654-11333218)

[CL 11498293 by helge mathee in 4.25-Plus branch]
2020-02-18 09:30:55 -05:00
Thomas Sarkanen
de2be528ca Copying //UE4/Dev-Anim to Dev-Main (//UE4/Dev-Main)
#rb none
#lockdown nick.penwarden

[CL 11214797 by Thomas Sarkanen in Main branch]
2020-02-04 11:06:23 -05:00
Helge Mathee
b8106b68b1 Incremental Static Analysis Win64 (MSVC) - Warning: Dereferencing NULL pointer Property in rigvmcontroller.cpp
#rb na
#jira UE-87400

[CL 11152217 by Helge Mathee in Main branch]
2020-01-29 03:07:54 -05:00