The issue was that the code that captures screenshots on a device and sends them to the editor was providing a path that represented what a screenshot *would* be saved at on the local system. (The screenshot was not actually saved, it's returned as raw data in the message).
This meant that the editor would try to convert this to a relative path for its needs which would fail as the the path roots were differenti (e.g. g:\settings\ on xbox).
The fixes here are -
1) Add some warnings to the code that tries to save screenshots if that fails
2) Change the names of the screenshot functions in AutomationCommon to clarify what they should be used for.
3) Change the 'path' variable in the message to screenshot name.
4) Calculate the path to use for screenshots on the editor.
#tests ran EngineTest on WIn64, PS4, and XboxOne (which now passes).
#jira UE-69399
#rb swarm
[CL 11733277 by Andrew Grant in 4.25 branch]
This allows enabling crash reporter client to run in monitor mode for game runtimes again.
#jira UE-89418
#rb steve.robb
[CL 11726679 by Johan Berg in 4.25 branch]
In some scenarios when copying the shared crash context the engine would overrun the fixed size string buffer. This issue appeared after two ensures fired, since the dynamic string buffers lifetime was equal to the crash reporting thread, and only reset on initialization.
#jira UE-89180
#rb pj.kack
#ushell-cherrypick of 11586607 by Johan.Berg
[CL 11601293 by Johan Berg in 4.25 branch]
- Apply IntelTBB-4.4u3 Priority Inversion patch from CL 3984773 (Jeff.Rous)
- Apply IntelTBB-4.4u3 ARM64 patch from CL 5420065 (Jackson.Fields)
- Verified IntelTBB-4.0 reallocAligned and internalMsize patch was present CL 2605187 (James.Moran)
- Compile ARM binaries for Hololens
- Compile Mac binaries
- Add tbb/tbb_debug dynamic libraries (used by OpenVDB)
- OpenVDB now references tbb/tbb_debug from the official Thirdparty folder
- Recompile OpenVDB
- Update .tps for new Apache 2.0 License
- Remove all old versions
From dev-enterprise@11303005
#jira UEENT-3378
#rb Steve.Robb, David.Hill, Michael.Trepka
[CL 11586698 by danny couture in 4.25 branch]
Initialize unused TBitArray bits, switch to faster unsigned operator% and don't shrink past initial allocation size
operator<, == and GetTypedHash() would access unused bits in the last word
#rb steve.robb
#robomerge[core] -core
#jira UE-88991
#ushell-cherrypick of 11575339 by Johan.Torp
[CL 11575479 by Johan Torp in 4.25 branch]
Add OnEnginePreExit() delegate to core delegates. This delegate is fired off before closing out the AssetTools, WorldBrowser and AssetRegistry modules, for handling shutdown tasks that would require these.
#jira UE-88976
#rb stefan.boberg
[CL 11565142 by nicholas goldstein in 4.25 branch]
Disabling on demand symbol loading due to issue where modules that are not in the main binary directory would not have symbols loaded correctly. This manifested as "UnknownFunction" entries in the logged stack trace. Crash reports were not affected since they are done externally.
#rb none
#jira UE-89027
#lockdown stefan.boberg
#ushell-cherrypick of 11374202 by Johan.Berg
#ushell-cherrypick of 11458974 by Johan.Berg
[CL 11536318 by Johan Berg in 4.25 branch]
[FYI] Paul.Chipchase,Ben.Marsh
#rb bob.tellez
#jira UE-87834
#ROBOMERGE-SOURCE: CL 11462958 via CL 11462978 via CL 11463000
#ROBOMERGE-BOT: (v654-11333218)
#ushell-cherrypick of 11463012 by bob.tellez
[CL 11535966 by paul chipchase in 4.25 branch]
Fix to the assignment operator of an array-based TUniquePtr with a different deleter.
Unification of constructor syntax.
#jira UECORE-507
#rb james.hopkin
#fyi ryan.gerleve
[CL 11535694 by Steve Robb in 4.25 branch]
[Switch] MemPro Platform Extension fixes
- fixing some issues that arose from the latest stream copy-up
#jira UE-81798, UE-88713
#rb none
#rnx
[CL 11447572 by brian white in 4.25 branch]
#jira none
#rb Steve.Robb, Zousar.Shaker
#ROBOMERGE-SOURCE: CL 11422924 via CL 11422962 via CL 11422980
#ROBOMERGE-BOT: (v654-11333218)
#ushell-cherrypick of 11422992 by devin.doucette
[CL 11445474 by devin doucette in 4.25 branch]
#jira none
#rb Steve.Robb, Zousar.Shaker
#ROBOMERGE-SOURCE: CL 11422909 via CL 11422921 via CL 11422928
#ROBOMERGE-BOT: (v654-11333218)
#ushell-cherrypick of 11422942 by devin.doucette
[CL 11445469 by devin doucette in 4.25 branch]
