Commit Graph

741 Commits

Author SHA1 Message Date
bryan sefcik
8cc129f2b6 IWYU Pass 1 - Engine/Source/Editor/...
#jira
#preflight 6306736ac85b7fef22be7751

[CL 21558583 by bryan sefcik in ue5-main branch]
2022-08-24 22:45:13 -04:00
scott nelson
e8f45f5813 AssetPrivatizeModel and Dialogue
#rb Lauren.Barnes, Brooke.Hubert, Julien.StJean
#preflight 6303b55ca45b007ea246007d

[CL 21511558 by scott nelson in ue5-main branch]
2022-08-23 12:52:04 -04:00
sebastian nordgren
2af3f1eb9d Typing a character while the asset picker menu is open will now focus the search box if it is not already focused, such as if you've dragged the scrollbar.
#review-21440564 @ lauren.barnes
#jira UE-158283
#preflight 63049778a45b007ea26af9b7

[CL 21503667 by sebastian nordgren in ue5-main branch]
2022-08-23 05:12:57 -04:00
aditya ravichandran
c653fe23c3 Outliner: Add a filter bar and the ability to save searches as filters
#jira UE-157474
#rb Lauren.Barnes
#preflight 62ffae747d17941e9f8c9104

[CL 21499949 by aditya ravichandran in ue5-main branch]
2022-08-22 21:23:04 -04:00
aditya ravichandran
1be2c72ef4 Content Browser: Add a minimum size for the vertical filters
#rb lauren.barnes
#preflight skip

[CL 21467985 by aditya ravichandran in ue5-main branch]
2022-08-19 19:27:19 -04:00
brandon boswell
34593b68b0 Back out changelist 21341433
#ROBOMERGE-AUTHOR: brandon.boswell
#ROBOMERGE-SOURCE: CL 21345998 via CL 21346033 via CL 21346055 via CL 21346058 via CL 21346071
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21347285 by brandon boswell in ue5-main branch]
2022-08-11 18:40:42 -04:00
aditya ravichandran
11c5fa9709 SFilterList: Temporarily disable saving/loading of filters using EditorConfig to fix a crash when docking the Content Drawer
[REVIEW] [at]lauren.barnes
#preflight 62f539197c66d5539e985394

#localization none
#tests Tested the repro on the JIRA to dock the Content Drawer - no crash. Tested adding filters to the Content Browser and closing and reopening it - no crash and filters are lost because saving is disabled.
#preferred_whitelister stan.hormell

#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 21341433 via CL 21341437 via CL 21341459 via CL 21341475 via CL 21341494
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21343264 by aditya ravichandran in ue5-main branch]
2022-08-11 15:54:50 -04:00
jeanmichel dignard
fdad9840be Content Browser
- Fixed the Other Developers frontend filter not working when the All folder is being showned.
- Converted the virtual paths to internal paths before checking against the base developers folder.

#jira UE-160329
#preflight 62f3ffeb7e472cbf79489198
#rb rex.hill

#ROBOMERGE-AUTHOR: jeanmichel.dignard
#ROBOMERGE-SOURCE: CL 21325015 via CL 21325245 via CL 21325345
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21327998 by jeanmichel dignard in ue5-main branch]
2022-08-10 18:18:39 -04:00
aditya ravichandran
ff9486e0c3 SAssetView: Change the column view to have a similar wokflow to other column views in the editor (like the Outliner)
#jira UE-155868
#rb lauren.barnes
#preflight 62d6d0b81133256db6e4b244

[CL 21163521 by aditya ravichandran in ue5-main branch]
2022-07-19 12:05:48 -04:00
aditya ravichandran
05af8310f1 Content Browser: Move Filter Display section to the Settings Cog
#rb lauren.barnes
#preflight 62d1b6d7af68cd745b7df5f7

#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 21116127 via CL 21119883 via CL 21119900 via CL 21120252
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21142569 by aditya ravichandran in ue5-main branch]
2022-07-17 22:49:02 -04:00
jason stasik
ce3cf77a50 Allow actors to change which asset they Browse to
Allow browsing to aliases if source asset is not visible
Allow aliases in collections
#rb dave.belanger,jamie.dale
#preflight 62d0b1ad8e4b379590da3397

#ROBOMERGE-AUTHOR: jason.stasik
#ROBOMERGE-SOURCE: CL 21115320 via CL 21115363 via CL 21115394 via CL 21115412 via CL 21115431
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21142427 by jason stasik in ue5-main branch]
2022-07-17 22:42:48 -04:00
bryan sefcik
435d89dea4 Manually updated a few files in Engine/Source/Editor/... to include some headers that were found to be missing after running IWYU.
#preflight 62cdac5084556536d0e57c64

[CL 21058996 by bryan sefcik in ue5-main branch]
2022-07-12 13:45:01 -04:00
aditya ravichandran
00156fb4c6 Content Browser: Fix a bug where you could have duplicate filters in the filter bar, and fix a regression where docking the Content Drawer would discard all the active filters
#jira UE-157471
#rb lauren.barnes
#preflight 62c45cf8f514983340a5546b

#ROBOMERGE-OWNER: aditya.ravichandran
#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 20944747 via CL 20968283 via CL 20969232 via CL 20970255
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 20973722 by aditya ravichandran in ue5-main branch]
2022-07-06 17:14:38 -04:00
aditya ravichandran
3a86dab377 Content Browser: Add an alternate vertical filter layout
Remove the overflow menu and add wrapping for fiters in the horizontal layout
#jira UE-157471
#preflight 62bf1391d94b57687c7f3395
#rb Lauren.Barnes

#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 20918175 via CL 20919826 via CL 20920342 via CL 20920507
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20923421 by aditya ravichandran in ue5-main branch]
2022-07-01 19:42:46 -04:00
aditya ravichandran
6ef1ff7798 Content Browser: Add the ability to save searches as filters, port the config over to EditorConfig for SFilterList
SFilterBar: Update search saving to use an independant interface and move FFilterBarBase to SAssetFilterBar
#jira UE-157471
#rb lauren.barnes, julien.stjean
#preflight 62b5dd23466962cd9a12fa8d

#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 20812033 via CL 20863311 via CL 20866578 via CL 20866617
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)

[CL 20876840 by aditya ravichandran in ue5-main branch]
2022-06-29 12:25:34 -04:00
jason stasik
e196bf65f5 Increase CB description width to 700
#rb lauren.barnes
#preflight 62aceb9ac0449d3dccd971dd

#ROBOMERGE-AUTHOR: jason.stasik
#ROBOMERGE-SOURCE: CL 20711985 via CL 20712000 via CL 20712077 via CL 20712711
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v970-20704180)

[CL 20732639 by jason stasik in ue5-main branch]
2022-06-19 23:40:28 -04:00
dave belanger
b1c525af2b Move implementation of FContentBrowserVirtualPathTree::GetMountPointFromPath to FPathViews
#rb Rex.Hill
#preflight 62accbcdc0449d3dccd56ac1

#ROBOMERGE-AUTHOR: dave.belanger
#ROBOMERGE-SOURCE: CL 20709056 via CL 20709527 via CL 20709609 via CL 20709671
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v970-20704180)

[CL 20732589 by dave belanger in ue5-main branch]
2022-06-19 23:39:22 -04:00
aditya ravichandran
efbd98a46f SFilterBar: Add the ability to save the current set of filters in a config file
#jira UE-151903
#preflight 62a8e87fd502a554368de197
#rb lauren.barnes

#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 20669240 via CL 20670228 via CL 20670242 via CL 20670258
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v955-20579017)

[CL 20672011 by aditya ravichandran in ue5-main branch]
2022-06-15 12:39:31 -04:00
jamie dale
2b6fad0ae2 Treat generated class assets as immutable
#rb Rex.Hill, Jason.Stasik
#rnx

#ROBOMERGE-OWNER: jamie.dale
#ROBOMERGE-AUTHOR: jamie.dale
#ROBOMERGE-SOURCE: CL 20627582 via CL 20627615 via CL 20627698 via CL 20627704
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v955-20579017)

[CL 20636216 by jamie dale in ue5-main branch]
2022-06-13 18:36:10 -04:00
scott nelson
2bacfef2b4 Fix issue where ContentBrowserDrawer is not marked as the primary content browser when selected in ChooseNewPrimaryBrowser
#rb Rex.Hill
#preflight 629ffa956a65c1f49f39e41e

#ROBOMERGE-AUTHOR: scott.nelson
#ROBOMERGE-SOURCE: CL 20559968 via CL 20559996 via CL 20560031 via CL 20561397 via CL 20561550
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v954-20466795)

[CL 20565265 by scott nelson in ue5-main branch]
2022-06-08 17:47:20 -04:00
jason stasik
fd9e52868c Add CVars to hide CB and EditorPrefs buttons
#rb none
#preflight 629e82796e36d50d0526d906

#ROBOMERGE-AUTHOR: jason.stasik
#ROBOMERGE-SOURCE: CL 20531162 via CL 20531172 via CL 20531185 via CL 20531322 via CL 20531447
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v954-20466795)

[CL 20532312 by jason stasik in ue5-main branch]
2022-06-06 22:26:15 -04:00
aditya ravichandran
29e05ea283 Fix a bug with the animation browser where sound assets would always show up.
SFilterList: Use the AddFilter() function to add extra filters to make sure the activation helper gets bound and inverse filters are handled properly.

#jira UE-154474
#preflight 6296225bfe779f23c8e3c9c7
#rb lauren.barnes

#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 20437413 via CL 20438847 via CL 20439153 via CL 20439227
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448728 by aditya ravichandran in ue5-main branch]
2022-06-01 03:56:36 -04:00
robert manuszewski
d1443992e1 Deprecating ANY_PACKAGE.
This change consists of multiple changes:

Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used  in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values

AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes

Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names

#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32

#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786

#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)

[CL 20448496 by robert manuszewski in ue5-main branch]
2022-06-01 03:46:59 -04:00
paul chipchase
d47a75be71 Restore the 'virtualized data' filter that was removed in CL 20340436
#rb aditya.ravichandran
#rnx
#preflight 628e2d4beb57f851e2261683

[CL 20363963 by paul chipchase in ue5-main branch]
2022-05-25 09:59:13 -04:00
bob tellez
c24eefba8a FilterBar: Fix deprecation warnings when including AssetFilter.h
#preflight skip
#rb trivial

#ROBOMERGE-OWNER: bob.tellez
#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 20339304 via CL 20339470 via CL 20339741 via CL 20339759
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v948-20297126)

[CL 20341215 by bob tellez in ue5-main branch]
2022-05-23 19:09:18 -04:00