[REVIEW] [at]lauren.barnes
#preflight 62f539197c66d5539e985394
#localization none
#tests Tested the repro on the JIRA to dock the Content Drawer - no crash. Tested adding filters to the Content Browser and closing and reopening it - no crash and filters are lost because saving is disabled.
#preferred_whitelister stan.hormell
#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 21341433 via CL 21341437 via CL 21341459 via CL 21341475 via CL 21341494
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)
[CL 21343264 by aditya ravichandran in ue5-main branch]
- Fixed the Other Developers frontend filter not working when the All folder is being showned.
- Converted the virtual paths to internal paths before checking against the base developers folder.
#jira UE-160329
#preflight 62f3ffeb7e472cbf79489198
#rb rex.hill
#ROBOMERGE-AUTHOR: jeanmichel.dignard
#ROBOMERGE-SOURCE: CL 21325015 via CL 21325245 via CL 21325345
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)
[CL 21327998 by jeanmichel dignard in ue5-main branch]
Allow browsing to aliases if source asset is not visible
Allow aliases in collections
#rb dave.belanger,jamie.dale
#preflight 62d0b1ad8e4b379590da3397
#ROBOMERGE-AUTHOR: jason.stasik
#ROBOMERGE-SOURCE: CL 21115320 via CL 21115363 via CL 21115394 via CL 21115412 via CL 21115431
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)
[CL 21142427 by jason stasik in ue5-main branch]
Remove the overflow menu and add wrapping for fiters in the horizontal layout
#jira UE-157471
#preflight 62bf1391d94b57687c7f3395
#rb Lauren.Barnes
#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 20918175 via CL 20919826 via CL 20920342 via CL 20920507
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)
[CL 20923421 by aditya ravichandran in ue5-main branch]
SFilterBar: Update search saving to use an independant interface and move FFilterBarBase to SAssetFilterBar
#jira UE-157471
#rb lauren.barnes, julien.stjean
#preflight 62b5dd23466962cd9a12fa8d
#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 20812033 via CL 20863311 via CL 20866578 via CL 20866617
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v971-20777995)
[CL 20876840 by aditya ravichandran in ue5-main branch]
#rb Rex.Hill
#preflight 629ffa956a65c1f49f39e41e
#ROBOMERGE-AUTHOR: scott.nelson
#ROBOMERGE-SOURCE: CL 20559968 via CL 20559996 via CL 20560031 via CL 20561397 via CL 20561550
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v954-20466795)
[CL 20565265 by scott nelson in ue5-main branch]
#rb none
#preflight 629e82796e36d50d0526d906
#ROBOMERGE-AUTHOR: jason.stasik
#ROBOMERGE-SOURCE: CL 20531162 via CL 20531172 via CL 20531185 via CL 20531322 via CL 20531447
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v954-20466795)
[CL 20532312 by jason stasik in ue5-main branch]
SFilterList: Use the AddFilter() function to add extra filters to make sure the activation helper gets bound and inverse filters are handled properly.
#jira UE-154474
#preflight 6296225bfe779f23c8e3c9c7
#rb lauren.barnes
#ROBOMERGE-AUTHOR: aditya.ravichandran
#ROBOMERGE-SOURCE: CL 20437413 via CL 20438847 via CL 20439153 via CL 20439227
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)
[CL 20448728 by aditya ravichandran in ue5-main branch]
This change consists of multiple changes:
Core:
- Deprecation of ANY_PACKAGE macro. Added ANY_PACKAGE_DEPRECATED macro which can still be used for backwards compatibility purposes (only used in CoreUObject)
- Deprecation of StaticFindObjectFast* functions that take bAnyPackage parameter
- Added UStruct::GetStructPathName function that returns FTopLevelAssetPath representing the path name (package + object FName, super quick compared to UObject::GetPathName) + wrapper UClass::GetClassPathName to make it look better when used with UClasses
- Added (Static)FindFirstObject* functions that find a first object given its Name (no Outer). These functions are used in places I consider valid to do global UObject (UClass) lookups like parsing command line parameters / checking for unique object names
- Added static UClass::TryFindType function which serves a similar purpose as FindFirstObject however it's going to throw a warning (with a callstack / maybe ensure in the future?) if short class name is provided. This function is used in places that used to use short class names but now should have been converted to use path names to catch any potential regressions and or edge cases I missed.
- Added static UClass::TryConvertShortNameToPathName utility function
- Added static UClass::TryFixShortClassNameExportPath utility function
- Object text export paths will now also include class path (Texture2D'/Game/Textures/Grass.Grass' -> /Script/Engine.Texture2D'/Game/Textures/Grass.Grass')
- All places that manually generated object export paths for objects will now use FObjectPropertyBase::GetExportPath
- Added a new startup test that checks for short type names in UClass/FProperty MetaData values
AssetRegistry:
- Deprecated any member variables (FAssetData / FARFilter) or functions that use FNames to represent class names and replaced them with FTopLevelAssetPath
- Added new member variables and new function overloads that use FTopLevelAssetPath to represent class names
- This also applies to a few other modules' APIs to match AssetRegistry changes
Everything else:
- Updated code that used ANY_PACKAGE (depending on the use case) to use FindObject(nullptr, PathToObject), UClass::TryFindType (used when path name is expected, warns if it's a short name) or FindFirstObject (usually for finding types based on user input but there's been a few legitimate use cases not related to user input)
- Updated code that used AssetRegistry API to use FTopLevelAssetPaths and USomeClass::StaticClass()->GetClassPathName() instead of GetFName()
- Updated meta data and hardcoded FindObject(ANY_PACKAGE, "EEnumNameOrClassName") calls to use path names
#jira UE-99463
#rb many.people
[FYI] Marcus.Wassmer
#preflight 629248ec2256738f75de9b32
#codereviewnumbers 20320742, 20320791, 20320799, 20320756, 20320809, 20320830, 20320840, 20320846, 20320851, 20320863, 20320780, 20320765, 20320876, 20320786
#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 20430220 via CL 20433854 via CL 20435474 via CL 20435484
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v949-20362246)
[CL 20448496 by robert manuszewski in ue5-main branch]