Commit Graph

509 Commits

Author SHA1 Message Date
benjamin fox
57011b5f32 Disable Pin Value Inspection Tooltips for Pose Pins in AnimBPs
#jira UE-136038
#rb ben.hoffman
#preflight 61d4b8bad17842e547ab783d

#ROBOMERGE-AUTHOR: benjamin.fox
#ROBOMERGE-SOURCE: CL 18512890 in //UE5/Release-5.0/... via CL 18512942
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18512978 by benjamin fox in ue5-release-engine-test branch]
2022-01-04 16:30:54 -05:00
bob tellez
f3eba66899 #UE4 Add more info to an assert
#ROBOMERGE-AUTHOR: bob.tellez
#ROBOMERGE-SOURCE: CL 18476381 via CL 18477404 via CL 18477469 via CL 18477893 via CL 18481497
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18481767 by bob tellez in ue5-release-engine-test branch]
2021-12-16 19:52:49 -05:00
thomas sarkanen
9e7c191aca Anim blueprint editor modes now display transform toolbar
Deferred to the active editor modes when determining transform toolbar visibility
Updated existing edit modes to correctly update their available widget modes

#rb Nick.Brett
#preflight 61ba0002590498f205a19fb2

#ROBOMERGE-AUTHOR: thomas.sarkanen
#ROBOMERGE-SOURCE: CL 18467669 via CL 18467672 via CL 18467673 via CL 18468089 via CL 18468141
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v899-18417669)

[CL 18468161 by thomas sarkanen in ue5-release-engine-test branch]
2021-12-15 12:17:40 -05:00
Marc Audy
f512a6d461 Eliminate whitespace only differences between Release-Engine-Staging and Release-Engine-Test
#fyi Aurel.Cordonnier

[CL 18448630 by Marc Audy in ue5-release-engine-test branch]
2021-12-13 15:59:48 -05:00
thomas sarkanen
fff3c9141f Added anim node data flags to reduce overhead introduced by anim node functions
Now we dont have to fetch the data out of folded constants to determine that it is invalid

#jira UE-130378 - Optimization pass on new UE5 anim node features
#rb Martin.Wilson
#preflight 61b758e3fc57089133808370

#ROBOMERGE-AUTHOR: thomas.sarkanen
#ROBOMERGE-SOURCE: CL 18443507 in //UE5/Release-5.0/... via CL 18445092
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v897-18405271)

[CL 18445251 by thomas sarkanen in ue5-release-engine-test branch]
2021-12-13 13:34:59 -05:00
thomas sarkanen
a60e7b2a87 Fix crash when selecting property access chains involving structs with native break functions
#jira UE-137312 - check() when accessing x/y/z of a vector with Property Access
#rb Martin.Wilson
#preflight 61b758b3c65177a674657e6d

#ROBOMERGE-AUTHOR: thomas.sarkanen
#ROBOMERGE-SOURCE: CL 18443429 in //UE5/Release-5.0/... via CL 18445080
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v897-18405271)

[CL 18445245 by thomas sarkanen in ue5-release-engine-test branch]
2021-12-13 13:34:38 -05:00
nick brett
fe791cd3bd [FIX] Crash when exiting anim graph editor - removeing call to ExitMode from Exit function as Exit is called from within the owning objects dtor but ExitMode calls v-function on owning object which is unsafe
[REVIEW] [at]thomas.sarkanen
#preflight 61a8afeaca183f8de48a8107

#ROBOMERGE-AUTHOR: nick.brett
#ROBOMERGE-SOURCE: CL 18351791 via CL 18353515 via CL 18353622 via CL 18434113 via CL 18435455
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v897-18405271)

[CL 18436220 by nick brett in ue5-release-engine-test branch]
2021-12-10 18:30:52 -05:00
nick brett
357c0294c4 Reinstate code that was removed in CL-18260151 to fix a bad merge
[REVIEW] [at]thomas.sarkanen

#ROBOMERGE-AUTHOR: nick.brett
#ROBOMERGE-SOURCE: CL 18351800 via CL 18351804 via CL 18434108 via CL 18435450
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v897-18405271)

[CL 18435929 by nick brett in ue5-release-engine-test branch]
2021-12-10 18:10:49 -05:00
thomas sarkanen
b506cf5727 Fix crash selecting linked anim layer class
Prevent filtering and selection of anim blueprints with incompatible/null skeletons, depending on context.
Additionally prevents non-template anim blueprints from being selected within templates and adds compile-time checks for compatibilty

#jira UE-136082 - Crash when clicking on the dropdown next to Instance Class in the Linked Anim Layer node settings
#rb Keith.Yerex
#preflight 61b092e55c61dba07bf10535

#ROBOMERGE-AUTHOR: thomas.sarkanen
#ROBOMERGE-SOURCE: CL 18404540 in //UE5/Release-5.0/... via CL 18404541
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v896-18170469)

[CL 18404555 by thomas sarkanen in ue5-release-engine-test branch]
2021-12-08 06:43:16 -05:00
thomas sarkanen
45b9547da9 Anim blueprints now dont participate in unneeded dependency compilation
This is because dependent BPs at least need a re-link to pick up layout changes in their property access 'bytecode'.

The also requires some re-arranging of where sparse class data gets created, linked and patched.
 - Previously sparse class data was patched in the linker at the point of re-creation, but this meant that stale TRASHCLASS sparse class data was could still be in the struct hierarchy when we are BATCH compiling (when batch compiling, each compilation phase is performed in turn for all compiling/dependent BPs). This change removes the sparse class data when the class is sanitized prior to full compilation and stashes it for later patching. This ensures that sparse class data doesnt get linked into stale structs that can then get GCed later, invalidating property links.
- Sparse class data is now linked when its containing ABPGC is linked. It also ensures that the hierarchy of sparse class data mirrors that of the ABPGC. The 'mirror hierarchy' is currently only an invariant of anim blueprints.

Part of this change alters the behavior of UClass::SetSparseClassDataStruct when passed a NULL value. This will now ensure that subclasses are left in a valid state when this occurs. Previously if sparse class data was nulled-out, subclasses would be left pointing at a potentially stale struct in the case where the struct was being regenerated.

Added an override point for subsystems to participate in Link() and made sure property access offsets are patched there, to catch cases where dependent BPs get either a bytecode-only or link-only compile

#jira UE-136035 - Unexpected results from Property Access after changing Lyra animbp
#jira UE-130965 - Multiple crashes involving anim BP sparse class data, inheritance & GC
#rb Phillip.Kavan,Matt.Peters
#preflight 61af321f470c73a8c4933ff5

#ROBOMERGE-AUTHOR: thomas.sarkanen
#ROBOMERGE-SOURCE: CL 18393342 in //UE5/Release-5.0/... via CL 18393349
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v896-18170469)

[CL 18393353 by thomas sarkanen in ue5-release-engine-test branch]
2021-12-07 05:32:13 -05:00
jose villarroel
55b6426a6b Fix for blend masks not being added when adding input pins to the layered blend per bone node
#jira none
[at]Thomas.Sarkanen, [at]Koray.Hagen
#preflight 619e5a1eaa4521f9e7bb2592
#rnx

#ROBOMERGE-AUTHOR: jose.villarroel
#ROBOMERGE-SOURCE: CL 18326403 in //UE5/Release-5.0/... via CL 18326431
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18326457 by jose villarroel in ue5-release-engine-test branch]
2021-11-30 12:15:54 -05:00
jose villarroel
95dd318cea Added Animation State Machine Library for common helper functions used in anim node functions:
*Added IsStateBlendingIn/Out to library
#jira none
[at]Thomas.Sarkanen, [at]Koray.Hagen
#preflight 619eab6488439fccfeab1615

#ROBOMERGE-AUTHOR: jose.villarroel
#ROBOMERGE-SOURCE: CL 18326309 in //UE5/Release-5.0/... via CL 18326338
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18326360 by jose villarroel in ue5-release-engine-test branch]
2021-11-30 12:12:43 -05:00
lucas dower
f5ebc5a62b Node compiler warning for experimental anim node
#jira UE-135338
#rb Thomas.Sarkanen
#preflight 619fb50caa4521f9e7e2f611

#ROBOMERGE-AUTHOR: lucas.dower
#ROBOMERGE-SOURCE: CL 18295417 in //UE5/Release-5.0/... via CL 18295427
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18295434 by lucas dower in ue5-release-engine-test branch]
2021-11-25 12:08:42 -05:00
thomas sarkanen
fe48b98e94 Fixed null blendspaces being referenced by child anim BPs that use blendspace graphs
Ensure that RF_Public is set so that external packages (like child BPs) can access the sub-object

#jira UE-135892 - Crash after adding child blueprint class of parent Animation BP class
#rb Jurre.deBaare
#preflight 619f9c3bb55894aa746b6c4b

#ROBOMERGE-AUTHOR: thomas.sarkanen
#ROBOMERGE-SOURCE: CL 18294806 in //UE5/Release-5.0/... via CL 18294808
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18294815 by thomas sarkanen in ue5-release-engine-test branch]
2021-11-25 10:44:14 -05:00
lucas dower
9d3cb8136b Added 'Pose Watch Manager' and other pose watch improvements
#rb Thomas.Sarkanen
#preflight 619e6b3f0141b3c6da60ae1d
#jira UE-127674

#ROBOMERGE-AUTHOR: lucas.dower
#ROBOMERGE-SOURCE: CL 18285294 in //UE5/Release-5.0/... via CL 18285317
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18285320 by lucas dower in ue5-release-engine-test branch]
2021-11-24 12:24:41 -05:00
jose villarroel
e5f1174ec4 Allow conduits to be used as entry states in animation state machines
#jira none
[at]Thomas.Sarkanen, [at]Koray.Hagen
#preflight 619d07da810f5e07a378f6d6

#ROBOMERGE-AUTHOR: jose.villarroel
#ROBOMERGE-SOURCE: CL 18271526 in //UE5/Release-5.0/... via CL 18271560
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18271579 by jose villarroel in ue5-release-engine-test branch]
2021-11-23 12:09:54 -05:00
thomas sarkanen
d9d8fc91ed Fix crash compiling child anim BPs with certain configurations
Copy mutable data (in the same way as constant data) to ensure that child class containers are coorectly initialized

#jira UE-135480 - Crash compiling child anim BP with invalid mutable data
#rb Jurre.deBaare
#preflight 619cbaaa801b361978a544d8

#ROBOMERGE-AUTHOR: thomas.sarkanen
#ROBOMERGE-SOURCE: CL 18268116 in //UE5/Release-5.0/... via CL 18268125
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18268128 by thomas sarkanen in ue5-release-engine-test branch]
2021-11-23 05:26:00 -05:00
aurel cordonnier
b0bef131bf Fixing bad merge
[FYI] nick.brett

#ROBOMERGE-AUTHOR: aurel.cordonnier
#ROBOMERGE-SOURCE: CL 18260151 via CL 18260168 via CL 18263329 via CL 18263509
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18263561 by aurel cordonnier in ue5-release-engine-test branch]
2021-11-22 16:46:12 -05:00
nick brett
8008a20f21 [UE][FEATURE] Support render of multiple selected nodes in Anim Graph Editor Viewport
#rb [at]phillip.kavan, [at]thomas.sarkanen, [at]paul.mclaurin
[FYI] [at]charles.anderson
#preflight 619b71741806a2425913e15c

#ROBOMERGE-AUTHOR: nick.brett
#ROBOMERGE-SOURCE: CL 18256465 via CL 18256468 via CL 18256470 via CL 18263298 via CL 18263370
#ROBOMERGE-BOT: STARSHIP (Release-Engine-Staging -> Release-Engine-Test) (v895-18170469)

[CL 18263520 by nick brett in ue5-release-engine-test branch]
2021-11-22 16:44:42 -05:00
Marc Audy
0c3be2b6ad Merge Release-Engine-Staging to Test @ CL# 18240298
[CL 18241953 by Marc Audy in ue5-release-engine-test branch]
2021-11-18 14:37:34 -05:00
aurel cordonnier
fc542f6cfd Merge from Release-Engine-Staging @ 18081189 to Release-Engine-Test
This represents UE4/Main @18073326, Release-5.0 @18081140 and Dev-PerfTest @18045971

[CL 18081471 by aurel cordonnier in ue5-release-engine-test branch]
2021-11-07 23:43:01 -05:00
aurel cordonnier
a6e741e007 Merge from Release-Engine-Staging @ 17915896 to Release-Engine-Test
This represents UE4/Main @17911760, Release-5.0 @17915875 and Dev-PerfTest @17914035

[CL 17918595 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-25 20:05:28 -04:00
aurel cordonnier
a12d56ff31 Merge from Release-Engine-Staging @ 17791557 to Release-Engine-Test
This represents UE4/Main @17774255, Release-5.0 @17791557 and Dev-PerfTest @17789485

[CL 17794212 by aurel cordonnier in ue5-release-engine-test branch]
2021-10-12 21:21:22 -04:00
aurel cordonnier
69fe095547 Merge from Release-Engine-Staging @ 17636544 to Release-Engine-Test
This represents UE4/Main @17638339 and Dev-PerfTest @17636504

[CL 17638842 by aurel cordonnier in ue5-release-engine-test branch]
2021-09-27 19:54:25 -04:00
timothy daoust
723d3df744 Move AnimGraphNode_Mirror.h from Classes to Public folder
#rb thomas.sarkanen
#preflight 614463659bba9a0001f530a4

#ROBOMERGE-AUTHOR: timothy.daoust
#ROBOMERGE-SOURCE: CL 17550574 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v870-17433530)

[CL 17550580 by timothy daoust in ue5-release-engine-test branch]
2021-09-17 07:03:52 -04:00