Commit Graph

39 Commits

Author SHA1 Message Date
lukasz furman
1a33ae7203 fixed crash on rebuilding UI invalidation path
[FYI] Nick.Darnell


#ROBOMERGE-SOURCE: CL 11459874 via CL 11459877 via CL 11459880
#ROBOMERGE-BOT: (v654-11333218)

[CL 11459881 by lukasz furman in Main branch]
2020-02-17 10:37:19 -05:00
nick darnell
12f10b22eb Slate - Faster and safer draw element submitting for invalidation painting. This should fix issues with difficult to reproduce crashes involving cached element lists that have been deleted but are being accessed (suspected).
Improved CSV stats we're tracking for cached elements.  This version should fix the issue with weakptrs getting corrupted.

Removing memstacks and using inline allocators with enough slack, the memstacks don't work as expected over multiple frames.

Cleaning up cached lists from the new array when the corresponding widget's handle is cleaned up.

#author Matt.Kuhlenschmidt
#editor Nick.Darnell
#rb Nick.Darnell
[FYI] Matt.Kuhlenschmidt, Andrew.Ladenberger




#ROBOMERGE-SOURCE: CL 11068394 via CL 11068413 via CL 11068420
#ROBOMERGE-BOT: (v637-11041722)

[CL 11068429 by nick darnell in Main branch]
2020-01-20 16:30:39 -05:00
bob tellez
2f797bdf39 Back out changelist 10981122. Client crash
[FYI] Nick.Darnell


#ROBOMERGE-SOURCE: CL 11025062 via CL 11025214 via CL 11025315
#ROBOMERGE-BOT: (v633-10983880)

[CL 11025423 by bob tellez in Main branch]
2020-01-16 00:43:13 -05:00
nick darnell
2c5c6f23d5 Slate - Faster and safer draw element submitting for invalidation painting. This should fix issues with difficult to reproduce crashes involving cached element lists that have been deleted but are being accessed (suspected).
Improved CSV stats we're tracking for cached elements.  This version should fix the issue with weakptrs getting corrupted.

Removing memstacks and using inline allocators with enough slack, the memstacks don't work as expected over multiple frames.

#author Matt.Kuhlenschmidt
#editor Nick.Darnell
#rb Nick.Darnell
[FYI] Matt.Kuhlenschmidt, Andrew.Ladenberger




#ROBOMERGE-SOURCE: CL 10981122 via CL 10981129 via CL 10981131
#ROBOMERGE-BOT: (v632-10940481)

[CL 10981133 by nick darnell in Main branch]
2020-01-14 09:34:05 -05:00
nick darnell
0b72677a36 Slate - Simplify the SWidget scope to just use anon variables.
#ROBOMERGE-SOURCE: CL 10951215 via CL 10951231 via CL 10951232
#ROBOMERGE-BOT: (v632-10940481)

[CL 10951234 by nick darnell in Main branch]
2020-01-13 09:37:47 -05:00
nick darnell
cf563e8faa Undo changelist 10949647
#ROBOMERGE-SOURCE: CL 10949682 via CL 10949683 via CL 10949684
#ROBOMERGE-BOT: (v632-10940481)

[CL 10949685 by nick darnell in Main branch]
2020-01-12 17:47:35 -05:00
nick darnell
0259841247 Slate - Faster and safer draw element submitting for invalidation painting. This should fix issues with difficult to reproduce crashes involving cached element lists that have been deleted but are being accessed (suspected).
Improved CSV stats we're tracking for cached elements.  This version should fix the issue with weakptrs getting corrupted.

Additional changes to try and solve issues with tests.

#author Matt.Kuhlenschmidt
#editor Nick.Darnell
#rb Nick.Darnell
[FYI] Matt.Kuhlenschmidt, Andrew.Ladenberger




#ROBOMERGE-SOURCE: CL 10949647 via CL 10949648 via CL 10949649
#ROBOMERGE-BOT: (v632-10940481)

[CL 10949650 by nick darnell in Main branch]
2020-01-12 16:28:32 -05:00
bob tellez
11b418ce16 Back out changelist 10906690. EdTest crash
[FYI] Nick.Darnell


#ROBOMERGE-SOURCE: CL 10911488 via CL 10911491 via CL 10911494
#ROBOMERGE-BOT: (v626-10872990)

[CL 10911496 by bob tellez in Main branch]
2020-01-08 18:03:44 -05:00
nick darnell
48a61ce08d Slate - Faster and safer draw element submitting for invalidation painting. This should fix issues with difficult to reproduce crashes involving cached element lists that have been deleted but are being accessed (suspected).
Improved CSV stats we're tracking for cached elements.  This version should fix the issue with weakptrs getting corrupted.

#author Matt.Kuhlenschmidt
#editor Nick.Darnell
#rb Nick.Darnell
[FYI] Matt.Kuhlenschmidt, Andrew.Ladenberger



#ROBOMERGE-SOURCE: CL 10906690 via CL 10906695 via CL 10906699
#ROBOMERGE-BOT: (v626-10872990)

[CL 10906703 by nick darnell in Main branch]
2020-01-08 13:59:18 -05:00
bob tellez
a981fcfeef Back out changelist 10892298, 10894924. CIS errors
[FYI] Nick.Darnell


#ROBOMERGE-SOURCE: CL 10901828 via CL 10901829 via CL 10901833
#ROBOMERGE-BOT: (v626-10872990)

[CL 10901836 by bob tellez in Main branch]
2020-01-08 01:17:43 -05:00
bob tellez
9c35ee5458 #UE4 Fix compile error
[FYI] Nick.Darnell


#ROBOMERGE-SOURCE: CL 10894924 via CL 10894927 via CL 10894932
#ROBOMERGE-BOT: (v626-10872990)

[CL 10894933 by bob tellez in Main branch]
2020-01-07 12:58:44 -05:00
nick darnell
b2c0905bb9 Slate - Faster and safer draw element submitting for invalidation painting. This should fix issues with difficult to reproduce crashes involving cached element lists that have been deleted but are being accessed (suspected).
#author Matt.Kuhlenschmidt
#rb Nick.Darnell
[FYI] Matt.Kuhlenschmidt, Andrew.Ladenberger



#ROBOMERGE-SOURCE: CL 10892298 via CL 10892363 via CL 10892427
#ROBOMERGE-BOT: (v626-10872990)

[CL 10892462 by nick darnell in Main branch]
2020-01-07 11:33:25 -05:00
nick darnell
3e1eb6036b Undo changelist 10890358
#ROBOMERGE-SOURCE: CL 10890838 via CL 10890856 via CL 10890887
#ROBOMERGE-BOT: (v626-10872990)

[CL 10890894 by nick darnell in Main branch]
2020-01-07 10:11:13 -05:00
nick darnell
d6ed2f85ff Slate - Faster and safer draw element submitting for invalidation painting. This should fix issues with difficult to reproduce crashes involving cached element lists that have been deleted but are being accessed (suspected).
#author Matt.Kuhlenschmidt
#rb Nick.Darnell
[FYI] Matt.Kuhlenschmidt



#ROBOMERGE-SOURCE: CL 10890358 via CL 10890426 via CL 10890455
#ROBOMERGE-BOT: (v626-10872990)

[CL 10890485 by nick darnell in Main branch]
2020-01-07 09:42:09 -05:00
ryan durand
0f0464a30e Updating copyright for Engine Runtime.
#rnx
#rb none


#ROBOMERGE-OWNER: ryan.durand
#ROBOMERGE-AUTHOR: ryan.durand
#ROBOMERGE-SOURCE: CL 10869210 via CL 10869511 via CL 10869900
#ROBOMERGE-BOT: (v613-10869866)

[CL 10870549 by ryan durand in Main branch]
2019-12-26 14:45:42 -05:00
andrew ladenberger
a39944e41e Added SCOPE_CYCLE_SWIDGET to mirror SCOPE_CYCLE_UOBJECT and get widget names from slate scope counters. Added scopes for Invalidation and RecacheElements events
#rb nick.darnell, jordan.cristiano
[FYI] ben.woodhouse, matt.kuhlenschmidt


#ROBOMERGE-OWNER: andrew.ladenberger
#ROBOMERGE-AUTHOR: andrew.ladenberger
#ROBOMERGE-SOURCE: CL 10779905 via CL 10779930 via CL 10780021 via CL 10780025 via CL 10780027
#ROBOMERGE-BOT: (v610-10636431)

[CL 10780035 by andrew ladenberger in Main branch]
2019-12-17 17:51:55 -05:00
nick darnell
da3f42d0f7 Linux Build Fix. Slate - Refrence the slate CSV define as module extern, even inside its own module.
#ROBOMERGE-SOURCE: CL 10766077 via CL 10768304 via CL 10768489 via CL 10771158 via CL 10771285
#ROBOMERGE-BOT: (v610-10636431)

[CL 10771487 by nick darnell in Main branch]
2019-12-17 14:58:56 -05:00
nick darnell
c952331400 Slate - Adding CSV profiling timers and counters to some key areas in Slate for performance reports. Also adding an event that fires when something invalidates more than a command line parameter level of parents, currently set to 5. I think I want it to be smarter though, some way to marking certain widgets as generating events when they're invalidated.
Andrew Ladenberger, Matt Kuhlenschmidt


#ROBOMERGE-SOURCE: CL 10763959 via CL 10763980 via CL 10763994 via CL 10764091 via CL 10764149
#ROBOMERGE-BOT: (v610-10636431)

[CL 10764216 by nick darnell in Main branch]
2019-12-17 11:07:46 -05:00
matt kuhlenschmidt
bdb38283e2 Enabled per-user hit testing in Slate to avoid cases where two users hovered over incompabile UI (UI designed for a specific user) can still interact with it.
#rb chris.gagnon


#ROBOMERGE-SOURCE: CL 10541213 via CL 10541286 via CL 10560152 via CL 10560839 via CL 10560958
#ROBOMERGE-BOT: (v606-10482310)

[CL 10561108 by matt kuhlenschmidt in Main branch]
2019-12-05 15:59:53 -05:00
nick darnell
4e14394934 Slate - When doing WidgetProxy fast path update, we now return true correctly if any of the updated proxies required a repaint. Also removed some stats and variables that were not being used. This fixes the issue with retainer widgets using invalidation method of redrawing to correctly repaint when widgets invalidate layout and paint.
Matt.Kuhlenschmidt


#ROBOMERGE-SOURCE: CL 9421835 via CL 9421841 via CL 9421844 via CL 9421851 via CL 9422758
#ROBOMERGE-BOT: (v480-9420520)

[CL 9423104 by nick darnell in Main branch]
2019-10-04 16:50:49 -04:00
matt kuhlenschmidt
43e13a6791 Added missing file from last checkin
#ROBOMERGE-SOURCE: CL 8030219 via CL 8035494 via CL 8035653 via CL 8045857
#ROBOMERGE-BOT: (v400-8057353)

[CL 8062990 by matt kuhlenschmidt in Main branch]
2019-08-15 14:01:11 -04:00
matt kuhlenschmidt
8a57e9106f Fix retainers nested in invalidation panels not bubbling layout to their parents.
#ROBOMERGE-SOURCE: CL 8030195 via CL 8035484 via CL 8035646 via CL 8045849
#ROBOMERGE-BOT: (v400-8057353)

[CL 8062986 by matt kuhlenschmidt in Main branch]
2019-08-15 14:01:03 -04:00
matt kuhlenschmidt
854633ea06 Disable ensure that will always happen during prepass. Its not a valid place to ensure.
#ROBOMERGE-SOURCE: CL 7661814 via CL 7662847 via CL 7670070
#ROBOMERGE-BOT: (v376-7668820)

[CL 7670144 by matt kuhlenschmidt in Main branch]
2019-07-31 11:34:20 -04:00
matt kuhlenschmidt
509b790b92 Fix social panel disappearing when switching social panel tabs.
Social panel was incorrectly marked as having volatlity inherited by a parent



#ROBOMERGE-SOURCE: CL 7627797 via CL 7627852 via CL 7627860 via CL 7635820
#ROBOMERGE-BOT: (v372-7473910)

[CL 7635855 by matt kuhlenschmidt in Main branch]
2019-07-26 13:11:58 -04:00
nick darnell
dbaed12a37 SlateGI - No longer computing the desktop geometry during the fast path update, we can now safely use the cached desktop geometry.
[FYI] Matt.Kuhlenschmidt


#ROBOMERGE-SOURCE: CL 7621532 via CL 7621533 via CL 7621534 via CL 7626282
#ROBOMERGE-BOT: (v372-7473910)

[CL 7626458 by nick darnell in Main branch]
2019-07-25 10:51:10 -04:00