Commit Graph

32 Commits

Author SHA1 Message Date
michael trepka
805cee2ab2 Fixed uninitialized varaible in FShaderPipelineCache that was causing stable cache load failures on some computers
[FYI] Arciel.Rekman, Chris.Bunner


#ROBOMERGE-SOURCE: CL 12204530 via CL 12210996 via CL 12211047
#ROBOMERGE-BOT: (v662-12191386)

[CL 12211135 by michael trepka in Main branch]
2020-03-16 13:29:59 -04:00
rolando caloca
b4ddf282b6 UE4.25 - Typo fix
#rb none
#jira UE-90413
#6772

#ROBOMERGE-SOURCE: CL 12132193 in //UE4/Release-4.25/... via CL 12132216
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v659-12123632)

[CL 12140394 by rolando caloca in Main branch]
2020-03-11 17:10:26 -04:00
peter sauerbrei
32a2bf7180 put back in the prioritized PSO caching system
#rb chris.bunner


#ROBOMERGE-SOURCE: CL 11580938 via CL 11580948 via CL 11580955 via CL 11580964
#ROBOMERGE-BOT: (v654-11333218)

[CL 11580972 by peter sauerbrei in Main branch]
2020-02-21 19:02:18 -05:00
dmitriy dyomin
f276753f0a Avoid creating tons of Blend, DepthStencil, Rasterizer states when caching PSOs
#ROBOMERGE-SOURCE: CL 11574745 via CL 11574747 via CL 11574748 via CL 11574749
#ROBOMERGE-BOT: (v654-11333218)

[CL 11574776 by dmitriy dyomin in Main branch]
2020-02-21 04:23:26 -05:00
peter sauerbrei
00b8de8412 fix for compile failure
#rb none


#ROBOMERGE-SOURCE: CL 11467783 via CL 11467791 via CL 11467868 via CL 11467925
#ROBOMERGE-BOT: (v654-11333218)

[CL 11467981 by peter sauerbrei in Main branch]
2020-02-17 17:34:37 -05:00
peter sauerbrei
8e7df5f8d1 fix for invalid PSO masks when the GameMask is disabled by default and we attempt to gather PSOs
#rb chris.bunner


#ROBOMERGE-SOURCE: CL 11467116 via CL 11467119 via CL 11467124 via CL 11467128
#ROBOMERGE-BOT: (v654-11333218)

[CL 11467276 by peter sauerbrei in Main branch]
2020-02-17 16:56:29 -05:00
peter sauerbrei
64e0c21033 revert out the prioritized PSO caching, seeing some very strange errors which we can't seem to resolve in time for 12.00
#rb none


#ROBOMERGE-SOURCE: CL 11458007 via CL 11458008 via CL 11458009 via CL 11458010
#ROBOMERGE-BOT: (v654-11333218)

[CL 11458011 by peter sauerbrei in Main branch]
2020-02-16 16:20:17 -05:00
peter sauerbrei
9d704722fb fix for PSO Cache not properly setting the mask when no cache is present
#rb thomas.ross


#ROBOMERGE-SOURCE: CL 11450978 via CL 11452366 via CL 11452392 via CL 11452433
#ROBOMERGE-BOT: (v654-11333218)

[CL 11456138 by peter sauerbrei in Main branch]
2020-02-15 10:17:00 -05:00
peter sauerbrei
fc5642954c fixes for the PSO cache to make it so we can prioritize and compile only those PSOs up front we want based on user category
#rb chris.bunner, ben.salem
[FYI] will.fissler, michael.trepka


#ROBOMERGE-SOURCE: CL 11291332 via CL 11291336 via CL 11291342 via CL 11291348
#ROBOMERGE-BOT: (v647-11244347)

[CL 11291349 by peter sauerbrei in Main branch]
2020-02-07 10:12:13 -05:00
Josh Adams
aa9705149b Copying Private-LoadTimes-4.24 stream to Main. Biggest changes are in Materials/Shader memory freezing.
#rb none

[CL 11282608 by Josh Adams in Main branch]
2020-02-06 13:13:41 -05:00
ryan durand
0f0464a30e Updating copyright for Engine Runtime.
#rnx
#rb none


#ROBOMERGE-OWNER: ryan.durand
#ROBOMERGE-AUTHOR: ryan.durand
#ROBOMERGE-SOURCE: CL 10869210 via CL 10869511 via CL 10869900
#ROBOMERGE-BOT: (v613-10869866)

[CL 10870549 by ryan durand in Main branch]
2019-12-26 14:45:42 -05:00
peter sauerbrei
4f441f2a48 addition of cvar to limit the max amount of pre-compile time for PSOs, defaulting to off for the time being
#rb thomas.ross


#ROBOMERGE-SOURCE: CL 10764445 via CL 10764467 via CL 10764470 via CL 10764476 via CL 10764487
#ROBOMERGE-BOT: (v610-10636431)

[CL 10764492 by peter sauerbrei in Main branch]
2019-12-17 11:16:02 -05:00
rolando caloca
e521bb5ed4 Delete Library file handle on close (Non native ShaderCodeLibrary implementation only), unfortunatly this also means we have to wait on any outstanding read tasks.
Plus - Fix rare shutdown check() failure when async file reads are still wainting in the FShaderPipelineCache.

Plus - Put back correct order of shutdown for FShaderCodeLibrary and FShaderPipelineCache as they can have outstanding aync file handles and we'll get a crash if they are closed after the module shutdown has deleted the FPakPrecacher singleton.

#jira UE-79315
#rb Dmitriy.Dyomin, Michael.Trepka
[FYI] Michael.Trepka
#fyi Richard.Wallis

#ROBOMERGE-OWNER: rolando.caloca
#ROBOMERGE-AUTHOR: richard.wallis
#ROBOMERGE-SOURCE: CL 9743659 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v542-9736015)

[CL 9744080 by rolando caloca in Main branch]
2019-10-22 08:30:35 -04:00
peter sauerbrei
dd67148543 fix for not properly deleting the OS cache on the first run
#rb thomas.ross


#ROBOMERGE-SOURCE: CL 9244146 via CL 9244213 via CL 9244250 via CL 9244284
#ROBOMERGE-BOT: (v443-9013191)

[CL 9244320 by peter sauerbrei in Main branch]
2019-09-27 17:48:57 -04:00
peter sauerbrei
836694910f make it so we don't optimize if the functions.data file is a legit size and we have previously optimized. At that point, just load the shaders requested by the scalability
#rb chris.bunner
[FYI] michael.trepka, richard.wallis, matt.collins


#ROBOMERGE-SOURCE: CL 9163202 via CL 9163547 via CL 9163603
#ROBOMERGE-BOT: (v443-9013191)

[CL 9163661 by peter sauerbrei in Main branch]
2019-09-26 17:43:37 -04:00
peter sauerbrei
950ff1fa48 make it so IOS can now pre-compile the PSOs during ESP and pre-compiles all PSOs for a set of scalabilities
#rb thomas.ross


#ROBOMERGE-SOURCE: CL 8068523 via CL 8068528 via CL 8068894 via CL 8094505
#ROBOMERGE-BOT: (v401-8057353)

[CL 8094643 by peter sauerbrei in Main branch]
2019-08-16 13:25:19 -04:00
richard wallis
750b7d563c Change check() to return success/failure in CheckPSOStringInveribility(). Use this and a new FPipelineCacheFileFormatPSO::Verify() function to decide if we should actually use this PSO in the ShaderPipelineCacheToolsCommandlet expand operation. In non shipping builds also use the verfy function during FPipelineCacheFileFormatPSO::Init() to catch bad PSOs during PSO record runs. E.g use the current check() assert in FPipelineFileCache::CacheGraphicsPSO().
#rb Michael.Trepka, Chris.Bunner


#ROBOMERGE-SOURCE: CL 7062282 via CL 7062284 via CL 7070288
#ROBOMERGE-BOT: (v367-6836689)

[CL 7070515 by richard wallis in Main branch]
2019-06-18 16:20:13 -04:00
chris bunner
c0c5c3e82e Update PSO validity check to compare against valid data, was comparing against a default out of bounds value.
[FYI] Michael.Trepka, Leslie.Nivison
[REVIEW]


#ROBOMERGE-SOURCE: CL 6988159 via CL 6988160 via CL 6988161 via CL 6988162 via CL 6988425
#ROBOMERGE-BOT: (v367-6836689)

[CL 6988447 by chris bunner in Main branch]
2019-06-14 09:25:47 -04:00
chris babcock
83dd01f4ee Fix precompiles of Android shaders
#ue4
#android
[FYI] Michael.Trepka,Jack.Porter,Thomas.Ross
[REVIEW]
#rb Thomas.Ross



#ROBOMERGE-SOURCE: CL 6987482 via CL 6987486 via CL 6987487 via CL 6987489 via CL 6987540
#ROBOMERGE-BOT: (v367-6836689)

[CL 6987544 by chris babcock in Main branch]
2019-06-14 00:15:30 -04:00
michael trepka
225de6eef2 Workaround for corrupt PSO data causing crash at startup on Mac
[FYI] Matt.Collins, Richard.Wallis, Chris.Bunner
#rb none


#ROBOMERGE-SOURCE: CL 6957169 via CL 6957172 via CL 6960095 via CL 6960462 via CL 6967082
#ROBOMERGE-BOT: (v367-6836689)

[CL 6981839 by michael trepka in Main branch]
2019-06-13 18:21:46 -04:00
michael trepka
e329bd08a5 Richard's change to skip PSO cache entries with invalid render target or samples count
#ROBOMERGE-SOURCE: CL 6490987 via CL 6491017 via CL 6491030 via CL 6491043 via CL 6500704

[CL 6500968 by michael trepka in Main branch]
2019-05-15 14:43:00 -04:00
dmitriy dyomin
03d7c24400 Added support for vulkan sub-passes. Used only by mobile renderer for fetching scene depth during translucency
This invalidates all collected PSO
[FYI] rolando.caloca


#ROBOMERGE-SOURCE: CL 6009976 via CL 6009978 via CL 6010093

[CL 6010125 by dmitriy dyomin in Main branch]
2019-04-19 04:07:27 -04:00
michael trepka
139afcf9b7 Changed the thread priority for FCompilePipelineStateTask on Mac to AnyBackgroundThreadNormalTask and reverted the default batch size for the fast mode to 50. Thanks to this we don't starve the game thread as much as before without sacrificing the load times.
#rb Richard.Wallis


#ROBOMERGE-SOURCE: CL 5669899 via CL 5669900 via CL 5669901 via CL 5669902 via CL 5671912

[CL 5671998 by michael trepka in Main branch]
2019-04-01 14:25:28 -04:00
richard wallis
0b8a816ad1 Speculative fix for macOS client builds crashing on launch due to bad PSO cache file. Don't write to PSO cache file while the Engine is shutting down - auto saves should have kept the file upto date.
#rb michael.trepka


#ROBOMERGE-SOURCE: CL 5661773 via CL 5661774 via CL 5661775 via CL 5661776 via CL 5661904

[CL 5661908 by richard wallis in Main branch]
2019-04-01 07:02:58 -04:00
Rolando Caloca
8e16044464 UE4 - Fix clang compile errors
#jira UE-71335
#rnx
#rb none

[CL 5359571 by Rolando Caloca in Main branch]
2019-03-11 11:09:10 -04:00