Commit Graph

1934 Commits

Author SHA1 Message Date
robert manuszewski
ce10617ceb Fixing FFieldPath::ToString() not removing nativized BP temp package prefix after changes from 12847659
#rb trivial
#jira UE-92149

#ROBOMERGE-SOURCE: CL 13003406 via CL 13003408 via CL 13003419
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v682-12900288)

[CL 13003431 by robert manuszewski in Main branch]
2020-04-23 06:46:03 -04:00
dan oconnor
9a5d02ddb0 FPropertyDelegate now lists the SignatureFunction in its 'Referenced Objects', TRASHCLASS is no marked as CLASS_NewerVersionExists, reload package now checks outer chain for out of date classes
#rb Phillip.Kavan
#jira UE-92248

#ROBOMERGE-SOURCE: CL 12939652 in //UE4/Release-4.25/... via CL 12939658 via CL 12939670
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v682-12900288)

[CL 12939678 by dan oconnor in Main branch]
2020-04-20 17:27:23 -04:00
robert manuszewski
ee5c5c5cbc Chaning how FFieldPaths (TFieldPaths) are internally stored and serialized. Now instead of storing the full path (from the outermost UPackage to the innermost FProperty) FFieldPaths will store the owner UStruct reference and a short path to its property (or inner property of its property). The same applies to serialization: both the owner UStruct reference and only the short path will be serialized.
Serializing the owner reference will enable proper handling of any owner struct package renames as well as greatly increase the initial field (property) resolution performance.

#rb Steve.Robb
#tests Basic editor functionality tests related to blueprint editing, editor quick smoke tests, cooked windows client and server, cooked build bot soak tests
[REVIEW] [at]Steve.Robb

#ROBOMERGE-SOURCE: CL 12847659 via CL 12847660 via CL 12847661
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v681-12776863)

[CL 12847663 by robert manuszewski in Main branch]
2020-04-16 04:12:39 -04:00
robert manuszewski
d7ecbe4556 Creating new UObjects while Collecting Garbage will now result in an assert.
#rb trivial
#jira UE-85425

#ROBOMERGE-SOURCE: CL 12792273 in //UE4/Release-4.25/... via CL 12792275 via CL 12792277
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v681-12776863)

[CL 12792280 by robert manuszewski in Main branch]
2020-04-15 08:37:10 -04:00
johan torp
c2b9eea6ef Remove debug assert that verifies that the new optimized StaticFindObject behaves exactly the same as the old algorithm
The old algorithm would match if the outermost name ended with the supplied outermost name. The new algorithm does exact matching of the outermost name, which makes more sense and was likely the intent of the old algorithm.

[FYI] marc.audy
#jira UE-92008
#rb trivial
#lockdown stefan.boberg

#ROBOMERGE-SOURCE: CL 12791641 in //UE4/Release-4.25/... via CL 12791657 via CL 12791675
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v681-12776863)

[CL 12791692 by johan torp in Main branch]
2020-04-15 08:00:51 -04:00
matt peters
e3979ee00e Fix unguarded multithreaded access to FCoreRedirects::KnownMissing functions.
#rb Per.Larsson
#rnx

#ROBOMERGE-SOURCE: CL 12781890 via CL 12781894 via CL 12781898 via CL 12781899
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v681-12776863)

[CL 12782646 by matt peters in Main branch]
2020-04-14 13:43:37 -04:00
carlmagnus nordin
25e8b4dd7d Copying //UE4/Release-4.25Plus-Dev to Release-4.25Plus (//UE4/Release-4.25Plus)
#rnx
#robomerge[BOT1] Main-For-EngineMerge
#rb none
#jira none
#lockdown stefan.boberg

#ROBOMERGE-OWNER: carlmagnus.nordin
#ROBOMERGE-AUTHOR: carlmagnus.nordin
#ROBOMERGE-SOURCE: CL 12504704 in //UE4/Release-4.25Plus/... via CL 12504720
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v673-12478461)

[CL 12504759 by carlmagnus nordin in Main branch]
2020-04-01 05:00:26 -04:00
johan torp
20e2b91cf5 Fix property parsing for + and " characters
[FYI] bob.tellez
#jira UE-91349
#rb stefan.boberg

#ROBOMERGE-SOURCE: CL 12494518 via CL 12494534 via CL 12494542
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v673-12478461)

[CL 12494552 by johan torp in Main branch]
2020-03-31 06:01:25 -04:00
bob tellez
ca0e027914 #UE4 Added '+' to the list of RegularTokenChars in property parsing code. Object paths can contain a plus, so they must be able to be parsed
[FYI] Johan.Torp

#ROBOMERGE-SOURCE: CL 12491993 via CL 12491994 via CL 12491995
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v673-12478461)

[CL 12491997 by bob tellez in Main branch]
2020-03-30 19:35:41 -04:00
tim tillotson
f2ccc5a4ed Merging using Dev-Solaris=>FN/Main CL#12453850
#rb none

#ROBOMERGE-OWNER: tim.tillotson
#ROBOMERGE-AUTHOR: tim.tillotson
#ROBOMERGE-SOURCE: CL 12479490 via CL 12479911 via CL 12479912
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v673-12478461)

[CL 12487295 by tim tillotson in Main branch]
2020-03-30 12:03:26 -04:00
josh adams
f91cd61430 - Fixed a compile error
#rb none
#rnx


#ROBOMERGE-SOURCE: CL 12451742
#ROBOMERGE-BOT: (v672-12450963)

[CL 12456999 by josh adams in Release-Engine-Staging branch]
2020-03-26 16:11:18 -04:00
devin doucette
6fb9beed8e Remove includes of StringBuilder.h in headers
#jira none
#rb Johan.Torp
#rnx

#ROBOMERGE-SOURCE: CL 12402647 in //UE4/Release-4.25/... via CL 12402653
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Release-Engine-Staging) (v671-12333473)

[CL 12426675 by devin doucette in Release-Engine-Staging branch]
2020-03-25 14:05:27 -04:00
jamie dale
12f18be5fc Fixed escaping of control characters when converting a string literal to C++
Fallout from CL# 12343442

#jira UE-91078
#rb none
#rnx

#ROBOMERGE-SOURCE: CL 12393937 in //UE4/Release-4.25/... via CL 12393948
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Release-Engine-Staging) (v671-12333473)

[CL 12403486 by jamie dale in Release-Engine-Staging branch]
2020-03-25 10:30:50 -04:00
devin doucette
92b97d9acc Remove includes of StringBuilder.h in headers
#jira none
#rb Johan.Torp
#rnx

[CL 12402647 by devin doucette in 4.25 branch]
2020-03-25 09:54:13 -04:00
robert manuszewski
fa7003e12d FFieldPaths should no longer re-resolve themselves each time a blueprint is destroy and only re-resolve if the blueprint that owns the property they resolve to is destroyed / or recompiled.
#rb Steve.Robb
#tests 1 hour bot soak tests in cooked build, quick some test, repro steps from FProperty related Jiras


#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 12401632 via CL 12401644
#ROBOMERGE-BOT: (v671-12333473)

[CL 12402296 by robert manuszewski in Release-Engine-Staging branch]
2020-03-25 08:23:06 -04:00
Jamie Dale
31128e1711 Fixed escaping of control characters when converting a string literal to C++
Fallout from CL# 12343442

#jira UE-91078
#rb none
#rnx

[CL 12393937 by Jamie Dale in 4.25 branch]
2020-03-24 17:22:33 -04:00
jamie dale
e06d54e0f2 Escape non-ASCII characters as UTF sequences when generating C++ literal strings
This improves portability between compilers and the default encoding of an OS install, and is inline with how we encode strings within hand written C++.

#jira UE-90621
#rb Johan.Torp
#rnx

#ROBOMERGE-SOURCE: CL 12343442 in //UE4/Release-4.25/... via CL 12343461
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v671-12333473)

[CL 12343467 by jamie dale in Main branch]
2020-03-20 14:39:11 -04:00
Jamie Dale
11cd08fe0e Escape non-ASCII characters as UTF sequences when generating C++ literal strings
This improves portability between compilers and the default encoding of an OS install, and is inline with how we encode strings within hand written C++.

#jira UE-90621
#rb Johan.Torp
#rnx

[CL 12343442 by Jamie Dale in 4.25 branch]
2020-03-20 14:38:15 -04:00
devin doucette
0a3b3c8a4c Changed FName(F[Ansi]StringView) constructors to be explicit
Avoid unintentional construction of names as this can be expensive and bloats the name table.

#jira none
#rb Johan.Torp, Steve.Robb
#rnx

#ROBOMERGE-SOURCE: CL 12341371 in //UE4/Release-4.25/... via CL 12341378
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v671-12333473)

[CL 12341393 by devin doucette in Main branch]
2020-03-20 13:40:59 -04:00
devin doucette
beb3bb93e3 Changed FName(F[Ansi]StringView) constructors to be explicit
Avoid unintentional construction of names as this can be expensive and bloats the name table.

#jira none
#rb Johan.Torp, Steve.Robb
#rnx

[CL 12341371 by devin doucette in 4.25 branch]
2020-03-20 13:40:10 -04:00
Robert Manuszewski
58f1148641 Fix for null access when verifying ScriptAndPropertyObjectReferences (fallout from 12192717)
#rb none
#jira UE-90698

[CL 12216874 by Robert Manuszewski in 4.25 branch]
2020-03-16 14:51:45 -04:00
robert manuszewski
cd1104dedb Fix for null access when verifying ScriptAndPropertyObjectReferences
#rb none


#ROBOMERGE-SOURCE: CL 12216380 via CL 12216408
#ROBOMERGE-BOT: (v662-12191386)

[CL 12216450 by robert manuszewski in Main branch]
2020-03-16 14:47:37 -04:00
robert manuszewski
be4b7bc6df Reducing the constant memory cost of keeping FProperty related references from 32 to 8 bytes per UStruct.
- Merged ScriptObjectReferences and PropertyObjectReferences into single ScriptAndPropertyObjectReferences array
- UnresolvedScriptProperties will now be a heap allocated array since it only needs to exist at load time

#rb Dan.OConnor
#tests Cooked and launched PC client and server + 3 hours of bot soak tests in cooked buiild


#ROBOMERGE-OWNER: robert.manuszewski
#ROBOMERGE-AUTHOR: robert.manuszewski
#ROBOMERGE-SOURCE: CL 12190983 via CL 12196972
#ROBOMERGE-BOT: (v662-12191386)

[CL 12197138 by robert manuszewski in Main branch]
2020-03-16 09:16:58 -04:00
robert manuszewski
2f07f6cd59 Reducing the constant memory cost of keeping FProperty related references from 32 to 8 bytes per UStruct.
- Merged ScriptObjectReferences and PropertyObjectReferences into single ScriptAndPropertyObjectReferences array
- UnresolvedScriptProperties will now be a heap allocated array since it only needs to exist at load time

#rb Dan.OConnor
#jira UE-90698

#ROBOMERGE-SOURCE: CL 12192717 in //UE4/Release-4.25/... via CL 12192726
#ROBOMERGE-BOT: RELEASE (Release-4.25Plus -> Main) (v662-12191386)

[CL 12192733 by robert manuszewski in Main branch]
2020-03-16 03:56:46 -04:00
Robert Manuszewski
88b779c80c Reducing the constant memory cost of keeping FProperty related references from 32 to 8 bytes per UStruct.
- Merged ScriptObjectReferences and PropertyObjectReferences into single ScriptAndPropertyObjectReferences array
- UnresolvedScriptProperties will now be a heap allocated array since it only needs to exist at load time

#rb Dan.OConnor
#jira UE-90698

[CL 12192717 by Robert Manuszewski in 4.25 branch]
2020-03-16 03:55:40 -04:00