Commit Graph

10 Commits

Author SHA1 Message Date
helge mathee
86d659f978 Control Rig: Ensure to clean up injected nodes during undo / redo
The injected node action was just calling RemoveNode, which outside of undo / redo does not clean up links. We had some stale / transient nodes due to this in the repro case. By adding an additional argument to force recursion into BreakAllLinks etc this is fixed.

#rb lina.halper
#lockdown laurent.delayen
#jira UE-92035

#ROBOMERGE-SOURCE: CL 12923962 in //UE4/Release-4.25/... via CL 12923974 via CL 12923998
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v682-12900288)

[CL 12924002 by helge mathee in Main branch]
2020-04-20 11:20:47 -04:00
helge mathee
097750f1d2 Control Rig: Rapidly undoing "Add visual debug" causes ensure
#rb trivial
#jira UE-89763

#ROBOMERGE-SOURCE: CL 12672604 in //UE4/Release-4.25/... via CL 12672606 via CL 12672638
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v675-12543919)

[CL 12672663 by helge mathee in Main branch]
2020-04-08 10:20:10 -04:00
helge mathee
494f2a53f6 Control Rig: Re-enable deprecated units for RigVM
#rb na
#jira UE-91550

#ROBOMERGE-SOURCE: CL 12651458 via CL 12651470 via CL 12651471
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v675-12543919)

[CL 12651474 by helge mathee in Main branch]
2020-04-07 04:28:28 -04:00
helge mathee
c56506a1ef Control Rig: Ensure to define missing parameters AFTER initial traverse of AST
#rb na
#jira UE-91550

#ROBOMERGE-SOURCE: CL 12651454 via CL 12651456 via CL 12651459
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v675-12543919)

[CL 12651464 by helge mathee in Main branch]
2020-04-07 04:27:49 -04:00
helge mathee
60a1b432f7 RigVM AST: Moved the lookup from AST Node to Expression Index to a map, since now with nested nodes the Node index itself cannot be relied on.
#rb lina.halper
#jira UE-88252

Merging

//UE4/Dev-Anim/Engine/Source/Developer/RigVMDeveloper/...

to //UE4/Dev-Anim/Engine/Source/Developer/RigVMDeveloper/...

#ROBOMERGE-SOURCE: CL 11498311 in //UE4/Release-4.25/...
#ROBOMERGE-BOT: RELEASE (Release-4.25 -> Release-4.25Plus) (v654-11333218)

[CL 11498330 by helge mathee in 4.25-Plus branch]
2020-02-18 09:32:18 -05:00
helge mathee
b7c3bfa7cc Instead of accessing sub array elements on a default struct we create a new structonscope for the inner property and use that instead. The array property might be empty - so relying on that isn't stable and can cause crashes as hit in UE-88394
#rb lina.halper
#jira UE-88394

Merging

//UE4/Dev-Anim/Engine/Source/Developer/RigVMDeveloper/Private/RigVMModel/RigVMController.cpp

to //UE4/Release-4.25/Engine/Source/Developer/RigVMDeveloper/Private/RigVMModel/RigVMController.cpp

#ROBOMERGE-SOURCE: CL 11498307 in //UE4/Release-4.25/...
#ROBOMERGE-BOT: RELEASE (Release-4.25 -> Release-4.25Plus) (v654-11333218)

[CL 11498326 by helge mathee in 4.25-Plus branch]
2020-02-18 09:32:14 -05:00
helge mathee
223157a801 Control Rig: Fix error log for UE-88390
#jira UE-88390
#rb na

Merging

//UE4/Dev-Anim/Engine/Source/Developer/RigVMDeveloper/Private/RigVMModel/RigVMController.cpp

to //UE4/Dev-Anim/Engine/Source/Developer/RigVMDeveloper/Private/RigVMModel/RigVMController.cpp

#ROBOMERGE-SOURCE: CL 11498280 in //UE4/Release-4.25/...
#ROBOMERGE-BOT: RELEASE (Release-4.25 -> Release-4.25Plus) (v654-11333218)

[CL 11498293 by helge mathee in 4.25-Plus branch]
2020-02-18 09:30:55 -05:00
Thomas Sarkanen
de2be528ca Copying //UE4/Dev-Anim to Dev-Main (//UE4/Dev-Main)
#rb none
#lockdown nick.penwarden

[CL 11214797 by Thomas Sarkanen in Main branch]
2020-02-04 11:06:23 -05:00
Helge Mathee
b8106b68b1 Incremental Static Analysis Win64 (MSVC) - Warning: Dereferencing NULL pointer Property in rigvmcontroller.cpp
#rb na
#jira UE-87400

[CL 11152217 by Helge Mathee in Main branch]
2020-01-29 03:07:54 -05:00
Lina Halper
44c1bb3292 COPY from //Dev-Anim to //Dev-Main
#rb: none
#fyi: Laurent.Delayen, Thomas.Sarkanen

[CL 11088765 by Lina Halper in Main branch]
2020-01-22 17:58:55 -05:00