Commit Graph

61 Commits

Author SHA1 Message Date
rob gay
e67e71d024 Fix circular dependency
#jira UE-91899 UE-91896
#rb none
#rnx

#ROBOMERGE-SOURCE: CL 12758606 via CL 12758850 via CL 12758997
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v678-12743200)

[CL 12759070 by rob gay in Main branch]
2020-04-13 13:35:02 -04:00
rob gay
20fe08b42d Generic Parameter Modulation Refactor
- Add classes to allow modulation of effect parameters
- Remove cruft from first attempt at adding generic modulators

Minor-ish:
- Clean-up headers
- Rename AudioModulationImpl --> AudioModulationSystem
- Remove dead generic code

#rb jimmy.smith

#ROBOMERGE-SOURCE: CL 12732445 via CL 12732449 via CL 12732451
#ROBOMERGE-BOT: RELEASE (Release-Engine-Staging -> Main) (v676-12543919)

[CL 12732457 by rob gay in Main branch]
2020-04-10 16:18:29 -04:00
Rob Gay
63fac693b0 Move icons to AudioModulation plugin content directory
#jira UE-90913
#rnx
#rb none

[CL 12437007 by Rob Gay in 4.25 branch]
2020-03-25 23:11:29 -04:00
Rob Gay
4d09cfa38d Fix issues with modulation output curves reordering randomly when modifying output curve values in editor & hide output curve when bypassed
#jira UE-82202
#rb jimmy.smith

[CL 12235577 by Rob Gay in 4.25 branch]
2020-03-17 16:15:33 -04:00
Rob Gay
91d4819ff1 Edigrate CL 11942501:
Fixing FModulatorBusMixChannelProxy not being marked as friend of FAudioModulationImpl in shipped builds
#jira UE-90145
#rnx
#rb none

[CL 11942822 by Rob Gay in 4.25 branch]
2020-03-05 13:20:59 -05:00
Rob Gay
f69b3de771 Edigrate CLs 11902874, 11849778
Fix Mod mixes not reactivating correctly due to original channel settings not being passed when calling 'SetEnabled' on mix.  Fixed by moving 'Init' logic to SetEnabled and making public for AudioModulationImpl to call when reactivating a stopping mix.

- Pass modulation implementation to proxies to ensure version in charge of creation is that used for initialization/modification where necessary
- Fix leak and make ref counting safer on modulation proxies by moving inc/dec ref out of factory creaters/getters

#review-11849604
#rb ethan.geller aaron.mcleran
#jira UE-90145 UE-89911
#rnx

[CL 11941082 by Rob Gay in 4.25 branch]
2020-03-05 13:01:58 -05:00
Rob Gay
92fc257c98 Fix bad move/add merge
#rb none
#jira none
#rnx

[CL 11914493 by Rob Gay in 4.25 branch]
2020-03-04 15:43:14 -05:00
Rob Gay
124df5c333 Edigrate CL 11672942
Shadow variable fix
#rb none
#jira UE-89686

[CL 11913774 by Rob Gay in 4.25 branch]
2020-03-04 15:33:03 -05:00
Rob Gay
90b90cf827 Edigrate CL 11558590
- Expose editor style colors to BP for OSC controller to piggyback to public, non-editor API
- Move AudioModulationStatics.h to public
- Return channel value array when loading profile with new values deserialized from .ini
#rb jimmy.smith
#jira none

[CL 11913611 by Rob Gay in 4.25 branch]
2020-03-04 15:30:53 -05:00
Rob Gay
a4b0b83ddb Edigration of CL 11460969, 11451271, 11461350, 11467851
- Add Mix serialization/deserialization to ini files
- Fix mix set/update logic and crash involved with removing mix proxy before stop fade complete
- Mixes can now activate buses they act on if bus is not already active. This avoids a lot of unnecessary legwork to ensure active status when buses *should* be active.  It also avoids a lot of complexity around mix state being mismatched between UObject & proxy representation
#rb ryan.mangin
#jira none

[CL 11911000 by Rob Gay in 4.25 branch]
2020-03-04 14:53:05 -05:00
rob gay
eaf0bd00a4 Disable offending clang compiler error in user-sanity bounds check.
#jira UE-88391
#rb none
#rnx


#ROBOMERGE-SOURCE: CL 11338654 via CL 11338676
#ROBOMERGE-BOT: (v653-11302973)

[CL 11338691 by rob gay in Main branch]
2020-02-11 10:15:36 -05:00
ethan geller
1b9558d5fa Editgrate 4.25 audio features from project stream:
-Soundfield Submixes
-Endpoint Submixes
-Unreal Ambisonics Encoder/Decoder

[FYI] aaron.mcleran, maxwell.hayes, phil.popp, rob.gay, charles.egenbacher, kevin.neilson


#ROBOMERGE-OWNER: ethan.geller
#ROBOMERGE-AUTHOR: ethan.geller
#ROBOMERGE-SOURCE: CL 11302185 via CL 11302187
#ROBOMERGE-BOT: (v649-11301724)

[CL 11302191 by ethan geller in Main branch]
2020-02-09 18:57:53 -05:00
ethan geller
f37e121920 Audio Device Manager refactor submission take two. haven't added the bIsMutable flag yet but will next week.
[FYI] aaron.mcleran, ryan.mangin, marc.audy, matt.hoffman


#ROBOMERGE-OWNER: ethan.geller
#ROBOMERGE-AUTHOR: ethan.geller
#ROBOMERGE-SOURCE: CL 11188538 via CL 11188549
#ROBOMERGE-BOT: (v640-11091645)

[CL 11189822 by ethan geller in Main branch]
2020-01-30 18:48:52 -05:00
ryan mangin
ecac024413 Undo changelist 11153200:
CL 1 of 3: Refactor Audio Device Manager.
[FYI] ethan.geller
#rb: none

#ROBOMERGE-OWNER: ryan.mangin
#ROBOMERGE-AUTHOR: ryan.mangin
#ROBOMERGE-SOURCE: CL 11160333 via CL 11160335
#ROBOMERGE-BOT: (v640-11091645)

[CL 11162634 by ryan mangin in Main branch]
2020-01-29 11:34:23 -05:00
ethan geller
4fff0cce59 CL 1 of 3: Refactor Audio Device Manager.
[FYI] aaron.mcleran, rob.gay


#ROBOMERGE-OWNER: ethan.geller
#ROBOMERGE-AUTHOR: ethan.geller
#ROBOMERGE-SOURCE: CL 11153200 via CL 11153210
#ROBOMERGE-BOT: (v640-11091645)

[CL 11153252 by ethan geller in Main branch]
2020-01-29 05:00:56 -05:00
bob tellez
73f3d19f1f Back out changelist 11119764, 11119772, 11119809, 11119849, 11121802, 11125895, 11124508. AutoTest assert
[FYI] Rob.Gay


#ROBOMERGE-SOURCE: CL 11125898 via CL 11126424
#ROBOMERGE-BOT: (v640-11091645)

[CL 11126508 by bob tellez in Main branch]
2020-01-28 05:18:04 -05:00
rob gay
dd71a4cd08 - Deprecate AudioDevice implementation Engine/UnrealEngine monolythics & move to AudioDeviceManager
- Remove redundant static calls on AudioDevice in favor of AudioDeviceManager for finding Main/Active Devices (state managed by the manager, not individual devices)
#rb ethan.geller ryan.mangin


#ROBOMERGE-SOURCE: CL 11119764 via CL 11119771
#ROBOMERGE-BOT: (v640-11091645)

[CL 11119776 by rob gay in Main branch]
2020-01-27 15:55:07 -05:00
Lina Halper
44c1bb3292 COPY from //Dev-Anim to //Dev-Main
#rb: none
#fyi: Laurent.Delayen, Thomas.Sarkanen

[CL 11088765 by Lina Halper in Main branch]
2020-01-22 17:58:55 -05:00
Marc Audy
360d078ca3 Second batch of remaining Engine copyright updates.
#rnx
#rb none

[CL 10871248 by Marc Audy in Main branch]
2019-12-27 09:26:59 -05:00
Robert Manuszewski
7b6f840f7f Copying //UE4/Dev-Core @ 10708550 to Dev-Main (//UE4/Dev-Main)
#rb none

[CL 10708666 by Robert Manuszewski in Main branch]
2019-12-13 11:07:03 -05:00
rob gay
20dc36b3e1 Fix init order warning
#rb none
#jira none

#ROBOMERGE-SOURCE: CL 10108245 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v586-10095595)

[CL 10108252 by rob gay in Main branch]
2019-11-11 18:49:58 -05:00
rob gay
12994664e7 Clean-up UX for modulation bus types (descriptions, order, advanced hiding)
#rb none
#jira none

#ROBOMERGE-SOURCE: CL 10108174 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v586-10095595)

[CL 10108179 by rob gay in Main branch]
2019-11-11 18:42:49 -05:00
rob gay
32ce936017 Perf Fix: Avoid creating modulation proxies every time an update request comes in if the proxy is not already active (as it will simply delete the proxy at the end of the call, and update calls are anticipated to be called relatively frequently)
#rb ethan.geller
#jira none

#ROBOMERGE-SOURCE: CL 10108149 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v586-10095595)

[CL 10108150 by rob gay in Main branch]
2019-11-11 18:40:14 -05:00
rob gay
4c95cee6e6 Fix shadow variable issue on Lumin (trivial)
#rb none
#jira UE-83298

#ROBOMERGE-SOURCE: CL 10070967 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v573-10069714)

[CL 10070968 by rob gay in Main branch]
2019-11-07 11:11:03 -05:00
rob gay
a0890af23e Fix display issue with MixByFilter static BP function call
#rb none
#jira none

#ROBOMERGE-SOURCE: CL 10061575 in //UE4/Release-4.24/...
#ROBOMERGE-BOT: RELEASE (Release-4.24 -> Main) (v566-10053404)

[CL 10061576 by rob gay in Main branch]
2019-11-06 16:36:37 -05:00