Commit Graph

278 Commits

Author SHA1 Message Date
steve robb
f029468598 Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.
[CL 30729174 by steve robb in ue5-main branch]
2024-01-19 16:41:35 -05:00
sergei svetlov
c739c0cb35 Clean up screenshot comparison report pipeline
#rb Jerome.Delattre
#jira UE-200919
#rnx

[CL 30687983 by sergei svetlov in ue5-main branch]
2024-01-18 12:22:38 -05:00
aris theophanidis
1b845cc9c3 Improvements in navigation includes
Removing Actor.h from NavigationTypes.h
Removing NavigationQueryFilter.h when unnecessary in headers
And additional non-unity build fixes
#rb Maxime.Mercier

[CL 30621909 by aris theophanidis in ue5-main branch]
2024-01-15 13:31:49 -05:00
christopher fiala
d1fd4e1e08 [Reintegration] - CL30342517
[FYI] christopher.fiala
Original CL Desc
-----------------------------------------------------------------
[Backout] - CL30314361
[FYI] christopher.fiala
Original CL Desc
-----------------------------------------------------------------
Overhaul stereo variants to support an arbitrary number of variants and correctly implement per-variant frame delays and test preparation, significantly reducing false failures.
Fixes compatibility with TSR sequence screenshot functional test blueprints.

#jira UE-194361
#rb sean.sweeney

[CL 30352401 by christopher fiala in ue5-main branch]
2023-12-15 12:41:53 -05:00
christopher fiala
9c052993ed [Backout] - CL30314361
[FYI] christopher.fiala
Original CL Desc
-----------------------------------------------------------------
Overhaul stereo variants to support an arbitrary number of variants and correctly implement per-variant frame delays and test preparation, significantly reducing false failures.
Fixes compatibility with TSR sequence screenshot functional test blueprints.

#jira UE-194361
#rb sean.sweeney

[CL 30342529 by christopher fiala in ue5-main branch]
2023-12-14 22:03:05 -05:00
sebastian lewicki
b0217d4b01 Fixing crash when trying to restore a CVar to a previous value, when the previous value was empty.
#jira UE-202497
#rnx
#rb Jerome.Delattre, rob.huyett

[CL 30320078 by sebastian lewicki in ue5-main branch]
2023-12-14 10:10:02 -05:00
christopher fiala
7196554c9e Overhaul stereo variants to support an arbitrary number of variants and correctly implement per-variant frame delays and test preparation, significantly reducing false failures.
Fixes compatibility with TSR sequence screenshot functional test blueprints.

#jira UE-194361
#rb sean.sweeney

[CL 30314369 by christopher fiala in ue5-main branch]
2023-12-14 00:32:29 -05:00
matt peters
64658cf6ae GetAssetRegistryTags deprecation: Make the old GetAssetRegistryTags and related functions deprecated.
Upgrade the overrides and callsites in all of Epic's code.
Every class that can be subclassed by licensees that has its override change needs to keep the old version of the function as deprecated. Otherwise subclasses that call Super::GetAssetRegistryTags will have a compile error instead of a deprecation warning.
Several classes had their own extension method for GetAssetRegistryTags being passed on to user data classes. Updated all of those to take FAssetRegistryTagsContext just like GetAssetRegistryTags does.
#rnx
#rb Francis.Hurteau

[CL 30224166 by matt peters in ue5-main branch]
2023-12-08 21:45:21 -05:00
oleg krasnov
99d23a4344 FunctionalTesting - Make screenshot test actor details more intuitive while working with DisableNoisyRenderingFeatures/EyeAdaptation options.
#jira UE-117952
#rb Jerome.Delattre
#rnx

[CL 30175002 by oleg krasnov in ue5-main branch]
2023-12-07 02:32:18 -05:00
christopher fiala
6291d6738b Update LightweightStereoTestVariants mode to run ONLY stereo test variants, no baseline, since they've been moved into their own category. Remove support for specifically exempting tests from running stereo variants. Save screenshots even for passed variants for the time being, since it's now possible to have a variant be the only test running.
Now `Automation.EnableStereoTestVariants=1` (off by default) enables ViewRectOffset, and adding `Automation.LightweightStereoTestVariants=1` causes us to ONLY run ViewRectOffset (on by default).

#jira UE-194361
#rb Jerome.Delattre

[CL 30174576 by christopher fiala in ue5-main branch]
2023-12-06 23:16:08 -05:00
kiaran ritchie
4e92dad5ee Fixes IK Rig rotation engine test. Issues caused by floating point discrepency in Rotator/Quat conversion between Linux/Windows platforms.
#JIRA UE-198900
#rb halfdan.ingvarsson



#virtualized

[CL 29989343 by kiaran ritchie in ue5-main branch]
2023-11-29 11:07:09 -05:00
christopher fiala
d5ec52b3cc Add a new CVar, Automation.LightweightStereoTestVariants, which stops variants from running if we've already encounted an error, and skips saving/attaching screenshots for successful variants to save space. Enabled by default. Also moves the "Supports Stereo Test Variants" checkbox to the "Screenshot" section.
#jira UE-194361
#rb jerome.delattre, chris.constantinescu

[CL 29718813 by christopher fiala in ue5-main branch]
2023-11-14 13:31:30 -05:00
christopher fiala
a0d65ab7f0 Move the global stereo test variants CVar out of ScreenshotFunctionalTest.cpp and into AutomationTest.cpp as "Automation.EnableStereoTestVariants", where it can now be controlled via the automation commandline
(e.g. "Automation Runtest Anisotropy;EnableStereoTests;Quit;").

#jira UE-194361
#rb jeff.fisher

[CL 29529430 by christopher fiala in ue5-main branch]
2023-11-07 14:57:30 -05:00
sergei svetlov
dc071d7436 Support the capability to add info, warning and error directly from Python test
#jira UE-198836
#rb jerome.delattre, sebastian.lewicki-qa-sdets

[CL 29359650 by sergei svetlov in ue5-main branch]
2023-11-02 06:07:56 -04:00
christopher fiala
9942c169c2 Add the ViewRectOffset "test variant" to all screenshot functional tests. When a test variant is enabled, the test will take two screenshots, one in the base configuration, and one in the variant configuration, and fail if both are not similar to the ground truth. The ViewRectOffset variant will be enabled if "Support Stereo Test Variants" is checked on the functional test actor (TRUE by default) and the CVar r.EnableStereoScreenshotTestVariants is set to 1. The CVar is 0 by default for the time being, so there should be no changes to ET unless it is manually set to true.
#jira UE-194361
#rb david.harvey

[CL 29341539 by christopher fiala in ue5-main branch]
2023-11-01 20:00:13 -04:00
BenVlodgi
528da2d693 PR #10982: Disable and hide HLOD category for Functional Test Actor
Reduce options bloat from new feature(HLOD).

#rb sebastian.lewicki

[CL 28884914 by BenVlodgi in ue5-main branch]
2023-10-18 14:33:56 -04:00
jerome delattre
4a5957a406 Add frame comparison failure to the test report when comparing image sequence for Movie Pipeline Functional Test
+ Improve messaging when movie pipeline test is failing for reason other than image comparison.
+ Store ScreenshotName inside comparison request and result.

#jira UE-194701
#rnx
#rb Matt.Hoffman, Sean.Sweeney

[CL 28750594 by jerome delattre in ue5-main branch]
2023-10-13 09:42:36 -04:00
DuncanRare
0b2cf01d8a Adding flag to toggle whether or not garbage collection should be delayed, by default they are. Added property to show in the Editor Details panel for the Functional Test in the Advanced section.
PR # 10898
#commit 10898
#jira UE-195842

[CL 28294665 by DuncanRare in ue5-main branch]
2023-09-27 17:26:59 -04:00
Jerome Delattre
50a2846584 Avoid Take High Res Screenshot scripting command to unset viewport user settings
#jira PLAY-12210
#rnx
#rb Rob.Huyett, Sean.Sweeney

[CL 27966880 by Jerome Delattre in ue5-main branch]
2023-09-18 14:02:00 -04:00
Jerome Delattre
31881299d9 Add support for plain text to FAutomationTestBase::AddExpectedMessage
#jira UE-190032
#rb Chris.Constantinescu, Rob.Huyett

[CL 27118558 by Jerome Delattre in ue5-main branch]
2023-08-15 16:21:05 -04:00
christopher waters
e457524ce3 Addressing casing issues with Automation test results by using the casing from the map's path instead of the map name itself since that is more likely to be a different case on clients.
#jira UE-187814
#rb jeannoe.morissette

[CL 26574385 by christopher waters in ue5-main branch]
2023-07-25 11:08:02 -04:00
guillaume abadie
80b3fd8eaa Makes default r.ScreenPercentage settings configurable in project settings per renderer
Motivations of this change:
1) Temporal upscale by default in game builds even when dynamic resolution is not supported;
2) Fixes "Editor Preferences > Performance > Viewport Resolution > Override game screen percentage settings with editor settings in PIE" or (r.Editor.Viewport.OverridePIEScreenPercentage) that used to override r.ScreenPercentage in PIE by default to prevent accidental out of video memory when going PIE on high resolution/DPI display that was not discoverable enought user and generating misunderstanding;
3) Makes editor UI more understandable that the resolution controls under Settings > Engine Scalability Settings is actually PIE resolution settings, since the editor viewport screen percentage is controled independently in editor viewport top left menus;
4) Fixes inconsistency where VR and mobile renderer viewport didn't have their own settings like path tracer or non-realtime editor viewports had;
5) Adds resolution quality presets: just a slider for the 3D rendering resolution is very subjective to a player what to choose, whereas presets allows to more intuitively suggests trade off on the screen percentage range.

What this changes does to the end user:
1) Implements default screen percentage project settings in Project Preferences > Rendering > Default Screen Percentage (or r.ScreenPercentage.Default.*) for each indivual uses case that are: desktop renderer, mobile renderer, VR rendering, path tracer
1.1) Desktop renderer renderer default to screen percentage based on display resolution to automatically temporally upscale;
1.2) All other rendering methods (mobile render, VR renderer, path tracer) defaults to native resolution rendering as before.
2) Adds editor viewport screen percentage settings for mobile renderer and VR in Project Settings > Editor Performance > Viewport Resolution
3) Changes defaults of sg.ResolutionQuality and r.ScreenPercentage to 0 and fallbacks to project settings' default screen percentage
4) Rewrite Level Editor UI > Settings > Engine Scalability Settings to:
4.1) Says it only apply to PIE viewport, not including Simulate in Editor since these is still viewed with editor viewports, and warn when there is no PIE game viewports;
4.2) Explicitly says what is the current screen percentage of the PIE game viewport;
4.3) Explicitly says what is the current rendering and display resolutions;
4.4) Says what rendering mode is being applied (Desktop renderer, mobile renderer, VR rendering, path tracer)
4.5) Says where the settings come from, r.ScreenPercentage was directly set by console code, or whether the Engine Scalability was overident (sg.ResolutionQuality>0) or where the default settings come from (project's default screen percentage settings or editor viewport preferences)
4.6) Says the actually setting is being used (Manual, Based on Display Resolution, Based on OS DPI Scale)
4.7) Explicitly says which anti-aliasing method is being used on the anti-aliasing scalability group
5) The "Editor Preferences > Performance > Viewport resolution > Override project's default screen percentage settings with editor viewports' settings in PIE" (r.Editor.Viewport.OverridePIEScreenPercentage) now chooses whether the default screen percentage project settings should be overriden by the editor viewport's default settings. sg.ResolutionQuality and r.ScreenPercentage now behaving as a override, it means they are also applied in PIE to avoid user confusions when they do indeed what to take control of it in the project settings or game logic.
6) Adds resolution quality presets in BaseScalability.ini that can be customised in a project's DefaultScalability.ini:
6.1) Default 3D resolution preset: Sets sg.ResolutionQuality=0 to end up using the default project settings presets which for the case of the desktop renderer means temporal upscaling by default based on the display resolution like Fortnite's Recommended settings.
6.2) Performance 3D resolution preset: Sets sg.ResolutionQuality=100*1080/2160
6.3) Balanced 3D resolution preset: Sets sg.ResolutionQuality=100*1260/2160
6.4) Quality 3D resolution preset: Sets sg.ResolutionQuality=100*1440/2160
6.5) Native 3D resolution preset: Sets sg.ResolutionQuality=100

#rb rob.srinivasiah, jack.porter, juan.canada, allan.bentham
#jira UE-184651

[CL 25988162 by guillaume abadie in ue5-main branch]
2023-06-14 14:28:12 -04:00
kirill zorin
de8db5ff76 Converting ARO-facing raw pointers to TObjectPtr ahead of raw pointer ARO API deprecation.
#rb zousar.shaker
#rb markus.breyer
#rb robert.manuszewski

#preflight 646391406b1406b54ab15460

[CL 25489627 by kirill zorin in ue5-main branch]
2023-05-16 10:52:49 -04:00
mikalai sukhikh
f6ea3b88d9 Add CVar setting node in AFunctionalTest class
#jira UE-171493
#rb adam.miezianko, chris.constantinescu, jerome.delattre
#preflight 64524cb90722d4f6a2dd4351
#preflight 64524cf20722d4f6a2dd4728

[CL 25370907 by mikalai sukhikh in ue5-main branch]
2023-05-08 10:57:51 -04:00
zahra nikbakht
907774c04e non-unity error fix in Function UI test.
#jira none
#rb trivial
#preflight 64541f74023fe5d3ad4aec0a

[CL 25343520 by zahra nikbakht in ue5-main branch]
2023-05-04 17:54:06 -04:00