Commit Graph

14373 Commits

Author SHA1 Message Date
dan thompson
47c94de653 Testing the alpha detection based on the channel source info. This CL incorporates the original 30692988 as well as the fixes under review 30729887. The base problem is a race condition touching the lock mip data - read only mip locking shoulid if at all possible favor the MipData interface rather than LockMip*. RB list is from the two input CLs.
#rb fabian.giesen
#jira UE-204348

[CL 30785833 by dan thompson in ue5-main branch]
2024-01-22 16:36:00 -05:00
aditya ravichandran
db87edff5e ToolMenus: Fix a bug where menu contexts would be incorrectly cleaned up during menu refresh
This fixes a crash on hovering over the "transform" submenu in the light mixer context menu

#jira UE-203032
#rb Jamie.Dale
[FYI] Jason.Walter

[CL 30778338 by aditya ravichandran in ue5-main branch]
2024-01-22 12:30:24 -05:00
ionut matasaru
1d3ef9d1d0 [Insights]
- Callers and Callees: Added Average (Inclusive and Exclusive) Time columns for Callers and Callees tree views.
  - Callers and Callees: Fixed tooltip to hide stats that are not computed (Min/Max/Median).

#rb Catalin.Dragoiu

[CL 30773343 by ionut matasaru in ue5-main branch]
2024-01-22 10:27:50 -05:00
evgenii babinets
40709a976b [Backout] - CL30692988
[FYI] Dan.Thompson
Original CL Desc
-----------------------------------------------------------------
Testing the alpha detection based on the channel source info.
#rb fabian.giesen
#jira UE-175146

[CL 30772929 by evgenii babinets in ue5-main branch]
2024-01-22 10:15:58 -05:00
evgenii babinets
8f67c5bef7 [Backout] - CL30697260
[FYI] Dan.Thompson
Original CL Desc
-----------------------------------------------------------------
Removing texture build metadata due to ddc complexities. It will be added to the metadata system in the new build flow SoonTM. Additionally, the alpha information for the source mips is no longer necessary as that is computed elsewhere now.
#rb fabian.giesen
#jira UE-183750

[CL 30772772 by evgenii babinets in ue5-main branch]
2024-01-22 10:12:42 -05:00
ionut matasaru
a8078ce4c2 [Insights] Updated limits for detecting too much data accumulated by trace analysis (number of parsed events).
#rb Johan.Berg

[CL 30770758 by ionut matasaru in ue5-main branch]
2024-01-22 09:24:24 -05:00
thomas sarkanen
266d9b077d Added the ability to add comments to curves on animations
Comments are added from the curve's outliner menu. Editing can just be done by clicking the comment after it has been created
Also exposed the setting to view curves in a tree view in the timeline itself

NOTE: this removes a 4.5 core redirect from CurveName to LastObservedName as CurveName was reinstated as the canonical name for the curve, and having the redirect in place causes issues with tagged property serialization when new properties are added.

#jira UE-203593
#rb Nicholas.Frechette

[CL 30769970 by thomas sarkanen in ue5-main branch]
2024-01-22 09:01:15 -05:00
ionut matasaru
2790f51cf7 [Insights] Added validation for renaming a utrace file with an empty name.
#rb Catalin.Dragoiu

[CL 30768333 by ionut matasaru in ue5-main branch]
2024-01-22 08:10:40 -05:00
ionut matasaru
9bf87dd93c [Insights] Improved error detection for timing region events. A zero duration region will be created automatically if begin and end events do not match. Excluded warnings for "<SlowTask>" regions as begin-end events are known to mismatch.
#rb Catalin.Dragoiu

[CL 30767803 by ionut matasaru in ue5-main branch]
2024-01-22 07:58:35 -05:00
oleg krasnov
d63fe33e5d AutomationTest - Add support for a task tracker field in the Exclude Test Options
#jira UE-202465
#rb Jerome.Delattre
#rnx

[CL 30764013 by oleg krasnov in ue5-main branch]
2024-01-22 01:42:51 -05:00
steve robb
6d5b974842 Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.
[CL 30735396 by steve robb in ue5-main branch]
2024-01-19 19:41:56 -05:00
steve robb
f029468598 Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.
[CL 30729174 by steve robb in ue5-main branch]
2024-01-19 16:41:35 -05:00
andrew phillips
87499e5576 Added warning about packages that cannot be found when wanting to be copied.
[CL 30724980 by andrew phillips in ue5-main branch]
2024-01-19 14:55:11 -05:00
catalin dragoiu
d5e7c9474a [Insights] Support for basic filters in the Asset Loading Track.
#jira UE-195438,UE-203423
#rb ionut.matasaru

[CL 30718110 by catalin dragoiu in ue5-main branch]
2024-01-19 11:59:24 -05:00
halfdan ingvarsson
1973de9e78 Skeletal Mesh: No need to warn on missing mesh description when processing vertex attributes since we might be processing a dependent LOD.
#rnx

[CL 30717687 by halfdan ingvarsson in ue5-main branch]
2024-01-19 11:49:11 -05:00
halfdan ingvarsson
b692d6e175 Skeletal Mesh: Change the import storage to use FMeshDescription instead of FSkeletalMeshImportData. This includes deprecating the USkeletalMesh::LoadLODImportedData and friends, in lieu of an API more similar to the one on UStaticMesh (GetMeshDescription/CommitMeshDescription/etc).
#jira UE-166343
#rb Alexis.Matte, benoit.gadreau, john.vanderburg

[CL 30711382 by halfdan ingvarsson in ue5-main branch]
2024-01-19 00:37:06 -05:00
zousar shaker
662d9b1d71 Adjusting logs related to zen usage to:
- Remove repeated log related to fetching cache stats
- Ensure that the Zen cache usage has log lines explaining the status of the caches it attempts to connect to (success or failure)

#rb Matt.Peters

[CL 30710842 by zousar shaker in ue5-main branch]
2024-01-18 22:43:41 -05:00
dan thompson
99e50792ea Removing texture build metadata due to ddc complexities. It will be added to the metadata system in the new build flow SoonTM. Additionally, the alpha information for the source mips is no longer necessary as that is computed elsewhere now.
#rb fabian.giesen
#jira UE-183750

[CL 30697278 by dan thompson in ue5-main branch]
2024-01-18 16:38:20 -05:00
dan thompson
48136a6f1f Testing the alpha detection based on the channel source info.
#rb fabian.giesen
#jira UE-175146

[CL 30693168 by dan thompson in ue5-main branch]
2024-01-18 14:54:53 -05:00
devin doucette
e675fcb5b5 DDC: Exposed metadata more extensively in the build API
#rb Zousar.Shaker

[CL 30691096 by devin doucette in ue5-main branch]
2024-01-18 14:06:50 -05:00
sergei svetlov
c739c0cb35 Clean up screenshot comparison report pipeline
#rb Jerome.Delattre
#jira UE-200919
#rnx

[CL 30687983 by sergei svetlov in ue5-main branch]
2024-01-18 12:22:38 -05:00
nick edwards
642f1a39bb Allow enabling/disabling LiveCoding via command line switch -LiveCoding=true|false
Useful in cases where there are multiple live coding targets, and you are only interested in having live coding enabled for one.
#rb Tim.Smith

[CL 30686790 by nick edwards in ue5-main branch]
2024-01-18 11:54:34 -05:00
wouter burgers
2daa2f0820 SkeinUE: Fixed conflicted icon incorrectly being white in some areas since #30499647.
[FYI] manuel.lang
#rnx

[CL 30684127 by wouter burgers in ue5-main branch]
2024-01-18 10:27:11 -05:00
aris theophanidis
8ae2292282 Remove Compression.h from CoreMinimal.h
It's about 1/4 of CoreMinimal.h but rarely needed (Compression.h pulls on CriticalSection.h and Map.h that are costly).
#rb Yoan.StAmant

[CL 30683417 by aris theophanidis in ue5-main branch]
2024-01-18 09:56:55 -05:00
paul chipchase
dd52744c0a Add option (disabled by default) for IAS to write out one toc per container rather than a single all encompassing toc.
#rb Per.Larsson
#jira UE-189912
#rnx

### IAS
- The previous version of this system worked by appending IAS data to the end of .utoc files and using that data to generate the FOnDemandTocContainerEntry data that we needed, however we don't want to do this long term as we want to remove the IAS code from IoStoreUtilities. So instead we want to store a FOnDemandToc for each .utoc that would contain on demand data, where the FOnDemandToc contains a single FOnDemandTocContainerEntry detailing the chunks that it has access to. Then when we mount a .pak we can mount this new file (currently called .uondemandtoc) if it exists for that .pak file, in the exact same way that we would mount a .utoc.
- Note that for now we will continue to produce and use the single large .iochunktoc file as before. This new code path does work for basic games but will need more testing and work before it will function correctly in all cases.
-- Both the old format (.iochunktoc) and the new format (.uondemandtoc) are only produced if the cmdline arg '-WriteTocToDisk' is passed to UnrealPak.
- Added a new global string 'GIasOnDemandTocExt' to allow us to change the extension easily in the future. Currently set to .uondemandtoc.
- There are a number of places that require us to calculate paths based on the provided service url and other server configuration options. This code has been moved to it's own function 'ResolvePaths' so that it can be reused.
-- Previously this code was in IoStoreUtilities where it was used to write out the .ini file. As it has been moved to the IoStoreOnDemandModule we now return the paths as part of FIoStoreUploadResult so that the ini file can continue to use the info.
- Removed the cvar 's.IasGenerateOnDemandToc' and 'ias.LoadOnDemandToc and replaced it with a new cvar 'ias.TocMode which is an int rather than a bool and allows us to select the type of toc loading that we want to do (load from .iochunktoc, download a .iochunktoc or use the new .uondemandtoc files).
-- Using enums as cvars is discouraged so instead of using the cvar directly we use an accessor function ::GetTocMode which converts the cvar to an enum (ETocMode) and gives errors if the cvar is invalid.
- FOnDemandIoStore::AddToc has been extended to work with the traditional toc methods (where TocPath is a path to a file) and the new method (where TocPath is just the filename).
-- The old method needs to parse the prefix, but the new method will store the path as "ChunksDirectory".
- All code for generating toc info from .utoc files has been removed as well as the code to verify that a generated FOnDemandToc is the same as the version downloaded from the network. Code that was working on both loaded and generated tocs has been renamed to reflect that we only load tocs now.
- When mounting FOnDemandIoBackend and using the new method we first hook into the newly added GetPakMountOperationDelegate in the PakFile system so that we are notified about new pak files being mounted followed by an attempt to find the pakfiles that have already been mounted and catch up by mounting any corresponding .uondemandtoc files.

## IAS Misc
- Minor Optimization: Changed some const FString& parameters to FStringView in places that were commonly being called with a TCHAR* string to avoid the implicit FString conversion.
- Minor Optimization: Presize some arrays during UploadContainerFiles to avoid unnecessary resizing and copying.
- Fixed some typos.
- Removed any remaining reference to the pakfile module as all communicate is via core delegates.
- When uploading we no longer log the containers that we are skipping.
- Changed the logging of uploaded chunks from Display to Log to reduce output spam.

[CL 30680833 by paul chipchase in ue5-main branch]
2024-01-18 06:43:29 -05:00