Commit Graph

495 Commits

Author SHA1 Message Date
steve robb
f029468598 Fixed up a lot of bool-taking container resize functions to take EAllowShrinking instead.
[CL 30729174 by steve robb in ue5-main branch]
2024-01-19 16:41:35 -05:00
phil popp
b3db59ff1d Fix remaining failures in metasound automated node tests
#rb Rob.Gay
#jira UE-198649

[CL 30688714 by phil popp in ue5-main branch]
2024-01-18 12:47:05 -05:00
helen yang
7d074697a0 Add Find tab for searching within a MetaSound
- Search by node/pin name string, node type, data type, display name, value, or comment
- View default literal values (including marking overridden inputs, array num), extended values on tooltip
- Jump to result in graph on click
#jira UE-200535
#rb Rob.Gay

[CL 30662993 by helen yang in ue5-main branch]
2024-01-17 13:17:18 -05:00
sarah noonan
63b9103240 Delay MetaSoundSource calling RegisterGraphWithFrontend if the MetaSoundAssetManager has not been set yet - to facilitate server preloading assets before the manager has been set.
#rb Rob.Gay

[CL 30655975 by sarah noonan in ue5-main branch]
2024-01-17 07:07:19 -05:00
marc audy
56a32fea9d Silence false V621, V654, and V1078 warnings mostly caused by TStaticArray, placement new, or population of the array inside a lambda
[CL 30587485 by marc audy in ue5-main branch]
2024-01-12 00:52:57 -05:00
rob gay
1ed21ae9e0 Fix for compiled out path setter, le sigh
#rb helen.yang

[CL 30491013 by rob gay in ue5-main branch]
2024-01-08 17:02:57 -05:00
rob gay
e5fa925482 Fix incorrect transient asset path being registered at times due to template node processing generating new transient object representing provided document interface object. (Added bonus with BuildRegistryDoc now actually living in RegistryImpl private implementation where it should've to begin with rather in asset base now that registration headers have been cleaned up).
#rb helen.yang
#jira UE-198785
#rnx

[CL 30424305 by rob gay in ue5-main branch]
2023-12-20 19:49:45 -05:00
cody albert
14db176493 MetaSounds: Clamp RandomGet node's NoRepeats value immediately instead of waiting until it's saved to the RandomGets map. This fixes an issue where Shared State wouldn't work if No Repeat value was being clamped since the comparison would always indicate it needs to be stomped.
#rb helen.yang
#jira UE-203067

[CL 30415551 by cody albert in ue5-main branch]
2023-12-20 12:45:12 -05:00
rob gay
b7ecd11142 Remove and assert against registration/unregisteration calls of MetaSound graphs when cooking, and make all node unregistration calls synchronous when cooking
#rb helen.yang
#rnx
#tests AudioUnitTests, AudioQA -run=Cook -TargetPlatform=WindowsClient, rename asset, run Engine 'Audio' Automated Tests

[CL 30402526 by rob gay in ue5-main branch]
2023-12-19 15:55:04 -05:00
rob gay
5668343434 Don't warn for missing unregistration tasks in cook, where graphs are not registered
#rb helen.yang
#rnx

[CL 30383889 by rob gay in ue5-main branch]
2023-12-18 17:29:43 -05:00
AdricEpic
473f754908 - Registration Race Condition Fixes (Attempt #2 w/ cook fixes)
- Part 1/2 fixing inconsistent file naming that is causing code query tool slowdowns (2/2 will be deprecating old MetasoundFrontendRegistries.h header path)
- Replace SoftObjectPaths with TopLevelAssetPaths for perf (ObjPaths do string copies all over, TopLevelAssetPaths are just two FNames)
#rb helen.yang
#rnx
[FYI] sondra.moyls
#tests AudioQA/EngineTest MetaSound Automated Tests, AudioTests, cook WindowsClient, submit and backout and then fix those problems
#jira UE-198785

[CL 30354102 by AdricEpic in ue5-main branch]
2023-12-15 13:21:12 -05:00
rob gay
65111a0774 Fix for cook errors, undo changelist 30246187
#rb helen.yang
#rnx

[CL 30255375 by rob gay in ue5-main branch]
2023-12-11 20:36:24 -05:00
rob gay
a876bffd23 - Registration Race Condition Fixes
- Part 1/2 fixing inconsistent file naming that is causing code query tool slowdowns
- Replace SoftObjectPaths with TopLevelAssetPaths for perf (ObjPaths do string copies all over, TopLevelAssetPaths are just two FNames)
#rb helen.yang
#rnx
#tests AudioQA MetaSound Automated Tests, AudioTests
#jira UE-198785

[CL 30246215 by rob gay in ue5-main branch]
2023-12-11 14:43:42 -05:00
evgenii babinets
3c155122fc Isolating out some easy wins from deeper investigations into audio parameter optimizations. The biggest change is to the array parameter version of FAudioParameter::Merge where we'll now avoid sorting both arrays and just doing a binary search into the output array. This results in fewer shifting inserts as well, since the order of the output array is not required to be sorted.
Saves about 0.15ms with a dozen AudioComponentGroups updating parameters per frame.

#rb jordan.cristiano, miles.flanagan, Rob.Gay

[CL 30156944 by evgenii babinets in ue5-main branch]
2023-12-06 11:14:23 -05:00
rob gay
39b3a6f74c [MetaSounds] Report changes to transmitter and runtime input map when live edits are enabled during Builder audition
#rb charlie.huguenard
#rnx
#tests Audio Engine Tests including ConnectInputAfterAuditionAndThenSetParameter, Audio Unit Tests
#jira UE-201185
[FYI] sondra.moyls

[CL 30045928 by rob gay in ue5-main branch]
2023-12-01 12:57:59 -05:00
rob gay
96aefd1da4 Add fix for PostExecuteInput types (i.e. triggers) throwing an assert when dynamically connecting a new owner to a referenced graph from attempting to rebind a read only data reference to a writable one.
#rb charlie.huguenard, helen.yang
#jira UE-201187

[CL 29938339 by rob gay in ue5-main branch]
2023-11-27 12:58:53 -05:00
marc audy
763a611985 Fix C4072 warnings
#rnx

[CL 29852844 by marc audy in ue5-main branch]
2023-11-20 17:26:53 -05:00
helen yang
5cf01ed82f Fix MetaSound reset to default arrow still showing even after literal has been set to default
#jira UE-197245
#rb rob.gay

[CL 29697592 by helen yang in ue5-main branch]
2023-11-13 17:34:23 -05:00
rob gay
10f2c62d17 Minor clean-up from prior CR
#rb helen.yang
#rnx

[CL 29695691 by rob gay in ue5-main branch]
2023-11-13 16:47:48 -05:00
daniele vettorel
e11e748b14 Use BusyWait instead of Wait in tasks run on worker threads.
On low core count machines where there are only a couple worker threads, waiting from a worker thread with a blocking Wait can mean it ends up deadlocking. BusyWait will ensure the worker thread processes outstanding tasks while it waits and makes forward progress.

[CL 29594418 by daniele vettorel in ue5-main branch]
2023-11-09 09:08:17 -05:00
phil popp
f6de0453fd Fix ensure when trying to get an array of integers
#rnx
#jira UE-199655

[CL 29421711 by phil popp in ue5-main branch]
2023-11-03 16:58:58 -04:00
rob gay
9ec52c5d42 Only register assets requested from builder if never built or if builder has transactions logged requiring re-registration (CVar disabled, will enable in subsequent change)
#rb phil.popp
#jira UE-198400
[FYI] helen.yang, Maxwell.Hayes, sondra.moyls, charlie.huguenard

[CL 29291747 by rob gay in ue5-main branch]
2023-10-31 17:16:11 -04:00
rob gay
500da9cd81 Fix async references not yet registered when auto-updating in editor
[FYI] phil.popp
#rb phil.popp

[CL 29283719 by rob gay in ue5-main branch]
2023-10-31 14:24:48 -04:00
helen yang
b0fcd3549d Move sound InitResources call in MovieSceneAudioSection to PostLoad and prevent registration of invalid MetaSound registry keys
#rb brian.chrisman, phil.popp

[CL 29117970 by helen yang in ue5-main branch]
2023-10-25 22:31:43 -04:00
phil popp
8d910c48d9 Metasound static analysis fix
#rnx

[CL 28984280 by phil popp in ue5-main branch]
2023-10-20 17:47:14 -04:00