Commit Graph

26 Commits

Author SHA1 Message Date
robert manuszewski
5acf09e035 Support for Incremental Gather Unreachable Objects
Split unreachable clusters destruction to DissolveUnreachableClusters (non-incremental as it's very fast)
Flipping MaybeUnreachable -> Unreachable flag is now a single Swap() function call (MaybeUnreachable / Unreachable flags are deprecated and replaced with interchangable Reachability flags)
GatherUnreachableObjects will now only gather unreachable objects for NotifyUnreachableObjects call and perf gains during unhashing and purging all objects.
Enable with gc.AllowIncrementalGather=1

#rb Johan.Torp, PJ.Kack

[CL 30033914 by robert manuszewski in ue5-main branch]
2023-12-01 04:39:57 -05:00
ben hoffman
79cd1dad96 Update the label on the asset creation tab to mark Player Mappable Input Config types as deprecated
#rb justin.hare
#rnx

[CL 26775325 by ben hoffman in ue5-main branch]
2023-08-02 12:00:36 -04:00
ben hoffman
ade7c26f12 Remove dependency on InputBlueprintNodes from the InputEditor Module.
The Input Editor module has several features that are using the K2Nodes from enhanced input when it doesnt need to. The Blueprint Node logic should be kept in its own module.

This will allow the K2Nodes to actually read from editor settings and preferences in the rest of enhanced input, which would otherwise cause a circular depedency in the build graph.

This change is really just moving some functions from one module to another, neither module is publically exposed so no deprecation is required.

#rb trivial
#rnx
#preflight 645914ab4c3ec54e6e1070ec

[CL 25375925 by ben hoffman in ue5-main branch]
2023-05-08 15:46:28 -04:00
ben hoffman
35daf13171 Deprecate the Input Editor pieces that reference Player Mappable Input Configs
#jira UE-175936
#prerflight 644ad724b208f61af83532af
#rb trivial

[CL 25225421 by ben hoffman in ue5-main branch]
2023-04-27 18:48:10 -04:00
ben hoffman
119aaac9f9 Specify what asset is using the mapping name if one exists already, making it much easier to track down in use mappings :)
Add in a cvar 'EnhancedInput.Editor.EnableMappingNameValidation' to toggle name validation, just to make sure that we can do sanity checks that the validation is actually accurate

#rb nate.strohmyer
#rnx
#preflight 643712e90c4277fc0bce6fdf

[CL 25018938 by ben hoffman in ue5-main branch]
2023-04-12 19:29:49 -04:00
ben hoffman
f180f2cf58 Add a name validator to player mappable setting names. This makes it easier to avoid mistakes and possibly stomping a key binding.
The "Name" here is the FName that will be used as a key to save each key mapping during serialization, so they should be unique for each key mapping that you want the player to be able to set.

#jira UE-177248
#preflight 63f4ef2290198dffba48f6ee
#rb benjamin.fox
#rb nate.strohmyer
#rnx

[CL 24344605 by ben hoffman in ue5-main branch]
2023-02-21 13:37:27 -05:00
ben hoffman
a7e0d55954 Only attempt to auto upgrade to Enhanced Input if the project has a name. This solves an issue where you would get toasts about EI from the project launcher.
#jira UE-176155
#rb justin.hare
#pf 63e1344b797b029c0a65d67c

[CL 24034353 by ben hoffman in ue5-main branch]
2023-02-06 13:38:52 -05:00
henrik karlsson
2f78497e67 [Engine/Plugins]
* Updated private files with IWYU for all plugins which had 3 or less changes made in ue5 main since last integration to fn

#preflight 63bf8d8b577437afe607dc72
#rb none

[CL 23659643 by henrik karlsson in ue5-main branch]
2023-01-12 01:48:34 -05:00
nate strohmyer
e9f8692c7c Fixing action value type toast showing up when modifying triggers
#Jira UE-171429, UE-171434
#rb ben.hoffman
#preflight 6397cb4c35203bc7aa2aaaec

[CL 23601507 by nate strohmyer in ue5-main branch]
2023-01-06 14:37:17 -05:00
nate strohmyer
c4b2e38146 Making a Drag/Drop action for Input Actions into the Blueprint Graph
#Jira UE-161947
#rb ben.hoffman
#preflight 635c52813c0af539fd66d17c

[CL 23040016 by nate strohmyer in ue5-main branch]
2022-11-08 16:28:09 -05:00
henrik karlsson
4a5e13525d Fixed non-unity non-pch compile errors
#preflight skipped
#rb none

[CL 22788359 by henrik karlsson in ue5-main branch]
2022-10-26 16:22:34 -04:00
nick darnell
954d29b9f5 Editor - Beginning the process to no longer make loading all assets you right click in the content browser. The first step, is setting up the code to have a deprecation flag DEPRECATE_ASSET_TYPE_ACTIONS_NEEDING_LOADED_OBJECTS, this will make it illegal to implement GetActions on all AssetTypeAction implementations. Checked in disabled, enable it locally to begin trying to implement the recommended method detailed in the IAssetTypeActions header. WIP. One of the things this change does is outlaw (regardless of deprecation) the HasActions() function, this function is no longer used at all, and so we may as well remove its implementation, it also works well as a canary in finding other samples and things that need to be upgraded.
#jira UE-165574
[REVIEW] [at]Rex.Hill, [at]Lauren.Barnes
#preflight 63483c43ad0f7e2f20e44910

[CL 22534452 by nick darnell in ue5-main branch]
2022-10-14 16:59:41 -04:00
bryan sefcik
50d4fac9e0 Updated ../Engine/Plugins/... to inline gen.cpp files
Before:
3548 unity files
Total CPU Time: 47343.578125 s
Total time in Parallel executor: 494.60 seconds

After:
3445 unity files
Total CPU Time: 46044.671875 s
Total time in Parallel executor: 468.51 seconds

#jira
#preflight 63336159b20e73a098b7f24f

[CL 22218213 by bryan sefcik in ue5-main branch]
2022-09-28 01:06:15 -04:00
Mike Beach
706505599a Providing a hook for external sources to override the editor's main window, much like the project browser does. Allows plugins to provide their own kind of "start up check" dialog.
Switching over the project browser dialog to use the new system.

#rb Lauren.Barnes
#preflight 63293e08b40000c8f04da02a
#preflight 6329eb72fc7f1efbdf479b84

[CL 22100188 by Mike Beach in ue5-main branch]
2022-09-20 15:34:49 -04:00
nate strohmyer
fad5ae0c44 Enhanced Input: Add class picker for Input Action and Input Mapping Context factories (Contributed by aquanox)
#Jira UE-163457
#rb ben.hoffman
#preflight 6329ef49f87253e0211ce2e9
#9557

[CL 22098175 by nate strohmyer in ue5-main branch]
2022-09-20 14:16:40 -04:00
ben hoffman
02ca56b204 Fix a typo in the Input Action asset tooltip.
#jira UE-162104
#rb trivial
#rnx
#preflight skip

[CL 21598014 by ben hoffman in ue5-main branch]
2022-08-26 16:23:37 -04:00
ben hoffman
f394a7f57c Add a right click option to create a Mapping Context from the selected input actions. This will let you create an input mapping context that is pre-populated with some input actions!
#jira UE-159694
#rb nate.strohmyer
#rnx
#preflight skip

[CL 21467674 by ben hoffman in ue5-main branch]
2022-08-19 19:19:14 -04:00
ben hoffman
82fa48b2fb Add the Enhanced Input plugin icon!
#jira UE-155677
#rb trivial
#preflight 62d9ac003122bf80ae0d781b
#rnx

#ROBOMERGE-AUTHOR: ben.hoffman
#ROBOMERGE-SOURCE: CL 21210084 via CL 21210092 via CL 21210104
#ROBOMERGE-BOT: UE5 (Release-Engine-Staging -> Main) (v972-20964824)

[CL 21212301 by ben hoffman in ue5-main branch]
2022-07-21 19:35:26 -04:00
ben hoffman
ab22193bc8 Fix a build machine error where we would be trying to check out a file when source control is not enabled
#jira none
#rb phillip.kavan
#preflight 62c5f89bf5149833404b804a

[CL 20973884 by ben hoffman in ue5-main branch]
2022-07-06 17:22:56 -04:00
ben hoffman
c258e2736f Only attempt to save the input settings config file if it is writable. This solves an issue where a warning log would be printed if the file is currently checked out. This warning came from startup editor time upgrading of Input Classes to enhanced input, not just when you changed any input setting.
#rb justin.hare
#jira UE-158238
#preflight 62c44e2e3c5171c817a111d1
#rnx

[CL 20945359 by ben hoffman in ue5-main branch]
2022-07-05 13:30:30 -04:00
ben hoffman
036f3dc106 Automatically upgrade projects with the default input class to use Enhanced Input when the module starts. By default this behavior is on, but it can be turned off with the cvar "EnhancedInput.bEnableAutoUpgrade".
We have to set the input settings properties on StartupModule like this because the base UInputSettings cannot reference the Enhanced Input plugin without creating a circular dependency.

Upgrading the project only when the current project is set to the default input classes is safe because it won't upgrade any project that has a custom class set on either property, and we can set on class but not the other with no issues.

#jira UE-144847
#preflight 62b22004de72d4f6b3451290
#rb nate.strohmyer

[CL 20765419 by ben hoffman in ue5-main branch]
2022-06-21 16:59:35 -04:00
ben hoffman
1cfd429b17 Fix the display name on Player Mappable Configs in their asset creation factory. Now its consistent with the asset dipslay name.
#jira none
#rb trivial
#rnx
#preflight skip

[CL 20554489 by ben hoffman in ue5-main branch]
2022-06-08 07:20:11 -04:00
ben hoffman
cfab426af9 Add a style set for Enhanced Input so that the asset types have custom icons.
#jira UE-148432
#rb benjamin.fox
#preflight 6286c320045aba22797a5687

[CL 20296433 by ben hoffman in ue5-main branch]
2022-05-20 12:13:19 -04:00
ben hoffman
a81500a2d9 Fix a linux ASan error when shutting down the InputEditorModule. We can use ::StaticClass()->GetName because the UObject may be uninitalized already
#jira none
#rb none
#rnx
#preflight skip

[CL 19590001 by ben hoffman in ue5-main branch]
2022-04-01 12:19:08 -04:00
ben hoffman
0e0fe95da9 Refactor of the Enhanced Input Project Settings. This moves the Trigger and Modifier default value customizations to the "InputCustomizations" header file, and out of the InputEditorModule. This allows us to simply add a class customization for the Developer Settings, and combine the two setting panels.
#jira UE-144850
#rb andrew.davidson
#preflight 6245e42d8f066102242239d8

[CL 19577762 by ben hoffman in ue5-main branch]
2022-03-31 16:16:07 -04:00