- Defines will still be there if we're dumping the shader code for debug.
- This makes the code less unique in general case and also avoids unnecessary works that no one sees.
#rb Lukas.Hermanns
[FYI] Lukas.Hermanns, Rolando.Caloca
#ROBOMERGE-SOURCE: CL 11311362 via CL 11311438
#ROBOMERGE-BOT: (v653-11302973)
[CL 11311455 by arciel rekman in Main branch]
#rnx
#rb none
#ROBOMERGE-SOURCE: CL 10869240 via CL 10869516 via CL 10869902
#ROBOMERGE-BOT: (v613-10869866)
[CL 10870584 by ryan durand in Main branch]
Depends on 4861258!
#jira UE-69189
#rb none
[FYI] morten.vassvik
#ROBOMERGE-SOURCE: CL 4861438 via CL 4865436
[CL 4873048 by matt collins in Main branch]
Catching up 4.20 to Dev-Niagara as of CL 4111104
#rb none
#tests PC and PS4 auto-tests pass
Change 4075849 by Wyeth.Johnson
Metadata on location and velocity modules, new DI
Change 4076028 by Frank.Fella
Niagara - Fix an issue where the list of relevant scripts in the shared script view model could get out of sync when changing properties on an emitter such as interpolated spawning and gpu simulation. This could result in an emitter recompiling forever if it started as GPU and was then switched to CPU and then a force compile was requested since it would include the GPU script when determing the compile status, but it would never compile it.
#jira UE-59220
Change 4076925 by Frank.Fella
Niagara - Adding and removing pins from an assignment node wasn't correctly invalidating the graph which I broke with my crash fix 4058428 since I thought the refresh call would do that.
#jira UE-59249
Change 4076971 by Frank.Fella
Niagara - Made few changes to stack issue handling while fixing an issue where the stack error wouldn't change when the compile error changed.
+ Changed the unique identifier for stack issues to be automatically generated from a hash of the combined stack editor data key and the long description of the error.
+ Changed the stack issue unique identifier from an FName to an FString to avoid poluting the name table with lots of generated hash strings.
+ Encapsulated all of the stack issue data to validate the required inputs.
#jira UE-59251
Change 4076974 by Frank.Fella
Niagara - Minor change missed in last checkin.
Change 4076990 by Frank.Fella
Niagara - Fix the assignment node so that it uses a "Begin Defaults" node instead of a regular input node when it's hooking up linked defaults.
#jira UE-59224
Change 4077392 by jonathan.lindquist
Changing pin order
Change 4077426 by Wyeth.Johnson
transform position DI
Change 4077636 by Frank.Fella
Niagara - Fix an issue where the stack function input collection wasn't generating errors correctly due to data being cached between refreshes which became stale.
#jira UE-59269
Change 4078004 by jonathan.lindquist
Submitting progress on a module
Change 4078009 by jonathan.lindquist
changing a variable name in rotate around point
Change 4078043 by Frank.Fella
Niagara - Fix the stack function input so that it cleans up properly when removing pins from assignment nodes, also fix undo for the remove operation.
#jira UE-59271
Change 4078063 by Shaun.Kime
Fixing debug particle data texture usage
#tests n/a
Change 4079110 by jonathan.lindquist
Submitting a cone mask function
Change 4079161 by jonathan.lindquist
Adding a new cone mask module
Change 4079164 by jonathan.lindquist
Adding a description to the cone mask function
Change 4079166 by jonathan.lindquist
Submitting a new cone mask dynamic input
Change 4079988 by Yannick.Lange
Set persistend guid for if node input pins on creating a new output pin.
Change 4080531 by jonathan.lindquist
New cone based mask for curl noise contributions. Additional meta data descriptions for other inputs.
Change 4080541 by jonathan.lindquist
Exposing the cone axis variable
Change 4080544 by jonathan.lindquist
One more meta data tweak :D
Change 4081107 by Shaun.Kime
Fixing underlying GPU collision system after Rendering refactored to use the FSceneTexturesUniformParameters instead of individual textures. Note that GPU collision only works with the primary back buffer. We will need more work to support split-screen or PIP.
#tests Collsion test GPU now is functional, but we still get a few nondeterministic strays in different directions keeping me from turning it on at the moment
Change 4081111 by Shaun.Kime
Updating the compile GUID because the previous change adjusted generated code
#tests n/a
Change 4081231 by Shaun.Kime
Allowing several descriptions to be multiline, accessible by Shift + Enter.
#tests created descriptions for both module fields and modules themselves that were multi-line. confirmed UI was correct.
Change 4081552 by Jonathan.Lindquist
Additional tooltips/documentation
Change 4081566 by Jonathan.Lindquist
Changing split linear color's pin order
Change 4081646 by Shaun.Kime
Added tooltips to the parameter map get and set nodes that should grealy improve understanding.
#tests n/a
Change 4082769 by Yannick.Lange
Pins and parameters unique name on creation
Change 4082792 by Yannick.Lange
Fix: Adding a property pin to a Niagara Module Script map node creates a duplicate of that property in the Properties menu
#jira UE-58823
Change 4082851 by jonathan.lindquist
Ensuring that the latest version of this content is available for Simon
Change 4082875 by Yannick.Lange
Parameter, source and dest pins of a parameter map node have a subcategories. Only pins with the parameter subcategory will be found by the graph.
#jira UE-57692
Change 4083076 by Wyeth.Johnson
Gnomon asset for example content
Change 4083783 by Frank.Fella
Niagara - Fix issues with drag/drop
+ Don't allow the user to drop a module if the usage flags of the target script aren't supported.
+ Allow dragging to different scripts event if they are in different graphs, or different emitters.
+ Transfer rapid iteration paramters correctly when moving modules between scripts.
+ Fix undo for rapid iteration paramters when undoing a move.
#jira UE-59340
#jira UE-59401
Change 4083999 by Bradut.Palas
Improved functionality of module dependencies: intercategory module dependencies now work, module order is fixed.
#tests none
#jira UE-58200
Change 4084002 by Shaun.Kime
Validating modules reads and writes.
You cannot read/write from particles namespace in system and emitter scripts
You cannot write to user or NPC namespaces ever
You cannot write to system/emitter namespaces in particle scripts
#tests auto-tests pass
Change 4084419 by jonathan.lindquist
Changing default texture assignments to work with the new project directory.
Change 4084595 by jonathan.lindquist
Submitting a new material that will generate a 3d sphere on a sprite using world position offset and pixel depth offset.
Change 4084603 by Jonathan.Lindquist
New thumbnail
Change 4084607 by jonathan.lindquist
Submitting final variable settings for the skeletal mesh reproduction particle system
Change 4084649 by jonathan.lindquist
Finalizing sampling mesh code after exploring multiple approaches.
Change 4084746 by Frank.Fella
Niagara - When creating the render state in the niagara component, also send the dynamic data the same frame since the emitter might not actually tick the next frame.
#jira UE-57696
#tests engine tests.
Change 4085536 by Yannick.Lange
Fix assert attempting to add a Niagara emitter parameter to a system before tracking an emitter.
Also passes all graphs to the add button, to avoid any use of Graphs[0] in SNiagaraParameterMapView.
#jira UE-58832
Change 4085757 by Yannick.Lange
Prevent circular connections when trying to connect pins
#jira UE-55541
Change 4086086 by Bradut.Palas
Fixing static code analysis issues by moving the RefreshIssues call inside the FunctionCallNode nullcheck
#tests none
Change 4086155 by jonathan.lindquist
Updating meta data etc.
Change 4086965 by Olaf.Piesche
Fixing uniform buffer alignment and padding to 16 bytes for all vector types; bumping vec2 and vec3 uniforms to vec4, and adding component mask to code chunk for accesses to uniform chunks according to their initial type
OpenGL requires this since because adherence to the std140 memory layout is shaky at best when it comes to sub-16-byte vector types
Change 4086968 by Olaf.Piesche
Making division by 0xFFFFFFFF explicitly unsigned, because OpenGL otherwise assumes it's a signed int, just dividing by -1
Change 4086975 by Frank.Fella
Niagara - Renderer update fixes.
+ Trigger data object changed when adding, removing, and changing the enabled state of renderers so that the simulation updates.
+ Fix undo for changing the enabled state on renderers.
#jira UE-57696
#jira UE-59390
Change 4087008 by Frank.Fella
Niagara - When refreshing the sequencer tracks in the emitter/system editor don't set sequencer the time to 0. This fixes an issue where modifying data in the timeline and undo would reset the time to 0 when paused rather than resimulating.
#jira UE-59463
Change 4087030 by Shaun.Kime
Fixing when you can create certain pin types to prevent invalid types from appearing in the list.
#tests autotests pass on PC
Change 4087271 by jonathan.lindquist
Adding an option to clamp particles.velocity's magnitude.
Change 4087279 by Wyeth.Johnson
Comments and dependencies
Change 4087333 by Wyeth.Johnson
Bitmask useage flags on forces to adhere to standards, plus dependencies
Change 4087636 by Wyeth.Johnson
Age related dependencies on update modules
Change 4087702 by Shaun.Kime
Getting translation set up for Frank's rapid iteration parameter rework in support for default dynamic inputs
#tests n/a
Change 4087992 by jonathan.lindquist
Adding a limit force module
Change 4088872 by Yannick.Lange
Fix renaming variables will not work if the user is only changing capitalization.
#jira UE-59119
Change 4088891 by Yannick.Lange
Fix adding a new attribute makes it hidden in the attribute spreadsheet. Now shows the added attribute when doing a new capture.
#jira UE-57167
Change 4089072 by Yannick.Lange
Reorder parameter list categories
Change 4089164 by jonathan.lindquist
Adding a velocity clamp feature and an acceleration clamp
Change 4089953 by Bradut.Palas
Disabled modules no longer display errors.
Also, enabling/disabling modules is now registered with the Undo system
Also fixed the GUID generation for all issues, now issues are properly differentiated from each other on refresh.
#tests none
Change 4090194 by Shaun.Kime
Fixing auto tests after acceleration force defaulted to world instead of local
#tests all pass
Change 4090195 by Shaun.Kime
Cleaning up UI for code view
#tests n/a
Change 4090198 by jonathan.lindquist
Setting the fallback vector to 0,0,0
Change 4090430 by jonathan.lindquist
Removing a reciprocal operation from the node. Now we use a single divide. Also, I added another length calculation to provide the proper length of the input fallback vector. This is important for cases in which the user specifies that the fallback vector should be 0,0,0 or another unnormalized value. Previously, the fallback vector length always returned 1.
Change 4090512 by Shaun.Kime
Fix for crash during Jonathan's deletion of the Set node in SolveForcesInVelocity.
#tests n/a
Change 4090534 by jonathan.lindquist
New acceleration limit
Change 4090676 by Olaf.Piesche
GPU Spawning auto test
Change 4090770 by Shaun.Kime
Curl noise bug test case
Change 4090796 by Olaf.Piesche
Added missing abs for GPU sim
Change 4091368 by Bradut.Palas
Also removing issues from disabled input collections and renderer items
#tests none
Change 4091417 by Simon.Tovey
Making emitter local space a constant embeded directly into emitter and particle scripts.
Allows a lot of optimization and exposes the value to emitter scripts properly.
Change 4091727 by jonathan.lindquist
Exposing delta time as an advanced input and organizing the graph
Change 4091788 by Bradut.Palas
#jira UE-54678 fIxing issues with refresh of skeletal mesh details
#tests none
Change 4092040 by Frank.Fella
Niagara - Fix some issues with modify, transactions, and change ids which was causing assets to be dirty or modified on load, or were allowing internal operation to be undone.
+ Move some transactions from public utility functions into private functions called by menu items in the UNiagaraNodeWithDynamicPins.
+ Prevent a few modify calls in UNiagaraEmitter from marking the package dirty since they're sometimes called as a result of compiling and in the other cases earlier modifies would have already marked the package dirty.
+ In the system view model, don't create transactions when adding an emitter if the system view model is in emitter asset mode since the user should be able to undo it.
+ In the system toolkit when opening an emitter asset initialize, clean up, and propagate the rapid iteration parameters before copying the emitter to prevent the change ids from getting out of sync after the compile completes.
+ In the system toolkit when trying to see if an emitter has changed using the change ids, use the last synced id from the copied emitter instead of the original emitter since duplicating the emitter can change the id, and there's not way to set it externally.
#jira UE-59517
#jira UE-59566
Change 4092700 by jonathan.lindquist
Removed param groups. We're now using inline bools to enable or disable limits on velocity and acceleration
Change 4093032 by Shaun.Kime
Fixing display of errors
#tests now errors in compilation properly display
Change 4093172 by Shaun.Kime
Curl noise cpu/gpu test map
#tests added last known good
Change 4094156 by Damien.Pernuit
Fixed crash in the editor when opening a Niagara Emitter/Script containing outdated script functions.
Fixed incorrect type cast, FNiagaraFloat instead of FNiagaraInt32.
Change 4094515 by Tim.Gautier
Enabled Niagara + Niagara Extras in QAGame
Change 4094674 by jonathan.lindquist
submitting an example of variable defaults not working as intended
Change 4094712 by Damien.Pernuit
Niagara - Houdini:
Houdini Niagara Data Interface:
- Removed the GetCSVFloatValueByString function as String aren't currently supported by Niagara.
- Particles in the CSV file can now be updated over time (not just spawned)
- Added GetParticlePositionAtTime, GetParticleValueAtTime, GetParticleVectorValueAtTime returning a linearly interpolated value for a given particle at a given time.
- Added GetParticleIndexesAtTime for getting the previous/next row indexes and weight to access the values for a given particle at a given time and handle the interpolation of the values.
- Added GetCSVVectorValue for accessing a Vector value at a given row/col.
Houdini CSV Assets now looks for the following attributes in the CSV "Title" line:
- pos for position.
- id and # for particle ID.
- alive and life for calculating a particles LifeTime.
Change 4094932 by Frank.Fella
Niagara - Fix a few more issues where asset editors would open with their assets modified.
+ Fix rapid iteration parameter preparation so that it doesn't modify the parameter store if it doesn't change after syncing with the graphs and propagating from dependencies. This fixes the emitter editor allowing changes to be applied on open.
+ Refactor the change notification for the script tool kit so that it uses the graph change and property change messages to determine if any changes have been made and can be applied.
#jira UE-59517
#tests auto tests
Change 4094978 by Damien.Pernuit
Niagara - Houdini:
Houdini Niagara Data Interface:
- Since we can now update particles over time, renamed/modified most of the functions to make a clear distinction between row indexes (row) and particle ids (N)
- Replaced GetNumberOfPointsInCSV by GetNumberOfRowsInCSV and GetNumberOfParticlesInCSV
- Renamed GetParticleIndexesAtTime to GetRowIndexesForParticleAtTime and GetLastParticleIndexAtTime to GetLastRowIndexAtTime
- Fixed some DI Functions that were using floats for input parameter instead of using integers.
Change 4095428 by Damien.Pernuit
Niagara - Houdini:
Houdini Niagara Data Interface:
Fixed incorrect behavior of the GetLastRowIndexAtTime and GetParticleIndexesToSpawnAtTime functions due to supporting particle update over time.
Houdini CSV Asset:
Fixed missing UPropery for SpawnTimes and LifeValues array.
Change 4096355 by Damien.Pernuit
Houdini Niagara:
Fixed performance warning for UHoudiniCSV::GetParticleLifeAtTime()
Change 4096419 by Damien.Pernuit
Niagara - Houdini:
Houdini Niagara Data Interface:
Added GetParticleLifeAtTime for accessing a given particle's life at a given time value.
Fixed GetParticleVectorValueAtTime not bound properly.
Fixed GetRowIndexesForParticleAtTime returning incorrect values when the time value was past the particle's last update.
Change 4096466 by Damien.Pernuit
Niagara - Houdini:
- Added GetNumberOfColumnsInCSV to the Houdini Data Interface
- Added descriptions to the functions exposed by the DI
Change 4096528 by Damien.Pernuit
Niagara - Houdini:
Houdini CSV Asset:
- As the DI expects the values to be sorted by time, if it's not the case, the CSV importer will sort them on import.
- As the DI spawning functions relies on the particle IDs starting at zero and increment, the CSV importer will fix the particles IDs on import if it's not the case.
Change 4096838 by Yannick.Lange
Fix focus search box on add parameter menu
#jira UE-59502
Change 4097205 by Bradut.Palas
Fixes for metadata details in script toolkit (now the apply and compile buttons refresh and sort the metadata collection). The metadata functionality is fixed. Delete, add and modify work just as before, but the sorting isn't applied because refreshing the whole collection is skipped for internal changes.
#jira UE-58745
#jira UE-59589
#tests none
Change 4097593 by Shaun.Kime
Now generating compiler debug info for VM shaders just like the rest of Materials using the r.DumpShaderDebugInfo
#tests now properly generate data in a VM folder sibling to other generated debug shader data
Change 4097721 by Frank.Fella
Niagara - Make the lifetime of stack entries well defined so that we can safely remove delegate bindings and clear out pointers.
Change 4097962 by Bradut.Palas
Stack issues now update fix delegates on each refresh, even if the fix GUIDs don't change, to account for other possible changes in the graph. Had to introduce unique identifiers for fixes too, now the issue entry is using the same recycle mechanism for fixes that the base stack entry uses for issues.
#tests none
Change 4098063 by Frank.Fella
Niagara - Fix input initialization for drag/drop with a "Set Variables" node.
#jira UE-57699
Change 4098192 by Damien.Pernuit
Niagara - Houdini:
Houdini CSV Asset:
When importing the CSV file, the importer creates a list of the row indexes updating each particle.
This greatly improves performance when accessing data in large files with a lot of particles updating over time.
Change 4098406 by Damien.Pernuit
Niagara - Houdini:
Houdini Niagara Data Interface:
Added helper functions for accessing Color and Velocity values in the CSV file.
Houdini CSV Asset:
The importer now looks for the Color (Cd, color), Alpha (A, Alpha) and velocity (V) attributes.
Change 4099945 by Frank.Fella
Niagara - Fix op description tool tip and keyword searches in the graph add menu, fix and standardize tool tip handling for script objects in menus, and add support for keyword searches for user defined scripts to match the built in ops.
#jira UE-59402
Change 4100451 by Shaun.Kime
Fixing wyeth's torus error, which was caused by us not properly initializing defaults. We now initialize defaults in three waves in spawn scripts. Wave 1 are any straight up constants at the top of the spawn function. Wave 2 is inlined in spawn just before the function that needs them is called. Wave 3 is at the bottom of spawn in a section called HandleMissingDefaultValues.
Also updated the error and warning messages to be much clearer text.
#jira UE-59723, UE-59762
#tests auto-tests pass
Change 4100568 by Shaun.Kime
Removing the old compile debug file generation and now unified with the existing shader compiler workflow for the future.
If r.DumpShaderDebugInfo=1, make sure that we generate the assembly, ush, and params files in the Saved\ShaderDebugInfo\VM\<SYSTEM_NAME>\<EMITTER_NAME>\<SCRIPT_NAME_AND_USAGE_ID_IF_NONZERO>
#jira UE-59767
#tests auto-tests pass
Change 4100913 by jonathan.lindquist
changing the pin order
Change 4100932 by jonathan.lindquist
setting the input pin order on a, b and alpha
Change 4101546 by jonathan.lindquist
Submitting a dynamic input that returns the exec index as an int
Change 4101734 by Shaun.Kime
Fixing static analysis errors
#tests n/a
Change 4101736 by Shaun.Kime
Creating new last known good for GPU Functional Test auto-test
#tests n/a
Change 4102305 by Simon.Tovey
Fix for VM Crash
#codereivew Frank.Fella, Shaun.Kime, Olaf.Piesche
Change 4102552 by Yannick.Lange
Tooltip variable types
#jira UE-59520
Change 4102599 by Yannick.Lange
New variables in maps or parameter view will get the name Namespace.NewVariable. This is not an actual fix for UE-59633, but gives the user the incentive to rename variables.
#codereveiw Shaun.Kime
Change 4102752 by Yannick.Lange
Fix auto expanding all the sections for the niagara parameters list view.
#jira UE-59121
Change 4102779 by Yannick.Lange
Fix auto expanding all the sections for the niagara parameters list view. Fix incorrect comment changelist: 4102752
#jira UE-59121
Change 4103419 by Shaun.Kime
Fixing build issues
#tests n/a
Change 4103522 by Damien.Pernuit
Houdini - Niagara:
Big renaming pass on the Houdini CSV Assets and Data Interface to follow naming conventions:
Replaced the GetCSVXXX functions by GetXXXX (GetCSVPosition is now GetPosition)
Always use "row" instead of "line", "Point" instead of "Particle", "PointID" instead of "N" or "ID" etc.
Houdini Data Interface:
- Added the GetVectorValueEx and GetPointVectorValueAtTimeEx functions that allow the user to decide how the vector conversion from houdini to unreal's coordinate system is handled.
- Replaced the GetParticleLifeAtTime function by GetPointLife, that returns the life of a particle at spawn time.
- Added the GetPointType function returning the type of a given point.
Houdini CSV Asset:
- Added the editable SourceTitleRow UProperty.
Editing this will trigger a reimport of the source CSV file and might be used to fix/modify column titles in the file.
- Added support for "type" attributes.
- Removed the unused StringValues buffer and GetCSVStringValues() functions.
- Added assetTags so the Houdini CSV asset thumbnails show more infos on the CSV data.
- Added the "FindSourceCSV" asset action to browse to the source CSV file.
Change 4104008 by Shaun.Kime
Missing header in Monolithic builds
Fixed indent issues, was using spaces vs tabs
#jira UE-59705
Change 4105249 by Simon.Tovey
Fixes in VMM backend and propagation visitors to ensure proper optimization for VM external function calls.
also adding a visitor to strip empty stats scopes.
Change 4105250 by Simon.Tovey
Updated windows binaries for hlslcc
Change 4105283 by Yannick.Lange
Fix creating an input parameter node from an input pin.
#jira UE-57362
Change 4105509 by Yannick.Lange
Fix being able to drop parameters in the system view on incorrect execution categories.
Change 4105726 by Wyeth.Johnson
Fix detection of valid toolchain directories with Visual Studio 2017 desktop (change by Ben.Marsh)
Change 4105727 by Shaun.Kime
Fixing nightly build due to missing GetAssetTags definition due to mismatches in WITH_EDITORONLY_DATA
#tests n/a
Change 4106034 by Damien.Pernuit
Houdini-Niagara:
Houdini CSV Asset:
- Fixed build break due to GetAssetRegistryTags()
- Replaced the different hardcoded ColumnIndexes member variables by an array.
Change 4106254 by Frank.Fella
Niagara - Fix playback issues where completed systems wouldn't simulate again until you pressed play.
#jira UE-58616
#jira UE-58721
Change 4106617 by Frank.Fella
Niagara - Prevent crash on shutdown.
#jira UE-59516
Change 4106623 by Frank.Fella
Niagara - Fix static analysis warning for posible null dereference in UNiagaraScriptItemGroup
Change 4106983 by Shaun.Kime
Fix to prevent PS4 compiler warning during cook on ambiguous uses of AtomicAdd.
#tests doesn't cause cook errors now
Change 4106988 by Shaun.Kime
Resaved test assets with latest non-zero version
#tests cooking no longer complains about file versions
Change 4106992 by Shaun.Kime
Now when errors appear in a cook for Niagara GPU shaders, we see them in the same location as the cook log
#tests n/a
Change 4108852 by Simon.Tovey
Fix for transforms in emitter scripts.
Param->Dataset bindings weren't handling structs correctly.
Change 4109260 by Wyeth.Johnson
Normalize Vector dynamic input
Change 4109748 by Marcus.Wassmer
olaf.piesche: Fresh build of hlslcc for Mac
Change 4110624 by Rolando.Caloca
-fresh build of hlslcc for Linux
-fixed a warning in NiagaraStackModuleItem.cpp
Change 4111103 by Shaun.Kime
Fixing nightly build issues with redundant left and right side of &&
CI Issue:
d:\build\++ue4+dev-niagara+compile\sync\engine\plugins\fx\niagara\source\niagaraeditor\private\viewmodels\niagarasystemviewmodel.cpp(1425): warning V501: There are identical sub-expressions 'bStartedPlaying == false' to the left and to the right of the '&&' operator.
#tests auto-tests pass
Change 4111104 by Shaun.Kime
Fix for CI issue:
d:\build\++ue4+dev-niagara+compile\sync\engine\plugins\fx\niagara\source\niagaraeditor\private\viewmodels\stack\niagarastackscriptitemgroup.cpp(553): warning V595: The 'SourceModuleItem' pointer was utilized before it was verified against nullptr. Check lines: 553, 554.
#tests auto-tests pass
#ROBOMERGE-SOURCE: CL 4113881 in //UE4/Release-4.20/...
#ROBOMERGE-BOT: RELEASE (Release-4.20 -> Release-Staging-4.20)
[CL 4114750 by shaun kime in Staging-4.20 branch]
#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3853627 by Shaun.Kime
Merging using OrionDevNiagaraToUE4DevNiagara_DoNotUse VectorVM
#tests non-gpu auto tests pass
Change 3853628 by Shaun.Kime
Merging using OrionDevNiagaraToUE4DevNiagara_DoNotUse Runtime
#tests all non-gpu auto tests pass
Change 3853629 by Shaun.Kime
Merging using OrionDevNiagaraToUE4DevNiagara_DoNotUse Engine\Shaders
#tests all non-gpu auto tests pass
Change 3853630 by Shaun.Kime
Merging using OrionDevNiagaraToUE4DevNiagara_DoNotUse Engine\Plugins\FX
#tests all non-gpu auto tests pass
Change 3853631 by Shaun.Kime
Jonathan's material function from Orion\DevNiagara
#tests all non-gpu auto tests pass
Change 3853633 by Shaun.Kime
Merging using OrionDevNiagaraToUE4DevNiagara_DoNotUse EngineTest
#tests all non-gpu auto tests pass
Change 3853911 by Shaun.Kime
GPU rendering now works
#tests GPU tests now pass
Change 3854179 by Shaun.Kime
Removing dead system
#tests now just with a warning
Change 3854731 by Shaun.Kime
Checkpointing current work
#tests n/a
Change 3855080 by Shaun.Kime
Fixing not all control paths return a value error
#tests n/a
Change 3856185 by Bradut.Palas
MultiStack with pinning support.
#jira UE-53459
#tests none
Change 3856615 by Shaun.Kime
Preventing a null pointer dereference when copying unallocated data
#tests auto tests pass
Change 3856622 by Shaun.Kime
Getting rid of the bogus get alias method
#tests auto tests pass
Change 3856644 by Shaun.Kime
Adding the ability to query the number of filtered triangles, index those triangles directly, and compute the position, velocity, UV, and NBT of a triangle.
#tests all auto tests now pass
Change 3856645 by Shaun.Kime
Added several new auto tests and tweaked existing ones.
+ PerParticleRandom still had some randomness in it
+ UserColorCurve has a user color curve defined in 3 different components referencing the same system
+ BasicSkinnedEmitter has 4 skinning sub-tests, attached as a subcomponent, referencing a world skeletal mesh, using a material filter, and using a bone filter
+ added a skinning module that spawns based off exec index and a data interface that queries the number of triangles on a skeletal mesh.
#tests auto tests pass
Change 3856675 by Shaun.Kime
Fixing crash on delete of an emitter
#tests removed one and multiple emitters from active multi-emitter. No crash
#jira UE-54378
Change 3860613 by jonathan.lindquist
New dynamic input
Change 3862549 by Shaun.Kime
Missing last known good images
Change 3864525 by Simon.Tovey
Fix for vm compiler crash when using structs as constants.
#tests No longer crashes.
Change 3864729 by Frank.Fella
Sequencer - Fixed a few places which were modifying sequencer data, but not calling the NotifySequencerDataChanged.
Change 3864737 by Frank.Fella
Niagara - Fix the timeline in the niagara editor plus other fixes.
+ Turned on looping in the timeline by default.
+ Added simulation options to control playback in the editor, including turning off auto-play, disabling reset on change, and disabling resimulation when changing while paused.
+ Added a buttons to the timeline for each renderer an emitter has which shows a renderer specific icon and will allow navigation directly to the renderer with future stack changes.
+ Fixed issues in the emitter life cycle and spawn rate modules which were preventing delay and looping from working consistently. (includes auto-test)
+ Added top level metadata for modules.
+ Added the ability to add metadata to a module and it's inputs to allow it to be edited directly using timed sections in the timeline. Currently configured for the emitter life cycle module.
+ Changed the way the "MaxSimTime" on niagara component works so that it now represents the maximum frame time which should be used when seeking the component to the desired age. This previously was the maximum amount of simulation time to run which would prevent simple effects from simulating quickly, and would also allow more complicated effects to hang the UI while seeking.
+ Changed the behavior of niagara component when seeking to desired age so that it always uses the exact specified seek delta instead of trying to seek to the exact desired age.
+ Fixed the component so that systems which are seeking to the desired age in the editor no longer draw in fast forward mode.
+ Changed the default playback range for effects in the timeline from 1000 seconds to 10 seconds, and fixed the timeline so that the playback range is serialized into the asset which will persist the setting across loads.
+ Fixed scrubbing in the timeline so that it doesn't immediately reset when scrubbing backwards.
+ Added a button to the timeline track for enabling and disabling isolation mode for emitters.
+ Added a checkbox to the timeline to enabled and disable emitters from the timeline.
+ Fixed PinToNiagaraVariable so that it asserts if bNeedsValue is specified and it can't actually provide a value.
+ Create a class called FNiagaraStackFunctionInputBinder which allows binding to an input of a function on a stack so that you can easily set and get the value of the input without having to worry about modifying the graph or rapid iteration parameter sets directly.
#tests Existing auto-tests and 1 new test for life cycle changes.
Change 3867179 by Frank.Fella
Niagara - Turn off GPU simulation for test assets for Shaun.
Change 3869201 by Simon.Tovey
Bypassing JonLs issue
#tests no longer crashes.
Change 3869897 by Frank.Fella
Niagara - Fix crashes when using the skeletal mesh data interface. NOTE: The change to the actual skeletal mesh data interface code doesn't seem needed, but without it, it crashes with the stomp allocator on. We'll have to investigate further.
Change 3870487 by Frank.Fella
Niagara - Always generate cached skin data immediately, and make sure we're not indexing triangles that don't exist. This is a temporary fix to avoid a crash when changing the skeletal mesh source on an effect in the level from the details panel.
Change 3877378 by Frank.Fella
Niagara - Update the burst and lifecycle modules with new metadata for incoming timeline changes.
Change 3877564 by Frank.Fella
Sequencer - Fix a few more places which were modifying sequencer data without calling NotifyMovieSceneDataChanged.
Change 3877565 by Frank.Fella
Niagara - Remove old unused burst code from some runtime classes.
Change 3877567 by Frank.Fella
Niagara - Add support for keying bursts on the timeline which is configured using script metadata.
Change 3877699 by Frank.Fella
Niagara - Fix a crash in the new timeline code for when you have bursts, but you have inputs on the emitter lifecycle bound, also set lower bound of view range of the timeline to be -.1 so that you can more easily interact with keys at 0.
Change 3877715 by Frank.Fella
Sequencer - Update the change type when pasting keys from the clipboard from Unknown to TrackValueChanged to avoid unnecessary work. From code review on last change.
Change 3879285 by Simon.Tovey
A couple of fixes for using struct constants
#tests Jon's case now compiles and works correctly.
Change 3879378 by Frank.Fella
Niagara - Fix a few spots where recursive graph traversal was visiting nodes multiple times because of diamonds in the pin connections. This reduces a terrible hang in UNiagaraScriptSource::InitializeNewRapidIterationParameters from 5 minutes to 5 seconds but there are futher issues to investigate becasue even 5 seconds it too long.
Change 3879858 by Shaun.Kime
Moved the VM script compilation to the DDC in order to facilitate better team compilation behavior. Significant changes to the translator and overall compile workflow to make the data behave better for a future multi-threaded compilation path.
In order to know when to compile, a key is generated that uses the compile id's of the graphs that influence the compilation of our node. In this way, if an end user goes and edits a function or module and checks in, the overall compile id will not match b/c that function is in the dependency list of a system downstream. The system will then know to recompile. However, everyone else on the team will generate the same key because the asset in question was checked in with its local compile id already changed.
Additionally, we now employ change tracking on traversals from a node graph. These traversals walk through all the nodes leading to a given output node and see if they've been altered. If they have, a new compile id is generated. If not, the old compile id is used. This also means that if you edit a particle update section in the stack, the emitter section won't force the system to recompile.
GPU scripts now have their own script slot rather than riding alongside particle spawn scripts. This allows us to address them independently in the translator and put them in the DDC as well. Once the text is generated, we then go back out to the DDC to generate the shader associated.
Known issues:
+ Emitters are sometimes marked dirty on open
+ Nodes connected to event writes aren't part of the hashing
+ DataInterface signature changes don't dirty the compiles
+ Struct changes don't dirty the compiles
+ On system loading, we go out to the DDC instead of using existing scripts, which is slower..
#tests all auto-tests pass, additional tests run to validate proper behavior
Change 3879859 by Shaun.Kime
Content update post DDC change
Change 3879862 by Shaun.Kime
Niagara plugin content to ddc
Change 3879958 by Frank.Fella
Niagara - Actually fix the bad recursion in this function by using the existing traversal method.
Change 3881727 by Damien.Pernuit
Niagara - Houdini - Created a separate plug-in for the Houdini CSV Data Interface.
Change 3881877 by Simon.Tovey
Fix for mac compile issue
Change 3882773 by Simon.Tovey
Actual fix for Mike
Change 3882822 by Shaun.Kime
Rather than throw a check, I instead emit an error when we can't match up a data interface and instantiate a CDO version. Not perfect, but this will let you recompile.
#tests allows me to open jonathan's file
Change 3883538 by Shaun.Kime
Moving particle-level scripts to compile with the emitter named Emitter in their internal scripts. This simplifies the dependencies quite a bit, but causes some complexity on the wiring side (most of which we were already doing anyway).
Getting rid of some allocations in translation (still more to go).
Fixed some of the logic for emitters that had modules of the same name to now properly concatenate.
Compile version bumped, so all scripts will be forced to recompile. Not saving this into the test files for now, as I expect this to happen a bit for the near term.
#tests all auto-tests pass, creating a new emitter and system on PC works
Change 3883552 by Shaun.Kime
Fixing renaming to work properly now. It just invalidates the system script compile id's, forcing it to auto-compile.
#tests auto-tests pass
Change 3884722 by Bradut.Palas
Added searchbar with basic name search for Niagara stack
#tests none
#jira UE-53469
Change 3884793 by Shaun.Kime
Adding pragma once
#tests no longer complains about duplicate definition
Change 3885629 by Wyeth.Johnson
Setting up a transient meshrotation framework pre-integration
Change 3887440 by Wyeth.Johnson
Custom HLSL failure for Shaun
Change 3888911 by Bradut.Palas
stack search box now has a minimum width of 300 pixels
#tests none
Change 3890843 by Shaun.Kime
Creating a Niagara quaternion type.
#tests created in editor, saw default was correct, carried through to VM runtime through attribute viewer
Change 3890849 by Shaun.Kime
Porting over 4.19 fix to Dev-Niagara
#tests allows creation of valid scripts even when ini is cleared.
Change 3891088 by Frank.Fella
Sequencer - When getting selected tracks for the external selection api, include tracks if any of their child nodes are selected. This matches the behavior object guid external selection.
Change 3891114 by Bradut.Palas
Fixing crash that sometimes happens if a stack tree changes while a stack search is active
#tests none
Change 3891131 by Frank.Fella
Sequencer - Move section headers for bool, int, vector, and color to the public directory so they can be used by the niagara level sequence integration.
Change 3891165 by Wyeth.Johnson
error for shaun
Change 3891354 by Shaun.Kime
Adding Quat struct to more locations. Now treated like hlsl float4.
#tests EulerToQuaternion now compiles
Change 3891463 by Bradut.Palas
Fix crash that sometimes happens when deleting module and hitting Ctrl-Z to undo (the condition for removing the listeners from the rootentry should not be tied to the validity of weak pointers for system and emitter, because sometimes they are out of sync when changing the graph)
#tests none
Change 3891641 by Wyeth.Johnson
resave node
Change 3893143 by Shaun.Kime
Fixing issue where you try to bind a vertex color sampler to a mesh without it. We failthe binding rather than crash due to a check later. Also fixed up error logging to only mention the one that failed.
#tests can open NiagaraSystem'/Game/FX/SkeletalMeshDissolve/EmittersAndSystems/FightSceneDissolve.FightSceneDissolve' with an error..
Change 3893528 by Bradut.Palas
fix another crash when search results are invalidated during search
#tests none
Change 3893830 by Shaun.Kime
Fix for copy & paste of comment boxes
#tests can now copy and paste comment boxes
Change 3894012 by Bradut.Palas
no longer executing search tick if the rootentry is null
#tests none
Change 3894828 by Frank.Fella
Niagara - Runtime changes to support sequencer animation
+ Reset the simulation when force solo is changed on the component.
+ Invalidate the render data and clear the buffers when resetting to avoid previously rendered particles from drawing.
+ Automatically sync the override parameters in the component when the source assets exposed parameters change and removed forced syncing from various places.
+ Remove lots of refresh code from the niagara component details which should not be neccessary anymore.
#TESTS Ran autotests, tested through the UI while building the sequencer tests asests.
Change 3894832 by Frank.Fella
Niagara - Level sequence support for spawning and animating system life cycle and select user parameter types.
#Tests Ran existing tests and added a new test to verify added functionality.
Change 3896944 by Bradut.Palas
safeguard entries with no search items (it actually can be null)
#tests none
Change 3896948 by Bradut.Palas
Fix assert when dereferencing source array (no need for a raw pointer to the array since it's initialized with the content anyway)
#tests none
Change 3896950 by Bradut.Palas
fix compile error with previous commit
#tests none
Change 3897698 by Frank.Fella
Niagara - Fix some safety issues with parameter initialization on the niagara component.
+ Kill the current system if we synchronize parameters to avoid issues with data interface lifetime.
+ Always sync parameters when the asset is set to prevent missing data interfaces in the override list.
+ Add an enum to control how data interface parameters are handled when calling CopyParametersTo.
+ When the system instance is copying the asset parameters, have it copy data interfaces by reference so that it's not creating data interfaces copies which will be deleted at the next garbage collection.
#Tests Auto-tests, also doesn't crash anymore when opeining Jonathan's disolve effect and then opening a level.
Change 3897953 by Frank.Fella
Niagara - Remove some namespace restrictions from the code that generates the available parameters to read from in the stack UI since it was preventing the use of custom namespaces in modules and it was not clear what issue it was solving since we already prevent scripts from addressing parameters from lower level scripts. Also move user parameters to their own menu section.
#Tests Custom namespaces are usable again in the stack.
Change 3898926 by Bradut.Palas
Fix for crash caused by garbage collection and async search
#jira UE-55284 (Stack search doesn't work on collapsed entries) now searching through unfiltered children, will need extra fixes on the stack to eliminate "ghost" results"
Both are still under code review, submitting because they are simple to rollback and harmless to other features.
#tests none
Change 3899069 by Shaun.Kime
Parallel compilation
Major changes:
Rather than a custom streaming version that we know influences a rebuild, I'm moving away to a guid that you need to regenerate if you change the compiler in any meaningful way
needed for multiple reasons,
1) if two people are making changes to the compiler, having something other than a guid as the value makes the content of the ddc ambiguous
2) when iterating I often need to make multiple changes to get to a working final result, bumping the version number each time that happens gets old fast
We fully clone the input graph to do the compile in the background. While the translation step is not a huge amount of time, it keeps the main thread responsive.
We currently have a big critsec around the crosscompiler to bytecode as it isn't threadsafe. Future changes will push this to the ShaderCompilerWorker.
#tests all tests pass as well as stress tests around saving while compilng, long compile times, etc.
Change 3899071 by Shaun.Kime
Fixing the availability flags for system and emitter scripts.
#tests all auto tests pass
Change 3899077 by Shaun.Kime
Fixing assets to have their wait on compile finished checkbox checked in the editor for testing
#tests n/a
Change 3899114 by Wyeth.Johnson
Random bool custom hlsl node
Change 3899184 by Bradut.Palas
implemented categories for module inputs (now inputs can be assigned a category in the module editor and they will be grouped by those categories in the Niagara stack)
#tests none
Change 3899329 by Bradut.Palas
fix broken commit by adding missing new files NiagaraStackInputCategory.cpp and .h
#tests none
Change 3899439 by Yannick.Lange
Niagara reroute node.
Change 3899516 by Shaun.Kime
Official angle conversion modules.
#tests made a local test emitter that converted back and forth between angles. Results were correct.
Change 3900193 by Shaun.Kime
Fixing build
#tests now compiles
Change 3900474 by Shaun.Kime
Fixes to help Mac compile
#tests n/a
Change 3901131 by Simon.Tovey
Warmup feature.
CPU Sim only.
Also has ability to advance simulation by tick count or seconds via BP/C++.
Includes some engine tests.
#tests editor + autotests
Change 3901455 by Frank.Fella
Niagara - Add WITH_EDITORONLY_DATA to prevent non-editor compile failures.
Change 3902477 by Frank.Fella
Niagara - Fix FNiagaraEditorTypeUtilities to be a thread safe TSharedFromThis since it's always created with a thread safe shared pointer, also fix up issues related to this change. Fixes a crash which occurrs when it's the target object of a delegate binding.
#Tests adding a curve data interface to a parameter collection no longer crashes.
#jira UE-55403
Change 3903478 by Shaun.Kime
No longer doing the check if compiling on load is enabled as this always forces different change ids'
#tests n/a
Change 3903783 by Shaun.Kime
Trimming down excess log spew
#tests auto-tests pass
Change 3905753 by Shaun.Kime
Made Sine(Degrees), Sine(Radians), and Sine, and the variants thereof for trig functions.
#tests n/a
Change 3905759 by Shaun.Kime
Auto tests for mesh orientation
#tests these now pass
Change 3905762 by Shaun.Kime
These files needed to be resaved for some reason to keep passing.
Change 3906727 by Bradut.Palas
Curve UX improvements
#jira UE-55134
#tests none
Change 3908177 by Shaun.Kime
Fixing build due to typo
#tests now compiles
Change 3908199 by Shaun.Kime
Trying to fix compilation when destroying objects. We cannot safely attach anything beneath us at this point ,we just need to clear out the queues.
#tests normal work day-to-day
Change 3908201 by Shaun.Kime
Working to fix crashes where the component was destroyed out from underneath us due to PIE shutting down and we have a Niagara item editable in Blueprint or world editor.
#tests n/a
Change 3908985 by Bradut.Palas
Renaming ColorCurveAsset to CurveAsset to better reflect the actual usage of the variable (fixing copy-paste issue)
#tests none
Change 3909222 by Yannick.Lange
Niagara graph connection colors
Change 3909436 by Bradut.Palas
fix crash in curve ux when importing a linear curve (curve of floats)
#tests none
Change 3909561 by Bradut.Palas
Updating LUT before sending NotifyPostChange when editing curves inline (so that LUT will not go out of sync)
#tests none
Change 3910010 by Yannick.Lange
Use new Niagara Actor icon
Change 3910191 by Yannick.Lange
Fix viewport widget showing up in the viewport when pressing W, E or R.
#jira UE-55142
Change 3910213 by Frank.Fella
PropertyEditor - PropertyRowGenerator - Added features and fixes to support integration into niagara's stack view.
+ Added a method to get filter/search strings for an IDetailTreeNode to support external searching and filtering.
+ Added a delegate to the layout builder for when one of it's owned nodes has it's visibility forcibly changed by a customization.
+ Changed the filtering so nodes are generated for properties marked as advanced.
+ Pass the notify hook down to the detail utilities so that change notifications work as expected.
+ Add layout data for the widgets returned from the IDetailTreeNode to prevent alignment and sizing issues in custom implementations.
Change 3910307 by Frank.Fella
PropertyEditor - Missed in last checkin.
Change 3910509 by Frank.Fella
Niagara - Removed nested details panels from the stack and integrate them properly plus other fixes.
+ Generate rows for nested objects using the details panel property row generator.
+ Fix the horizontal sizing for niagara parameter editors.
+ Add an IsValid() method to the base niagara stack entry so that derived classes can know if the associated view models are still valid when processing events. This is a temporary measure to fix a crash in the user parameter UI.
+ Set stack entries to be expandable by default and delete usages which were setting it to true.
+ Highlight the active search result with a border since property rows can't highlight text.
Change 3911653 by Frank.Fella
Niagara - Fix stack spacer sizing.
Change 3911667 by Frank.Fella
PropertyEditor - Actually fix the notify hook handling in the property row generator.
Change 3911896 by Yannick.Lange
Niagara function input context menu.
Change 3911900 by Yannick.Lange
Project setting for not showing comment bubbles.
Change 3911996 by Yannick.Lange
Niagara fix if node persistent guids for older nodes. The OutputVarGuids are always synced on PostLoad.
Change 3912221 by Wyeth.Johnson
Renderer Icons for timeline
Change 3912608 by Bradut.Palas
stack style refactor
#jira UE-55399
#tests none
Change 3913063 by Wyeth.Johnson
Icons for stack added, including new system param png
Change 3913618 by Shaun.Kime
Fixing two of the most common Illegal call to StaticFindObject() errors while compiling.
#tests ran through compilation after changes.
Change 3914369 by Bradut.Palas
Using new SystemParams.png icon provided by Wyett (instead of the old "Parameters.png")
#tests none
Change 3914782 by Wyeth.Johnson
Adjusting icon for update to not indicate "flow"
Change 3915738 by Shaun.Kime
Moving away from the generic and super-slow EdGraphSchema ShouldAlwaysPurgeOnModification being true to using the same mechanism we use to invalidate the compile to synchronize nodes. This should be substantially faster.
#jira UE-55463
#tests ran through a variety of tests creating and wiring nodes
Change 3915739 by Shaun.Kime
Assignment nodes need to invalidate the graph for compile.
Change 3915741 by Shaun.Kime
Making default values more accessible and making it possible to route renderers to use different values than the defaults.
#tests n/a
Change 3915798 by Frank.Fella
SearchBox - Add options to show the number of search results and an option to show a throbber when a search is active.
Change 3915966 by Shaun.Kime
Changing the default for velocity to 0,0,0 as requested by Wyeth
#tests n/a
Change 3915982 by Shaun.Kime
Making the default text more readable
#tests n/a
Change 3916237 by Frank.Fella
PropertyEditor - Change the DetailCategoryBuilderImpl so that it sets the horizontal alignment to fill for value widgets when generating stand alone widgets so that the behavior in the property row generator matches the behavior of the property grid.
Change 3916240 by Frank.Fella
Niagara - Should prevent some recent crashes due to stack entry delegates and lifetime.
Change 3916261 by Frank.Fella
Niagara - Lots of minor stack ui fixes and adjustments
+ Tweaked padding in a bunch of different places.
+ Added a dark background behind the stack and stack header to prevent the colors from bleeding together.
+ Fixed the group text not being white anymore.
+ Hooked up new features of the search box for showing the search result data and an is searching throbber.
+ Fixed an issue where the current search result couldn't be interacted with.
+ Fix some other inconsistencies with searching where you might jump more than one result.
+ Replace the checkbox for showing curve in the curves tab with an icon based button. (icon is placeholder)
Change 3916833 by Shaun.Kime
Fixing issue where the system wasn't set to wait for compilation on load, sometimes leading to failures for auto-tests
#tests this test now passes when forced to recompile
Change 3916846 by Shaun.Kime
Missed one system in the scene.
#tests n/a
Change 3917458 by Shaun.Kime
Fixing another potential race condition on the DDC.
#tests n/a
Change 3918349 by Frank.Fella
Niagara - Invalidate the node visuals when reallocating pins.
#Jira UE-55698
Change 3918783 by Olaf.Piesche
Correct 'temp' to 'Temp' in map set
Change 3919262 by Shaun.Kime
We weren't properly updating the default values for user data interface components when tweaked in the editor.
#tests open skinned mesh auto test system change the preview for the user skinned mesh to be SK_Mannequin_Niagara. It now updates, it didn't before.
Change 3919602 by Shaun.Kime
Fixing the skeletal mesh to now clamp to the end of the index buffer for safety as well as adding IsValidTriCood. This lets us keep going even when swapping out the skeletal mesh underneath.
Tested out isvalidtricoord in the test skinning module.
#tests auto tests pass
#codereivew simon.tovey
Change 3921701 by Yannick.Lange
Make Vector2 and Vector4 default blue color to be consistent with blueprints.
Change 3922331 by Damien.Pernuit
Niagara - Houdini - Added support of CSV File as UAsset (HoudiniCSV)
Modified the Data Interface to use the CSV asset instead of the imported buffers from the CSV File Path.
Added some new functions to the DI:
GetLastParticleIndexAtTime()
GetCSVPositionAndTime()
GetCSVVectorValue()
GetCSVFloatValueByString()
Change 3923118 by Simon.Tovey
PS4 compile fix.
Change 3924934 by Bradut.Palas
fix Mac compile issues
#jira UE-55426
#tests none
Change 3925168 by Bradut.Palas
Curve logspamming
#jira UE-55593
#tests none
The UpdateCompiledDataInterfaces would end up comparing LUTs when copying curves and the source LUT was out of date.
Change 3925366 by Frank.Fella
Slate - SMenuAnchor - Fix the implementation of "BelowRightAnchor" to align the right edge of the menu with the right edge of the anchor. There aren't any other usages of this in the engine as far as I can tell, hopefully people weren't relying on the broken behavior in a game somwhere.
Change 3925423 by Frank.Fella
Niagara - Remove the large add buttons from the stack and add smaller add buttons in the group headers.
Change 3925877 by Olaf.Piesche
New collision modules, separating query, linear and angular impulse; Solve forces and velocity takes care of integrating f->v->p and fA->vA->O; linear impulse module would probably be cleaner by zeroing velocity on collision and calculating a force instead of setting new velocity directly
Change 3926582 by Simon.Tovey
PS4 compile fix
Change 3927401 by Shaun.Kime
Fixing events due to added member
#tests all tests pass as of 3925423 with this change
Change 3927496 by Shaun.Kime
Getting auto-tests to run
Questions: Why did I have to recompile the GPU tests... something is missing in their key generation?
Resaved several files.
#tests almost all pass now
Change 3927582 by Shaun.Kime
Fixing last failing auto test
#tests all tests now pass
Change 3927924 by Simon.Tovey
Chunk level vm parallelism.
Any execution processing > batch_size chunks will go wide.
The batch size is 4 currently but adjsutable via vm.ParallelChunksPerBatch.
VM parallelism can be disabled by vm.Parallel 0
Change 3927990 by Shaun.Kime
Submitting redirector
Change 3928426 by Frank.Fella
Niagara - Always propagate rapid iterations parameters when merging an emitter.
Change 3929823 by Frank.Fella
Niagara - Fix hlsl generation for system/emitter spawn script so that we read the engine and user parameters from the data set instead of initializing them to 0.
#Tests Full recompile + auto-tests
Change 3929983 by Simon.Tovey
Curve LUT Interpolation
+ updated test altered by it.
Change 3930551 by Frank.Fella
Niagara - Fix what looks like a copy/paste error in the SNiagaraSelectedEmitterGraph destructor which was preventing clean removal of delegates and causing a crash.
#Tests closing the "Selected Emitter Graph" tab and then changing the selected emitter no longer crashes.
Change 3932695 by Damien.Pernuit
Niagara - Houdini:
Houdini CSV Asset:
- Packed vector values in the CSV file are now properly supported (not just for Position/Normal) and can be of any size.
- Added support for reimporting Houdini CSV files.
- Added an "open in text editor" entry in the context menu.
- Improved error/warning logging during the parsing of the file
Houdini Niagara Data Interface:
- Added GetParticleIndexesToSpawnAtTime():
New helper functions returning the min index, max index and number of particles to be spawned for a given time value.
Uses an internal LastSpawnIndex to avoid spawning the same particles twice.
- Modified GetLastParticleIndexAtTime():
If the CSV file doesn't have time informations, returns false and set the LastIndex to the last particle
If desiredTime is smaller than the first particle, LastIndex will be set to -1
If desiredTime is higher than the last particle in the csv file, LastIndex will be set to the last particle's index
Change 3933425 by Shaun.Kime
Made the spreadsheet debugger capable of capturing in-world systems as long as they are solo'ed.
#tests have been running with it for several days, debugging real-world assets stably
Change 3933986 by Frank.Fella
Niagara - Fixed a bug with merging where added dynamic inputs which changed names could end up with the wrong rapid iteration parameters. Also fixed an issue where added dynamnic inputs would be renamed when they didn't need to be.
#Tests Engine tests and fixes custom repro.
Change 3934052 by Frank.Fella
Niagara - Added a console command to dump rapid iteration parameters for a system or emitter asset.
Change 3934436 by Simon.Tovey
Fixes for sprite VF depth test failure issue
Change 3934658 by Frank.Fella
Niagara - Make disabled modules visually distinct.
#Tests General stack use.
Change 3935383 by Shaun.Kime
Fixing mac compile errors
#tests n/a
#jira UE-55911
Change 3935420 by Yannick.Lange
Niagara parameter UI first version.
Change 3935482 by Yannick.Lange
Add missing files for parameters
Change 3935591 by Shaun.Kime
more macos compile
#tests na
Change 3935637 by Shaun.Kime
Reverting to prior behavior
#tests na
Change 3936541 by Yannick.Lange
Remove the merge up menu entry for set variables module items.
Change 3936841 by Wyeth.Johnson
Bool comparison dynamic input
Change 3936895 by Simon.Tovey
A few perf improvements and fixes to the SetSolo transfering between solo and batched so all lightning sims can run batched after they're warmded up.
Change 3936899 by Simon.Tovey
Missed a file
Change 3937178 by Krzysztof.Narkowicz
Fixed bHasSkipOutputVelocityParameter for shaders without PreviousLocalToWorldMatrix (e.g. particles)
#jira UE-50914
Change 3937222 by Yannick.Lange
Random event spawn
Change 3937292 by Yannick.Lange
Fix Adding a new parameter then renaming it the default name deletes the new parameter
#jira UE-55994
Change 3938472 by Yannick.Lange
Fix new parameters in emitters saving by using the editable emitter.
Change 3938474 by Yannick.Lange
- Store graphs as weak object pointers in the parameter UI.
- Allow right mouse menu on parameters in the system toolkit.
- Refresh only the parameter actions when deleting an entry instead of refreshing the graphs aswell.
Change 3938525 by Yannick.Lange
Fix creating an unique FName every tick for parameterstores by using a FString instead.
Change 3938596 by Shaun.Kime
Macos compile
#tests n/a
Change 3939362 by jonathan.lindquist
Adding a new Component Spacing input to the debug value functions. This will allow users to make better use of space when debugging values.
Change 3939365 by Shaun.Kime
Back out changelist 3936895 and 3936899
Leaving in some changes around stats as they should be harmless.
These changes were removed b/c they added poor perf to Jonathan's dissolve effect and also caused multiple tests to fail in engine tests.
#tests all tests pass besides Yannick's FName/FString warning, with the exception of BPTimeControl, Hypnotizer, and MeshOrientation, which seem to be off by one frame, but have been consistently off for several days (CL 3929823 had same issues for me)
Change 3939367 by jonathan.lindquist
Adding greyscale output
Change 3939368 by jonathan.lindquist
Changing the pin order
Change 3939377 by Shaun.Kime
Allows the unnormalized lut table flag to be copied over
#tests all tests pass besides Yannick's FName/FString warning, with the exception of BPTimeControl, Hypnotizer, and MeshOrientation, which seem to be off by one frame, but have been consistently off for several days (CL 3929823 had same issues for me)
Change 3939379 by Yannick.Lange
Rename FParameterStore Name to DebugName to prevent loading a FName into a FString with existing assets.
Change 3939382 by Shaun.Kime
Adding the ability to have a default curve index with a custom switch node.
#tests all tests pass besides Yannick's FName/FString warning, with the exception of BPTimeControl, Hypnotizer, and MeshOrientation, which seem to be off by one frame, but have been consistently off for several days (CL 3929823 had same issues for me)
Change 3939383 by Shaun.Kime
Converting existing curves over to using the new default pin
#tests all tests pass besides Yannick's FName/FString warning, with the exception of BPTimeControl, Hypnotizer, and MeshOrientation, which seem to be off by one frame, but have been consistently off for several days (CL 3929823 had same issues for me)
Change 3939501 by Shaun.Kime
Submitting missing files
#tests n/a
Change 3939580 by Wyeth.Johnson
Default curve indexing to three more DIs
Change 3940122 by Yannick.Lange
Parameters view: - Jump to new parameter added and request rename for new parameter.
- Remove adding parameters to the parameterstore when a pin is requested.
- Only show make new parameters in the dropdown to add a new parameter.
- Use Sections of UI as types instead of int32.
Change 3940214 by Bradut.Palas
fix crash when rename skeletal mesh user variable
#jira UE-55236
#tests none
Change 3940215 by Bradut.Palas
undo not working in graph editor
#jira UE-55466
#tests none
Overriding the BreakPinLinks methods to include a transaction
Change 3940250 by Bradut.Palas
Creating stats tab in module toolkit to show LastOpCount
#tests none
Change 3940251 by Bradut.Palas
#jira UE-55684 create inline menus for stack
#tests none
Change 3940262 by Simon.Tovey
Back out changelist 3939365 with fixes
Tests all now pass
Change 3940333 by Shaun.Kime
Nullptr check
#tests n/a
Change 3940338 by Krzysztof.Narkowicz
Niagara sprite particles - implemented get previous position in order to fix sprite particle motion vectors
#jira UE-52865
Change 3940407 by Yannick.Lange
Create pin on map get and set node when dragging without recompiling the graph.
Change 3940534 by Shaun.Kime
Making sure that collision returns defaults of 0 if nothing was found.
#tests auto-tests that have been passing still pass
Change 3940709 by Simon.Tovey
Temp hacks for the skeletal mesh painting issues.
Change 3940960 by Yannick.Lange
Only build parameter menu once when graphchanged is called multiple times in a frame.
Also use the existing metadata from graph to build the parameter menu, because the metadata already looped through all nodes and pins.
Change 3941019 by Yannick.Lange
Meta data UI refresh next tick to avoid refreshing multiple times a tick.
Change 3941853 by Simon.Tovey
Adding more dynamic parameters
Change 3941957 by Frank.Fella
Property Editor - Fix issues with property row generator to support the niagara stack.
+ Make the detail tree node name accessible through the interface, and fix the implementations for category group and property item.
+ Add a temporary fix for passing instance customizations from the property row generator to the detail property row through the detail layout builder. This should be unified in a nicer way, but this will work for the time being.
Change 3942174 by Frank.Fella
Niagara - Stack UI Pass
+ Advanced rows are not handled properly per item.
+ Expanded and scroll state is now saved in editor data per asset.
+ Added a "View Options" drop down for showing all advanced rows, and for showing/hiding outputs.
+ Added an option to collapse all stack items from the emitter header context menu.
+ Added support for "Edit Conditions" on module and dymaic inputs which will enable and disabled an input based on the value of another input. This includes showing a checlbox inline for the edit condition toggle input.
+ Added support for "Visible Conditions" on module and dynamic inputs which will hide and show inputs based on the value of another input.
+ Removed the pencil icon for locally editable values in the stack.
+ Fixed issues with invisible search results. It's still possible for a search result to not highlight the text correctly, but the outline never disappears.
+ Removed pinning for module inputs.
+ Fixed the event handler properties so that they use the property row generator instead of an embedded details panel.
+ Unified indent handling across all stack classes.
+ Unified stack editor data across all stack classes.
Change 3942427 by Simon.Tovey
Another hack for vertex painting tool
Change 3942453 by Simon.Tovey
Some more hacks for skel mesh vertex painting until Jurre's rework is ready.
Change 3942799 by Yannick.Lange
Rebuild metadata, input and output parameters UI next frame instead of on every graph changed call.
Change 3942833 by Frank.Fella
Niagara - Fix the visibility of the advanced expander item.
Change 3942923 by Yannick.Lange
Revert using metadata for parameters to looping through pins to find parameters in maps not connected to anything.
Temporary fix to remove used parameters if they are found in the graph.
Change 3943094 by Wyeth.Johnson
Rollback //UE4/Dev-Niagara/Engine/Plugins/FX/Niagara/Content/Modules/Spawn/Location/SphereLocation.uasset to revision 5
Change 3943154 by Wyeth.Johnson
Metadata to sphere location module
Change 3943256 by Wyeth.Johnson
Testing out sweet new metadata control
Change 3943374 by Olaf.Piesche
Fixing mesh motion blur
Change 3943382 by Olaf.Piesche
Turning on base pass velocities until I can fix separate vel pass for particles
Change 3943471 by Yannick.Lange
Emitter view stats only show particles count. Use Niagara.EmitterStatsFormat 0 and 1 to switch between all data and only particle count. Default is 1 to only show particle count.
Change 3943497 by Yannick.Lange
Paramater map remove FTickableEditorObject and use SWidget::Tick
Change 3943589 by Olaf.Piesche
-Fix for linear impulse (offset by 1/2*velocity*dt instead to avoid distracting bounciness)
-Collision Rest; add after impulse modules to make particles rest if in collision under threshold velocity magnitude
Change 3943644 by Olaf.Piesche
Turn shader development mode back off
Change 3943718 by Olaf.Piesche
Fix vertex factories
Change 3943776 by Olaf.Piesche
Properly calculate old particle position using dt for velocity rendering
Change 3943780 by Frank.Fella
Niagara - Fix ensure when removing dynamic inputs due to incorrect logic which would have left unused nodes in the graph.
Change 3943870 by Yannick.Lange
Parameter drag drop window
Change 3943994 by Frank.Fella
Niagara - Fix some editor settings not saving across sessions.
Change 3944056 by Shaun.Kime
Updating to replace values reset when Wyeth resaved files.
#tests DrawOrderGPU, DrawOrder, and TestDifferentInactiveEmitters now pass
Change 3944068 by Simon.Tovey
Back out of my changes to vertex painting and replaced with Jurre's fixes.
Change 3944174 by Frank.Fella
Niagara - Fix stack categories so that they don't freak out when the stack is refreshed, and also remove the uncategorized heading and move uncategorized inputs to the top.
Change 3944313 by Shaun.Kime
Updated screenshots after motion blur
Change 3944321 by Shaun.Kime
Fixing error message to be clearer about a disconnected Get node.
#tests n/a
Change 3944351 by Shaun.Kime
Making safe against weak pointers going away.
Track error encountered by Jonathan.
#tests n/a
Change 3944368 by Yannick.Lange
Remove automatic adding prefix "particles." when renaming functioninput.
Change 3944383 by Shaun.Kime
Just adding some more nullptr check
#tests n/a
Change 3944384 by Shaun.Kime
Providing more context for a check that existed previosuly and was encountered by Wyeth today
#tests n/a
Change 3944872 by Yannick.Lange
Remove old material parameter node.
Change 3945209 by Shaun.Kime
Fixing possible infinite recurson on child array size of zero
#tests n/a
Change 3945865 by Yannick.Lange
Spreadsheet filter for output attributes
Change 3946091 by Simon.Tovey
Per particle sorting for translucent sprites and meshes
Change 3946095 by Simon.Tovey
Updated screens for dynamic param tests
Change 3946378 by Olaf.Piesche
Another sprite motion blur fix
Change 3946864 by Shaun.Kime
SkinnedMesh per-instance data requires 16 byte alignment due to usage of FMatrix. We were not guaranteeing that in our per-instance data system. We are now enforcing that to be true by aligning all memory size requests.
#tests autotests pass
Change 3946928 by Wyeth.Johnson
Skeletal mesh location metadata. THIS VERSION ALSO CRASHES ON SAVE FYI
Change 3946934 by Frank.Fella
Niagara - Clean up rapid iteration parameters on compile.
#Tests - Fixes the jira below, all auto tests which were currently passing still pass, and GDC effects load and look correct.
#jira UE-55932
Change 3946936 by Frank.Fella
Niagara - Fix crash when undoing adding a dynami input.
Change 3947213 by Simon.Tovey
Fix for thread safety in collision data interface.
Previously I'd made them thread safe between VM chunks but they already weren't safe between system instances.
Change 3947279 by Simon.Tovey
Fixed thread safety issue with niagara global dynamic buffer
Change 3947788 by Simon.Tovey
Fix enum property warnings
Change 3947849 by Olaf.Piesche
Normalize orientation quats. Safety first.
Change 3947877 by Frank.Fella
Niagara - Fix a crash when editing meta-data for a module currently open in a system or emitter editor stack. This updates the FNiagaraStackFunctionInputBinder to track the lifetime of the default pin correctly.
Change 3948445 by jonathan.lindquist
Inverting alpha output
Change 3948615 by Olaf.Piesche
Don't access data layouts that are invalid because their bindings don't exist
Change 3949361 by Yannick.Lange
Command to expand all groups and collapse all items of those groups in the stack.
Change 3949365 by Yannick.Lange
Missing file for change 3949361
Change 3951123 by Simon.Tovey
Fix bug with dynamic parameters in Niagara mesh particle VFs
Change 3951199 by Simon.Tovey
Fix for issues caused by unsafe reads of GT data from RT
Change 3951293 by Olaf.Piesche
Workaround for jittering particles with collision at rest state; will need to revisit after GDC
Change 3951533 by Yannick.Lange
Collapse parameter menu by default
Change 3952106 by Frank.Fella
Niagara - Fix data interface input initialization when inserting modules and dynamic inputs. We now put all inputs into categories in the stack and this code didn't handle that.
Change 3954809 by Frank.Fella
HoudiniNiagara - Add include to fix CIS incremental build.
Change 3954857 by Frank.Fella
Niagara - Accept newer versions of 3 automated tests images as they are stable and still look correct for what they are testing.
Change 3954935 by Frank.Fella
Niagara - Fix a crash in the skeletal mesh sampling info details customization when a mesh has no skeleton.
Change 3954969 by Simon.Tovey
Compile fix for gpu emitters
Change 3955012 by Frank.Fella
Niagara - Fix clang and deprecation warnings.
Change 3955988 by Olaf.Piesche
Fixing collision queries (separating line query trace direction and velocity, so we can look a frame ahead properly); various fixes to the impulse modules; rest module now allows for color change when particles are set to rest. This checkin should stabilize collision dynamics substantially.
Change 3956730 by Yannick.Lange
Cleanup parameter
Change 3957065 by Bradut.Palas
enable/disable mechanism for renderers
#tests none
Change 3957802 by Olaf.Piesche
-Removing Velocity parameter from collision query DI, since velocity at query time is known and can just be passed along in temporary parameter; this stops the compiler from falling over in unity builds and also makes the Perform Query function more sane as an actual line check
-Put some safeguarding against non-collisions (v.n>0) reported as intersections into the collision query module to avoid instances of particles being pushed through geometry
-Updated modules to use the new function signature
#tests modular explosion test map, EngineTests
Change 3957804 by Olaf.Piesche
Updated tests for 3957802
Change 3957859 by Frank.Fella
Niagara - Add missing #if to fix some of the nightly build errors.
Change 3958065 by Olaf.Piesche
Fix GPU sim hlsl for the collision data interface; should make GPU collision bounce test run again
Change 3958302 by Olaf.Piesche
modified test for sane depth bounds; accepting new results; some changes to hlsl for collision data interface
Change 3959007 by Simon.Tovey
Further defining the barrier between GT and RT data.
Not finished yet, especially for GPU sims but we're heading in the right direction.
Change 3960004 by Bradut.Palas
QOL change, now committing search text in the stack (pressing enter) will jump to the next occurrence.
#tests none
Change 3960019 by Frank.Fella
Niagara - Preemptively fix up stack related header includes to avoid manual merges.
Change 3964217 by Bradut.Palas
Fixing compile issue after renderer enable feature(the Isolate features require the WITH_EDITORONLY_DATA preprocessor directive to be enabled)
#tests none
Change 3964581 by Frank.Fella
Niagara - Get things compiling again after merge. Mostly include fixes and commeting out lots of sequencer related stuff that needs to be fixed.
Change 3965057 by Frank.Fella
Niagara - Fix compile issues in the houdini plugin. Also add the houdini pluging to EngineTest so that it compiles by default when running tests.
Change 3965075 by Frank.Fella
Niagara - Fix another include issue that was caught on the build machine.
Change 3965308 by Frank.Fella
Niagara - One more header fix. Should fix the win64 build in CIS.
Change 3965313 by Frank.Fella
Niagara - Fix in editor playback. The timeline data is still broken.
Change 3965482 by Yannick.Lange
Stack source taken apart into different files.
Change 3965863 by Shaun.Kime
Fixes scope level variable definition causing my local build to fail
#tests n/a
Change 3965866 by Shaun.Kime
Crash fix when the module is missing. Now show an error message as well as checking for script validity before calling method on it
#tests n/a
Change 3968174 by Frank.Fella
Niagara - Fix more merge fallout. The emitter/system editor timeline now matches the stack data again.
Change 3968183 by Frank.Fella
Niagara - Delete commented out include from merge.
Change 3972162 by Frank.Fella
Niagara - Updated level sequence testing assets.
Change 3972880 by Shaun.Kime
Merging using DevNiagaraToGDC2018
Allowing disabled modules to still influence parameter maps.
#tests n/a
Change 3973269 by Shaun.Kime
Disabling warning about divide by zero as it is often incorrect
#tests n/a
Change 3973273 by Shaun.Kime
Forcing all three planes to be GPU
#tests n/a
Change 3973307 by Shaun.Kime
Fixing CIS win32 errors
#tests n/a
Change 3973374 by Shaun.Kime
Fixing minor static analysis warnings
#tests n/a
Change 3976107 by Shaun.Kime
Updating multiple files as they have the unversioned file warning
#tests auto tests now show green
Change 3976114 by Shaun.Kime
Taking snapshots after the integration for time control to clear automated tests. Frank was uncertain about the current behavior being correct, but didn't want to hold up integration for that.
#jira UE-57117
Change 3976119 by Shaun.Kime
Makiing GPU shaders contain the dependencies and the compile id's and other items so that they update properly.
#tests auto-tests now pass
Change 3976449 by Shaun.Kime
Adding additional debugging to logs
#tests n/a
Change 3977172 by Frank.Fella
Niagara - Fix issues with the level sequence integration for niagara caused by the integration from main, and accept the new test image. This code should be updated at some point to use the new channel blending in sequencer.
NOTE: There is still a timing issue that is evident in the automated test screen shot due to float timing and rounding issues in niagara, but the sequencer code is functioning correctly.
Change 3977362 by Bradut.Palas
UE-55601 curve snapping not working in Niagara curve editor
#tests none
Change 3977363 by Bradut.Palas
exposed added external asset for function input so it would appear in context menu in the Niagara stack.
#tests none
Change 3977368 by Bradut.Palas
#jira UE-51052 If you undo an emitter rename we get invalid values
The CachedUsageInfo got emptied but it didn't get restored by the undo, sending the system in an endless Compile() loop
Added a Modify() call in the UNiagaraScriptSource::InvalidateCachedCompileIds()
#tests none
Change 3978716 by Shaun.Kime
Fixing half of CIS static analysis warnings and localization symbol dupe warnings from Jamie Dale
#tests auto tests pass other than known level sequence test
Change 3978857 by Shaun.Kime
The map SpawnTest niagara actor didn't have its wait for compilation flag set, potentially leading to artifacts. Disabling for now as that didn't resolve the issue.
Change 3979594 by Shaun.Kime
Potential fix for cook on Orion
#tests n/a
Change 3979713 by Shaun.Kime
Fixing several more CIS static analysis warnings as well as duplicate localization string warnings from Jamie Dale
#tests n/a
Change 3980017 by Shaun.Kime
Fixing CIS static analysis warnings as well as duplicate localization string warnings from Jamie Dale
#tests n/a
Change 3981859 by Shaun.Kime
Fixing crash in Paragon when the normals buffer was not present during startup with just UI screens.
#jira UE-57188
#tests got through to paragon main screen, related auto-tests pass
Change 3982685 by Shaun.Kime
For some reason, when Lightmass is spinning off workers, the render thread is null, causing us to trigger checks that we shouldn't trigger when killing of system instances.
#jira UE-57214
#tests all auto-tests pass
Change 3983902 by Simon.Tovey
Speculative fixes for mac errors regarding niagara vertex decls.
Change 3984023 by Andrew.Rodham
Sequencer: No longer upgrade bIsInfinite for section types that do not support open ranges
Change 3986727 by Wyeth.Johnson
Fixed add velocity from point to work in more situations, not cause errors regardless of stack location, made it more programmable with inputs, and added metadata
Change 3988114 by Wyeth.Johnson
fixed color and inherit parent vel
Change 3989175 by Simon.Tovey
Improved VM error reporting.
#tests engine tests
Change 3995007 by Yannick.Lange
Parameter menu in system layout
Change 3995192 by Yannick.Lange
Fix niagara script details panel search
Change 3995291 by Yannick.Lange
Parameter menu tooltip fix
Change 3997804 by shaun.kime
Lookup table is off for this. Keys are 0,0 and 1,1, so you'd expect normalized age as a sampler to just return the same value from lookup. If LUT is disabled, this is true. If LUT is enabled, it isn't, especially the farther one gets from 0.
Change 3998124 by Simon.Tovey
Fixed Curve LUT generation
#tests editor
#jira UE-57604
Change 3998286 by Wyeth.Johnson
Fixed normalized execution index to, you know, work.
Change 4000324 by Shaun.Kime
Replacing a thread-safety issue where we get an enum on an as-needed basis. This was causing crashes in cooking as you cannot find from the global table while serializing.
#tests have not gotten the crash since
Change 4000428 by Bradut.Palas
UE-55750 focus curve editor when "show" button is pressed
UE-55791 user variable curves cannot be shown in the Curve tab
These issues were related and touched the same area of code, so I fixed them together. UE-55791 is basically just getting curve data from the system exposed variables too.
#tests none
Change 4001094 by Frank.Fella
Niagara - Fix slowdown in the metadata editor due to delegate rebinding.
Change 4001098 by Frank.Fella
Niagara - Remove the tool tip from the additional options drop-down for modules since it covers the drop down menu.
Change 4001133 by Bradut.Palas
Fix curve editor getting focused each time a curve was changed.
#jira UE-57708
#tests none
Change 4001253 by Frank.Fella
PropertyEditor - Fix issues with external root handling.
+ Fix external nodes not being cleaned up correctly when custom node builders rebuild children.
+ Fix expanded state being trampled when processing external nodes due to the expanded nodes list being emptied every time RestoreExpandedItems was called.
+ Fix performance issues with refreshing during tick by moving all calls to RestoreExpandedItems to UpdateFilteredDetails, and then only calling UpdateFilteredDetails once per tick as needed instead of per root property node and per root external node.
Change 4003365 by Shaun.Kime
If the physical material has gone away, make sure to set value values. Note that if this data interface is going to go on in parallel to the game thread, we'll need something more sophisticated.
#tests Win64 tests pass
Change 4003367 by Shaun.Kime
Making sure that the system has finished compiling before we begin cooking.
#tests n/a
Change 4003374 by Frank.Fella
Niagara - Fix a crash when adding and removing modules and dynamic inputs with data interfaces.
#jira UE-57749
Change 4003696 by Shaun.Kime
Getting rid of whitelist, now open on all platforms.
#tests n/a
Change 4005368 by Shaun.Kime
Fixing compile error on Linux
#tests n/a
Change 4013779 by Shaun.Kime
Interpolated spawn on GPU does not yet work but checkpointing work.
+ Added AdditionalDefines to the VMCompileId, switched interpoalted spawn to use that
+ Added rough interpolated spawn support to translator by refactoring away from specific calls and hard-coded update/spawn somewhat... could improve for events
+ Revised shader variables away from Phase0/Phase1 terminology to the true Update/Spawn meaning. Leaving the phase numbers as an implementation detail within the usf.
+ Added ToString to ParameterStores for debugging
+ Changed GPU ExecIndex() logic to actually work similar to the VM
#tests collision gpu fails
Change 4015355 by Simon.Tovey
Persistent IDs final.
Still need to change the compile ID parts over to use the new additional defines but the core functionality is in.
#tests editor + engine tests
Change 4018445 by Simon.Tovey
Some missing assets
Change 4021647 by shaun.kime
Moving jonathan's DebugParticleData to Niagara Extras
Change 4024809 by Yannick.Lange
Parameter map hover text using metadata description.
Change 4025042 by Wyeth.Johnson
Dogfooding the skeletal Mesh location module w/ comments, reroute pins, map gets and sets, metadata, tooltips, etc.
Change 4025236 by Shaun.Kime
Working on getting interpolated spawning working. Submitting to get assistance from Simon.
... PLEASE DON'T SYNC UNLESS YOU'VE SPOKEN TO ME...
#tests collision test on GPU is better, but not yet right.. ribbon id emitter is ensuring on LUT table generation
Change 4025372 by Shaun.Kime
Making the debug particle data stay the same size as the base particle for easier debugging.
#tests n/a
Change 4025701 by Shaun.Kime
Debug asset for Simon
#tests n/a
Change 4027865 by Shaun.Kime
Fixing parameter map stores to properly handle reset. Previously was leaving around padding info from previous version of the script which could be totally wrong.
#tests now don't crash
Change 4029638 by Wyeth.Johnson
Refactor Skeletal mesh location module to test some ideas on coding standards and shake out workflow issues
Change 4030135 by Shaun.Kime
Interpolated spawning now works on the GPU.
#tests collision gpu has stray collisions and the GenerateLocationEvent was recently updated that broke . will fix in a later update
Change 4030197 by Wyeth.Johnson
Refactor static mesh location module
Change 4033437 by Simon.Tovey
Adding a few simple new functions for direct access to vertex positions for cannabis.cod3r.
Change 4033937 by Shaun.Kime
Setting the wait for compilation flag
#tests now pass consistently
Change 4034391 by Shaun.Kime
Created a parameter map default node to start default call chains.Updated standard modules and dynamic inputs.
#tests all previoulsy passing tests pass
Change 4035002 by Shaun.Kime
Updated to work with latest main integration
#tests n/a
Change 4035523 by Wyeth.Johnson
Refactor Cone stuff to coding standards, replace some things with functions
Change 4035672 by Shaun.Kime
Fixing build warnings
#tests n/a
Change 4036887 by Wyeth.Johnson
Some metadata, some optimization, some additional refactoring and swapping in functions. Straight Dogfoodin'
Change 4037132 by Shaun.Kime
Adding GPU test versions of several assets
Change 4037241 by Wyeth.Johnson
Optimizing, metadata, and making some coding standards changes
Change 4037436 by Wyeth.Johnson
Fixing a pointless module to make it... pointful?
Change 4037629 by Frank.Fella
Niagara - Fix issues with data interfaces as parameters
+ Collect data interface reads and writes from parameter maps during compilation so they can be hooked up a runtime.
+ Add new runtime parameter stores for systems and emitters at runtime which bind the exposed data interfaces into the execution contexts.
+ Fix the editor code which updates the compiled data interfaces so that it updates the correct ones regardless of where they are defined.
+ Fix an issue where failed compiles weren't being propgated to the UI correctly.
Change 4037832 by Shaun.Kime
Properly handling nullptr references
#tests deleting a module from the stack after it was recently refreshed now doesn't crash
Change 4037917 by Wyeth.Johnson
Fix add velocity from point (needed begin defaults), reorg, comment and metadata
Change 4038250 by Wyeth.Johnson
Big refactor of spawn per unit
Change 4038665 by Shaun.Kime
Events now take parameter map in/out pins
#tests now the events auto-tests should pass
Change 4038723 by Shaun.Kime
Now renderers can say if they are compatible with the SimTarget mode.
#tests now changing to GPU doesn't crash a light renderer
Change 4038731 by Shaun.Kime
Missing file from prior checkin
#tests n/a
Change 4038742 by Shaun.Kime
Attempting to fix editor build, which is unfortunately fine on my machine
#tests n/a
Change 4040069 by Wyeth.Johnson
Refactor of Event Generator and Event Receiver, new coding standards for events
Change 4040377 by Wyeth.Johnson
Refactor the solver to adhere to coding standards (and remove some reroute pins, sorry Shaun)
Change 4040639 by Wyeth.Johnson
Vector Noise Force refactor and optimization
Change 4041031 by Shaun.Kime
Making the modulo functions on the gpu return a value.
#tests passes cook on PS4 and gets past this in compile on Mac
Change 4041254 by Wyeth.Johnson
Refactor Point Attraction, change some behavior also
Change 4041999 by Yannick.Lange
Parameters refactor:
- Find parameters and references in graph
- Renaming parameters, includes renaming all pins in the graph
- Removing parameters
- Find metadata when finding parameters, so we are not looping through all nodes/pins twice
- Parameters list supports multiple emitters in systems
Change 4042058 by Simon.Tovey
Refactored GPU parameters.
- Shader now uses the DI default object to create the correct parameters struct.
All parameter and buffer management now being handled inside this parameter struct.
This allows far more encapsulated code for each DI.
Allows us to reamove the GPU buffers from and the Scene texture refs that were in the base DataInterface class.
Simplifies the API and process of implementing DI's on the GPU considerably.
- Removed all existing GPU buffer support code and usage. All DIs now use a parameters struct.
- Have moved tons of curve code into the base class, simplifying the child implementation classes.
- Implemented GPU curve interpolation.
- Removed bAllowUnnormalizedLUT. Confusing and now unnessessary. All curves do this by default.
- Modified FNiagaraShaderMapId to use the latest FNiagaraCustomVersion::LatestScriptCompileVersion and bumped it.
- Created NiagaraCore module and moved a few classes into it. Anything needed by both the shaders and runtime should be here.
- Refactored DI hierarchy to base from a new UNiagaraDataInterfaceBase which is inside NiagaraCore.
- Removed constness from many UStruct/UEnum/UClass pointers. Technically we don't ever need these to be non const so initialy coded as const. Some existing engine code however requires these be non const so had to propagate that back through our code.
Change 4043427 by jonathan.lindquist
Submitting a material function that will allow users to reproduce mesh surfaces.
Change 4043448 by Olaf.Piesche
Async GPU buffer readbacks and updates
Change 4043679 by Shaun.Kime
Fixing Mac compile issue. Not sure if correct, but unused code so good for now.
#tests n/a
Change 4044000 by Simon.Tovey
static analysis fix
Change 4044001 by Simon.Tovey
Fix for gpu scripts with multiple curves.
Change 4044124 by Yannick.Lange
Fix persistent guid for parameter map set pins.
Change 4044230 by Simon.Tovey
I didn't forget to check these in. Nothing to see here.... *whistling*....
Change 4044584 by Bradut.Palas
Module dependency properties are now available (to be used by technical artists before the functionality is done and submitted)
#jira UE-58200
#tests none
Change 4044663 by Wyeth.Johnson
Jitter position needed begin defaults, got a refactor which I was in there
Change 4044894 by Yannick.Lange
Rename parameter and all referenced pin when renaming a pin on a map set or get.
Also fixes renaming a pin not deleting the old metadata.
Change 4045383 by Wyeth.Johnson
Fix up and comment/tooltip on mesh rotation, look at, and rot rate
Change 4045488 by Wyeth.Johnson
Update Age reorg just for readability
Change 4045799 by Shaun.Kime
Reworking test art to get rid of known issues and put known issues into their own assets.
Change 4046328 by Wyeth.Johnson
Some optimizations, options to polar/cartesian, starting in on Dynamic Inputs
Change 4046728 by Shaun.Kime
Fixed error where we were writing to Loca.Module.EventVelocity instead of Local.Module.EventVelocity.
Change 4047423 by Frank.Fella
Niagara - Fix post load code for the assignment node which was not conditionally post loading another object it was using which now has a custom post load. This resulted in strange pin renaming which was breaking merging and automated tests.
Change 4047425 by Frank.Fella
Niagara - Make the merge manager a little more resistant to malformed stacks.
Change 4047788 by Bradut.Palas
#jira UE-57902 Module input sort priority
#tests none
Change 4048063 by Yannick.Lange
Fix don't show context menu on parameter view categories.
#jira UE-57196
Change 4048068 by Yannick.Lange
Fix create system from emitter
#jira UE-57186
Change 4048132 by Yannick.Lange
Add missing includes.
Change 4048269 by Shaun.Kime
Removing ensure that we log later
#tests n/a
Change 4048273 by Shaun.Kime
Really doing it this time
#tests n/a
Change 4048595 by Yannick.Lange
Fix niagara if node input disconnect on output pin rename.
#jira UE-58095
Change 4049640 by Simon.Tovey
Daft mistake in curve hlsl gen.
Change 4050270 by jonathan.lindquist
Submitting a module that lerps each of a particle system's intrinsic particle values. Each variable set utilizes an opt-in bool.
Change 4050282 by jonathan.lindquist
Submitting newly formated Mesh Reproduction modules. They now contain documentation, be fully generalized and meet our updated coding standards.
Change 4050566 by Olaf.Piesche
-More fixes and changes for async gpu buffer readback
-removed more CPU intervention; spawning and death now happen largely without CPU direction, other than determining the number of particles to spawn
-Added piping number of vert indices per instance from the renderer down to the GPU context and CS; as a result, GPU simulated mesh emitters are working again; this will need a bit of additional work to handle multiple renderers (will need multiple DrawIndirect parameter buffers reflecting the different renderers)
-General cleanup and prettification
Change 4050907 by Frank.Fella
Niagara - Add support for default dynamic inputs on modules and dynamic inputs.
Change 4051436 by Simon.Tovey
Forcing a refresh of curve LUTs on assets with old versions.
Change 4051463 by Simon.Tovey
Compile fix
Change 4051900 by Frank.Fella
Niagara - Fix linux warning.
Change 4052253 by Olaf.Piesche
GPU sim interpolated spawn fixes - Look Ma, no gaps!
Change 4052321 by Frank.Fella
Niagara - Enable the level sequence test.
Change 4052353 by Shaun.Kime
Renamed variable after Wyeth's change
#tests MeshOrientationTests now pass
Change 4052627 by jonathan.lindquist
Submitting a new spline function.
Change 4052648 by Shaun.Kime
PS4 development builds don't seem to be able to remove generated data for structs like this even though it is in a non-editor build.
#tests n/a
Change 4052661 by Olaf.Piesche
-Avoid branching on every OutputData operation by allocating a scratch instance at the buffer end and setting the default index from AcquireIndex to that.
-bit of shader code cleanup
Change 4052706 by jonathan.lindquist
Adding a module that supports a single segment spline
Change 4052712 by jonathan.lindquist
Adding a below threshold output to the direction and length safe function
Change 4052786 by jonathan.lindquist
Submitting a new height lerp function
Change 4053126 by jonathan.lindquist
Submiting a function that calculates a triangle's surface area.
Change 4053132 by jonathan.lindquist
Changing the category to geometry
Change 4053141 by jonathan.lindquist
Moving the asset back to a generic math category
Change 4053166 by jonathan.lindquist
Submitting a new threshold function that removes threshold downtime.
Change 4053564 by Shaun.Kime
Added staging to ini as requested by cook
#tests n/a
Change 4053619 by Shaun.Kime
Fixing defaults
#tests used by Orion art
Change 4054171 by Yannick.Lange
Remove bold font for parameters.
Change 4054183 by Yannick.Lange
Syncing system exposed parameters and parameters list. Includes adding, removing and renaming parameters.
Change 4054313 by Wyeth.Johnson
Refactor spawnrate to (mostly, other than a bug) conform to coding standards, and set begin defaults on a few things.
Change 4054840 by Shaun.Kime
Fixing redundant branch for CI
#tests n/a
Change 4055492 by Shaun.Kime
Updating compile version since I changed the usf
#tests n/a
Change 4055550 by Shaun.Kime
Disabling rendering of middle module as it differs between machines.
#tests LevelSequenceTestsNiagara now passes
Change 4056256 by Shaun.Kime
Disabling the ensure and turning into log statements for curve copying
#tests n/a
Change 4056287 by Shaun.Kime
Now using GLobalCompileShader. There are still issues with cooking as there is sometimes a runtime streaming error that we didn't read in the correct amount of data. I think the logic for when/if we stream out the compiled shader might still need TLC.
#tests n/a
Change 4056381 by jonathan.lindquist
A new quat to angle axis and angle axis to quat conversion mat function
Change 4056513 by Frank.Fella
Niagara - Fix crashes for default data interfaces where the pin default was empty or the data interface wasn't initialized.
#jira UE-58789
Change 4056734 by Frank.Fella
Niagara - Drag and drop for modules.
Change 4056880 by Simon.Tovey
Replacing engine tests shots for RibbonID test.
Some slight changes introduced, likely curve or recent module changes.
Change 4056894 by Bradut.Palas
UNiagaraStackEntry Error refactoring + Module dependency warning feature.
#jira UE-58199, UE-58200
#tests none
Change 4056916 by Bradut.Palas
Add missing files from shelved changelist.
#tests none
Change 4056937 by Bradut.Palas
#jira UE-54678 The skeletal mesh customisation did not update when the mesh was changed through the data interface or mesh editor
#tests none
Change 4057014 by Frank.Fella
Niagara - Fix cis initializer order warning.
Change 4057542 by Bradut.Palas
#jira UE-58554 Remove Refresh UI button from Niagara script editor
#jira UE-58555 Remove Numeric Output Type Selection Mode from Niagara script UI
#tests none
Change 4057702 by Bradut.Palas
The stack editor priority in the variable metadata now properly has zero as default value.
#jira UE-58740
Change 4057758 by Frank.Fella
Niagara - Fix text wrapping for error items.
Change 4057990 by Bradut.Palas
Stack error tweaks (added error count to the stack errors button and also updating icon according to highest severity issue in the subtree)
#tests none
Change 4057996 by Shaun.Kime
Trying to fix the static analysis header tool error in CIS
#tests n/a
Change 4058027 by Shaun.Kime
Fixing compilation on other platforms
#tests compiles on playstation
Change 4058356 by Frank.Fella
Niagara - Fix an assert that happens when adding a module or dynamic input with a boolean or enum input.
Change 4058428 by Frank.Fella
Niagara - Fix a crash when removing an input from a set variables node in the stack which was caused by the function losing an input without the stack being refreshed. This also fixes an issue where add and remove actions on a set variables module wouldn't take affect until the graph was compiled.
Change 4059924 by Wyeth.Johnson
Rollback //UE4/Dev-Niagara/Engine/Plugins/FX/Niagara/Content/Modules/Spawn/Velocity/AddVelocity.uasset to revision 5
Change 4060256 by Wyeth.Johnson
Forces are now dependent on a solver
Change 4060430 by Wyeth.Johnson
Velocity modules depend on a solver
Change 4060949 by Shaun.Kime
Fixing pragma once definition as well as a possible null deref
#tests n/a
Change 4060955 by Shaun.Kime
Fixing due to changes in defaults
#tests all now pass PC
Change 4061000 by jonathan.lindquist
Debug particle material improvements which includes comments in the shader, rearranged layout with a vector 2 input for particle id, new texture, a new instance that includes "focus masking"
Change 4061804 by Wyeth.Johnson
Optimized out a couple unnecessary bits of math from some axis alignment stuff, solver dependencies
Change 4061974 by Simon.Tovey
Fixed GPU cooking.
- Removing check for emitter SimTarget in CanBeRunOnGpu() and relying only on the script usage having been loaded already.
We can't rely on properties in the emitter being loaded before the call to UNiagaraScript::PostLoad() so this is unsafe.
- Adding some dummy gpu buffers to bypass validation ensures in rhi when we need to set params for SRVs that have not been allocated yet.
- Fixed bug in RHI that was returning FGPUFenceRHIParamRef and so the created fence was immediately freed and boom.
Change 4062269 by Shaun.Kime
Re-enabling most of the tests.
#test n/a
Change 4062414 by tim.gautier
QAGame: Updated QA-Effects for mobile compatibility
- Removed Atmospheric Fog (not supported on Mobile)
- Added SkySphere (resolved lighting issues)
Change 4062651 by Shaun.Kime
Saving with versions
Change 4062673 by Shaun.Kime
Making emitter names without spaces so that they can be blacklisted if need be
Change 4062686 by Shaun.Kime
Getting ready for CI for 4.20
Change 4062687 by Shaun.Kime
Updating mac images
Change 4063298 by Shaun.Kime
Disabling collision test gpu for now. Need to investigate what broke it tomorrow.
#tests CollisionBounceGPU
Change 4063373 by Shaun.Kime
Blacklisting mac tests that still need work
Change 4063434 by Shaun.Kime
Cleaning out previous debug code
#tests n/a
Change 4063618 by Yannick.Lange
Fix dragging an input pin to the add pin of an if node
#jira UE-58600
Change 4063847 by Frank.Fella
Niagara - Rename RibbonSortKey to RibbonLinkOrder, change it from an int32 to a float, and disable uv age offset when using link order instead of normalized age to order particles in the ribbon. This should fix the issues preventing beams from being implemented nicely.
#tests Auto-tests
Change 4064150 by tim.gautier
QAGame: Removing floating NewWidgetBP from /Content
Change 4064237 by Shaun.Kime
Disabling the level sequence test for now
Change 4064902 by Shaun.Kime
Fixing compile errors on linux editor build
#jira UE-58620
#tests n/a
Change 4065167 by tim.gautier
QAGame: Submitting temporary update to TM-ShaderModels, adding Niagara station
Change 4065400 by tim.gautier
QAGame: Submitting updated (temp) TM-ShaderModels. Set NewNiagaraEmitter to Local Space by default
Change 4065540 by Frank.Fella
Niagara - Temporarily disable the module dependencies until they can be fixed.
Change 4065570 by Shaun.Kime
Fixing linux build
#tests n/a
#jira UE-58979
Change 4066753 by Shaun.Kime
Updating custom version after previous change to shader includes
#tests autotests pass
Change 4067981 by Frank.Fella
Niagara - Fix potential null dereference found by CIS
#jira UE-59013
Change 4067998 by Shaun.Kime
Nullpointer checks on shutdown
#jira UE-59000
Change 4068104 by Frank.Fella
Niagara - Change the prefix for the previous parameter values from PREV__ to PREV_ since the cross compiler reserves all symbols with double underscores for opengl.
Change 4068118 by Frank.Fella
Niagara - Fix an open GL crash where we weren't passing the correct buffer index when setting parameters for compute shaders.
Change 4069299 by Olaf.Piesche
Async GPU readback/update mobile platform fixes
CPU particles should work on Android
#jira UE-58986
Change 4069603 by Shaun.Kime
Making it possible to see the debug output if the console variables are set for shaders.
#tests auto-tests pass
Change 4069628 by Shaun.Kime
OpenGL is very picky about shutting down its texture buffers. We were improperly holding onto static resources and leaking OpenGLShaderResourceViews until module shutdown. Unfortunately, this is *after* the renderer has been shut down and the corresponding OpenGL managers have been deleted, causing us to call into deleted memory. By making several classes FRendererResources, we now register at the appropriate times. In several cases, since the buffers are special purpose fallbacks I moved them into helper locations that are build on demand.
Removed FNiagaraVertexFactoryBase::DummyBuffer
Created FNiagaraDummyRWBufferInt and FNiagaraDummyRWBufferFloat so that I could wrap several dummy RW buffers in RendererResources and TGlobalResource.
Removed NiagaraEmitterInstanceBatcher::DummyWriteIndexBuffer
#tests all auto-tests pass on PC and OpenGL and we can open and close OpenGL after using Niagara assets
#jira UE-59000
Change 4069646 by Shaun.Kime
Disabling Niagara component activation on Switch. This is an attempt to bypass a crash after the assets have been loaded on Switch.
#tests auto-tests on PC still pass
#jira UE-59048
Change 4069660 by Shaun.Kime
Updated Niagara version
#tests Auto tests pass
Change 4069714 by Shaun.Kime
Fixing Olaf's checkin prior adding offset to the base readback call
#tests autotests pc pass
Change 4070785 by Olaf.Piesche
Make RWBuffer available on Metal, Vulkan, and ES3.1 with SRVs
Change 4070888 by Olaf.Piesche
#jira UE-57657
Reenable ribbon custom facing mode
Change 4071570 by Shaun.Kime
Removing thread pool size log item as it comes up thousands of times in a cook and is purely for debugging.
#tests n/a
Change 4071926 by Shaun.Kime
Disabling Olaf's change from earlier in the day as it doesn't work on PS4.
#tests Ribbon test now works again
Change 4073700 by Shaun.Kime
Fixing compiler warning about float4 being used as a float.
#tests pc auto tests pass
#jira UE-59157
[CL 4075457 by Shaun Kime in Main branch]
#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3805828 by Gil.Gribb
UE4 - Fixed a bug in the lock free stalling task queue and adjusted a comment. The code is not current used, so this is not actually change the way the code works.
Change 3806784 by Ben.Marsh
UAT: Remove code to compile UBT when using UE4Build. It should already be compiled as a dependency of UAT.
Change 3807549 by Graeme.Thornton
Add a cook timer around VerifyCanCookPackage. A licensee reports this taking a lot of time so it'll be good to account for it.
Change 3807727 by Graeme.Thornton
Unhide the text asset format experimental editor option
Change 3807746 by Josh.Engebretson
Remove WER from iOS platform
Change 3807928 by Robert.Manuszewski
When async loading, GC Clusters will be created after packages have been processed to avoid situations where some of the objects that are being added to a cluster haven't been fully loaded yet
Change 3808221 by Steve.Robb
GitHub #4307 - Made GetModulePtr() thread safe by not using GetModule()
^ I'm not convinced by how much thread-safer this is really, but it's tidier anyway.
Change 3809233 by Graeme.Thornton
TBA: Misc changes to text asset commandlet
- Rename mode to "loadsave"
- Add -outputFormat option which can be assigned "text" or "binary"
- When saving binary, use a differentiated filename so that source assets aren't overwritten
Change 3809518 by Ben.Marsh
Remove the outdated UnrealSync automation script.
Change 3809643 by Steve.Robb
GitHub #4277 : fix bug; FMath::FormatIntToHumanReadable 3rd comma and negative value
#jira UE-53037
Change 3809862 by Steve.Robb
GitHub #3342 : [FRotator.h] Fix to DecompressAxisFromByte to be more efficient and reflect its intent accurately
#jira UE-42593
Change 3811190 by Graeme.Thornton
Add support for writing specific log channels to their own files
Change 3811197 by Graeme.Thornton
Minor updates to output formatting and timing for the text asset commandlet
Change 3811257 by Robert.Manuszewski
Cluster creation will now be time-sliced
Change 3811565 by Steve.Robb
Define out non-monolithic module functions.
Change 3812561 by Steve.Robb
GitHub #3886 : Enable Brace-Initialization for Declaring Variables
Incorrect semi-colon search removed after discussion with author.
Test added.
#jira UE-48242
Change 3812864 by Steve.Robb
Removal of some unproven code which was supposed to fix hot reloading BP class functions in plugins.
See: https://udn.unrealengine.com/questions/376978/aitask-blueprint-nodes-disappear-when-their-module.html
#jira UE-53089
Change 3820358 by Ben.Marsh
PR #4358: Incredibuild use ShowAgent by default (Contributed by projectgheist)
Change 3822594 by Ben.Marsh
UAT: Improvements to log file handling.
- Always create log files in the final location, rather than writing to a temp directory and copying in later.
- Now supports -Verbose and -VeryVerbose for increasing log verbosity, rather than -Verbose=XXX.
- Keep a backlog of log output before the log system is initialized, and flush it to the log file once it is.
- Allow buildmachines to specify the uebp_FinalLogFolder environment variable, which is used to form paths for display. When build machines copy log files elsewhere after UAT finishes (eg. a network share), this allows error messages to display the right location.
Change 3823695 by Ben.Marsh
UGS: Fix issue where precompiled binaries would not be shown as available for a change until scrolling the last submitted code change into the buffer (other symptoms, like de-focussing the main window would cause it to go back to an unavailable state, since the changes buffer was shrunk).
Now always queries changes up to the last change for which zipped binaries are available.
Change 3823845 by Ben.Marsh
UBT: Exclude C# projects for unsupported platforms when generating project files.
Change 3824180 by Ben.Marsh
UGS: Add an option to show changes by build machines, and move the "only show reviewed" option in there too (Options > Show Changes).
#jira
Change 3825777 by Steve.Robb
Fix to return value of StringToBytes.
Change 3825810 by Ben.Marsh
UBT: Reduce length of include paths for MSVC toolchain.
Change 3825822 by Robert.Manuszewski
Optimized PIE lazy pointer fixup. Should be up to 8x faster now.
Change 3826734 by Ben.Marsh
Remove code to disable TextureFormatAndroid on Linux. It seems to be an editor dependency.
Change 3827730 by Steve.Robb
Try to avoid decltype(auto) if it's not supported.
See: https://udn.unrealengine.com/questions/395644/build-417-with-c11-on-linux-ttuple-errors.html
Change 3827745 by Steve.Robb
Initializer list support for TMap.
Change 3827770 by Steve.Robb
GitHub #4399 : Added a CONSTEXPR qualifiers to FVariant::GetType()
#jira UE-53813
Change 3829189 by Ben.Marsh
UBT: Now always writes a minimal log file. By default, just contains the regular console output and any reasons why actions are outdated and needed to be executed. UAT directs child UBT instances to output logs into its own log folder, so that build machines can save them off.
Change 3830444 by Steve.Robb
BuildVersion and ModuleManifest moved to Core, and parsing of these files reimplemented to avoid a JSON library.
This should be revisited when Core has its own JSON library.
Change 3830718 by Ben.Marsh
Fix incorrect group name being returned by FStatNameAndInfo::GetGroupName() for stat groups.
The editor populates the viewport stats list by calling this for every registered stat and stat group (via FLevelViewportCommands::HandleNewStatGroup). The menu entry attempts to show the stat name with STAT_XXX stripped from the start as the menu item label, with the free-form text description as a tooltip.
For stat groups, the it would previously just return the stat group name as "Groups" (due to the raw naming convention of "//Groups//STATGROUP_Foo//..."). Since this didn't match the expected naming convention in FLevelViewportCommands::HandleNewStat (ie. STAT_XXX or STATGROUP_XXX), it would fail to add it.
When the first actual stat belonging to that group is added, it would add a menu entry for the group based on that, but the stat description no longer makes sense as a tooltip for the group. As a result, all the editor tooltips were junk.
#jira UE-53845
Change 3831064 by Ben.Marsh
Fix log file contention when spawning UBT recursively.
Change 3832654 by Ben.Marsh
UGS: Fix error panel not being selected when opened, and weird alignment/color issues on it.
Change 3832680 by Ben.Marsh
UGS: Fix failing to detect workspace if synced to a different stream. Seems to be a regression caused by recent P4D upgrade.
Change 3832695 by Ben.Marsh
UGS: Invert the options in the 'Show Changes' submenu for simplicity.
Change 3833528 by Ben.Marsh
UAT: Script to rewrite source files with public include paths relative to the 'Public' folder. Usage is: RebasePublicIncludePaths -UpdateDir=<Dir> [-Project=<Dir>] [-Write].
Change 3833543 by Ben.Marsh
UBT: Allow targets to opt-out of having public include paths added for every dependent module. This reduces the command line length when building a target, which has recently become a problem with larger games (due to Microsoft's compiler embedding the command line into each object file, with a maximum length of 64kb). All engine modules are compiled with this enabled; games may opt into it by setting bLegacyPublicIncludePaths = false; from their .target.cs, as may individual modules.
Change 3834354 by Robert.Manuszewski
Archetype pointer will now be cached to avoid locking the object tables when acquiring its info. It should also be faster this way regardless of any locks.
#jira UE-52035
Change 3834400 by Robert.Manuszewski
Fixing crash on exit caused by cached archetypes not being cleaned up before static exit cleanup.
#jira UE-52035
Change 3834947 by Steve.Robb
USE_FORMAT_STRING_TYPE_CHECKING removed from FMsg::Logf and FMsg::Logf_Internal.
Change 3835004 by Ben.Marsh
Fix code that relies on dubious behavior of requiring referenced "include path only" modules having their _API macros set to be empty, even if the module is actually implemented in a separate DLL.
Change 3835340 by Ben.Marsh
Fix errors making installed build from directories with spaces in the name.
Change 3835972 by Ben.Marsh
UBT: Improved diagnostic message for targets which don't need a version file.
Change 3836019 by Ben.Marsh
UBT: Fix warnings caused by defining linkage macros for third party libraries.
Change 3836269 by Ben.Marsh
Fix message box larger than the screen height being created when a large number of modules are incompatible on startup.
Change 3836543 by Ben.Marsh
Enable SoundMod plugin on Linux, since it's already supported through the editor.
Change 3836546 by Ben.Marsh
PR #4412: fix type mismatch (Contributed by nakapon)
Change 3836805 by Ben.Marsh
Fix commandlet to compile marketplace plugins.
Change 3836829 by Ben.Marsh
UBT: Fix ability to precompile plugins from installed engine builds.
Change 3837036 by Ben.Marsh
UBT: Write the previous and new contents of intermediate files to the log if they change. Makes it easier to debug unexpected rebuilds.
Change 3837037 by Ben.Marsh
UBT: Fix engine modules having inconsistent definitions depending on whether modules are only referenced for their include paths vs being linked into a binary (due to different _API macro).
Change 3837040 by Ben.Marsh
UBT: Remove code that initializes members in ModuleRules and TargetRules objects before the constructor is run. This is no longer necessary, now that the backwards-compatible default constructors have been removed.
Change 3837247 by Ben.Marsh
UBT: Remove UELinkerFixups module, now that plugins and precompiled modules do not require hacks to force initialization (since they're linked in as object files).
Encryption and signing keys are now set via macros expanded from the IMPLEMENT_PRIMARY_GAME_MODULE macro, via project-specific macros added in the TargetRules constructor.
Change 3837262 by Ben.Marsh
UBT: Set whether a module is an engine module or not via a default value for the rules assembly. All non-program engine and enterprise modules are created with this flag set to true; program targets and modules are now created from a different assembly that sets it to false. This removes hacks from UEBuildModule needed to adjust behavior for different module types based on the directory containing the module.
Also add a bUseBackwardsCompatibleDefaults flag to the TargetRules class, also initialized to a default value from a setting passed to the RulesAssembly constructor. This controls whether modules created for the target should be configured to allow breaking changes to default settings, and is set to false for all engine targets, and true for all project targets.
Change 3837343 by Ben.Marsh
UBT: Remove the OverrideExecutableFileExtension target property. Change the only current use for this (the MayaLiveLinkPlugin target) to use a post build step to copy the file instead.
Change 3837356 by Ben.Marsh
Fix invalid character encodings.
Change 3837727 by Graeme.Thornton
UnrealPak: KeyGenerator: Only generate prime table when required, not all the time
Change 3837823 by Ben.Marsh
UBT: Output warnings and errors when compiling module rules assembly in a way that allows them to be double-clicked in the Visual Studio output window.
Change 3837831 by Graeme.Thornton
UBT: When parsing crypto settings, always load legacy data first, then allow the new system to override it. Provides the same key backwards compatibility that the editor settings class gives
Change 3837857 by Robert.Manuszewski
PR #4404: Make FGCArrayPool singleton global instead of per-CU (Contributed by mhutch)
Change 3837943 by Robert.Manuszewski
PR #4405: Fix FGarbageCollectionTracer (Contributed by mhutch)
Change 3838451 by Ben.Marsh
UBT: Fix exceptions thrown on a background thread while caching C++ includes not being caught and logged correctly. Now captures exceptions and re-throws on the main thread.
#jira UE-53996
Change 3839519 by Ben.Marsh
UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data.
Change 3843790 by Graeme.Thornton
UnrealPak: Log the size of all encrypted data
Change 3844258 by Ben.Marsh
Fix plugin compile failure when created via new plugin wizard. Passing -plugin on the command line is unnecessary, and is now reserved for packaging external plugins for the marketplace.
Also extend the length of time that the error toast stays visible, and don't delete the plugin on failure.
#jira UE-54157
Change 3845796 by Ben.Marsh
Workaround for slow performance of String.EndsWith() on Mono.
Change 3845823 by Ben.Marsh
Fix case sensitive matching of platform names in -TargetPlatform=X argument to BuildCookRun.
#jira UE-54123
Change 3845901 by Arciel.Rekman
Linux: fix crash due to lambda lifetime issues (UE-54040).
- The lambda goes out of scope in FBufferVisualizationMenuCommands::CreateVisualizationCommands, crashing the editor if compiled with a recent clang (5.0+).
(Edigrating 3819174 to Dev-Core)
Change 3846439 by Ben.Marsh
Revert CL 3822742 to always call Process.WaitForExit(). The Android target platform module in the editor spawns ADB.EXE, which inherits the editor's stdout/stderr handles and forks itself. Process.WaitForExit() waits for EOF on those pipes, which never occurs because the forked process never terminates.
Proper fix is probably to have the engine explicitly duplicate stdout/stderr handles for new pipes to output process, but too risky before copying up to Main.
Change 3816608 by Ben.Marsh
UBT: Use DirectoryReference objects for all include paths.
Change 3816954 by Ben.Marsh
UBT: Remove bIncludeDependentLibrariesInLibrary option. This is not widely supported by platform toolchains, and is not used anywhere.
Change 3816986 by Ben.Marsh
UBT: Remove UEBuildBinaryConfig; UEBuildBinary objects are now just created directly.
Change 3816991 by Ben.Marsh
UBT: Deprecate PlatformSpecificDynamicallyLoadedModules. We no longer have any special behavior for these modules.
Change 3823090 by Ben.Marsh
UAT: Improve logging for child UAT instances.
- Calling RunUAT now requires an identifier for prefixing into the parent log, which is also used to determine the name of the log folder.
- Stdout is no longer written to its own output file, since it's written to the parent stdout, the parent log file, and the child log file anyway.
- Log folders for child UAT instances are left intact, rather than being copied to the parent folder. The derived names for the copied names were confusing and hard to read.
- Output from UAT is no longer returned as a string. It should not be parsed anyway (but may be huge!). ProcessResult now supports running without capturing output.
Change 3826082 by Ben.Marsh
UBT: Add a check to make sure that all modules that are precompiled are correctly marked to enable it, even if they are part of the build target.
Change 3827025 by Ben.Marsh
UBT: Move the compile output directory into a property on the module, and explicitly pass it to the toolchain when compiling.
Change 3829927 by James.Hopkin
Made HTTP interface const correct
Change 3833533 by Ben.Marsh
Rewrite engine source files to base include paths relative to the "Public" directory. This allows reducing the number of public include paths that have to be added for engine modules.
Change 3835826 by Ben.Marsh
UBT: Precompiled targets now generate a separate manifest for each precompiled module, rather than adding object files to a library. This fixes issues where object files from static libraries would not be linked into a target if a symbol in them was not referenced.
Change 3835969 by Ben.Marsh
UBT: Fix cases where text is being written directly to the console rather than via logging functions.
Change 3837777 by Steve.Robb
Format string type checking added to FOutputDevice::Logf.
Fixes for those.
Change 3838569 by Steve.Robb
Algo moved up a folder.
[CL 3847482 by Ben Marsh in Main branch]
#lockdown Nick.Penwarden
#rb none
Change 3720210 on 2017/10/25 by Olaf.Piesche
Fixing dynamic material params for ribbons
#!codereview scott.kennedy
#!rb none
#!tests scott's test ribbon
Change 3720073 on 2017/10/25 by robomerge
#!ROBOMERGE-AUTHOR: frank.fella
Niagara - Fix a crash where a UNiagaraSystem has been GCed at runtime and there is still a system simulation ticking for it.
#!Tests Minion automated tests no longer crash randomly.
#!rb SimonT
#!ROBOMERGE-SOURCE: CL 3719901 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3719233 on 2017/10/25 by robomerge
#!ROBOMERGE-AUTHOR: philip.buuck
[OR-45889] Ability fail widget will no longer fire if you are dead and have a passive (which is failing to activate while you are dead).
#!rb Matt.Schembari
#!tests PIE
[QAREVIEW] Ensure the ability fail widget and its attached sounds do not trigger on death
#!ROBOMERGE-SOURCE: CL 3719016 in //Orion/Release-44/... via CL 3719072 via CL 3719091
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3718474 on 2017/10/25 by Yannick.Lange
Niagara: Only show isolate menu items on track context menu if it is a system.
Rename "Isolate toggle" to "Isolated".
#!rb none
#!codereview Shaun.Kime
#!tests n/a
Change 3718095 on 2017/10/25 by Yannick.Lange
Niagara: Fix crash when not having dynamic parameter in material.
#!rb none
#!codereview Shaun.Kime
#!tests n/a
Change 3718069 on 2017/10/25 by Yannick.Lange
Niagara: Remove material member from material parameter node and add helper function for getting material dynamic parameter expression.
#!rb none
#!codereview Shaun.Kime
#!tests n/a
Change 3717545 on 2017/10/24 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Removed read / write locks from PipelineStateCache.
#!rb Andrew.Grant, Gil.Gribb
#!test paragon ps4.
#!ROBOMERGE-SOURCE: CL 3716445 in //Orion/Release-44/... via CL 3716701
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3716928 on 2017/10/24 by Shaun.Kime
The cooked dusk minions on PS4 don't have an index buffer, previously causing us to crash. We now fail to initialize the skeletal mesh data interface if this happens. This change also reworks the skeletal mesh data interface to be more like what Simon is already working on, getting rid of some places where we were skinning. Additionally, I have disabled the parallel pretick and posttick logic.Many more checks have been added to try and detect bad situations at runtime.
#!rb olaf.piesche, simon.tovey
#!fyi olaf.piesche, simon.tovey, frank.fella
#!tests am now able to run Test_minionWave on PS4
Change 3715712 on 2017/10/24 by Yannick.Lange
Niagara: Set display name of if node to "If" instead of "NiagaraNodeIf".
#!rb none
#!codereview Shaun.Kime
#!tests n/a
Change 3715430 on 2017/10/23 by Shaun.Kime
Rather than make a unique decision each time we bind a VM function about whether or not we need previous positions, we initialize the decision with the results of last time. The value defaults to false in the constructor, so we're still behaving as we did before, but this time asking for UV info last won't initialize the data to no longer want the previous position even though we later ask for it.
#!rb none
#!fyi simon.tovey
#!tests from Tim Elek - testMinion map get minions spawned then run down the lane and "setteamnum 1" crashes everytime
Change 3715368 on 2017/10/23 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Merging 3714121 from //Orion/Release-44 to Main (//Orion/Main)
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3715255 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3715226 on 2017/10/23 by Shaun.Kime
Getting rid of an ensure for Nan's and switching to a log warning. This keeps it from polluting long term runs in the debugger. It seems like at least one of the Niagara systems on minions generates Nan's.
#!rb none
#!fyi simon.tovey, olaf.piesche, frank.fella
#!tests ran in PIE
Change 3714645 on 2017/10/23 by Yannick.Lange
Niagara: Add ability to create particle system from this emitter in content browser.
#!rb Shaun.Kime
#!tests n/a
Change 3714200 on 2017/10/23 by Olaf.Piesche
Niagara: Fixing rendering of GPU simulated emitters; store SRV instead of data buffers, so we can point the VF at the correct buffer based on sim target
#!codereview simon
#!rb none
#!tests Orion Niagara assets
Change 3713341 on 2017/10/23 by Yannick.Lange
Niagara: Fix NiagaraNodeIF output pins cannot be deleted.
Fix NiagaraNodeIF output pins cannot be renamed.
#!jira UE-50193
#!jira UE-50193
#!rb Shaun.Kime
#!tests n/a
Change 3713133 on 2017/10/23 by Yannick.Lange
Niagara: Isolate emitters in sequencer UI.
- Added being able to extend the sequencer track context menu with a delegate.
- Added entry in track context menu to toggle the selected emitters isolation state.
- Added entry in track context menu to isolate all the selected emitters and turn isolation off for all non-selected emitters.
#!rb Shaun.Kime
#!tests n/a
Change 3712445 on 2017/10/22 by robomerge
#!ROBOMERGE-AUTHOR: shaun.kime
UVScale, UniformAorBFloat, and LinearColorAlongVector added.
#!rb none
#!tests new autotest added
#!ROBOMERGE-SOURCE: CL 3712444 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3712420 on 2017/10/21 by robomerge
#!ROBOMERGE-AUTHOR: shaun.kime
Fixing issue where if you disabled Acceleration Force it would cause a compile error saying that it could find a default for Physics.Force but not in the parameter map. This was because of a simple error of using the index of the pin instead of the value of the pin when routing around the disabled node. In interpolated spawn scripts, there are two parameter maps, the spawn and update. If you always look in 0, which you would if you just use the pin index, you'd never find the Physics.Force variable in parameter map at entry 1.
#!rb none
[CODEREVIEW] frank.fella
[FYI] simon.tovey, olaf.piesche, wyeth.johnson
#!tests created an emitter, disabled Acceleration Force.. still compiled.
#!ROBOMERGE-SOURCE: CL 3712419 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3711602 on 2017/10/20 by robomerge
#!ROBOMERGE-AUTHOR: shaun.kime
Fix for issue where we were getting a check due to the mesh not being set up properly. We now catch the error and don't try and do the bad operation. The log will have something like:
LogNiagara: SkeletalMesh data interface has no valid mesh. Failed InitPerInstanceData
#!jira UE-51511
#!rb Simon.Tovey
#!tests n/a
#!ROBOMERGE-SOURCE: CL 3711601 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3711288 on 2017/10/20 by robomerge
#!ROBOMERGE-AUTHOR: eric.ketchum
[Justice] Ultiamte VFX in Niagara work, includes GeneratePositionEvent Module work
#!rb: None
#!tests: PIE
[CODEREVIEW] Scott.Kennedy, Tim.Elek, Simon.Tovey, Shaun.Kime
#!ROBOMERGE-SOURCE: CL 3711285 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3711197 on 2017/10/20 by Olaf.Piesche
Fix for ribbon facing issue; VF assumed local space particles in the ribbon, now it assumes world space (the most common case); TODO: deal with local space properly
#!rb none
#!tests minion projectile ribbon trail
Change 3710634 on 2017/10/20 by Mic.Rooney
Moving some Facial Animation stuff around so I can use some of their importing logic inside Orion Dialogue asset importing.
#!RB: none
#!Test: tested/built locally ran preflight Editor/Monolithics build.
#!review-3710635 @andrew.grant, @david.ratti, @thomas.sarkanen
Change 3709686 on 2017/10/20 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Added some more timerguards for slow timer manager tick objects.
Commented out for now.
#!rb Trivial
#!test Paragon Cooked ps4.
#!ROBOMERGE-SOURCE: CL 3709683 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3708958 on 2017/10/19 by Shaun.Kime
Back out changelist 3708456 .. this was an unintentional change
#!rb none
#!tests n/a
Change 3708839 on 2017/10/19 by Shaun.Kime
Merging CL 3708835
Fixing Scott's common crash with adding an emitter with autocompile off
#!rb frank.fella
#!tests n/a
Change 3708784 on 2017/10/19 by Shaun.Kime
Merging CL 3708782
//Orion/Main/... to //Orion/DevGeneral/...
#!rb none
#!tests n/a
Change 3708600 on 2017/10/19 by robomerge
#!ROBOMERGE-AUTHOR: mieszko.zielinski
Made bots in Ultimate movement mode not ignore all enemies but instead use a very small radius for enemy selection #!Orion
#!rb none
#!test golden path
#!ROBOMERGE-SOURCE: CL 3706947 in //Orion/Release-44/... via CL 3708165
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3708473 on 2017/10/19 by Shaun.Kime
Merging Frank's changes for team color support from Main to Dev-General
#!rb Frank.Fella
#!tests test_minionwave worked
Change 3708456 on 2017/10/19 by Shaun.Kime
Particles.Random set to 0.0
#!rb none
#!tests n/a
Change 3708455 on 2017/10/19 by Shaun.Kime
Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara
#!rb none
#!tests passed minion fx autotest
Change 3707648 on 2017/10/19 by Shaun.Kime
Temporary render thread safety code for emitter instances and it's dataset until a more thorough refactor/safety pass can be made.
Defer deletion of dataset to RT.
Ensure resets don't mess with data inflight RT commands are using.
Checkin on behalf of Simon Tovey
#!jira OR-45423
#!rb Simon.Tovey
#!tests ran through the LaneMinionFXTests successfully on PC
Change 3707096 on 2017/10/19 by robomerge
#!ROBOMERGE-AUTHOR: shaun.kime
CameraOffset for sprites. Had to bless some new images due to Simon's off by one frame render fix from a few days ago.
#!rb none
#!tests automated tests pass
#!ROBOMERGE-SOURCE: CL 3707088 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3706726 on 2017/10/19 by Rob.Cannaday
Merge XMPP resource version to use version 2 instead of version 3
#!rb trivial
#!tests compile
#!ROBOMERGE: Main, 44, Tencent
Change 3706349 on 2017/10/19 by Josh.Markiewicz
#!UE4 - Cross Voice code review feedback
- fixed up broken stack vs queue
- fixed GetRoomId returning int32 instead of uint64
- fixed switch room logic
- more/better logging
- more comments
#!jira TEN-301
#!review-3681404 @sam.zamani, @rob.cannaday
#!rb none
#!tests local cheat codes
Change 3705453 on 2017/10/18 by robomerge
#!ROBOMERGE-AUTHOR: arne.schober
Initzalize missing Cubemaps with Zero index to avoid inconsistencies between platforms (like PS4 where a negative index will access the memory shead of the array)
#!RB Daniel.Wright
#!Tests LaunchOnPs4
#!ROBOMERGE-SOURCE: CL 3704845 in //Orion/Release-44/... via CL 3704847
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3705399 on 2017/10/18 by robomerge
#!ROBOMERGE-AUTHOR: scott.kennedy
Default Niagara emitter changed color property to better default value.
Updated basic glow emitter
Added energy bubble base emitter
put a little more polish into siege minion impact FX.
#!ROBOMERGE-SOURCE: CL 3704654 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3704426 on 2017/10/18 by Shaun.Kime
Standardizing our null and zero checks for the sprite and mesh renderers trying to prevent OR-45423
#!rb simon.tovey
#!fyi hunter.kent
#!tests ran test_minionwave with no crashes on PC, needs QA to bang on it to be sure
Change 3703288 on 2017/10/18 by Olaf.Piesche
Simon's change to avoid recreation of vertex buffers; should also fix uninitialized gpu buffer crash
#!rb olaf.piesche, simon.tovey
#!tests minion test map PC and PS4
Change 3701373 on 2017/10/17 by robomerge
#!ROBOMERGE-AUTHOR: shaun.kime
Passing the wrong shader into ribbon vertex factories when setting shader constants for pixel shader.
#!rb Olaf.Piesche
#!tests test_minionwave runs
#!ROBOMERGE-SOURCE: CL 3701371 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3701108 on 2017/10/17 by Hunter.Kent
Added a "New Minions (nomcp)" option to the Mode dropdown in the BuildLauncher tool so that Devs can test the new minions on PS4 more easily.
#!RNX
#!Test PS4
#!rb @tim.elek
#!review-3701110 @andrew.grant, @daniel.lamb
Change 3701044 on 2017/10/17 by robomerge
#!ROBOMERGE-AUTHOR: jon.lietz
- white space fixes
- added in more detail to logging
- fixed dragon GC to not hide when the mesh is hidden
#!rb none
#!tests complies and logging is updated
[FYI] Billy.Rivers, Eric.Ketchum, Fredrik.Seehuusen
#!ROBOMERGE-SOURCE: CL 3700996 in //Orion/Release-44/... via CL 3701002
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3700900 on 2017/10/17 by Shaun.Kime
Integrating possible crash fix from Dev-Niagara to Dev-Gen
#!rb none
#!tests n/a
#!fyi Olaf.Piesche
Change 3700492 on 2017/10/17 by Shaun.Kime
Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara
#!rb none
#!tests done in branch
Change 3700217 on 2017/10/17 by Olaf.Piesche
Fix for potential crash in sprite renderer
#!rb none
#!tests minion test map
Change 3700216 on 2017/10/17 by Benn.Gallagher
Fix for crash using Ghost's E on Rampage due to posable mesh being set as the master pose component. Clothing simulation assumed derivative of skeletal mesh component so was failing to correctly map its bones to the master.
#!rb Lina.Halper
#!jira OR-45226
#!tests PIE + Standalone games hitting Rampage with Ghosts E
Change 3699660 on 2017/10/17 by Jason.Bestimt
#!ORION_DG - Fixes to UnrealHitchParser edge cases
#!RB:none
#!Tests: Ran on Logs from QA
#!CodeReview: ben.salem
Change 3699462 on 2017/10/17 by Shaun.Kime
Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara
#!tests preflight ok
#!rb none
Change 3699010 on 2017/10/17 by Jeff.Williams
Merging //Orion/Main to Dev-General (//Orion/Dev-General) @3698920
#!rb none
#!tests none
Change 3698519 on 2017/10/16 by Olaf.Piesche
Sawtooth ribbon fix; may well fix other potential ribbon rendering artifacts
#!rb none
#!tests minion wave test map
Change 3698380 on 2017/10/16 by Shaun.Kime
Updating logic to now support the autoattachment
#!rb none
#!tests autotests pass..
Change 3698263 on 2017/10/16 by Olaf.Piesche
Assume degrees for sprite rotation
#!rb none
#!codereview shaun.kime
#!tests test sprite emitter
Change 3697652 on 2017/10/16 by Olaf.Piesche
Fixing crappy FP math for alternating vertex IDs ffor ribbon expansion
#!rb none
#!tests minion test map
Change 3696906 on 2017/10/15 by Shaun.Kime
Fixing the spurious missing required attribute errors that were occuring for Scott on Friday. These were a result of a bad assumption in the code. The scripts input array can include more than just this emitter's scripts and as such we cannot assume that all the input scripts should be checked against the Emitter's renderers. Now we only check this emitter's scripts against the renderers.
#!rb none
#!tests now no longer generates invalid errors
#!fyi frank.fella, olaf.piesche, simon.tovey
Change 3695456 on 2017/10/13 by Olaf.Piesche
Fix for potential ribbon crash and end-of-ribbon rendering artifacts
#!rb none
#!codereview scott.kennedy
#!tests minion wave test map
Change 3694545 on 2017/10/13 by Andrew.Grant
Fix for low frequency async loading crash (OR-42535)
#!rb gil.gribb
#!tests comppiled
Change 3694176 on 2017/10/13 by Jeff.Williams
Plugin manifest name changed to DLCFile name
#!rb none
#!tests compile, stage
Change 3693582 on 2017/10/12 by Don.Eubanks
Fixing PS4 Compile warning (constructor init order not matching member define order)
#!rb none
#!tests Compile Shipping Client PS4
#!fyi olaf.piesche
Change 3693516 on 2017/10/12 by Olaf.Piesche
Niagara: Remove mesh renderer assert, replace with early out
#!rb none
#!tests niagara mesh test asset
Merging
//Orion/Dev-Niagara/Engine/Plugins/FX/Niagara/Source/Niagara/Private/NiagaraRendererMeshes.cpp
to //Orion/Dev-General/Engine/Plugins/FX/Niagara/Source/Niagara/Private/NiagaraRendererMeshes.cpp
Change 3693051 on 2017/10/12 by Ben.Salem
Adding parser for any logs with dumphitches enabled. Run UnrealHitchParser <logfile> to receive a logfile_hitches.txt file containing only the hitches in the log, plus reference lines to their location in the original log.
#!rb Clayton.Langford
#!tests Parsed a 5mb log with dumphitches down to 23k of hitch data.
Change 3692912 on 2017/10/12 by Olaf.Piesche
Merging: Niagara ribbon tiling distance
#!rb none
#!tests ribbon test asset
Change 3692835 on 2017/10/12 by Shaun.Kime
Synching with Dev-Niagara, specifically CL 3692821 which made InitialMeshRotation respect local space flags.
#!rb none
#!fyi scott.kennedy, wyeth.johnson
#!tests n/a
Change 3692751 on 2017/10/12 by Shaun.Kime
Removing script that shouldn't have come over.
#!rb none
#!tests n/a
Change 3692746 on 2017/10/12 by Shaun.Kime
Merging using //Orion/Dev-General/_To_//Orion/Dev-Niagara
#!rb none
#!tests opened test level and created new emitter/system
Change 3692616 on 2017/10/12 by Don.Eubanks
OR-45131
Marking SRetainerWidget and our Orion-specific VirtualWindow (child of the RetainerWidget when bUseRetainerWidget is true) as SelfHitTestInvisible so they don't interfere with our HUD tooltip mouse picking.
#!rb dan.hertzka
#!tests Compile DebugGame Editor Win64 / Shipping Client PS4 / PIE
#!codereview nick.darnell
Change 3691912 on 2017/10/12 by robomerge
#!ROBOMERGE-AUTHOR: jeff.williams
Merging //Orion/Dev-General to Main (//Orion/Main) to [at 3689865] #!rb none
#!tests compile, editor
#!ROBOMERGE-SOURCE: CL 3691870 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3690944 on 2017/10/11 by Jeff.Williams
Adding Plugin Config .ini's to DLC paks. Building pluginmanifests per-DLC.
#!rb Daniel.Lamb
#!tests Compile, build
Change 3688989 on 2017/10/10 by Lina.Halper
LOD sync of attached/parent
#!rb: Laurent.Delayen
#!tests: price with shotgun skin/PIE/editor
Change 3687592 on 2017/10/09 by Ben.Salem
Increase the number of times we run each shallow test to make sure our numbers are reliable. Improve shallow FX perf logger to be able to handle multiple runs of the same test.
#!rb clayton.langford
#!tests Ran sparrow shallow tests.
Change 3686560 on 2017/10/09 by Shaun.Kime
Flipping the min/max values to be standard
#!rb none
#!tests n/a
Change 3686046 on 2017/10/09 by Shaun.Kime
Merging latest from Dev-Niagara in preparation for Effects team work on Monday
#!rb none
#!tests successful preflight
#!fyi Andrew.Grant, Simon.Tovey, Frank.Fella, Olaf.Piesche, Scott.Kennedy, Tim.Elek
Change 3685613 on 2017/10/07 by robomerge
#!ROBOMERGE-AUTHOR: simon.tovey
Implementing vector field matrix inverse fix from CL3675167 to 43.3.
#!rb none
#!tests none
#!lockdown andrew.grant
#!ROBOMERGE-SOURCE: CL 3684339 in //Orion/Release-43.3/... via CL 3684340 via CL 3684342
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3685603 on 2017/10/07 by robomerge
#!ROBOMERGE-AUTHOR: thomas.ross
RotationalContent Improvements
- Fixed potential bug where tags could be updated when not intended on RotationalContentManager
- Fix for PIE assert
- Moved DebugParsing checks to all cases of InitializingTagsFromMCP so that connecting to MCP or returning to the main menu would not overwrite a console / manually set debug option.
- Removing config tag from RotationalContentOverrides in OrionGlobals.
New Halloween Gauntlet Test
- Adding in Halloween Gauntlet Test to facilitate launching halloween overriden builds easily. Run by typing Halloween into the custom text box.
#!rb none
#!tests local builds / editor / PIE
#!ROBOMERGE-SOURCE: CL 3682813 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3685408 on 2017/10/07 by ben.salem
Fixing robomerge error in DevGen
#!CodeReview: ben.salem, jason.bestimt, andrew.grant, jeff.williams
Unresolved conflicts. ben.salem, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/OrionGame/Build/OrionBuild.xml
--------------------------------------
Merging using DevGen->Release43.3
Repairing mailer for nightly Perf tests, fixing email headers.
#!tests run in devgen
#!rb none
#!lockdown andrew.grant
#!ROBOMERGE-SOURCE: CL 3680914 in //Orion/Release-43.3/... via CL 3680919 via CL 3680922
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3685073 on 2017/10/06 by Andrew.Grant
Merging 3680922 //Orion/Main to Dev-General (//Orion/Dev-General)
#!tests #!rb na
Change 3684717 on 2017/10/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed issue where GT & RT times in profile info were reversed :(
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3680128 in //Orion/Release-43.2/... via CL 3680129 via CL 3680130 via CL 3680235
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3684512 on 2017/10/06 by Laurent.Delayen
Added 'PlayRateBasis' to SequencePlayer node, to scale PlayRate without having to do more expensive BP code.
#!rb lina.halper
#!tests minion AnimBP nativization
Change 3684059 on 2017/10/06 by Max.Preussner
Orion: Fixed ability videos not loading on PS4 and/or not looping
#!fyi stephan.jiang
#!jira OR-44682
#!rb none
#!rnx
#!tests none
Change 3683538 on 2017/10/06 by David.Ratti
batch all non-trickle gold and XP gameplay cues into single compact RPC call. Fixes issues where rpc throttling would prevent gold/xp number pops over large groups of minions.
-Fixes enemy heroe kills/assists never showing XP pops. We now pass the avatar actor as the Source Actor into ::AwardXP (like we do for ::AwardCardXP). This was causing XP pops to only show for minions and not players.
-Fixes case where killing minions with badass was not displaying pops (prediction key issue)
#!rb none
#!tests editor, pie
#!review-3683539 @Matt.Schembari
Change 3683364 on 2017/10/06 by Andrew.Grant
Changed warning to info
#!tests #!rb na
Change 3681999 on 2017/10/05 by Bart.Hawthorne
Implement live spectating feature. Clients can join a match using a custom key by setting their custom key and using the "JoinAsSpectator" console command. This will be replaced with proper UI later. The client is able to watch a match from start to finish (or join in the middle), then they will see the end game sequence and return to the title screen at match completion.
#!rb cody.haskell
#!fyi ben.zeigler, matt.schembari, matt.kuhlenschmidt, paul.moore
#!jira OR-44111
#!tests Golden path, live spectated numerous matches.
Change 3681403 on 2017/10/04 by Josh.Markiewicz
#!UE4 - base pass for Tencent Cross SDK
- basic testing done with enter/exit/switch room
- basic testing of ShowUI
- checked in disabled
#!rb duck
#!tests see above
#!jira TEN-301
#!review-3681404 @sam.zamani, @rob.cannaday
Change 3680623 on 2017/10/04 by David.Ratti
Rework for how max movement speed is calculated.
The design is now "only strongest movement speed slow affects player speed". Movement speed buffs are unaffected : they are still accumulated along with the strongest slow.
Combat Slows (Shooting, jump penalties) are now aggregated within Max Movement Speed, so the same rules apply. If a slow of greater magnitude is active, Combat Slows will effectively be ignored. Likewise, if a combat slow is stronger than a debuff slow, the debuff slow will effectively be ignored.
Directional Slows (penalty for strafing or backpeddaling) are treated in a similar way. There are some subtleties here, but basically directional slows are only applied if they would be "the strongest" slow.
GE Slows that are not contributing (due to not being the strongest active slow) will still appear to be "on" and applied. (Their GCs will still play, they are not inhibited, handles to them are still valid, etc).
Suggested methods for inspection:
AbilitySystem debug hud (Home/End)
p.VisualizeMovement (displays final calculated movement speed)
Orion.Movement.DirectionalScaleDebug (displays directional slow movement scalar)
Technical information:
1. Changes the way attribute mods are qualified. Rather than qualifying inside the mod prior to evaluating, we qualify all mods within an FAggregator first, then allow a custom callback to run which can further muck with the mods IsQualified bool, then we evaluate like normal except that we just check the IsQualified bool.
2. Added a concept of Aggregator Evaluate Meta Data that can be set per aggregator. This is data that is instrinc to the aggregator rather than passed in by the person evaluating. It may make sense to have this be a shared ptr to reduce memory footprint if this struct grows.
3. Added a notification for attribute sets when an aggregator is created for one of their attributes.
4. Added ForEachMod functions in the aggregators to iterate over all mods (while getting the channel and mod op which are otherwise not known to the actual FAggregatorMod)
5. Added FAggregatorEvaluateMetaDataLibrary which can store common/shared functions for this type of extension.
#!tests pie
#!rb FrankG
#!codereview Fred.Kimberley, Billy.Bramer
#!fyi colin.fogle
#!QAReview
#!RN
#!designchange
Change 3680580 on 2017/10/04 by Ben.Salem
Repair email titles for various reports.
#!rb none
#!tests Reran tests.
Change 3680438 on 2017/10/04 by Dan.Hertzka
GameplayAbilities now pass along their SourceObject when creating the effect context for a new effect
- Fixes the HUD status effect feed not showing sources for a lot of itemization abilities
Also added the tag to prevent showing a feed entry for the Lifesteal received from the first major agi pip
#!rb Dave.Ratti
#!tests OrionEntry PIE - equipped Sand Speeder
#!QAReview: This should address the majority of cases where a card/gem effect buff doesn't show the source item. There are still a number of unaddressed cases, but these will largely be content one-offs from here on
Change 3680344 on 2017/10/04 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Speculative disable of defragging on volumetric lightmap textures.
#!rb andrew.grant
#!test monolith2 ps4
#!ROBOMERGE-SOURCE: CL 3678624 in //Orion/Release-43.3/... via CL 3678628
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3680302 on 2017/10/04 by Shaun.Kime
Integration from DevNiagara.
Some character and card blueprints were changed in a minor way when they called their parent Burst, Loop, etc. as Blueprints cannot have an unattached array pin and Gameplay cues now have an Additional Niagara Particle Systems array.
#!rb none
#!fyi Scott.Kennedy, Olaf.Piesche, Simon.Tovey, Frank.Fella, Andrew.Grant, Tim.Elek
#!tests passed PS4 test level (not submitted, but ported from DevNiagara). Automated tests pass.
Change 3679946 on 2017/10/04 by Laurent.Delayen
Fix for OR-44826. Old minions would crash because their LODs would reduce bone counts, and LowerBodyBoneIndices wasn't properly reset between LOD switches.
#!rb lina.halper
#!FYI andrew.grant
#!tests monolith2 old minions
Change 3679938 on 2017/10/04 by Daniel.Lamb
Allowed foliage cullall option to be modified by scalability options.
#!rb Trivial
#!test Compile paragon editor
Change 3679563 on 2017/10/04 by Jon.Lietz
OR-43599
- added support for WaitForAttributeChange, WaitForAttributeChangeWithComparison, WaitForAttributeChangeThreshold, and WaitForAttributeChangeRatioThreshold to support tracking on an extrnal source. This way you can track when that extranal sources attribute changes and respond to it.
#!rb Dave.Ratti
#!review-3679564 @John.Nielson
#!tests added these waits to hot pursuit and they worked as expected
Change 3679006 on 2017/10/03 by Ben.Salem
Try to fix broken nightly mailer issues for FX tests.
#!rb none
#!tests Preflighted a shallow fx pass successfully in EC.
Change 3677845 on 2017/10/03 by Andrew.Grant
Added an ensure to guard against OR-44826 while further investigations occur
#!tests compiled
#!rb none
Change 3677443 on 2017/10/03 by John.Nielson
Fix to OrionOR-44394, Log Warnings related to Phase GC when loading into game as Phase.
Made it so that gameplayCue's async loads are cancelled when Unloaded (in UnloadGameplayCueNotify).
#!RB: None
#!Test: Pie, Uncooked
#!review-3677445: @David.Ratti
Change 3676748 on 2017/10/02 by Laurent.Delayen
Minions: split body layer is now done in mesh space, to maintain upper body orientation.
#!FYI ray.arnett, lina.halper
#!rb none
#!test lane minion test map
Change 3675950 on 2017/10/02 by Don.Eubanks
Added several new supported tags / status effects to the Floating Status Effect Text system.
Added support for providing a list of Instigating actors when a status effect begins, the list isn't super perfect (overlapping status effects can result in an instigator appearing in multiple lists) but it should be pretty good for now. This paves the way for us to squelch status effects unless they are initiated by the player.
Added ScaleOverDistance curve support for floating numbers / text.
Inverted the Instigator / Target checkboxes for XP in the DamageNumberManager per @matt.schembari request to support his work while I had the asset checked out.
#!rb matt.schembari
#!tests Compile DebugGame Editor Win64 / Shipping Client PS4
Change 3675186 on 2017/10/02 by Mic.Rooney
Support for other anim curve driving audio types (right now specifically DialogueWave)
#!RB: none
#!Test: compiled editor/monolithics/withoutunity and tested locally.
#!review-3675187 @andrew.grant, @david.ratti, @thomas.sarkanen
Change 3675167 on 2017/10/02 by Shaun.Kime
Changed unsafe InverseFast() to an Inverse()
#!jira OR-44671
#!rb Simon.Tovey
#!tests n/a
Change 3674888 on 2017/10/02 by David.Ratti
GGP V2
* Major refactor of the GGP system though this first check in is a scaled back integration from original plans. Primarily to stabilize the system and improve designer work flows before possibly going deeper for a "Completely unified" integration.
Item System:
* Simple Ability Keyword Data now directly references gameplay effect to apply, effectively removing Gameplay Effect Keywords.
* Qualifier and Gameplay Effect parameters now use the FAutoExportScalableFloat structure which automatically hooks up the values to spreadsheets. (GGP is used to surface these parameters for the auto hookup).
Ability System:
* SetByCaller magnitudes are now copied over anytime a GE applies another GE. When an ability applies a GE it also brings over its SetByCaller Magnitude tags from the GE that granted it (if granted bya GE)
#!rb none
#!tests editor pie cooked
#!review-3674889 @Jon.Lietz
Change 3674170 on 2017/09/30 by Mieszko.Zielinski
Fixed a bug in OrionToggleableNavLinkProxy resulting from an overly optimistic assumption that Navmesh and Gameplay levels are being saved in sync #!Orion
Had to make OrionToggleableNavLinkProxy's nav poly ID caching happen on map load.
#!rb none
#!test golden path
#!OR-44738
Change 3672937 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Changed Gauntlet filecopy to a single thread to see if it addresses issue with PS4 files
#!tests 3compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3670237 in //Orion/Release-43/... via CL 3670243 via CL 3670244 via CL 3670245 via CL 3670246
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672867 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Restored previous behaviour of integer numbers being formatted as "1" and not "1.00"
#!tests ran game, checked playlist analytic
#!rb nikdel
#!ROBOMERGE-SOURCE: CL 3669417 in //Orion/Release-43/... via CL 3669556 via CL 3669557 via CL 3669558 via CL 3669559
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672575 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: david.ratti
Remove warning that can happens normally with backwards compat replays
#!rb none
#!tests compile
#!ROBOMERGE-SOURCE: CL 3667518 in //Orion/Release-43.3/... via CL 3667520
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672548 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Fixed crash in the editor caused by trying to build hlods with StaticMeshComponents that don't have a static mesh assigned.
#!rb Andrew.Grant
#!test Editor building hlods
#!ROBOMERGE-SOURCE: CL 3667059 in //Orion/Release-43.3/... via CL 3667060
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672542 on 2017/09/29 by Andrew.Grant
Merging
#!rb #!tests na
Change 3672390 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Changed memreport settings for frontend tests
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3666239 in //Orion/Release-43/... via CL 3666240 via CL 3666241 via CL 3666242 via CL 3666243
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672385 on 2017/09/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Reworked and pretty much final PipelineState cache code
- various comments incorporated
- namespaced functions
- removed redundant class and replaced with ref pointer
#!tests soaked a lot
[at daniel.lamb,] [at arne.schober] #!rb none
#!ROBOMERGE-SOURCE: CL 3666233 in //Orion/Release-43/... via CL 3666235 via CL 3666236 via CL 3666237 via CL 3666238
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3672281 on 2017/09/29 by Rob.Cannaday
Add user ID to OnNetworkCheatDetected
#!jira TEN-272
#!jira TEN-273
#!jira TEN-274
#!rb rob.cannaday
#!tests Win64 AI match, simulate cheat detected by cheat command
#!review-3672282 @ian.fox @sam.zamani
Change 3671688 on 2017/09/29 by Frank.Gigliotti
Added ability to set developer comment when adding native tags.
#!RB David.Ratti
#!Tests None
Change 3670409 on 2017/09/28 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for dump type made while doing cleanup
#!tests compiled Win64, PS4, ran PS4
#!rb none
#!ROBOMERGE-SOURCE: CL 3664048 in //Orion/Release-43/... via CL 3664049 via CL 3664050 via CL 3664873
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3670399 on 2017/09/28 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed race condition in pipeline state cache
Cache now trims every 60 secs to reduce memory. Saves ~95MB in a 60m game of Paragon
(Couple of extra tweaks planned, but this should be GTG for a v43 release)
#!rb codereviewed
#!tests soaked locally, lots
#!ROBOMERGE-SOURCE: CL 3663603 in //Orion/Release-43/... via CL 3663605 via CL 3663607 via CL 3664870
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3669802 on 2017/09/28 by Andrew.Grant
From Dev-Framework
#!jira UE-49858 Fix performance regression deleting many actors at once. It was redundantly serializing packages repeatedly to look for actor references, so now we cache that once per package and only display the slow dialog/p4 check when needed
#!rb michael.noland
#!codereview andrew.grant
#!tests na
Change 3669709 on 2017/09/28 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
Restored LoadTimesObjectVersion even though it is no longer used, packages saved with it will issue a warning in the cooker
#!rb none
#!TESTS none
#!ROBOMERGE-SOURCE: CL 3664407 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3669177 on 2017/09/28 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] Reflection Captures support Lighting Scenarios without recapturing
* Reflection Captures are now part of the Map Build
* Modifying a capture in editor will display a preview, but game can only display built captures (black for unbuilt with screen message)
* Reflection Capture build data moved to the BuildData package
* Building lighting / reflection captures no longer dirties ULevels
* Sky lights which capture the scene now work correctly with Lighting Scenarios
* Lighting Scenarios must now be loaded for each time they are made visible (no switching back and forth while keeping both loaded)
#!rb Marcus.Wassmer
#!TESTS Paragon editor Monolith02
#!ROBOMERGE-SOURCE: CL 3662969 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3669124 on 2017/09/28 by Daniel.Lamb
Merging //Orion/Main/Engine/Shaders/Public/ShaderVersion.ush
to //Orion/Dev-General/Engine/Shaders/Public/ShaderVersion.ush
Fix cook in devgeneral
Bumped shader version to invalidate stale uniform buffer name.
#!rb none
#!TESTS none
#!fyi Daniel.Wright
Change 3667906 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] Fixed HandleLegacyMapBuildData not getting called on P maps loaded in the editor, which apparently was dropped in an integration error, causing all legacy maps (before the BuildData change) to lose their built lighting.
#!rb none
#!TESTS QAGame
#!ROBOMERGE-SOURCE: CL 3662475 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667899 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] Remove unused SM4 reflection capture cubemap
#!rb none
#!TESTS none
#!ROBOMERGE-SOURCE: CL 3662462 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667894 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy from Brian] SM4 fallback for reflection captures.
#!rb none
#!TESTS none
#!ROBOMERGE-SOURCE: CL 3662449 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667859 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy from Brian] Removed old rasterized deferred reflection env path.
Removed reflection compute shader. Replaced with PS. Small perf gain.
#!rb none
#!TESTS none
#!ROBOMERGE-SOURCE: CL 3662439 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667852 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] Fixed missing include
#!rb none
#!TESTS none
#!ROBOMERGE-SOURCE: CL 3662396 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667807 on 2017/09/27 by Daniel.Lamb
Tencent DLC can now remap the plugin content to the game root directory.
#!rb Ben.Marsh
#!test Paragon regioncl dlc build, preflight ps4, win64 standard build + test
Change 3667753 on 2017/09/27 by Clayton.Langford
Adding automated test for capturing fx perf for lane minions. Also adding a Gauntlet node to run the test nightly, added test map to the cook list, updated the SpawnMinion phase to use new minion assets, and fixed an issue with the spawn timer.
#!RB Ben.Salem, Adric.Worley
#!tests PIE, local synced client/server, and Gauntlet's RunAutomaticTest.bat
Change 3667408 on 2017/09/27 by Jordan.Walker
Optimization to bakedNormal layer blend on Low end material quality
-uses simple multiply and add normal map blend
Change 3667388 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] Moved Volumetric Lightmap textures out of FScene and into FPrecomputedVolumetricLightmapData so their lifetime can match the MapBuildData. This allows tossing the source BulkData in game after RHI texture creation even though switching lighting scenarios does Release/InitializeRenderingResources multiple times.
#!rb none
#!TESTS QAGame on console
#!ROBOMERGE-SOURCE: CL 3662389 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667383 on 2017/09/27 by robomerge
#!ROBOMERGE-AUTHOR: daniel.wright
[Copy] CPU interpolation of Volumetric Lightmaps for the mobile renderer. They use a scene cache based on interpolation position, since the precomputed lighting buffer for movable objects is recreated every frame.
#!rb none
#!TESTS QAGame
#!ROBOMERGE-SOURCE: CL 3662383 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3667265 on 2017/09/27 by Daniel.Lamb
Fixed crash in the editor caused by trying to build hlods with StaticMeshComponents that don't have a static mesh assigned.
#!rb Uriel.Doyon
#!test Editor building hlods
Change 3667159 on 2017/09/27 by Mieszko.Zielinski
Added simple logging to BT loading allowing us to identify missing BB keys #!Orion
#!test golden path
#!rb Lukasz.Furman
Change 3665944 on 2017/09/26 by Dan.Hertzka
Fix PS4 compile
#!rb none
#!tests compile PS4
Change 3665590 on 2017/09/26 by Daniel.Lamb
Fix for DLC cooking everything when it should only cook the DLC.
#!rb None
#!test None
Change 3665569 on 2017/09/26 by Dan.Hertzka
New status effect feed for the new HUD:
- Now placed in the mid-upper-left side of the HUD
- Biggest difference from before is that there are now names associated with each effect
- If we can determine the ability it came from (and it has a name/icon), we show that as well. This doesn't work for any card effects yet.
Cleaning:
- Deleted all of the old buff widget classes & codepaths
- Removed redundant properties from StatusEffectDisplayInfo
- Added BuffStatusTags and DebuffStatusTags to AttributeViewItem. This allows us to associate the effects that modify an attribute with the attribute itself. Allowed me to remove about half of the entries in StatusEffectDisplayData
Also:
- Consolidated all of the events on FActiveGameplayEffect into a single struct. Since we don't want to allow non-const access to any other part of the active effect, each of these has an individual getter on the ASC. This is pretty obnoxious when you want to bind multiple events. There is now a getter for the event set of an active effect on the ASC. This allows more convenient non-const native access to these events
- Added an event for when the inhibition of an effect changes. This is important for UI to know when an effect is no longer relevant (despite never being actually removed)
@todo: Add support for showing the item ability names that are responsible for effects (note that this will be the ability, not the name of the item. The name of the item will be a lot harder.)
#!rb Don.Eubanks
#!tests OrionEntry PIE with some cards and hero abilities
#!QAReview - Please keep an eye on this to make sure it works as expected during normal play. I wasn't sure how to test stack counts - not sure which status effects actually support that. They should show up though if any do. Please also verify that this still works/appears correctly during the tutorial.
#!lockdown Billy.Rivers
Change 3665555 on 2017/09/26 by Daniel.Lamb
AudioStreaming mpsc queue fix up.
#!rb Andrew.Grant
#!test Compile paragon client / editor.
Change 3665517 on 2017/09/26 by Daniel.Lamb
Suspect fix for OR-44619
#!jira OR-44619
#!test Paragon editor compile
#!rb Trivial
Change 3664346 on 2017/09/26 by Jon.Lietz
- making LifeSpanCallback inside UDecalComponent virtual so sub classes can override how Decals handle fade out.
- Adding in UOrionDecalComponent to replace the use of UDecalComponent, for the most part they are the same the only thing we needed to change was the LifeSpanCallback() if the Owner is a AOrionGameplayCueNotify_Actor we dont call Super::LifeSpanCallback() that would result in the GC getting destroyed but now call GameplayCueFinishedCallback() so our gameplay cues will recycle as desired.
- Updated all GC's data to use the new decal class
- removed the option to place UDecalComponent as BP comp and only left our new UOrionDecalComponent
#!rb Dave.Ratti
#!reivew Dave.Ratti
#!tests used characters that had decal comps in the GC and they recylce as expected.
#!QAReview please check the effected abilities and cues, I tested and everything looks fine to me up a deeper check is needed.
Change 3664099 on 2017/09/26 by Jon.Lietz
OR-44510
- bringing over engine fixes for the Enum Redirector from Dev-Framework
#!rb none
#!tests compiles and warnings are gone
Change 3663019 on 2017/09/25 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Gil: fixed race condition in the PipelineStateCache
#!rb Daniel.Lamb
#!test paragon ps4 with higher repro modified build
#!lockdown Andrew.Grant
#!jira OR-44441
#!ROBOMERGE-SOURCE: CL 3659463 in //Orion/Release-43/... via CL 3661481 via CL 3661489 via CL 3661497
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3663014 on 2017/09/25 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Quick fix to remove a redundant copy of the PipelineStateInitializer (saves 16MB over a 10min game) incase we need to submit a build before the more extensive changes are ready.
#!tests ran locally
#!rb [at daniel.lamb] [at arne.schober]
#!ROBOMERGE-SOURCE: CL 3658907 in //Orion/Release-43/... via CL 3661480 via CL 3661488 via CL 3661494
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3663004 on 2017/09/25 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Changed dev check for extra commandline args from /data to /temp0
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3658497 in //Orion/Release-43/... via CL 3661478 via CL 3661486 via CL 3661492
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3662999 on 2017/09/25 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Gauntlet - Fixed DateTime used for folders not being set
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3658390 in //Orion/Release-43/... via CL 3661477 via CL 3661485 via CL 3661491
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3662255 on 2017/09/25 by Sam.Zamani
#!tencent
- fix for link error due to missing define of static OnNetworkCheatDetected delegate
#!rb none
#!tests none
Change 3662073 on 2017/09/25 by Sam.Zamani
#!tencent
Added new global network delegates callback FNetworkCheatDetected for when cheating is detected on a server
Possible options
#!jira TEN-275 TSS detect and expose punish user callbacks
KickClient - User should be booted from the current game session via disconnect
KickMatch - User received info about being punished (eg. ban type etc)
PunishInfo - User received info about being punished (eg. ban type etc)
#!rb rob.cannaday
#!tests none
Change 3659487 on 2017/09/22 by Josh.Markiewicz
#!Orion - removed NUTFortnite* files because they have been moved into Fortnite specific plugin
#!review-3659190 john.barrett, ryan.gerleve
Change 3659485 on 2017/09/22 by Josh.Markiewicz
#!UE4 - removed OSSUtils dependencies from NUTUnrealEngine4 since the refactor moved dependencies into game specific plugins
#!fyi john.barrett, ryan.gerleve
Change 3659184 on 2017/09/22 by Josh.Markiewicz
#!UE4 - delete EpicSurvey module
#!fyi justin.sargent, nick.darnell
#!rb none
Change 3658697 on 2017/09/22 by Ryan.Gerleve
Fixes for server-side Tencent anti-cheat library integration:
-Fix DLL loading to properly call tss_sdk_load and use the correct paths on Linux as well as Windows
-Add getter for the TssSdkAntiInterf object
-Enable server anti-cheat in editor builds
#!codereview sam.zamani
#!rb none
#!tests enabled Tencent OSS, built & ran server
Change 3658200 on 2017/09/22 by Graeme.Thornton
Manual copy of CL 3587584 from Dev-Core
Logging improvements for pak signature check failures
- Added "PakCorrupt" console command which corrupts the master signature table
- Added some extra log information about which block failed
- Re-hash the master signature table and to make sure that it hasn't changed since startup
- Moved the ensure around so that some extra logging messages can make it out before the ensure is hit
- Added PAK_SIGNATURE_CHECK_FAILS_ARE_FATAL to IPlatformFilePak.h so we have a single place to make signature check failures fatal again
#!rb none
#!tests been in Dev-Core and Main for a while now. Compile tests in Dev-General
Change 3657970 on 2017/09/22 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added Trim() delegate hook to PipelineStateCache so accumulated memory is freed on a hard level transition.
We've noticed this memory growing considerably overtime and while it may reach a ceiling eventually it was still increasing after 60m of Paragon. This should at least reset it upon the end of each game,
[at marcus.wassmer,] [at arne.schober] #!rb none
#!tests cycled 6-7 levels of Paragon
#!ROBOMERGE-SOURCE: CL 3657965 in //Orion/Release-43/... via CL 3657967 via CL 3657968 via CL 3657969
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657914 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Non-shipping: test and dev builds now check testkit's data drive for a commandline override. Not sure if this will work as-is, but shouldn't cause any harm if not and it needs to go into a pkg build for testing...
#!tests stepped through in non-pkg build
#!rb none
#!ROBOMERGE-SOURCE: CL 3657910 in //Orion/Release-43/... via CL 3657911 via CL 3657912 via CL 3657913
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657906 on 2017/09/21 by Andrew.Grant
Improved some logging
#!tests used locally
#!rb none
Change 3657891 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Formalized idea of multiple test passes in Gauntlet. Current pass and total passes are provided to nodes incase they want to perform custom processing
Fixed issue with -dev mode on PS4 not updating symbols
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3657887 in //Orion/Release-43/... via CL 3657888 via CL 3657889 via CL 3657890
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657867 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Re-locked network CL to 3652780
#!tests #!rb na
#!ROBOMERGE-SOURCE: CL 3657221 in //Orion/Release-43/... via CL 3657359 via CL 3657366 via CL 3657374
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657857 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Removing start up dialog that warns of non-optional instructions - OR-44444
#!RB:arciel.rekman
#!Tests:Compiled
[CODEREVIEW] daniel.lamb, andrew.grant, arciel.rekman, benjamin.crocker, matthew.coleman, joe.graf
#!ROBOMERGE-SOURCE: CL 3657058 in //Orion/Release-43/... via CL 3657355 via CL 3657364 via CL 3657370
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657852 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for case-insensitivity causing title.json not to be staged
#!rb daniel.lamb, bob.tellez
#!tests ran packaging script, verified contents match v42
#!ROBOMERGE-SOURCE: CL 3657054 in //Orion/Release-43/... via CL 3657353 via CL 3657363 via CL 3657369
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657831 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Removing popcnt version of CountBits to repair pre-Nehalem processors
We can worry about a more permanent solution after we get this live.
#!RB:none
#!Tests: Compiled
[CODEREVIEW] daniel.lamb, andrew.grant, ben.marsh, marcus.wassmer
#!ROBOMERGE-SOURCE: CL 3656206 in //Orion/Release-43/... via CL 3657325 via CL 3657333 via CL 3657338
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657824 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
[CODEREVIEW] andrew.grant, jason.bestimt, jeff.williams
Unresolved conflicts. andrew.grant, please merge this change by hand.
//ROBOMERGE_ORION_Release_43_1/Engine/Binaries/Win64/UnrealCEFSubProcess.exe
//ROBOMERGE_ORION_Release_43_1/Engine/Binaries/Win64/UnrealCEFSubProcess.pdb
--------------------------------------
Built new UnrealCEFSubprocess client
Changed OrionBuild.xml to build the shipping version of the above.
The first should definitely fix out store issue. It's not clear to me if the latter will because if this artifact was being staged I'd expect to see UnrealCEFSubProcess-Win64-Development etc be distributed and it's not. This suggests to me we just stage what's in P4 and not the result of this step, but further investigationds will be needed to vet this.
[at justin.sargent,[at benjamin.crocker,[at wes.fudala]]]
#!ROBOMERGE-SOURCE: CL 3656066 in //Orion/Release-43/... via CL 3657319 via CL 3657332 via CL 3657337
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3657488 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: anton.migulko
LIGHTING AND assets update
#!ROBOMERGE-SOURCE: CL 3656996 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3656388 on 2017/09/21 by Laurent.Delayen
Added default GetAxisVector static function to EAxisOption
#!rb none
#!FYI thomas.sarkanen
#!tests lane minions test map
Change 3656387 on 2017/09/21 by Laurent.Delayen
Initialize FAnimInstanceProxy with default constructor.
#!rb none
#!fyi lina.halper, thomas.sarkanen
#!tests lane minion test map
Change 3656003 on 2017/09/21 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Locked net version to 3650578 for patching
benjamin.crocker
#!tests #!rb na
#!ROBOMERGE-SOURCE: CL 3655998 in //Orion/Release-43/... via CL 3656000 via CL 3656001 via CL 3656002
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3654403 on 2017/09/20 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Merge DevCore -> Orion Release-43 CL 3641450
UE4 - Switch PS4 over to atomics that issue a full memory barrier. UE4 assumes atomics have memory barriers.
#!rb Daniel.Lamb
#!test Compile
#!lockdown Andrew.Grant
#!ROBOMERGE-SOURCE: CL 3654399 in //Orion/Release-43/... via CL 3654400 via CL 3654401 via CL 3654402
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3654356 on 2017/09/20 by Andrew.Grant
Merging 3653658 from Dev-Rendering
#!tests compiled, ran editor
#!rb marcus.wassmer
Change 3653914 on 2017/09/20 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Bumped script version to reprocess autosdks (installs debugger for CoreFileAPI access).
#!rb none
#!tests ran locally
#!ROBOMERGE-SOURCE: CL 3653910 in //Orion/Release-43.1/... via CL 3653911 via CL 3653912
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3652495 on 2017/09/19 by Andrew.Grant
Editgration of VR fix in 3643776 from Release-4.17
#!tests #!rb na
Change 3652244 on 2017/09/19 by Sam.Zamani
#!tencent
Disable launcher checks if "-q" is on command line indicating QQ id when launched via TCLS launcher
Added "-q" to whitelist of command line params for shipping builds
Skip update URI routing to Epic Launcher for tencent builds since they use TCLS launcher
#!rb rob.cannaday
#!tests none
Change 3651493 on 2017/09/19 by buildmachine
BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_x86_64-unknown-linux-gnu libs.
#!rb none
#!lockdown Nick.Penwarden
#!tests none
Change 3651490 on 2017/09/19 by buildmachine
BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_aarch64-unknown-linux-gnueabi libs.
#!rb none
#!lockdown Nick.Penwarden
#!tests none
Change 3651489 on 2017/09/19 by buildmachine
BuildPhysX.Automation: Deploying PhysX & APEX & NvCloth Linux_arm-unknown-linux-gnueabihf libs.
#!rb none
#!lockdown Nick.Penwarden
#!tests none
Change 3651445 on 2017/09/19 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Integrating CL 3651124 from Release-4.17 to remove -ffast-math flag
#!RB:none
#!Tests:none
[CODEREVIEW] dmitry.rekman, daniel.lamb, andrew.grant
#!ROBOMERGE-SOURCE: CL 3651441 in //Orion/Release-43/... via CL 3651443 via CL 3651444
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3651059 on 2017/09/19 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Removed code to archive load-order during tests
#!tests #!rb na
#!ROBOMERGE-SOURCE: CL 3651056 in //Orion/Release-43/... via CL 3651057 via CL 3651058
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3651043 on 2017/09/19 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Changed error parsing from tests to put cause ahead of file info
#!tests ran self-test
#!rb none
#!ROBOMERGE-SOURCE: CL 3651034 in //Orion/Release-43/... via CL 3651041 via CL 3651042
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3649683 on 2017/09/18 by Andrew.Grant
Bulk-merge of oustanding changes in Main to DG
#!tests #!rb na
Change 3649345 on 2017/09/18 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Integrate fix for eidtor crash when switching between low and high scaleability options.
#!rb Olaf.Piesche
#!test Paragon editor
#!ROBOMERGE-SOURCE: CL 3643174 in //Orion/Release-43/... via CL 3643214 via CL 3643240
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3649335 on 2017/09/18 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - OR-44257 - Fix for hair not working
It is valuable to use the proper variable when doing Boolean logic :/ Cut-n-paste error from bit-packing conversion.
#!RB:daniel.lamb
#!Tests:Re-tested in cooked build
[CODEREVIEW] daniel.lamb
#!ROBOMERGE-SOURCE: CL 3643061 in //Orion/Release-43/... via CL 3643211 via CL 3643237
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3649231 on 2017/09/18 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Bit packing skel mesh cache variable and then reverting sound cue changes to avoid collision with AaronM
#!RB:none
#!Tests:none
[CODEREVIEW] daniel.lamb, aaron.mcleran, marc.audy
#!ROBOMERGE-SOURCE: CL 3642166 in //Orion/Release-43/... via CL 3643199 via CL 3643231
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3649211 on 2017/09/18 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Fix 'lowest' shadow settings (simple forward rendering)
#!rb arne.schober
[FYI] Daniel.Wright
#!tests monolith
#!ROBOMERGE-SOURCE: CL 3642119 in //Orion/Release-43/... via CL 3643196 via CL 3643228
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3649141 on 2017/09/18 by Stephan.Jiang
Tagging files that shouldn't be merged up to Main, upon next engine merge should accept source.
-- These are hacks for ability videos to work before we have the new Sequencer updates
-- CLs contain those hacks: 3649066, 3649049, 3648752, 3648748
#!fyi Andrew.Grant, Max.Preussner
#!rb none
#!test compile
Change 3649087 on 2017/09/18 by Thomas.Ross
Merging //UE4/Dev-Framework/ CL#!3646428 using //UE4/Dev-Framework_to_//Orion/Dev-General
#!rb none
#!tests none
#!fyi Andrew.Grant,Jeff.Williams,dan.oconnor
Change 3649066 on 2017/09/18 by Max.Preussner
WmfMedia: Fix for multiple media sessions being created when repeatedly opening media sources
#!rb stephan.jiang
#!rnx
#!tests none
Change 3649049 on 2017/09/18 by Max.Preussner
Media: Changed audio sample rate warning to verbose log
#!fyi stephan.jiang
#!rb none
#!rnx
#!tests none
Change 3648752 on 2017/09/18 by Max.Preussner
WmfMedia: Fixed race condition in media sound wave
#!rb none
#!rnx
#!tests none
Change 3648748 on 2017/09/18 by Max.Preussner
WmfMedia: Hack for preventing flicker between media source switching
Do not merge to Dev-Main!
#!rb stephan.jiang
#!rnx
#!tests none
Change 3648596 on 2017/09/18 by Bart.Hawthorne
More Oodle batch file fixes - cleaned up the changelist description and removed the changelist parameter since the branch parameter is enough.
Change 3648575 on 2017/09/18 by Sam.Zamani
#!tencent
Fix for missing library calls when initializing TSS anti cheat SDK
#!rb none
#!tests compiles win64 server
Change 3648556 on 2017/09/18 by Jeff.Williams
Null Merging //Orion/Main to Dev-General (//Orion/Dev-General) @3642084
Clearing up robomerge
#!rb none
#!tests none
Change 3648533 on 2017/09/18 by clayton.langford
Unblocking RM.
#!CodeReview: clayton.langford, jason.bestimt, andrew.grant, jeff.williams
Unresolved conflicts. clayton.langford, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Gauntlet.Automation.csproj
--------------------------------------
Backing out 3641723 for now due to nontrivial merge conflicts. Did not back out change to DefaultEditor.ini since this change is unrelated to the conflict and essential for existing tests to run properly.
#!RB Adric.Worley
#!tests none
#!ROBOMERGE-SOURCE: CL 3642084 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3648219 on 2017/09/18 by Sam.Zamani
#!tencent
fixed Tencent module thirdparty dll runtime dependency paths
fixed DLLHandle not being set
#!rb none
#!tests none
Change 3647998 on 2017/09/18 by Clayton.Langford
Reorganized CardFXTests to the appropriate location for this branch as part of the merge associated with 3645763.
#!tests compiled
#!rb Adric.Worley
Change 3647817 on 2017/09/18 by James.Golding
Mirror fix from 4.18 release stream (CL 3647799) to Dev-General
Fix out-of-bounds access of cloth mapping data during CPU skinning
#!rb benn.gallagher
#!jira UE-49628
#!fyi benn.gallagher
#!tests convert RiftMage to static mesh
Change 3647749 on 2017/09/18 by Benn.Gallagher
Small change to windows memory intrinsics in PhysX to avoid VS compilation bug on windows causing restrict parameters to bleed the restrict into the calling scope.
This caused matrix transposition to fail after the data was copied in using memcpy
BuildPhysX.Automation: Deploying PhysX & APEX Win64 libs.
#!rb none
#!tests Editor reimport of clothing assets
Change 3646242 on 2017/09/15 by Tyler.Cole
Revert shared engine LocalMCP scripts.
Change 3646153 on 2017/09/15 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Caching off HasActiveClothingAssets for SkeletalMeshes and ShouldApplyInteriorVolumes for SoundCues in non editor builds
#!RB:daniel.lamb
#!Tests: Ran cooked Client
[CODEREVIEW] daniel.lamb, Benn.Gallagher, lina.halper, marc.audy
#!ROBOMERGE-SOURCE: CL 3641934 in //Orion/Release-43/... via CL 3641936 via CL 3641940
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3646125 on 2017/09/15 by robomerge
#!ROBOMERGE-AUTHOR: arne.schober
OR - Sorting Primitive Components to increase I-Cache utilization and to keep the branch prediction alive during initviews.
#!RB Marcus.Wassmer
#!tests automated performance tests
#!ROBOMERGE-SOURCE: CL 3641873 in //Orion/Release-43/... via CL 3641882 via CL 3641886
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3645861 on 2017/09/15 by clayton.langford
#!CodeReview: clayton.langford, jason.bestimt, andrew.grant, jeff.williams
Still need to move OrionTest.CardFXTest.cs to the correct location and generate the proper includes in the GauntletExtra csproj file. Will do this in a separate CL as advised by JeffW.
Unresolved conflicts. clayton.langford, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Gauntlet.Automation.csproj
--------------------------------------
Adding more card types to the automated tests. We now support all cards with an active ability and valid target types. This brings us to a current total of 40 cards for now, but new cards that fit the criteria will automatically be included once they are added.
To execute the tests, either run a gauntlet test for CardFXTests or enterthe following command from the frontend: Automation RunTests OrionPerf.Effects.Cards
Known issues: The following cards do not properly confirm their abilities and so produce invalid results: StaticTrap, LampLighter, ProtectiveSentry, and AstralLeap. Disabling these cards is nontrivial as the tests are automatically generated.
#!tests ran local client/server, preflighted
#!rb Ben.Salem
#!rnx
[FYI] Sean.Tobin, Hunter.Kent, Edward.King
#!ROBOMERGE-SOURCE: CL 3641723 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3644062 on 2017/09/14 by Aaron.McLeran
#!jira OR-44171 Some looping sounds are extremely loud
#!rb Ethan.Geller
#!tests run paragon, run near water river, don't observe looping sound being very loud
Change 3643901 on 2017/09/14 by Laurent.Delayen
Integrated CL #!3604725 to fix bug with opening state machines from anim graph.
#!rb none
#!tests fixes bug
#!FYI lina.halper
Change 3643641 on 2017/09/14 by Rob.Cannaday
Fix unreachable code detected
#!rb rob.cannaday
#!tests Win64 compile
Change 3643326 on 2017/09/14 by Sam.Zamani
#!tencent
- temp disabled TerSafe.dll loading until staging issues can be resolved
#!rb none
#!tests none
Change 3643039 on 2017/09/14 by Sam.Zamani
#!tencent
- temp disabled TSS on servers due to linux build issues
#!rb none
#!tests none
Change 3642438 on 2017/09/13 by Rob.Cannaday
Handle new analytics param types (number, string, etc)
Stub implementation of FAnalyticsProviderETTencent DefaultAttrs
#!rb rob.cannaday
#!tests Win64 vs AI match
Change 3641655 on 2017/09/13 by Sam.Zamani
#!tencent
WIP added tss_sdk.dll (server) and TerSafe.dll (client)
JIRA TEN-262 StoryAnti-Cheat SDK - TerSafe.dll 3rd party module for client
JIRA TEN-197 StoryTSS SDK 3rd party module for dedicated servers
#!rb none
#!tests PC run with RegionCN.pak enabling tencent mode
Change 3641559 on 2017/09/13 by Bart.Hawthorne
Fix up oodle dictionary generation scripts
#!rb none
#!jira none
Change 3641550 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: john.nielson
Added more temp logging in attempt to find OrionOR-43600: Master Bug: Some hero ability FXs are missing in v43
#!rb: none
#!test: Pie
#!ROBOMERGE-SOURCE: CL 3641546 in //Orion/Release-43/... via CL 3641548 via CL 3641549
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3641393 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
We'd lilke to start using this on PS4 but the cost is very high (link-times are 60-90m!) so it needs to be something that is enabled selectively on the farm. I think we're going to consider it analogous to "Arxan" where it's on by default for Nightly/Standard builds in Release branches, but can be flipped off for quick turnarounds and is off in dev.
Currently LTCG/LTO on PS4 is driven purely by bEnableLTOPerfBuilds / bEnableLTODevBuilds project settings. This change allows it to be specified as a command line UBT argument, and also preps the ground for targets to specify their own PGO file which would be used when LTO is enabled
- Changed UBT option from -NoLTCG to -LTCG (I didn't see how it's possible to turn this on, since the default is false and adding the option also turns it false)
- Added PGOInput option to TargetRules and passed through to compile environment
- Updated UEBuildPS4.cs to that bAllowLTCG=true overrides settings in the ini file about what targets to have LTCG on for
- Updated PS4 toolchain to use both LTO and PGO depending on what was set
#!tests soaked locally, preflighted
#!rb codereviewed
FWIW here are before/after results for LTCG.
Orion Performance report from 3 games and 1441.51 seconds
MVP: 2.83 (Min: 2.05, Max: 3.22)
HPM: 4.29 (Min: 4.24, Max: 4.37)
AvgH: 2.77ms (Min: 2.08ms, Max: 4.16ms)
GT: 12.88ms (Min: 12.68ms, Max: 13.25ms)
RT: 13.71ms (Min: 13.48ms, Max: 14.08ms)
GPU: 14.39ms (Min: 14.21ms, Max: 14.50ms)
Orion Performance report from 3 games and 1440.49 seconds
MVP: 1.42 (Min: 1.02, Max: 1.94)
HPM: 3.25 (Min: 2.75, Max: 3.62)
AvgH: 2.08ms (Min: 2.08ms, Max: 2.08ms)
GT: 11.93ms (Min: 11.64ms, Max: 12.47ms)
RT: 12.80ms (Min: 12.54ms, Max: 13.24ms)
GPU: 14.10ms (Min: 13.91ms, Max: 14.27ms)
#!ROBOMERGE-SOURCE: CL 3641352 in //Orion/Release-43/... via CL 3641354 via CL 3641357
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3640885 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Limited warning to once every 10 secs.
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3640377 in //Orion/Release-43/... via CL 3640380
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3640875 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed shipping config issue
#!tests #!rb na
#!ROBOMERGE-SOURCE: CL 3640328 in //Orion/Release-43/... via CL 3640362
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3640870 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: mieszko.zielinski
Fixing CIS builds #!Orion
The builds were failing because InitAsyncThread is being run as part of UHT, which doesn't usually include -DebugFX parameter, and warnings reported by UHT during reflection code generation are treated as errors.
[CODEREVIEW] John.Nielson
#!rb none
#!test compilation
#!ROBOMERGE-SOURCE: CL 3640310 in //Orion/Release-43/... via CL 3640361
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3640783 on 2017/09/13 by robomerge
#!ROBOMERGE-AUTHOR: john.nielson
More temporary logging for finding the missing FX issue.
#!rb: none
#!Test: Pie
#!ROBOMERGE-SOURCE: CL 3640089 in //Orion/Release-43/... via CL 3640352
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3639910 on 2017/09/12 by Rob.Cannaday
Build fix for AnalyticsETTencent
#!rb rob.cannaday
#!tests compile Win64 DebugGame Editor
Change 3639565 on 2017/09/12 by Laurent.Delayen
SkeletalMeshComponent::InitAnim doesn't call Update and Eval anymore, but instead initializes transforms with cheaper ref pose, and relies on regular ticking for updating the pose, so we can take advantage of visibility related optimizations. Also RecalcRequiredBones uses correct predicted LOD level instead of defaulting to 0.
#!rb lina.halper
#!FYI lina.halper
#!tests minion test lane, dropping meshes in a level, testing masterpose component at runtime.
Change 3639228 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Tools - Added ability to postmortem a PS4 devkit for last crash
#!rb run locally
#!tests none
#!ROBOMERGE-SOURCE: CL 3639226 in //Orion/Release-43/... via CL 3639227
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3639075 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: jeff.williams
Specifically requesting 'all' configuration, to avoid missing manifest in jar.
#!ROBOMERGE-SOURCE: CL 3639072 in //Orion/Release-43/... via CL 3639074
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3639022 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: dan.hertzka
Remove dependency on the editor style set in the WidgetReflector
- Fixes a crash when trying to use the reflector in a client cooked build
- Also updated Focusable column name to shared var
#!rb none
#!tests Widget Reflected in a cooked build
#!ROBOMERGE-SOURCE: CL 3639020 in //Orion/Release-43/... via CL 3639021
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638984 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: john.nielson
Added some more temp logging to get to the bottom of the missing FX issue. OR-43600 : Master Bug: Some hero ability FXs are missing in v43
#!rb: none
#!test: Pie
#!ROBOMERGE-SOURCE: CL 3638982 in //Orion/Release-43/... via CL 3638983
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638696 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Swapped problematic ensure to LogError, made draft obey notimeouts.
#!tests compiled
#!rb none
[at daniel.lamb]
#!ROBOMERGE-SOURCE: CL 3638693 in //Orion/Release-43/... via CL 3638695
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638644 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Third time's the charm
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3638620 in //Orion/Release-43/... via CL 3638636
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638628 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Removed ensure in a PS4 friendly way
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3638550 in //Orion/Release-43/... via CL 3638551
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638583 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Removed ensure to get a cook
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3638476 in //Orion/Release-43/... via CL 3638478
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3638545 on 2017/09/12 by Bart.Hawthorne
Add analytics for oodle compression percentages
#!rb ryan.gerleve, wes.hunt
#!tests ran a 2 person game with dedicated server and verified analytics were reported
#!jira OR-26386
Change 3638172 on 2017/09/12 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Duplicate 3620803
Partial Fix for Dither Opacity Mask
#!rb none
#!tests PC monolith
#!ROBOMERGE-SOURCE: CL 3637837 in //Orion/Release-43/... via CL 3637838
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3637643 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: jeff.williams
Fixing version stream to Main
#!ROBOMERGE-SOURCE: CL 3637373 in //Orion/Release-43/... via CL 3637466
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3637524 on 2017/09/11 by Andrew.Grant
Merging EngineTest and latest Gauntlet using //Orion/Dev-General/_To_//UE4/Orion-Stating
#!tests build Win64 editor, ran tests locally
#!rb none
Change 3637402 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Gauntlet - Restored logging of runoptions when not verbose
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3636838 in //Orion/Release-43/... via CL 3636840
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3637357 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Made 'none' test specify Attended
#!rb Daniel.Lamb
#!tests compiled
#!ROBOMERGE-SOURCE: CL 3636811 in //Orion/Release-43/... via CL 3636812
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3637305 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: john.nielson
Added temporary debug logging cmd line option for finding Jira OrionOR-43600
#!RB: none
#!Test: Pie
[at David.Ratti]
#!ROBOMERGE-SOURCE: CL 3636730 in //Orion/Release-43/... via CL 3636732
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3636549 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Integrating CL 3633162 from Dev-Rendering to guard around potential issues
#!RB:none
#!Tests:none
[CODEREVIEW] uriel.doyon
#!ROBOMERGE-SOURCE: CL 3636541 in //Orion/Release-43/... via CL 3636542
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3636507 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: dan.hertzka
[OR-44013] & [OR-43780] - Hamstrung the old long-form rich text formatting functions to remove unsupported formatting immediately. Will be cleaning up API and usages in DG.
Also:
- Added distance formatting type for simple ability description values (will automatically append u to the value)
- SimpleAbility description values can now go up to two decimal places
Engine:
- Modified FGameplayTag::ImportTextItem to account for redirects when establishing TagName
#!rb Matt.Schembari
#!tests PIE OrionEntry & FrontEndScene - various bug repros
#!ROBOMERGE-SOURCE: CL 3636370 in //Orion/Release-43/... via CL 3636412
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3636372 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Implement fast particle pool memory.
Default is 2mb, automatically cleans up oldest used pool slots.
Estimated 1/4 time for STAT_PARTALLOC.
#!rb Jason.Bestimt
#!test paragon ps4 cooked
#!ROBOMERGE-SOURCE: CL 3636045 in //Orion/Release-43/... via CL 3636048
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3636319 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed issue with fatal error message not being shown in reports.
Fixed issue where some cancelled tests reported as succeeded
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3635951 in //Orion/Release-43/... via CL 3635955
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3636264 on 2017/09/11 by robomerge
#!ROBOMERGE-AUTHOR: jason.bestimt
#!ORION_43 - Integrating CL 3609090 && 3621546 from Dev-Rendering to help with Render Thread mip map streaming performance
#!RB:none
#!Tests: Ran client cooked build
[CODEREVIEW] daniel.lamb, andrew.grant, Uriel.Doyon
[QAREVIEW]
#!ROBOMERGE-SOURCE: CL 3635817 in //Orion/Release-43/... via CL 3635819
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3635288 on 2017/09/10 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added CleanDevices command and task that runs nightly in Dev-Gen to remove old builds from devices
Fixed missing - in SoloSmoke args that were causing trailing params to be lost
#!tests preflighted, ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3635286 in //Orion/Release-43/... via CL 3635287
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3635145 on 2017/09/09 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Bumped script version to pick up SDK change for patch packages
#!rb none
#!tests none
#!ROBOMERGE-SOURCE: CL 3635143 in //Orion/Release-43/... via CL 3635144
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3635097 on 2017/09/09 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added cleardevices option to Gauntlet that removes all devices after running.
Added to Orion build scripts
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3635090 in //Orion/Release-43/... via CL 3635091
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3634985 on 2017/09/09 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Cleaned up some logging around device failures
Attempt to handle "Too Many Connections" error at a lower level
Added removeall command to PS4DevkitUtil (not yet used)
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3634983 in //Orion/Release-43/... via CL 3634984
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3634897 on 2017/09/09 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Checking in change to timeouts to test theory
#!tests ran test locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3634895 in //Orion/Release-43/... via CL 3634896
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3634765 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Scrape another .05ms out of GPU particle simulation.
#!rb none
#!tests ps4 monolith
#!ROBOMERGE-SOURCE: CL 3634763 in //Orion/Release-43/... via CL 3634764
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3634422 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for Gauntlet shutdown issue on builders
Fix for BP editing crash from Dev-Framework
#!tests ran locally
#!rb none!
#!ROBOMERGE-SOURCE: CL 3634313 in //Orion/Release-43/... via CL 3634314
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3634139 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Gauntlet - provision devices on demand. Cuts down logging and reduces issue of kits having too many TM connections when tests on different branches are running
#!tests ran locally with single and file-based devices
#!rb none
#!ROBOMERGE-SOURCE: CL 3633919 in //Orion/Release-43/... via CL 3633921
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3633799 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: laurent.delayen
Fixed crash when on Turrets, when changing their MeshUpdate mode to Montages only.
#!rb none
#!tests monolith02 turrets
[CODEREVIEW] lina.halper
#!ROBOMERGE-SOURCE: CL 3633600 in //Orion/Release-43/... via CL 3633601
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3633647 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Possible fix for OR-43926 from Arne
#!tests ran locally, observed no ensures or negative side-effects in UI or HUD
#!rb none
#!ROBOMERGE-SOURCE: CL 3633278 in //Orion/Release-43/... via CL 3633281
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3633637 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Upped timeout for editorbased tests
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3633271 in //Orion/Release-43/... via CL 3633274
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3632565 on 2017/09/08 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Removed some test code...
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3632563 in //Orion/Release-43/... via CL 3632564
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3632385 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
More improvements to device handling.
Specifically PS4 targets now force-kill other connection if they're not in use, and fixed an edge case where devices could be left in TM and cause problems.
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3632383 in //Orion/Release-43/... via CL 3632384
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3632177 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: thomas.ross
Merging CL#!3631888 from //UE4/Dev-Framework to //Orion/Dev-Release-43
#!rb none
#!test local commandlet
#!ROBOMERGE-SOURCE: CL 3632175 in //Orion/Release-43/... via CL 3632176
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3632131 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Fix a bug with new local vector-field only project setting
#!rb none
#!tests ps4 monolith
#!ROBOMERGE-SOURCE: CL 3632127 in //Orion/Release-43/... via CL 3632130
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3632034 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed issue where problem devices were reset each attempt
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3632029 in //Orion/Release-43/... via CL 3632032
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3631812 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
More improvements to device management in Gauntlet
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3631602 in //Orion/Release-43/... via CL 3631604
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3631787 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: laurent.delayen
Fix for OR-42922, reset TickRecords when doing 'OnlyTickMontagesWhenNotRendered' since the montage will appear to have jumped when regular ticking resumes.
#!rb none
[CODEREVIEW] martin.wilson
#!test bot game
#!ROBOMERGE-SOURCE: CL 3631532 in //Orion/Release-43/... via CL 3631536
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3631251 on 2017/09/07 by Andrew.Grant
Additional device selection improvements
#!tests #!rb na
Change 3630861 on 2017/09/07 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Imrpoved device selection to randomize pick order, exclude devices that failed on the last round, and provide more info as to the constraints of the pool
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3630857 in //Orion/Release-43/... via CL 3630858
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3630620 on 2017/09/07 by Laurent.Delayen
RigidBody anim node: Maintain Bone Velocity transfers through LOD changes. Refactored bone velocity transfer to be queued one frame, while we let final animation pose through. Added support for transferring angular velocity. If update rate is less than 30FPS, break down update into several iterations (max 4). This is to support URO, which can update animations at 15 FPS for minions.
#!rb Ori.Cohen
#!codereview benn.gallagher
#!tests lane minions test map
Change 3629990 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Fix for gpu hang on ps4.
#!rb Marcus.Wassmer
#!test Paragon cooked ps4
#!jira OR-43835
#!ROBOMERGE-SOURCE: CL 3629890 in //Orion/Release-43/... via CL 3629891
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629980 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Moved some missed code to FDebug::HasAsserted()
#!tests na
#!rb none
#!ROBOMERGE-SOURCE: CL 3629794 in //Orion/Release-43/... via CL 3629795
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629975 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Project optimization to only support local vector fields.
separate 'stat emitters' into 'stat emitters' and 'stat emittersrt' to separate gamethread cost from renderthread cost.
#!rb olaf.piesche
#!tests monolith ps4/pc
#!ROBOMERGE-SOURCE: CL 3629782 in //Orion/Release-43/... via CL 3629783
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629917 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: marcus.wassmer
Fix for sizebyspeed on ps4
#!rb Simon.Tovey
#!tests pc
#!ROBOMERGE-SOURCE: CL 3629660 in //Orion/Release-43/... via CL 3629661
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629620 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Always get the rest result from nodes, this is where UnrealTestNode parses logs for errors
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3629618 in //Orion/Release-43/... via CL 3629619
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629554 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Restored screenshot support to gauntlet (now driven externally)
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3629551 in //Orion/Release-43/... via CL 3629553
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629495 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: don.eubanks
Stat panel will only show stat changes or improvements that come from Item sources (cards / gems)
#!rb dan.hertzka
#!tests Compile DebugGame Editor Win64 / Shipping Client PS4 / PIE
[RN] Card Shop now only considers Attribute Point effects and Card effects when calculating the bonuses for stats on the stats panel. No more giant HP/MP regen numbers when standing in base!
#!ROBOMERGE-SOURCE: CL 3629334 in //Orion/Release-43/... via CL 3629337
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629468 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Replaced global access to bHasAsserted to FDebug::HasAsserted() and added FDebug::IsEnsuring()
Changed GameThreadWaitForTask so it won't timeout if an ensure is ocurring on a different thread.
#!tests ran locally
#!rb none
[at marcus.wassmer]
#!ROBOMERGE-SOURCE: CL 3629246 in //Orion/Release-43/... via CL 3629296
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629410 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
[CODEREVIEW] andrew.grant, jason.bestimt, jeff.williams
Unresolved conflicts. andrew.grant, please merge this change by hand.
//ROBOMERGE_ORION_Main/Engine/Plugins/Runtime/PacketHandlers/CompressionComponents/Oodle/Source/ThirdParty/NotForLicensees/Oodle/Oodle.Build.cs
--------------------------------------
Fix for generating project files
#!tests GPF
#!rb none
#!ROBOMERGE-SOURCE: CL 3629088 in //Orion/Release-43/... via CL 3629174
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629369 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Ignore pak signing if fileopenorder is specified (temp? workaround for deadlock in Orion tests)
#!rb none
#!tests verified signing is disabled and game gets to main menu with -fileopenlog
[at graeme.thornton]
#!ROBOMERGE-SOURCE: CL 3628814 in //Orion/Release-43/... via CL 3628816
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3629254 on 2017/09/06 by Laurent.Delayen
URO: ensure we don't skip more frames than desired when switching LODs.
#!rb lina.halper
#!codereview martin.wilson, benn.gallagher
#!test lane minions test map
Change 3629191 on 2017/09/06 by Laurent.Delayen
Added CopyAndAssign to BoneContainer. To help transfer Cached Poses through LOD transitions.
#!rb lina.halper
#!codereview martin.wilson
#!test lane minions test map
Change 3629130 on 2017/09/06 by Laurent.Delayen
AnimInstance: tweaked debug display of AnimSequences, and added DeltaTime to AnimInstance debug.
#!rb none
#!tests lane minion test map
Change 3628300 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed exception that could occur during tests if all devices were in use
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3628298 in //Orion/Release-43/... via CL 3628299
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627915 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Undoing Oodle check for the time being
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3627913 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627875 on 2017/09/06 by Jason.Bestimt
#!ORION_DG - Merge of CL#! 3626655 from Dev-Framework to fix assetimportdata loading (allowing for re-import of curve tables)
#!RB:none
#!Tests:none
#!CodeReview: andrew.grant, alex.gillies, colin.fogle, benjamin.crocker
#!ROBOMERGE: MAIN, 43
Change 3627694 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Improved warnings
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3627691 in //Orion/Release-43/... via CL 3627693
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627642 on 2017/09/06 by robomerge
#!ROBOMERGE-AUTHOR: david.ratti
More logging for OR-43892 and OR-43779
#!rb none
#!tests compile
#!ROBOMERGE-SOURCE: CL 3627640 in //Orion/Release-43/... via CL 3627641
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627247 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Removed check that turns out to be bogus
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3627245 in //Orion/Release-43/... via CL 3627246
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627240 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added compile-time check for presence of Oodle files to prevent future hard-to-debug-runtime-failures
#!tests compiled OrionClient
[at daniel.lamb] #!rb none
#!ROBOMERGE-SOURCE: CL 3627237 in //Orion/Release-43/... via CL 3627239
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3627211 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added ensure for OR-43777
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3627209 in //Orion/Release-43/... via CL 3627210
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3626839 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added wait to PS4DevkitUtil before trying to postmortem crashdump
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3626833 in //Orion/Release-43/... via CL 3626837
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3626755 on 2017/09/05 by Rob.Cannaday
Merge //Orion/Release-Tencent to //Orion/Dev-General
Some features need to be re-implemented as noted by #!ifdef TODO_TENCENT
TODO: Figure out how to have OnlineSubsystemTencent be Enabled by default in OrionGame.uproject, some calls to IOnlineSubsystem::IsLoaded(TENCENT_SUBSYSTEM) will return true even though the OSS is disabled by config because the module itself is loaded
#!rb sam.zamani
#!lockdown andrew.grant
#!tests Win64 vs AI match, QA smoke test
#!fyi sam.zamani
Change 3626285 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed BaseDir argument not being correctly applied in tests
Added check for LowLevelFatalError to log parser. Don't consider RequestExit's clean if StaticShutdownAfterError was called
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3626280 in //Orion/Release-43/... via CL 3626284
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3626221 on 2017/09/05 by robomerge
#!ROBOMERGE-AUTHOR: david.ratti
Queue OnRep_ReplicatedMovement for simulated proxy OrionChars for a single end of frame call. This is to address when clients can't keep up with server's send rate and end up processing multiple packets / actor bunches in a single frame. Rather than handling multiple bunches with movement updates and calling OnRep_ReplicatedMovement every time, this will call the OnRep once at the end of the frame.
Can be toggled off via UOrionRuntimeOptions::bQueueSimulatedProxyOnRepMovement
#!rb none
#!tests verified OnRep_Movement doesn't show up in profiler when client running at < 60hz
[at Laurent.Delayen] [FYI] [at Andrew.Grant]
#!ROBOMERGE-SOURCE: CL 3626215 in //Orion/Release-43/... via CL 3626219
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3625925 on 2017/09/05 by Laurent.Delayen
If using URO with bShouldUseLodMap and we're missing higher LOD numbers into our LOD Map, use highest available settings (below our current LOD number). Instead of defaulting to high quality (eval every frame), which is certainly not what we want.
#!rb benn.gallagher
#!codereview martin.wilson, lina.halper
#!tests lane minion map
Change 3624051 on 2017/09/02 by Andrew.Grant
Fixed issue with test params not being set.
Went through OrionBuild.xml and added explicit configs arguments to tests where missing. Also set order of args to tests as "-platform -config" to improve readability.
#!tests preflighted
#!rb none
#!review-3624052 @ben.salem
Change 3623907 on 2017/09/02 by Andrew.Grant
Fixed usesyncedbuild option being broken in Gauntlet
#!codereview @daniel.lamb
#!tests compiled
#!rb none
Change 3623906 on 2017/09/02 by David.Ratti
Fix some issues where GameplayCues played on an OrionBaseActor wouldn't be properly translated for skin overrides
#!rb none
#!test future wukong pie
Change 3623766 on 2017/09/01 by Daniel.Wright
[Copy] Volume materials on static meshes now voxelize the mesh's Object space bounding box
#!rb none
#!Tests PC QAGame
Change 3623518 on 2017/09/01 by Don.Eubanks
Fix for Shipping Client PS4
#!rb none
#!tests Compile Shipping Client PS4
#!fyi daniel.lamb andrew.grant
Change 3623515 on 2017/09/01 by Daniel.Wright
[Copy] Volume materials applied to static meshes operate on the object's bounding sphere
#!rb none
#!TESTS QAGame PC
Change 3623503 on 2017/09/01 by Daniel.Wright
[Copy] Fixed ObjectRadius in Volume domain materials
#!rb none
#!TESTS none
Change 3623102 on 2017/09/01 by Marcus.Wassmer
Add GT (gamethread), AT (async task), RT (renderthread) to stuff in 'stat particles' to make things easier to understand
#!rb none
#!tests monolith on PS4
#!fyi olaf.piesche,tim.elek
Change 3623096 on 2017/09/01 by Marcus.Wassmer
checkslow -> check to find issues with ILC
#!rb none
#!tests ran monolith on ps4
Change 3622744 on 2017/09/01 by Laurent.Delayen
RigidBody anim node: Added option 'bTransferBoneVelocities' to transfer bone velocities to simulation upon start, so ragdolls transition seamlessly from kinematic (animation) to simulation. (just linear velocity for now).
Added 'bFreezeIncomingPoseOnStart' option to freeze incoming pose and stop ticking/evaluating rest of the AnimGraph. Also prevents animation animating non simulated bodies.
Take gravity from movement component if present, to inherit custom gravity scaling.
Use proper animation deltatime, rather than world deltatime, as that would cause the simulation to run in slow motion when URO was used.
If LOD enables new bodies, they are now initialized during simulation.
Only write transforms from simulated bodies. Stop considering children of simulated bodies, since SkelControl system handles that by default.
Cached MeshBoneIndexToBodyIndex on initialization to avoid linear search during InitializeBoneTransforms, on LOD change.
Added AnimStats for PreUpdate, Update and Eval.
#!rb ori.cohen
#!codereview ori.cohen, lina.halper, benn.ghallager
#!tests lane minion test map
Change 3622743 on 2017/09/01 by Laurent.Delayen
Added UpdateComponentPose_AnyThread and EvaluateComponentPose_AnyThread to AnimNode_SkeletalControlBase to allow overriding these in child classes.
#!rb lina.halper
#!tests lane minion test map
Change 3622742 on 2017/09/01 by Laurent.Delayen
'showdebug animation' now shows current LOD, various counters to know if Update/Eval/Cachebones/Init was called. Also URO settings.
Renamed DisplayDebugCustom to DisplayDebugInstance.
#!rb lina.halper
#!tests lane minion test map
Change 3622738 on 2017/09/01 by Laurent.Delayen
Removed unused USkinnedMeshComponent::AnimUpdateRateSetParams
#!rb lina.halper
#!tests lane minion test map
Change 3622666 on 2017/09/01 by Jian.Ru
Fix incorrect grouping when FHierarchicalStaticMeshSceneProxy::GetDynamicMeshElements
#!jira UE-48972, OR-43455
#!rb Chris.Bunner
#!tests editor
Change 3622579 on 2017/09/01 by Andrew.Grant
Fixed shutdown issues with some tests being detected as errors
Simplied and cleanup some things in state management of tests.
#!tests ShortSOloGame test locally
#!rb none
Change 3622322 on 2017/09/01 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for OR-40366 from v43
#!tests compiled
#!rb Aaron.McLeran
#!ROBOMERGE-SOURCE: CL 3620707 in //Orion/Release-42.4/... via CL 3621208 via CL 3622295
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3621054 on 2017/08/31 by Andrew.Grant
Merging Gauntlet refactor from //Orion/Dev-General/_To_//UE4/Orion-Stating
#!tests preflighted
#!rb none
Change 3620755 on 2017/08/31 by Daniel.Lamb
Added a pooling system for FDynamicSkelMeshObjectDataGPUSkin. Doesn't add a lot of memory over head. Cleans out every few allocations.
#!rb Jason.Bestimt
#!test Cooked paragon ps4
Change 3620541 on 2017/08/31 by Ben.Salem
Tag all nightly gauntlet report emails with [NightlyAuto] for easier sorting.
#!rb none
#!tests compiled.
Change 3620443 on 2017/08/31 by Mieszko.Zielinski
Extended EQSTestingPawn with an option to specify its nav agent properties to affect navigation-related EQS tests/features #!UE4
#!rb none
#!test golden path
Change 3620428 on 2017/08/31 by Aaron.McLeran
#!jira OR-40366 Bringing fix from FN and Anim-Phys to Dev-General
#!rb Ethan.Geller
#!tests there is no internal repro. Rare crash online. Confirmed fixed in FN crash reports.
Change 3620411 on 2017/08/31 by Mieszko.Zielinski
Fix to removal of simuli sources from the AISense_Sight #!UE4
Made sure given source gets removed from ObservedTargets.
#!rb none
#!test golden path
Change 3620343 on 2017/08/31 by Ben.Salem
Add hitch reporting into FX tests. Layout is definitely WIP but we want the data in those reports to iterate on.
#!rb clayton.langford
#!tests ran shallow and normal FX tests, generated hitches to display.
Change 3620050 on 2017/08/31 by Luke.Thatcher
[ORION] [PS4] [^] Merging compile fix in UEBuildPS4.cs (CL 3619919) from //UE4/Dev-Console/... to //Orion/Dev-General/...
- USE_DEFRAG_ALLOCATOR was not always defined in all cases.
#!rb Daniel.Lamb
#!tests none
Change 3619836 on 2017/08/31 by Andrew.Grant
Merging //UE4/Main @ 3613306 (largely 4.17 fixes and an update from rendering team)
#!tests preflighted, ran locally
#!rb none
Change 3618597 on 2017/08/30 by Dan.Hertzka
Fixed Additive UI materials not being affected by the widget opacity
- We needed to multiply the sampled color by the alpha of the vertex color
Also added fade in anim for scoreboard when showing after the endgame cinematic
#!rb Nick.Darnell
#!tests Widget alpha affects additive materials
Change 3618441 on 2017/08/30 by Laurent.Delayen
Added AnimInstance::DisplayDebugCustom, to display custom debug info before AnimGraph display.
#!rb lina.halper
#!tests lane minions
Change 3618404 on 2017/08/30 by Paul.Moore
- Update to new MMS client API from Fortnite.
- Add MMS API plugin.
#!rb none
#!tests matchmaking, v2 MMS matchmaking, draft lobby.
#!lockdown andrew.grant
Change 3618167 on 2017/08/30 by Marcus.Wassmer
Fix fog on PS4, also volume texture clears.
#!rb luke.thatcher
#!fyi Jordan.Walker
#!tests ran monolith on ps4
Change 3617911 on 2017/08/30 by Andrew.Grant
Fix for OR-43401, lighting remaining unbuilt
#!tests ran cook, verified that lighting for bp components is now correctly found.
#!rb marc.audy
Change 3617765 on 2017/08/30 by Andrew.Grant
Fix for lighting always being unbuilt on some blueprints
#!tests cooked data and verified BP components have the correct transform and receive cached lighting data
#!rb marc.audy, bp-team
Change 3617757 on 2017/08/30 by Laurent.Delayen
clang fix
#!rb none
#!tests none
Change 3617700 on 2017/08/30 by Laurent.Delayen
Added PreEvalSkelControl_AnyThread to SkelControlBase, to allow capture of incoming pose before SkelControl is evaluated.
#!rb lina.halper
#!tests lane minions map
Change 3617695 on 2017/08/30 by Laurent.Delayen
Added Empty() to FBaseCompactPose and FCSPose, to release allocated arrays.
#!rb lina.halper
#!tests test lane minions map
Change 3616757 on 2017/08/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for OR-43459 from Laurent
#!tests na
#!rb Lina.Halper, Andrew.Grant
#!ROBOMERGE-SOURCE: CL 3615643 in //Orion/Release-42.3/... via CL 3615645 via CL 3615649
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3616745 on 2017/08/29 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Locked net version to 3609966 in anticipation of patch
#!rb #!tests na
#!ROBOMERGE-SOURCE: CL 3615584 in //Orion/Release-42.3/... via CL 3615592 via CL 3615597
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3616551 on 2017/08/29 by Daniel.Lamb
Fix memory leak in paragon.
#!rb Andrew.Grant
#!test Paragon ps4
Change 3613700 on 2017/08/28 by Andrew.Grant
Integrated r.Shadow.UnbuiltPreviewInGame support from Dev-Rendering (reduces cost of rendering unbuilt lighting). Set to off for Orion
Renabled r.Cache.UpdatePrimsTaskEnabled
#!tests ran locally
#!rb none
Change 3613694 on 2017/08/28 by Andrew.Grant
Added -teamsize argument to Orion none test.
#!tests ran None test :)
#!rb none
Change 3613638 on 2017/08/28 by Ben.Salem
Hide threshold colors for Perf tests on Thread times when in development. Add hyperlinks to description videos for Shallow tests. Support for linking new videos on other tests is already in for when videos are created.
#!rb clayton.langford
#!tests Ran shallow and deep test for multiple characters.
Change 3612731 on 2017/08/28 by Chris.Bunner
[DUPLICATE] CL 3572421 - Edge case in lazyobjptr assignment failing for landscape collision components which causes grass data to be flushed during cook.
#!rb
#!fyi Robert Manuszewski, Andrew.Grant, Daniel.Lamb
#!tests Cooking/running simple scene with grass foliage
#!jira UE-48698, OR-42612
Change 3612695 on 2017/08/28 by Andrew.Grant
Added longtimeouts option that uses TimeoutMultiplierForUnoptimizedBuilds value for net connections to solve issue where nomcp can timeout due to non-async loading
Moved Gauntlet-in-shipping determination to OrionClient.Target.cs so it can be enabled with other things.
#!tests ran NoneTest with -nomcp
#!rb none
Change 3612002 on 2017/08/27 by Andrew.Grant
Fix for crash seen during nightly tests
#!tests baseline perf didn't crast 3/3
#!rb none
Change 3611980 on 2017/08/27 by Andrew.Grant
PS4DevkitUtil post-mortem improvements to logging
#!tests run ShortSoloGame
#!rb none
Change 3611758 on 2017/08/26 by Andrew.Grant
Fix for warning
#!tests #!rb na
Change 3611737 on 2017/08/26 by Andrew.Grant
Merging optimizations 3517039, 3545241, & 3545347 from Dev-Rendering
3517039 -
GitHub #!2655: Optimization for shadow map resolution selection for spot lights
* Use the radius of the inscribed sphere at the cone end as the spot light's screen radius
Note: slight drop of shadow quality of spot lights may occur when they are far away from the camera. This is intended, since before this optimization they tend to be always rendered with the maximum shadow map resolution (2048), which is very costly
3545241 -
Fixed spotlight whole scene shadows using a radius 2x too long
3545347 -
Fixed shadow occlusion culling broken by shadowmap caching change. FProjectedShadowKey is now computed correctly for whole scene shadows and SDCM_StaticPrimitivesOnly shadowmaps will fall back to the query for a SDCM_MovablePrimitivesOnly, since the static primitives shadowmap's query is not issued every frame.
#!rb none
#!tests compiled
Change 3611718 on 2017/08/26 by andrew.grant
#!CodeReview: andrew.grant, jason.bestimt, jeff.williams
Unresolved conflicts. andrew.grant, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Unreal/Gauntlet.UnrealLogParser.cs
--------------------------------------
Improved parsing of callstacks and errors in test logs
Added unit test for error parsing
#!tests ran locally, unit tests
#!rb none
#!ROBOMERGE-SOURCE: CL 3611709 in //Orion/Release-42.3/... via CL 3611710 via CL 3611711
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3611704 on 2017/08/26 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Test fixes - addresses issue with memory report failing
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3611695 in //Orion/Release-42.3/... via CL 3611702 via CL 3611703
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3611683 on 2017/08/26 by Andrew.Grant
Upgraded PS4 SDK to 4.508.111
#!tests SoloGames locally
#!rb none
Change 3611466 on 2017/08/25 by Andrew.Grant
Changed none test to use monolith02 by default
#!tests compiled
#!rb none
Change 3611167 on 2017/08/25 by Laurent.Delayen
Reset UpdateCounter in AnimProxy when initialized, to force an update if rendered without updated.
#!rb none
#!tests lane minions
#!codereview martin.wilson
Change 3610850 on 2017/08/25 by dan.hertzka
Unclog Robomerge
#!rb none
#!tests none
Change 3610325 on 2017/08/25 by Andrew.Grant
Compile fix for PS4
#!tests compiled
#!rb none
Change 3610018 on 2017/08/25 by Laurent.Delayen
UE-48827, OR-43346, OR-43345 Fix for SingleNodeInstances not getting ticked properly. Due to them not increasing UpdateCounter, and forcing a tick even if we're doing parallel ticking later.
#!rb lina.halper
#!tests venus ult on minion lane test map
Change 3609967 on 2017/08/25 by Daniel.Lamb
Merging using //Fortnite/Main/->//Orion/Dev-General/
Bringing across several changes to the texture streamer and budgets from fortnite so as to reduce our garlic memory pool slack for PS4.
CL 3526904 [FORTNITE] [PS4] [!] Fix blurry textures in shipping.
- The texture streaming manager has additional logic in shipping builds which caused textures to never stream back in once they had streamed out.
- Added an extra flag to reset mip bias values when texture memory budget is increased.
#!rb Uriel.Doyon
#!jira FORT-45385
#!jira FORT-47739
CL 3505459 [FORTNITE] [PS4] [~] Memory savings for Fortnite on PS4.
- Disabled LLM. This was increasing the libc heap from 32MB to 100MB in builds with STATs enabled.
- Reduced Libc heap size from 32MB to 8MB. The game only uses 2-3 MB of this heap space, so additional memory is wasted.
- Removed "RESERVED_MEMORY_SIZE" allocation. This is just wasting 1 MB unnecessarily. There is already ~1.5 MB of unallocated direct memory due to alignment requirements of the garlic/onion heaps.
#!jira FORT-45229
#!rb Ben.Woodhouse
CL 3564368
LLM Changes
Summary:
LLM now has 3 stat pages, stat LLM for engine allocations, LLMPlatform for OS allocations and LLMOverhead.
Changes where LLM hooks into the various allocation functions and pools.
Added more LLM tracking scopes.
Changed the way LLM gets its internal memory.
Writing stats out to csv
Fixed a few bugs with the tracker code
Details:
* re-enabled LLM by default in Dev builds for XB1 and PS4
* Reduced overhead to 30MB when LLM is defined in but disabled (this will be removed in a future update)
* track allocations made from the defrag pool (PS4)
* track non-drfrag pool garlic allocations (PS4)
* track allocations made from PS4 malloc
* combined the RHI and Malloc trackers into the Default tracker
* changed stat groups to LLM, LLMPlatform and LLMOverhead
* OnLowLevelAlloc how takes a default tag to be used is no tag scope has been set
* XMemAlloc now uses AllocationType if no LLM scope has been set
* renamed VirtualMap to LLMMap
* added global function pointers for LLMMap to use to allocate memory. Using malloc to allocate memory meant that we couldn't track that memory using LLM. LLM now uses the lowest level OS function depending on the platform. If the platform doesn't set these fiunction pointers LLM will be disabled.
* support for tracking allocations that move in memory (for the PS4 defrag allocator)
* support for tracking explicit memory without pausing the tracker
* LLMCsvWriter for writing out the LLM stats periodically. Enable with -LLMCSV command line arg
* fixed check in FNameToTag. It was checking the wrong value when verifying the name index
* show a warning on screen if LLM has been enabled without debug memory enabled (on consoles)
* fixed program size tracking
* fixed bug with tag scopes being tracked in all trackers. This caused allocations to be counted in stats that were not shown in the tracker. The tracker is now passed in to the scope.
* optimised FLLMScopedTag so that it only calls the singleton once when disabled (instead of 3 times)
* fixed problem in the Pause feature. It now only pauses the specified tracker instead of all of them.
* fixed compile error when LLM_ALLOW_ASSETS_TAGS is disabled
* changed default alloc size for LLMMap to 16K
* Added lots more LLM scopes renamed some of the existing ones
* made FMemBlock::Allocators private and added accessor functions, which include LLM tracking.
* fixed LLM alignment tracking in CustomVirtualAlloc
* implemented LLM on XB1 so that it properly tracks D3D12Allocations
* added tracking to allocations that come from FMemBlock (excluding the defrag heap alloc) and removed tracking from Growable allocator
* tracking of render targets
* fixed LLM pool total column value.
#!rb luke.thatcher
CL 3565905
[ATHENA] [PS4] [^] Merging new PS4 memory system from //UE4/Dev-Console/... to //Fortnite/Dev-Athena/...
3458941 - Initial submission of new PS4 memory allocator.
3485054 - Finer grain scope locks. Prevents contention stalls between threads where possible.
3498440 - Flexible and framebuffer memory fallbacks
3515704 - Add stats to new PS4 memory system.
UEBuildPS4.cpp changes reimplemented as edit. Cannot merge as Dev-Athena's copy is too old to merge properly.
#!rb Ben.Woodhouse
CL 3580934
[FORTNITE] [PS4] [+] Support different garlic and onion heap sizes in the old memory system for base and neo.
- Neo has 512 MB more direct memory than a base kit.
- Increased the garlic heap size by 416 MB on Neo, and CPU heap by 96 MB.
#!rb Marcus.Wassmer
#!jira FORT-50206
CL 3590180
[FORTNITE] [PS4] [!] Allow fallback to MallocBinned2 when Libc mspace heaps are exhausted.
- Since FORCE_ANSI_ALLOCATOR is not defined, the Libc heap only had 8 MB.
- Platform and 3rd party libraries that make libc malloc/free calls could potentially crash OOM if we exhausted the pool.
- Now, when no memory is left in the mspace heaps, we call into the base allocator (MallocBinned2). This has the added benefit that we should get proper OOM crashes/logs if a libc allocation fails.
#!jira FORT-49700
#!rb Aaron.McLeran
CL 3593920
[FORTNITE] [PS4] [!] Fix 4 GB CPU memory limit in old PS4 memory system.
- Incorrect bitmask usage was truncating the available memory value to 32 bits.
- Also includes some minor refactoring to make parts more readable.
- Removed PS4_USE_FLEXIBLE_FIRST. Dead code that doesn't compile.
#!rb Jonathan.Fitzpatrick
#!jira FORT-50918
CL 3597577
[FORTNITE] [PS4] [~] Modified the way memory is allocated on Playstation to make more memory available to the CPU.
- Previously the amount of texture memory wasnÆt fixed due to the way the defrag memory is allocated on PS4. This meant we had to have a significant amount of slack.
- With the new configuration, we have a guaranteed texture memory pool, so the slack can be significantly smaller, meaning we can give more memory to the CPU, which is where most of our memory pressure is.
#!rb Stewart.Lynch
#!jira FORT-50825
#!jira FORT-49688
#!jira FORT-49695
#!jira FORT-50054
CL 3601951
[FORTNITE] [PS4] [!] Fix memory stats in the old PS4 memory system
- Physical memory stat now includes garlic and onion allocations. CPU OOMs will result in "AvailablePhysical" being close to 0.
- Added garlic, onion and defrag stats to the platform memory stats struct.
- Added fixed pool sizes to platform memory stats.
- Modified the Fortnite heartbeat logging to include extra details of PS4 fixed sized pools.
#!rb Stewart.Lynch
#!jira FORT-52910
#!test preflight with baseline performance memory report tests, local tests on neo
#!rb Luke.Thatcher
Change 3608480 on 2017/08/24 by Uriel.Doyon
Instanced static mesh lightmaps are now updated correctly after lighting scenario changes
#!jira UE-48522
#!tests Build lighting, loaded maps
#!rb michel.dupuis
Change 3608407 on 2017/08/24 by Andrew.Grant
Reintegrated ROlando's cloth optimizations
#!tests #!rb none
Change 3608349 on 2017/08/24 by Rolando.Caloca
O - Cloth vertex buffers no longer generate dummy vertices
#!rb Lina.Halper
#!fyi James.Golding
#!tests Check obj list memory with multiple characters, tested animations
Change 3607815 on 2017/08/24 by Laurent.Delayen
Fixed crash when displaying a two bone IK gizmo for a node that hadn't had a chance to evaluate or had a zero alpha.
https://jira.it.epicgames.net/browse/OR-43186
#!rb none
#!tests Price hand two bone IK
#!codereview lina.halper, thomas.sarkanen
Change 3607770 on 2017/08/24 by Andrew.Grant
Fixed bug with peak memory being missing in BaselinePerf tests and time being wrong
#!tests ran locally, updated parser test
#!rb none
Change 3607546 on 2017/08/24 by Jian.Ru
Add more control to chromatic aberration effect
#!jira UE-47138
#!rb Brian.Karis
#!tests editor
Change 3607270 on 2017/08/24 by Andrew.Grant
Mirroring 3605735 from FN to address bug with MIC deduplication
#!tests compiled
#!rb none
Change 3607082 on 2017/08/24 by Laurent.Delayen
Moved up Paragon functionality to cycle between targets with PageUp and PageDown for 'showdebug' commands.
List of targets is contextual (For example 'showdebug animation' will consider all visible actors with an AnimGraph).
Current debug Target is highlighted in a green bounding box.
Paragon now supports 'ShowDebugForReticleTargetToggle <class>' to have 'showdebug' for Actors aimed at by the player.
Paragon maintains feature to track AbilitySystemComponents across Targets. But Cycling is restricted to visible actors.
Target cycling in Paragon now works for all 'showdebug' tags, not just ASCs and Animation.
#!rb dave.ratti
#!tests lane minion test map, debugging individual minions
#!codereview jon.lietz
Change 3606772 on 2017/08/24 by David.Ratti
Spot edigrate CL 3606417 for accurate CurveTable memory tracking
#!rb none
#!tests none
[CL 3748735 by Andrew Grant in Main branch]
#lockdown Nick.Penwarden
#rb na
Change 3604978 on 2017/08/23 by Andrew.Grant
Fix for OR-42722 from 4.17 branch
#!tests compiled
#!rb max.chen
Change 3604960 on 2017/08/23 by Andrew.Grant
Proper fix for OR-43001, removed hack-around.
#!tests compiled
#!rb max.chen
Change 3604881 on 2017/08/23 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Changed LostReservation message in tests to info from warning.
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3604871 in //Orion/Release-42.3/... via CL 3604878 via CL 3604880
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3604566 on 2017/08/23 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Gauntlet - return -1 for a test if there's a fatal error. Removed network errors failing tests (should be down to test to determine)
Made SoakTest better able to detect failed drafts and incomplete matches
#!tests ran multiple soaks and SoloAllHeroes
#!rb none
#!ROBOMERGE-SOURCE: CL 3604560 in //Orion/Release-42.3/... via CL 3604563 via CL 3604565
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3604181 on 2017/08/23 by David.Ratti
Set ULandscapeHeightfieldCollisionComponent to be NetAddressable so that it can be replicated as a movement base without error.
OR-42615
#!rb none
#!tests pie
Change 3603647 on 2017/08/22 by Laurent.Delayen
AnimProxy: initialize Actor/Component transforms.
#!rb none
#!tests lane minion test map
Change 3603343 on 2017/08/22 by robomerge
#!ROBOMERGE-AUTHOR: don.eubanks
Added several more stats to the Card Shop stat panel.
+ Basic Attack Damage
+ Max Move Speed
+ Armor Penetration / Percent
+ Ability Penetration / Percent
Added utility function to AbilitySystemComponent to calculate an ability's value with additional Required/Ignore tags and Target tag container (functionality moved from AttributeView)
#!rb matt.schembari
#!tests Compile DebugGame Editor Win64 / Shipping Client PS4 / PIE
#!ROBOMERGE-SOURCE: CL 3603172 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3603121 on 2017/08/22 by Laurent.Delayen
Added FAnimationRuntime::LerpPosesPerBone
#!rb none
#!tests lane minions split body anims.
Change 3603010 on 2017/08/22 by Laurent.Delayen
Draw box around Actor being debugged by 'ShowDebug' command, to help identify what we're viewing.
#!rb none
#!tests lane minions
Change 3602574 on 2017/08/22 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fixed linux warning
#!tests compiled
#!rb none
#!ROBOMERGE-SOURCE: CL 3602571 in //Orion/Release-42.3/... via CL 3602572
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3602396 on 2017/08/22 by andrew.grant
#!CodeReview: andrew.grant, jason.bestimt, jeff.williams
Unresolved conflicts. andrew.grant, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Gauntlet.Automation.csproj
--------------------------------------
Updated Gauntlet log parser for new callstack format
Added offline and runtime Gauntlet tests to verify error generation and parsing
#!tests ran lots of tests locally
#!rb codereviewed
#!ROBOMERGE-SOURCE: CL 3601948 in //Orion/Release-42.3/... via CL 3601950
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3602373 on 2017/08/22 by Andrew.Grant
Fixed compile error
#!tests compiled
#!rb none
Change 3602321 on 2017/08/22 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
LogAssertFailedMessage
- Removed callstack dumping from LogAssertFailedMessage (now in StaticFailDebug)
- Moved script dumping inside GIsCritial check
StaticFailDebug
- Now dumps the callstack if supported for non-ensures. This results in PS4 (and other platforms) now displaying a callstack on a Fatal log.
- Removed log flush, was redundant
- Removed LowLevelOutputDebugStringf. If a platform needs this it can be done later in its error device
OutputMultiLineCallstack
- Renamed to FDebug::LogFormattedMessageWithCallstack and exposed in headers (calling locations have been updated to remove their extern declarations)
- No longer writes into the buffer to format it (!)
- LogName is now the first param. If NAME_None it writes using LowLevelOutputDebugString
- While writing out error information all callstack likes are prefixed with [Callstack]
Added brief documentation about the order of ops for ensures/asserts/fatal logs
#!tests ran lots of tests locally
#!rb codereviewed
#!ROBOMERGE-SOURCE: CL 3601943 in //Orion/Release-42.3/... via CL 3601944
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3602316 on 2017/08/22 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Changed various platform-specific implementations of ProgramCounterToHumanReadableString to return info in a canonical format of address module!func [file:line].
E.g.
0x00416A5F OrionClient.self!FEngineLoop::Tick() [D:\Epic\Orion\Release-Next\Engine\Source\Runtime\Launch\Private\LaunchEngineLoop.cpp:3295]
#!tests ran lots of tests locally
#!rb codereviewd
#!ROBOMERGE-SOURCE: CL 3601940 in //Orion/Release-42.3/... via CL 3601941
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3602311 on 2017/08/22 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Sony don't allow exception handling on PS4 so for sometime we've had an issue where crashes have no presence in logs*
This change adds postmortem analysis to PS4DevkitUtil. If the OS terminates the process then it process the minidump and writes the cause and the callstack to stdout. As a bonus PS4DevkitUtil can now display cause & callstacks from minidumps via "PS4DevkitUtil postmortem -dump=path\to\crash.orbisdmp"
(*if you're lucky the kit may have been setup correctly to submit dumps to crashreporter, it may have actually worked, and you may be able to find it).
#!tests run many times on Orion tests
#!rb CR
#!ROBOMERGE-SOURCE: CL 3601929 in //Orion/Release-42.3/... via CL 3601930
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3599823 on 2017/08/21 by Jian.Ru
Allow MaxCascades cvar be set to 0 (should perobject shadow be forced on?)
#!jira UE-48468,OR-42749
#!rb Daniel.Wright
#!tests editor
Change 3598765 on 2017/08/19 by Andrew.Grant
Disable regeneration of missing cubemap data in cooked build.
Need some way of handling this, but currently this breaks PS4 anytime someone makes a map change and doesn't build lighting...
#!review-3598766 @daniel.lamb
#!tests ran PS4 successfully
#!rb none
Change 3597800 on 2017/08/18 by Laurent.Delayen
Added FAnimationRuntime::LerpPoses. Blends two poses together, but first pose is also storing results. To save on copying poses when not necessary.
Removed individual use of ZERO_ANIMWEIGHT_THRESH, instead use FAnimWeight functions.
FAnimationRuntime weight functions use FAnimWeight for consistency. (IsFullWeight was different).
#!rb none
#!codereview martin.wilson, lina.halper
#!tests minion test lane map
Change 3597332 on 2017/08/18 by Laurent.Delayen
SkelMeshComponent LOD update only refreshes transforms when rendered.
If AnimGraph eval is done, make sure Graph has been updated at least once.
Fixes:
- Significance Manager setting MinLOD on non recently rendered minions, causing them to refresh bones.
- Minions calling eval with graph not updated due to having bUseRefPoseOnInitAnim set. It means it's possible to refresh bones on a graph that has never been updated, causing a crash.
#!rb martin.wilson, lina.halper
#!codereview martin.wilson, lina.halper
#!tests minions test lane map. placing skelmeshes in editor and making sure LOD update works as expected.
Change 3597042 on 2017/08/18 by Daniel.Lamb
Added onlinesubsystemmcp to the cooksettings blacklist.
#!rb Trivial
#!test none
Change 3596575 on 2017/08/18 by Shaun.Kime
Fixing nonunity build issues
#!rb none
#!tests compiled OrionGame with unity builds disabled
Change 3595475 on 2017/08/17 by Andrew.Grant
Fixed issue with PS4 asserts not being detected during test shutdown
#!tests ran locally
#!rb none
Change 3595415 on 2017/08/17 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Added check for network failure to tests
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3595412 in //Orion/Release-42.3/... via CL 3595414
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3594725 on 2017/08/17 by Ben.Salem
Add "Worst offenders" table and runtime to FX perf reports.
#!rb adric.worley
#!tests Ran a few FX Perf tests and generated reports.
Change 3594195 on 2017/08/17 by Shaun.Kime
Integration from Dev-Niagara to Dev-General. Note that this may cause assets to need to be recooked. Please be prepared for longer than normal cook times once syncing past this changelist.
#!rb none
#!tests preflight'ed change, QA ran multiple soak tests
Change 3594177 on 2017/08/17 by Andrew.Grant
Fixed issue that was causing exceptions not to be recognized
#!tests ran locally
#!rb none
Change 3594090 on 2017/08/17 by robomerge
#!ROBOMERGE-AUTHOR: laurent.delayen
Fix for mesh desyncing during online play.
https://jira.it.epicgames.net/browse/UE-45947
#!rb none
#!tests none
[CODEREVIEW] zak.middleton
#!ROBOMERGE-SOURCE: CL 3590625 in //Orion/Release-42.3/... via CL 3590626
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3594022 on 2017/08/17 by Laurent.Delayen
SkeletalMeshComponent::InitAnim
- Do not call RefreshBoneTransforms without calling TickAnim first. AnimGraph could get in a bad state.
- Do not call RefreshBoneTransforms if AnimInstance has not been initialized.
- Do not call RefreshBoneTransforms if bUseRefPoseOnInitAnim is set. Which it could if bForceReinit was false.
#!rb martin.wilson
#!tests minion test lane map.
Change 3593972 on 2017/08/17 by Chris.Bunner
Duplicating instanced static mesh fixes from Dev-Editor - 3502581, 3570934, 3593597.
#!rb None
#!tests Editor, -game, PC
#!jira UE-48521, OR-42612
Change 3590611 on 2017/08/16 by David.Ratti
Spot edigrate CL 3584203 to fix show collision crash in mono 2
#!rb none
#!tests compile
Change 3590452 on 2017/08/16 by Laurent.Delayen
Fix for mesh desyncing during online play.
https://jira.it.epicgames.net/browse/UE-45947
#!rb none
#!tests none
#!codereview zak.middleton
Change 3590378 on 2017/08/16 by Laurent.Delayen
Integrated CL #!3585145 from Main.
>>
Fix for https://jira.it.epicgames.net/browse/OR-42337 and https://jira.it.epicgames.net/browse/OR-42338
Don't call UpdateMontageSyncGroup() when doing EMeshComponentUpdateFlag::OnlyTickMontagesWhenNotRendered.
Fixed auto ranged iterator.
#!rb none
#!tests bot match with Twinblast
<<
Change 3590263 on 2017/08/16 by Matt.Kuhlenschmidt
Added the ability to remove vertex colors from static meshes from the content browser
#!rb none
#!tests none
#!fyi jordan.walker
Change 3590026 on 2017/08/16 by Jurre.deBaare
HLOD: When mesh has auto LOD generation disabled it prevents user from dragging meshes to make a cluster
#!fix changed the tooltip and error handling for cluster creation, if there is any valid mesh now it will show up as a warning
#!jira OR-41584
#!rb none
#!test have tested several 'error' meshes which would before prevent the user from creating a cluster,
Change 3588580 on 2017/08/15 by Laurent.Delayen
Fix for https://jira.it.epicgames.net/browse/OR-42755
#!rb none
#!tests bot match
Change 3588360 on 2017/08/15 by Charles.Anderson
Phat
- Fixed up the materials to turn off the Render Before DOF so that we can see what were doing in Phat again.
Change 3587983 on 2017/08/15 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Fixed up audio issue on the new dawn intro movie
#!jira OR-42144
#!rb Max.Preussner
#!test Paragon ps4
#!lockdown Andrew.Grant
#!ROBOMERGE-SOURCE: CL 3581466 in //Orion/Release-42.1/... via CL 3581468 via CL 3581469
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3587746 on 2017/08/15 by Daniel.Lamb
Build launcher now has option for custom test.
Dumps generated buildcooktest commandline to log when using -interactive for reference.
#!rb trivial
#!test BuildCookTest with and without test options.
Change 3587733 on 2017/08/15 by Daniel.Lamb
Reenabled binned 2 stats in not shipping.
#!rb Andrew.Grant
#!test Paragon editor.
Change 3587727 on 2017/08/15 by Daniel.Lamb
Removed all the checks to help track down Texture GC issue.
#!rb Trivial
#!test Paragon editor
Change 3584487 on 2017/08/14 by Laurent.Delayen
https://jira.it.epicgames.net/browse/OR-42754 making sure this is not firing because of false positives.
#!rb none
#!tests compiles
Change 3582074 on 2017/08/11 by Laurent.Delayen
TimeStretchCurve system for AnimMontages.
Allows adjusting playback time of montages in a non constant way. This optional curve allows the user to determine how animation frames are influenced by play back time scaling, instead of using a constant play rate scaling.
For example, with an attack animation, the strike could have zero influence (no play rate), and the recovery time could have 100% influence (most play rated).
This system is entirely optional and compatible with current Montage API. You still determine desired play back time via the Play Rate parameter. Based on desired playback time, if there is a curve named 'MontageTimeStretchCurve' then, it will use the curve to determine animation frames to play based on playback time and TimeStretchCurve. Otherwise, if no curve exists, it is done using the constant supplied PlayRate.
#!rb martin.wilson
#!codereview lina.halper, james.golding
#!tests wukong primary attacks
Change 3582063 on 2017/08/11 by Brian.Fasten
Removing Monolith02_LowTest from automated builds until errors can be cleared
#!codereview: daniel.lamb
#!rb - none
#!tests - none
Change 3581229 on 2017/08/10 by Lina.Halper
- Back out revision 21 from //Orion/Dev-General/Engine/Source/Runtime/SlateCore/Private/Rendering/DrawElements.cpp
- Comment out issue that causes crash in the draw box
#!jira: UE-48222
#!code review: Jurre.DeBaare, Nick.Darnell, Daniel.Lamb
#!rb: Jurre.DeBaare
#!tests: building HLOD as specified in the ticket, and anim blueprint graph
Change 3577839 on 2017/08/08 by Daniel.Lamb
Revert CL 3576931. To fix crash when generating HLOD in Monolith 2.
#!rb Andrew.Grant
#!test Rebuild HLOD paragon editor
#!fyi Lina.Halper
Change 3577684 on 2017/08/08 by Andrew.Grant
Removed ensure and merged proper fix for crash from UE4/Main (3572777)
#!tests #!rb none
Change 3577562 on 2017/08/08 by robomerge
#!ROBOMERGE-AUTHOR: laurent.delayen
Potential fix for https://jira.it.epicgames.net/browse/OR-42383
Clear NotifyQueue prior to ticking montages. Also dispatch events right away, since ticking ends here, and no rendering is happening. In the event TickPose() is called directly and Component does not get ticked.
#!rb lina.halper
[CODEREVIEW] lina.halper, martin.wilson
#!tests bot match
#!ROBOMERGE-SOURCE: CL 3577071 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3577358 on 2017/08/08 by Harrison.Moore
Updating Colorchecker
Change 3576931 on 2017/08/08 by Lina.Halper
Fix for missing arrowhead of the transition on state machine graph
#!rb: Nick.Darnell
#!tests: editor
Change 3576847 on 2017/08/08 by Jason.Bestimt
#!ORION_DG - OR-42361 - Removing assert that was causing crash report client to break (during shipping builds of Paragon due to directories that didn't exist)
#!RB: Guillaume.Abadie
#!Tests:none
Change 3576794 on 2017/08/08 by Laurent.Delayen
Removed call to DebugCanvas->Flush_GameThread(); to fix 'showdebug' commands not rendering anymore.
#!rb Matt.Kuhlenschmidt
#!codereview Matt.Kuhlenschmidt
#!tests Ghost in PIE, showdebug animation works.
Change 3576302 on 2017/08/08 by Jurre.deBaare
Fix for Materials get switched up while building HLODs in case the section order is different than the material order
#!rb none
#!tests Rebuild problematic clusters in Monolith2
#!fix materials remapping was done using the section index instead of material index in the hlod path (static mesh merge one was fine)
Change 3575221 on 2017/08/07 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for PS4 shipping
#!tests compiled PS4 shipping
#!rb none
#!ROBOMERGE-SOURCE: CL 3575112 in //Orion/Release-42.1/... via CL 3575114
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3575165 on 2017/08/07 by andrew.grant
#!CodeReview: andrew.grant, jason.bestimt, jeff.williams
Unresolved conflicts. andrew.grant, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/Engine/Source/Runtime/PS4/PS4RHI/Private/GnmManager.cpp
--------------------------------------
PS4 GPU time now shows correct values instead of vsync time.
#!tests Ran on PS4
#!rb Luke.Thatcher
#!ROBOMERGE-SOURCE: CL 3574821 in //Orion/Release-42.1/... via CL 3574823
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3574408 on 2017/08/06 by Ben.Salem
Switch nightly solo smoke/fx tests to have -unattended on their commandlines.
#!rb none
#!tests compiled.
Change 3574308 on 2017/08/06 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Include session time, MVP, and hitches on new health report
#!tests ran locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3574305 in //Orion/Release-42/... via CL 3574306 via CL 3574307
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3574217 on 2017/08/05 by Jeff.Williams
Fixing UAT compile error
#!review-3574218 @andrew.grant
#!rb na
#!tests na
Change 3574139 on 2017/08/05 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
[NULL MERGE]
Locked net version to 3571982 for future v42 patches
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3574136 in //Orion/Release-42/... via CL 3574137 via CL 3574138
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3574130 on 2017/08/05 by andrew.grant
#!CodeReview: andrew.grant, jason.bestimt, jeff.williams
Unresolved conflicts. andrew.grant, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/SelfTest/Gauntlet.SelfTest.LogParserTest.cs
--------------------------------------
Non-shipping Gauntlet changes -
Log parser cleanup that provides better access to log channel info, errors, warnings, and ensures
Updated BaselinePerf test to record number of units travelled. This should highlight tests where a bot gets blocked :(
#!tests ran locally on PS4
#!rb none
#!ROBOMERGE-SOURCE: CL 3574116 in //Orion/Release-42/... via CL 3574123 via CL 3574124
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3573197 on 2017/08/04 by andrew.grant
#!CodeReview: andrew.grant, jason.bestimt, jeff.williams
Unresolved conflicts. andrew.grant, please merge this change by hand.
//ROBOMERGE_ORION_Dev_General/Engine/Source/Programs/AutomationTool/NotForLicensees/Gauntlet/Gauntlet.Automation.csproj
--------------------------------------
Merging //Orion/Release-42.1 to Dev-ContentUpdate (//Orion/Dev-ContentUpdate)
#!tests #!rb none
#!ROBOMERGE-SOURCE: CL 3573179 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3573079 on 2017/08/04 by Andrew.Grant
Removed some code that was preventing Wacom from working
#!tests #!rb none
Change 3572790 on 2017/08/04 by Jurre.deBaare
Moving over fixes from 4.17 stream related to HLOD:
"UE-47360
Non Uniform baking of HLOD materials causes texture stretching
UE-47031
Generating a HLOD cluster with multiple actors that contain lods will not bake correctly"
#!rb none
#!tests none
Change 3572663 on 2017/08/04 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Gauntlet - copy elf files to temp dir and launch from there
#!tests ran gauntlet
#!rb none
#!ROBOMERGE-SOURCE: CL 3572657 in //Orion/Release-42/... via CL 3572659 via CL 3572662
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3572622 on 2017/08/04 by Jurre.deBaare
Moving over:
"Guard against zero sized boxes being sent to the slate batcher. This was exposed by the clipping changes since zero sized elements would have been previously clipped.
#!rb nick.darnell
#!jira UE-46919"
#!tests none
Change 3572428 on 2017/08/04 by Benn.Gallagher
Added per-axis inertia and parent dominance settings to physics assets
#!rb Thomas.Sarkanen
#!tests Shrapnel in editor and -game (seems to be the only character using old inertia scaler for rigid body node)
Change 3572142 on 2017/08/04 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Disabling r.Cache.UpdatePrimsTaskEnabled for PS4 due to lock-ups
#!tests none
#!rb none
#!ROBOMERGE-SOURCE: CL 3572139 in //Orion/Release-42/... via CL 3572140 via CL 3572141
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3572133 on 2017/08/04 by Andrew.Grant
Merging
//UE4/Main/Engine/Source/Runtime/SlateCore/Private/Input/HittestGrid.cpp
to //Orion/Dev-General/Engine/Source/Runtime/SlateCore/Private/Input/HittestGrid.cpp
#!tests #!rb none
Change 3572065 on 2017/08/03 by Andrew.Grant
Fixed bug in Gauntlet parsing of perf data for tests
Added perf-parsing test to SelfTest
#!tests ran self test
#!rb none
#!ROBOMERGE: 42.1
Change 3572033 on 2017/08/03 by Andrew.Grant
Merging //UE4/Main @ 3571062 through Orion-Staging
#!rb none
#!tests Engine QA pass
Change 3571262 on 2017/08/03 by Uriel.Doyon
StaticMeshComponent and LandscapeComponent now register AO material mask and sky occlusion texture in the texture streamer.
Changing the current lighting scenario now triggers an update of the texture streamer.
Added an option to the "liststreamingtextures" named UNKOWNREF allowing to inspect texture without references in the texture streamer.
#!rb none
#!tests played monolith2 on PS4 and loaded the map in the editor.
Change 3571247 on 2017/08/03 by robomerge
#!ROBOMERGE-AUTHOR: daniel.lamb
Integrate Dev-UI -> Release42
Reduced the sensitivity on the slow tick timer warning
#!rb Trivial
#!test Cooked paragon ps4
#!lockdown Andrew.Grant
#!ROBOMERGE-SOURCE: CL 3571239 in //Orion/Release-42/... via CL 3571244 via CL 3571246
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3570431 on 2017/08/03 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Removed a change that was inadvertendly included in a larger fix and seems to be having problems on windows server.
#!tests ran windows server locally
#!rb none
#!ROBOMERGE-SOURCE: CL 3570428 in //Orion/Release-42/... via CL 3570429 via CL 3570430
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3570343 on 2017/08/03 by Jurre.deBaare
HLOD: opening a level with HLOD defaults to forcing HLOD on for all clusters
#!fix forcing the HLODs to show up in the editor changes the MinDrawDistance of the static mesh component, this was getting saved and not restored during runtime (now does it in PostLoad)
#!jira UE-47712
#!rb none
#!tests PIE in Editor while having HLOD forced on
Change 3570047 on 2017/08/02 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Fix for ensure leading to deadlock
#!jira OR-42071
#!tests compiled, ran ShortSoloGame test
#!rb none
[QAREVIEW] - this fixes the PC locks in OR-42071 and probably the PS4 too, but please recheck both platforms to be sure.
#!ROBOMERGE-SOURCE: CL 3570044 in //Orion/Release-42/... via CL 3570045 via CL 3570046
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3569932 on 2017/08/02 by robomerge
#!ROBOMERGE-AUTHOR: andrew.grant
Integration from UE4 - fixed a set of critical bugs that would cause rare crashes in the async IO subsystems.
#!rb gil.gribb
#!tests ran 10x solo games, ran LoadTest, all PS4
#!jira UE-47483
#!ROBOMERGE-SOURCE: CL 3569929 in //Orion/Release-42/... via CL 3569930 via CL 3569931
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3569839 on 2017/08/02 by Daniel.Lamb
Added the low quality monolith map to the build launcher and cook maps list.
#!rb Trivial
#!test Compile UAT
Change 3569441 on 2017/08/02 by robomerge
#!ROBOMERGE-AUTHOR: laurent.delayen
Re-enabled OnlyTickMontagesWhenNotRendered animation optimization, after fixing edge case where 'Evaluate' could be called on out of sync cached data.
Only update cached data when the graph will be updated, to ensure we don't have mismatching update and evaluate data.
#!rb none
[CODEREVIEW] martin.wilson, lina.halper
#!tests bot match w/ dedicated server.
#!ROBOMERGE-SOURCE: CL 3569235 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3569397 on 2017/08/02 by robomerge
#!ROBOMERGE-AUTHOR: ben.salem
Merging using Dev-Gen_->_Release-42.1 Support for skins in perf reporting, also report overall test run time.
#!rb various
#!tests ran with new shallow test maps.
#!ROBOMERGE-SOURCE: CL 3568892 in //Orion/Release-42.1/... via CL 3568967
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3568639 on 2017/08/02 by Adric.Worley
Add individual FTest enumeration to Orion perf tests
Moved methods to run FTests to helper for reuse.
Effects perf tests now show individual test cases for more granular runs.
All perf tests now do map check and draft logic as setup.
#!tests ran updated tests in client/server
#!rb ben.salem
Change 3568616 on 2017/08/02 by Ben.Salem
Switch shallow fx tests to report to their own mailing list.
#!rb bob.ferreira
#!tests recompiled
Change 3568607 on 2017/08/02 by Daniel.Lamb
Added staticmeshcomponent to the memreportfull command.
#!rb Trivial
#!test Paragon
Change 3568018 on 2017/08/01 by Ben.Salem
Add skin and character name to test reports, and also test runtime.
#!rb none
#!tests ran steel shallow test
Change 3567995 on 2017/08/01 by Bob.Ferreira
[FXTests] Updating FXTests and ShallowFXTests to call OnComplete() when doing check point validation.
[Gauntlet] Changed InnerTestResult to be protected so that inherited test nodes can modify it.
#!rb Ben.Salem
#!TESTS Ran local automationtool run on a cooked main build.
Change 3567912 on 2017/08/01 by robomerge
#!ROBOMERGE-AUTHOR: ori.cohen
Added support for physical materials in immediate mode
#!rb none
#!tests none
[CODEREVIEW] Benn.Gallagher
#!ROBOMERGE-SOURCE: CL 3567865 in //Orion/Release-42/... via CL 3567901 via CL 3567904
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3567594 on 2017/08/01 by robomerge
#!ROBOMERGE-AUTHOR: laurent.delayen
Disabling animation optimization until I can fix an edge case.
#!rb none
#!tests arcade mode
#!ROBOMERGE-SOURCE: CL 3567593 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3566953 on 2017/08/01 by robomerge
#!ROBOMERGE-AUTHOR: laurent.delayen
Animation Optimization: Added EMeshComponentUpdateFlag::OnlyTickMontagesWhenNotRendered to only update montages when not rendered, instead of doing a whole pose update. This means on dedicated servers we'll only update montages when needed, and not the AnimGraph, which we have no need for.
This is also affects non rendered meshes on clients.
#!rb martin.wilson
[CODEREVIEW] lina.halper, martin.wilson
#!tests ghost and wukong networked doing montage abilities.
#!ROBOMERGE-SOURCE: CL 3566950 in //Orion/Main/...
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
Change 3564610 on 2017/07/31 by Uriel.Doyon
Integrated CL 3543210 : Fixed an issue when computing material scales where the default material ends up being used instead of the required material.
Deprecated previous material data as it was causing some waste.
Integrated CL 3526859 : Texture mip bias is now reset whenever the streaming budget increases
#!rb none
#!tests played monolith2 on PS4
Change 3564509 on 2017/07/31 by robomerge
#!ROBOMERGE-AUTHOR: laurent.delayen
Fixed warning when opening Kwang AnimBP the first time, due to missing virtual bone name. (When Skeleton doesn't have PostLoad() called on it yet - happens only the first time the AnimBP is opened).
[CODEREVIEW] jurre.debaare, dwayne.martin, lina.halper, martin.wilson
#!rb none
#!tests Kwang AnimBP opens without a warning.
#!ROBOMERGE-SOURCE: CL 3564506 in //Orion/Release-42/... via CL 3564507
#!ROBOMERGE-BOT: ORION (Main -> Dev-General)
[CL 3613306 by Andrew Grant in Main branch]
#lockdown Nick.Penwarden
============================
MAJOR FEATURES & CHANGES
============================
Change 3441680 by Uriel.Doyon
Added units to point light intensity, to allow the user to specify the value in candelas or lumens.
New point light actors now configure the intensity in candelas by default.
Replaced viewport exposure settings by an EV100 slider.
Hidding the tone mapper in the show flag now still applies the exposure.
Added a new AutoExposure method called EV100 which allows to specify :
- MinEV100, MaxEV100
- Calibration Constnat
- Exposure Compensation
#jira UE-42783
Change 3454934 by Chris.Bunner
Backing out changelists 3441680, 3454636 and 3454844 for the sake of integration stability.
Change 3512118 by Marc.Olano
Fix rare Sobol shader data problem. Mismatch with CPU code after a large number of points
Resubmit of portion of //UE4/Dev-Rendering@3509854 that was rolled back to avoid massive shader recompiles during integration testing
Change 3512129 by Benjamin.Hyder
Fixing up content in TM-SobolNoise
Change 3512151 by Rolando.Caloca
DR - Fixed some layouts that were general
- Added some extra dump information
Change 3512160 by Benjamin.Hyder
Still Fixing TM-Sobol
Change 3512180 by Marc.Olano
PCSS for spotlights. Like directional PCSS this is experimental, activated by r.Shadow.FilterMethod.
Change 3512261 by Michael.Lentine
Move Subsurface to shared properties.
Previously the same code could be executed multiple times without being optimized out if multiple inputs used the same subsurface output.
#jira UE-44405
Change 3512288 by Rolando.Caloca
DR - Fix issue when recycling image handles
Change 3512338 by Michael.Lentine
Fix precision if user enters a multiple of 90 degree rotation for transforms.
This will only work for exact values. Generally comparing float point numbers using == is unsafe but it should be ok in this case as they are exact values entered from the UI. We may want to later expand this to include thresholding using a value ~1e-7.
#jira UE-46137
Change 3512424 by Michael.Lentine
Regenerate BaseColor.uasset and Specular.uasset to not have the notforclient flags set.
#jira UE-44315
Change 3512686 by Brian.Karis
Fix for quadric assert in infiltrator. Due to bad tangents in source mesh.
Change 3512696 by Brian.Karis
Unrevert TAA. Fixed DOF NaN artifacts
Change 3512717 by Marcus.Wassmer
PR #3714: Fix typo in EOcclusionCombineMode (Contributed by Mumbles4)
Change 3513112 by Richard.Wallis
Crash when packaging for iOS with Shared Material Native Libraries and Share Material Shader Code from windows platform. Offline shader compile for archiving not done - shader header has missing offline compile flag for native Metal library archiving.
Fix includes:
- Handle offline compile failure when not running on Mac and no remote is configured (or remote fails). (I think it's this point at which the crash in the bug report is at).
- Make sure remote can build for native Metal libraries and archive correctly - this should now support Linux platforms or Mac to Mac (if enabled in MetalShaderCompiler.cpp) for testing if required.
- Updated to include remote calling into the xcode 9 Metal pch fix already submitted by Mark Satt.
#jira UE-45657
Change 3513357 by Richard.Wallis
Windows compile fix.
Change 3513375 by Guillaume.Abadie
Exposes the possibility to manually destroy the GPU ressource of UTextureRenderTarget2D.
Change 3513685 by Richard.Hinckley
#jira UEDOC-3822
Fixing a comment that refers to a non-existent function, for documentation purposes.
Change 3513705 by Marc.Olano
Updates to Sobol test levels in RenderTest project
Change 3513730 by Rolando.Caloca
DR - Fix mip size copying resolve targets
- Fix compute fence
- Fix descriptor set texture layout
- More dump info
Change 3513742 by Marc.Olano
Texture-free numeric print for shader debugging
Change 3513777 by Daniel.Wright
Handled edge case where no furthest samples are found in precomputed visibility
Change 3514852 by Rolando.Caloca
DR - Fix -directcompile on SCW
Change 3515049 by Rolando.Caloca
DR - hlslcc dump crash fix
Change 3515167 by Rolando.Caloca
DR - hlslcc - Fix bogus string pointer
- Allow reading from non-scalar UAVs
Change 3515745 by Rolando.Caloca
DR - Linux compile fix
Change 3515862 by Rolando.Caloca
DR - Remove old reference to CCT
- Link with hlslcc debug libs on SCW debug config for easier debugging
Change 3516292 by Rolando.Caloca
DR - glslang exe fixes
Change 3516568 by Rolando.Caloca
DR - hlslcc - Copy fix for *Buffer as functionparameters
Change 3516659 by Marcus.Wassmer
Fix some d3derrors with distance fields
Change 3516801 by Daniel.Wright
Fixed crash when doing editor 'Force Delete' on a static mesh whose distance field is still being built. Any UObject reference that is to an asset can be NULL'ed by the editor.
Change 3516825 by Rolando.Caloca
DR - Some initial fixes for structured buffers
Change 3516843 by Rolando.Caloca
DR - Fix for Vulkan dist fields
Change 3516869 by Marcus.Wassmer
Add format to the createrendertarget blueprint node
Change 3516957 by Daniel.Wright
Fixed bUsesDistortion being editable
Change 3516965 by Daniel.Wright
Still mark the distance field task completed, even if the static mesh has been deleted
Change 3517039 by Yujiang.Wang
GitHub #2655: Optimization for shadow map resolution selection for spot lights
* Use the radius of the inscribed sphere at the cone end as the spot light's screen radius
Note: slight drop of shadow quality of spot lights may occur when they are far away from the camera. This is intended, since before this optimization they tend to be always rendered with the maximum shadow map resolution (2048), which is very costly
#jira UE-33982
Change 3517069 by Yujiang.Wang
Fix for ScissorRect settings in d3d11 being lost under certain scenarios
* Scissor rectangle is always enabled in the low-level d3d11 pipeline, and it is expected that at least one ScissorRect is present no matter whether RHISetScissorRect is called with bEnable=false (when it is false we just use a big rect to make it effectively disabled)
* However FD3D11StateCacheBase::ClearState() clears all the states, which removes scissor rectangles and causes problems for certain routines (FScene::UpdateSkyCaptureContents)
* Now SetScissorRectIfRequiredWhenSettingViewport will always set a effectively disabled ScissorRect on each FD3D11DynamicRHI::RHISetViewport call, just like d3d12 does
#jira UE-45465 UE-44760
Change 3517134 by Yujiang.Wang
CIS fix
Change 3517662 by Rolando.Caloca
DR - Execute upload Vulkan cmds on the RHI thread
- Fix crash with structured buffer
Change 3517677 by Rolando.Caloca
DR - Update/copy textures on RHI thread
Change 3517680 by Rolando.Caloca
DR - Copy texture bulk data on rhi thread
Change 3517748 by Marcus.Wassmer
temporary workaround for one class of GPU crashes
Change 3518832 by Rolando.Caloca
DR - Copy & extend 3518077
- Fix for movable skylight shader missing on simple forward (low lighting quality mode)
Change 3519973 by Richard.Wallis
Jittering in Engine Menu Dropdown Options. Jitter fix: Fix some areas that hadn't been changed from RoundToInt (from previous CL's) to CeilToInt.
#jira UE-46505
Change 3520849 by Uriel.Doyon
Fixed issue with investigate texture command and dynamic component entries.
Change 3521064 by Guillaume.Abadie
Returns absolute path of shader files on error to avoid work loss in visual studio that can't figure out that a sln relative and absolute path might leading to same file on disk.
Change 3521834 by Rolando.Caloca
DR - Fix decals on Vulkan
Change 3521892 by Rolando.Caloca
DR - Fix Vulkan texture streaming
Change 3523181 by Rolando.Caloca
DR - Copy from 3523176
UE4.17 - Fix Vulkan scissor causing text to not clip
Change 3523534 by Yujiang.Wang
UE-46631: Implement a scalable LongGPUTask to fix ProfileGPU
* A new, scalable, platform-independent IssueLongGPUTask is now implemented in UtilityShaders
* Removed IssueLongGPUTask and G*Vector4VertexDeclaration from RHI implementations
* The measurement of the execution time of a basic LongGPUTask unit is kicked off on the very first frame
#jira UE-46631
Change 3524552 by Yujiang.Wang
Fix iteration number calculation of LongGPUTask
Change 3524975 by Joe.Graf
Moved the Hamming-weight function from StaticMeshDrawList.inl to FGenericPlatformMath
Added SSE versions using _mm_popcnt_u64 for platforms that support it
Added a SSE check to gracefully exit when missing the instruction and it was expected to be there
#CodeReview: arciel.rekman, brian.karis
Change 3525306 by Daniel.Wright
Fixed ensure from LPV
Change 3525346 by Rolando.Caloca
DR - Fix linking issue
Change 3525459 by Daniel.Wright
Volumetric Lightmaps - higher quality precomputed GI on dynamic objects and GI on Volumetric Fog
* Enabled by default on all maps, effective after a lighting build. This replaces the existing Precomputed Light Volume and Indirect Lighting Cache features.
* New Lightmass World Settings: VolumeLightingMethod, VolumetricLightmapDetailCellSize and VolumetricLightmapMaximumBrickMemoryMb.
* Lightmass computes lighting samples in an adaptive grid, with higher density around geometry inside the importance volume. Positions outside the importance volume get lit with the border texels.
* Improved Lightmass volume solver to use importance photons and full adaptive final gather, so volume samples have similar quality to 2d lightmaps.
* A static indirection texture is built covering the importance volume and flattening the brick tree by storing the offset to the highest density brick at each indirection cell.
* Seamless and efficient GPU interpolation across density levels is achieved by adding a single row of padding to bricks, copied from neighbors, and stitching up bricks with lower density neighbors
* The Volumetric lightmap stores Irradiance as a 3 band SH, which is 27 floats, quantized into 28 bytes, 7 texture lookups.
* A full screen barebones material using Volumetric Lightmaps costs .42ms on 970 GTX, while Indirect Lighting Cache Point costs .32ms
* Sky bent normal is also stored for stationary skylights and Directional Light Shadowing for Single Sample Shadow receiving.
* Volumetric fog, Movable components, unbuilt Static Components, SingleSampleShadow receiving and Capsule Shadows use Volumetric Lightmaps if available
* New Visualization show flag for Volumetric Lightmap sample points
* Level streaming of volume light data is not currently supported with this method
Change 3525461 by Daniel.Wright
Lowered default r.Shadow.RadiusThreshold for Epic shadow settings as it was causing a lot of visible artifacts from small objects popping out. This will increase shadowmap cost slightly (13.5ms RT -> 14.3ms RT in Fortnite on PS4, no measurable GPU difference).
Change 3526459 by Rolando.Caloca
DR - Fix validation error
Change 3526474 by Rolando.Caloca
DR - Integrate from GV
Change 3526487 by Daniel.Wright
Disabled Volumetric Lightmap filtering with neighbors due to artifacts
Fix linux compile errors
Change 3526833 by Rolando.Caloca
DR - Workaround for hlslcc
Change 3526991 by Uriel.Doyon
Integrated 3526859 : Texture mip bias is now reset whenever the streaming budget increases. This fixes an issue where textures persistently become low res after a memory spike.
Change 3527574 by Rolando.Caloca
DR - Added some missing resource entries for SCW direct mode
Change 3527625 by Rolando.Caloca
DR - Copy from 3527113
UE4.17 - Fix Vulkan not calling Present
Change 3528461 by Brian.Karis
Support larger hash sizes. Added uint list hashing function.
Change 3528780 by Rolando.Caloca
DR - Default Vulkan resources
Change 3528818 by Rolando.Caloca
DR - glslang - Added missing accessor
Change 3528839 by Rolando.Caloca
DR - Fix virtual path issue when using non-engine relative absolute paths
Change 3528900 by Daniel.Wright
Fixed variable shadowing
Change 3529039 by Rolando.Caloca
DR - Read Spirv reflection data (not used yet)
Change 3529040 by Joe.Graf
Fixed the 32bit compile failures for the popcnt optimization
#CodeReview: arciel.rekman
Change 3529060 by Rolando.Caloca
DR - hlslcc - New flag for keeping resource names
Change 3529344 by Rolando.Caloca
DR - Delete unused file
Change 3529723 by Brian.Karis
Fixed static analysis cleaner.
Change 3531357 by Michael.Trepka
Updated Mac glslang libraries with latest changes. Also, updated the Xcode project (generated with CMake) and moved it to a different location so that it no longer uses hardcoded absolute paths. It should be easy to rebuild these libraries in the future.
Change 3531517 by Joe.Graf
Added support for ddx_fine, ddy_fine, ddx_coarse, ddy_coarse to hlslcc
#CodeReview: arciel.rekman, mark.satterthwaite, rolando.caloca
Change 3531626 by Joe.Graf
Mac version of the popcount optimization
Changed Linux version to use the same builtin
#CodeReview: mark.satterthwaite, arciel.rekman
Change 3531837 by Chris.Bunner
SetScissorRectIfRequiredWhenSettingViewport sets the viewport size by default rather than disabling the scissor rect.
#jra UE-46753
Change 3533415 by Joe.Graf
Renamed the SSSE3 checks per feedback
#CodeReview: arciel.rekman
Change 3533480 by Michael.Lentine
Use more accurate descriptions for shader recompile options
Change 3533511 by Joe.Graf
Updated the GenericPlatformMisc to match the SSSE3 name change
#CodeReview: arciel.rekman
Change 3533521 by Marcus.Wassmer
Fix scenerenderer leak when updating out of view planar reflections
Change 3533528 by Joe.Graf
Updated comments
#CodeReview: n/a
Change 3533608 by Mark.Satterthwaite
New manual Xcode project for glslang so that we include all the necessary code and can link again.
Change 3534260 by Mark.Satterthwaite
Fix the Xcode 9 Beta 3 compile errors in MetalRHI without breaking Xcode 8.3.3.
Change 3535789 by Yujiang.Wang
Fix for wrong hair shading in forward shading
* IBL reflections should be turned off for hairs
Change 3537059 by Ben.Marsh
Fixing case of iOS directories, pt1
Change 3537060 by Ben.Marsh
Fixing case of iOS directories, pt2
Change 3538297 by Michael.Lentine
Add shader comparison test.
Adding the basic test case.
Adding logic to Common.ush to enable FP16 conditionally on a define (which is not set by default)
Adding more exported functionality to automation for use in the shader test.
Change 3538309 by Michael.Lentine
Add missing file from Shader Test CL.
Change 3538751 by Michael.Lentine
Add missing pragma once.
Change 3539236 by Michael.Lentine
Do not ignore return values.
Change 3539237 by Michael.Lentine
Check in the correct file
Change 3540343 by Rolando.Caloca
DR - Added t.DumpHitches.AllThreads
Change 3540661 by Yujiang.Wang
Fix spot tube light direction
* The tube direction for a spot light was pointing along the light direction, now it is along the local Z axis which is perpendicular to the light direction. Lightmass is also touched
* A new LightTangent is added to FDeferredLightData
* Packed all the values from LightSceneProxy->GetParameters into a single FLightParameters struct to avoid copy-pasting them everywhere
Change 3541129 by Rolando.Caloca
DR - vk - Copy all Vulkan fixes from 4.17
Change 3541347 by Yujiang.Wang
Fix wrong ViewFlags being set between objects when rendering shadow depth maps
* Bug caused by trying to share DrawRenderState between objects, but SetViewFlagsForShadowPass was designed to start from a fresh render state
* Now SetViewFlagsForShadowPass recalculates and sets the flags on each call
Change 3542603 by Rolando.Caloca
DR - vk - Allow sharing samplers on Vulkan
Change 3542639 by Jian.Ru
Changed warning text to better indicate that global clip plane needs to be enabled for planar reflection
#RB Marcus.Wassmer
Change 3543167 by Michael.Lentine
Fix naming for the shader comparison tests.
Change 3543210 by Uriel.Doyon
Fixed an issue when computing material scales where the default material ends up being used instead of the required material.
In that case, we used the default settings for texture streaming (assuming a scale of 1).
Change 3543221 by Brian.Karis
Simplifier optimizations
Change 3543239 by Arciel.Rekman
hlslcc: remove FCustomStd* workarounds.
- This was previous attempt to work around problems arising from different STL used for building libhlslcc (in the cross-toolchain) and possibly different STL used for building engine (on the system).
- The same problem has been resolved by bundling libc++.
Change 3543946 by Michael.Lentine
Add comparison output.
Change 3544277 by Brian.Karis
Fixed uninitialized var error
Change 3544404 by Rolando.Caloca
DR - Fix broken textures
Change 3544503 by Jian.Ru
Ensure lighting failure delegates are always called
#RB Marcus.Wassmer,Daniel.Wright
#3689
Change 3545241 by Daniel.Wright
Fixed spotlight whole scene shadows using a radius 2x too long
Change 3545347 by Daniel.Wright
Fixed shadow occlusion culling broken by shadowmap caching change. FProjectedShadowKey is now computed correctly for whole scene shadows and SDCM_StaticPrimitivesOnly shadowmaps will fall back to the query for a SDCM_MovablePrimitivesOnly, since the static primitives shadowmap's query is not issued every frame.
Change 3546196 by Marcus.Wassmer
Fix minor typo
Change 3546459 by Daniel.Wright
ULevel::PostEditChangeProperty recreates rendering resources if MapBuildData is modified - fixes a crash when Force Deleting the MapBuildData package.
Change 3546469 by Jian.Ru
Take into account CVarStaticMeshLODDistanceScale during static mesh LOD calculation
Change 3546804 by Daniel.Wright
[Copy] Added SendAllEndOfFrameUpdates draw event to wrap skin cache events
Change 3546814 by Daniel.Wright
[Copy] Only use skylight OcclusionMaxDistance for the global distance field if it casts shadows
Change 3546815 by Daniel.Wright
[Copy] Snap volumetric fog light function target resolution to a factor of 32 to avoid constant texture reallocation
Change 3546817 by Daniel.Wright
[Copy] Warmup time warning
Change 3546828 by Daniel.Wright
[Copy] Fixed UWorld::DestroyActor in PIE calling InvalidateLightingCacheDetailed which can do a FlushRenderingCommands and cause a large hitch
Change 3546836 by Daniel.Wright
[Copy] ULightComponent::InvalidateLightingCacheInner uses MarkRenderStateDirty instead of slow reregister + FlushRendingCommands, and only for lights which might have static lighting data
Change 3546849 by Rolando.Caloca
DR - vk - Fix missing samplerstates
- Fixes for structured buffers
- Add missing Draw and Dispatch Indirect
Change 3547516 by Brian.Karis
Linear time 5-coloring for planar graphs.
Brought in the Planarity library written by John Boyer, heavily edited and trimmed down to only include code necesary for graph coloring. Put behind a simple wrapper.
Change 3547542 by Brian.Karis
Linear time 5-coloring for planar graphs.
Brought in the Planarity library written by John Boyer, heavily edited and trimmed down to only include code necesary for graph coloring. Put behind a simple wrapper.
Change 3547563 by Brian.Karis
Fixed some compiler warnings and hopefully some errors.
Change 3547610 by Brian.Karis
Replaced macros with inlined functions
Change 3547620 by Brian.Karis
Clean up includes
Change 3547770 by Marcus.Wassmer
GPU Crash for MTBF analytics
Change 3547773 by Marcus.Wassmer
Updated doxygen comment for new analytic
Change 3548244 by Rolando.Caloca
DR - Fix for translucency
Change 3548352 by Yujiang.Wang
Added soft source radius for point and spot lights
* Soft source radius controls how 'blurry' the shape of specular lighting looks
* Implemented by LobeRoughness modification
* Better approximation for spherical lights so that they don't look sharp when the radius is large using 'smoothed representative point' method
* Suppoted LightTangent in forward shading
Change 3548530 by Brian.Karis
Fix for mac build
Change 3548770 by Rolando.Caloca
DR - vk - Prereq work for Vulkan parallel RHI contexts
Change 3548772 by Jian.Ru
Fixed an issue that caused an ensure when switching levels in D3D10. #rb Marcus.Wassmer
Change 3548865 by Daniel.Wright
With shadowmap caching of whole scene shadows, only one of the cache modes issues an occlusion query. Fixes a crash where the static primitive shadowmap is culled but the movable primitive shadowmap is visible, which is normally not possible.
Change 3548952 by Rolando.Caloca
DR - Allow separate samplers in the shaders on Vulkan
Change 3549197 by Marcus.Wassmer
Fix DX12 PIx not working in cooked builds
Change 3549209 by Daniel.Wright
Occlusion culling for CSM, from the main camera, controlled by 'r.Shadow.OcclusionCullCascadedShadowMaps'. Disabled by default as rapid view changes don't work well with latent occlusion queries.
Change 3549943 by Ben.Marsh
Include better diagnostic information when a modified build product is detected after running a build step.
Change 3550546 by Rolando.Caloca
DR - Fix merge issue
Change 3550962 by Marcus.Wassmer
EarlyZ Masking requires full depth prepass, so just force it to.
Change 3551062 by Daniel.Wright
Handle NULL skylight
Change 3551104 by Rolando.Caloca
DR - vk - Remove assert to match other platforms
Change 3551221 by Rolando.Caloca
DR - vk - Add mirror clamp to edge extension
- Fix framebuffer deletion
Change 3551224 by Daniel.Wright
Volumetric lightmap increase density around static lights affecting a voxel brighter than LightBrightnessSubdivideThreshold.
Change 3551495 by Rolando.Caloca
DR - vk - Intiial support for async queue
Change 3552101 by Rolando.Caloca
DR - vk - Fix for async
Change 3552102 by Rolando.Caloca
DR - SkinCache - Fix potential leak on staging buffers for recompute tangents
- Integrate changes from 4.17 for memory optimizations
Change 3552104 by Rolando.Caloca
DR - vk - Support for SRVs for index buffers
Change 3552838 by Rolando.Caloca
DR - vk - Enable debug markers if found
Change 3553106 by Rolando.Caloca
DR - vk - Fixes for index buffer SRVs
Change 3553107 by Rolando.Caloca
DR - vk - Enable recompute tangents on Vulkan
Change 3553154 by Rolando.Caloca
DR - vk - Fix crash with null uav
Change 3553342 by Yujiang.Wang
Fix redundant skylights in AdvancedPreviewScene
* PreviewScene was changed to using a skylight instead of ambient cubemap to support forward shading
* AdvancedPreviewScene originally had a skylight, now it is changed to using the one inherited from PreviewScene
Change 3553481 by Rolando.Caloca
DR - Integrate fix for D3D12 support of index buffers SRVs
#jira UE-47674
Change 3553715 by Rolando.Caloca
DR - Fix crash when launching PC with -featureleveles31
Change 3553725 by Rolando.Caloca
DR - Redo fix
Change 3553803 by Rolando.Caloca
DR - Shader compile fixes for ES3.1
Change 3553963 by Rolando.Caloca
DR - vk - Remove extra IRDump
Change 3554741 by Ben.Marsh
CIS fix.
Change 3555222 by Rolando.Caloca
DR - vk - static analysis fix
Change 3555362 by Rolando.Caloca
DR - vk - Prep work for separate present queue
Change 3556800 by Daniel.Wright
Fixed screenshot for simple volume material doc
Change 3556942 by Brian.Karis
Fixed Bokeh DOF regression.
Change 3556959 by Rolando.Caloca
DR - vk - Rework staging buffer peak usage
Change 3557497 by Daniel.Wright
Better display name for Unbound property on post process volume
Change 3557499 by Daniel.Wright
Disable r.GenerateLandscapeGIData by default, opt-in for kite demo. Projects that want to use heightfield GI need to opt-in to r.GenerateLandscapeGIData.
Change 3557068 by Olaf.Piesche
Configurable spawn rate scaling reference value; sets the zero-scale reference value (default: 2), so additional quality levels can be added and scaling customized further.
IMPORTANT: This sets the reference to 3 in PS4Scalability.ini; effects on PS4 are again going to have reduced spawn rates versus PC and Neo, as intended by the FX artists starting with this change.
#tests QAGame test maps
Change 3558123 by Rolando.Caloca
DR - vk - static analysis fix
Change 3558685 by Yujiang.Wang
Github #3323: Two sided foliage lightmap directionality fix
* Subsurface is not intended to work with lightmaps that don't have directionality, however we still want it to look similar to a directional one
* Now it uses a constant directionality value
#jira UE-42523
Change 3559052 by Brian.Karis
Hopefully fix static analysis
Change 3559113 by Rolando.Caloca
DR - Fix crash witrh planar reflections
Change 3559275 by Yujiang.Wang
Fix race condition on several scalability CVars between rendering thread and game thread
Change 3559612 by Rolando.Caloca
DR - vk - SM5 with uniform buffers backend support
Change 3559716 by Rolando.Caloca
DR - hlslcc - Fix linker warning on SCW debug
Change 3559768 by Rolando.Caloca
DR - vk - Keep ub names for bindings
Change 3560195 by Rolando.Caloca
DR - accessor
Change 3560275 by Rolando.Caloca
DR - vk - Support for uniform buffers
Change 3560913 by Rolando.Caloca
DR - vk - Fix static analysis
Change 3561145 by Rolando.Caloca
DR - Don't crash if out of resource table bits
Change 3561194 by Rolando.Caloca
DR - vk - Integrate timestamp fixes
Change 3562009 by Rolando.Caloca
DR - vk - Workaround for bad UTexture data
Change 3563884 by Chris.Bunner
VK_NULL_HANDLE fix.
Change 3563885 by Jian.Ru
Ignore a warning caused by enabling distance field generation so that test Cube_Blue and Cube_Section don't fail. #rb Chris.Bunner
Change 3565943 by Jian.Ru
Add extra warning log triggered when attempt to create FRWBuffer greater than 256MB in ComputeLightGrid() #rb Chris.Bunner
Change 3569479 by Michael.Lentine
Integrate rhino shader changes to dev-rendering
Change 3569511 by Michael.Lentine
Fix formating and string out on windows.
Change 3569572 by Yujiang.Wang
Fix MeasureLongGPUTaskExecutionTime crashing on AMD on Macs
Change 3569614 by Yujiang.Wang
Flush rendering commands before measuring the long GPU task's excution time to get accurate results
Change 3570524 by Jian.Ru
Add extra parentheses to avoid compilation warning #rb Chris.Bunner
Change 3570722 by Chris.Bunner
Static analysis workaround - same code, just validating compile-time assumptions a little further.
Change 3570880 by Jian.Ru
Add small depth offset to avoid depth test failing during velocity pass
#jira UE-37556
Change 3572532 by Jian.Ru
Disable a warning to let tests pass
#jira UE-48021
Change 3573109 by Michael.Lentine
Checkin Michael.Trepka's fix for external dynamic libraries on mac.
This is needed to make the build go green on mac.
Change 3573995 by Jian.Ru
Move an include out of define to let nightly build pass
Change 3574777 by Chris.Bunner
Continued merge fixes.
Change 3574792 by Rolando.Caloca
DR - Rename todo
Change 3574794 by Chris.Bunner
Re-adding includes lost in a pre-merge merge.
Change 3574879 by Michael.Trepka
Disabled a couple of Mac deprecation warnings
Change 3574932 by Chris.Bunner
Merge fix.
Change 3575048 by Michael.Trepka
Fixed iOS compile warnings
Change 3575530 by Chris.Bunner
Duplicating static analysis fix CL 3539836.
Change 3575582 by Chris.Bunner
Fixed GetDimensions return type in depth resolve shaders.
Compile error fix.
Change 3576326 by Chris.Bunner
Static analysis fixes.
Change 3576513 by Michael.Trepka
Updated Mac MCPP lib to be compatible with OS X 10.9
Change 3576555 by Richard.Wallis
Metal Validation Errors. Dummy black volume texture is in the wrong format in the Metal shader for the VolumetricLightmapIndirectionTexture. Create a new dummy texture with pixel format PF_R8G8B8A8_UINT.
#jira UE-47549
Change 3576562 by Chris.Bunner
OpenGL SetStreamSource stride updates.
Change 3576589 by Michael.Trepka
Fixed Mac CIS warnings and errors in Dev-Rendering
Change 3576708 by Jian.Ru
Fix cascade preview viewport background color not changing
#jira UE-39687
Change 3576827 by Rolando.Caloca
DR - Minor fix for licensee
Change 3576973 by Chris.Bunner
Fixing up HLSLCC language spec mismatch (potential shader compile crashes in GL and Vulkan).
Change 3577729 by Rolando.Caloca
DR - Fix for info on SCW crashes
Change 3578723 by Chris.Bunner
Fixed issue where custom material attribute was using display name as hlsl function name.
Change 3578797 by Chris.Bunner
Fixed pixel inspector crashing on high-precision normals gbuffer format.
#jira UE-48094
Change 3578815 by Yujiang.Wang
Fix for UE-48207 Orion cooked windows server crash on startup
* Crash caused by rendering features not available in a dedicated server build
* Skip over MeasureLongGPUTaskExecutionTime when !FApp::CanEvenRender()
#jira UE-48207
Change 3578828 by Daniel.Wright
Disable volumetric lightmap 3d texture creation on mobile
Change 3579473 by Daniel.Wright
Added View.SharedBilinearClampSampler and View.SharedBilinearWrapSampler. Used these to reduce base pass sampler counts with volumetric lightmaps.
Change 3580088 by Jian.Ru
Fix QAGame TM-CharacterMovement crashing on PIE
#jira UE-48031
Change 3580388 by Daniel.Wright
Fixed shadowed light injection into volumetric fog fallout from Rhino merge
Change 3580407 by Michael.Trepka
Updated Mac UnrealPak binaries
Change 3581094 by Michael.Trepka
Fix for ScreenSpaceReflections not working properly on iOS 11
Change 3581242 by Michael.Trepka
Fixed a crash on startup on Mac when launching TM-ShaderModels in QAGame
#jira UE-48255
Change 3581489 by Olaf.Piesche
Replicating CL 3578030 from Fortnite-Main to fix #jira UE-46475
#jira FORT-47068, FORT-49705
Don't inappropriaely touch game thread data on the render thread. Push SubUV cutout data into a RT side object owned by the sprite dynamic data.
#tests FN LastPerfTest
Change 3581544 by Simon.Tovey
Fix for ensure accessing cvar from task thread.
#tests no more ensure
Change 3581934 by Chris.Bunner
Fixed ConsoleVariables.ini break from merge.
Change 3581968 by Jian.Ru
Fix QAGame TM-ShaderModels PIE crash when resizing game viewport
#jira UE-48251
Change 3581989 by Richard.Wallis
Fix for NULL PrecomputedLightingBuffer. It is null for first frame request in forward rendering so should have the GEmptyPrecomputedLightingUniformBuffer set in these cases after it's been initially tried to be set not before.
#jira UE-46955
Change 3582632 by Chris.Bunner
Resolved merge error.
Change 3582722 by Rolando.Caloca
DR - Workaround for PF_R8G8B8A8_UINT on GL
#jira UE-48208
Change 3584096 by Rolando.Caloca
DR - Fix for renderdoc crashing in shipping
#jira UE-46867
Change 3584245 by Jian.Ru
Fix System.Promotion.Editor.Particle Editor test crash
#jira UE-48235
Change 3584359 by Yujiang.Wang
Fix for UE-48315 Wall behind base in Monolith is flickering white in -game Orion
* Caused by dot(N, V) being negative
* Clamp to (0, 1)
#jira UE-48315
Change 3587864 by Mark.Satterthwaite
Fix the GPU hang on iOS caused by changes to the Depth-Stencil MSAA handling: you can't store the MSAA stencil results on iOS < 10 unless you use the slower MTLStoreActionStoreAndMultisampleResolve which we don't need for the mobile renderer.
#jira UE-48342
Change 3587866 by Mark.Satterthwaite
Correctly fix iOS compilation errors against Xcode 9 Beta 5 and Xcode 8.3.3 - duplicating function definitions is guaranteed to be wrong.
Change 3588168 by Mark.Satterthwaite
Move the Xcode version into the Metal shader format header, not the DDC key, so that we can handle bad compiler/driver combinations in the runtime and don't force all users to recompile every time the Xcode version changes.
Change 3588192 by Rolando.Caloca
DR - Fix d3d12 linker error when EXECUTE_DEBUG_COMMAND_LISTS is enabled
Change 3588291 by Rolando.Caloca
DR - Fix for d3d12 command list crash: Commited resources can not have aliasing barriers
#jira UE-48299
Change 3590134 by Michael.Trepka
Copy of CL 3578963
Reset automation tests timer after shader compilation when preparing for screenshots taking to make sure tests don't time out.
Change 3590405 by Rolando.Caloca
DR - hlslcc - support for sqrt(uint)
Change 3590436 by Mark.Satterthwaite
Rebuild Mac hlslcc for CL #3590405 - without the various compiler workarounds left over from before the recent code changes.
Change 3590674 by Rolando.Caloca
DR - vk - Integration from working branch
- Fixes distance field maps
- Compute pipelines stored in saved file
- Adds GRHIRequiresRenderTargetForPixelShaderUAVs for platforms that need dummy render targets
Change 3590699 by Rolando.Caloca
DR - Fix distance fields mem leak
Change 3590815 by Rolando.Caloca
DR - vk - Fixes for uniform buffers and empty resource tables
Change 3590818 by Mark.Satterthwaite
Temporarily switch back to OpenVR v1.0.6 for Mac only until I can clarify what to do about a required but missing API hook for Metal. Re-enabled and fixed compile errors with Mac SteamVR plugin code.
Change 3590905 by Mark.Satterthwaite
For Metal shader compilation where the bytecode compiler is unavailable force the debug compiler flag and disable the archiving flag because storing text requires this.
#jira UE-48163
Change 3590961 by Mark.Satterthwaite
Submitted on Richard Wallis's behalf as he's on holiday:
Mac fixes for Compute Skin Cache rendering issues (resulting in incorrect positions and tangents) and for recomputing tangents. Problem sampling from buffers/textures as floats with packed data. Some of the data appears as denorms so get flushed to zero then reinterpreted as uints via asuint or in Metal as_type<uint>(). Fix here for Metal seems to be to use uint types for the skin cache SRV's and as_type<> to floats instead.
There could be some other areas where we're unpacking via floats that could affect Metal and I'm not sure how this will impact on other platforms.
#jira UE-46688, UE-39256, UE-47215
Change 3590965 by Mark.Satterthwaite
Remove the Z-bias workaround from Metal MRT as it isn't required and actually causes more problems.
Change 3590969 by Mark.Satterthwaite
Make all Metal shader platforms compile such that half may be used, unless the material specifies full precision.
Change 3591871 by Rolando.Caloca
DR - Enable PCSS on Vulkan & Metal
- Enable capsule shadows on Vulkan
Change 3592014 by Mark.Satterthwaite
Remove support for Mac OS X El Capitan (10.11) including the stencil view workaround.
Bump the minimum Metal shader standard for Metal SM4, SM5 & Metal MRT to v1.2 (macOS 10.12 Sierra & iOS 10) so we can use FMAs and other newer shader language features globally.
Enable the new GRHIRequiresRenderTargetForPixelShaderUAVs flag as Metal is like Vulkan and needs a target for fragment rendering.
Also fix the filename for direct-compile & remove the old batch file generation in the Metal shader compiler.
Change 3592171 by Rolando.Caloca
DR - CIS fix
Change 3592753 by Jian.Ru
repeat Daniel's fix on xb1 profilegpu crash (draw events cannot live beyond present)
Change 3594595 by Rolando.Caloca
DR - Fix D3D shader compiling run time stack corruption failure on debug triggering falsely
Change 3594794 by Michael.Trepka
Call FPlatformMisc::PumpMessages() before attempting to toggle fullscreen on Mac to fix an issue on some Macs running 10.13 beta that would ignore the toggle fullscreen call freezing the app
Change 3594999 by Mark.Satterthwaite
Disable MallocBinned2 for iOS as on Rhino it worked but on iOS 10.0.2 there are bugs (munmap uses 64kb granularity, not the 4096 the code expects given the reported page-size).
While we are here remove the spurious FORCE_MALLOC_ANSI from the iOS platform header.
#jira UE-48342
Change 3595004 by Mark.Satterthwaite
Disable Metal's Deferred Store Actions and combined Depth/Stencil formats on iOS < 10.3 as there are bugs on earlier versions of iOS 10.
#jira UE-48342
Change 3595386 by Mark.Satterthwaite
Silence the deprecation warning for kIOSurfaceIsGlobal until SteamVR switches to one of the newer IOSurface sharing mechanisms.
Change 3595394 by Rolando.Caloca
DR - Added function for tracking down errors in the hlsl parser
- Added support for simple #if 0...#endif
Change 3599352 by Rolando.Caloca
DR - Fixes for HlslParser
- Added missing attributes for functions
- Fixed nested assignment
Change 3602440 by Michael.Trepka
Fixed Metal shader compilation from Windows with remote compilation disabled
#jira UE-48163
Change 3602898 by Chris.Bunner
Resaving assets.
Change 3603731 by Jian.Ru
fix a crash caused by a material destroyed before the decal component
#jira UE-48587
Change 3604629 by Rolando.Caloca
DR - Workaround for PF_R8G8B8A8_UINT on Android
#jira UE-48208
Change 3604984 by Peter.Sauerbrei
fix for orientation not being limited to that specified in the plist
#jira UE-48360
Change 3605738 by Chris.Bunner
Allow functional screenshot tests to request a camera cut (e.g. tests relying on temporal aa history).
#jira UE-48748
Change 3606009 by Mark.Satterthwaite
Correctly implement ClipDistance for Metal as an array of floats as required by the spec. and fix a few irritating issues from the merge that should not have.
- When compiling a tessellation vertex shader in the SCW direct mode we can't evaluate non-existant defines and we don't actually need to.
- The define names, values & shader file name are irrelevant to the Metal output key, but the shader format name & Metal standard really do matter - should speed up Metal shader compilation a bit.
- Move the shader vertex layer clip-distance to index 2 to avoid conflicts.
- Don't default initialise the debug code string for Metal shaders or it won't print out the actual code....
#jira UE-47663
Change 3606108 by Mark.Satterthwaite
Temporary hack to avoid a crash in AVPlayer.
#jira UE-48758
Change 3606121 by Mark.Satterthwaite
Fix Windows compilation.
Change 3606992 by Chris.Bunner
Static analysis fix.
[CL 3608256 by Marcus Wassmer in Main branch]
#lockdown Nick.Penwarden
=====================================
MAJOR FEATURES + CHANGES
=====================================
Change 3372740 by Chris.Bunner
[Experimental] Partial compute post process pipeline (r.PostProcess.PreferCompute).
StencilSceneTexture added to deferred list.
A few known issues to be fixed in a follow-up CL.
Change 3374187 by Chris.Bunner
Volume texture support for CombineLUTs/Tonemap compute pass.
Refactored common param code to shared sub-class in CombineLUTs and Tonemap PS/CS.
Skip compute post process out-of-bounds writes.
Unsigned type conversion fixes.
Trimmed compute post process shader inputs.
Change 3441680 by Uriel.Doyon
Added units to point light intensity, to allow the user to specify the value in candelas or lumens.
New point light actors now configure the intensity in candelas by default.
Replaced viewport exposure settings by an EV100 slider.
Hidding the tone mapper in the show flag now still applies the exposure.
Added a new AutoExposure method called EV100 which allows to specify :
- MinEV100, MaxEV100
- Calibration Constnat
- Exposure Compensation
#jira UE-42783
Change 3454636 by Uriel.Doyon
Fixed point light having an extra scale of 16 in mobile
#jira UE-45272
Change 3454844 by Uriel.Doyon
Fixed extra X16 on some point lights
#jira UE-45250
Change 3454934 by Chris.Bunner
Backing out changelists 3441680, 3454636 and 3454844 for the sake of integration stability.
Change 3461206 by Guillaume.Abadie
Adds possibility to scene captures and player controller to render no primitives at all.
Change 3461207 by Guillaume.Abadie
Exposes showflag details to USceneCaptureComponent. This gives the possibility to configure scene capture's showflags in blueprint encapsulated compositing pipeline.
#jira UE-6810
Change 3461233 by Chris.Bunner
Added Log10 material expression.
Added tooltip for Log2 and Log10.
Change 3461434 by Michael.Trepka
Copy of CL 3456118
In Metal RHI report texture streaming as immediately successful as on D3D to avoid a race-condition leading to deadlock between the Main, Game, Render & RHI threads.
#jira UE-44961
Change 3461770 by Benjamin.Hyder
Submitting TM-RayTracedDistanceField map
Change 3461929 by Marc.Olano
Add Sobol blueprint and material node test maps to RenderTest project
Change 3462249 by Uriel.Doyon
Translucency after DoF is now disabled when showflag postprocess is disabled.
Change 3462371 by Brian.Karis
VT addressing is now 64bit to support huge sparse virtualized volumes
16bit page tables working.
Change 3462936 by Marc.Olano
Extend Sobol testing map with comparision between Random Sobol and Next Sobol functions
Change 3464394 by Uriel.Doyon
Improved synchronization for texture streaming commands.
This fixes an issue when accessing FStreamingTexture for pending textures.
Change 3464743 by Guillaume.Abadie
Adds .usf file extension on all shader's source file names and adds checks to verify them at engine load time.
Change 3464818 by Guillaume.Abadie
Fixes compilation error in FindShaderRelativePath
Change 3465184 by Daniel.Wright
r.Shadow.PreShadowResolutionFactor 1.0 on Epic shadow settings
Change 3465283 by Marc.Olano
Update Sobol Gray code tables to match random order tables
Change 3465976 by Arne.Schober
DR - [UE-44393] - The Canvas is using the Globalshaders for clearing but compilation is done asynconously at load time. Unfortunately there could be Code that uses a canvas to draw and cause this issue in between. There might be some plugins that do this. For now we need to wait and block for the shaqders to be compiled until we can allo the use of the canvas.
#RB none
Change 3467513 by Guillaume.Abadie
Fixes an issue where primitives would no longer draw in gameplay.
#jira UE-45550
Change 3471116 by Richard.Wallis
Mac OpenGL Is No Longer Supported - Remove All Code & Shader Platforms. Merge of CL 3327784 dev-editor stream from Michael Trepka with some extra changes.
- Also removed Metal shader platforms from PlatformSupportsDebugViewShaders() otherwise we get a compiler error. HLSL register binds not implemented in metal backend.
#jira UE-39108
Change 3471117 by Richard.Wallis
Drop down menus clip on 27" Screen iMacs. Disable viewport HDR rendering on macOS 10.12.x when in editor.
#jira UE-43026
Change 3471130 by Richard.Wallis
Mac GPU hang causes editor output log to be written to the wrong file. Try to emulate windows behaviour when opening a file for reading or writing. Tested against behaviour of windows log file with multiple instances running.
- Only defined in for Mac and non shipping.
#jira UE-44934
Change 3471224 by Guillaume.Abadie
Lets the ProjectFileGenerator to look at Shaders/ directories in plugin and game projects.
Change 3471646 by Daniel.Wright
Fixed ensure opening UT system settings
Change 3471862 by Arne.Schober
DR - revert accidently checked in changes.
#RB Chris.Bunner
Change 3472249 by Guillaume.Abadie
Implements virtual shader source directory mapping.
- /Engine/... maps to Engine/Shaders/...
- /Plugin/FooBar/... maps to FooBar plugin's Shaders/ directory
- /Project/... maps to project's Shaders/ directory
Change 3472443 by Daniel.Wright
Moved the Rendering category for lights to be just below the Light category, so the bVisible property is easily accessible
Change 3474537 by Uriel.Doyon
Fixed lighting needs rebuild happening after blueprint rescript and a non symetrical Quaterion != ToQuaternion(ToRotator(Quaternion)
Change 3475192 by Guillaume.Abadie
Implements LensDistortion engine plugin.
This CL import a polished version of Raven's lens distortion and undistortion from OpenCV parameters:
- It is implemented as the first engine plugin with its own shaders and render thread commands;
- Has feature tests in EngineTest with gold images directly extracted from OpenCV itself (GenerateLensDistortionUndistortReferences.py)
Change 3475209 by Guillaume.Abadie
Back out changelist 3475192
Change 3475252 by Guillaume.Abadie
Reland: Implements LensDistortion engine plugin.
This CL import a polished version of Raven's lens distortion and undistortion from OpenCV parameters:
- It is implemented as the first engine plugin with its own shaders and render thread commands;
- Has feature tests in EngineTest with gold images directly extracted from OpenCV itself (GenerateLensDistortionUndistortReferences.py)
Change 3475389 by Guillaume.Abadie
Adds LensDistortion plugin's feature tests.
Change 3475538 by Guillaume.Abadie
Adds the /Engine/* prefix on all of the renderer's USF file references.
Change 3475568 by Guillaume.Abadie
Adds a check for virtual shader source file path format in FShaderType::FShaderType()
Change 3475871 by Guillaume.Abadie
Fixes a bug in shader compile worker, were an error in a relative #include USF file would trigger an check failure in CheckVirtualShaderFilePath
Change 3475997 by Yujiang.Wang
Workaround for a compiler optimization bug introduced in VS2015 Update 3.
* The bug causes TSHVector<2>::CalcDiffuseTransfer to go to infinity at certain spot, making movable objects with ILCQ_Volume indirect lighting cache interpolation get very dark.
* Debug builds don't exhibit this bug.
* Semantics are exactly the same as the original code.
Change 3476203 by David.Hill
Compute SSAO: problem wiht AmbientOcclusionLevels and with various viewporttest sizes. Only seen when Levels >=2
#jira UE-45741
Change 3476536 by Benjamin.Hyder
adding player start to Ray Traced Distance Field Shadows Map
Change 3478298 by Benjamin.Hyder
disabling mesh distance fields in Tm-Raytraced_DistanceField_Shadows map
Change 3478948 by Rolando.Caloca
DR - Nicer check
Change 3478949 by Rolando.Caloca
DR - Default GPU morphs to enabled
Change 3478950 by Rolando.Caloca
DR - By default -vulkan will launch SM5
Change 3478984 by Rolando.Caloca
DR - Pass down -vulkan
Change 3479655 by Richard.Wallis
Video track does not switch in AVF Media Player. Need to disable unused video tracks to allow AVPlayerItemVideoOutput to decode the required track.
- Minimal change to allow video track changes/selection.
- Audio samples are extracted using AVAssetReaderTrackOutput but video uses AVPlayerItemVideoOutput. Video could also use AVAssetReaderTrackOutput to access the video data unless there is an iOS reason not to...
- Flush the audio sink sample buffers so we get instant audio track changes
#jira UE-39750, UE-39749
Change 3479834 by Rolando.Caloca
DR - Fix issue with bad vertex colors (per licensee)
Change 3480376 by Guillaume.Abadie
Disables ComputeLightGrid() if no volumetric fog and no lighting.
#jira UE-45377
Change 3480596 by Yujiang.Wang
Fix for dynamic shadows and raytraced distance field shadows of directional lights not appearing in planar reflection
* Bug caused by incorrect shadow culling volumes for cascaded shadow map and backface culling mode for WholeSceneShadowProjection
* Fixed by taking View.bReverseCulling into account
#jira UE-34452
Change 3480600 by Yujiang.Wang
Fix for UE-42376
* The bug is caused by post-processing ambient cubemaps not being supported in forward shading currently.
* This fix replaces all the occurences of them in CalcSceneView with a skylight using the cubemap
* If a CalcSceneView is used solely for setting the PP ambient cubemap, it is removed.
#jira UE-42376
Change 3480784 by Rolando.Caloca
DR - hlslcc - Initial support for [RW]StructuredBuffer
Change 3481690 by Uriel.Doyon
Attempt to fix static analysis warning
Change 3482012 by Simon.Tovey
Fixed issue when building distribution lookup tables where the final sample fell short of the max input time.
As sampling is done only over this range, under constant interpolation the final value was never actually sampled and so cut from the final optimized LUT.
#tests constant interpolation now works.
#jira UE-45614
Change 3482965 by Yujiang.Wang
Some quality of life changes for UE-42757
* The UV overlay in static mesh editor now has a darker background
* Selected edges are getting highlighted and bolder
* When some edges are selected others turn grey
#jira UE-42757
Change 3483014 by David.Hill
Change labels on bloom boost from x,y,z to min, max, mult.
#jira UE-43904
a PropertyRedirect in BaseEngine.ini allows this to work with older version.
Change 3484573 by Yujiang.Wang
Fix for shadow color not updated after light build when a texture is changed and reimported
* Bug caused by counter-intuitive design of UMaterial::GetReferencedFunctionIds and UMaterial::GetReferencedParameterCollectionIds, both of which will reset the OutIds parameter
* Renamed to AppendReferencedFunctionIdsTo and AppendReferencedParameterCollectionIdsTo, the resets are removed
#jira UE-45647
Change 3484969 by Yujiang.Wang
Fix for UE-39929 inconsistent type between C++ and shader code
* MeshDistanceFieldCasterIndices is declared as Buffer<uint> in CapsuleShadowShaders.usf, while created as PF_R32_SINT in CapsuleShadowRendering.cpp
* Changed PF_R32_SINT to PF_R32_UINT in CapsuleShadowRendering.cpp
#jira UE-39929
Change 3485012 by Yujiang.Wang
Fix for UE-39929 #2: Changed int32 to uint32 to match PF_R32_UINT
#jira UE-39929
Change 3485146 by Guillaume.Abadie
Destroyes scene capture's view states on the UnRegister, to avoid large memory usage cause by the ViewState's render targets when moving blueprints arround.
#jira UE-43455
Change 3486602 by Joe.Conley
Adding "texcoord" keyword to UMaterialExpressionTextureCoordinate so you can search for the name that is displayed on the node in the graph.
Change 3487471 by Yujiang.Wang
Github #3659: Improved performance of DumpUnbuiltLightInteractions
* Replaced TArrays with TSets
#jira UE-45783
Change 3487641 by Guillaume.Abadie
Fixes some shader file name casing issues in LPV.
Change 3488014 by Uriel.Doyon
New AllowAsyncLoading flag for UTexture::CachePlatformData().
It allows to load the source texture data in the async task if the source bulk data was not yet loaded.
Data loaded that way is not sharable between tasks and will be discarded.
This is required because updating the source data is not thread safe.
#jira UERNDR-190
#jira UE-33401
Change 3488249 by Uriel.Doyon
Fixed long stall in UpdateResourceStreaming() caused by Actor.GetComponents() not resetting the number of actors anymore.
Fixed inconsistent results in ALODActor::HasValidSubActors() caused by the same change.
#jira UE-46004
Change 3490228 by Mark.Satterthwaite
Fix the Nvidia driver bug with the old reversebits fallback function - you need to use the native reverse_bits intrinsic or use some uint(ushort()) casts to get the compiler to do the right thing, which means injecting the reverse_bits function in MetalBackend not the HLSL (as it has no such type).
#jira UE-46067
Change 3490538 by Arne.Schober
Back out changelist 3488249
#RB none
Change 3490551 by Arne.Schober
Back out changelist 3488249
#RB none
Change 3491828 by Guillaume.Abadie
Fixes another USf file reference casing issue in C++.
Change 3491924 by Yujiang.Wang
Fix for UE-43302 Crash when entering the DebugCreatePlayer console command with planar reflections in the level
* Crash caused by check(Views.Num() <= 2); in SceneCaptureRendering.cpp
* We still want to support at most 2 views for performance, but now instead of crash the planar reflections in additional views will simply turn black
#jira UE-43302
Change 3492359 by Guillaume.Abadie
Fixes non editor launches, failing in FGenericPlatformProcess::AddShaderSourceDirectoryMapping().
Change 3492367 by Marc.Olano
Change Sobol texture size to 32x16, tweak distribution
Change 3492599 by Marcus.Wassmer
PR #3669: -Fix logmessages ParticleModules_Location.cpp (Contributed by UpwindSpring01)
Change 3493473 by Uriel.Doyon
Back out changelist 3490538
Change 3493590 by Uriel.Doyon
Back out changelist 3490551
Fixed missing #pragma once
Change 3493911 by Marcus.Wassmer
Fix potential GPU crash/hang caused by out of bound subresource updates.
Added checks at cross-platform level to catch any instance earlier.
Change 3494139 by Uriel.Doyon
Fixed shadow variable issue on UE4Editor Linux.
Change 3494364 by Richard.Wallis
Mac OpenGL Is No Longer Supported - Remove All Code & Shader Platforms - Part 2: Remove some more areas and fixes for previous attempt. Also removed OpenGL based GPU performance checks in EditorEngine.cpp - assuming that any GPU that can run Metal is currently OK for UE4.
OpenGL left in the following areas:
- OpenGLShaderCompiler
- StandaloneRenderer
The following files need to be reviewed in conjunction with CL 3471116 as there were some logic errors made:
- OpenGLTexture.cpp
#jira UE-39108
Change 3494413 by Guillaume.Abadie
Updates r.InvalidateCachedShader and bump ShaderVersion.ush.
Change 3494422 by Guillaume.Abadie
Adds LensDistortion plugin's Private shader directory.
Change 3494717 by Guillaume.Abadie
Strengthens shader compiler with checks on generated file names and shader type file names.
Change 3494763 by Guillaume.Abadie
Removes a nolonger standing TODO in GlobalBeginCompileShader() that was automatically adding /Engine/ prefix to all relative virtual shader source file path.
Change 3494985 by Rolando.Caloca
DR - Integrate Vulkan Rewrite
Change 3495031 by Rolando.Caloca
DR - Delete file as it moved
Change 3495032 by Rolando.Caloca
DR - Show Vulkan SM5 instead of SM4 on windows packaging
- Also added support for Vulkan SM5_UB
Change 3495202 by Uriel.Doyon
Fixed static analysis warning with pointer dereferencing.
Change 3495342 by Rolando.Caloca
DR - clang compile fix
Change 3495354 by Rolando.Caloca
DR - clang compile fixes
Change 3495420 by Marc.Olano
Use Sobol sampling for PCSS
Change 3495799 by Rolando.Caloca
DR - Delete old dev assets
Change 3496202 by Mark.Satterthwaite
Switch to using actual Vector*Matrix intrinsic for Metal to avoid a problem whereby the Metal compiler reorders operations in such a way that it loses precision and ends up being different between pre-pass and base-pass.
#jira UE-46070
Change 3496253 by Uriel.Doyon
Fixed static analysis warning for IncludeTool
Change 3496631 by Guillaume.Abadie
Makes AScreenshotFunctionalTest::ScreenshotOptions blueprint readable.
Change 3496851 by Guillaume.Abadie
Fixes back slash issues in Platform.usf.
Change 3496852 by Guillaume.Abadie
Fixes other back slashes includes in PS4 specific usf files.
Change 3496941 by Guillaume.Abadie
Adds a check() for no backslash in virtual shader file paths.
Change 3497661 by Guillaume.Abadie
Lets FLensDistortionCameraModel::GetUndistortOverscanFactor() early return 1.0 if the camera model is does an identity transform.
Change 3497969 by Richard.Wallis
Fix for start Up Movies Are not Playing for iOS Devices. Handle case when movie is loading aysnc in background - need to wait for state changes otherwise it skips intermediate movies.
- Tested on iOS and Mac.
#jira UE-39585
Change 3498035 by Guillaume.Abadie
Polishes //Engine/Plugins/Compositing/LensDistortion/Shaders/Private/UVGeneration.usf from debuging artifacts.
Change 3498101 by Rolando.Caloca
DR - Compile fix
Change 3498254 by Guillaume.Abadie
Exposes comparing FLensDistortionCameraModel to blueprint with == and != operator nodes for cross frame uv displacement map caching.
Change 3498264 by Guillaume.Abadie
Integrate 3267269: Implements SceneCaptureComponent2D::bCameraCutThisFrame
Change 3498371 by Yujiang.Wang
Fix for UE-46149 Planar Reflections display screenspace info when viewports are >2
* Prevent planar reflections being rendered when ViewIndex >= GMaxPlanarReflectionViews
* Now planar reflections in >2 viewports will fallback to other reflection methods (SSR, reflection captures)
#jira UE-46149
Change 3498409 by Rolando.Caloca
DR - Swap resolves
Change 3498410 by Guillaume.Abadie
Adds support for opacity output alpha for post process material when doing a draw material to render target.
Change 3498705 by Rolando.Caloca
DR - Add UID for debugging mem allocations
Change 3498759 by Marcus.Wassmer
No post processing in vertexcolor view mode
#jira UE-44704
Change 3498891 by Rolando.Caloca
DR - Minor Vulkan per frame allocator refactor in prep for changes
Change 3499206 by Rolando.Caloca
DR - Fix temp frame allocator OOM on Vulkan
#jira UE-45913
Change 3499319 by Rolando.Caloca
DR - Vulkan support for StorageBuffer
Change 3499339 by Rolando.Caloca
DR - Remove deprecated typedef
Change 3499400 by Rolando.Caloca
DR - Remove some RHICmdList deprecated functions
Change 3499422 by Rolando.Caloca
DR - Allow buffer transitions inside render passes
Change 3500370 by Rolando.Caloca
DR - Compile fix
Change 3500474 by Rolando.Caloca
DR - Fix static analysis
Change 3500517 by Guillaume.Abadie
Exposes r.PostProcessing.PropagateAlpha to the renderer settings.
Change 3500537 by Guillaume.Abadie
Fixes a bug where scene capture WorldToView matrix would get scale != 1 when scaling the scene capture actor in the world.
#jira UE-39389
Change 3501069 by Mark.Satterthwaite
Bring back temporary 4.16 fix for iOS 9 (CL #3425995) into Dev-Rendering for 4.17 as a real fix will need to wait for 4.18.
temporary fix for skewed textures on IOS 9
#jira UE-44468
Change 3501164 by Michael.Lentine
PR #3402: UE-43131: Format argument count not equal to actual arguments (Contributed by projectgheist)
Change 3501222 by Benjamin.Hyder
Checking in Tm_SobolNoise map
Change 3501612 by zachary.wilson
Adding testing content for RTDF shadows on planar reflections
Change 3501708 by Guillaume.Abadie
Break FPostProcessSettings into smallers structs.
Change 3501830 by Olaf.Piesche
#jira UE-39628; using fix proposed in UDN, will investigate further
Change 3501954 by Marcus.Wassmer
Duplicate 3480903
Light culling safety measures.
Change 3502032 by Mark.Satterthwaite
Fix generation of Metal precompiled headers for the bytecode compiler when using Xcode 9.
Change 3502118 by Uriel.Doyon
Fixed shader compilation issues.
Change 3502191 by Guillaume.Abadie
Implements Composure plugin to make compositing in UE4 easier.
Change 3502192 by Guillaume.Abadie
Implements Composure feature testing in EngineTests
Change 3502196 by Guillaume.Abadie
Creates a dependency of Composure plugin over LensDistortion plugin.
Change 3502213 by Arciel.Rekman
Fix for loading shaders on Linux (UE-46276).
Change 3502243 by Brian.Karis
Bent normal map support.
Multibounce AO.
Spherical Gaussian based specular occlusion.
Change 3502506 by Guillaume.Abadie
Fixes compilation failure in Composure with unity build.
Change 3502507 by Guillaume.Abadie
Fixes composure Set Pass with Render Target blueprint helper.
Change 3502510 by Guillaume.Abadie
Attempts to fix ComposureUtils.cpp compile errors.
Change 3502515 by Guillaume.Abadie
Some other composure failure fixes.
Change 3502545 by Guillaume.Abadie
Fixes some unity build related error in Composure.
Change 3502548 by Guillaume.Abadie
Fixes last missing includes in ComposurePostProcessPass.cpp
Change 3502672 by Guillaume.Abadie
Fixes linux warning in Composure.
Change 3502790 by Ryan.Brucks
float4 PseudoVolumeTexture: Fixed frame layout being a float instead of float2. Now works correctly with non-square frame layouts. Only called in custom nodes and calling with a float still functions properly so no old content will break.
Change 3502836 by Guillaume.Abadie
Propagates scene capture engine showflag changes from blueprint editor to the blueprint instances.
#jira UE-6810
Change 3503096 by Guillaume.Abadie
Resave a unversioned asset.
Change 3503228 by Yujiang.Wang
Fix for UE-45646 Dynamic Light placed inside of a Dynamic Static Mesh doesn't pass through the geometry
* Bug caused by bReflectiveShadowmap not being passed into SetViewFlagsForShadowPass
* Replaced the true with bReflectiveShadowmap
#jira UE-45646
Change 3503284 by Rolando.Caloca
DR - Fixed initial clear on rendertargets
- Added support for r.Vulkan.EnableValidation 1, 2, 3 & 4
- Dump the vulkan log into VS output log
- Added validation for layouts when using dump log
Change 3503545 by Arciel.Rekman
Fix black UI on Linux (UE-46333)
- Rebuilt hlslcc with clang 3.7.0. Whatever issues we're running in with newer clangs still seem to persist.
#jira UE-46333
Change 3503638 by Daniel.Wright
[Copy] Changed DynamicBentNormalAO back to fp16, as PF_FloatR11G11B10 was not enough precision and introduced banding
Change 3503787 by Marcus.Wassmer
Fix difference between gpu/cpu morph target application
Change 3503902 by Marcus.Wassmer
Roll back TAA refactor until we have time to look into the bad interaction with DOF.
Change 3503953 by Arne.Schober
DR - UE-46319 - borked Reflections: The resource transition needs to be in this weired place for PS4 and switch until we teach the interface to know about subresources.
#RB Marcus.Wassmer
Change 3504131 by Rolando.Caloca
DR - Maintain a cache of pipeline and descriptor set layouts
- Fix marker dump
Change 3504462 by Guillaume.Abadie
Fixes an assertion failure that was failing because compute light grid was not done, but the shader used where not necessarily using compute light grid results.
#jira UE-46277
Change 3504779 by Chris.Bunner
Potential static analysis fix.
#jira UE-46360
Change 3504950 by Marc.Olano
Allow Sobol material nodes & textures only if feature level is at least ES3.1
#jira UE-46334
#jira UE-46317
Change 3505035 by Daniel.Wright
Increased MaxSearchCount in GetShaderIncludes. The previous limit of 20 is now getting hit in BasePassPixelShader.usf, causing compiles to fail erroneously.
Change 3505386 by Daniel.Wright
GetShaderIncludes handles infinite recursion gracefully, needed by Metal causing BasePassTessellation.usf to include BasePassVertexShader.usf
Change 3505491 by Rolando.Caloca
DR - Fix crash on first frame of particles on modern APIs
Change 3505557 by Chris.Bunner
[Duplicate] Workaround for outdated shader map crash.
#jira UE-46061
Change 3506071 by Rolando.Caloca
DR - Vulkan fixes
- Fix copy out of bounds reading textures to CPU
- Defer event deletion
- Split validation for errors and warnings
- Skip validation error about attachment not used
Change 3506698 by Guillaume.Abadie
Fixes Composure alpha channel clobering and performance regression in bloom and tonemapper passes caused by scene capture API compatibility breakage brought by Fortnite merge.
Change 3506797 by Rolando.Caloca
DR - Fix static analysis
#jira UE-46428
Change 3506861 by Rolando.Caloca
DR - Fix crash due to layering violation
#jira UE-46424
#jira UE-46431
Change 3508098 by Rolando.Caloca
DR - Fix for Vulkan ES31 crash
- Fix for AMD ensure
Change 3508123 by Rolando.Caloca
DR - Disable occlusion queries on Vulkan to avoid flickering
- Fix for bad HZB & cube mips on Vulkan (now using RHIGenerateMips)
- Fix for decal blending
#jira UE-46376
Change 3509064 by Uriel.Doyon
Changing the logic arround generating an error when HasHadBulkDataCleared() so that it only triggers if the DDC are not found.
#jira UE-46427
Change 3509854 by Marc.Olano
Fix 2D Sobol gray code numbers.
Just changes some numbers in initialization tables, so no effect on existing tests or content.
Change 3509920 by Marcus.Wassmer
Fix LPV fastvram ensure
Change 3509937 by Rolando.Caloca
DR - Fix crash due to deleted viewport
#jira UE-46281
Change 3509988 by Marcus.Wassmer
Roll back part of Sobol fix to avoid full shader recompile for integration.
Change 3510255 by Rolando.Caloca
DR - Fix popup window ensure
#jira UE-46511
Change 3510646 by Marcus.Wassmer
fix ios compiles
Change 3511442 by Rolando.Caloca
DR - Change mesh simplification check to ensure/checkslow to unblock
#jira UE-46538
DONE!
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
CHANGES WITH MULTIPLE PLATFORMS!!! YOU MUST COPY THESE INTO THE OTHER ONES AS MAKES SENSE!!
XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
Change 3467095 by Guillaume.Abadie
Nukes all += TEXT(".usf")
#jira UE-45530
Change 3475084 by Guillaume.Abadie
Fixes compilation failure of the shader compiler on PS4 and XboxOne
Change 3477464 by Guillaume.Abadie
Fixes dumpshaderinfo that generate unecessary sub directory, breaking shell scripts.
Change 3494395 by Guillaume.Abadie
Moves all engine shader files into Public and Private directory, and introduce the .ush extensions for header file that do not contains entry points.
DONE!
[CL 3511602 by Marcus Wassmer in Main branch]
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3232283 on 2016/12/13 by Ben.Woodhouse
D3D12 - downgrade root signature size warning to a log following a discussion with Microsoft. There's not much we can actually do about it, and it's not relevant to all hardware
#jira UE-36999
Change 3232641 on 2016/12/13 by Mark.Satterthwaite
- Eliminate redundant state changes in MetalRHI in the state cache.
- Add a new debug level for setting buffers to nil prior to calls to set*Bytes so that the tool doesn't display incorrect data.
- Make testing for validation & statistics features use the same EMetalFeatures API as everything else for consistency.
- Cache the fallback depth-stencil texture in the state cache and ignore it for determining whether a pass can restart - if we are using this texture its contents are worthless anyway.
Change 3232661 on 2016/12/13 by Mark.Satterthwaite
Re-enable Metal SM5 & DFAO/DistanceFieldShadowing on Intel for 10.12.2 or later.
Change 3232759 on 2016/12/13 by Ben.Woodhouse
Fix memory leak on XB1 when calling GPURealloc with count of 0, suggested on UDN
https://udn.unrealengine.com/questions/326660/gpurealloc-leak.html
Change 3232803 on 2016/12/13 by Ben.Marsh
Add UT to the populate DDC job, and cook UT and Fortnite for Mac as well.
Change 3232836 on 2016/12/13 by Ben.Marsh
Split cooks to populate DDC into separate nodes for each platform. May help to reduce number of timeouts on remote VMs.
Change 3232974 on 2016/12/13 by Rolando.Caloca
DR - Refactor common code to UWorld::RecreateScene
#jira UE-36719
PR #2824
Change 3232976 on 2016/12/13 by Ben.Marsh
Add missing dependency on tools node for Mac cooks. Need to compile SCW first.
Change 3233289 on 2016/12/13 by Olaf.Piesche
Fixing potentially broken spot/point light fade with old content; initialize new properties properly
Change 3233811 on 2016/12/13 by Mark.Satterthwaite
Fix compiling QA-Material tessellation shaders that don't need to emit from Hull or sample in Domain the HSOut buffer which was confusing MetalBackend.
Change 3233854 on 2016/12/13 by Mark.Satterthwaite
More information about texture type validation errors in Metal.
Change 3234650 on 2016/12/14 by Rolando.Caloca
DR - vk - Fix bad aspect on depth cubemaps
Change 3234651 on 2016/12/14 by Rolando.Caloca
DR - vk - Fix for 32 bit crash on dump layer
Change 3234813 on 2016/12/14 by Guillaume.Abadie
Fixes texture mask static lighting when using GBuffer selective outputs.
#jira UE-39527
Change 3235047 on 2016/12/14 by Uriel.Doyon
Refactored HLOD texture streaming strategy to separate forced load from visibility.
Added an incremental update in the last stage of the texture streaming update load to clear any pending work.
Added an option "All" to the "BuildMateriaTexturelStreamingData" command to force rebuild everything.
Change 3235317 on 2016/12/14 by Uriel.Doyon
Removed timed primitives in the texture streaming since it was not used and there is now a fallback implementation in UPrimitiveComponent::GetStreamingTextureInfo.
Change 3235431 on 2016/12/14 by Rolando.Caloca
DR - Fix for Vulkan drawing black
Change 3236788 on 2016/12/15 by Mark.Satterthwaite
Fix 10.11.6 support (aka -nometalv2): the stencil view workaround necessitates a mid-render blit and the way things were setup resulted in the HasValidRenderTargets assert firing. Refactored the code to separate the concept or valid render-states in the cache from active render-states in the render-pass. Now it works as intended and will be needed for 4.15.
Change 3236850 on 2016/12/15 by Mark.Satterthwaite
Make changing the Metal Shader Version project setting prompt the user to restart for the changes to take effect.
#jira UE-39801
Change 3237002 on 2016/12/15 by Benjamin.Hyder
submitting updated TM-Shadermodels map
Change 3237312 on 2016/12/15 by Rolando.Caloca
DR - Change more macros to lambdas
Change 3237394 on 2016/12/15 by Mark.Satterthwaite
Add Metal-specific permutations of TBasePassHS - they affect the C++ definition on all platforms but are only cached or used on Metal - because the way we compile the combined VS+HS tessellation stage requires that the combined VS + HS HLSL code references the same resources, otherwise we get incorrect resouce bindings and subsequently fail to render properly. Long-term the Metal tessellation code will need to be refactored so that the vertex shader stage is emitted as a separate shader from the hull shader stage as this but will keep cropping back up and continue to complicate the engine.
#jira UE-39799
Change 3237490 on 2016/12/15 by Daniel.Wright
Fixed ULandscapeComponent::GetUsedMaterials
Change 3237597 on 2016/12/15 by Ben.Woodhouse
Disable timestamp queries on pre-Maxwell nvidia hardware. Local testing suggests that this is the major cause of instability in the UE4.14 release.
It's possible that we could be more targeted by only excluding Fermi and older hardware, but identifying fermi hardware by device ID is difficult in practice, since the range overlaps with Kepler.
Change 3237654 on 2016/12/15 by Daniel.Wright
Non-editor compile fix
Change 3238229 on 2016/12/16 by Rolando.Caloca
DR - Remove ExcludeRect from inner RHI Clear methods; ensure will happen if trying to use it
Change 3238236 on 2016/12/16 by Rolando.Caloca
DR - Compile fixes
Change 3238280 on 2016/12/16 by Marc.Olano
Small optimization to Lanczos-3 upsample shader code.
Change 3238321 on 2016/12/16 by Rolando.Caloca
DR - Compile fix
Change 3238331 on 2016/12/16 by Rolando.Caloca
DR - compile fix
Change 3238495 on 2016/12/16 by Marc.Olano
Replace TEA random number generator with PCG.
Was only used in #if-disabled reference rendering, but ldoes make better quality reference rendering when enabled.
Change 3238496 on 2016/12/16 by Marc.Olano
Tone mapping fix for OR-31752, cherry picked from Orion 3208273
Assumption that green is approximates luminance fails on red/blue HDR content, resulting in ugly black artifacts. Go back to luminance.
Change 3238520 on 2016/12/16 by Rolando.Caloca
DR - CIS Fix
Change 3238571 on 2016/12/16 by Rolando.Caloca
DR - CIS fix
Change 3238605 on 2016/12/16 by Daniel.Wright
Sharing IndirectLightingCacheTextureSampler samplers
Change 3238626 on 2016/12/16 by Daniel.Wright
Ray Traced Distance Field Shadow optimizations
* Tighter light space tile culling
* Skip ray marching pixels before the RTDF cascade near distance, or further than the cascade far distance
* Depth bounds test on upsample
* Created FLightTileIntersectionParameters for encapsulation of light tile culling functionality
* RTDF shadow time went from 1.8ms -> .8ms and 3.1ms -> 1.2ms in FortGPUTestbed on 7870 with these changes
Change 3238652 on 2016/12/16 by Rolando.Caloca
DR - RHI clear methods no longer have an ExcludeRect, use DrawClearQuad functions instead
Change 3238855 on 2016/12/16 by Rolando.Caloca
DR - Added FRHITexture2D GetSizeXY
Change 3238881 on 2016/12/16 by Rolando.Caloca
DR - CIS fix
Change 3239008 on 2016/12/16 by Arne.Schober
DR - Fixing accidently returning a stackpointer in EnqueueRenderCommands
Change 3239012 on 2016/12/16 by Arne.Schober
DR - missing file
Change 3239255 on 2016/12/17 by Rolando.Caloca
DR - Remove shader clears from D3D11
Change 3239690 on 2016/12/19 by Rolando.Caloca
DR - vk - Misc fixes from 1.0.37.00 SDK warnings
Change 3239964 on 2016/12/19 by Rolando.Caloca
DR - Fix click on editor not showing selected
Change 3239995 on 2016/12/19 by Rolando.Caloca
DR - Enable dist field on GL4 & Vulkan SM5
Change 3240162 on 2016/12/19 by Daniel.Wright
Added EnableDepthBoundsTest / DisableDepthBoundsTest to RHIUtilites to share some common code
Change 3240163 on 2016/12/19 by Daniel.Wright
Distance field self shadowing controls for hiding world position offset self-shadow artifacts
* Removed static mesh build settings DistanceFieldBias, which shrunk the distance field, breaking AO and shadows
* Added DistanceFieldSelfShadowBias, which prevents occlusion close to the surface only, maintaining shadows on the ground and AO on the ground
Change 3240271 on 2016/12/19 by Daniel.Wright
Use 16 bit indices for distance field objects culled to tiles, when 16 bit will be enough. Saves 10mb of tile culling buffers.
Change 3240282 on 2016/12/19 by Rolando.Caloca
DR - Proper fix for hit proxies clear
- Added missing stencil ref to DrawClearQuad
Change 3240316 on 2016/12/19 by Rolando.Caloca
DR - vk - Fixed some new 1.0.37.0 warnings
Change 3240354 on 2016/12/19 by Rolando.Caloca
DR - Dev shaders on sm4/5
Change 3240759 on 2016/12/20 by Rolando.Caloca
DR - Fix bad crc on GL element declarations
Change 3240895 on 2016/12/20 by Rolando.Caloca
DR - vk - Swapchain fixes
Change 3241057 on 2016/12/20 by Rolando.Caloca
DR - vk - Fix resize on desktop
Change 3241112 on 2016/12/20 by Rolando.Caloca
DR - vk - Fix 1.0.37.0 warnings
- Ignore some warnings we know we can't fix
Change 3241310 on 2016/12/20 by Rolando.Caloca
DR - vk - Fix crash
Change 3241417 on 2016/12/20 by Daniel.Wright
[Copy] Fixed race condition with FPrecomputedLightVolume::Data which was exposed when switching lighting scenarios
Change 3241990 on 2016/12/21 by Daniel.Wright
Converted DistanceFieldVolume data to BulkData
* FDistanceFieldVolumeData Serialize time from .7s on PS4 to 0s
Change 3242005 on 2016/12/21 by Daniel.Wright
Removed unused !USE_DEPTH_RANGE_LISTS path to reduce complexity
Change 3242295 on 2016/12/21 by Bob.Tellez
Duplicating CL#3242294 from //Fortnite/Main
#UE4 Re-applying the fix for rendering editor primitives when r.EarlyZPassOnlyMaterialMasking is enabled
Change 3242487 on 2016/12/21 by Marcus.Wassmer
Fix typo
Change 3243091 on 2016/12/22 by Daniel.Wright
Fixed too many groups dispatched for TConeTraceScreenGridGlobalOcclusionCS
Change 3243161 on 2016/12/22 by Uriel.Doyon
New async tasks for the streaming update. Optimizing the biggest frame cost.
Change 3243179 on 2016/12/22 by Uriel.Doyon
Fixed possible invalid access from the async FNormalizeLightmapTexelFactorTask
Change 3243236 on 2016/12/22 by Daniel.Wright
Fixed DFAO bilateral upsample
* Depth buffer was being unbound due to lack of DepthRead_StencilNop
Change 3243452 on 2016/12/23 by Ben.Woodhouse
Bring back 1024 render query limit workaround on D3D12 which was lost during the merge from partners
#jira UE-35247
Change 3243512 on 2016/12/23 by Uriel.Doyon
Improved task system for texture streaming.
Change 3243742 on 2016/12/26 by Rolando.Caloca
DR - vk - Fix UAV clears
- Removed old validation layer
- Print found device layers
Change 3243745 on 2016/12/27 by Rolando.Caloca
DR - vk - Fix for texture cube arrays
- Warning for ClearUAVs
Change 3243762 on 2016/12/27 by Rolando.Caloca
DR - vk - Always use pipeline cache
Change 3244450 on 2016/12/31 by Rolando.Caloca
DR - vk - Pre reqs for separate transfer queue
Change 3244453 on 2016/12/31 by Rolando.Caloca
DR - vk - Win32 compile fix
Change 3244756 on 2017/01/03 by Marcus.Wassmer
Copying //Tasks/UE4/Dev-Niagara@3244743 to Dev-Rendering (//UE4/Dev-Rendering)
Change 3244757 on 2017/01/03 by Marcus.Wassmer
Niagara is still experimental in non-task branches.
Change 3245059 on 2017/01/03 by Benjamin.Hyder
Submitting TM-TrigNodes map
Change 3245500 on 2017/01/03 by Olaf.Piesche
Compile fix#1 for post-merge problems
Change 3245572 on 2017/01/03 by Olaf.Piesche
(Speculative) fix#2 for post-merge build problem. Hopefully fixes public distribution level error for cross compiler tool.
Change 3245683 on 2017/01/03 by Marcus.Wassmer
Fix some niagara warnings
Change 3245732 on 2017/01/03 by Marcus.Wassmer
Fix Niagara compile on clang platforms.
Fix a few warnings / static analysis things as well.
Change 3246403 on 2017/01/04 by Rolando.Caloca
DR - vk - Fix bogus warning
Change 3246432 on 2017/01/04 by Marcus.Wassmer
Copying //Tasks/UE4/Dev-Niagara@3246424 to Dev-Rendering (//UE4/Dev-Rendering)
Change 3246538 on 2017/01/04 by Rolando.Caloca
DR - vk - Show hitch time for compute psos
Change 3246580 on 2017/01/04 by Rolando.Caloca
DR - vk - compile fix
Change 3246610 on 2017/01/04 by Rolando.Caloca
DR - Compute PSO pre reqs
Change 3246707 on 2017/01/04 by Marcus.Wassmer
Add missing integer operations to UnrealMathDirectX.h
Change 3246786 on 2017/01/04 by Marcus.Wassmer
Avoid public dependency build errors. Should probably just remove the DDCUtils module instead
Change 3246828 on 2017/01/04 by Olaf.Piesche
UE-39249; need to check the view as well as the view family in CheckAndUpdateLastFrame; scene captures use a different family, but each eye for VR uses a different scene view.
Change 3247026 on 2017/01/04 by Rolando.Caloca
DR - Remove CrossCompilerTool as it's not required anymore
Change 3247086 on 2017/01/04 by Marcus.Wassmer
Remove includes for Core.h monolithic header
Change 3247227 on 2017/01/04 by Marcus.Wassmer
Fix typo and compile errors.
Change 3247228 on 2017/01/04 by Marcus.Wassmer
Use crossplatform intrinsics
Change 3247229 on 2017/01/04 by Marcus.Wassmer
Implement missing integer NEON operations.
Change NEON vectorint to match name and sign from other platforms
Change 3247245 on 2017/01/04 by Marcus.Wassmer
Fixing various warnings/errors from clang platforms (Mac/Linux)
Change 3247331 on 2017/01/04 by Marcus.Wassmer
More Mac/clang fixes
Change 3247958 on 2017/01/05 by Marcus.Wassmer
VectorInt < - > Float ops should be conversions not reinterpret cast
Change 3247959 on 2017/01/05 by Marcus.Wassmer
Add missing ops to non-vector header
Change 3247964 on 2017/01/05 by Rolando.Caloca
DR - Temp fix for crash
#jira UE-40211
Change 3248067 on 2017/01/05 by Rolando.Caloca
DR - Static analysis fixes
#jira UE-40167
Change 3248284 on 2017/01/05 by Rolando.Caloca
DR - Linuix Compile fix
#jira UE-40260
Change 3248288 on 2017/01/05 by Rolando.Caloca
DR - Linux compile fix
#jira UE-40264
Change 3248399 on 2017/01/05 by Brian.Karis
Filtered importance sampling for envmap prefiltering.
Fixed SSR on clearcoat with skylight only.
Change 3248503 on 2017/01/05 by Rolando.Caloca
DR - Linux fixes
#jira UE-40264
Change 3248666 on 2017/01/05 by Brian.Karis
Fix GL compile error
Change 3248740 on 2017/01/05 by Marcus.Wassmer
Fix linux and clang errors/warnings
Change 3248851 on 2017/01/05 by Marcus.Wassmer
Simplest fix for ES2 compile errors
Change 3249217 on 2017/01/06 by Simon.Tovey
Speculative fix for static analysis warning
Change 3249296 on 2017/01/06 by Ben.Woodhouse
XB1/Fast semantics:
Add missing L1/L2 cache flush on transition to readable (or RW). The missing cache flush was causing indeterminism when reading from a texture shortly after writing to it as a render target.
This fixes bloom and diffuse irradiance issues
The bug has been there for a while, but CL 3227787 (drawclear early out) caused it to manifest
#jira UE-39727
#jira UE-40238
Change 3249300 on 2017/01/06 by Ben.Woodhouse
Remove workaround for diffuse irradiance (redundant clear). No longer necessary with CL 3249296
Change 3249387 on 2017/01/06 by Rolando.Caloca
DR - Fix GL clear issues
#jira UE-40254
Change 3249435 on 2017/01/06 by Ben.Woodhouse
Duplicated from UT CL 3238664
Fix dbuffer decal rendering issues in fullscreen on PC. Also fixes crash in editor when viewing dbuffer materials.
Pass clearcolor in RT params for system textures to workaround a bug with ClearColorTexture not working in fullscreen mode on DX11. Make sure dbuffer targets are bound if we're rendering mesh decals
#jira UT-6891
#jira UE-39842
Change 3249721 on 2017/01/06 by Marcus.Wassmer
Remove final references to non-existent Niagara data
Change 3249742 on 2017/01/06 by Marcus.Wassmer
Fix missing GPU particles on Mac.
Pointers getting reused is causing the blendstate equality operator to fail.
Simple workaround until we have time for a proper fix.
[CL 3249983 by Marcus Wassmer in Main branch]
dan elksnitis
Marc Audy
arciel rekman
Rolando Caloca
ryan durand
Marcus Wassmer
Matt Collins
Ben Marsh
shaun kime
projectgheist
Andrew Grant