Commit Graph

8227 Commits

Author SHA1 Message Date
robert millar
ae588565e0 Early out when a localization target with no loc files is added.
#rb jamie.dale

[CL 27898057 by robert millar in ue5-main branch]
2023-09-14 18:04:04 -04:00
daniele vettorel
62fe4290b0 Add GPU breadcrumbs information into crash reports.
* Breadcrumbs are processed into a common data structure used to dump the contents to the log and also used by the crash reporting routines to format breadcrumbs into the crash report file.
* The format used by the crash report is versioned so that parsers know what to expect if the format ever changes. The format is specifically written for automated parsing - the human-readable dump stays in the log.
* A (per-queue) hash of the full breadcrumbs stack and a separate hash for the active subset are computed and stored in the crash report.
* The existing string dumped to the log is unchanged.

Example of the new crash report section:
<GPUBreadcrumbs>
	<FormatVersion>1.0</FormatVersion>
	<Queue>
		<Name>3D Queue 0</Name>
		<FullHash>D02D1A942643A9C549606769037ED96B52104742</FullHash>
		<ActiveHash>4DE9A4E81D71A1993E939D82A1C3ED063B6F6E7C</ActiveHash>
		<Breadcrumbs>{{Frame 2540},A,{{{BufferPoolCopyOps},F},{{TexturePoolCopyOps},F},{{WorldTick},F},{{SendAllEndOfFrameUpdates},F},{{GPUDebugCrash_DirectQueue_Hang},A},{{ClearGPUMessageBuffer},A},{{VirtualTextureClear},N},{{ShaderPrint::UploadParameters},N},{{UpdateDistanceFieldAtlas},N},{{Scene},N},{{EnqueueCopy(GPUMessageManager.MessageBuffer)},N},{{AccessModePass[Graphics] (Textures: 7, Buffers: 6)},N},{{SlateUI Title = Test Application },N}}}</Breadcrumbs>
	</Queue>
	<Queue>
		<Name>Compute Queue 0</Name>
		<FullHash>1DC8AED3D68A1B4DC2719B9D94F3EFBE16E8E371</FullHash>
		<ActiveHash>DA39A3EE5E6B4B0D3255BFEF95601890AFD80709</ActiveHash>
		<Breadcrumbs>{{AccessModePass[AsyncCompute] (Textures: 4, Buffers: 2)},F}{{Scene},F}{{AccessModePass[AsyncCompute] (Textures: 4, Buffers: 2)},F}{{Scene},F}{{AccessModePass[AsyncCompute] (Textures: 4, Buffers: 2)},F}{{Scene},F}{{AccessModePass[AsyncCompute] (Textures: 4, Buffers: 2)},F}{{Scene},N}{{AccessModePass[AsyncCompute] (Textures: 4, Buffers: 2)},N}</Breadcrumbs>
	</Queue>
</GPUBreadcrumbs>

[CL 27884877 by daniele vettorel in ue5-main branch]
2023-09-14 13:09:08 -04:00
robert millar
387bb0bd06 Add ability to presize name table in editor for large projects.
Example config in Editor.ini:

[Names]
PreallocateNames=10485760
PreallocateNameMemoryMB=900

#rb ben.zeigler

[CL 27883674 by robert millar in ue5-main branch]
2023-09-14 12:46:21 -04:00
johan berg
ea1c4720e2 Reenable auto-start of UnrealTraceServer on Mac
#rb ionut.matasaru
#jira UE-188183

[CL 27883401 by johan berg in ue5-main branch]
2023-09-14 12:42:43 -04:00
chris constantinescu
4e93516a90 Remove extra line
#rnx

[CL 27880031 by chris constantinescu in ue5-main branch]
2023-09-14 11:22:41 -04:00
chris constantinescu
754e83523b Revert debug logging in UnixPlatformOutputDevices.cpp
#rb Brandon.Schaefer

[CL 27879498 by chris constantinescu in ue5-main branch]
2023-09-14 11:10:11 -04:00
lorry li
cf982f098f Log platform, device id and machine id when startup.
[REVIEW] [at]michael.atchison [at]chris.applegarth
#rb [at]michael.atchison

[CL 27865351 by lorry li in ue5-main branch]
2023-09-13 22:30:45 -04:00
jamie dale
932fd6b197 Added a CVar to control whether locales use their CLDR specified digit characters, or whether they should always use Arabic digit characters (eg, 1234)
This can be controlled via "Localization.UseLocaleSpecificDigitCharacters" and defaults to True to preserve the current behavior

#jira
[FYI] Kevin.Shen

[CL 27852750 by jamie dale in ue5-main branch]
2023-09-13 17:36:07 -04:00
steve robb
3cccdde2da Moved code out of generic string .inl files that we don't want to be generic (yet?).
#rb devin.doucette
#jira UE-194628

[CL 27837674 by steve robb in ue5-main branch]
2023-09-13 13:05:04 -04:00
steve robb
e8b2d6304a Moved string code into .inl files in anticipation of the upcoming FUtf8String change.
#rb devin.doucette
#jira UE-194628

[CL 27832174 by steve robb in ue5-main branch]
2023-09-13 11:11:38 -04:00
rune stubbe
45018186fd Fix for Nanite builder not handling empty submeshes correctly. It now outputs a single node with no children, instead of duplicating a cluster.
FResources::NumClusters now reflects the number of clusters after trim, not before.
#rb brian.karis
[FYI] graham.wihlidal, jamie.hayes

[CL 27830347 by rune stubbe in ue5-main branch]
2023-09-13 10:24:12 -04:00
andriy tylychko
c8d32b6b0b Custom cross-platform dynamic TLS implementation because we hit OS TLS slot limit on many platforms. compile-time defined num slot limit.
Allocating and freeing slots can be contended, getting and setting a slot value is fast but has an additional indirection compared with OS TLS. Used only for windows editor for now, because it's a bit slower than OS TLS implementation.

#rb dmytro.vovk, francis.hurteau

[CL 27827939 by andriy tylychko in ue5-main branch]
2023-09-13 09:25:27 -04:00
steve robb
a769bda86a Fixes for static analysis false positives.
#rb andriy.tylychko
[FYI] robert.millar

[CL 27824599 by steve robb in ue5-main branch]
2023-09-13 06:18:35 -04:00
steve robb
51f3ea53ae Removed ChooseClass.h includes.
#rb trivial

[CL 27823723 by steve robb in ue5-main branch]
2023-09-13 05:43:01 -04:00
steve robb
a398665058 CHARTEXT(CharType, x) which expands out to x, TEXT(x) or UTF8TEXT(x) depending on CharType.
#rb robert.millar
#jira UE-194628

[CL 27818547 by steve robb in ue5-main branch]
2023-09-12 21:06:52 -04:00
steve robb
da9f5a828a Replaced TChooseClass with std::conditional_t.
#rb none
#jira UE-195271

[CL 27816205 by steve robb in ue5-main branch]
2023-09-12 19:55:55 -04:00
catalin dragoiu
36583085d6 [Insights] Add a new persistent setting "Auto Connect" to the Session Browser page that controls if the Editor and Game should auto connect and start tracing if Insights Session Browser is open.
#jira UE-194404
#rb Ionut.Matasaru

[CL 27801419 by catalin dragoiu in ue5-main branch]
2023-09-12 14:32:03 -04:00
jeremy moore
d4180f5434 Reduce default file cache size used by virtual texturing. Add profiling to track file cache usage.
[CL 27788112 by jeremy moore in ue5-main branch]
2023-09-12 08:20:40 -04:00
sebastian arleryd
f618e67a9c Add CVAR to move Mac main menu into UE window
* Add the Mac-only CVAR Slate.MacMainMenuInsideUnrealWindow (ignored on other platforms). When it's false (default) there should be no user-visible difference. When true, Slate will draw (most of) the main menu inside the Unreal windows instead of using the macOS system main menu bar at the top of the screen.
* Expose the value of the CVAR via a new function FPlatformMisc::CanShowMenusInWindows(). This always returns true on non-Mac platforms.
* Remove unused code in SDockingTabStack.cpp.
* Improve spacing between tabs and close/min/max buttons in the title bar of smaller windows on the Mac.

#jira UE-186873

[CL 27759699 by sebastian arleryd in ue5-main branch]
2023-09-11 13:18:04 -04:00
stan hormell
37bad2d07b [Backout] - CL27731288 - CIS / Build Errors
[FYI] Josh.Adams
Original CL Desc
-----------------------------------------------------------------
- Deprecated GetSectionPrivate and FindOrAddSection, and accessors in FConfigFile that could return a non-const FConfigSection (this is so we can track modifications to config values)
- Added AddToSection, RemoveKeyFromSection, etc to replace directly accessing a FConfigSection
- Fixed up Epic code for the deprecations (at least the majority, some projects that aren't built by Horde presubmit may have some that we will address going forward)
#jira UE-194955
#rb david.harvey and various others

[CL 27745141 by stan hormell in ue5-main branch]
2023-09-10 22:58:21 -04:00
josh adams
a8a9a0b759 - Deprecated GetSectionPrivate and FindOrAddSection, and accessors in FConfigFile that could return a non-const FConfigSection (this is so we can track modifications to config values)
- Added AddToSection, RemoveKeyFromSection, etc to replace directly accessing a FConfigSection
- Fixed up Epic code for the deprecations (at least the majority, some projects that aren't built by Horde presubmit may have some that we will address going forward)
#jira UE-194955
#rb david.harvey and various others

[CL 27731364 by josh adams in ue5-main branch]
2023-09-08 17:58:55 -04:00
lorry li
ebcf0d74da Fix the issue the boot hotfix file doesn't get loaded in shipping version;
Only load from boot hotfix file for CVars which has flag ECVF_SaveForNextBoot.

Reason: Engine has more restriction on loading .ini file.

[REVIEW] [at]michael.atchison [at]michael.kirzinger
#rb [at]michael.atchison
#test Tried in Shipping version on console

[CL 27724564 by lorry li in ue5-main branch]
2023-09-08 15:50:42 -04:00
anton dunchev
c916d24013 MB2 Allocator optimizations.
- Removed extra page allocation for VMA pool header.
- Added VMA pool stats reporting.
- Removed extra lock per pool (was not used).
- Scale factor parameter is configurable via compile-time definition.

#rb [at]dmytro.vovk
[FYI] [at]mickael.gilabert, [at]dmytro.vovk, [at]johan.torp, [at]chris.babcock
#tests replays

[CL 27719144 by anton dunchev in ue5-main branch]
2023-09-08 13:53:09 -04:00
Brian Karis
a622f52036 Added LerpUVs property to Nanite static mesh settings.
Enabled by default. When disabled UVs are not lerped in the simplifier. This is useful when data stored in UVs isn't valid to interpolate, for example indexes.

Fixed long standing bug where locked boundary verts still would get attributes recalculated when taking part in an edge collapse. This results in them not matching when later merged with their neighbor, causing attribute discontinuities where they previously weren't. That will degrade further simplification, bloat vertex work, bloat vertex storage, and generally look worse.

Can reduce rendered vertex count by 14% and disk size by 3%.

#rb rune.stubbe, graham.wihlidal
#lockdown marc.audy

[CL 27715715 by Brian Karis in ue5-main branch]
2023-09-08 12:38:58 -04:00
joe barnes
6b59a226fb [Switch] Fix for no callback on exceptions in retail kits. Make some basic calls so we get the info we need when the thread hang detector triggers.
#rb brian white

[CL 27715064 by joe barnes in ue5-main branch]
2023-09-08 12:23:44 -04:00